[aarch64-port-dev ] RFR(M): 8243392: Remodel CDS/Metaspace storage reservation

[coleen.phillimore at oracle.com]

Hi, I have no more comments.  It all looks good to me.  I think we're 
waiting for Ioi to run through CI and he might have a comment on the 
check_SharedBaseAddress change which seems reasonable to me. I like that 
it's not in arguments.cpp.  Too much dispersion of knowledge to 
arguments.cpp.

http://cr.openjdk.java.net/~stuefe/webrevs/rework-cds-ccs-reservation/webrev.03/webrev/src/hotspot/share/runtime/arguments.cpp.udiff.html

You may not need this change anymore.

Thanks,
Coleen


On 5/19/20 6:06 AM, Thomas Stüfe wrote:
>
>
> On Tue, May 19, 2020 at 11:26 AM Andrew Haley <aph at redhat.com 
> <mailto:aph at redhat.com>> wrote:
>
>     Hi,
>
>     In general, please wrap comment lines at 80 characters. Some of
>     these lines
>     are too long to read.
>
>
> okay.
>
>
>     On 5/7/20 3:21 PM, Thomas Stüfe wrote:
>
>
>     +  // Note: on AARCH64, if the code above does not find any good
>     placement, we
>     +  // have no recurse. We return an empty space and the VM will exit.
>        return ReservedSpace();
>
>     Spelling: "we have no recourse"
>
>
> Will fix.
>
>     +    // We do this by reserving space for the ccs behind the
>     archives. Note however that
>
>     Should be "below the archives", surely? Or is that "above"? Which
>     is it?
>
>
> Above. Will fix.
>
>
>     +  bool use_requested_base = true; // Whether to use
>     SharedBaseAddress as attach point.
>
>     What exactly is an "attach point" ? The phrase is used few times in
>     comments but never defined.
>
>
> Attach address. I'll clarify the comments.
>
>     +//      class space according to CompressedClassSpaceSize. Its
>     start address will be aligned to etaspace::reserve_alignment
>
>     "Metaspace"
>
>
> Thanks for looking this over Andrew. I'll wait for Coleens feedback 
> and will post an update.
>
> ..Thomas
>
>     -- 
>     Andrew Haley  (he/him)
>     Java Platform Lead Engineer
>     Red Hat UK Ltd. <https://www.redhat.com>
>     https://keybase.io/andrewhaley
>     EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671
>