[aarch64-port-dev ] [jdk11u] 8253947: Implementation: JEP 388: Windows AArch64 Support

[Anton Kozlov]

Hi,

Adding jdk-updates, where jdk11u is developed. 

In general, it looks it clearly falls into the category of changes worth backporting[1] (although written for jdk8u)
> New features should not generally be back-ported to 8u, except where it is necessary to adapt OpenJDK to new computing environments. For example, [...] ports to new hardware or operating systems [might qualify]. These are necessary for JDK 8u to remain relevant.

Process-wise, you don't need to create backports, this is done automatically by a push hook on the HG repo. You need to commit changes under the same bug IDs that were used for integration into the mainline. [2]

IMHO, to simplify reviewing (I'm not a reviewer, just expressing what I would find beneficial), it may be useful to split the patch into two. One patch for changes that carry the risk for an existing jdk11u functionality, including support of other operating systems. Another patch for the the new platform support only, like a new file or an extra #ifdef that is turns to nothing on the rest of the platforms. The second patch review could then be reduced to ensure it actually does not harm.

Thanks,
Anton

[1] https://mail.openjdk.java.net/pipermail/jdk8u-dev/2020-June/012002.html
[2] https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix

On 02.10.2020 22:49, Ludovic Henry wrote:
> Hi,
> 
> As we are getting closer to merge JEP 388 (Windows/AArch64 Port), I wanted to share the work I've done for the backport to JDK 11.
> 
> This email is not an RFR as the webrev is not finalized yet (the JEP implementation hasn't landed on JDK tip). I'm sharing it just to give an idea of the work which will be required, what kind of changes we are facing, and for other parties who have expressed interest in this backport. I'll keep updating it as we get reviews on [1].
> 
> Once we've landed the JEP implementation into JDK tip, I'll create the appropriate bug IDs for all the necessary backports, and contact the relevant mailing lists with the different webrevs and JBS.
> 
> I've tested this change on Windows-AArch64 against hotspot:tier1, jdk:tier1 and langtools, but not yet on Linux-AArch64.
> 
> Webrev: http://cr.openjdk.java.net/~luhenry/8253947/webrev.00/
> 
> Thank you,
> Ludovic
> 
> [1] https://github.com/openjdk/jdk/pull/212
>