[aarch64-port-dev ] [16] RFR(S): 8251525: AARCH64: Faster Math.signum(fp)

[Dmitry Chuyko]

Hi David,

Technically the review went entirely on hotspot-compiler-dev from the 
start in August [1] until integrated in September [2]. However at some 
point [3] email subjects got extra aarch64 port mention which I agree 
may be confusing.

For aarch64 part I got review from Andrew Haley.

For shared code changes I got extra review from Vladimir Ivanov.

I apologize again for the insufficient testing as there are issues with 
both jdk/submit and our internal CI.

The test failed after the change is a common one. I had better to wait 
for dev-submit to restore and to run more tests locally.

-Dmitry

[1] 
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-August/039495.html

[2] 
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-September/039863.html

[3] 
http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2020-August/039523.html

On 9/4/20 3:50 PM, David Holmes wrote:
> Hi Dmitry,
>
> This change included changes to shared code and should have been 
> reviewed on the main hotspot mailings list from the start not just 
> aarch64-port-dev. As Aarch64 is a mainline OpenJDK port it is 
> questionable whether aarch64-port-dev should be used for any code 
> reviews that relate to mainline.
>
> David
> -----
>
> ............