[aarch64-port-dev ] [8u] RFR: Revert differences against upstream 8u

[Aleksey Shipilev]

On 2/18/21 7:41 PM, Andrew Hughes wrote:
> On 19:30 Thu 18 Feb     , Aleksey Shipilev wrote:
>> changeset:   8867:af37ee789a9c
>> user:        aph
>> date:        Thu May 05 14:14:21 2016 +0000
>> summary:     AArch64 support for Shenandoah.
> 
> Right, upstream has '%' because it's the pre-Shenandoah sources.
> It was later removed in aarch64/shenandoah-jdk8u:
> 
> https://hg.openjdk.java.net/aarch64-port/jdk8u-shenandoah/hotspot/rev/af37ee789a9c#l10.14
> 
> Removing it is the right thing, no?

I don't see how.

8u upstream has it with "%":
 
http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/file/3d2970e26c36/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp#l1723

...and it still has "%r0" in the line that is not affected by Shenandoah at all:
 
http://hg.openjdk.java.net/jdk8u/jdk8u/hotspot/file/3d2970e26c36/src/cpu/aarch64/vm/sharedRuntime_aarch64.cpp#l1744

...and the same shape remains thorough JDK 11 -> JDK 17.

It is a typo in the initial Shenandoah 8u sources, plain and simple, should be reverted to upstream 
state. Moreover, this is a _comment line_, it does not even affect the product code.

-- 
Thanks,
-Aleksey