[aarch64-port-dev ] RFR: Fix AArch64 build failure after JDK-8062808 backport

[Andrew Haley]

On 1/4/21 9:27 AM, Aleksey Shipilev wrote:
> So, a trivial fix is to put in the missing addition:
> 
> diff -r 76dace090781 src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp
> --- a/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp    Tue Dec 15 20:18:10 2020 +0100
> +++ b/src/cpu/aarch64/vm/c1_LIRAssembler_aarch64.cpp    Mon Jan 04 04:24:42 2021 -0500
> @@ -207,6 +207,7 @@
>         return Address(base, tmp, Address::lsl(addr->scale()));
>       }
>     }
> +  return Address();
>   }

Ah, another bad code change caused by a bogus compiler diagnostic. (Not the
compiler's problem, it's because we don't mark ShouldNotReachHere() as
not returning.

OK, but there really should be a ShouldNotReachHere() or equiv before

> +  return Address();

-- 
Andrew Haley  (he/him)
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
https://keybase.io/andrewhaley
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671