[aarch64-port-dev ] RFR: Merge jdk:master [v2]
Anton Kozlov
akozlov at openjdk.java.net
Fri Jan 22 17:07:05 UTC 2021
On Fri, 22 Jan 2021 15:32:49 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:
>> Thanks for checking! Good point, I haven't looked at the test results closely for some time.
>>
>> Gtest failures are probably caused by the missing `--with-gtest` configure parameter. I've checked them, they are passing before and after merge on linux/aarch64
>>
>> runtime/CompressedOops/CompressedClassPointers.java has a lot of guards for various systems, it seems we miss one for macos/aarch64
>>
>> compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java is interesting, especially since we don't support JVMCI :) It looks like a test bug, it should not run on mac
>>
>> I will make a PR with the JEP implementation and will look at these tests while the review is going.
>
>> Gtest failures are probably caused by the missing `--with-gtest` configure parameter. I've checked them, they are passing before and after merge on linux/aarch64
>
> Indeed! I missed `--with-gtest` on Linux.
>
>> compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java is interesting, especially since we don't support JVMCI :) It looks like a test bug, it should not run on mac
>
> It does work in principle though:
> $ ./build/macosx-aarch64-server-release/images/jdk/bin/java -XX:+UnlockExperimentalVMOptions -XX:+UseJVMCICompiler -XX:+BootstrapJVMCI -version
> Bootstrapping JVMCI............................... in 8410 ms (compiled 3128 methods)
> openjdk version "17-internal" 2021-09-14
> OpenJDK Runtime Environment (build 17-internal+0-adhoc.lewurm.aarch64-port)
> OpenJDK 64-Bit Server VM (build 17-internal+0-adhoc.lewurm.aarch64-port, mixed mode)
>
> I kind of sneaked in macOS support in my PR for Windows+AArch64: https://github.com/openjdk/jdk/pull/685
> [ JVMCI ] does work in principle though:
Hmm, that was unexpected :) Based on the test, JVMCI calling convention is broken. I'll check how much efforts would it require to fix the test
-------------
PR: https://git.openjdk.java.net/aarch64-port/pull/12
More information about the aarch64-port-dev
mailing list