[aarch64-port-dev ] RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port

[Bernhard Urban-Forster]

On Wed, 5 Jan 2022 14:10:56 GMT, Bernhard Urban-Forster <burban at openjdk.org> wrote:

>> Backport of JEP-391 to jdk11u-dev
>> The PR has two commits, one is simple copy of linux_aarch64 to bsd_aarch64. This will allow to see the difference applied to os_cpu against linux_aarch64 version.
>> 
>> Total issues:
>> JDK-8253795: Implementation of JEP 391: macOS/AArch64 Port
>> JDK-8253816: Support macOS W^X
>> JDK-8253817: Support macOS Aarch64 ABI in Interpreter
>> JDK-8253818: Support macOS Aarch64 ABI for compiled wrappers
>> JDK-8253819: Implement os/cpu for macOS/AArch64
>> JDK-8253839: Update tests and JDK code for macOS/Aarch64
>> JDK-8254941: Implement Serviceability Agent for macOS/AArch64
>> JDK-8255776: Change build system for macOS/AArch64
>> JDK-8262903: [macos_aarch64] Thread::current() called on detached thread
>> JDK-8262896: [macos_aarch64] Crash in jni_fast_GetLongField
>
> Running fastdebug tier1 on macOS/AArch64 looks good:
> 
> ==============================
> Test summary
> ==============================
>    TEST                                              TOTAL  PASS  FAIL ERROR
>>> jtreg:test/hotspot/jtreg:tier1                     1239  1238     1     0 <<
>>> jtreg:test/jdk:tier1                               1872  1866     6     0 <<
>    jtreg:test/langtools:tier1                         3915  3915     0     0 
>    jtreg:test/nashorn:tier1                              0     0     0     0
>    jtreg:test/jaxp:tier1                                 0     0     0     0
> ==============================
> TEST FAILURE
> 
> 
> Those 6 failures in `jdk:tier` also happen on Linux/AArch64, so I'll ignore them. The hotspot failure happens on `test/hotspot/jtreg/runtime/ErrorHandling/TestOnError.java` with the following output:
> 
> 
> TEST RESULT: Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: '^Test Succeeded' missing from stdout
> 
> 
> Not sure what's going on.
> 
> Circeling back to the r18 issue mentioned here: https://github.com/openjdk/jdk11u-dev/pull/301#issuecomment-911998917
> My understanding is that the current stable release of macOS (12.1 Monterey) should already be affected by this issue, as I haven't backported https://bugs.openjdk.java.net/browse/JDK-8274795 to jdk11 yet. Do you have some better reproducer other than running Intellij? Apparently none of the tier1 tests seem to trigger it. 
> 
> Edit: The `release` build of this branch actually runs Intellij just fine.

> @lewurm I am also getting the same `TestOnError` failure in hotspot:tier1 when I run the tests on the fastdebug build. However, I do not get the 6 langtools failures. All tier1 tests pass on the release build though.

Thanks for looking at it @ahmedmuhsin, probably an issue with my setup then.

> Edit: The release build of this branch actually runs Intellij just fine.

Running on that build for >48h now. Seems good �� (it doesn't just sit in the background, but I'm actually using it).

> Is there an issue here that prevents 8274795 from being backported to 11? It's
> obviously a bug. Are you waiting for the MacOS port?

Yes, I was hoping the macOS port nicely crashes ��  Here is the backport: https://github.com/openjdk/jdk11u-dev/pull/744


@VladimirKempik not sure how you would like to proceed with this, do you want to merge this PR into `jdk11-macos` or do we just let it sit and bake here?  Both is fine I think.

-------------

PR: https://git.openjdk.java.net/aarch64-port/pull/14