Betterrev Pull Request

[Edward Yue Shung Wong]

Thanks for the update Martijn! Rather unfortunate situation really...

Hope the hacking goes smoothly for the others!

Edward
On 13 Dec 2014 10:52, "Martijn Verburg" <martijnverburg at gmail.com> wrote:

> Hi Ed,
>
> Yeah - the Mac OS X situation sucks.  Basically you had the right idea -
> install npm and the other build tools globally using sudo.  Install the
> other packages locally using sudo, why?  Coz Apple hates you :-).
>
> Cheers,
> Martijn
>
> On 13 December 2014 at 10:33, Edward Yue Shung Wong <
> edward.ys.wong at gmail.com> wrote:
>
>> Morning,
>>
>> Apologies again for not being able to make it today, my baby is teething
>> and none of us slept very well last night :( For what it is worth, I am
>> available via email and I'm more than happy to do reviews/field questions.
>>
>> All the best,
>>
>> Edward
>>
>> ----
>>
>> P.S. Martijn - I tried the instructions and Node on Mac seems to have
>> issues... When I tried to run:
>>
>> npm install -g bower
>>
>> I had to run it with sudo to get it to install properly. Similarly for
>> the "npm install -g gulp".
>>
>> When running "npm install" in the angularjsapp directory, sudo doesn't
>> help this time. It appears all the node scripts have similar permission
>> issues. Here is a snippet of the error log:
>>
>> error Error: ENOENT, chmod
>> '/Users/Seraph/workspace/betterrev/betterrev/src/main/angularjsapp/node_modules/mocha/bin/mocha'
>>
>> I'm sure this is just some sort of configuration problem with NodeJS on
>> Mac... I'll let the group know if I resolve this!
>>
>> ----
>>
>> On 11 December 2014 at 11:04, Martijn Verburg <martijnverburg at gmail.com>
>> wrote:
>>>
>>> You should:
>>>
>>> * Download and install wildly 8.2.0-Final
>>> * globally install Node, npm, bower and (possibly gulp if you want to
>>> force all of your HTML5 apps to use the same version)
>>> * update your javaee branch with the one from adoptopenjdk org (what
>>> just got merged)
>>> * run npm install and bower install in the angularapp folder
>>> * run gulp in the angularapp folder - you should see a crappy karma test
>>> run, you should also be able to get to the UI via local host:9000/betterev
>>>
>>> This Is all from memory typed on my phone :-)
>>>
>>> On Thursday, 11 December 2014, Edward Yue Shung Wong <
>>> edward.ys.wong at gmail.com> wrote:
>>>
>>>> "Done done" now :)
>>>>
>>>> Looking forward to seeing everyone Saturday. Anything I can pick up
>>>> between now and then to help?
>>>>
>>>> Cheers,
>>>>
>>>> Edward
>>>> On 11 Dec 2014 10:15, "Martijn Verburg" <martijnverburg at gmail.com>
>>>> wrote:
>>>>
>>>>> Thanks! But I think it's only been approved, but not yet merged :-)
>>>>>
>>>>> Cheers,
>>>>> Martijn
>>>>>
>>>>> On 11 December 2014 at 00:40, Ben Evans <benjamin.john.evans at gmail.com
>>>>> >
>>>>> wrote:
>>>>>
>>>>> > Done & done. This is fundamentally a version upgrade.
>>>>> >
>>>>> > Ben
>>>>> >
>>>>> > On Wed, Dec 10, 2014 at 11:59 PM, Martijn Verburg
>>>>> > <martijnverburg at gmail.com> wrote:
>>>>> > > Hi all,
>>>>> > >
>>>>> > > If someone could review and merge (or not):
>>>>> > >
>>>>> >
>>>>> https://bitbucket.org/adoptopenjdk/betterrev/pull-request/89/upgrade-frontend-components/diff
>>>>> > >
>>>>> > > I can then get people started on Sat.
>>>>> > >
>>>>> > > Cheers,
>>>>> > > Martijn
>>>>> >
>>>>>
>>>>
>>>
>>> --
>>> Cheers,
>>> Martijn
>>>
>>
>