Submitting patches to OpenJDK

Thu Mar 27 08:58:25 UTC 2014

Didn't see this called out , please include a test case for your fix.

Rgds,Rory
On 27/03/2014 08:49, Martijn Verburg wrote:
> Oh and I forgot - if you want to back port the change to java 8 you'll have
> to build and test the patch against that forest as well.
>
> On Wednesday, 26 March 2014, Mani Sarkar <sadhak001 at gmail.com> wrote:
>
>> Thanks Martijn, this should answer everyone's questions post Java 8
>> release - and availability of OpenJDK 9!
>>
>> Cheers,
>> Mani
>>
>>
>> On Wed, Mar 26, 2014 at 5:23 PM, Martijn Verburg <martijnverburg at gmail.com<javascript:_e(%7B%7D,'cvml','martijnverburg at gmail.com');>
>>> wrote:
>>> Hi Mani,
>>>
>>> It's a good question and I'm sure Dalibor will weigh in if I get this
>>> wrong but basically here goes.  In most cases you:
>>>
>>> 1.) You create a patch against OpenJDK 9 HEAD for the appropriate forest
>>> (most people will just go for the efault unless they're doing specialist
>>> Hotspot etc work).
>>>
>>> 2.) You should of course run the tests locally.
>>>
>>> 3.) You should check the openJDK project page for the area that you are
>>> making the change in and look to see what coding standards they have an
>>> meet those.
>>>
>>> 3.a.) You'll also need to check what the review process for that project
>>> is.  But typically you need to find one sponsor who has Reviewer status
>>> (especially if your change is a semantic one)
>>>
>>> 4.) You then need to create a webrev (using the webrev.sh tool in the
>>> codetools project) and host that somewhere.
>>>
>>> 5.) You'll need to sign the OCA if you haven't done so already.
>>>
>>> 6.) You'll mail the link to your webrev to the right mailing list in
>>> OpenJDK asking for a sponsor with Reviewer status to review your change and
>>> perhaps open up a bug/issue on your behalf in the JBUG database (or you
>>> should reference an existing one).
>>>
>>> 7.) Assuming your patch passes review it will then be merged into
>>> OpenJDK. Please note that subsequent testing by Oracle's internal team in
>>> particular may find bugs in your patch and you'll be asked to fix those.
>>>
>>> I think that roughly covers it, you can see why we're trying to introduce
>>> Betterev soon to streamline the process :-).
>>>
>>> Cheers,
>>> Martijn
>>>
>>>
>>>
>>>
>>>
>>> Cheers,
>>> Martijn
>>>
>>>
>>> On 26 March 2014 13:42, mani <sadhak001 at gmail.com<javascript:_e(%7B%7D,'cvml','sadhak001 at gmail.com');>
>>>> wrote:
>>>> Hi Martijn,
>>>>
>>>> We have been asked (over the conference call and in person at JavaLand),
>>>> what is the process flow for submitting patches for both bug fixes and
>>>> enhancements from start to finish (before its been merged into the repos).
>>>>
>>>> Hopefully they are on this mailing list and would be able to benefit
>>>> from the response.
>>>>
>>>> Regards,
>>>> Mani
>>>>
>>>> On Thursday, 14 November 2013 10:11:32 UTC, Martijn Verburg wrote:
>>>>> Hi all,
>>>>>
>>>>> Just a warning that as the end game for Java 8 arrives, the project
>>>>> will be less likely to accept patches unless they are purely bug fixes or
>>>>> things like documentation tidy-up.
>>>>>
>>>>> Cheers,
>>>>> Martijn
>>>>>
>>>>   --
>>>> -- You've received this message because you are subscribed to the Google
>>>> Groups Adopt OpenJDK group. To post to this group, send an email to
>>>> adopt-openjdk at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk at googlegroups.com');>.
>>>> To unsubscribe from this group, send an email to
>>>> adopt-openjdk+unsubscribe at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk%2Bunsubscribe at googlegroups.com');>.
>>>> For more options, visit this group at
>>>> https://groups.google.com/d/forum/adopt-openjdk?hl=en-GB
>>>> ---
>>>> You received this message because you are subscribed to the Google
>>>> Groups "Adopt OpenJDK" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>> an email to adopt-openjdk+unsubscribe at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk%2Bunsubscribe at googlegroups.com');>
>>>> .
>>>> To post to this group, send email to adopt-openjdk at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk at googlegroups.com');>
>>>> .
>>>> Visit this group at http://groups.google.com/group/adopt-openjdk.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>   --
>>> -- You've received this message because you are subscribed to the Google
>>> Groups Adopt OpenJDK group. To post to this group, send an email to
>>> adopt-openjdk at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk at googlegroups.com');>.
>>> To unsubscribe from this group, send an email to
>>> adopt-openjdk+unsubscribe at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk%2Bunsubscribe at googlegroups.com');>.
>>> For more options, visit this group at
>>> https://groups.google.com/d/forum/adopt-openjdk?hl=en-GB
>>> ---
>>> You received this message because you are subscribed to the Google Groups
>>> "Adopt OpenJDK" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to adopt-openjdk+unsubscribe at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk%2Bunsubscribe at googlegroups.com');>
>>> .
>>> To post to this group, send email to adopt-openjdk at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk at googlegroups.com');>
>>> .
>>> Visit this group at http://groups.google.com/group/adopt-openjdk.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>> --
>> @theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
>> <http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC Advocate
>> (@adoptopenjdk & @adoptajsr programs)
>> *Meet-a-Project - *MutabilityDetector<https://github.com/MutabilityDetector>*
>> |  **Bitbucket <https://bitbucket.org/neomatrix369>* * |  **Github
>> <https://github.com/neomatrix369>* * |  **LinkedIn
>> <http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
>> *Come to Devoxx UK 2014:* http://www.devoxx.co.uk/
>>
>> *Don't chase success, rather aim for "Excellence", and success will come
>> chasing after you!*
>>
>> --
>> -- You've received this message because you are subscribed to the Google
>> Groups Adopt OpenJDK group. To post to this group, send an email to
>> adopt-openjdk at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk at googlegroups.com');>.
>> To unsubscribe from this group, send an email to
>> adopt-openjdk+unsubscribe at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk%2Bunsubscribe at googlegroups.com');>.
>> For more options, visit this group at
>> https://groups.google.com/d/forum/adopt-openjdk?hl=en-GB
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Adopt OpenJDK" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to adopt-openjdk+unsubscribe at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk%2Bunsubscribe at googlegroups.com');>
>> .
>> To post to this group, send email to adopt-openjdk at googlegroups.com<javascript:_e(%7B%7D,'cvml','adopt-openjdk at googlegroups.com');>
>> .
>> Visit this group at http://groups.google.com/group/adopt-openjdk.
>> For more options, visit https://groups.google.com/d/optout.
>>
>

-- 
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland