Kulla build broken on Mac

Tue Jul 7 16:20:05 UTC 2015

Hi Jan,

Just retried on a clean pull of jdk9/dev - I'm seeing the same issue
there as well.

The colliding files appear to be coming from sa-jdi.jar in
/Library/Java/JavaVirtualMachines/java8/Contents/Home/lib

Is this something we should be resolving by e.g. setting a parameter
indicating that only jars from jre/lib should be used?

Thanks,

Ben

On Tue, Jul 7, 2015 at 5:09 PM, Jan Lahoda <jan.lahoda at oracle.com> wrote:
> Hi Ben,
>
> On 7.7.2015 16:06, Ben Evans wrote:
>>
>> Hi Jan,
>>
>> This was a clean build. I've also verified it by a completely clean
>> download and starting from scratch, and also used both 8u25 and a
>> build of JDK 9 mainline as the boot JDK. Same result in each case.
>>
>> Could it be a clash between the imports?
>
>
> That sounds probable. What puzzles me is why this wouldn't happen on
> jdk9/dev (or at least on jdk9/dev at the time we last merged jdk9/dev into
> kulla/dev). I don't think we have any Kulla-specific changes in the hotspot
> repository. I am working on merging recent jdk9/dev changes into kulla/dev,
> so then the behavior should be closer to current jdk9/dev behavior.
>
> Jan
>
>
>>
>> In hotspot/agent/src/share/classes JDK 8 has VirtualSpace.java in
>> sun/jvm/hotspot/runtime whereas in the kulla repo this has become
>> sun/jvm/hotspot/memory. Could this be the cause of the problem?
>> Perhaps both are now being picked up at compile time.
>>
>> This change to CMSBitMap.java (in
>> hotspot/agent/src/share/classes/sun/jvm/hotspot/gc/cms) seems to
>> resolve the ambiguity
>>
>> boxcat$ diff -u CMSBitMap.java.dst CMSBitMap.java
>> --- CMSBitMap.java.dst    2015-07-07 14:52:20.000000000 +0100
>> +++ CMSBitMap.java    2015-07-07 15:02:23.000000000 +0100
>> @@ -27,8 +27,10 @@
>>   import java.io.*;
>>   import java.util.*;
>>   import sun.jvm.hotspot.debugger.*;
>> -import sun.jvm.hotspot.memory.*;
>> -import sun.jvm.hotspot.runtime.*;
>> +import sun.jvm.hotspot.memory.VirtualSpace;
>> +import sun.jvm.hotspot.runtime.VM;
>> +import sun.jvm.hotspot.runtime.VMObject;
>> +import sun.jvm.hotspot.runtime.VMObjectFactory;
>>   import sun.jvm.hotspot.types.*;
>>   import sun.jvm.hotspot.utilities.*;
>>
>> boxcat$ make images > comp.out 2> comp.err
>> e-js-mbp:kulla boxcat$ grep -n CMSBitMap comp.err
>>
>> Thanks,
>>
>> Ben
>>
>> On Tue, Jul 7, 2015 at 2:23 PM, Jan Lahoda <jan.lahoda at oracle.com> wrote:
>>>
>>> Hi Ben,
>>>
>>> I am personally not aware of any Kulla-specific changes in the hotspot
>>> repository. I see some classes were moved to different
>>> directories/packages
>>> in the hotspot repository. Was the build a clean build? If not, could you
>>> please try to do a clean build (e.g. "make clean; make images").
>>>
>>> Thanks,
>>>      Jan
>>>
>>>
>>> On 7.7.2015 14:18, Ben Evans wrote:
>>>>
>>>>
>>>> Hi,
>>>>
>>>> The current tip of kulla/dev appears to be broken on Mac 10.9.
>>>>
>>>> Running make images gives 61 errors, all of the form:
>>>>
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/gc/cms/CMSBitMap.java:77:
>>>> error: reference to VirtualSpace is ambiguous
>>>>     public VirtualSpace virtualSpace() {
>>>>            ^
>>>>     both class sun.jvm.hotspot.runtime.VirtualSpace in
>>>> sun.jvm.hotspot.runtime and class sun.jvm.hotspot.memory.VirtualSpace
>>>> in sun.jvm.hotspot.memory match
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java:38:
>>>> error: reference to CompactibleSpace is ambiguous
>>>> public class CompactibleFreeListSpace extends CompactibleSpace {
>>>>                                                 ^
>>>>     both class sun.jvm.hotspot.memory.CompactibleSpace in
>>>> sun.jvm.hotspot.memory and class
>>>> sun.jvm.hotspot.gc.shared.CompactibleSpace in
>>>> sun.jvm.hotspot.gc.shared match
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/gc/shared/Generation.java:184:
>>>> error: reference to VirtualSpace is ambiguous
>>>>     protected VirtualSpace virtualSpace() {
>>>>               ^
>>>>     both class sun.jvm.hotspot.runtime.VirtualSpace in
>>>> sun.jvm.hotspot.runtime and class sun.jvm.hotspot.memory.VirtualSpace
>>>> in sun.jvm.hotspot.memory match
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java:396:
>>>> error: reference to SpaceClosure is ambiguous
>>>>     private class LiveRegionsCollector implements SpaceClosure {
>>>>                                                   ^
>>>>     both interface sun.jvm.hotspot.memory.SpaceClosure in
>>>> sun.jvm.hotspot.memory and interface
>>>> sun.jvm.hotspot.gc.shared.SpaceClosure in sun.jvm.hotspot.gc.shared
>>>> match
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java:401:
>>>> error: reference to Space is ambiguous
>>>>        public void doSpace(Space s) {
>>>>                            ^
>>>>     both class sun.jvm.hotspot.memory.Space in sun.jvm.hotspot.memory
>>>> and class sun.jvm.hotspot.gc.shared.Space in sun.jvm.hotspot.gc.shared
>>>> match
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/tools/HeapSummary.java:208:
>>>> error: reference to Generation is ambiguous
>>>>      private void printGen(Generation gen) {
>>>>                            ^
>>>>     both class sun.jvm.hotspot.memory.Generation in
>>>> sun.jvm.hotspot.memory and class sun.jvm.hotspot.gc.shared.Generation
>>>> in sun.jvm.hotspot.gc.shared match
>>>>
>>>> or:
>>>>
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java:84:
>>>> error: cannot find symbol
>>>>                                    collectorField.getValue(addr));
>>>>                                                            ^
>>>>     symbol:   variable addr
>>>>     location: class CompactibleFreeListSpace
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java:88:
>>>> error: cannot find symbol
>>>>        return capacity() - used0();
>>>>               ^
>>>>     symbol:   method capacity()
>>>>     location: class CompactibleFreeListSpace
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java:92:
>>>> error: cannot find symbol
>>>>        return capacity() - free();
>>>>               ^
>>>>     symbol:   method capacity()
>>>>     location: class CompactibleFreeListSpace
>>>>
>>>>
>>>> /Users/boxcat/projects/openjdk/kulla/hotspot/agent/src/share/classes/sun/jvm/hotspot/gc/cms/CompactibleFreeListSpace.java:108:
>>>> error: cannot find symbol
>>>>         Address cur = addr.addOffsetTo( indexedFreeListField.getOffset()
>>>> );
>>>>                       ^
>>>>     symbol:   variable addr
>>>>     location: class CompactibleFreeListSpace
>>>>
>>>> My current hg tip is:
>>>>
>>>> $ hg tip
>>>> changeset:   1522:bd5e490ebc9e
>>>> tag:         tip
>>>> user:        jlahoda
>>>> date:        Tue Jun 02 09:17:20 2015 +0200
>>>> summary:     jline should be without warnings
>>>>
>>>> Any ideas?
>>>>
>>>> Thanks,
>>>>
>>>> Ben
>>>>
>>>
>