Builds for project Valhalla

Tue Oct 6 05:25:32 UTC 2015

Hi Mani.

Thanks. No luck with that.
I even put a 'export SOURCE_LOCATION xxx' in the build script and it did
not recognise my {SOURCE_LOCATION} in the Dockerfile

They do support a -e flag in the run phase, but this does not work in the
build phase.
I'm afraid my docker experience is a little lacking.

Regards,
Richard.
On 5 Oct 2015 22:28, "Mani Sarkar" <sadhak001 at gmail.com> wrote:

> Richard,
>
> Just as an experiment try doing this at the linux prompt:
>
> $ ENV_VARIABLE=value docker <whatever args>
>
> See if the ENV_VARIABLE is substitutable in the Dockerfile ?
>
> Also check Environment Variables section of
> https://docs.docker.com/reference/builder/.
>
> Cheers,
> Mani
>
> On Mon, Oct 5, 2015 at 9:24 PM, Mani Sarkar <sadhak001 at gmail.com> wrote:
>
>> Richard,
>>
>> No worries, thanks for your efforts - I have left a couple of minor
>> comments for you. We can evolve it as need arises.
>>
>> Cheers,
>> Mani
>>
>> On Sun, Oct 4, 2015 at 5:31 AM, Richard Kolb <rjdkolb at gmail.com> wrote:
>>
>>> Hi Mani,
>>>
>>> I actually deleted that branch a while back.
>>> I've created a cleaner way for now that still works :
>>> https://github.com/neomatrix369/BuildHelpers/pull/3
>>>
>>> I can't pass -e commands (variables) into the build phase to pass in
>>> source location. Scratching my head with docker a bit.
>>> I'll have a look at making it pretty in the week. My current approach is
>>> still a quick and nasty. :)
>>>
>>> regards,
>>> Richard.
>>>
>>> On 3 October 2015 at 23:23, Mani Sarkar <sadhak001 at gmail.com> wrote:
>>>
>>>> Hi Richard,
>>>>
>>>> Please resend in your pull request for valhalla as it is and I'll merge
>>>> it. You can later on create a second pull request with a generic approach.
>>>>
>>>> Cheers,
>>>> Mani
>>>>
>>>> On Sat, Oct 3, 2015 at 1:46 PM, Mani Sarkar <sadhak001 at gmail.com>
>>>> wrote:
>>>>
>>>>> Richard,
>>>>>
>>>>> I have responded with comments on your PR.
>>>>>
>>>>> Looking forward to your changes.
>>>>>
>>>>> Cheers,
>>>>> Mani
>>>>>
>>>>> On Sat, Oct 3, 2015 at 10:45 AM, Mani Sarkar <sadhak001 at gmail.com>
>>>>> wrote:
>>>>>
>>>>>> No worries Richard, take your time.
>>>>>>
>>>>>> Cheers,
>>>>>> Mani
>>>>>>
>>>>>> On Sat, Oct 3, 2015 at 5:39 AM, Richard Kolb <rjdkolb at gmail.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Sorry for the delay Mani.
>>>>>>>
>>>>>>> I will get a pull request out to you this morning.
>>>>>>>
>>>>>>> Regards,
>>>>>>> Richard.
>>>>>>> On 2 Oct 2015 18:39, "Mani Sarkar" <sadhak001 at gmail.com> wrote:
>>>>>>>
>>>>>>>> Good work Richard, I'll take a look at it when I get home.
>>>>>>>>
>>>>>>>> @Martijn - I think its time to move some of the scripts to Adopt
>>>>>>>> OpenJDK github repo including the GSK gitbook which is on my personal
>>>>>>>> github repo.
>>>>>>>>
>>>>>>>> Cheers,
>>>>>>>> Mani
>>>>>>>>
>>>>>>>> On Fri, Oct 2, 2015 at 2:58 PM, Richard Kolb <rjdkolb at gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>>
>>>>>>>>> Hats off to you Mani!
>>>>>>>>> Got it going with one minor alteration.
>>>>>>>>>
>>>>>>>>> I'll add a Valhalla directory to build Valhalla and submit a pull
>>>>>>>>> request.
>>>>>>>>>
>>>>>>>>> >sudo docker run neomatrix369/openjdk9-full-image java -version
>>>>>>>>> openjdk version "1.9.0-internal"
>>>>>>>>> OpenJDK Runtime Environment (build
>>>>>>>>> 1.9.0-internal-_2015_10_02_13_26-b00)
>>>>>>>>> OpenJDK 64-Bit Server VM (build
>>>>>>>>> 1.9.0-internal-_2015_10_02_13_26-b00, mixed mode)
>>>>>>>>>
>>>>>>>>> regards,
>>>>>>>>> Richard.
>>>>>>>>>
>>>>>>>>> On 2 October 2015 at 13:36, Richard Kolb <rjdkolb at gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Think I have it.
>>>>>>>>>>
>>>>>>>>>> https://neomatrix369.wordpress.com/2015/06/04/why-not-build-openjdk-9-using-docker/
>>>>>>>>>>
>>>>>>>>>> I'm building the base Image.
>>>>>>>>>>
>>>>>>>>>> regards,
>>>>>>>>>> Richard.
>>>>>>>>>>
>>>>>>>>>> On 2 October 2015 at 09:58, Richard Kolb <rjdkolb at gmail.com>
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Mani,
>>>>>>>>>>>
>>>>>>>>>>> Thanks.
>>>>>>>>>>> I can't find the docker scripts. Can you point me in the right
>>>>>>>>>>> direction ?
>>>>>>>>>>>
>>>>>>>>>>> regards,
>>>>>>>>>>> Richard.
>>>>>>>>>>>
>>>>>>>>>>> On 2 October 2015 at 09:53, Mani Sarkar <sadhak001 at gmail.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Martijn,
>>>>>>>>>>>>
>>>>>>>>>>>> I was planning to have a script for Valhalla and the other
>>>>>>>>>>>> builds but lack of time and demand - but now its should be possible as we
>>>>>>>>>>>> have base scripts for both vagrant and docker.
>>>>>>>>>>>>
>>>>>>>>>>>> @Richard - thanks and good work reusing our existing work. Can
>>>>>>>>>>>> you p;s also play with the docker scripts later on if time permits ?
>>>>>>>>>>>>
>>>>>>>>>>>> Btw the vagrant scripts are from John Patrick - credits to him.
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks guys.
>>>>>>>>>>>>
>>>>>>>>>>>> Cheers,
>>>>>>>>>>>> Mani
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Oct 2, 2015 at 8:40 AM, Martijn Verburg <
>>>>>>>>>>>> martijnverburg at gmail.com> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi Richard,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks - much appreciated!  It does remind me we need to
>>>>>>>>>>>>> cleanup the Github
>>>>>>>>>>>>> repo as well.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Cheers,
>>>>>>>>>>>>> Martijn
>>>>>>>>>>>>>
>>>>>>>>>>>>> On 2 October 2015 at 08:36, Richard Kolb <rjdkolb at gmail.com>
>>>>>>>>>>>>> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>> > Hi Martijn and Mani.
>>>>>>>>>>>>> >
>>>>>>>>>>>>> > I've been playing with Mani's Vagrant script.
>>>>>>>>>>>>> > I'm keen to help and maybe be done by tomorrow.
>>>>>>>>>>>>> >
>>>>>>>>>>>>> > Regards,
>>>>>>>>>>>>> > Richard.
>>>>>>>>>>>>> > On 2 Oct 2015 09:30, "Martijn Verburg" <
>>>>>>>>>>>>> martijnverburg at gmail.com> wrote:
>>>>>>>>>>>>> >
>>>>>>>>>>>>> >> Hi all,
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >> A few people have asked us if we can provide Vagrant files
>>>>>>>>>>>>> and
>>>>>>>>>>>>> >> provisioning
>>>>>>>>>>>>> >> scripts for the valhalla forest.
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >> Something like a Vagrantfile + provisioning script(s), such
>>>>>>>>>>>>> as
>>>>>>>>>>>>> >> https://github.com/AdoptOpenJDK/openjdk-virtual-images or
>>>>>>>>>>>>> your own
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> https://github.com/AdoptOpenJDK/openjdk-virtual-images/tree/master/chef/cookbooks/openjdk-build
>>>>>>>>>>>>> >> .
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >> @Mani is that something you can quickly throw together?
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >> Cheers,
>>>>>>>>>>>>> >> Martijn
>>>>>>>>>>>>> >>
>>>>>>>>>>>>> >
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> @theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
>>>>>>>>>>>> <http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC
>>>>>>>>>>>> Advocate (@adoptopenjdk & @adoptajsr programs)
>>>>>>>>>>>> *Meet-a-Project - *MutabilityDetector
>>>>>>>>>>>> <https://github.com/MutabilityDetector>*  |  **Bitbucket
>>>>>>>>>>>> <https://bitbucket.org/neomatrix369>* * |  **Github
>>>>>>>>>>>> <https://github.com/neomatrix369>* * |  **LinkedIn
>>>>>>>>>>>> <http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
>>>>>>>>>>>> *Come to Devoxx UK 2016:* http://www.devoxx.co.uk/
>>>>>>>>>>>>
>>>>>>>>>>>> *Don't chase success, rather aim for "Excellence", and success
>>>>>>>>>>>> will come chasing after you!*
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> @theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
>>>>>>>> <http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC
>>>>>>>> Advocate (@adoptopenjdk & @adoptajsr programs)
>>>>>>>> *Meet-a-Project - *MutabilityDetector
>>>>>>>> <https://github.com/MutabilityDetector>*  |  **Bitbucket
>>>>>>>> <https://bitbucket.org/neomatrix369>* * |  **Github
>>>>>>>> <https://github.com/neomatrix369>* * |  **LinkedIn
>>>>>>>> <http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
>>>>>>>> *Come to Devoxx UK 2016:* http://www.devoxx.co.uk/
>>>>>>>>
>>>>>>>> *Don't chase success, rather aim for "Excellence", and success will
>>>>>>>> come chasing after you!*
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> @theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
>>>>>> <http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC
>>>>>> Advocate (@adoptopenjdk & @adoptajsr programs)
>>>>>> *Meet-a-Project - *MutabilityDetector
>>>>>> <https://github.com/MutabilityDetector>*  |  **Bitbucket
>>>>>> <https://bitbucket.org/neomatrix369>* * |  **Github
>>>>>> <https://github.com/neomatrix369>* * |  **LinkedIn
>>>>>> <http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
>>>>>> *Come to Devoxx UK 2016:* http://www.devoxx.co.uk/
>>>>>>
>>>>>> *Don't chase success, rather aim for "Excellence", and success will
>>>>>> come chasing after you!*
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> @theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
>>>>> <http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC
>>>>> Advocate (@adoptopenjdk & @adoptajsr programs)
>>>>> *Meet-a-Project - *MutabilityDetector
>>>>> <https://github.com/MutabilityDetector>*  |  **Bitbucket
>>>>> <https://bitbucket.org/neomatrix369>* * |  **Github
>>>>> <https://github.com/neomatrix369>* * |  **LinkedIn
>>>>> <http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
>>>>> *Come to Devoxx UK 2016:* http://www.devoxx.co.uk/
>>>>>
>>>>> *Don't chase success, rather aim for "Excellence", and success will
>>>>> come chasing after you!*
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> @theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
>>>> <http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC
>>>> Advocate (@adoptopenjdk & @adoptajsr programs)
>>>> *Meet-a-Project - *MutabilityDetector
>>>> <https://github.com/MutabilityDetector>*  |  **Bitbucket
>>>> <https://bitbucket.org/neomatrix369>* * |  **Github
>>>> <https://github.com/neomatrix369>* * |  **LinkedIn
>>>> <http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
>>>> *Come to Devoxx UK 2016:* http://www.devoxx.co.uk/
>>>>
>>>> *Don't chase success, rather aim for "Excellence", and success will
>>>> come chasing after you!*
>>>>
>>>
>>>
>>
>>
>> --
>> @theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
>> <http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC Advocate
>> (@adoptopenjdk & @adoptajsr programs)
>> *Meet-a-Project - *MutabilityDetector
>> <https://github.com/MutabilityDetector>*  |  **Bitbucket
>> <https://bitbucket.org/neomatrix369>* * |  **Github
>> <https://github.com/neomatrix369>* * |  **LinkedIn
>> <http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
>> *Come to Devoxx UK 2016:* http://www.devoxx.co.uk/
>>
>> *Don't chase success, rather aim for "Excellence", and success will come
>> chasing after you!*
>>
>
>
>
> --
> @theNeomatrix369 <http://twitter.com/theNeomatrix369>*  |  **Blog
> <http://neomatrix369.wordpress.com>**  |  *LJC Associate & LJC Advocate
> (@adoptopenjdk & @adoptajsr programs)
> *Meet-a-Project - *MutabilityDetector
> <https://github.com/MutabilityDetector>*  |  **Bitbucket
> <https://bitbucket.org/neomatrix369>* * |  **Github
> <https://github.com/neomatrix369>* * |  **LinkedIn
> <http://uk.linkedin.com/pub/mani-sarkar/71/a77/39b>*
> *Come to Devoxx UK 2016:* http://www.devoxx.co.uk/
>
> *Don't chase success, rather aim for "Excellence", and success will come
> chasing after you!*
>