On what issues could I help clean up for JDK 9
dalibor topic
dalibor.topic at oracle.com
Tue Dec 6 11:44:17 UTC 2016
Looking at the issue, it's a rather poor choice for a "cleanup" issue
for newcomers, as the only time the word 'cleanup' shows up in its
description is in the logged output of a failing tests. That means it's
not actually a cleanup issue at all.
In addition, reproducing the test case failure requires installing two
additional proprietary products (a third party database, and a third
party database driver). Each additional software installation
requirement introduces additional challenges for newcomers, such as
purchasing such third party software.
It presents the same challenges to potential reviewers, as well.
That's a good example for the kind of contribution that would most
likely be a net negative: it would end up using up valuable time both on
the new contributor's side and the side of existing contributors, while
the novice would only have a tiny chance of being successful.
As Patrick pointed out, mentoring is important. It's also very hard to
do well. One of the hard parts of mentoring is picking the right
challenge for the novice to tackle.
Someone unfamiliar with JDK development attempting to mentor other
novices will likely pick the wrong ones, such as this one, as will
someone picking out issues randomly from a bug tracker search, etc.
Instead, the better way of picking out such cleanup tasks is to follow
along the mailing list threads to understand what kind of cleanup
activities are already ongoing or being discussed for JDK 10, or other
OpenJDK Projects.
Accordingly, a more useful contribution to this Group would be to track
such cleanup effort related mailing list threads on our wiki, for
example, so that novices can find them, read through them, and
understand if that's an effort that they would like to get involved
with, that matches their skill levels.
And of course, not every cleanup effort is suited for everyone. Please
don't attempt C compiler warnings cleanups if you are not a practicing C
developer^W language standards lawyer, for example ...
cheers,
dalibor topic
On 06.12.2016 10:15, Martijn Verburg wrote:
> Hi all,
>
> So after some keyword spelunking I found:
>
> /jdk/javax/sql/testing/test/rowset/joinrowset/JoinRowSetTests.java/ test
> class which has some methods which test joinrowset behaviour.
>
> That may or may not be a replacement for the test class that is
> mentioned in the bug report.
>
> I'm going to go and ask over on core-libs and see if anyone knows
> anything about it :-).
>
>
>
>
> Cheers,
> Martijn
>
> On 5 December 2016 at 23:25, Martijn Verburg <martijnverburg at gmail.com
> <mailto:martijnverburg at gmail.com>> wrote:
>
> Hi Patrick,
>
> Hmm, you're right, it may not be, let's take a look :-)
>
> Cheers,
> Martijn
>
> On 5 December 2016 at 22:07, Patrick Reinhart <patrick at reini.net
> <mailto:patrick at reini.net>> wrote:
>
>
> > Am 05.12.2016 um 11:12 schrieb Martijn Verburg <martijnverburg at gmail.com <mailto:martijnverburg at gmail.com>>:
> >
> > Hi all,
> >
> > It does come across as a bit Chicken and Egg at times (even if that isn't the intent). Since this group is meant to help new joiners perhaps as a starting step we could find a few issues and work on them collaboratively on this mailing list.
> >
> > Following Claes's advice, how does this one sound?
> >
> > https://bugs.openjdk.java.net/browse/JDK-6253001
> <https://bugs.openjdk.java.net/browse/JDK-6253001>
> >
> > Where an internal test is failing (com.sun.rowset.tests.smoke.jo
> <http://com.sun.rowset.tests.smoke.jo>inrowset.joinrowset3.JoinRowSet3#testJoinRowSet22
> FAILED)
> >
> > It's an old bug so as per Dalibor's suggestion we could post to core-libs, start a discussion that we'd like to take a look into this issue (starting by trying to reproduce it) and see what people say.
> >
> > Thoughts?
> >
>
> I can take a look into that - I guess the actual test is not
> public right?
>
> -Patrick
>
> >
> >
> >
> > Cheers,
> > Martijn
> >
> > On 2 December 2016 at 21:35, Patrick Reinhart
> <patrick at reini.net <mailto:patrick at reini.net>> wrote:
> > It’s a bit disappointing answer after all.
> >
> > All you get told on the various Presentations is that „we need
> you“, but when you actually try to help there seem’s to be
> nobody that actually want’s to mentor new contributors. I know
> that a new contributors should prove in a some way that they are
> willing to do more than one contribution. But on the other hand
> if I ask for help, I should also do some investment on my side.
> >
> > The main reason for keeping me on trying to help is the nice
> response of a couple guys like you Stephen, Stuart Marks, Mandy
> Chung and Paul Sandoz to just name a few that actually took the
> time to help me going.
> >
> > I read the post [1] but only pointing to documentation only
> seems to me not be mentoring
> >
> > For me it looks like:
> >
> > „We are so busy working, that we got not time to help new guys
> in getting in shape, to take over some of the work“
> >
> > -Patirck
> >
> > [1]
> http://mail.openjdk.java.net/pipermail/adoption-discuss/2016-August/001422.html
> <http://mail.openjdk.java.net/pipermail/adoption-discuss/2016-August/001422.html>
> >
> >
> > > Am 02.12.2016 um 17:13 schrieb Stephen Colebourne
> <scolebourne at joda.org <mailto:scolebourne at joda.org>>:
> > >
> > > This advice reads as "go bother some other mailing list,
> we're too
> > > busy doing important things". Essentially it ensures that
> there will
> > > be no new contributors to the JDK (core-libs) because they
> have all
> > > been sent elsewhere.
> > >
> > > Stephen
> > >
> > >
> > > On 2 December 2016 at 15:08, dalibor topic
> <dalibor.topic at oracle.com <mailto:dalibor.topic at oracle.com>> wrote:
> > >> Community-wide 'starter issues' are a better idea in
> theory, then they are
> > >> in practice.
> > >>
> > >> Typically the theory behind them is to mark some low
> priority issues for
> > >> someone else to fix. But in practice, not all low priority
> fixes are welcome
> > >> at all times. See
> > >>
> http://mail.openjdk.java.net/pipermail/adoption-discuss/2016-August/001422.html
> <http://mail.openjdk.java.net/pipermail/adoption-discuss/2016-August/001422.html>
> > >> for a longer explanation why that's the case.
> > >>
> > >> In practice, it's a better idea to focus new contributors'
> attention not on
> > >> what they can do for the large projects with schedules,
> processes and all
> > >> that good, complicated stuff that enables releases to
> happen, like JDK 9 or
> > >> JDK 8 Updates, but on what they can do in the projects that
> are in a more
> > >> exploratory phase, such as Valhalla. Beside exploration of
> new ideas being
> > >> more fun for new contributors, they are also often eager
> for the kind of
> > >> feedback on the new ideas and designs, that comes from
> playing with the new
> > >> toys and often enough, breaking them in interesting ways.
> > >>
> > >> cheers,
> > >> dalibor topic
> > >>
> > >>
> > >> On 02.12.2016 13:53, Patrick Reinhart wrote:
> > >>>
> > >>> What was the outcome of that discussion?
> > >>>
> > >>> I seem to miss that one. My question comes from the past
> presentation I
> > >>> gave about contributing to the OpenJDK. And one of the
> main things was not
> > >>> only to do some local hacking but instead try to solve
> some small issues,
> > >>> that else would not be fixed because of other more
> important things.
> > >>>
> > >>> -Patrick
> > >>>
> > >>>> Am 02.12.2016 um 11:45 schrieb Martijn Verburg
> > >>>> <martijnverburg at gmail.com <mailto:martijnverburg at gmail.com>>:
> > >>>>
> > >>>> There's no JBS query that I know of (I think in the
> distant past we
> > >>>> discussed adding a low hanging fruit 'Duke' tag?).
> > >>>>
> > >>>> Cheers,
> > >>>> Martijn
> > >>>
> > >>>
> > >>
> > >> --
> > >> <http://www.oracle.com> Dalibor Topic | Principal Product
> Manager
> > >> Phone: +494089091214 <tel:%2B494089091214>
> <tel:+494089091214 <tel:%2B494089091214>> | Mobile:
> +491737185961 <tel:%2B491737185961>
> > >> <tel:+491737185961 <tel:%2B491737185961>>
> > >>
> > >> ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg
> > >>
> > >> ORACLE Deutschland B.V. & Co. KG
> > >> Hauptverwaltung: Riesstr. 25, D-80992 München
> > >> Registergericht: Amtsgericht München, HRA 95603
> > >>
> > >> Komplementärin: ORACLE Deutschland Verwaltung B.V.
> > >> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
> > >> Handelsregister der Handelskammer Midden-Niederlande, Nr.
> 30143697
> > >> Geschäftsführer: Alexander van der Ven, Jan Schultheiss,
> Val Maher
> > >>
> > >> <http://www.oracle.com/commitment
> <http://www.oracle.com/commitment>> Oracle is committed to
> developing
> > >> practices and products that help protect the environment
> >
> >
>
>
>
--
<http://www.oracle.com> Dalibor Topic | Principal Product Manager
Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961
<tel:+491737185961>
ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg
ORACLE Deutschland B.V. & Co. KG
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRA 95603
Komplementärin: ORACLE Deutschland Verwaltung B.V.
Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
Geschäftsführer: Alexander van der Ven, Jan Schultheiss, Val Maher
<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment
More information about the adoption-discuss
mailing list