Remove exception from sun.rmi.runtime.Log#getSource()

Dalibor Topic dalibor.topic at oracle.com
Thu Aug 22 07:54:39 UTC 2019


Hi Philippe,

that sounds like an interesting change.

Please subscribe to core-libs-dev and start a thread there, with your 
patch inline - our mailing lists drop zip, exe and similar attachments.

cheers,
dalibor topic

On 21.08.2019 16:33, Philippe Marschall wrote:
> Hello
> 
> First time contributor here.
> 
> We have exception tracing enabled in production and see thousands of
> exceptions in sun.rmi.runtime.Log#getSource() to get the caller class.
> In my option this should use StackWalker introduced in Java 9. I could
> find no corresponding bug in JBS.
> 
> Attached you'll find a webrev. I created a custom StackWalker to be able
> to pass in the estimated number of frames that we traverse. As for
> variable naming conventions I tried to stick with other StackWalker
> users I could find in the JDK. The stream formatting tries to follow the
> LVTI style guidelines.
> 
> I have not written a test as the method is private. I ran the tier1
> tests and they passed.
> 
> I have signed the OCA.
> 
> What are the next steps, where should I post this?
> 
> Cheers
> Philippe Marschall

-- 
<http://www.oracle.com>
Dalibor Topic | Consulting Product Manager
Phone: +494089091214 <tel:+494089091214> | Mobile: +491737185961
<tel:+491737185961> | Video: dalibor.topic at oracle.com
<sip:dalibor.topic at oracle.com>

Oracle Global Services Germany GmbH
Hauptverwaltung: Riesstr. 25, D-80992 München
Registergericht: Amtsgericht München, HRB 246209
Geschäftsführer: Ralf Herrmann

<http://www.oracle.com/commitment> Oracle is committed to developing
practices and products that help protect the environment


More information about the adoption-discuss mailing list