From brian.goetz at oracle.com Sat Jul 1 12:39:25 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Sat, 1 Jul 2017 08:39:25 -0400 Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: References: <0562c35c-c38b-a65a-03c9-bcbcf5e814d3@oracle.com> <672C8B59-D120-430E-A107-2CABABCF1CD6@oracle.com> Message-ID: <1bf2233b-5b05-8ef7-7efd-376368c8f7c3@oracle.com> No, nothing stopping us from starting at A and then going to B/C/D. On 6/30/2017 7:57 PM, Maurizio Cimadamore wrote: > Is there something that prevents us to go from, say A to C/D in steps, > rather than all at once? > > Seems to be that, being A about being conservative, it should keep > most doors open for whatever extension of '_' we might plan in the > future. Am I missing something? > > Maurizio > > > On 30/06/17 23:04, John Rose wrote: >> On Jun 30, 2017, at 2:38 PM, Brian Goetz wrote: >>> And once we bring in methods, it raises tooling questions like "what >>> about Javadoc." So maybe the last step was the problem. >> If it's only javadoc that's the problem, then that's an easy call: >> we should Inconvenience the javadoc authors if it will help a >> tiny fraction of java developers. >> >> In fact, even if it is 20 tools (and it won't?e.g., reflection already >> handles missing parameter names), it's still arguably a pure >> question of whether it's good for developers, as long as the >> effect on tool writers is a temporary irritant. >> >> ? John > From forax at univ-mlv.fr Sat Jul 1 15:11:29 2017 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 1 Jul 2017 17:11:29 +0200 (CEST) Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: <1bf2233b-5b05-8ef7-7efd-376368c8f7c3@oracle.com> References: <0562c35c-c38b-a65a-03c9-bcbcf5e814d3@oracle.com> <672C8B59-D120-430E-A107-2CABABCF1CD6@oracle.com> <1bf2233b-5b05-8ef7-7efd-376368c8f7c3@oracle.com> Message-ID: <1805586664.3177579.1498921889730.JavaMail.zimbra@u-pem.fr> As Brian said, parameter names are part of the API, Most if not all IDEs support @SuppressWarnings("unused") to said that an implementation will not use a specific parameter, but there is no way to said that a parameter name should not be used in term of API. So i'm in favor of D with the javadoc saying that a parameter named '_' should not be used. R?mi ----- Mail original ----- > De: "Brian Goetz" > ?: "Maurizio Cimadamore" , "John Rose" > Cc: amber-dev at openjdk.java.net > Envoy?: Samedi 1 Juillet 2017 14:39:25 > Objet: Re: [lambda-leftovers] Underscore parameter for abstract/native methods > No, nothing stopping us from starting at A and then going to B/C/D. > > On 6/30/2017 7:57 PM, Maurizio Cimadamore wrote: >> Is there something that prevents us to go from, say A to C/D in steps, >> rather than all at once? >> >> Seems to be that, being A about being conservative, it should keep >> most doors open for whatever extension of '_' we might plan in the >> future. Am I missing something? >> >> Maurizio >> >> >> On 30/06/17 23:04, John Rose wrote: >>> On Jun 30, 2017, at 2:38 PM, Brian Goetz wrote: >>>> And once we bring in methods, it raises tooling questions like "what >>>> about Javadoc." So maybe the last step was the problem. >>> If it's only javadoc that's the problem, then that's an easy call: >>> we should Inconvenience the javadoc authors if it will help a >>> tiny fraction of java developers. >>> >>> In fact, even if it is 20 tools (and it won't?e.g., reflection already >>> handles missing parameter names), it's still arguably a pure >>> question of whether it's good for developers, as long as the >>> effect on tool writers is a temporary irritant. >>> >>> ? John From gavin.bierman at oracle.com Tue Jul 4 12:29:38 2017 From: gavin.bierman at oracle.com (gavin.bierman at oracle.com) Date: Tue, 04 Jul 2017 12:29:38 +0000 Subject: hg: amber/amber/langtools: Fixed bug relating to constant patterns matching expressions of reference type Message-ID: <201707041229.v64CTcuK005627@aojmv0008.oracle.com> Changeset: ff963f699030 Author: gbierman Date: 2017-07-04 13:27 +0100 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/ff963f699030 Fixed bug relating to constant patterns matching expressions of reference type ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! test/tools/javac/patterns/ConstantPatternTest1.java From wshackle at gmail.com Wed Jul 5 20:34:07 2017 From: wshackle at gmail.com (William Shackleford) Date: Wed, 5 Jul 2017 16:34:07 -0400 Subject: Comments/Feature Requests regarding JEP 305: Pattern Matching Message-ID: In the examples provided in the JEP it looks as though it would always be required to provide new variable names each time a pattern match is used. Could we eliminate the new variable names or make them optional? As written it doesn't seem to completely provide the benefits of flow typing. This would have the following benefits. 1. It is more compact. 2. It reduces the number of variable names you need to think of when writing code. 3. It reduces the chances of needing one variable name to shadow another. 4. It is easier to see if a variable is used or modified if it is only referenced with one name. For example String formatted; switch (p) { case Integer i: formatted = String.format("int %d", i); break; case Byte b: formatted = String.format("byte %d", b); break; case Long l: formatted = String.format("long %d", l); break; case Double d: formatted = String.format(?double %f", d); break; case String s: formatted = String.format("String %s", s); break default: formatted = obj.toString(); } would change to String formatted; switch (p) { case Integer: formatted = String.format("int %d", p); break; case Byte: formatted = String.format("byte %d", p); break; case Long: formatted = String.format("long %d", p); break; case Double: formatted = String.format(?double %f", p); break; case String: formatted = String.format("String %s", p); break default: formatted = p.toString(); } In the second one if i,b,l,d,s are other variables in scope there is no chance of misunderstanding that they have been shadowed by the new variables. If you look for where is p used, the answer in both cases is all the format calls but thats easier to see at a glance in the second example. Generally the variable name p would give one insight into the source or purpose of that variable which is lost if you change to a variable name chosen just to indicate the type, or the variable names end up too long if one always appends the type info to the source and/or purpose info in the name. Also : int eval(Node n) { switch(n) { case IntNode(int i): return i; case NegNode(Node n): return -eval(n); case AddNode(Node left, Node right): return eval(left) + eval(right); case MulNode(Node left, Node right): return eval(left) * eval(right); default: throw new IllegalStateException(n); }; } could be written more concisely as int eval(Node n) { switch(n) { case IntNode: return n.i; case NegNode: return -eval(n.n); case AddNode: return eval(n.left) + eval(n.right); case MulNode: return eval(n.left) * eval(n.right); default: throw new IllegalStateException(n); }; } In addition to being more concise: n is not both used as the positive part of the NegNode and as the input parameter. It works with classes that have more fields/methods than constructor arguments. It seems to me that is better to consistently use a single syntax style rather than having one for classes that have only one or two fields that happen to match the constructor arguments and another more general style. This is especially true given that it doesn't even seem to make the code more concise. -- Will From maurizio.cimadamore at oracle.com Wed Jul 5 21:03:01 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Wed, 5 Jul 2017 22:03:01 +0100 Subject: Comments/Feature Requests regarding JEP 305: Pattern Matching In-Reply-To: References: Message-ID: <4a60efbc-0bc2-552c-4515-3ec10c886034@oracle.com> On 05/07/17 21:34, William Shackleford wrote: > In addition to being more concise: > n is not both used as the positive part of the NegNode and as the input > parameter. Note that this is likely to be a bug in the original example. It is not possible for a pattern binding to 'shadow' a method parameter name. > It works with classes that have more fields/methods than constructor > arguments. > It seems to me that is better to consistently use a single syntax style > rather than having one for classes > that have only one or two fields that happen to match the constructor > arguments and another more > general style. This is especially true given that it doesn't even seem to > make the code more concise. Generally what you say is true - in many cases you will be able to write things even without nested patterns. It is very likely that at the very least we will add some support for unnamed binding (with underscore '_' ) - in the spirit of unused lambda parameters (see JEP 302 [1]). But where I think you reach the end of the road with that approach is when matching arbitrary expressions. Let's say you want to 'simplify' an expression - that is, given an input expression, you want to construct another expression that is simpler than the one in the input, by recognizing things such as: -N + N = 0 0 + N = N 0 * N = 0 1 * N = N To recognize some of those cases, you need to build more complex patterns; for instance, for the first case you need a pattern like this: case AddNode(NegNode(IntNode(var n1)), IntNode(var n2)) && n1 == n2: ... [sidebar: '&& n1 == n2' is what we call a _guard_ - a binary expression that further controls whether a pattern matches or not] Writing something like the one above without nested patterns would be extremely hard - you could start by checking that the outermost expression is an AddNode, as in your example, but then you would still need 2 dynamic checks for the two nodes, and then a further dynamic check for accessing the guts of the NegNode. In other words, getting at the two int values would be extremely unpleasant and verbose w/o any support for nested patterns. For simpler examples, I'm with you, simpler patterns might be just fine. Maurizio [1] - http://openjdk.java.net/jeps/302 From wshackle at gmail.com Thu Jul 6 14:10:06 2017 From: wshackle at gmail.com (William Shackleford) Date: Thu, 6 Jul 2017 10:10:06 -0400 Subject: Fwd: Comments/Feature Requests regarding JEP 305: Pattern Matching In-Reply-To: References: <4a60efbc-0bc2-552c-4515-3ec10c886034@oracle.com> Message-ID: ( The message below is being forwarded because just hitting reply before looks like it only went only to Maurizio Cimadamore ) ---------- Forwarded message ---------- From: William Shackleford Date: Thu, Jul 6, 2017 at 9:51 AM Subject: Re: Comments/Feature Requests regarding JEP 305: Pattern Matching To: Maurizio Cimadamore I like the guards but I would still like to avoid introducing new new variable names and keeping the syntax simpler. It would be nice if any expression of the form (x instanceof SomeType && ((SomeType)x).field ... where field is some field in SomeType but not in the original static class for x could drop the unnecessary cast to be (x instanceof SomeType && x.field Then case AddNode(NegNode(IntNode(var n1)), IntNode(var n2)) && n1 == n2: ... would be this case AddNode && n.left instanceof NegNode && n.left.n instanceof IntNode && n.right instanceof IntNode && n.left.n.i == n.right.i : I think this makes it much easier to see all of the conditions that have to be true to match here. The same style could be used even if the classes were more general and the fields we needed had nothing to do with the constructor arguments. It doesn't require that I come up with any new variable names. -- Will On Wed, Jul 5, 2017 at 5:03 PM, Maurizio Cimadamore < maurizio.cimadamore at oracle.com> wrote: > > > On 05/07/17 21:34, William Shackleford wrote: > > In addition to being more concise: > n is not both used as the positive part of the NegNode and as the input > parameter. > > Note that this is likely to be a bug in the original example. It is not > possible for a pattern binding to 'shadow' a method parameter name. > > It works with classes that have more fields/methods than constructor > arguments. > It seems to me that is better to consistently use a single syntax style > rather than having one for classes > that have only one or two fields that happen to match the constructor > arguments and another more > general style. This is especially true given that it doesn't even seem to > make the code more concise. > > Generally what you say is true - in many cases you will be able to write > things even without nested patterns. > > It is very likely that at the very least we will add some support for > unnamed binding (with underscore '_' ) - in the spirit of unused lambda > parameters (see JEP 302 [1]). > > But where I think you reach the end of the road with that approach is when > matching arbitrary expressions. Let's say you want to 'simplify' an > expression - that is, given an input expression, you want to construct > another expression that is simpler than the one in the input, by > recognizing things such as: > > -N + N = 0 > 0 + N = N > 0 * N = 0 > 1 * N = N > > To recognize some of those cases, you need to build more complex patterns; > for instance, for the first case you need a pattern like this: > > case AddNode(NegNode(IntNode(var n1)), IntNode(var n2)) && n1 == n2: ... > > [sidebar: '&& n1 == n2' is what we call a _guard_ - a binary expression > that further controls whether a pattern matches or not] > > Writing something like the one above without nested patterns would be > extremely hard - you could start by checking that the outermost expression > is an AddNode, as in your example, but then you would still need 2 dynamic > checks for the two nodes, and then a further dynamic check for accessing > the guts of the NegNode. In other words, getting at the two int values > would be extremely unpleasant and verbose w/o any support for nested > patterns. > > For simpler examples, I'm with you, simpler patterns might be just fine. > > Maurizio > > [1] - http://openjdk.java.net/jeps/302 > From maurizio.cimadamore at oracle.com Thu Jul 6 14:22:54 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 6 Jul 2017 15:22:54 +0100 Subject: Fwd: Comments/Feature Requests regarding JEP 305: Pattern Matching In-Reply-To: References: <4a60efbc-0bc2-552c-4515-3ec10c886034@oracle.com> Message-ID: <2a581631-3b66-1203-439f-0ea31bce9edb@oracle.com> Hi William, what you are suggesting is essentially 'flow typing'. Kotlin achieves something very similar with 'smart casts' - see this discussion [1]. While I think flow typing is a reasonable alternative to nested patterns, I can't help note that your rewritten version of the code I gave is more verbose and indirect. The fact that a pattern can introduce new variable bindings is certainly a novel element in Java - but it's not too different from what happen in other languages which support pattern matching (most notably Scala and C# [3]). As any language feature, it can be abused - and I buy the argument that some programs will make use of unnecessary bindings - but I think there are also programs which can be written a lot more nicely if patterns (esp. nested ones) can introduce binding variables. Maurizio [1] - http://mail.openjdk.java.net/pipermail/amber-spec-experts/2017-March/000006.html [2] - http://docs.scala-lang.org/tutorials/tour/pattern-matching.html [3] - https://docs.microsoft.com/en-us/dotnet/csharp/pattern-matching On 06/07/17 15:10, William Shackleford wrote: > ( The message below is being forwarded because just hitting reply before > looks like it only went only to Maurizio Cimadamore ) > > > ---------- Forwarded message ---------- > From: William Shackleford > Date: Thu, Jul 6, 2017 at 9:51 AM > Subject: Re: Comments/Feature Requests regarding JEP 305: Pattern Matching > To: Maurizio Cimadamore > > > > > I like the guards but I would still like to avoid introducing new new > variable names and keeping the syntax simpler. > > It would be nice if any expression of the form (x instanceof SomeType && > ((SomeType)x).field ... > where field is some field in SomeType but not in the original static class > for x > > could drop the unnecessary cast > > to be (x instanceof SomeType && x.field > > Then > > case AddNode(NegNode(IntNode(var n1)), IntNode(var n2)) && n1 == n2: ... > > > would be this > > > case AddNode > && n.left instanceof NegNode > && n.left.n instanceof IntNode > && n.right instanceof IntNode > && n.left.n.i == n.right.i : > > > I think this makes it much easier to see all of the conditions that have to > be true to match here. > The same style could be used even if the classes were more general and the > fields we needed had nothing to do with > the constructor arguments. > It doesn't require that I come up with any new variable names. > > > -- Will > > > > > > > > > > > > > On Wed, Jul 5, 2017 at 5:03 PM, Maurizio Cimadamore < > maurizio.cimadamore at oracle.com> wrote: > >> >> On 05/07/17 21:34, William Shackleford wrote: >> >> In addition to being more concise: >> n is not both used as the positive part of the NegNode and as the input >> parameter. >> >> Note that this is likely to be a bug in the original example. It is not >> possible for a pattern binding to 'shadow' a method parameter name. >> >> It works with classes that have more fields/methods than constructor >> arguments. >> It seems to me that is better to consistently use a single syntax style >> rather than having one for classes >> that have only one or two fields that happen to match the constructor >> arguments and another more >> general style. This is especially true given that it doesn't even seem to >> make the code more concise. >> >> Generally what you say is true - in many cases you will be able to write >> things even without nested patterns. >> >> It is very likely that at the very least we will add some support for >> unnamed binding (with underscore '_' ) - in the spirit of unused lambda >> parameters (see JEP 302 [1]). >> >> But where I think you reach the end of the road with that approach is when >> matching arbitrary expressions. Let's say you want to 'simplify' an >> expression - that is, given an input expression, you want to construct >> another expression that is simpler than the one in the input, by >> recognizing things such as: >> >> -N + N = 0 >> 0 + N = N >> 0 * N = 0 >> 1 * N = N >> >> To recognize some of those cases, you need to build more complex patterns; >> for instance, for the first case you need a pattern like this: >> >> case AddNode(NegNode(IntNode(var n1)), IntNode(var n2)) && n1 == n2: ... >> >> [sidebar: '&& n1 == n2' is what we call a _guard_ - a binary expression >> that further controls whether a pattern matches or not] >> >> Writing something like the one above without nested patterns would be >> extremely hard - you could start by checking that the outermost expression >> is an AddNode, as in your example, but then you would still need 2 dynamic >> checks for the two nodes, and then a further dynamic check for accessing >> the guts of the NegNode. In other words, getting at the two int values >> would be extremely unpleasant and verbose w/o any support for nested >> patterns. >> >> For simpler examples, I'm with you, simpler patterns might be just fine. >> >> Maurizio >> >> [1] - http://openjdk.java.net/jeps/302 >> From forax at univ-mlv.fr Thu Jul 6 14:39:30 2017 From: forax at univ-mlv.fr (Remi Forax) Date: Thu, 6 Jul 2017 16:39:30 +0200 (CEST) Subject: Comments/Feature Requests regarding JEP 305: Pattern Matching In-Reply-To: References: Message-ID: <392200646.2393541.1499351970146.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "William Shackleford" > ?: amber-dev at openjdk.java.net > Envoy?: Mercredi 5 Juillet 2017 22:34:07 > Objet: Comments/Feature Requests regarding JEP 305: Pattern Matching [...] > > Also : > > int eval(Node n) { > switch(n) { > case IntNode(int i): return i; > case NegNode(Node n): return -eval(n); > case AddNode(Node left, Node right): return eval(left) + > eval(right); > case MulNode(Node left, Node right): return eval(left) * > eval(right); > default: throw new IllegalStateException(n); > }; > } > > > > could be written more concisely as > > > int eval(Node n) { > switch(n) { > case IntNode: return n.i; > case NegNode: return -eval(n.n); > case AddNode: return eval(n.left) + eval(n.right); > case MulNode: return eval(n.left) * eval(n.right); > default: throw new IllegalStateException(n); > }; > } The main issue with your example is that you have lost the encapsulation, a pattern like case AddNode(Node left, Node right) said that you can extract two nodes from AddNode but you have not idea if left and right are stored as field or not in AddNode. There is a nice paper by Ordersky and al. on that subject [1]. > > -- Will regards, R?mi [1] https://infoscience.epfl.ch/record/98468/files/MatchingObjectsWithPatterns-TR.pdf From brian.goetz at oracle.com Thu Jul 6 18:27:22 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Thu, 6 Jul 2017 14:27:22 -0400 Subject: Comments/Feature Requests regarding JEP 305: Pattern Matching In-Reply-To: References: Message-ID: <728c903c-7372-1c28-8454-1e8c0ca0da4f@oracle.com> There are really at least three separate requests here. 1. Don't make me provide a name if I don't need one. 2. Please provide flow-typing so that I can just reuse the target. (And with instanceof too, thanks.) 3. Don't make me provide unique names for every binding. #1 is well in hand; you can always use an unnamed binding (_), and we may make bindings optional as well. #2 sounds nice, but runs out of gas pretty quickly. Sometimes the switch target is not a variable, but an expression; repeating the expression is undesirable (especially if there are side-effects.) #3 is taken care of by our scoping rules. You can re-use binding variable names: case Integer x: case Double x: case Float x: A variant of #2 would be to allow the user to explicitly re-use (and hence shadow) the target: switch (p) { case Integer p: case Double p: case Float p: } We might consider that, as it is in line with another shadowing-related change we're making as part of Lambda Leftovers. On 7/5/2017 4:34 PM, William Shackleford wrote: > In the examples provided in the JEP it looks as though it would always be > required to provide new > variable names each time a pattern match is used. > > Could we eliminate the new variable names or make them optional? > As written it doesn't seem to completely provide the benefits of flow > typing. > > This would have the following benefits. > > 1. It is more compact. > 2. It reduces the number of variable names you need to think of when > writing code. > 3. It reduces the chances of needing one variable name to shadow another. > 4. It is easier to see if a variable is used or modified if it is only > referenced with one name. > > > For example > > String formatted; > switch (p) { > case Integer i: formatted = String.format("int %d", i); break; > case Byte b: formatted = String.format("byte %d", b); break; > case Long l: formatted = String.format("long %d", l); break; > case Double d: formatted = String.format(?double %f", d); break; > case String s: formatted = String.format("String %s", s); break > default: formatted = obj.toString(); > } > > would change to > > > String formatted; > switch (p) { > case Integer: formatted = String.format("int %d", p); break; > case Byte: formatted = String.format("byte %d", p); break; > case Long: formatted = String.format("long %d", p); break; > case Double: formatted = String.format(?double %f", p); break; > case String: formatted = String.format("String %s", p); break > default: formatted = p.toString(); > } > > > In the second one if i,b,l,d,s are other variables in scope there is no > chance of misunderstanding that they have been shadowed by the new > variables. If you look for where is p used, the answer in both cases is all > the format calls but thats easier to > see at a glance in the second example. Generally the variable name p would > give one insight into the source or purpose of that variable which is lost > if you change to a variable name chosen just to indicate the type, or the > variable names end up too long if one always appends the type info to the > source and/or purpose info in the name. > > > Also : > > int eval(Node n) { > switch(n) { > case IntNode(int i): return i; > case NegNode(Node n): return -eval(n); > case AddNode(Node left, Node right): return eval(left) + > eval(right); > case MulNode(Node left, Node right): return eval(left) * > eval(right); > default: throw new IllegalStateException(n); > }; > } > > > > could be written more concisely as > > > int eval(Node n) { > switch(n) { > case IntNode: return n.i; > case NegNode: return -eval(n.n); > case AddNode: return eval(n.left) + eval(n.right); > case MulNode: return eval(n.left) * eval(n.right); > default: throw new IllegalStateException(n); > }; > } > > > In addition to being more concise: > n is not both used as the positive part of the NegNode and as the input > parameter. > It works with classes that have more fields/methods than constructor > arguments. > It seems to me that is better to consistently use a single syntax style > rather than having one for classes > that have only one or two fields that happen to match the constructor > arguments and another more > general style. This is especially true given that it doesn't even seem to > make the code more concise. > > > -- Will From talden at gmail.com Thu Jul 6 20:38:31 2017 From: talden at gmail.com (Aaron Scott-Boddendijk) Date: Fri, 7 Jul 2017 08:38:31 +1200 Subject: Comments/Feature Requests regarding JEP 305: Pattern Matching In-Reply-To: References: <4a60efbc-0bc2-552c-4515-3ec10c886034@oracle.com> Message-ID: I don't know the spec well enough to be sure that there's an atomicity guarantee over the expression for the field access of 'n.left' (and, by extension, 'n.left.n'). Are there multiple field accesses of 'n.left' or are we assured of resolving the field access and storing the value for use in the expression 'n.left.n' later? For performance reasons it _might_ do the access once, but is it a guarantee. If there's no such guarantee, then the type of 'n.left' could change during evaluation of the expression as a whole. Explicitly capturing this with a binding removes any confusion about how the expression should deal with that possibility. The fact that that this simplifies how someone has to think about atomicity handling in this expression probably makes it worthwhile anyway. I presume that Kotlin treats the flow-typing as essentially a capture of the value with newly gained type-information into a shadowing binding of the same name (probably with narrowed scope than the shadowed binding). -- Aaron Scott-Boddendijk On Fri, Jul 7, 2017 at 2:10 AM, William Shackleford wrote: > ( The message below is being forwarded because just hitting reply before > looks like it only went only to Maurizio Cimadamore ) > > > ---------- Forwarded message ---------- > From: William Shackleford > Date: Thu, Jul 6, 2017 at 9:51 AM > Subject: Re: Comments/Feature Requests regarding JEP 305: Pattern Matching > To: Maurizio Cimadamore > > > > > I like the guards but I would still like to avoid introducing new new > variable names and keeping the syntax simpler. > > It would be nice if any expression of the form (x instanceof SomeType && > ((SomeType)x).field ... > where field is some field in SomeType but not in the original static class > for x > > could drop the unnecessary cast > > to be (x instanceof SomeType && x.field > > Then > > case AddNode(NegNode(IntNode(var n1)), IntNode(var n2)) && n1 == n2: ... > > > would be this > > > case AddNode > && n.left instanceof NegNode > && n.left.n instanceof IntNode > && n.right instanceof IntNode > && n.left.n.i == n.right.i : > > > I think this makes it much easier to see all of the conditions that have to > be true to match here. > The same style could be used even if the classes were more general and the > fields we needed had nothing to do with > the constructor arguments. > It doesn't require that I come up with any new variable names. > > > -- Will > > > > > > > > > > > > > On Wed, Jul 5, 2017 at 5:03 PM, Maurizio Cimadamore < > maurizio.cimadamore at oracle.com> wrote: > > > > > > > On 05/07/17 21:34, William Shackleford wrote: > > > > In addition to being more concise: > > n is not both used as the positive part of the NegNode and as the input > > parameter. > > > > Note that this is likely to be a bug in the original example. It is not > > possible for a pattern binding to 'shadow' a method parameter name. > > > > It works with classes that have more fields/methods than constructor > > arguments. > > It seems to me that is better to consistently use a single syntax style > > rather than having one for classes > > that have only one or two fields that happen to match the constructor > > arguments and another more > > general style. This is especially true given that it doesn't even seem to > > make the code more concise. > > > > Generally what you say is true - in many cases you will be able to write > > things even without nested patterns. > > > > It is very likely that at the very least we will add some support for > > unnamed binding (with underscore '_' ) - in the spirit of unused lambda > > parameters (see JEP 302 [1]). > > > > But where I think you reach the end of the road with that approach is > when > > matching arbitrary expressions. Let's say you want to 'simplify' an > > expression - that is, given an input expression, you want to construct > > another expression that is simpler than the one in the input, by > > recognizing things such as: > > > > -N + N = 0 > > 0 + N = N > > 0 * N = 0 > > 1 * N = N > > > > To recognize some of those cases, you need to build more complex > patterns; > > for instance, for the first case you need a pattern like this: > > > > case AddNode(NegNode(IntNode(var n1)), IntNode(var n2)) && n1 == n2: ... > > > > [sidebar: '&& n1 == n2' is what we call a _guard_ - a binary expression > > that further controls whether a pattern matches or not] > > > > Writing something like the one above without nested patterns would be > > extremely hard - you could start by checking that the outermost > expression > > is an AddNode, as in your example, but then you would still need 2 > dynamic > > checks for the two nodes, and then a further dynamic check for accessing > > the guts of the NegNode. In other words, getting at the two int values > > would be extremely unpleasant and verbose w/o any support for nested > > patterns. > > > > For simpler examples, I'm with you, simpler patterns might be just fine. > > > > Maurizio > > > > [1] - http://openjdk.java.net/jeps/302 > > > From maurizio.cimadamore at oracle.com Thu Jul 6 21:56:52 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 21:56:52 +0000 Subject: hg: amber/amber/jdk: 8 new changesets Message-ID: <201707062156.v66Lur3F012206@aojmv0008.oracle.com> Changeset: 76ff72bb6a4a Author: xiaofeya Date: 2017-06-29 18:42 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/76ff72bb6a4a 8182975: Mark http2/BasicTest.java and FixedThreadPoolTest.java as intermittently failing Reviewed-by: rriggs ! test/java/net/httpclient/http2/BasicTest.java ! test/java/net/httpclient/http2/FixedThreadPoolTest.java Changeset: e48ebdce5b14 Author: rriggs Date: 2017-06-30 13:28 -0400 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/e48ebdce5b14 8183019: Diagnostics for onExitTest Reviewed-by: clanger ! test/java/lang/ProcessHandle/OnExitTest.java Changeset: 7a2bc0a80087 Author: clanger Date: 2017-07-01 20:35 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/7a2bc0a80087 8182743: Ineffective use of volatile hurts performance of Charset.atBugLevel() Reviewed-by: clanger, redestad, plevart, coffeys Contributed-by: ogatak at jp.ibm.com ! src/java.base/share/classes/java/nio/charset/Charset-X-Coder.java.template ! src/java.base/share/classes/java/nio/charset/Charset.java ! test/java/nio/charset/Charset/EmptyCharsetName.java ! test/java/nio/charset/CharsetDecoder/AverageMax.java Changeset: e99004ee6f13 Author: naoto Date: 2017-07-03 12:54 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/e99004ee6f13 8160199: Language's script should be reflected in user.script on Mac OS X Reviewed-by: bchristi, sherman ! src/java.base/macosx/native/libjava/java_props_macosx.c ! src/java.base/macosx/native/libjava/java_props_macosx.h ! src/java.base/unix/native/libjava/locale_str.h Changeset: c59351ecfea3 Author: amlu Date: 2017-07-05 08:26 +0800 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/c59351ecfea3 8183531: Wrong @modules in test javax/net/ssl/ciphersuites/ECCurvesconstraints.java Reviewed-by: wetmore, xuelei ! test/javax/net/ssl/ciphersuites/ECCurvesconstraints.java Changeset: 92772660d9dc Author: amlu Date: 2017-07-05 08:30 +0800 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/92772660d9dc 8183512: Remove intermittent key from nio test Transfer4GBFile.java TransferTo6GBFile.java and StressLoopback.java Reviewed-by: alanb ! test/java/nio/channels/AsynchronousSocketChannel/StressLoopback.java ! test/java/nio/channels/FileChannel/Transfer4GBFile.java ! test/java/nio/channels/FileChannel/TransferTo6GBFile.java Changeset: 36746d41ce49 Author: xiaofeya Date: 2017-07-04 18:49 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/36746d41ce49 8183514: Remove intermittent key from httpclient test TimeoutOrdering and ErrorTest Reviewed-by: dfuchs ! test/java/net/httpclient/TimeoutOrdering.java ! test/java/net/httpclient/http2/ErrorTest.java Changeset: 9dcc29929c85 Author: alanb Date: 2017-07-05 13:30 +0100 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/9dcc29929c85 8183536: Update jdk tests to allow for unique test classes directory Reviewed-by: lancea ! test/java/lang/ModuleTests/AnnotationsTest.java ! test/java/lang/invoke/DefineClassTest.java ! test/java/lang/module/ConfigurationTest.java ! test/java/lang/module/customfs/ModulesInCustomFileSystem.java ! test/java/nio/channels/AsynchronousChannelGroup/SetupJar.java ! test/java/util/ServiceLoader/ModulesTest.java From maurizio.cimadamore at oracle.com Thu Jul 6 21:56:55 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 21:56:55 +0000 Subject: hg: amber/amber/hotspot: 8183503: Update hotspot tests to allow for unique test classes directory Message-ID: <201707062156.v66LutgK012441@aojmv0008.oracle.com> Changeset: d864b3a8ff52 Author: alanb Date: 2017-07-05 13:25 +0100 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/d864b3a8ff52 8183503: Update hotspot tests to allow for unique test classes directory Reviewed-by: iklam ! test/compiler/classUnloading/anonymousClass/TestAnonymousClassUnloading.java ! test/runtime/logging/ClassLoadUnloadTest.java ! test/runtime/testlibrary/ClassUnloadCommon.java From maurizio.cimadamore at oracle.com Thu Jul 6 21:56:57 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 21:56:57 +0000 Subject: hg: amber/amber/jaxp: 8183583: LSSerializer docs have invalid character Message-ID: <201707062156.v66Luvwk012455@aojmv0008.oracle.com> Changeset: f0aabb2fef5b Author: joehw Date: 2017-07-05 14:41 -0700 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/f0aabb2fef5b 8183583: LSSerializer docs have invalid character Reviewed-by: lancea ! src/java.xml/share/classes/org/w3c/dom/ls/LSSerializer.java From maurizio.cimadamore at oracle.com Thu Jul 6 21:56:59 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 21:56:59 +0000 Subject: hg: amber/amber/langtools: 6 new changesets Message-ID: <201707062156.v66LuxWq012493@aojmv0008.oracle.com> Changeset: 0b74aa85c3c5 Author: vromero Date: 2017-06-30 05:47 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/0b74aa85c3c5 8182047: javac compile error on type-parameter-exceptions in lambda expressions Reviewed-by: mcimadamore ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/T8182047/CorrectGenerationOfExConstraintsTest.java Changeset: 34ad0d38103d Author: jlahoda Date: 2017-06-30 20:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/34ad0d38103d 8183021: JShell tests: Fix failing tests on Windows Reviewed-by: jjg, rfield ! test/jdk/jshell/ToolBasicTest.java ! test/jdk/jshell/ToolMultilineSnippetHistoryTest.java ! test/jdk/jshell/UITesting.java Changeset: add6717b655e Author: sadayapalam Date: 2017-07-03 12:58 +0530 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/add6717b655e 8068836: Error message should be updated when Override is used with static methods Summary: Issue a more direct, specific error when @Override annotation is used with a static method Reviewed-by: sadayapalam Contributed-by: priya.lakshmi.muthuswamy at oracle.com ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/annotations/6359949/T6359949a.java ! test/tools/javac/annotations/6359949/T6359949a.out + test/tools/javac/diags/examples/OverrideAnnotatedStaticMethod.java Changeset: 6f15d35d31df Author: ksrini Date: 2017-07-05 13:46 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/6f15d35d31df 8179704: doclet crashes with an empty package.html Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! test/jdk/javadoc/doclet/testPackageHtml/TestPackageHtml.java + test/jdk/javadoc/doclet/testPackageHtml/pkg2/X.java + test/jdk/javadoc/doclet/testPackageHtml/pkg2/package.html + test/jdk/javadoc/doclet/testPackageHtml/pkg3/X.java + test/jdk/javadoc/doclet/testPackageHtml/pkg3/package.html + test/jdk/javadoc/doclet/testPackageHtml/pkg4/X.java + test/jdk/javadoc/doclet/testPackageHtml/pkg4/package.html Changeset: 813863b6154b Author: jjg Date: 2017-07-05 14:36 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/813863b6154b 8183505: Update langtools tests to allow for unique test classes directory Reviewed-by: alanb ! test/tools/javadoc/8147801/T8147801.java ! test/tools/jdeprscan/tests/jdk/jdeprscan/TestLoad.java ! test/tools/jdeprscan/tests/jdk/jdeprscan/TestScan.java ! test/tools/jdeps/MultiReleaseJar.java Changeset: ecb84dbdcf84 Author: vromero Date: 2017-07-05 19:57 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/ecb84dbdcf84 8183126: port improvements to analyzers from lvti repo to jdk10 Reviewed-by: mcimadamore, jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Analyzer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! test/tools/javac/lambda/LambdaConv18.java ! test/tools/javac/lambda/LambdaConv18.out + test/tools/javac/lambda/LambdaConv29.java + test/tools/javac/lambda/LambdaConv29.out From maurizio.cimadamore at oracle.com Thu Jul 6 22:01:48 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:01:48 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707062201.v66M1mdd015319@aojmv0008.oracle.com> Changeset: b08656ba35ba Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-06 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/b08656ba35ba Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:01:50 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:01:50 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707062201.v66M1oMt015477@aojmv0008.oracle.com> Changeset: 9ecce7630399 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-06 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/9ecce7630399 Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 6 22:01:52 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:01:52 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707062201.v66M1qBN015531@aojmv0008.oracle.com> Changeset: 948e0fdfa3ca Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-06 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/948e0fdfa3ca Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:01:51 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:01:51 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707062201.v66M1pvN015494@aojmv0008.oracle.com> Changeset: f3b2541b0105 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-06 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/f3b2541b0105 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:02:22 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:02:22 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707062202.v66M2MHq017189@aojmv0008.oracle.com> Changeset: f5ce87282ad7 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/f5ce87282ad7 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:02:21 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:02:21 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707062202.v66M2LrZ017126@aojmv0008.oracle.com> Changeset: 9098adde6129 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/9098adde6129 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:02:23 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:02:23 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707062202.v66M2NEh017222@aojmv0008.oracle.com> Changeset: 28a84b744307 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/28a84b744307 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:02:25 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:02:25 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707062202.v66M2PvD017247@aojmv0008.oracle.com> Changeset: c1f1383cb029 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/c1f1383cb029 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:02:52 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:02:52 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707062202.v66M2qEj018970@aojmv0008.oracle.com> Changeset: 2b063e5762a7 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/2b063e5762a7 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:02:57 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:02:57 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707062202.v66M2whv019376@aojmv0008.oracle.com> Changeset: 2269af561dea Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/2269af561dea Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:02:56 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:02:56 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707062202.v66M2uR8019326@aojmv0008.oracle.com> Changeset: 5b6b80c411ef Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/5b6b80c411ef Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java From maurizio.cimadamore at oracle.com Thu Jul 6 22:02:59 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:02:59 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707062203.v66M30T5019442@aojmv0008.oracle.com> Changeset: 9d272b01f379 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/9d272b01f379 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:03:29 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:03:29 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707062203.v66M3TRe021108@aojmv0008.oracle.com> Changeset: ba577a0e3c7e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/ba577a0e3c7e Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:03:32 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:03:32 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707062203.v66M3Wwh021168@aojmv0008.oracle.com> Changeset: 1103d3e4cd75 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/1103d3e4cd75 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:03:31 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:03:31 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707062203.v66M3VE4021165@aojmv0008.oracle.com> Changeset: dd535c37a674 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/dd535c37a674 Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 6 22:03:32 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:03:32 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707062203.v66M3XKv021174@aojmv0008.oracle.com> Changeset: 3c679ba3ed6a Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/3c679ba3ed6a Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:04:02 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:04:02 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707062204.v66M429V022518@aojmv0008.oracle.com> Changeset: 02fbbdd2b158 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/02fbbdd2b158 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:04:03 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:04:03 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707062204.v66M43Nh022610@aojmv0008.oracle.com> Changeset: c006f9343c3a Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/c006f9343c3a Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:04:05 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:04:05 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707062204.v66M45oU022665@aojmv0008.oracle.com> Changeset: bde6ba76bb78 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/bde6ba76bb78 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 22:04:06 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:04:06 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707062204.v66M466b022668@aojmv0008.oracle.com> Changeset: e252d2108d3c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/e252d2108d3c Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 6 22:04:38 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:04:38 +0000 Subject: hg: amber/amber/langtools: Automatic merge with constant-folding Message-ID: <201707062204.v66M4ciw024032@aojmv0008.oracle.com> Changeset: 703705619b64 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/703705619b64 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 6 22:04:37 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:04:37 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with constant-folding Message-ID: <201707062204.v66M4bOH024029@aojmv0008.oracle.com> Changeset: 462190800d29 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/462190800d29 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 6 22:04:36 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 22:04:36 +0000 Subject: hg: amber/amber/jdk: Automatic merge with constant-folding Message-ID: <201707062204.v66M4aSe024026@aojmv0008.oracle.com> Changeset: 9b921d5b799a Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/9b921d5b799a Automatic merge with constant-folding From john.r.rose at oracle.com Thu Jul 6 22:48:24 2017 From: john.r.rose at oracle.com (John Rose) Date: Thu, 6 Jul 2017 15:48:24 -0700 Subject: Comments/Feature Requests regarding JEP 305: Pattern Matching In-Reply-To: <728c903c-7372-1c28-8454-1e8c0ca0da4f@oracle.com> References: <728c903c-7372-1c28-8454-1e8c0ca0da4f@oracle.com> Message-ID: <22FC33FD-0E31-4832-818A-D8F8BF0CC29F@oracle.com> On Jul 6, 2017, at 11:27 AM, Brian Goetz wrote: > > A variant of #2 would be to allow the user to explicitly re-use (and hence shadow) the target: > > switch (p) { > case Integer p: > case Double p: > case Float p: > } > > We might consider that, as it is in line with another shadowing-related change we're making as part of Lambda Leftovers. +10 on this. It is "poor man's flow-typing", and the explicit separate bindings remove a bunch of unpleasant complexity that real flow-typing suffers from. (BTW: The new p bindings are all 'final', right? You can't say "p=q" later on in the switch, and then get surprised about the resulting paradoxes.) ? John From maurizio.cimadamore at oracle.com Thu Jul 6 23:36:52 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:36:52 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with constant-folding Message-ID: <201707062336.v66NaqAC027312@aojmv0008.oracle.com> Changeset: 27925df6a6b2 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/27925df6a6b2 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 6 23:38:14 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:38:14 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with condy Message-ID: <201707062338.v66NcEcO001183@aojmv0008.oracle.com> Changeset: 35641e7a6d58 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 01:36 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/35641e7a6d58 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 6 23:38:12 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:38:12 +0000 Subject: hg: amber/amber/langtools: Automatic merge with condy Message-ID: <201707062338.v66NcC7t001027@aojmv0008.oracle.com> Changeset: d43d18eda99f Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 01:36 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/d43d18eda99f Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 6 23:38:15 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:38:15 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with condy Message-ID: <201707062338.v66NcFoM001194@aojmv0008.oracle.com> Changeset: cd98d8e3c5ed Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 01:36 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/cd98d8e3c5ed Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 6 23:38:16 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:38:16 +0000 Subject: hg: amber/amber/jdk: Automatic merge with condy Message-ID: <201707062338.v66NcG3v001197@aojmv0008.oracle.com> Changeset: b17814e77647 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 01:36 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/b17814e77647 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 6 23:53:12 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:53:12 +0000 Subject: hg: amber/amber/langtools: manual merge Message-ID: <201707062353.v66NrCj4006061@aojmv0008.oracle.com> Changeset: dc9c0ca425c7 Author: mcimadamore Date: 2017-07-07 00:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/dc9c0ca425c7 manual merge ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Analyzer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/lambda/LambdaConv18.java ! test/tools/javac/lambda/LambdaConv18.out From maurizio.cimadamore at oracle.com Thu Jul 6 23:54:45 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:54:45 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707062354.v66Nsjsb009090@aojmv0008.oracle.com> Changeset: 67bc5af4c3cc Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 01:52 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/67bc5af4c3cc Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 23:54:43 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:54:43 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707062354.v66Nshft008958@aojmv0008.oracle.com> Changeset: a6ae45cc3cb1 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 01:52 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/a6ae45cc3cb1 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 6 23:54:47 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 06 Jul 2017 23:54:47 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707062354.v66NslYw009097@aojmv0008.oracle.com> Changeset: 6bff54557687 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-07 01:52 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/6bff54557687 Automatic merge with default From org.openjdk at io7m.com Fri Jul 7 14:47:43 2017 From: org.openjdk at io7m.com (Mark Raynsford) Date: Fri, 7 Jul 2017 14:47:43 +0000 Subject: [patterns] Pattern matching In-Reply-To: <20170630211514.3e38a613@copperhead.int.arc7.info> References: <20170630204446.5e1da5dd@copperhead.int.arc7.info> <545674659.3067387.1498856330010.JavaMail.zimbra@u-pem.fr> <20170630211514.3e38a613@copperhead.int.arc7.info> Message-ID: <20170701092446.314387f4@copperhead.int.arc7.info> Hello. I'm lagging behind the discussion a little; I've been having mail delivery issues which are hopefully now corrected. Could I verify that I have the right branch and commit to build the patterns prototype? My working directory: $ hg branch patterns $ hg log -l 1 changeset: 2831:fdecf272d639 branch: patterns tag: tip parent: 2823:1fd5901544ac user: gbierman date: Fri Jun 30 16:35:59 2017 +0100 summary: Initial changes for patterns branch $ grep -rl __match . $ The JDK that was built from the above doesn't seem to know anything about __match or __matches, so I'm assuming that I've somehow not built the right sources... M From maurizio.cimadamore at oracle.com Fri Jul 7 15:08:00 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Fri, 7 Jul 2017 16:08:00 +0100 Subject: [patterns] Pattern matching In-Reply-To: <20170701092446.314387f4@copperhead.int.arc7.info> References: <20170630204446.5e1da5dd@copperhead.int.arc7.info> <545674659.3067387.1498856330010.JavaMail.zimbra@u-pem.fr> <20170630211514.3e38a613@copperhead.int.arc7.info> <20170701092446.314387f4@copperhead.int.arc7.info> Message-ID: <341cddf4-700e-c788-09d4-b419ba982564@oracle.com> The changeset you show is the right 'tip' for the toplevel repo. If you go inside the 'langtools' folder, and do hg tip what does it print? Maurizio On 07/07/17 15:47, Mark Raynsford wrote: > Hello. I'm lagging behind the discussion a little; I've been having > mail delivery issues which are hopefully now corrected. > > Could I verify that I have the right branch and commit to build the > patterns prototype? > > My working directory: > > $ hg branch > patterns > > $ hg log -l 1 > changeset: 2831:fdecf272d639 > branch: patterns > tag: tip > parent: 2823:1fd5901544ac > user: gbierman > date: Fri Jun 30 16:35:59 2017 +0100 > summary: Initial changes for patterns branch > > $ grep -rl __match . > $ > > The JDK that was built from the above doesn't seem to know anything > about __match or __matches, so I'm assuming that I've somehow not built > the right sources... > > M From org.openjdk at io7m.com Fri Jul 7 15:12:30 2017 From: org.openjdk at io7m.com (Mark Raynsford) Date: Fri, 7 Jul 2017 15:12:30 +0000 Subject: [patterns] Pattern matching In-Reply-To: <341cddf4-700e-c788-09d4-b419ba982564@oracle.com> References: <20170630204446.5e1da5dd@copperhead.int.arc7.info> <545674659.3067387.1498856330010.JavaMail.zimbra@u-pem.fr> <20170630211514.3e38a613@copperhead.int.arc7.info> <20170701092446.314387f4@copperhead.int.arc7.info> <341cddf4-700e-c788-09d4-b419ba982564@oracle.com> Message-ID: <20170707151230.139d5f0d@copperhead.int.arc7.info> Hello! On 2017-07-07T16:08:00 +0100 Maurizio Cimadamore wrote: > The changeset you show is the right 'tip' for the toplevel repo. If you > go inside the 'langtools' folder, and do > > hg tip > > what does it print? $ hg tip changeset: 4423:be8da3a33d15 branch: patterns tag: tip user: gbierman date: Fri Jun 30 17:03:28 2017 +0100 summary: Prototype for pattern matching M From amaembo at gmail.com Fri Jul 7 15:21:28 2017 From: amaembo at gmail.com (Tagir Valeev) Date: Fri, 7 Jul 2017 18:21:28 +0300 Subject: [patterns] Destructuring without matching? Message-ID: Hello! Sometimes it's reasonable to deconstruct the object of known type. A classical example is Map.Entry. E.g. currently I can write: // Map wordCounts wordCounts.entrySet().stream() .filter(e -> e.getValue() > 10) .map(e -> e.getKey()+": "+e.getValue()) .forEach(System.out::println); It's desired to refer by concrete name to key and value like this: wordCounts.entrySet().stream() .filter((_, count) -> count > 10) .map((word, count) -> word+": "+count) .forEach(System.out::println); Of course such syntax is not possible. Reading pattern matching proposal I thought whether it could solve this somehow. I see these alternatives: wordCounts.entrySet().stream() .filter(e -> e matches Entry(_, count) && count > 10) .map(e -> e matches Entry(word, count) ? word+": "+count : null) .forEach(System.out::println); Or wordCounts.entrySet().stream() .filter(e -> exprswitch(e) {case Entry(_, count) -> count > 10; default -> false;}) .map(e -> exprswitch(e) {case Entry(word, count) -> word+": "+count; default -> null;}) .forEach(System.out::println); In the latter case default branch is redundant as we know that e is always an Entry. Probably compiler could figure out this as well and do not require default branch? In this case exprswitch will have only one branch and looks too verbose. The matches operator case is shorter, but also has redundant : null. It would be nice to develop a separate simpler syntax for deconstruction without matching. Probably lambda/method parameter could be deconstructed at declaration point like wordCounts.entrySet().stream() .filter(Entry(_, count) -> count > 10) .map(Entry(word, count) -> word+": "+count) .forEach(System.out::println); What do you think? With best regards, Tagir Valeev. From maurizio.cimadamore at oracle.com Fri Jul 7 15:21:46 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Fri, 7 Jul 2017 16:21:46 +0100 Subject: [patterns] Pattern matching In-Reply-To: <20170707151230.139d5f0d@copperhead.int.arc7.info> References: <20170630204446.5e1da5dd@copperhead.int.arc7.info> <545674659.3067387.1498856330010.JavaMail.zimbra@u-pem.fr> <20170630211514.3e38a613@copperhead.int.arc7.info> <20170701092446.314387f4@copperhead.int.arc7.info> <341cddf4-700e-c788-09d4-b419ba982564@oracle.com> <20170707151230.139d5f0d@copperhead.int.arc7.info> Message-ID: <4ce3b70e-ae1c-990b-3cd7-770424385fca@oracle.com> That looks a bit behind - but nothing out of the ordinary. To make sure we're doing the right thing, go in the toplevel dir and execute following commands: sh get_source.sh sh common/bin/hgforest update patterns make clean make images My suspect is that you have updated to the right branch for the toplevel repo, but not for all the other repos. Maurizio On 07/07/17 16:12, Mark Raynsford wrote: > Hello! > > On 2017-07-07T16:08:00 +0100 > Maurizio Cimadamore wrote: >> The changeset you show is the right 'tip' for the toplevel repo. If you >> go inside the 'langtools' folder, and do >> >> hg tip >> >> what does it print? > $ hg tip > changeset: 4423:be8da3a33d15 > branch: patterns > tag: tip > user: gbierman > date: Fri Jun 30 17:03:28 2017 +0100 > summary: Prototype for pattern matching > > M From org.openjdk at io7m.com Fri Jul 7 15:34:42 2017 From: org.openjdk at io7m.com (Mark Raynsford) Date: Fri, 7 Jul 2017 15:34:42 +0000 Subject: [patterns] Pattern matching In-Reply-To: <4ce3b70e-ae1c-990b-3cd7-770424385fca@oracle.com> References: <20170630204446.5e1da5dd@copperhead.int.arc7.info> <545674659.3067387.1498856330010.JavaMail.zimbra@u-pem.fr> <20170630211514.3e38a613@copperhead.int.arc7.info> <20170701092446.314387f4@copperhead.int.arc7.info> <341cddf4-700e-c788-09d4-b419ba982564@oracle.com> <20170707151230.139d5f0d@copperhead.int.arc7.info> <4ce3b70e-ae1c-990b-3cd7-770424385fca@oracle.com> Message-ID: <20170707153442.14001453@copperhead.int.arc7.info> On 2017-07-07T16:21:46 +0100 Maurizio Cimadamore wrote: > > To make sure we're doing the right thing, go in the toplevel dir and > execute following commands: > > sh get_source.sh > sh common/bin/hgforest update patterns > make clean > make images > > > My suspect is that you have updated to the right branch for the toplevel > repo, but not for all the other repos. Got it, thanks! I'll run these now and report back. M From brian.goetz at oracle.com Fri Jul 7 15:34:51 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 7 Jul 2017 11:34:51 -0400 Subject: [patterns] Destructuring without matching? In-Reply-To: References: Message-ID: <075730fd-9987-d265-5e49-bf017a876f8b@oracle.com> On 7/7/2017 11:21 AM, Tagir Valeev wrote: > Hello! > > Sometimes it's reasonable to deconstruct the object of known type. A > classical example is Map.Entry. E.g. currently I can write: > > // Map wordCounts > wordCounts.entrySet().stream() > .filter(e -> e.getValue() > 10) > .map(e -> e.getKey()+": "+e.getValue()) > .forEach(System.out::println); > > It's desired to refer by concrete name to key and value like this: > > wordCounts.entrySet().stream() > .filter((_, count) -> count > 10) > .map((word, count) -> word+": "+count) > .forEach(System.out::println); > > Of course such syntax is not possible. Reading pattern matching proposal I > thought whether it could solve this somehow. I see these alternatives: > > wordCounts.entrySet().stream() > .filter(e -> e matches Entry(_, count) && count > 10) > .map(e -> e matches Entry(word, count) ? word+": "+count : null) > .forEach(System.out::println); > > Or > > wordCounts.entrySet().stream() > .filter(e -> exprswitch(e) {case Entry(_, count) -> count > 10; default > -> false;}) > .map(e -> exprswitch(e) {case Entry(word, count) -> word+": "+count; > default -> null;}) > .forEach(System.out::println); > > In the latter case default branch is redundant as we know that e is always > an Entry. Probably compiler could figure out this as well and do not > require default branch? In this case exprswitch will have only one branch > and looks too verbose. Not so fast! We know that its static type is Entry, but it might be null. In which case it would be foolish to try to let it match Entry(var w, var c) -- because once we cast to Entry, we'll NPE immediately when we try to extract the word/count components. (See the recent writeup on patterns and nullity on amber-spec-experts.) Without nullity information in the type system, that pesky default branch is actually needed. From org.openjdk at io7m.com Fri Jul 7 16:58:23 2017 From: org.openjdk at io7m.com (Mark Raynsford) Date: Fri, 7 Jul 2017 16:58:23 +0000 Subject: [patterns] Pattern matching In-Reply-To: <20170707153442.14001453@copperhead.int.arc7.info> References: <20170630204446.5e1da5dd@copperhead.int.arc7.info> <545674659.3067387.1498856330010.JavaMail.zimbra@u-pem.fr> <20170630211514.3e38a613@copperhead.int.arc7.info> <20170701092446.314387f4@copperhead.int.arc7.info> <341cddf4-700e-c788-09d4-b419ba982564@oracle.com> <20170707151230.139d5f0d@copperhead.int.arc7.info> <4ce3b70e-ae1c-990b-3cd7-770424385fca@oracle.com> <20170707153442.14001453@copperhead.int.arc7.info> Message-ID: <20170707165823.42b136ca@copperhead.int.arc7.info> On 2017-07-07T15:34:42 +0000 Mark Raynsford wrote: > > > My suspect is that you have updated to the right branch for the toplevel > > repo, but not for all the other repos. That seems to have been it. javac recognizes "__match" now. Thanks again. M From amaembo at gmail.com Fri Jul 7 18:51:32 2017 From: amaembo at gmail.com (Tagir Valeev) Date: Fri, 7 Jul 2017 21:51:32 +0300 Subject: [patterns] Destructuring without matching? In-Reply-To: <075730fd-9987-d265-5e49-bf017a876f8b@oracle.com> References: <075730fd-9987-d265-5e49-bf017a876f8b@oracle.com> Message-ID: Argh, those nulls. Well, they gradually becoming non-grata in Java, so probably it would be good to throw NPE in case if null appears at unconditional deconstruction. After all when method called with (Integer)null while expects primitive int, you'll got an NPE even though you have no explicit dereference. Unboxing is pretty similar to deconstruction, actually deconstruction of Integer would work like unboxing, so such behavior looks consistent to me. With best regards, Tagir Valeev. 7 ???? 2017 ?. 6:35 PM ???????????? "Brian Goetz" ???????: On 7/7/2017 11:21 AM, Tagir Valeev wrote: > Hello! > > Sometimes it's reasonable to deconstruct the object of known type. A > classical example is Map.Entry. E.g. currently I can write: > > // Map wordCounts > wordCounts.entrySet().stream() > .filter(e -> e.getValue() > 10) > .map(e -> e.getKey()+": "+e.getValue()) > .forEach(System.out::println); > > It's desired to refer by concrete name to key and value like this: > > wordCounts.entrySet().stream() > .filter((_, count) -> count > 10) > .map((word, count) -> word+": "+count) > .forEach(System.out::println); > > Of course such syntax is not possible. Reading pattern matching proposal I > thought whether it could solve this somehow. I see these alternatives: > > wordCounts.entrySet().stream() > .filter(e -> e matches Entry(_, count) && count > 10) > .map(e -> e matches Entry(word, count) ? word+": "+count : null) > .forEach(System.out::println); > > Or > > wordCounts.entrySet().stream() > .filter(e -> exprswitch(e) {case Entry(_, count) -> count > 10; default > -> false;}) > .map(e -> exprswitch(e) {case Entry(word, count) -> word+": "+count; > default -> null;}) > .forEach(System.out::println); > > In the latter case default branch is redundant as we know that e is always > an Entry. Probably compiler could figure out this as well and do not > require default branch? In this case exprswitch will have only one branch > and looks too verbose. > Not so fast! We know that its static type is Entry, but it might be null. In which case it would be foolish to try to let it match Entry(var w, var c) -- because once we cast to Entry, we'll NPE immediately when we try to extract the word/count components. (See the recent writeup on patterns and nullity on amber-spec-experts.) Without nullity information in the type system, that pesky default branch is actually needed. From brian.goetz at oracle.com Fri Jul 7 19:42:32 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 7 Jul 2017 15:42:32 -0400 Subject: [patterns] Destructuring without matching? In-Reply-To: References: <075730fd-9987-d265-5e49-bf017a876f8b@oracle.com> Message-ID: <2a05c967-983b-b5e4-454f-a45eb4a47b8a@oracle.com> I think it would be pretty unreasonable for if (x matches Point(var x, var y)) { ... } to NPE, which is basically what you're arguing for. Failure to match should result in a boolean false, not an exception. On 7/7/2017 2:51 PM, Tagir Valeev wrote: > Argh, those nulls. Well, they gradually becoming non-grata in Java, so > probably it would be good to throw NPE in case if null appears at > unconditional deconstruction. After all when method called with > (Integer)null while expects primitive int, you'll got an NPE even > though you have no explicit dereference. Unboxing is pretty similar to > deconstruction, actually deconstruction of Integer would work like > unboxing, so such behavior looks consistent to me. > > With best regards, > Tagir Valeev. > > 7 ???? 2017 ?. 6:35 PM ???????????? "Brian Goetz" > > ???????: > > > > On 7/7/2017 11:21 AM, Tagir Valeev wrote: > > Hello! > > Sometimes it's reasonable to deconstruct the object of known > type. A > classical example is Map.Entry. E.g. currently I can write: > > // Map wordCounts > wordCounts.entrySet().stream() > .filter(e -> e.getValue() > 10) > .map(e -> e.getKey()+": "+e.getValue()) > .forEach(System.out::println); > > It's desired to refer by concrete name to key and value like this: > > wordCounts.entrySet().stream() > .filter((_, count) -> count > 10) > .map((word, count) -> word+": "+count) > .forEach(System.out::println); > > Of course such syntax is not possible. Reading pattern > matching proposal I > thought whether it could solve this somehow. I see these > alternatives: > > wordCounts.entrySet().stream() > .filter(e -> e matches Entry(_, count) && count > 10) > .map(e -> e matches Entry(word, count) ? word+": "+count : > null) > .forEach(System.out::println); > > Or > > wordCounts.entrySet().stream() > .filter(e -> exprswitch(e) {case Entry(_, count) -> count > > 10; default > -> false;}) > .map(e -> exprswitch(e) {case Entry(word, count) -> word+": > "+count; > default -> null;}) > .forEach(System.out::println); > > In the latter case default branch is redundant as we know that > e is always > an Entry. Probably compiler could figure out this as well and > do not > require default branch? In this case exprswitch will have only > one branch > and looks too verbose. > > > Not so fast! We know that its static type is Entry, but it might > be null. In which case it would be foolish to try to let it match > Entry(var w, var c) -- because once we cast to Entry, we'll NPE > immediately when we try to extract the word/count components. > (See the recent writeup on patterns and nullity on > amber-spec-experts.) Without nullity information in the type > system, that pesky default branch is actually needed. > > > From forax at univ-mlv.fr Fri Jul 7 19:59:51 2017 From: forax at univ-mlv.fr (Remi Forax) Date: Fri, 7 Jul 2017 21:59:51 +0200 (CEST) Subject: [patterns] Destructuring without matching? In-Reply-To: References: Message-ID: <346369122.3138667.1499457591958.JavaMail.zimbra@u-pem.fr> Hi Tagir, ----- Mail original ----- > De: "Tagir Valeev" > ?: amber-dev at openjdk.java.net > Envoy?: Vendredi 7 Juillet 2017 17:21:28 > Objet: [patterns] Destructuring without matching? > Hello! > > Sometimes it's reasonable to deconstruct the object of known type. A > classical example is Map.Entry. E.g. currently I can write: > > // Map wordCounts > wordCounts.entrySet().stream() > .filter(e -> e.getValue() > 10) > .map(e -> e.getKey()+": "+e.getValue()) > .forEach(System.out::println); > > It's desired to refer by concrete name to key and value like this: > > wordCounts.entrySet().stream() > .filter((_, count) -> count > 10) > .map((word, count) -> word+": "+count) > .forEach(System.out::println); > > Of course such syntax is not possible. Reading pattern matching proposal I > thought whether it could solve this somehow. I see these alternatives: > > wordCounts.entrySet().stream() > .filter(e -> e matches Entry(_, count) && count > 10) > .map(e -> e matches Entry(word, count) ? word+": "+count : null) > .forEach(System.out::println); > > Or > > wordCounts.entrySet().stream() > .filter(e -> exprswitch(e) {case Entry(_, count) -> count > 10; default > -> false;}) > .map(e -> exprswitch(e) {case Entry(word, count) -> word+": "+count; > default -> null;}) > .forEach(System.out::println); > > In the latter case default branch is redundant as we know that e is always > an Entry. Probably compiler could figure out this as well and do not > require default branch? In this case exprswitch will have only one branch > and looks too verbose. yes, the compiler can figure that you do not need a default branch. But for what you want you do not need to match/switch on things, you just want destructuration. I think it's better to have a new operator, let call it 'let' that does the same destructuration that the pattern matching does, wordCounts.entrySet().stream() .filter(e -> let (_, count) = e; count > 10) .map(e -> let(word, count) = e; word+": "+count) .forEach(System.out::println); and given that we already have a way to support string interpolation in the JDK (StringConcatFactory), you can even add String interpolation in the mix, wordCounts.entrySet().stream() .filter(e -> let (_, count) = e; count > 10) .map(e -> let (word, count) = e; ''$(word): $(count)'') .forEach(System.out::println); (you need a way to said that a String is interpolated, i've chosen '' (quotequote) which is close to " and currently invalid) and with values types (thus tuples), you can write it that way, wordCounts.entrySet().stream() .map(e -> let (word, count) = e; (word, count)) .filter((_, count) -> count > 10) .map((word, count) -> ''$(word): $(count)'') .forEach(System.out::println); regards, R?mi > Tagir Valeev. From vicente.romero at oracle.com Sat Jul 8 18:37:47 2017 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sat, 08 Jul 2017 18:37:47 +0000 Subject: hg: amber/amber/langtools: 8184038: disallow the use of underscore for unnamed method parameters Message-ID: <201707081837.v68Ibl92028679@aojmv0008.oracle.com> Changeset: 371b0a8954a2 Author: vromero Date: 2017-07-08 10:43 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/371b0a8954a2 8184038: disallow the use of underscore for unnamed method parameters ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Log.java ! test/tools/javac/diags/examples/UnderscoreCantBeFollowedByDims.java + test/tools/javac/diags/examples/UnderscoreInMethodParameters.java ! test/tools/javac/lambda_leftovers/UnderscoreCantBeFollowedByDimsTest.out ! test/tools/javac/lambda_leftovers/UnderscoreInMethodsTest.out - test/tools/javac/lambda_leftovers/UnderscoreInMethodsTest2.java - test/tools/javac/lambda_leftovers/UnderscoreInMethodsTest2.out From amaembo at gmail.com Sun Jul 9 02:22:26 2017 From: amaembo at gmail.com (Tagir Valeev) Date: Sun, 9 Jul 2017 05:22:26 +0300 Subject: [patterns] Destructuring without matching? In-Reply-To: <346369122.3138667.1499457591958.JavaMail.zimbra@u-pem.fr> References: <346369122.3138667.1499457591958.JavaMail.zimbra@u-pem.fr> Message-ID: Hello, Remi, Brian! Yes, I was thinking about separate operator / syntax construct like 'let' in Remi example. I don't propose changing 'matching' behavior: when type is specified, it should be consistent with 'instanceof' which doesn't match null. With best regards, Tagir Valeev. 8 ???? 2017 ?. 2:59 AM ???????????? "Remi Forax" ???????: > Hi Tagir, > > ----- Mail original ----- > > De: "Tagir Valeev" > > ?: amber-dev at openjdk.java.net > > Envoy?: Vendredi 7 Juillet 2017 17:21:28 > > Objet: [patterns] Destructuring without matching? > > > Hello! > > > > Sometimes it's reasonable to deconstruct the object of known type. A > > classical example is Map.Entry. E.g. currently I can write: > > > > // Map wordCounts > > wordCounts.entrySet().stream() > > .filter(e -> e.getValue() > 10) > > .map(e -> e.getKey()+": "+e.getValue()) > > .forEach(System.out::println); > > > > It's desired to refer by concrete name to key and value like this: > > > > wordCounts.entrySet().stream() > > .filter((_, count) -> count > 10) > > .map((word, count) -> word+": "+count) > > .forEach(System.out::println); > > > > Of course such syntax is not possible. Reading pattern matching proposal > I > > thought whether it could solve this somehow. I see these alternatives: > > > > wordCounts.entrySet().stream() > > .filter(e -> e matches Entry(_, count) && count > 10) > > .map(e -> e matches Entry(word, count) ? word+": "+count : null) > > .forEach(System.out::println); > > > > Or > > > > wordCounts.entrySet().stream() > > .filter(e -> exprswitch(e) {case Entry(_, count) -> count > 10; default > > -> false;}) > > .map(e -> exprswitch(e) {case Entry(word, count) -> word+": "+count; > > default -> null;}) > > .forEach(System.out::println); > > > > In the latter case default branch is redundant as we know that e is > always > > an Entry. Probably compiler could figure out this as well and do not > > require default branch? In this case exprswitch will have only one branch > > and looks too verbose. > > yes, the compiler can figure that you do not need a default branch. > > But for what you want you do not need to match/switch on things, you just > want destructuration. > > I think it's better to have a new operator, let call it 'let' that does > the same destructuration that the pattern matching does, > > wordCounts.entrySet().stream() > .filter(e -> let (_, count) = e; count > 10) > .map(e -> let(word, count) = e; word+": "+count) > .forEach(System.out::println); > > and given that we already have a way to support string interpolation in > the JDK (StringConcatFactory), > you can even add String interpolation in the mix, > > wordCounts.entrySet().stream() > .filter(e -> let (_, count) = e; count > 10) > .map(e -> let (word, count) = e; ''$(word): $(count)'') > .forEach(System.out::println); > > (you need a way to said that a String is interpolated, i've chosen '' > (quotequote) which is close to " and currently invalid) > > and with values types (thus tuples), you can write it that way, > > wordCounts.entrySet().stream() > .map(e -> let (word, count) = e; (word, count)) > .filter((_, count) -> count > 10) > .map((word, count) -> ''$(word): $(count)'') > .forEach(System.out::println); > > regards, > R?mi > > > Tagir Valeev. > From john.r.rose at oracle.com Mon Jul 10 00:19:42 2017 From: john.r.rose at oracle.com (John Rose) Date: Sun, 9 Jul 2017 17:19:42 -0700 Subject: [patterns] Destructuring without matching? In-Reply-To: References: <346369122.3138667.1499457591958.JavaMail.zimbra@u-pem.fr> Message-ID: <7B4DB586-C530-42D7-B9A2-64794298461F@oracle.com> On Jul 8, 2017, at 7:22 PM, Tagir Valeev wrote: > > Yes, I was thinking about separate operator / syntax construct like 'let' > in Remi example. I don't propose changing 'matching' behavior: when type is > specified, it should be consistent with 'instanceof' which doesn't match > null. Whether a match is "soft" or "hard", that is "conditional" or "unconditional", is one of the many design parameters we are working with. The two cases correspond, roughly, to "instanceof" vs. "checkcast" or "unbox" operations. The most productive case to work with is the "soft" one, because we can always ask the user to handle failure explicitly. This lets us off the hook from specifying a one-size-fits all failure behavior. Annoyingly, failure can come from a surprise NPE, as with (int)(Integer)null. Even more annoyingly, our legacy "hard" destructuring operations have a mixed response to nulls: checkcast allows them, while unbox does not. And a source-level cast can be either, or a mix of both, so go figure! This is one more reason to stay on the "soft" side of the design as long as we can, since there is usually reasonable grounds for claiming that null is simply a value that doesn't match some pattern. And "instanceof" provides a helpful precedent for failing nulls from type-narrowing matches, without throwing NPE or letting the nulls "leak" into the case logic. (IMO it's an important goal that match expressions provide a useful sugar for the old instanceof/checkcast idiom, which requires users to mention the same type twice. This is another reason to lean on "instanceof" as a precedent for matching against a type.) Languages which support "hard" matches (Haskell, e.g.) allow you to write lambdas whose formal parameters deconstruct an actual argument. Such lambdas are not total, and so must have permission to throw some analog of ClassCastException or WrongMethodTypeException. It might seem tempting to do these, but it doesn't scale unless you can *also* provide a way to overload multiple lambda bodies, to give the user control over multiple deconstruction cases. So in the end I think an expression-switch, with a programmable default, is the best way to handle "hard" matches on the fly. Something like: foo( x -> exprswitch(x) { case Foo(var y, var z) -> lambdaBodyHere(y,z); case _ || null -> throw?; } ); I don't see any particular reason to sugar such a thing down further into a special purpose multi-body lambda syntax. (Maybe the "throw?" needs some sugar, along the lines of NPE, which is in some sense sugar for the code "if (r==null)throw NPE()" before a dereference of "r".) So, after this walk around the issues, it seems to me that all we have to design are "soft" matching constructs, that are sweet enough to let users build "hard" constructs on top of them. ? John P.S. There is another legacy source of NPEs, which arises from "switch" on a reference type (boxed int, enum, or string). If you hand a null to such a switch, you get an NPE. This is a "hard" behavior in an otherwise "soft" construct, since failing to match a case in a switch simply drops you to the default label, or out the bottom. Basically, the "default" label is "hard" with respect to nulls, although it is permissive to every other value. That's fine as a heuristic for catching uninitialized references, etc., but it gets in the way if you *expect* nulls as a possible value. A generalized switch needs to cover cases which *do expect* nulls as possible values, or it's one of those awful 99% generalizations that lure you in just to cut you on the 1% sharp edge. So this would be a very bad precedent to follow in new design; we must give a retroactive account (a "ret-con", a fandom term) of why it is that switch has this behavior. I think the right answer there is say that switch has a legacy behavior in which there is an implicit case added to every switch (at least legacy ones) which looks like this: "case null: throw NPE". This lets us give the user a lifeline to escape the NPE: If the user provides an explicit case that matches a null, we can simply say that this case takes precedence over the implicit one, rendering it dead code. So if you really want to skip the NPE, you replace "default:" with the double label "case null: default:". Not pretty, but it gives continuity between past and future semantics. There's a fraught issue about how to deal with the degrees of freedom between "default", "case _", "case var x", made much worse by the fact that "default" by itself might cause legacy NPEs. We are likely to disallow bare "case _" since it is a confusing synonym for "default", but then we also need a good way to defend against the NPEs, hence "case _ || null:", which I wrote above as notation for a "softer default". We need a story here. I suppose it's likely that we can require totality on enhanced switches, giving warnings if the ranges of the various cases don't cover the domain of the switch value. (NPE will likely get shuffled under the rug by such logic, for compatibility and to keep nulls out of peoples' hair.) If a switch, especially an expr-switch, lacks a default, and provably doesn't cover some (non-null) switch domain value, then we should issue a warning or error, to help the user complete the logic. To convert such a switch to a "hard" switch, which "knows and throws" it's incompleteness, we will probably want to require an explicit "default" with a throw. That's the "throw?" above in the multi-body lambda. I think requiring users to opt in to "hard" switches is a good idea, since assuming switches are "soft" will allow us to check totality. But, for the opt-in to "hard" switches, we might want to make it easy to make the throw happen. Perhaps a bare "throw;", in a switch, could be made sugar for "SwitchRangeException" or some such. From forax at univ-mlv.fr Mon Jul 10 07:45:43 2017 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Mon, 10 Jul 2017 09:45:43 +0200 (CEST) Subject: [patterns] Destructuring without matching? In-Reply-To: <7B4DB586-C530-42D7-B9A2-64794298461F@oracle.com> References: <346369122.3138667.1499457591958.JavaMail.zimbra@u-pem.fr> <7B4DB586-C530-42D7-B9A2-64794298461F@oracle.com> Message-ID: <146487568.189584.1499672743187.JavaMail.zimbra@u-pem.fr> Hi John, hi all, for the exprswitch()*, if your allowing the 'case null' syntax, you do not have to choose between hard and soft line because you have created an opt-in mechanism. As you said, switch by default do not accept null mostly because switch on objects was not introduce in Java 1.0 but in Java 5, when it was obvious that allowing data structures or language constructs to support null was a mistake because it propagates the null so instead of dealing with null when it is created, you have to deal with it later when it has lost its meaning and the error recovery code is less obvious. I think we should keep that idea, i.e. a switch() should fail by default, unless there is an explicit' case null' that ask to allow null in the switch so exprswitch(foo) { case Foo(...) -> .... } do not accept null wile this one: exprswitch(foo) { case Foo(...) -> .... case null -> .... } accepts null. And this also works for enclosed patterns, exprswitch(bar) { case Link(var e, var next) -> ... case Link(var e, null) -> .... } here we allow null BTW, i've found that for destructured pattern,s semantically, it's easy to see them as switch too (if you allow switch to have multiple arguments), so the last pattern matching can be seen as: exprswitch(bar) { case Link l -> exprswitch(l.element, l.next) { case Object e, Link next -> ... case Object e, null -> default: continue; } } regards, R?mi *IMO concerning null, the semantics of matches should be exactly the semantics of instanceof, so you can replace one by the other. > De: "John Rose" > ?: "Tagir Valeev" > Cc: "R?mi Forax" , "Brian Goetz" , > amber-dev at openjdk.java.net > Envoy?: Lundi 10 Juillet 2017 02:19:42 > Objet: Re: [patterns] Destructuring without matching? > On Jul 8, 2017, at 7:22 PM, Tagir Valeev < amaembo at gmail.com > wrote: >> Yes, I was thinking about separate operator / syntax construct like 'let' >> in Remi example. I don't propose changing 'matching' behavior: when type is >> specified, it should be consistent with 'instanceof' which doesn't match >> null. > Whether a match is "soft" or "hard", that is "conditional" or "unconditional", > is one of the many design parameters we are working with. The two cases > correspond, roughly, to "instanceof" vs. "checkcast" or "unbox" operations. > The most productive case to work with is the "soft" one, because we can > always ask the user to handle failure explicitly. This lets us off the hook > from specifying a one-size-fits all failure behavior. > Annoyingly, failure can come from a surprise NPE, as with (int)(Integer)null. > Even more annoyingly, our legacy "hard" destructuring operations have > a mixed response to nulls: checkcast allows them, while unbox does not. > And a source-level cast can be either, or a mix of both, so go figure! > This is one more reason to stay on the "soft" side of the design as long > as we can, since there is usually reasonable grounds for claiming that > null is simply a value that doesn't match some pattern. And "instanceof" > provides a helpful precedent for failing nulls from type-narrowing matches, > without throwing NPE or letting the nulls "leak" into the case logic. > (IMO it's an important goal that match expressions provide a useful > sugar for the old instanceof/checkcast idiom, which requires users to > mention the same type twice. This is another reason to lean on > "instanceof" as a precedent for matching against a type.) > Languages which support "hard" matches (Haskell, e.g.) allow you to > write lambdas whose formal parameters deconstruct an actual argument. > Such lambdas are not total, and so must have permission to throw some > analog of ClassCastException or WrongMethodTypeException. > It might seem tempting to do these, but it doesn't scale unless you > can *also* provide a way to overload multiple lambda bodies, to > give the user control over multiple deconstruction cases. > So in the end I think an expression-switch, with a programmable > default, is the best way to handle "hard" matches on the fly. > Something like: > foo( x -> exprswitch(x) { > case Foo(var y, var z) -> lambdaBodyHere(y,z); > case _ || null -> throw?; } > ); > I don't see any particular reason to sugar such a thing down further > into a special purpose multi-body lambda syntax. > (Maybe the "throw?" needs some sugar, along the lines of NPE, > which is in some sense sugar for the code "if (r==null)throw NPE()" > before a dereference of "r".) > So, after this walk around the issues, it seems to me that all we > have to design are "soft" matching constructs, that are sweet enough > to let users build "hard" constructs on top of them. > ? John > P.S. There is another legacy source of NPEs, which arises from "switch" > on a reference type (boxed int, enum, or string). If you hand a null to such > a switch, you get an NPE. This is a "hard" behavior in an otherwise "soft" > construct, since failing to match a case in a switch simply drops you to the > default label, or out the bottom. Basically, the "default" label is "hard" with > respect to nulls, although it is permissive to every other value. That's fine > as a heuristic for catching uninitialized references, etc., but it gets in the > way if you *expect* nulls as a possible value. A generalized switch needs > to cover cases which *do expect* nulls as possible values, or it's one of > those awful 99% generalizations that lure you in just to cut you on the > 1% sharp edge. > So this would be a very bad precedent to follow in new design; we must > give a retroactive account (a "ret-con", a fandom term) of why it is that > switch has this behavior. I think the right answer there is say that switch > has a legacy behavior in which there is an implicit case added to every > switch (at least legacy ones) which looks like this: "case null: throw NPE". > This lets us give the user a lifeline to escape the NPE: If the user provides > an explicit case that matches a null, we can simply say that this case takes > precedence over the implicit one, rendering it dead code. > So if you really want to skip the NPE, you replace "default:" with the double > label "case null: default:". Not pretty, but it gives continuity between past > and future semantics. > There's a fraught issue about how to deal with the degrees of freedom > between "default", "case _", "case var x", made much worse by the fact > that "default" by itself might cause legacy NPEs. We are likely to disallow > bare "case _" since it is a confusing synonym for "default", but then we > also need a good way to defend against the NPEs, hence "case _ || null:", > which I wrote above as notation for a "softer default". We need a story here. > I suppose it's likely that we can require totality on enhanced switches, > giving warnings if the ranges of the various cases don't cover the domain > of the switch value. (NPE will likely get shuffled under the rug by such > logic, for compatibility and to keep nulls out of peoples' hair.) If a switch, > especially an expr-switch, lacks a default, and provably doesn't cover > some (non-null) switch domain value, then we should issue a warning > or error, to help the user complete the logic. To convert such a switch > to a "hard" switch, which "knows and throws" it's incompleteness, we > will probably want to require an explicit "default" with a throw. That's > the "throw?" above in the multi-body lambda. I think requiring users > to opt in to "hard" switches is a good idea, since assuming switches > are "soft" will allow us to check totality. But, for the opt-in to "hard" > switches, we might want to make it easy to make the throw happen. > Perhaps a bare "throw;", in a switch, could be made sugar for > "SwitchRangeException" or some such. From john.r.rose at oracle.com Mon Jul 10 07:53:10 2017 From: john.r.rose at oracle.com (John Rose) Date: Mon, 10 Jul 2017 00:53:10 -0700 Subject: [patterns] Destructuring without matching? In-Reply-To: <146487568.189584.1499672743187.JavaMail.zimbra@u-pem.fr> References: <346369122.3138667.1499457591958.JavaMail.zimbra@u-pem.fr> <7B4DB586-C530-42D7-B9A2-64794298461F@oracle.com> <146487568.189584.1499672743187.JavaMail.zimbra@u-pem.fr> Message-ID: <2C5DF93E-8AA9-4A8B-894A-7E94E1A558EA@oracle.com> On Jul 10, 2017, at 12:45 AM, forax at univ-mlv.fr wrote: > > you do not have to choose between hard and soft line because you have created an opt-in mechanism. > ? > The semantics of matches should be exactly the semantics of instanceof, so you can replace one by the other. Yes. From amaembo at gmail.com Mon Jul 10 10:47:00 2017 From: amaembo at gmail.com (Tagir Valeev) Date: Mon, 10 Jul 2017 13:47:00 +0300 Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: <0562c35c-c38b-a65a-03c9-bcbcf5e814d3@oracle.com> References: <0562c35c-c38b-a65a-03c9-bcbcf5e814d3@oracle.com> Message-ID: Hello! I see that A was selected and currenty I support it. Just a short opinion against C for the record. There are many cases when method does not override another one, but has to declare some parameters. Examples: - public static void main: using main(String[] _) would indicate that command line parameters are not used. - name parameter in BootstrapMethodFactory: often it's unnecessary - some annotation-based APIs when method annotation directs a framework to call this method reflectively with specific parameters (but some of them are not used actually) - a lambda with unused parameter which was converted to a method for convenient use as a method reference So covering traditional inheritance, but not covering these cases looks arbitrary indeed. With best regards, Tagir Valeev. On Sat, Jul 1, 2017 at 12:38 AM, Brian Goetz wrote: > So, a fair question is whether _ should be supported for methods at all, > because (in many cases) method parameters are both declaration and > implementation. This feature started out for lambdas (whose parameters are > pure implementation), and then got extended to catch formals (also pure > implementation) and method parameters (not pure implementation.) And once > we bring in methods, it raises tooling questions like "what about Javadoc." > So maybe the last step was the problem. > > Here's a menu of defensible options here: > > A. Don't allow _ for method or constructor parameters. > > B. Only allow _ for method parameters in *anonymous* classes. This has the > advantage that it makes it easier to freely refactor lambdas to/from anon > classes. > > C. The option I proposed the other day -- only allow _ as a method > parameter name for concrete class methods that are known to be an @Override > of some other method. This excludes all interface and abstract methods, > constructors, and "initial declarations" of methods in base classes. > > D. Allow it in all methods. > > > Now that this has been pointed out, I'm pretty down on D. C is > defensible, but likely will feel arbitrary. B does has a nice symmetry to > it, but it means it drags tooling support (Javadoc) into the feature. And > A avoids the problem entirely. (Though, like with LVTI, people will > inevitably ask "but what about private methods? And they'd get the same > answer, regarding source compatibility of modifier changes.) > > Leaning towards A.... > > > On 6/25/2017 6:51 AM, Tagir Valeev wrote: > >> Hello! >> >> Currently in lambda-leftovers underscore is allowed as a parameter name >> for >> abstract methods. This looks dubious as normally underscore means that >> parameter is not used in the corresponding method/lambda/catch body, but >> there's no actual body and no parameter is actually used anyways (but >> could >> be used in abstract method implementations). I think, allowing underscores >> for interface methods may encorage bad practices of defining interfaces >> without readable parameter names: >> >> interface X { >> void doSomething(int _, long _, String _); >> } >> >> Should not this be disabled? >> >> It's even worse for native methods, because underscore assumes that >> parameter is not used, but it does not limit the corresponding native >> implementation from using it. >> >> With best regards, >> Tagir Valeev. >> > > From maurizio.cimadamore at oracle.com Thu Jul 13 21:57:00 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 21:57:00 +0000 Subject: hg: amber/amber/jaxws: 6 new changesets Message-ID: <201707132157.v6DLv0wJ029115@aojmv0008.oracle.com> Changeset: 357a084232ff Author: lana Date: 2017-07-06 22:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/357a084232ff Added tag jdk-10+14 for changeset bddeaa49ffd5 ! .hgtags Changeset: 880541212285 Author: lana Date: 2017-06-29 17:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/880541212285 Added tag jdk-9+176 for changeset ea819b6009d3 ! .hgtags Changeset: b44a721aee3d Author: mr Date: 2017-07-03 13:18 -0700 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/b44a721aee3d 8182776: Fix typos in module declarations Reviewed-by: jjg, alanb ! src/java.activation/share/classes/module-info.java ! src/java.xml.bind/share/classes/module-info.java ! src/java.xml.ws.annotation/share/classes/module-info.java ! src/java.xml.ws/share/classes/module-info.java Changeset: d0190aaf1816 Author: lana Date: 2017-07-06 20:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/d0190aaf1816 Added tag jdk-9+177 for changeset b44a721aee3d ! .hgtags Changeset: 6d17fd0a5133 Author: lana Date: 2017-07-07 03:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/6d17fd0a5133 Merge ! .hgtags Changeset: bc8289ce1ed3 Author: lana Date: 2017-07-13 19:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/bc8289ce1ed3 Added tag jdk-10+15 for changeset 6d17fd0a5133 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 13 21:57:00 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 21:57:00 +0000 Subject: hg: amber/amber/jaxp: 9 new changesets Message-ID: <201707132157.v6DLv0kC029112@aojmv0008.oracle.com> Changeset: b34f3fc51c50 Author: lana Date: 2017-07-06 22:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/b34f3fc51c50 Added tag jdk-10+14 for changeset 4d05f673cf77 ! .hgtags Changeset: 332ad9f92632 Author: lana Date: 2017-06-29 17:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/332ad9f92632 Added tag jdk-9+176 for changeset 38cf34e23280 ! .hgtags Changeset: 0983b2dbe17b Author: lana Date: 2017-07-06 20:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/0983b2dbe17b Added tag jdk-9+177 for changeset 332ad9f92632 ! .hgtags Changeset: 18b09cba334b Author: lana Date: 2017-07-07 03:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/18b09cba334b Merge ! .hgtags - src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/XMLCatalogResolver.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/Catalog.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogEntry.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogException.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/CatalogManager.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/Resolver.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/BootstrapResolver.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/Debug.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/FileURL.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/Namespaces.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/helpers/PublicId.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/CatalogReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/DOMCatalogParser.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/DOMCatalogReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/ExtendedXMLCatalogReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/OASISXMLCatalogReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXCatalogParser.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXCatalogReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/SAXParserHandler.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/TR9401CatalogReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/TextCatalogReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/readers/XCatalogReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/tools/CatalogResolver.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingParser.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingXMLFilter.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/resolver/tools/ResolvingXMLReader.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/AttList.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/utils/DOM2Helper.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/DOMHelper.java - src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/DOMOrder.java - test/javax/xml/jaxp/libs/jdk/testlibrary/Asserts.java - test/javax/xml/jaxp/libs/jdk/testlibrary/CompilerUtils.java - test/javax/xml/jaxp/libs/jdk/testlibrary/JDKToolFinder.java - test/javax/xml/jaxp/libs/jdk/testlibrary/JDKToolLauncher.java - test/javax/xml/jaxp/libs/jdk/testlibrary/OutputAnalyzer.java - test/javax/xml/jaxp/libs/jdk/testlibrary/OutputBuffer.java - test/javax/xml/jaxp/libs/jdk/testlibrary/Platform.java - test/javax/xml/jaxp/libs/jdk/testlibrary/ProcessTools.java - test/javax/xml/jaxp/libs/jdk/testlibrary/README.txt - test/javax/xml/jaxp/libs/jdk/testlibrary/StreamPumper.java - test/javax/xml/jaxp/libs/jdk/testlibrary/Utils.java Changeset: 86157a0bf14f Author: joehw Date: 2017-07-10 10:22 -0700 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/86157a0bf14f 8181154: Fix lint warnings in JAXP repo: deprecation Reviewed-by: lancea, dfuchs ! src/java.xml/share/classes/com/sun/java_cup/internal/runtime/virtual_parse_stack.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantDouble.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantFloat.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantInteger.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/ConstantLong.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/JavaClass.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/BIPUSH.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/DCONST.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FCONST.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/FieldGen.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/ICONST.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/Instruction.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/InstructionFactory.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LCONST.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/LDC2_W.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/SIPUSH.java ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/util/SecuritySupport.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/lib/ExsltMath.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/ObjectFactory.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/utils/SecuritySupport.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/Parser.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathLexer.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XPathParser.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/compiler/XSLTC.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/DocumentCache.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/KeyIndex.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecord.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/NodeSortRecordFactory.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/dom/SAXImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/AbstractTranslet.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/Attributes.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/runtime/BasisLibrary.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TemplatesImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/TrAXFilter.java ! src/java.xml/share/classes/com/sun/org/apache/xalan/internal/xsltc/trax/Util.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDOMImplementationImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/CoreDocumentImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DOMNormalizer.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/DeferredDocumentImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIAttrNSImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/dom/PSVIElementNSImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XML11NSDocumentScannerImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityManager.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/XMLEntityScanner.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMAny.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/CMLeaf.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dtd/models/DFAContentModel.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/util/ByteListImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/AttributePSVImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/ElementPSVImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAttributeDecl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSAttributeUseImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XSElementDecl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/identity/XPathMatcher.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/CMNodeFactory.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/models/XSDFACM.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSAttributeChecker.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDComplexTypeTraverser.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDHandler.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/util/ShortListImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/SAXParserImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/XMLGregorianCalendarImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractDOMParser.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/parsers/AbstractSAXParser.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/util/AttributesProxy.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/utils/ObjectFactory.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xinclude/SecuritySupport.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xinclude/XIncludeHandler.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xpointer/ElementSchemePointer.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xpointer/ShortHandPointer.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/xpointer/XPointerHandler.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/dtm/ref/IncrementalSAXSource_Xerces.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serialize/SecuritySupport.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/SerializerFactory.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/dom3/DOM3TreeWalker.java ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/utils/ObjectPool.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/SourceTreeManager.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/XPathContext.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/axes/HasPositionalPredChecker.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/compiler/FunctionTable.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/compiler/XPathParser.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/jaxp/XPathFactoryImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/objects/XBoolean.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/objects/XNumber.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/objects/XObject.java ! src/java.xml/share/classes/javax/xml/datatype/FactoryFinder.java ! src/java.xml/share/classes/javax/xml/datatype/SecuritySupport.java ! src/java.xml/share/classes/javax/xml/parsers/FactoryFinder.java ! src/java.xml/share/classes/javax/xml/parsers/SAXParser.java ! src/java.xml/share/classes/javax/xml/parsers/SecuritySupport.java ! src/java.xml/share/classes/javax/xml/stream/FactoryFinder.java ! src/java.xml/share/classes/javax/xml/transform/FactoryFinder.java ! src/java.xml/share/classes/javax/xml/transform/SecuritySupport.java ! src/java.xml/share/classes/javax/xml/validation/SchemaFactoryFinder.java ! src/java.xml/share/classes/javax/xml/xpath/XPathFactoryFinder.java ! src/java.xml/share/classes/org/w3c/dom/bootstrap/DOMImplementationRegistry.java ! src/java.xml/share/classes/org/xml/sax/helpers/NewInstance.java ! src/java.xml/share/classes/org/xml/sax/helpers/ParserAdapter.java ! src/java.xml/share/classes/org/xml/sax/helpers/SecuritySupport.java ! src/java.xml/share/classes/org/xml/sax/helpers/XMLReaderAdapter.java Changeset: 714f6393f03b Author: mli Date: 2017-07-10 18:22 -0700 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/714f6393f03b 8184062: wrong @modules javax.xml at jaxp/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java Reviewed-by: amlu, lancea ! test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java Changeset: 02a876781a3a Author: jjg Date: 2017-07-11 12:39 -0700 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/02a876781a3a 8184021: Fix tables in doc comments to be accessible Reviewed-by: joehw, lancea ! src/java.xml/share/classes/javax/xml/catalog/Catalog.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogResolver.java ! src/java.xml/share/classes/javax/xml/datatype/DatatypeFactory.java ! src/java.xml/share/classes/javax/xml/datatype/Duration.java ! src/java.xml/share/classes/javax/xml/datatype/XMLGregorianCalendar.java ! src/java.xml/share/classes/javax/xml/datatype/package-info.java ! src/java.xml/share/classes/javax/xml/namespace/NamespaceContext.java ! src/java.xml/share/classes/javax/xml/stream/XMLEventWriter.java ! src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java ! src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java ! src/java.xml/share/classes/javax/xml/stream/XMLStreamReader.java ! src/java.xml/share/classes/javax/xml/stream/XMLStreamWriter.java ! src/java.xml/share/classes/javax/xml/validation/SchemaFactory.java ! src/java.xml/share/classes/javax/xml/validation/Validator.java ! src/java.xml/share/classes/javax/xml/xpath/XPath.java ! src/java.xml/share/classes/javax/xml/xpath/XPathExpression.java ! src/java.xml/share/classes/javax/xml/xpath/package-info.java ! src/java.xml/share/classes/org/w3c/dom/Attr.java ! src/java.xml/share/classes/org/w3c/dom/Comment.java ! src/java.xml/share/classes/org/w3c/dom/Document.java ! src/java.xml/share/classes/org/w3c/dom/Node.java ! src/java.xml/share/classes/org/xml/sax/helpers/XMLReaderFactory.java ! src/java.xml/share/classes/org/xml/sax/package-info.java Changeset: e4bef2c8a12f Author: jjg Date: 2017-07-12 14:28 -0700 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/e4bef2c8a12f 8184307: fix typo in Validator.java Reviewed-by: darcy ! src/java.xml/share/classes/javax/xml/validation/Validator.java Changeset: 9b7f827fe067 Author: lana Date: 2017-07-13 19:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/9b7f827fe067 Added tag jdk-10+15 for changeset 02a876781a3a ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 13 21:57:01 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 21:57:01 +0000 Subject: hg: amber/amber/corba: 6 new changesets Message-ID: <201707132157.v6DLv2kc029223@aojmv0008.oracle.com> Changeset: 9df4e105fd04 Author: lana Date: 2017-07-06 22:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/9df4e105fd04 Added tag jdk-10+14 for changeset 25d991a67cba ! .hgtags Changeset: 76cebcdca958 Author: lana Date: 2017-06-29 17:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/76cebcdca958 Added tag jdk-9+176 for changeset 40fb9f229471 ! .hgtags Changeset: c72e9d3823f0 Author: mr Date: 2017-07-03 13:18 -0700 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/c72e9d3823f0 8182776: Fix typos in module declarations Reviewed-by: jjg, alanb ! src/java.corba/share/classes/module-info.java Changeset: 9c1e97126489 Author: lana Date: 2017-07-06 20:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/9c1e97126489 Added tag jdk-9+177 for changeset c72e9d3823f0 ! .hgtags Changeset: 15f59cfc6fbe Author: lana Date: 2017-07-07 03:08 +0000 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/15f59cfc6fbe Merge ! .hgtags Changeset: b82b62ed5deb Author: lana Date: 2017-07-13 19:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/b82b62ed5deb Added tag jdk-10+15 for changeset 15f59cfc6fbe ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 13 21:57:03 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 21:57:03 +0000 Subject: hg: amber/amber/hotspot: 6 new changesets Message-ID: <201707132157.v6DLv3dG029290@aojmv0008.oracle.com> Changeset: ed412e267e5f Author: lana Date: 2017-07-06 22:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/ed412e267e5f Added tag jdk-10+14 for changeset e920b4d008d9 ! .hgtags Changeset: 2ab74e5dbdc2 Author: roland Date: 2017-06-23 09:33 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/2ab74e5dbdc2 8181742: Load that bypasses arraycopy has wrong memory state Summary: Set load memory edge to the memory state right before the arraycopy. Reviewed-by: kvn, thartmann ! src/share/vm/opto/arraycopynode.cpp ! src/share/vm/opto/arraycopynode.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp + test/compiler/arraycopy/TestLoadBypassACWithWrongMem.java Changeset: 1ca8f038fceb Author: lana Date: 2017-06-29 17:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/1ca8f038fceb Added tag jdk-9+176 for changeset 2ab74e5dbdc2 ! .hgtags Changeset: 9daaceb6c64c Author: lana Date: 2017-07-06 20:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/9daaceb6c64c Added tag jdk-9+177 for changeset 1ca8f038fceb ! .hgtags Changeset: c1f3649a3a42 Author: lana Date: 2017-07-07 03:07 +0000 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/c1f3649a3a42 Merge ! .hgtags - test/gc/arguments/TestExplicitGCInvokesConcurrentAndUnloadsClasses.java - test/gc/startup_warnings/TestDefNewCMS.java - test/gc/startup_warnings/TestParNewCMS.java - test/gc/startup_warnings/TestParNewSerialOld.java - test/gc/startup_warnings/TestUseAutoGCSelectPolicy.java - test/runtime/NMT/AutoshutdownNMT.java Changeset: 2fe2a593e8eb Author: lana Date: 2017-07-13 19:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/2fe2a593e8eb Added tag jdk-10+15 for changeset c1f3649a3a42 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 13 21:57:02 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 21:57:02 +0000 Subject: hg: amber/amber/langtools: 15 new changesets Message-ID: <201707132157.v6DLv3Ud029286@aojmv0008.oracle.com> Changeset: ab8722b81eef Author: lana Date: 2017-07-06 22:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/ab8722b81eef Added tag jdk-10+14 for changeset add6717b655e ! .hgtags Changeset: 0d0ac75b0f6c Author: jjg Date: 2017-06-26 18:48 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/0d0ac75b0f6c 8182736: javadoc generates bad names and broken module graph links Reviewed-by: jjg, bpatel, darcy, ksrini Contributed-by: bhavesh.patel at oracle.com, jonathan.gibbons at oracle.com ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/IndexBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java ! test/jdk/javadoc/doclet/testModules/TestModules.java + test/jdk/javadoc/doclet/testModules/test.moduleFullName/module-info.java + test/jdk/javadoc/doclet/testModules/test.moduleFullName/testpkgmdlfullname/TestClassInTestModuleFullName.java Changeset: 552f8fdfba55 Author: lana Date: 2017-06-29 17:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/552f8fdfba55 Added tag jdk-9+176 for changeset 0d0ac75b0f6c ! .hgtags Changeset: 2f01728210c1 Author: mr Date: 2017-07-03 13:18 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/2f01728210c1 8182776: Fix typos in module declarations Reviewed-by: jjg, alanb ! src/java.compiler/share/classes/module-info.java ! src/jdk.compiler/share/classes/module-info.java ! src/jdk.javadoc/share/classes/module-info.java ! src/jdk.jdeps/share/classes/module-info.java Changeset: 849e366ef175 Author: lana Date: 2017-07-06 20:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/849e366ef175 Added tag jdk-9+177 for changeset 2f01728210c1 ! .hgtags Changeset: 7a9a70b69184 Author: lana Date: 2017-07-07 03:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/7a9a70b69184 Merge ! .hgtags - src/jdk.javadoc/share/classes/com/sun/tools/doclets/Taglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AbstractExecutableMemberWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AbstractIndexWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AbstractMemberWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AbstractPackageIndexWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AbstractTreeWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AllClassesFrameWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeFieldWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/AnnotationTypeWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ClassUseWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ClassWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ConfigurationImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ConstantsSummaryWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/ConstructorWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/DeprecatedListWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/EnumConstantWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/FieldWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/FrameOutputWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/HelpWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/HtmlDoclet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialMethodWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/LinkFactoryImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/LinkInfoImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/LinkOutputImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/MethodWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/NestedClassWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/PackageFrameWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/PackageIndexFrameWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/PackageIndexWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/PackageTreeWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/PackageUseWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/PackageWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/PropertyWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/SearchIndexItem.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/SectionName.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/SerializedFormWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/SingleIndexWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/SplitIndexWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/SubWriterHolderWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/TagletWriterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/TreeWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/WriterFactoryImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/Comment.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/ContentBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/DocType.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlAttr.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlDocument.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlStyle.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTag.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlTree.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlVersion.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/HtmlWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/RawHtml.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/StringContent.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/markup/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/resources/standard_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/doclets/formats/html/resources/standard_zh_CN.properties - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/AbstractDoclet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeFieldWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeOptionalMemberWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeRequiredMemberWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/AnnotationTypeWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/ClassWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/Configuration.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/ConstantsSummaryWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/ConstructorWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/Content.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/EnumConstantWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/FieldWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/MemberSummaryWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/MethodWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/NestedClassWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/PackageSummaryWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/PropertyWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/SerializedFormWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/WriterFactory.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AbstractMemberBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeFieldBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeOptionalMemberBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/BuilderFactory.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstantsSummaryBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ConstructorBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/EnumConstantBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/FieldBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/LayoutParser.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MemberSummaryBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/MethodBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PackageSummaryBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/PropertyBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/XMLNode.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/builders/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclet.xml - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets.properties - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_zh_CN.properties - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/glass.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/external/jquery/jquery.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-bg_flat_0_aaaaaa_40x100.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-bg_flat_75_ffffff_40x100.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-bg_glass_55_fbf9ee_1x400.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-bg_glass_65_ffffff_1x400.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-bg_glass_75_dadada_1x400.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-bg_glass_75_e6e6e6_1x400.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-bg_glass_95_fef1ec_1x400.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-bg_highlight-soft_75_cccccc_1x100.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-icons_222222_256x240.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-icons_2e83ff_256x240.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-icons_454545_256x240.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-icons_888888_256x240.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/images/ui-icons_cd0a0a_256x240.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jquery-1.10.2.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jquery-ui.css - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jquery-ui.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jquery-ui.min.css - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jquery-ui.min.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jquery-ui.structure.css - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jquery-ui.structure.min.css - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jszip-utils/dist/jszip-utils-ie.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jszip-utils/dist/jszip-utils-ie.min.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jszip-utils/dist/jszip-utils.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jszip-utils/dist/jszip-utils.min.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jszip/dist/jszip.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/jquery/jszip/dist/jszip.min.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/script.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/search.js - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/resources/x.png - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseExecutableMemberTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseInlineTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BasePropertyTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/BaseTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/CodeTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DeprecatedTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/DocRootTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/IndexTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritDocTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/InheritableTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LegacyTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/LiteralTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ParamTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertyGetterTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/PropertySetterTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ReturnTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SeeTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/SimpleTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/Taglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletManager.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/TagletWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ThrowsTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/ValueTaglet.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/taglets/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassDocCatalog.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassTree.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/ClassUseMapper.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DeprecatedAPIListBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFile.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFileFactory.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocFinder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocLink.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPath.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocPaths.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletAbortException.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/DocletConstants.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/Extern.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/FatalError.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/Group.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/ImplementedMethods.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/IndexBuilder.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/MessageRetriever.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/MetaKeywords.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/MethodTypes.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/PackageListWriter.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/StandardDocFileFactory.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/TextTag.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/Utils.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/VisibleMemberMap.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkFactory.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkInfo.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/LinkOutput.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/links/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/internal/toolkit/util/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/package-info.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConfigurationImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/Configuration.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/LayoutParser.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/XMLNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclet.xml ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/IndexBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java ! src/jdk.javadoc/share/classes/module-info.java - test/com/sun/javadoc/5093723/DocumentedClass.java - test/com/sun/javadoc/5093723/T5093723.java - test/com/sun/javadoc/5093723/UndocumentedClass.java - test/com/sun/javadoc/AccessAsciiArt/AccessAsciiArt.java - test/com/sun/javadoc/AccessAsciiArt/p1/C.java - test/com/sun/javadoc/AccessAsciiArt/p1/I.java - test/com/sun/javadoc/AccessAsciiArt/p1/SC.java - test/com/sun/javadoc/AccessAsciiArt/p1/SI.java - test/com/sun/javadoc/AccessAsciiArt/p1/subpkg/SSC.java - test/com/sun/javadoc/AccessFrameTitle/AccessFrameTitle.java - test/com/sun/javadoc/AccessFrameTitle/p1/C1.java - test/com/sun/javadoc/AccessFrameTitle/p2/C2.java - test/com/sun/javadoc/AccessH1/AccessH1.java - test/com/sun/javadoc/AccessH1/p1/C.java - test/com/sun/javadoc/AccessH1/p2/C2.java - test/com/sun/javadoc/AccessSkipNav/AccessSkipNav.java - test/com/sun/javadoc/AccessSkipNav/p1/C1.java - test/com/sun/javadoc/AccessSkipNav/p2/C2.java - test/com/sun/javadoc/AccessSummary/AccessSummary.java - test/com/sun/javadoc/AccessSummary/p1/C1.java - test/com/sun/javadoc/AccessSummary/p2/C2.java - test/com/sun/javadoc/AuthorDD/AuthorDD.java - test/com/sun/javadoc/AuthorDD/p1/C1.java - test/com/sun/javadoc/DocRootSlash/DocRootSlash.java - test/com/sun/javadoc/DocRootSlash/overview.html - test/com/sun/javadoc/DocRootSlash/p1/C1.java - test/com/sun/javadoc/DocRootSlash/p1/package.html - test/com/sun/javadoc/DocRootSlash/p2/C2.java - test/com/sun/javadoc/DocRootSlash/p2/package.html - test/com/sun/javadoc/InheritDocForUserTags/DocTest.java - test/com/sun/javadoc/JavascriptWinTitle/JavascriptWinTitle.java - test/com/sun/javadoc/JavascriptWinTitle/overview.html - test/com/sun/javadoc/JavascriptWinTitle/p1/C.java - test/com/sun/javadoc/JavascriptWinTitle/p2/C2.java - test/com/sun/javadoc/JavascriptWinTitle/package-list - test/com/sun/javadoc/MetaTag/MetaTag.java - test/com/sun/javadoc/MetaTag/p1/C1.java - test/com/sun/javadoc/MetaTag/p2/C2.java - test/com/sun/javadoc/PackagesHeader/PackagesHeader.java - test/com/sun/javadoc/PackagesHeader/p1/C1.java - test/com/sun/javadoc/PackagesHeader/p2/C2.java - test/com/sun/javadoc/T6735320/SerialFieldTest.java - test/com/sun/javadoc/T6735320/T6735320.java - test/com/sun/javadoc/ValidHtml/ValidHtml.java - test/com/sun/javadoc/ValidHtml/overview.html - test/com/sun/javadoc/ValidHtml/p1/C.java - test/com/sun/javadoc/ValidHtml/p2/C2.java - test/com/sun/javadoc/VersionNumber/VersionNumber.java - test/com/sun/javadoc/VersionNumber/p1/C.java - test/com/sun/javadoc/WindowTitles/WindowTitles.java - test/com/sun/javadoc/WindowTitles/p1/C1.java - test/com/sun/javadoc/WindowTitles/p2/C2.java - test/com/sun/javadoc/_template/Template.java - test/com/sun/javadoc/_template/TemplateComplete.java - test/com/sun/javadoc/constantValues/A.java - test/com/sun/javadoc/constantValues/TestConstantValues.java - test/com/sun/javadoc/constantValues/TestConstantValues2.java - test/com/sun/javadoc/constantValues/TestConstantValuesDriver.java - test/com/sun/javadoc/dupThrowsTags/TestDupThrowsTags.java - test/com/sun/javadoc/lib/JavadocTester.java - test/com/sun/javadoc/testAbsLinkPath/TestAbsLinkPath.java - test/com/sun/javadoc/testAbsLinkPath/pkg1/C1.java - test/com/sun/javadoc/testAbsLinkPath/pkg2/C2.java - test/com/sun/javadoc/testAbstractMethod/TestAbstractMethod.java - test/com/sun/javadoc/testAbstractMethod/pkg/A.java - test/com/sun/javadoc/testAbstractMethod/pkg/B.java - test/com/sun/javadoc/testAbstractMethod/pkg/C.java - test/com/sun/javadoc/testAnchorNames/TestAnchorNames.java - test/com/sun/javadoc/testAnchorNames/pkg1/DeprMemClass.java - test/com/sun/javadoc/testAnchorNames/pkg1/RegClass.java - test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOptional.java - test/com/sun/javadoc/testAnnotationOptional/pkg/AnnotationOptional.java - test/com/sun/javadoc/testAnnotationTypes/TestAnnotationTypes.java - test/com/sun/javadoc/testAnnotationTypes/pkg/AnnotationType.java - test/com/sun/javadoc/testAnnotationTypes/pkg/AnnotationTypeField.java - test/com/sun/javadoc/testBackSlashInLink/C.java - test/com/sun/javadoc/testBackSlashInLink/TestBackSlashInLink.java - test/com/sun/javadoc/testBadPackageFileInJar/TestBadPackageFileInJar.java - test/com/sun/javadoc/testBadPackageFileInJar/badPackageFileInJar.jar - test/com/sun/javadoc/testBadPackageFileInJar/pkg/C.java - test/com/sun/javadoc/testBadSourceFile/C1.java - test/com/sun/javadoc/testBadSourceFile/C2.java - test/com/sun/javadoc/testBadSourceFile/TestBadSourceFile.java - test/com/sun/javadoc/testBaseClass/Bar.java - test/com/sun/javadoc/testBaseClass/BaseClass.java - test/com/sun/javadoc/testBaseClass/TestBaseClass.java - test/com/sun/javadoc/testBaseClass/baz/Foo.java - test/com/sun/javadoc/testBreakIterator/TestBreakIterator.java - test/com/sun/javadoc/testBreakIterator/pkg/BreakIteratorTest.java - test/com/sun/javadoc/testCRLineSeparator/TestCRLineSeparator.java - test/com/sun/javadoc/testCRLineSeparator/pkg/MyClass.java - test/com/sun/javadoc/testCharset/TestCharset.java - test/com/sun/javadoc/testCharset/pkg/Foo.java - test/com/sun/javadoc/testClassCrossReferences/C.java - test/com/sun/javadoc/testClassCrossReferences/TestClassCrossReferences.java - test/com/sun/javadoc/testClassCrossReferences/package-list - test/com/sun/javadoc/testClassTree/TestClassTree.java - test/com/sun/javadoc/testClassTree/pkg/AnnotationType.java - test/com/sun/javadoc/testClassTree/pkg/ChildClass.java - test/com/sun/javadoc/testClassTree/pkg/Coin.java - test/com/sun/javadoc/testClassTree/pkg/ParentClass.java - test/com/sun/javadoc/testCmndLineClass/C5.java - test/com/sun/javadoc/testCmndLineClass/TestCmndLineClass.java - test/com/sun/javadoc/testCmndLineClass/pkg1/C1.java - test/com/sun/javadoc/testCmndLineClass/pkg1/C2.java - test/com/sun/javadoc/testCmndLineClass/pkg1/package.html - test/com/sun/javadoc/testCmndLineClass/pkg2/C3.java - test/com/sun/javadoc/testCmndLineClass/pkg2/C4.java - test/com/sun/javadoc/testCmndLineClass/pkg2/package.html - test/com/sun/javadoc/testCompletionFailure/TestCompletionFailure.java - test/com/sun/javadoc/testCompletionFailure/pkg1/NumberFormatTest.java - test/com/sun/javadoc/testConstantValuesPage/TestConstantValuesPage.java - test/com/sun/javadoc/testConstructorIndent/C.java - test/com/sun/javadoc/testConstructorIndent/TestConstructorIndent.java - test/com/sun/javadoc/testConstructors/TestConstructors.java - test/com/sun/javadoc/testConstructors/pkg1/Outer.java - test/com/sun/javadoc/testCustomTag/TagTestClass.java - test/com/sun/javadoc/testCustomTag/TestCustomTag.java - test/com/sun/javadoc/testCustomTag/taglets/CustomTag.java - test/com/sun/javadoc/testDeprecatedDocs/TestDeprecatedDocs.java - test/com/sun/javadoc/testDeprecatedDocs/pkg/DeprecatedClassByAnnotation.java - test/com/sun/javadoc/testDeprecatedDocs/pkg/TestAnnotationType.java - test/com/sun/javadoc/testDeprecatedDocs/pkg/TestClass.java - test/com/sun/javadoc/testDeprecatedDocs/pkg/TestEnum.java - test/com/sun/javadoc/testDeprecatedDocs/pkg/TestError.java - test/com/sun/javadoc/testDeprecatedDocs/pkg/TestException.java - test/com/sun/javadoc/testDeprecatedDocs/pkg/TestInterface.java - test/com/sun/javadoc/testDocEncoding/TestDocEncoding.java - test/com/sun/javadoc/testDocEncoding/pkg/Test.java - test/com/sun/javadoc/testDocErrorReporter/TestDocErrorReporter.java - test/com/sun/javadoc/testDocFileDir/TestDocFileDir.java - test/com/sun/javadoc/testDocFileDir/pkg/C.java - test/com/sun/javadoc/testDocFileDir/pkg/doc-files/subdir-excluded1/testfile.txt - test/com/sun/javadoc/testDocFileDir/pkg/doc-files/subdir-excluded2/testfile.txt - test/com/sun/javadoc/testDocFileDir/pkg/doc-files/subdir-used1/testfile.txt - test/com/sun/javadoc/testDocFileDir/pkg/doc-files/subdir-used2/testfile.txt - test/com/sun/javadoc/testDocFileDir/pkg/doc-files/testfile.txt - test/com/sun/javadoc/testDocFiles/TestDocFiles.java - test/com/sun/javadoc/testDocFiles/pkg/Test.java - test/com/sun/javadoc/testDocFiles/pkg/doc-files/test.txt - test/com/sun/javadoc/testDocRootInlineTag/TestDocRootInlineTag.java - test/com/sun/javadoc/testDocRootInlineTag/TestDocRootTag.java - test/com/sun/javadoc/testDocRootInlineTag/package-list - test/com/sun/javadoc/testDocRootInlineTag/pkg/C.java - test/com/sun/javadoc/testDocRootLink/TestDocRootLink.java - test/com/sun/javadoc/testDocRootLink/pkg1/C1.java - test/com/sun/javadoc/testDocRootLink/pkg1/package.html - test/com/sun/javadoc/testDocRootLink/pkg2/C2.java - test/com/sun/javadoc/testDocRootLink/pkg2/package.html - test/com/sun/javadoc/testDupParamWarn/TestDupParamWarn.java - test/com/sun/javadoc/testDupParamWarn/pkg/Bar.java - test/com/sun/javadoc/testDupParamWarn/pkg/Foo.java - test/com/sun/javadoc/testEmptyClass/TestEmptyClass.java - test/com/sun/javadoc/testEmptyClass/src/Empty.java - test/com/sun/javadoc/testEnclosingClass/TestEnclosingClass.java - test/com/sun/javadoc/testEnclosingClass/pkg/MyClass.java - test/com/sun/javadoc/testEncoding/EncodeTest.java - test/com/sun/javadoc/testEncoding/TestEncoding.java - test/com/sun/javadoc/testExternalOverridenMethod/TestExternalOverridenMethod.java - test/com/sun/javadoc/testExternalOverridenMethod/package-list - test/com/sun/javadoc/testExternalOverridenMethod/pkg/XReader.java - test/com/sun/javadoc/testGeneratedBy/TestGeneratedBy.java - test/com/sun/javadoc/testGeneratedBy/pkg/MyClass.java - test/com/sun/javadoc/testGroupOption/TestGroupOption.java - test/com/sun/javadoc/testGroupOption/pkg1/C.java - test/com/sun/javadoc/testGroupOption/pkg2/C.java - test/com/sun/javadoc/testGroupOption/pkg3/C.java - test/com/sun/javadoc/testHeadings/TestHeadings.java - test/com/sun/javadoc/testHeadings/pkg1/C1.java - test/com/sun/javadoc/testHeadings/pkg2/C2.java - test/com/sun/javadoc/testHelpFile/TestHelpFile.java - test/com/sun/javadoc/testHelpOption/TestHelpOption.java - test/com/sun/javadoc/testHiddenMembers/TestHiddenMembers.java - test/com/sun/javadoc/testHiddenMembers/pkg/BaseClass.java - test/com/sun/javadoc/testHiddenMembers/pkg/SubClass.java - test/com/sun/javadoc/testHref/TestHref.java - test/com/sun/javadoc/testHref/package-list - test/com/sun/javadoc/testHref/pkg/C1.java - test/com/sun/javadoc/testHref/pkg/C2.java - test/com/sun/javadoc/testHref/pkg/C4.java - test/com/sun/javadoc/testHrefInDocComment/TestHrefInDocComment.java - test/com/sun/javadoc/testHrefInDocComment/pkg/I1.java - test/com/sun/javadoc/testHrefInDocComment/pkg/I2.java - test/com/sun/javadoc/testHtmlComments/C.java - test/com/sun/javadoc/testHtmlComments/TestHtmlComments.java - test/com/sun/javadoc/testHtmlDefinitionListTag/TestHtmlDefinitionListTag.java - test/com/sun/javadoc/testHtmlDefinitionListTag/pkg1/C1.java - test/com/sun/javadoc/testHtmlDefinitionListTag/pkg1/C2.java - test/com/sun/javadoc/testHtmlDefinitionListTag/pkg1/C3.java - test/com/sun/javadoc/testHtmlDefinitionListTag/pkg1/C4.java - test/com/sun/javadoc/testHtmlDefinitionListTag/pkg1/C5.java - test/com/sun/javadoc/testHtmlDefinitionListTag/pkg1/package-info.java - test/com/sun/javadoc/testHtmlDocument/TestHtmlDocument.java - test/com/sun/javadoc/testHtmlDocument/testLink.html - test/com/sun/javadoc/testHtmlDocument/testMarkup.html - test/com/sun/javadoc/testHtmlStrongTag/TestHtmlStrongTag.java - test/com/sun/javadoc/testHtmlStrongTag/pkg1/C1.java - test/com/sun/javadoc/testHtmlStrongTag/pkg2/C2.java - test/com/sun/javadoc/testHtmlTableStyles/TestHtmlTableStyles.java - test/com/sun/javadoc/testHtmlTableStyles/pkg1/TestTable.java - test/com/sun/javadoc/testHtmlTableStyles/pkg2/TestUse.java - test/com/sun/javadoc/testHtmlTableTags/TestHtmlTableTags.java - test/com/sun/javadoc/testHtmlTableTags/pkg1/C1.java - test/com/sun/javadoc/testHtmlTableTags/pkg1/I1.java - test/com/sun/javadoc/testHtmlTableTags/pkg1/package-info.java - test/com/sun/javadoc/testHtmlTableTags/pkg2/C2.java - test/com/sun/javadoc/testHtmlTableTags/pkg2/C3.java - test/com/sun/javadoc/testHtmlTableTags/pkg2/C4.java - test/com/sun/javadoc/testHtmlTableTags/pkg2/package-info.java - test/com/sun/javadoc/testHtmlTag/TestHtmlTag.java - test/com/sun/javadoc/testHtmlTag/pkg1/C1.java - test/com/sun/javadoc/testHtmlTag/pkg2/C2.java - test/com/sun/javadoc/testHtmlVersion/TestHtmlVersion.java - test/com/sun/javadoc/testHtmlVersion/pkg/AnnotationType.java - test/com/sun/javadoc/testHtmlVersion/pkg/AnotherClass.java - test/com/sun/javadoc/testHtmlVersion/pkg/TestError.java - test/com/sun/javadoc/testHtmlVersion/pkg/TestException.java - test/com/sun/javadoc/testHtmlVersion/pkg/TestInterface.java - test/com/sun/javadoc/testHtmlVersion/pkg/package-info.java - test/com/sun/javadoc/testHtmlVersion/pkg1/NestedInnerClass.java - test/com/sun/javadoc/testHtmlVersion/pkg1/PrivateIncludeInnerClass.java - test/com/sun/javadoc/testHtmlVersion/pkg1/ProtectedInnerClass.java - test/com/sun/javadoc/testHtmlVersion/pkg1/PublicExcludeInnerClass.java - test/com/sun/javadoc/testHtmlVersion/pkg1/RegClass.java - test/com/sun/javadoc/testHtmlVersion/pkg2/DeprecatedClassByAnnotation.java - test/com/sun/javadoc/testHtmlVersion/pkg2/Interface.java - test/com/sun/javadoc/testHtmlVersion/pkg2/TestAnnotationType.java - test/com/sun/javadoc/testHtmlVersion/pkg2/TestClass.java - test/com/sun/javadoc/testHtmlVersion/pkg2/TestEnum.java - test/com/sun/javadoc/testHtmlVersion/pkg2/TestError.java - test/com/sun/javadoc/testHtmlVersion/pkg2/TestException.java - test/com/sun/javadoc/testHtmlVersion/pkg2/TestInterface.java - test/com/sun/javadoc/testHtmlVersion/pkg3/ClassNoConstants.java - test/com/sun/javadoc/testHtmlVersion/profile-rtjar-includes.txt - test/com/sun/javadoc/testIndentation/TestIndentation.java - test/com/sun/javadoc/testIndentation/p/Indent.java - test/com/sun/javadoc/testIndentation/p/IndentAnnot.java - test/com/sun/javadoc/testIndex/NoPackage.java - test/com/sun/javadoc/testIndex/TestIndex.java - test/com/sun/javadoc/testIndex/pkg/AnnotationType.java - test/com/sun/javadoc/testIndex/pkg/C.java - test/com/sun/javadoc/testIndex/pkg/Coin.java - test/com/sun/javadoc/testIndex/pkg/Interface.java - test/com/sun/javadoc/testInlineLinkLabel/TestInlineLinkLabel.java - test/com/sun/javadoc/testInlineLinkLabel/pkg/C1.java - test/com/sun/javadoc/testInlineLinkLabel/pkg/C2.java - test/com/sun/javadoc/testInlineLinkLabel/pkg/package.html - test/com/sun/javadoc/testInterface/TestInterface.java - test/com/sun/javadoc/testInterface/pkg/Child.java - test/com/sun/javadoc/testInterface/pkg/Interface.java - test/com/sun/javadoc/testInterface/pkg/Parent.java - test/com/sun/javadoc/testJavaFX/TestJavaFX.java - test/com/sun/javadoc/testJavaFX/pkg1/C.java - test/com/sun/javadoc/testJavaFX/pkg1/D.java - test/com/sun/javadoc/testJavaFX/pkg2/Test.java - test/com/sun/javadoc/testJavascript/TestJavascript.java - test/com/sun/javadoc/testJavascript/pkg/C.java - test/com/sun/javadoc/testLambdaFeature/TestLambdaFeature.java - test/com/sun/javadoc/testLambdaFeature/pkg/A.java - test/com/sun/javadoc/testLambdaFeature/pkg/B.java - test/com/sun/javadoc/testLambdaFeature/pkg1/FuncInf.java - test/com/sun/javadoc/testLambdaFeature/pkg1/NotAFuncInf.java - test/com/sun/javadoc/testLeadingSpaces/LeadingSpaces.java - test/com/sun/javadoc/testLegacyTaglet/C.java - test/com/sun/javadoc/testLegacyTaglet/Check.java - test/com/sun/javadoc/testLegacyTaglet/TestLegacyTaglet.java - test/com/sun/javadoc/testLegacyTaglet/ToDoTaglet.java - test/com/sun/javadoc/testLegacyTaglet/UnderlineTaglet.java - test/com/sun/javadoc/testLinkOption/TestBadLinkOption.java - test/com/sun/javadoc/testLinkOption/TestLinkOption.java - test/com/sun/javadoc/testLinkOption/TestNewLineInLink.java - test/com/sun/javadoc/testLinkOption/extra/StringBuilder.java - test/com/sun/javadoc/testLinkOption/jdk/package-list - test/com/sun/javadoc/testLinkOption/mylib/lang/StringBuilderChild.java - test/com/sun/javadoc/testLinkOption/pkg/C.java - test/com/sun/javadoc/testLinkOption/pkg2/C2.java - test/com/sun/javadoc/testLinkOption/testNewLineInLink/C.java - test/com/sun/javadoc/testLinkOption/testNewLineInLink/package.html - test/com/sun/javadoc/testLinkTaglet/TestLinkTaglet.java - test/com/sun/javadoc/testLinkTaglet/checkPkg/A.java - test/com/sun/javadoc/testLinkTaglet/checkPkg/B.java - test/com/sun/javadoc/testLinkTaglet/pkg/C.java - test/com/sun/javadoc/testLinkToSerialForm/TestLinkToSerialForm.java - test/com/sun/javadoc/testLinkToSerialForm/pkg/C.java - test/com/sun/javadoc/testLiteralCodeInPre/TestLiteralCodeInPre.java - test/com/sun/javadoc/testLiteralCodeInPre/pkg/Test.java - test/com/sun/javadoc/testMemberInheritence/TestMemberInheritence.java - test/com/sun/javadoc/testMemberInheritence/diamond/A.java - test/com/sun/javadoc/testMemberInheritence/diamond/B.java - test/com/sun/javadoc/testMemberInheritence/diamond/C.java - test/com/sun/javadoc/testMemberInheritence/diamond/X.java - test/com/sun/javadoc/testMemberInheritence/diamond/Z.java - test/com/sun/javadoc/testMemberInheritence/inheritDist/A.java - test/com/sun/javadoc/testMemberInheritence/inheritDist/B.java - test/com/sun/javadoc/testMemberInheritence/inheritDist/C.java - test/com/sun/javadoc/testMemberInheritence/pkg/BaseClass.java - test/com/sun/javadoc/testMemberInheritence/pkg/BaseInterface.java - test/com/sun/javadoc/testMemberInheritence/pkg/SubClass.java - test/com/sun/javadoc/testMemberSummary/TestMemberSummary.java - test/com/sun/javadoc/testMemberSummary/pkg/PrivateParent.java - test/com/sun/javadoc/testMemberSummary/pkg/PublicChild.java - test/com/sun/javadoc/testMemberSummary/pkg2/A.java - test/com/sun/javadoc/testMethodTypes/TestMethodTypes.java - test/com/sun/javadoc/testMethodTypes/pkg1/A.java - test/com/sun/javadoc/testMethodTypes/pkg1/B.java - test/com/sun/javadoc/testMethodTypes/pkg1/D.java - test/com/sun/javadoc/testModifier/Interface.java - test/com/sun/javadoc/testModifier/ModifierAbstract.java - test/com/sun/javadoc/testModifier/Test.java - test/com/sun/javadoc/testModifier/TestModifier.java - test/com/sun/javadoc/testNavigation/TestNavigation.java - test/com/sun/javadoc/testNavigation/pkg/A.java - test/com/sun/javadoc/testNavigation/pkg/C.java - test/com/sun/javadoc/testNavigation/pkg/E.java - test/com/sun/javadoc/testNavigation/pkg/I.java - test/com/sun/javadoc/testNestedGenerics/TestNestedGenerics.java - test/com/sun/javadoc/testNestedGenerics/pkg/NestedGenerics.java - test/com/sun/javadoc/testNestedInlineTag/TestNestedInlineTag.java - test/com/sun/javadoc/testNestedInlineTag/testtaglets/BoldTaglet.java - test/com/sun/javadoc/testNestedInlineTag/testtaglets/GreenTaglet.java - test/com/sun/javadoc/testNestedInlineTag/testtaglets/UnderlineTaglet.java - test/com/sun/javadoc/testNewLanguageFeatures/TestNewLanguageFeatures.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/AnnotationType.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/AnnotationTypeUndocumented.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/AnnotationTypeUsage.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/Coin.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/MultiTypeParameters.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/SubInterface.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/SuperInterface.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/TypeParameterSubClass.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/TypeParameterSuperClass.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/TypeParameters.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/VarArgs.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/Wildcards.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg/package-info.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg1/A.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg1/B.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/ClassUseTest1.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/ClassUseTest2.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/ClassUseTest3.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/Foo.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/Foo2.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/Foo3.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/Foo4.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/ParamTest.java - test/com/sun/javadoc/testNewLanguageFeatures/pkg2/ParamTest2.java - test/com/sun/javadoc/testNoPackagesFile/C.java - test/com/sun/javadoc/testNoPackagesFile/TestNoPackagesFile.java - test/com/sun/javadoc/testNonInlineHtmlTagRemoval/C.java - test/com/sun/javadoc/testNonInlineHtmlTagRemoval/Negative.java - test/com/sun/javadoc/testNonInlineHtmlTagRemoval/TestNonInlineHtmlTagRemoval.java - test/com/sun/javadoc/testNotifications/TestNotifications.java - test/com/sun/javadoc/testNotifications/pkg/C.java - test/com/sun/javadoc/testOptions/TestOptions.java - test/com/sun/javadoc/testOptions/pkg/Foo.java - test/com/sun/javadoc/testOrdering/C.java - test/com/sun/javadoc/testOrdering/TestOrdering.java - test/com/sun/javadoc/testOrdering/UsedInC.java - test/com/sun/javadoc/testOrdering/pkg1/A.java - test/com/sun/javadoc/testOrdering/pkg1/B.java - test/com/sun/javadoc/testOrdering/pkg1/C1.java - test/com/sun/javadoc/testOrdering/pkg1/C2.java - test/com/sun/javadoc/testOrdering/pkg1/C3.java - test/com/sun/javadoc/testOrdering/pkg1/C4.java - test/com/sun/javadoc/testOrdering/pkg1/MethodOrder.java - test/com/sun/javadoc/testOrdering/pkg1/UsedClass.java - test/com/sun/javadoc/testOrdering/src-2/a/A.java - test/com/sun/javadoc/testOrdering/src-2/a/something.java - test/com/sun/javadoc/testOrdering/src-2/b/B.java - test/com/sun/javadoc/testOrdering/src-2/b/something.java - test/com/sun/javadoc/testOrdering/src-2/e/something.java - test/com/sun/javadoc/testOrdering/src-2/something/J.java - test/com/sun/javadoc/testOrdering/src-2/something/package-info.java - test/com/sun/javadoc/testOrdering/src-2/something/something.java - test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java - test/com/sun/javadoc/testOverridenMethods/TestOverridenMethodDocCopy.java - test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethods.java - test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPackageFlag.java - test/com/sun/javadoc/testOverridenMethods/TestOverridenPrivateMethodsWithPrivateFlag.java - test/com/sun/javadoc/testOverridenMethods/pkg1/BaseClass.java - test/com/sun/javadoc/testOverridenMethods/pkg1/SubClass.java - test/com/sun/javadoc/testOverridenMethods/pkg2/SubClass.java - test/com/sun/javadoc/testOverridenMethods/pkg3/I0.java - test/com/sun/javadoc/testOverridenMethods/pkg3/I1.java - test/com/sun/javadoc/testOverridenMethods/pkg3/I2.java - test/com/sun/javadoc/testOverridenMethods/pkg3/I3.java - test/com/sun/javadoc/testOverridenMethods/pkg3/I4.java - test/com/sun/javadoc/testPackageDeprecation/C2.java - test/com/sun/javadoc/testPackageDeprecation/FooDepr.java - test/com/sun/javadoc/testPackageDeprecation/TestPackageDeprecation.java - test/com/sun/javadoc/testPackageDeprecation/pkg/A.java - test/com/sun/javadoc/testPackageDeprecation/pkg1/ClassUseTest1.java - test/com/sun/javadoc/testPackageDeprecation/pkg1/Foo.java - test/com/sun/javadoc/testPackageDeprecation/pkg1/Foo2.java - test/com/sun/javadoc/testPackageDeprecation/pkg1/package-info.java - test/com/sun/javadoc/testPackagePage/TestPackagePage.java - test/com/sun/javadoc/testPackagePage/com/pkg/C.java - test/com/sun/javadoc/testPackagePage/com/pkg/package.html - test/com/sun/javadoc/testPackagePage/pkg2/C.java - test/com/sun/javadoc/testParamTaglet/TestParamTaglet.java - test/com/sun/javadoc/testParamTaglet/pkg/C.java - test/com/sun/javadoc/testParamTaglet/pkg/Parent.java - test/com/sun/javadoc/testPrivateClasses/TestPrivateClasses.java - test/com/sun/javadoc/testPrivateClasses/pkg/PrivateInterface.java - test/com/sun/javadoc/testPrivateClasses/pkg/PrivateParent.java - test/com/sun/javadoc/testPrivateClasses/pkg/PublicChild.java - test/com/sun/javadoc/testPrivateClasses/pkg/PublicInterface.java - test/com/sun/javadoc/testPrivateClasses/pkg2/C.java - test/com/sun/javadoc/testPrivateClasses/pkg2/I.java - test/com/sun/javadoc/testRecurseSubPackages/TestRecurseSubPackages.java - test/com/sun/javadoc/testRecurseSubPackages/pkg1/C1.java - test/com/sun/javadoc/testRecurseSubPackages/pkg1/C2.java - test/com/sun/javadoc/testRecurseSubPackages/pkg1/pkg2/C3.java - test/com/sun/javadoc/testRecurseSubPackages/pkg1/pkg2/C4.java - test/com/sun/javadoc/testRecurseSubPackages/pkg1/pkg2/packageToExclude/DummyClass.java - test/com/sun/javadoc/testRecurseSubPackages/pkg1/pkg2/pkg3/C5.java - test/com/sun/javadoc/testRecurseSubPackages/pkg1/pkg2/pkg3/C6.java - test/com/sun/javadoc/testRelativeLinks/TestRelativeLinks.java - test/com/sun/javadoc/testRelativeLinks/pkg/C.java - test/com/sun/javadoc/testRelativeLinks/pkg/package.html - test/com/sun/javadoc/testRelativeLinks/pkg2/Foo.java - test/com/sun/javadoc/testRepeatedAnnotations/TestRepeatedAnnotations.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/C.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeRegDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContaineeSynthDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerRegNotDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/ContainerSynthDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/D.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/NonSynthDocContainer.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegArryDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContaineeNotDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegContainerNotDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg/RegDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/C.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeNotDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContaineeSynthDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerSynthNotDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/ContainerValNotDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContaineeNotDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValDoc.java - test/com/sun/javadoc/testRepeatedAnnotations/pkg1/RegContainerValNotDoc.java - test/com/sun/javadoc/testReturnTag/TestReturnTag.java - test/com/sun/javadoc/testSearch/TestSearch.java - test/com/sun/javadoc/testSearch/UnnamedPkgClass.java - test/com/sun/javadoc/testSearch/pkg/AnnotationType.java - test/com/sun/javadoc/testSearch/pkg/AnotherClass.java - test/com/sun/javadoc/testSearch/pkg/TestError.java - test/com/sun/javadoc/testSearch/pkg/TestException.java - test/com/sun/javadoc/testSearch/pkg/TestInterface.java - test/com/sun/javadoc/testSearch/pkg/package-info.java - test/com/sun/javadoc/testSearch/pkg1/NestedInnerClass.java - test/com/sun/javadoc/testSearch/pkg1/PrivateIncludeInnerClass.java - test/com/sun/javadoc/testSearch/pkg1/ProtectedInnerClass.java - test/com/sun/javadoc/testSearch/pkg1/PublicExcludeInnerClass.java - test/com/sun/javadoc/testSearch/pkg1/RegClass.java - test/com/sun/javadoc/testSearch/pkg2/DeprecatedClassByAnnotation.java - test/com/sun/javadoc/testSearch/pkg2/Interface.java - test/com/sun/javadoc/testSearch/pkg2/TestAnnotationType.java - test/com/sun/javadoc/testSearch/pkg2/TestClass.java - test/com/sun/javadoc/testSearch/pkg2/TestEnum.java - test/com/sun/javadoc/testSearch/pkg2/TestError.java - test/com/sun/javadoc/testSearch/pkg2/TestException.java - test/com/sun/javadoc/testSearch/pkg2/TestInterface.java - test/com/sun/javadoc/testSearch/pkg3/ClassNoConstants.java - test/com/sun/javadoc/testSearch/pkgfx/C.java - test/com/sun/javadoc/testSeeTag/TestSeeTag.java - test/com/sun/javadoc/testSeeTag/pkg/Test.java - test/com/sun/javadoc/testSerialVersionUID/C.java - test/com/sun/javadoc/testSerialVersionUID/TestSerialVersionUID.java - test/com/sun/javadoc/testSerializedForm/TestSerializedForm.java - test/com/sun/javadoc/testSerializedForm/pkg1/NestedInnerClass.java - test/com/sun/javadoc/testSerializedForm/pkg1/PrivateIncludeInnerClass.java - test/com/sun/javadoc/testSerializedForm/pkg1/ProtectedInnerClass.java - test/com/sun/javadoc/testSerializedForm/pkg1/PublicExcludeInnerClass.java - test/com/sun/javadoc/testSerializedFormDeprecationInfo/TestSerializedFormDeprecationInfo.java - test/com/sun/javadoc/testSerializedFormDeprecationInfo/pkg1/C1.java - test/com/sun/javadoc/testSerializedFormDeprecationInfo/pkg1/C2.java - test/com/sun/javadoc/testSerializedFormDeprecationInfo/pkg1/C3.java - test/com/sun/javadoc/testSimpleTag/C.java - test/com/sun/javadoc/testSimpleTag/TestSimpleTag.java - test/com/sun/javadoc/testSimpleTagExclude/DummyClass.java - test/com/sun/javadoc/testSimpleTagExclude/TestSimpleTagExclude.java - test/com/sun/javadoc/testSimpleTagInherit/TestSimpleTagInherit.java - test/com/sun/javadoc/testSimpleTagInherit/p/BaseClass.java - test/com/sun/javadoc/testSimpleTagInherit/p/TestClass.java - test/com/sun/javadoc/testSinceTag/TestSinceTag.java - test/com/sun/javadoc/testSinceTag/pkg1/C1.java - test/com/sun/javadoc/testSingleQuotedLink/TestSingleQuotedLink.java - test/com/sun/javadoc/testSingleQuotedLink/pkg1/C1.java - test/com/sun/javadoc/testSingleQuotedLink/pkg1/C2.java - test/com/sun/javadoc/testSingleQuotedLink/pkg1/package.html - test/com/sun/javadoc/testSourceTab/DoubleTab/C.java - test/com/sun/javadoc/testSourceTab/SingleTab/C.java - test/com/sun/javadoc/testSourceTab/TestSourceTab.java - test/com/sun/javadoc/testStylesheet/TestStylesheet.java - test/com/sun/javadoc/testStylesheet/pkg/A.java - test/com/sun/javadoc/testSubTitle/TestSubTitle.java - test/com/sun/javadoc/testSubTitle/pkg/C.java - test/com/sun/javadoc/testSubTitle/pkg/package.html - test/com/sun/javadoc/testSummaryHeading/C.java - test/com/sun/javadoc/testSummaryHeading/TestSummaryHeading.java - test/com/sun/javadoc/testSuperclassInSerialForm/TestSuperClassInSerialForm.java - test/com/sun/javadoc/testSuperclassInSerialForm/pkg/SubClass.java - test/com/sun/javadoc/testSuperclassInSerialForm/pkg/SuperClass.java - test/com/sun/javadoc/testSupplementary/C.java - test/com/sun/javadoc/testSupplementary/TestSupplementary.java - test/com/sun/javadoc/testTagHolderMethod/TestTagHolderMethod.java - test/com/sun/javadoc/testTagHolderMethod/pkg/C.java - test/com/sun/javadoc/testTagInheritence/TestTagInheritence.java - test/com/sun/javadoc/testTagInheritence/firstSentence/A.java - test/com/sun/javadoc/testTagInheritence/firstSentence/B.java - test/com/sun/javadoc/testTagInheritence/firstSentence2/A.java - test/com/sun/javadoc/testTagInheritence/firstSentence2/B.java - test/com/sun/javadoc/testTagInheritence/firstSentence2/C.java - test/com/sun/javadoc/testTagInheritence/pkg/TestAbstractClass.java - test/com/sun/javadoc/testTagInheritence/pkg/TestInterface.java - test/com/sun/javadoc/testTagInheritence/pkg/TestInterfaceForAbstractClass.java - test/com/sun/javadoc/testTagInheritence/pkg/TestSuperSuperClass.java - test/com/sun/javadoc/testTagInheritence/pkg/TestSuperSuperInterface.java - test/com/sun/javadoc/testTagInheritence/pkg/TestTagInheritence.java - test/com/sun/javadoc/testTagMisuse/TestTagMisuse.java - test/com/sun/javadoc/testTagOutput/TestTagOutput.java - test/com/sun/javadoc/testTagOutput/pkg1/DeprecatedTag.java - test/com/sun/javadoc/testTaglets/C.java - test/com/sun/javadoc/testTaglets/Child.java - test/com/sun/javadoc/testTaglets/Parent.java - test/com/sun/javadoc/testTaglets/TestTaglets.java - test/com/sun/javadoc/testTaglets/taglets/Foo.java - test/com/sun/javadoc/testThrowsHead/C.java - test/com/sun/javadoc/testThrowsHead/TestThrowsHead.java - test/com/sun/javadoc/testThrowsInheritence/C.java - test/com/sun/javadoc/testThrowsInheritence/Foo.java - test/com/sun/javadoc/testThrowsInheritence/I.java - test/com/sun/javadoc/testThrowsInheritence/Iface.java - test/com/sun/javadoc/testThrowsInheritence/TestThrowsTagInheritence.java - test/com/sun/javadoc/testThrowsTag/TestThrowsTag.java - test/com/sun/javadoc/testThrowsTag/pkg/C.java - test/com/sun/javadoc/testThrowsTag/pkg/P.java - test/com/sun/javadoc/testThrowsTag/pkg/T1.java - test/com/sun/javadoc/testThrowsTag/pkg/T2.java - test/com/sun/javadoc/testThrowsTag/pkg/T3.java - test/com/sun/javadoc/testThrowsTag/pkg/T4.java - test/com/sun/javadoc/testThrowsTag/pkg/T5.java - test/com/sun/javadoc/testThrowsTag/pkg/T6.java - test/com/sun/javadoc/testThrowsTag/pkg/T7.java - test/com/sun/javadoc/testThrowsTag/pkg/T8.java - test/com/sun/javadoc/testTitleInHref/TestTitleInHref.java - test/com/sun/javadoc/testTitleInHref/package-list - test/com/sun/javadoc/testTitleInHref/pkg/Class.java - test/com/sun/javadoc/testTitleInHref/pkg/Interface.java - test/com/sun/javadoc/testTitleInHref/pkg/Links.java - test/com/sun/javadoc/testTopOption/TestTopOption.java - test/com/sun/javadoc/testTopOption/overview.html - test/com/sun/javadoc/testTopOption/pkg/AnnotationType.java - test/com/sun/javadoc/testTopOption/pkg/Cl.java - test/com/sun/javadoc/testTypeAnnotations/TestTypeAnnotations.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/ClassExtends.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/ClassParameters.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/Fields.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/MethodReturnType.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/MethodTypeParameters.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/Parameters.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/Receivers.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/Throws.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/TypeParameters.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/Varargs.java - test/com/sun/javadoc/testTypeAnnotations/typeannos/Wildcards.java - test/com/sun/javadoc/testTypeParams/TestTypeParameters.java - test/com/sun/javadoc/testTypeParams/pkg/C.java - test/com/sun/javadoc/testTypeParams/pkg/ClassUseTest3.java - test/com/sun/javadoc/testTypeParams/pkg/Foo4.java - test/com/sun/javadoc/testTypeParams/pkg/ParamTest2.java - test/com/sun/javadoc/testTypeParams/pkg/Parent.java - test/com/sun/javadoc/testUnnamedPackage/BadSource.java - test/com/sun/javadoc/testUnnamedPackage/C.java - test/com/sun/javadoc/testUnnamedPackage/TestUnnamedPackage.java - test/com/sun/javadoc/testUnnamedPackage/package.html - test/com/sun/javadoc/testUseOption/C.java - test/com/sun/javadoc/testUseOption/TestUseOption.java - test/com/sun/javadoc/testUseOption/UsedInC.java - test/com/sun/javadoc/testUseOption/pkg1/AnAbstract.java - test/com/sun/javadoc/testUseOption/pkg1/C1.java - test/com/sun/javadoc/testUseOption/pkg1/C10.java - test/com/sun/javadoc/testUseOption/pkg1/C2.java - test/com/sun/javadoc/testUseOption/pkg1/C4.java - test/com/sun/javadoc/testUseOption/pkg1/C5.java - test/com/sun/javadoc/testUseOption/pkg1/C6.java - test/com/sun/javadoc/testUseOption/pkg1/C7.java - test/com/sun/javadoc/testUseOption/pkg1/C8.java - test/com/sun/javadoc/testUseOption/pkg1/C9.java - test/com/sun/javadoc/testUseOption/pkg1/UsedClass.java - test/com/sun/javadoc/testUseOption/pkg1/UsedInterface.java - test/com/sun/javadoc/testUseOption/pkg1/UsedInterfaceA.java - test/com/sun/javadoc/testUseOption/pkg1/package.html - test/com/sun/javadoc/testUseOption/pkg2/C3.java - test/com/sun/javadoc/testUseOption/pkg2/package.html - test/com/sun/javadoc/testUseOption/unique/C1.java - test/com/sun/javadoc/testUseOption/unique/UseMe.java - test/com/sun/javadoc/testValueTag/TestValueTag.java - test/com/sun/javadoc/testValueTag/pkg1/Class1.java - test/com/sun/javadoc/testValueTag/pkg1/Class2.java - test/com/sun/javadoc/testValueTag/pkg1/CustomTagUsage.java - test/com/sun/javadoc/testValueTag/pkg2/Class3.java - test/com/sun/javadoc/testValueTag/pkg2/package.html - test/com/sun/javadoc/testWarnBadParamNames/C.java - test/com/sun/javadoc/testWarnBadParamNames/TestWarnBadParamNames.java - test/com/sun/javadoc/testWarnings/TestWarnings.java - test/com/sun/javadoc/testWarnings/pkg/X.java - test/com/sun/javadoc/testWarnings/pkg/package.html - test/com/sun/javadoc/testWindowTitle/TestWindowTitle.java - test/com/sun/javadoc/testWindowTitle/p1/C1.java - test/com/sun/javadoc/testWindowTitle/p2/C2.java - test/com/sun/javadoc/testXOption/TestXOption.java - test/com/sun/javadoc/typeAnnotations/smoke/TestSmoke.java - test/com/sun/javadoc/typeAnnotations/smoke/pkg/TargetTypes.java - test/tools/javadoc/6958836/errs/Errors.java - test/tools/javadoc/6958836/warns/Warnings.java - test/tools/javadoc/T4696488.java - test/tools/javadoc/T6551367.java - test/tools/javadoc/TestScriptInComment.java - test/tools/javadoc/api/basic/TagletPathTest.java - test/tools/javadoc/badSuper/BadSuper.java - test/tools/javadoc/badSuper/p/A.java - test/tools/javadoc/badSuper/p/B.java - test/tools/javadoc/sampleapi/SampleApiTest.java - test/tools/javadoc/sampleapi/res/fx.xml - test/tools/javadoc/sampleapi/res/simple.xml - test/tools/javadoc/sampleapi/res/sub.xml - test/tools/javadoc/sampleapi/res/tiny.xml Changeset: 95e646101afe Author: jjg Date: 2017-07-07 10:21 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/95e646101afe 8183897: Update the "striped" style in the javadoc style sheet Reviewed-by: bpatel ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css Changeset: bed86b98e7db Author: jjg Date: 2017-07-11 18:09 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/bed86b98e7db 8184023: Fix tables in doc comments to be accessible Reviewed-by: ksrini ! src/jdk.javadoc/share/classes/com/sun/javadoc/Tag.java ! src/jdk.javadoc/share/classes/jdk/javadoc/doclet/package-info.java Changeset: 069d27d987c7 Author: pmuthuswamy Date: 2017-07-12 12:27 +0530 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/069d27d987c7 8074364: Update error message for incorrect annotation type declaration Summary: Issue a more direct, specific error when an annotation type is declared where it is disallowed Reviewed-by: sadayapalam ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/IllegalAnnotation.java ! test/tools/javac/IllegalAnnotation.out + test/tools/javac/diags/examples/IllegalAnnotationDeclaration.java Changeset: 2b9273266ea6 Author: jjg Date: 2017-07-12 11:24 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/2b9273266ea6 8184225: Fix accessibility and tidy issues in jdk.jshell docs Reviewed-by: jlahoda ! src/jdk.jshell/share/classes/jdk/jshell/Snippet.java ! src/jdk.jshell/share/classes/jdk/jshell/execution/JdiExecutionControlProvider.java Changeset: c81b0db7b845 Author: bpatel Date: 2017-07-12 17:39 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/c81b0db7b845 8170825: Generated index page has a broken link Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java + test/jdk/javadoc/doclet/testIndexFiles/TestIndexFiles.java + test/jdk/javadoc/doclet/testIndexFiles/pkg/ClassForIndexFilesTest.java + test/jdk/javadoc/doclet/testIndexFiles/pkg/package-info.java Changeset: 949093a9bc94 Author: bpatel Date: 2017-07-12 18:54 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/949093a9bc94 8182257: Duplicate anchor ids in generated javadoc pages Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java ! test/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java Changeset: c3157e930907 Author: jlahoda Date: 2017-07-13 08:49 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/c3157e930907 8181298: Assertion failure in com.sun.tools.javac.comp.Modules Summary: Fixing dependencies for ct.sym-files target. Reviewed-by: tbell, erikj Contributed-by: erik.joelsson at oracle.com ! make/gendata/Gendata-jdk.compiler.gmk Changeset: d601b22360fa Author: jlahoda Date: 2017-07-13 13:37 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/d601b22360fa 8182450: javac aborts when generating ct.sym intermittently Summary: Initialize the module system model even in presence of missing/broken module-infos; BadClassFiles should not immediatelly abort compilation anymore, but should be handled as if the classfile did not exist. Reviewed-by: jjg ! make/src/classes/build/tools/symbolgenerator/TransitiveDependencies.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/ClassFinder.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/modules/BrokenModulesTest.java ! test/tools/javac/modules/EdgeCases.java + test/tools/javac/processing/model/completionfailure/NoAbortForBadClassFile.java Changeset: e8a02dc46a56 Author: lana Date: 2017-07-13 19:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/e8a02dc46a56 Added tag jdk-10+15 for changeset 2b9273266ea6 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 13 21:57:04 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 21:57:04 +0000 Subject: hg: amber/amber: 11 new changesets Message-ID: <201707132157.v6DLv5Gq029303@aojmv0008.oracle.com> Changeset: 9b869e777027 Author: lana Date: 2017-07-06 22:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/9b869e777027 Added tag jdk-10+14 for changeset 1fd5901544ac ! .hgtags Changeset: 99918cff846d Author: ihse Date: 2017-06-21 12:51 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/99918cff846d 8179892: Update build documentation for JDK 9 Reviewed-by: erikj ! common/doc/building.html ! common/doc/building.md ! common/doc/testing.html ! make/Init.gmk ! make/UpdateBuildDocs.gmk Changeset: 84777531d994 Author: lana Date: 2017-06-22 19:23 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/84777531d994 Merge Changeset: 85e6cb013b98 Author: lana Date: 2017-06-29 17:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/85e6cb013b98 Added tag jdk-9+176 for changeset 84777531d994 ! .hgtags Changeset: a4371edb589c Author: mr Date: 2017-07-03 13:18 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/a4371edb589c 8183251: Meta "keywords" tag malformed in overview-summary.html and related pages Reviewed-by: jjg, alanb ! make/Docs.gmk Changeset: ec4159ebe705 Author: lana Date: 2017-07-06 20:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/ec4159ebe705 Added tag jdk-9+177 for changeset a4371edb589c ! .hgtags Changeset: bbef2eeb4a12 Author: lana Date: 2017-07-07 03:05 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/bbef2eeb4a12 Merge ! .hgtags - common/bin/shell-tracer.sh ! common/doc/testing.html ! make/Init.gmk Changeset: 3a5e2b08d5f6 Author: simonis Date: 2017-07-06 16:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/3a5e2b08d5f6 8183534: [TEST] Make detection of compilation mode more robust Reviewed-by: clanger, stuefe ! test/jtreg-ext/requires/VMProps.java Changeset: a6c830ee8a67 Author: erikj Date: 2017-07-11 14:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/a6c830ee8a67 8184075: Make run-test-prebuilt profile more robust Reviewed-by: tbell ! common/conf/jib-profiles.js Changeset: d681b4d6c202 Author: jlahoda Date: 2017-07-13 08:49 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/d681b4d6c202 8181298: Assertion failure in com.sun.tools.javac.comp.Modules Summary: Fixing dependencies for ct.sym-files target. Reviewed-by: tbell, erikj Contributed-by: erik.joelsson at oracle.com ! make/Main.gmk Changeset: c1f32b73cab4 Author: lana Date: 2017-07-13 19:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/c1f32b73cab4 Added tag jdk-10+15 for changeset a6c830ee8a67 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 13 21:57:05 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 21:57:05 +0000 Subject: hg: amber/amber/nashorn: 7 new changesets Message-ID: <201707132157.v6DLv57l029313@aojmv0008.oracle.com> Changeset: ebfb35301318 Author: lana Date: 2017-07-06 22:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/ebfb35301318 Added tag jdk-10+14 for changeset fed3f3298757 ! .hgtags Changeset: b25986e36b28 Author: lana Date: 2017-06-29 17:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/b25986e36b28 Added tag jdk-9+176 for changeset 3c6fbdf6e785 ! .hgtags Changeset: aa7404e062b9 Author: mr Date: 2017-07-03 13:18 -0700 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/aa7404e062b9 8182776: Fix typos in module declarations Reviewed-by: jjg, alanb ! src/jdk.dynalink/share/classes/module-info.java Changeset: 7497ad85759f Author: lana Date: 2017-07-06 20:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/7497ad85759f Added tag jdk-9+177 for changeset aa7404e062b9 ! .hgtags Changeset: f8a0c4895b2a Author: lana Date: 2017-07-07 03:06 +0000 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/f8a0c4895b2a Merge ! .hgtags Changeset: d2726917b0dd Author: sdama Date: 2017-07-13 16:51 +0530 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/d2726917b0dd 8184239: Fix broken nashorn/samples Summary: Fixed broken nashorn samples Reviewed-by: sundar, hannesw, jlaskey Contributed-by: srinivas.dama at oracle.com ! samples/barchart_weather.js ! samples/datepick.js ! samples/jsonviewer.js Changeset: f456f59dad3f Author: lana Date: 2017-07-13 19:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/f456f59dad3f Added tag jdk-10+15 for changeset f8a0c4895b2a ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 13 21:57:04 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 21:57:04 +0000 Subject: hg: amber/amber/jdk: 20 new changesets Message-ID: <201707132157.v6DLv5dH029316@aojmv0008.oracle.com> Changeset: 4d2cb50a1928 Author: lana Date: 2017-07-06 22:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/4d2cb50a1928 Added tag jdk-10+14 for changeset 7a2bc0a80087 ! .hgtags Changeset: 2425838cfb5e Author: mullan Date: 2017-06-23 14:32 -0400 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/2425838cfb5e 8182652: RuntimePermission("usePolicy") is not a Java SE permission Reviewed-by: mchung ! src/java.base/share/classes/java/lang/RuntimePermission.java Changeset: 9f27d513658d Author: jjg Date: 2017-06-26 18:48 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/9f27d513658d 8182736: javadoc generates bad names and broken module graph links Reviewed-by: jjg, bpatel, darcy, ksrini Contributed-by: bhavesh.patel at oracle.com, jonathan.gibbons at oracle.com ! make/src/classes/build/tools/taglet/ModuleGraph.java Changeset: 473db5c4c2c9 Author: lana Date: 2017-06-29 17:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/473db5c4c2c9 Added tag jdk-9+176 for changeset 9f27d513658d ! .hgtags Changeset: d5c07d9a0146 Author: ksrini Date: 2017-06-29 17:12 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/d5c07d9a0146 8183141: java --help-extra in non-English locales lists --permit-illegal-access which no longer exists Reviewed-by: alanb ! src/java.base/share/classes/sun/launcher/resources/launcher_de.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_es.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_fr.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_it.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_ja.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_ko.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_pt_BR.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_sv.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_zh_CN.properties ! src/java.base/share/classes/sun/launcher/resources/launcher_zh_TW.properties Changeset: a873a0435751 Author: erikj Date: 2017-07-03 10:27 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/a873a0435751 8183166: lib\jawt.lib is missing from JDK 9 distribution for Windows Reviewed-by: ihse ! make/lib/Awt2dLibraries.gmk Changeset: 80acf577b7d0 Author: mr Date: 2017-07-03 13:18 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/80acf577b7d0 8182776: Fix typos in module declarations 8183161: Fix font-family style attributes in module declarations Reviewed-by: jjg, alanb ! src/java.base/share/classes/module-info.java ! src/java.management.rmi/share/classes/module-info.java ! src/java.se.ee/share/classes/module-info.java ! src/java.se/share/classes/module-info.java ! src/java.transaction/share/classes/module-info.java ! src/jdk.httpserver/share/classes/module-info.java ! src/jdk.jartool/share/classes/module-info.java ! src/jdk.management/share/classes/com/sun/management/package-info.java ! src/jdk.management/share/classes/module-info.java Changeset: 443025bee731 Author: lana Date: 2017-07-06 20:13 +0000 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/443025bee731 Added tag jdk-9+177 for changeset 80acf577b7d0 ! .hgtags Changeset: 28ec2d23ed70 Author: lana Date: 2017-07-07 03:09 +0000 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/28ec2d23ed70 Merge ! .hgtags - src/java.base/macosx/native/launcher/jexec.c ! src/java.base/share/classes/module-info.java - src/java.base/share/classes/sun/security/ssl/EllipticCurvesExtension.java - src/java.base/share/classes/sun/security/ssl/RecordType.java - src/java.base/unix/classes/sun/nio/ch/DefaultAsynchronousChannelProvider.java - test/java/io/File/MacPathTest.sh - test/java/io/File/basic.sh - test/java/io/FileOutputStream/FileOpen.sh - test/java/io/FileOutputStream/FileOpenNeg.java - test/java/io/FileOutputStream/FileOpenPos.java - test/java/io/Serializable/class/NonSerialA_1.java - test/java/io/Serializable/class/NonSerialA_2.java - test/java/io/Serializable/class/SerialA.java - test/java/io/Serializable/class/SerialA_1.java - test/java/io/Serializable/class/SerialA_2.java - test/java/io/Serializable/class/SerialA_3.java - test/java/io/Serializable/class/Test.java - test/java/io/Serializable/class/run.sh - test/java/io/Serializable/evolution/AddedExternField/run.sh - test/java/io/Serializable/evolution/RenamePackage/run.sh - test/java/io/Serializable/maskSyntheticModifier/Test.java - test/java/io/Serializable/maskSyntheticModifier/run.sh - test/java/io/Serializable/packageAccess/Test.java - test/java/io/Serializable/packageAccess/run.sh - test/java/io/Serializable/resolveClass/consTest/Test.java - test/java/io/Serializable/resolveClass/consTest/run.sh - test/java/io/Serializable/resolveClass/deserializeButton/Test.java - test/java/io/Serializable/resolveClass/deserializeButton/run.sh - test/java/io/Serializable/serialver/classpath/Test.java - test/java/io/Serializable/serialver/classpath/run.sh - test/java/io/Serializable/serialver/nested/Test.java - test/java/io/Serializable/serialver/nested/run.sh - test/java/io/Serializable/subclass/Test.java - test/java/io/Serializable/subclass/run.sh - test/java/io/Serializable/superclassDataLoss/Test.java - test/java/io/Serializable/superclassDataLoss/run.sh - test/java/io/Serializable/unnamedPackageSwitch/Test.java - test/java/io/Serializable/unnamedPackageSwitch/run.sh - test/java/net/Socket/OldSocketImpl.sh - test/java/net/URL/B5086147.sh - test/java/net/URLClassLoader/B5077773.java - test/java/net/URLClassLoader/B5077773.sh - test/java/net/URLClassLoader/closetest/build.sh - test/java/net/URLClassLoader/closetest/build2.sh - test/java/net/URLClassLoader/getresourceasstream/test.sh - test/java/net/URLClassLoader/sealing/checksealed.sh - test/java/net/URLConnection/6212146/test.sh - test/java/net/URLConnection/UNCTest.sh - test/java/nio/Buffer/LimitDirectMemory.sh - test/java/nio/channels/AsynchronousChannelGroup/Attack.java - test/java/nio/channels/AsynchronousChannelGroup/PrivilegedThreadFactory.java - test/java/nio/channels/AsynchronousChannelGroup/run_any_task.sh - test/java/nio/channels/DatagramChannel/NetworkConfiguration.java - test/java/nio/channels/Selector/lots_of_updates.sh - test/java/nio/channels/SocketChannel/Open.sh - test/java/nio/channels/spi/AsynchronousChannelProvider/custom_provider.sh - test/java/nio/channels/spi/SelectorProvider/inheritedChannel/run_tests.sh - test/java/nio/charset/Charset/default.sh - test/java/nio/charset/coders/CheckSJISMappingProp.sh - test/java/nio/charset/spi/Test.java - test/java/nio/charset/spi/basic.sh - test/java/nio/file/Files/delete_on_close.sh - test/java/nio/file/Files/walkFileTree/PrintFileTree.java - test/java/nio/file/Files/walkFileTree/find.sh - test/java/nio/file/Path/MacPathTest.sh - test/java/util/Arrays/ParallelPrefix.java - test/java/util/stream/bootlib/java.base/java/util/SpliteratorOfIntDataBuilder.java - test/java/util/stream/bootlib/java.base/java/util/SpliteratorTestHelper.java - test/java/util/stream/bootlib/java.base/java/util/stream/CollectorOps.java - test/java/util/stream/bootlib/java.base/java/util/stream/DefaultMethodStreams.java - test/java/util/stream/bootlib/java.base/java/util/stream/DoubleStreamTestDataProvider.java - test/java/util/stream/bootlib/java.base/java/util/stream/DoubleStreamTestScenario.java - test/java/util/stream/bootlib/java.base/java/util/stream/FlagDeclaringOp.java - test/java/util/stream/bootlib/java.base/java/util/stream/IntStreamTestDataProvider.java - test/java/util/stream/bootlib/java.base/java/util/stream/IntStreamTestScenario.java - test/java/util/stream/bootlib/java.base/java/util/stream/IntermediateTestOp.java - test/java/util/stream/bootlib/java.base/java/util/stream/LambdaTestHelpers.java - test/java/util/stream/bootlib/java.base/java/util/stream/LambdaTestMode.java - test/java/util/stream/bootlib/java.base/java/util/stream/LoggingTestCase.java - test/java/util/stream/bootlib/java.base/java/util/stream/LongStreamTestDataProvider.java - test/java/util/stream/bootlib/java.base/java/util/stream/LongStreamTestScenario.java - test/java/util/stream/bootlib/java.base/java/util/stream/OpTestCase.java - test/java/util/stream/bootlib/java.base/java/util/stream/StatefulTestOp.java - test/java/util/stream/bootlib/java.base/java/util/stream/StatelessTestOp.java - test/java/util/stream/bootlib/java.base/java/util/stream/StreamOpFlagTestHelper.java - test/java/util/stream/bootlib/java.base/java/util/stream/StreamTestDataProvider.java - test/java/util/stream/bootlib/java.base/java/util/stream/StreamTestScenario.java - test/java/util/stream/bootlib/java.base/java/util/stream/TestData.java - test/java/util/stream/bootlib/java.base/java/util/stream/TestFlagExpectedOp.java - test/java/util/stream/bootlib/java.base/java/util/stream/ThrowableHelper.java - test/java/util/stream/test/org/openjdk/tests/java/util/NullArgsTestCase.java - test/lib/testlibrary/CompilerUtils.java - test/lib/testlibrary/JavaToolUtils.java - test/lib/testlibrary/ModuleInfoMaker.java - test/lib/testlibrary/jdk/testlibrary/FileUtils.java - test/lib/testlibrary/jdk/testlibrary/FilterClassLoader.java - test/lib/testlibrary/jdk/testlibrary/IOUtils.java - test/lib/testlibrary/jdk/testlibrary/JarUtils.java - test/lib/testlibrary/jdk/testlibrary/LockFreeLogManager.java - test/lib/testlibrary/jdk/testlibrary/NetworkConfiguration.java - test/lib/testlibrary/jdk/testlibrary/ParentLastURLClassLoader.java - test/lib/testlibrary/jdk/testlibrary/Platform.java - test/lib/testlibrary/jdk/testlibrary/SerializationUtils.java - test/lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java - test/lib/testlibrary/jdk/testlibrary/management/InputArguments.java - test/lib/testlibrary/jdk/testlibrary/management/ThreadMXBeanTool.java - test/lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/CodeCacheOverflowProcessor.java - test/lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java - test/sun/net/InetAddress/nameservice/dns/cname.sh - test/sun/net/ftp/MarkResetTest.sh - test/sun/net/www/protocol/file/DirPermissionDenied.sh - test/sun/net/www/protocol/jar/B5105410.sh - test/sun/net/www/protocol/jar/copyin.sh - test/sun/net/www/protocol/jar/getcontenttype.sh - test/sun/net/www/protocol/jar/jarbug/run.sh - test/sun/net/www/protocol/jar/jarbug/src/test/RunAllTests.java - test/sun/net/www/protocol/jrt/other_resources.sh - test/tools/jar/multiRelease/data/runtimetest/base/testpackage/Helper.java - test/tools/jar/multiRelease/data/runtimetest/base/testpackage/Main.java - test/tools/jar/multiRelease/data/runtimetest/base/versionResource - test/tools/jar/multiRelease/data/runtimetest/v10/testpackage/Helper.java - test/tools/jar/multiRelease/data/runtimetest/v10/testpackage/Main.java - test/tools/jar/multiRelease/data/runtimetest/v10/versionResource - test/tools/jar/multiRelease/data/runtimetest/v9/testpackage/Helper.java - test/tools/jar/multiRelease/data/runtimetest/v9/testpackage/Main.java - test/tools/jar/multiRelease/data/runtimetest/v9/versionResource Changeset: 1e7eea95eb9c Author: amlu Date: 2017-07-07 12:42 +0800 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/1e7eea95eb9c 8183378: Refactor java/lang/System/MacEncoding/MacJNUEncoding.sh to java Reviewed-by: bchristi, xiaofeya ! test/java/lang/System/MacEncoding/ExpectedEncoding.java + test/java/lang/System/MacEncoding/MacJNUEncoding.java - test/java/lang/System/MacEncoding/MacJNUEncoding.sh Changeset: cac598ef010e Author: mli Date: 2017-07-06 22:40 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/cac598ef010e 8183990: compilation error for test/com/sun/crypto/provider/Cipher/DES/PerformanceTest.java Reviewed-by: weijun ! test/com/sun/crypto/provider/Cipher/DES/PerformanceTest.java Changeset: 3841886ca12e Author: nishjain Date: 2017-07-07 12:19 +0530 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/3841886ca12e 8032842: Locale.filterTags()/lookupTag() methods return lowercased language tags 8175539: Duplicate matching tags returned by Locale.filterTags() for LanguageRange("*") Reviewed-by: naoto Contributed-by: nishit.jain at oracle.com ! src/java.base/share/classes/java/util/Locale.java ! src/java.base/share/classes/sun/util/locale/LocaleMatcher.java ! test/java/util/Locale/Bug7069824.java + test/java/util/Locale/Bug8032842.java Changeset: 7bdb59123fe5 Author: weijun Date: 2017-07-08 14:09 +0800 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/7bdb59123fe5 8183509: keytool should not allow multiple commands Reviewed-by: mullan, vinnie ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/tools/keytool/Resources.java + test/sun/security/tools/keytool/DupCommands.java ! test/sun/security/tools/keytool/WeakAlg.java Changeset: ebc53b7406ce Author: amlu Date: 2017-07-10 14:56 +0800 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/ebc53b7406ce 8183989: Mark java/nio/channels/DatagramChannel/Disconnect.java as intermittently failing Reviewed-by: psandoz ! test/java/nio/channels/DatagramChannel/Disconnect.java Changeset: e723567cdb06 Author: mli Date: 2017-07-11 20:11 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/e723567cdb06 8184165: sun.security.provider.PolicyFile$PolicyEntry.toString() throws MissingResourceException Reviewed-by: weijun ! src/java.base/share/classes/sun/security/util/Resources.java Changeset: e069834e2c51 Author: mli Date: 2017-07-12 01:26 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/e069834e2c51 8184234: sun.security.provider.AuthPolicyFile$PolicyEntry.toString() throws MissingResourceException Reviewed-by: weijun ! src/java.base/share/classes/sun/security/util/AuthResources.java Changeset: 229f964e77f0 Author: jjg Date: 2017-07-12 12:48 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/229f964e77f0 8184208: update class="striped" tables for accessibility Reviewed-by: lancea, bpb ! src/java.base/share/classes/java/io/RandomAccessFile.java ! src/java.base/share/classes/java/io/SerializablePermission.java ! src/java.base/share/classes/java/lang/RuntimePermission.java ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/reflect/ReflectPermission.java ! src/java.base/share/classes/java/net/NetPermission.java ! src/java.base/share/classes/java/nio/channels/AsynchronousChannelGroup.java ! src/java.base/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/java.base/share/classes/java/nio/channels/AsynchronousServerSocketChannel.java ! src/java.base/share/classes/java/nio/channels/AsynchronousSocketChannel.java ! src/java.base/share/classes/java/nio/channels/DatagramChannel.java ! src/java.base/share/classes/java/nio/channels/FileChannel.java ! src/java.base/share/classes/java/nio/channels/ServerSocketChannel.java ! src/java.base/share/classes/java/nio/channels/SocketChannel.java ! src/java.base/share/classes/java/nio/charset/Charset.java ! src/java.base/share/classes/java/nio/file/Files.java ! src/java.base/share/classes/java/nio/file/LinkPermission.java ! src/java.base/share/classes/java/nio/file/attribute/AclFileAttributeView.java ! src/java.base/share/classes/java/nio/file/attribute/BasicFileAttributeView.java ! src/java.base/share/classes/java/nio/file/attribute/DosFileAttributeView.java ! src/java.base/share/classes/java/nio/file/attribute/PosixFileAttributeView.java ! src/java.base/share/classes/java/nio/file/spi/FileSystemProvider.java ! src/java.base/share/classes/java/security/SecurityPermission.java ! src/java.base/share/classes/java/text/DecimalFormat.java ! src/java.base/share/classes/java/text/SimpleDateFormat.java ! src/java.base/share/classes/java/time/format/DateTimeFormatter.java ! src/java.base/share/classes/java/util/Formatter.java ! src/java.base/share/classes/java/util/GregorianCalendar.java ! src/java.base/share/classes/java/util/Locale.java ! src/java.base/share/classes/javax/net/ssl/SSLPermission.java Changeset: 4321d86620d6 Author: jjg Date: 2017-07-12 14:30 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/4321d86620d6 8184304: (sctp) make tables in jdk.sctp module accessible Reviewed-by: alanb ! src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpChannel.java ! src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpMultiChannel.java ! src/jdk.sctp/share/classes/com/sun/nio/sctp/SctpServerChannel.java Changeset: 04ea58db1778 Author: apetcher Date: 2017-07-13 12:24 +0100 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/04ea58db1778 8182999: SunEC throws ProviderException on invalid curves Reviewed-by: vinnie ! make/mapfiles/libsunec/mapfile-vers ! src/java.base/share/classes/sun/security/util/ECUtil.java ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECKeyPairGenerator.java ! src/jdk.crypto.ec/share/native/libsunec/ECC_JNI.cpp + test/sun/security/ec/InvalidCurve.java Changeset: 5eda4aba643a Author: lana Date: 2017-07-13 19:34 +0000 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/5eda4aba643a Added tag jdk-10+15 for changeset e069834e2c51 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 13 22:02:47 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:02:47 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707132202.v6DM2lQZ002789@aojmv0008.oracle.com> Changeset: c7199b91f482 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/c7199b91f482 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:02:48 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:02:48 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707132202.v6DM2mno002872@aojmv0008.oracle.com> Changeset: ea433c84b850 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/ea433c84b850 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:02:46 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:02:46 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707132202.v6DM2k13002719@aojmv0008.oracle.com> Changeset: e75e1a626ff0 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/e75e1a626ff0 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:02:49 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:02:49 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707132202.v6DM2n9N002931@aojmv0008.oracle.com> Changeset: 94c96ae2fbac Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/94c96ae2fbac Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:02:51 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:02:51 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707132202.v6DM2pX1003072@aojmv0008.oracle.com> Changeset: b338eac86fb3 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/b338eac86fb3 Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 13 22:02:53 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:02:53 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707132202.v6DM2rtv003164@aojmv0008.oracle.com> Changeset: 9d974b93fda8 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/9d974b93fda8 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:02:54 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:02:54 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707132202.v6DM2s8S003211@aojmv0008.oracle.com> Changeset: 61c92f4e7872 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/61c92f4e7872 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:02:52 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:02:52 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707132202.v6DM2q0w003153@aojmv0008.oracle.com> Changeset: bed47e73b271 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/bed47e73b271 Automatic merge with default - test/java/lang/System/MacEncoding/MacJNUEncoding.sh From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:23 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:23 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707132203.v6DM3N4j004969@aojmv0008.oracle.com> Changeset: b4a244df79ad Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/b4a244df79ad Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:22 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:22 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707132203.v6DM3MSm004919@aojmv0008.oracle.com> Changeset: 341ade24e9e8 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/341ade24e9e8 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:24 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:24 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707132203.v6DM3O1e005029@aojmv0008.oracle.com> Changeset: 4c41fdcc6ef1 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/4c41fdcc6ef1 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:25 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:25 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707132203.v6DM3PvQ005075@aojmv0008.oracle.com> Changeset: 1058e7e32d4e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/1058e7e32d4e Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:26 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:26 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707132203.v6DM3QiI005160@aojmv0008.oracle.com> Changeset: e63ee1f02d46 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/e63ee1f02d46 Automatic merge with default ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java - test/java/lang/System/MacEncoding/MacJNUEncoding.sh From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:28 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:28 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707132203.v6DM3Sc3005170@aojmv0008.oracle.com> Changeset: 6a621186e907 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/6a621186e907 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:27 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:27 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707132203.v6DM3R6S005165@aojmv0008.oracle.com> Changeset: 657f692588ff Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/657f692588ff Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:29 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:29 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707132203.v6DM3Thl005175@aojmv0008.oracle.com> Changeset: 6accb7221040 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/6accb7221040 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:56 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:56 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707132203.v6DM3u6j006394@aojmv0008.oracle.com> Changeset: 697701dfc47c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/697701dfc47c Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:58 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:58 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707132203.v6DM3wvI006524@aojmv0008.oracle.com> Changeset: 522a3246f19c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/522a3246f19c Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:57 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:57 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707132203.v6DM3wMt006460@aojmv0008.oracle.com> Changeset: 70b4a456eb4f Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/70b4a456eb4f Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:03:59 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:03:59 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707132203.v6DM3xAS006586@aojmv0008.oracle.com> Changeset: d833969e3f8d Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/d833969e3f8d Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:00 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:00 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707132204.v6DM40TH006646@aojmv0008.oracle.com> Changeset: 26287b6ef258 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/26287b6ef258 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:02 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:02 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707132204.v6DM42tZ006655@aojmv0008.oracle.com> Changeset: c41e98d78335 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/c41e98d78335 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:01 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:01 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707132204.v6DM41AR006650@aojmv0008.oracle.com> Changeset: 6b2ebf118a56 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/6b2ebf118a56 Automatic merge with default - test/java/lang/System/MacEncoding/MacJNUEncoding.sh From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:03 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:03 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707132204.v6DM43FT006659@aojmv0008.oracle.com> Changeset: dedfc3c2da6e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/dedfc3c2da6e Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:31 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:31 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707132204.v6DM4V8k007918@aojmv0008.oracle.com> Changeset: 9eb2be91f36e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/9eb2be91f36e Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:31 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:31 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707132204.v6DM4VS5007967@aojmv0008.oracle.com> Changeset: 6ab32d5cd55b Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/6ab32d5cd55b Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:33 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:33 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707132204.v6DM4XXt008075@aojmv0008.oracle.com> Changeset: 5ff38ea16cff Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/5ff38ea16cff Automatic merge with default ! .hgtags ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:32 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:32 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707132204.v6DM4Wk9008033@aojmv0008.oracle.com> Changeset: d8bafbeefb45 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/d8bafbeefb45 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:35 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:35 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707132204.v6DM4Zdm008166@aojmv0008.oracle.com> Changeset: bd5c8f692fea Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/bd5c8f692fea Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:34 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:34 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707132204.v6DM4Ziw008162@aojmv0008.oracle.com> Changeset: ffba46020c9e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/ffba46020c9e Automatic merge with default - test/java/lang/System/MacEncoding/MacJNUEncoding.sh From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:37 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:37 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707132204.v6DM4bVr008174@aojmv0008.oracle.com> Changeset: e255a4135547 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/e255a4135547 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:04:36 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:04:36 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707132204.v6DM4aDC008170@aojmv0008.oracle.com> Changeset: a44b5fbae8fe Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/a44b5fbae8fe Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:05 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:05 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707132205.v6DM55qG009387@aojmv0008.oracle.com> Changeset: fc860fb32c10 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/fc860fb32c10 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:06 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:06 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707132205.v6DM57R9009502@aojmv0008.oracle.com> Changeset: 6b4163773ca8 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/6b4163773ca8 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:06 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:06 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707132205.v6DM5632009439@aojmv0008.oracle.com> Changeset: 7303f8262e80 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/7303f8262e80 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:08 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:08 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707132205.v6DM58B9009574@aojmv0008.oracle.com> Changeset: 3c92fc8a0ff1 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/3c92fc8a0ff1 Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:08 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:08 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707132205.v6DM59nq009630@aojmv0008.oracle.com> Changeset: 544e5650f254 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/544e5650f254 Automatic merge with default - test/java/lang/System/MacEncoding/MacJNUEncoding.sh From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:09 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:09 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707132205.v6DM598w009640@aojmv0008.oracle.com> Changeset: 20b5b9f8b656 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/20b5b9f8b656 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:11 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:11 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707132205.v6DM5BIf009648@aojmv0008.oracle.com> Changeset: 0f3542d634fc Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/0f3542d634fc Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:10 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:10 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707132205.v6DM5A5T009644@aojmv0008.oracle.com> Changeset: 4d668505de7c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/4d668505de7c Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:39 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:39 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707132205.v6DM5dDi010875@aojmv0008.oracle.com> Changeset: 9a647f65cdeb Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/9a647f65cdeb Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:40 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:40 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707132205.v6DM5e79010940@aojmv0008.oracle.com> Changeset: f78f7c87bd87 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/f78f7c87bd87 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:41 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:41 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707132205.v6DM5fG7010994@aojmv0008.oracle.com> Changeset: c993b66d8729 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/c993b66d8729 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:42 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:42 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707132205.v6DM5hDb011108@aojmv0008.oracle.com> Changeset: 36a2d238c995 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/36a2d238c995 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:42 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:42 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707132205.v6DM5ghs011073@aojmv0008.oracle.com> Changeset: 579234f08bfe Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/579234f08bfe Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:44 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:44 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707132205.v6DM5isA011132@aojmv0008.oracle.com> Changeset: 606ea893955e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/606ea893955e Automatic merge with default - test/java/lang/System/MacEncoding/MacJNUEncoding.sh From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:45 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:45 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707132205.v6DM5j6E011140@aojmv0008.oracle.com> Changeset: 22470bbcd66f Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/22470bbcd66f Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:05:45 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:05:45 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707132205.v6DM5jDX011136@aojmv0008.oracle.com> Changeset: a822bae9c291 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/a822bae9c291 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:14 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:14 +0000 Subject: hg: amber/amber/corba: Automatic merge with constant-folding Message-ID: <201707132206.v6DM6Euh012556@aojmv0008.oracle.com> Changeset: a9d3205413a3 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/a9d3205413a3 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:13 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:13 +0000 Subject: hg: amber/amber: Automatic merge with constant-folding Message-ID: <201707132206.v6DM6D2w012492@aojmv0008.oracle.com> Changeset: 176cd9235b21 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/176cd9235b21 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:16 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:16 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with constant-folding Message-ID: <201707132206.v6DM6GWF012684@aojmv0008.oracle.com> Changeset: 9ceda87e8df1 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/9ceda87e8df1 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:15 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:15 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with constant-folding Message-ID: <201707132206.v6DM6FGg012622@aojmv0008.oracle.com> Changeset: 3f813ca3ff44 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/3f813ca3ff44 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:18 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:18 +0000 Subject: hg: amber/amber/jdk: Automatic merge with constant-folding Message-ID: <201707132206.v6DM6Iw9012751@aojmv0008.oracle.com> Changeset: 34a19af95a64 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/34a19af95a64 Automatic merge with constant-folding ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java - test/java/lang/System/MacEncoding/MacJNUEncoding.sh From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:17 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:17 +0000 Subject: hg: amber/amber/langtools: Automatic merge with constant-folding Message-ID: <201707132206.v6DM6H7A012746@aojmv0008.oracle.com> Changeset: f37392dce028 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/f37392dce028 Automatic merge with constant-folding ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:18 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:18 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with constant-folding Message-ID: <201707132206.v6DM6Ili012754@aojmv0008.oracle.com> Changeset: feb56c69c0d6 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/feb56c69c0d6 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:19 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:19 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with constant-folding Message-ID: <201707132206.v6DM6JFu012761@aojmv0008.oracle.com> Changeset: 6289ba6e5c48 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/6289ba6e5c48 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:49 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:49 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with condy Message-ID: <201707132206.v6DM6nZh014103@aojmv0008.oracle.com> Changeset: 57e78ad621ac Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/57e78ad621ac Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:47 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:47 +0000 Subject: hg: amber/amber: Automatic merge with condy Message-ID: <201707132206.v6DM6lC7013968@aojmv0008.oracle.com> Changeset: 8656d16e1a77 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/8656d16e1a77 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:48 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:48 +0000 Subject: hg: amber/amber/corba: Automatic merge with condy Message-ID: <201707132206.v6DM6mJj014034@aojmv0008.oracle.com> Changeset: fa9044fc9e02 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/fa9044fc9e02 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:50 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:50 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with condy Message-ID: <201707132206.v6DM6ogv014191@aojmv0008.oracle.com> Changeset: 4ad10737684c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/4ad10737684c Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:51 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:51 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with condy Message-ID: <201707132206.v6DM6pxY014267@aojmv0008.oracle.com> Changeset: 90d9d2ab6812 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/90d9d2ab6812 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:52 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:52 +0000 Subject: hg: amber/amber/langtools: Automatic merge with condy Message-ID: <201707132206.v6DM6qYm014322@aojmv0008.oracle.com> Changeset: 47bd6e0c39b9 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/47bd6e0c39b9 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:53 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:53 +0000 Subject: hg: amber/amber/jdk: Automatic merge with condy Message-ID: <201707132206.v6DM6rEo014333@aojmv0008.oracle.com> Changeset: 83eed0e9e736 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/83eed0e9e736 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 13 22:06:54 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 13 Jul 2017 22:06:54 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with condy Message-ID: <201707132206.v6DM6sbg014395@aojmv0008.oracle.com> Changeset: 11677f44ffa9 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-14 00:04 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/11677f44ffa9 Automatic merge with condy From amaembo at gmail.com Fri Jul 14 05:15:48 2017 From: amaembo at gmail.com (Tagir Valeev) Date: Fri, 14 Jul 2017 12:15:48 +0700 Subject: [lvti] Non-denotable types Message-ID: Hello! When thinking about local variable type inference, I noticed that lambda parameter type inference in Java 8 is sometimes similar. For example, we can declare the following method: static void var(T t, Consumer cons) { cons.accept(t); } Then Java 8 code like this: var(theValue, theVariable -> { codeBlock; }); Is equivalent to LVTI code like this: var theVariable = theValue; codeBlock; Apparently this does not work for non-denotable types. I checked the non-denotable types section in [1]: seems that lambda parameter inference infers to non-denotable type as it described in this section, which already produces "surprising" results: void test(List l1, List l2) { var(l1, l3 -> { l3 = l2; // error l3.add(l3.get(0)); // error }); } Shouldn't we expect a consistency here? There's already a kind of variables in Java (lambda parameters) for which non-denotable types are inferred. It looks strange to me that two kinds of variable inference work in different manner. With best regards, Tagir Valeev [1] http://openjdk.java.net/jeps/286 From maurizio.cimadamore at oracle.com Fri Jul 14 10:03:18 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Fri, 14 Jul 2017 11:03:18 +0100 Subject: [lvti] Non-denotable types In-Reply-To: References: Message-ID: <46234dcc-19ff-c68a-299f-a6c9d2fc7b9b@oracle.com> On 14/07/17 06:15, Tagir Valeev wrote: > Hello! > > When thinking about local variable type inference, I noticed that lambda > parameter type inference in Java 8 is sometimes similar. For example, we > can declare the following method: > > static void var(T t, Consumer cons) { > cons.accept(t); > } > > Then Java 8 code like this: > > var(theValue, theVariable -> { > codeBlock; > }); > > Is equivalent to LVTI code like this: > > var theVariable = theValue; > codeBlock; Yep - this is how lambda implicit parameters work in JDK 8/9. > > Apparently this does not work for non-denotable types. I checked the > non-denotable types section in [1]: seems that lambda parameter inference > infers to non-denotable type as it described in this section, which already > produces "surprising" results: > > void test(List l1, List l2) { > var(l1, l3 -> { > l3 = l2; // error > l3.add(l3.get(0)); // error > }); > } > > Shouldn't we expect a consistency here? There's already a kind of variables > in Java (lambda parameters) for which non-denotable types are inferred. It > looks strange to me that two kinds of variable inference work in different > manner. We had many discussions on this very topic. In general we agree that it's bad having two different inference schemes for doing similar things. That said, there are distinctions to be made, as implicit lambda parameter inference is _not_ an inference process that can be applied in isolation, by adjusting each parameter. The way this works is that you infer a _target_ (not a parameter type) and then you derive the parameter type from the target, under the constraint that the parameter type must be whatever is needed to make the lambda 'override equivalent' with the functional descriptor induced by the target. In LVTI the inference process is more straightforward: you start from an expression type (the initializer) and you derive a type from it (the type for the 'var'), which will need to be some upper bound of the type you started with. Being consistent here could mean two things: either allow non denotable types in 'var', or disallow non-denotable types in implicit lambdas. The first path seems 'easier' - although it might expose a 'feature' that many people would probably not even have realized it's there. The latter would be safer from a language/type-system design perspective, but it comes with a source compatibility price. We are currently discussing this and running experiments to see which approach would work best - so expect to hear something on this topic soon. Cheers Maurizio > > With best regards, > Tagir Valeev > > [1] http://openjdk.java.net/jeps/286 From vicente.romero at oracle.com Fri Jul 14 14:38:08 2017 From: vicente.romero at oracle.com (Vicente Romero) Date: Fri, 14 Jul 2017 10:38:08 -0400 Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: References: <0562c35c-c38b-a65a-03c9-bcbcf5e814d3@oracle.com> Message-ID: On 07/10/2017 06:47 AM, Tagir Valeev wrote: > Hello! > > I see that A was selected and currenty I support it. Just a short opinion > against C for the record. There are many cases when method does not > override another one, but has to declare some parameters. Examples: > - public static void main: using main(String[] _) would indicate that > command line parameters are not used. > - name parameter in BootstrapMethodFactory: often it's unnecessary > - some annotation-based APIs when method annotation directs a framework to > call this method reflectively with specific parameters (but some of them > are not used actually) > - a lambda with unused parameter which was converted to a method for > convenient use as a method reference > > So covering traditional inheritance, but not covering these cases looks > arbitrary indeed. right, good point and thanks for the feedback. We preferred to move to a conservative mode and keep this feature small which was the first intention. > > With best regards, > Tagir Valeev. Vicente > > On Sat, Jul 1, 2017 at 12:38 AM, Brian Goetz wrote: > >> So, a fair question is whether _ should be supported for methods at all, >> because (in many cases) method parameters are both declaration and >> implementation. This feature started out for lambdas (whose parameters are >> pure implementation), and then got extended to catch formals (also pure >> implementation) and method parameters (not pure implementation.) And once >> we bring in methods, it raises tooling questions like "what about Javadoc." >> So maybe the last step was the problem. >> >> Here's a menu of defensible options here: >> >> A. Don't allow _ for method or constructor parameters. >> >> B. Only allow _ for method parameters in *anonymous* classes. This has the >> advantage that it makes it easier to freely refactor lambdas to/from anon >> classes. >> >> C. The option I proposed the other day -- only allow _ as a method >> parameter name for concrete class methods that are known to be an @Override >> of some other method. This excludes all interface and abstract methods, >> constructors, and "initial declarations" of methods in base classes. >> >> D. Allow it in all methods. >> >> >> Now that this has been pointed out, I'm pretty down on D. C is >> defensible, but likely will feel arbitrary. B does has a nice symmetry to >> it, but it means it drags tooling support (Javadoc) into the feature. And >> A avoids the problem entirely. (Though, like with LVTI, people will >> inevitably ask "but what about private methods? And they'd get the same >> answer, regarding source compatibility of modifier changes.) >> >> Leaning towards A.... >> >> >> On 6/25/2017 6:51 AM, Tagir Valeev wrote: >> >>> Hello! >>> >>> Currently in lambda-leftovers underscore is allowed as a parameter name >>> for >>> abstract methods. This looks dubious as normally underscore means that >>> parameter is not used in the corresponding method/lambda/catch body, but >>> there's no actual body and no parameter is actually used anyways (but >>> could >>> be used in abstract method implementations). I think, allowing underscores >>> for interface methods may encorage bad practices of defining interfaces >>> without readable parameter names: >>> >>> interface X { >>> void doSomething(int _, long _, String _); >>> } >>> >>> Should not this be disabled? >>> >>> It's even worse for native methods, because underscore assumes that >>> parameter is not used, but it does not limit the corresponding native >>> implementation from using it. >>> >>> With best regards, >>> Tagir Valeev. >>> >> From forax at univ-mlv.fr Sat Jul 15 10:19:43 2017 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 15 Jul 2017 10:19:43 +0000 Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: References: <0562c35c-c38b-a65a-03c9-bcbcf5e814d3@oracle.com> Message-ID: <181B87FB-F37F-4CE7-88BC-D307D354EC1F@univ-mlv.fr> I am not confortable with any solution but D, lambdas are just anonymous methods. With lambda leftover, we are bridging the gap between methods and lambdas by saying that lambdas have the same scope rules as methods, making lambdas less specific in term of feature. So restricting underscore to lambda only goes is the wrong direction, because it artificially re-create a gap between methods and lambdas in term of feature. regards, R?mi On July 14, 2017 4:38:08 PM GMT+02:00, Vicente Romero wrote: > > >On 07/10/2017 06:47 AM, Tagir Valeev wrote: >> Hello! >> >> I see that A was selected and currenty I support it. Just a short >opinion >> against C for the record. There are many cases when method does not >> override another one, but has to declare some parameters. Examples: >> - public static void main: using main(String[] _) would indicate that >> command line parameters are not used. >> - name parameter in BootstrapMethodFactory: often it's unnecessary >> - some annotation-based APIs when method annotation directs a >framework to >> call this method reflectively with specific parameters (but some of >them >> are not used actually) >> - a lambda with unused parameter which was converted to a method for >> convenient use as a method reference >> >> So covering traditional inheritance, but not covering these cases >looks >> arbitrary indeed. > >right, good point and thanks for the feedback. We preferred to move to >a >conservative mode and keep this feature small which was the first >intention. > >> >> With best regards, >> Tagir Valeev. > >Vicente > >> >> On Sat, Jul 1, 2017 at 12:38 AM, Brian Goetz >wrote: >> >>> So, a fair question is whether _ should be supported for methods at >all, >>> because (in many cases) method parameters are both declaration and >>> implementation. This feature started out for lambdas (whose >parameters are >>> pure implementation), and then got extended to catch formals (also >pure >>> implementation) and method parameters (not pure implementation.) >And once >>> we bring in methods, it raises tooling questions like "what about >Javadoc." >>> So maybe the last step was the problem. >>> >>> Here's a menu of defensible options here: >>> >>> A. Don't allow _ for method or constructor parameters. >>> >>> B. Only allow _ for method parameters in *anonymous* classes. This >has the >>> advantage that it makes it easier to freely refactor lambdas to/from >anon >>> classes. >>> >>> C. The option I proposed the other day -- only allow _ as a method >>> parameter name for concrete class methods that are known to be an >@Override >>> of some other method. This excludes all interface and abstract >methods, >>> constructors, and "initial declarations" of methods in base classes. >>> >>> D. Allow it in all methods. >>> >>> >>> Now that this has been pointed out, I'm pretty down on D. C is >>> defensible, but likely will feel arbitrary. B does has a nice >symmetry to >>> it, but it means it drags tooling support (Javadoc) into the >feature. And >>> A avoids the problem entirely. (Though, like with LVTI, people will >>> inevitably ask "but what about private methods? And they'd get the >same >>> answer, regarding source compatibility of modifier changes.) >>> >>> Leaning towards A.... >>> >>> >>> On 6/25/2017 6:51 AM, Tagir Valeev wrote: >>> >>>> Hello! >>>> >>>> Currently in lambda-leftovers underscore is allowed as a parameter >name >>>> for >>>> abstract methods. This looks dubious as normally underscore means >that >>>> parameter is not used in the corresponding method/lambda/catch >body, but >>>> there's no actual body and no parameter is actually used anyways >(but >>>> could >>>> be used in abstract method implementations). I think, allowing >underscores >>>> for interface methods may encorage bad practices of defining >interfaces >>>> without readable parameter names: >>>> >>>> interface X { >>>> void doSomething(int _, long _, String _); >>>> } >>>> >>>> Should not this be disabled? >>>> >>>> It's even worse for native methods, because underscore assumes that >>>> parameter is not used, but it does not limit the corresponding >native >>>> implementation from using it. >>>> >>>> With best regards, >>>> Tagir Valeev. >>>> >>> -- Sent from my Android device with K-9 Mail. Please excuse my brevity. From brian.goetz at oracle.com Sat Jul 15 17:11:09 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Sat, 15 Jul 2017 13:11:09 -0400 Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: <181B87FB-F37F-4CE7-88BC-D307D354EC1F@univ-mlv.fr> References: <0562c35c-c38b-a65a-03c9-bcbcf5e814d3@oracle.com> <181B87FB-F37F-4CE7-88BC-D307D354EC1F@univ-mlv.fr> Message-ID: <8CFA0CC5-52CA-4CA0-A73C-8453EBBE1550@oracle.com> So you are proposing E: don?t allow it for lambdas either? > On Jul 15, 2017, at 6:19 AM, Remi Forax wrote: > > I am not confortable with any solution but D, lambdas are just anonymous methods. > > With lambda leftover, we are bridging the gap between methods and lambdas by saying that lambdas have the same scope rules as methods, making lambdas less specific in term of feature. > > So restricting underscore to lambda only goes is the wrong direction, because it artificially re-create a gap between methods and lambdas in term of feature. > > regards, > R?mi > > > On July 14, 2017 4:38:08 PM GMT+02:00, Vicente Romero wrote: > > > On 07/10/2017 06:47 AM, Tagir Valeev wrote: > Hello! > > I see that A was selected and currenty I support it. Just a short opinion > against C for the record. There are many cases when method does not > override another one, but has to declare some parameters. Examples: > - public static void main: using main(String[] _) would indicate that > command line parameters are not used. > - name parameter in BootstrapMethodFactory: often it's unnecessary > - some annotation-based APIs when method annotation directs a framework to > call this method reflectively with specific parameters (but some of them > are not used actually) > - a lambda with unused parameter which was converted to a method for > convenient use as a method reference > > So covering traditional inheritance, but not covering these cases looks > arbitrary indeed. > > right, good point and thanks for the feedback. We preferred to move to a > conservative mode and keep this feature small which was the first intention. > > > With best regards, > Tagir Valeev. > > Vicente > > > On Sat, Jul 1, 2017 at 12:38 AM, Brian Goetz wrote: > > So, a fair question is whether _ should be supported for methods at all, > because (in many cases) method parameters are both declaration and > implementation. This feature started out for lambdas (whose parameters are > pure implementation), and then got extended to catch formals (also pure > implementation) and method parameters (not pure implementation.) And once > we bring in methods, it raises tooling questions like "what about Javadoc." > So maybe the last step was the problem. > > Here's a menu of defensible options here: > > A. Don't allow _ for method or constructor parameters. > > B. Only allow _ for method parameters in *anonymous* classes. This has the > advantage that it makes it easier to freely refactor lambdas to/from anon > classes. > > C. The option I proposed the other day -- only allow _ as a method > parameter name for concrete class methods that are known to be an @Override > of some other method. This excludes all interface and abstract methods, > constructors, and "initial declarations" of methods in base classes. > > D. Allow it in all methods. > > > Now that this has been pointed out, I'm pretty down on D. C is > defensible, but likely will feel arbitrary. B does has a nice symmetry to > it, but it means it drags tooling support (Javadoc) into the feature. And > A avoids the problem entirely. (Though, like with LVTI, people will > inevitably ask "but what about private methods? And they'd get the same > answer, regarding source compatibility of modifier changes.) > > Leaning towards A.... > > > On 6/25/2017 6:51 AM, Tagir Valeev wrote: > > Hello! > > Currently in lambda-leftovers underscore is allowed as a parameter name > for > abstract methods. This looks dubious as normally underscore means that > parameter is not used in the corresponding method/lambda/catch body, but > there's no actual body and no parameter is actually used anyways (but > could > be used in abstract method implementations). I think, allowing underscores > for interface methods may encorage bad practices of defining interfaces > without readable parameter names: > > interface X { > void doSomething(int _, long _, String _); > } > > Should not this be disabled? > > It's even worse for native methods, because underscore assumes that > parameter is not used, but it does not limit the corresponding native > implementation from using it. > > With best regards, > Tagir Valeev. > > > > > -- > Sent from my Android device with K-9 Mail. Please excuse my brevity. From forax at univ-mlv.fr Sat Jul 15 17:21:53 2017 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Sat, 15 Jul 2017 19:21:53 +0200 (CEST) Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: <8CFA0CC5-52CA-4CA0-A73C-8453EBBE1550@oracle.com> References: <0562c35c-c38b-a65a-03c9-bcbcf5e814d3@oracle.com> <181B87FB-F37F-4CE7-88BC-D307D354EC1F@univ-mlv.fr> <8CFA0CC5-52CA-4CA0-A73C-8453EBBE1550@oracle.com> Message-ID: <643112166.1463187.1500139313841.JavaMail.zimbra@u-pem.fr> > De: "Brian Goetz" > ?: "Remi Forax" > Cc: amber-dev at openjdk.java.net, "Vicente Romero" , > "Tagir Valeev" > Envoy?: Samedi 15 Juillet 2017 19:11:09 > Objet: Re: [lambda-leftovers] Underscore parameter for abstract/native methods > So you are proposing E: don?t allow it for lambdas either? no, D, allow it for lambdas and methods, so i will be able to refactor a lambda to an inner class or vice-versa without much trouble. R?mi >> On Jul 15, 2017, at 6:19 AM, Remi Forax < [ mailto:forax at univ-mlv.fr | >> forax at univ-mlv.fr ] > wrote: >> I am not confortable with any solution but D, lambdas are just anonymous >> methods. >> With lambda leftover, we are bridging the gap between methods and lambdas by >> saying that lambdas have the same scope rules as methods, making lambdas less >> specific in term of feature. >> So restricting underscore to lambda only goes is the wrong direction, because it >> artificially re-create a gap between methods and lambdas in term of feature. >> regards, >> R?mi >> On July 14, 2017 4:38:08 PM GMT+02:00, Vicente Romero < [ >> mailto:vicente.romero at oracle.com | vicente.romero at oracle.com ] > wrote: >>> On 07/10/2017 06:47 AM, Tagir Valeev wrote: >>>> Hello! >>>> I see that A was selected and currenty I support it. Just a short opinion >>>> against C for the record. There are many cases when method does not >>>> override another one, but has to declare some parameters. Examples: >>>> - public static void main: using main(String[] _) would indicate that >>>> command line parameters are not used. >>>> - name parameter in BootstrapMethodFactory: often it's unnecessary >>>> - some annotation-based APIs when method annotation directs a framework to >>>> call this method reflectively with specific parameters (but some of them >>>> are not used actually) >>>> - a lambda with unused parameter which was converted to a method for >>>> convenient use as a method reference >>>> So covering traditional inheritance, but not covering these cases looks >>>> arbitrary indeed. >>> right, good point and thanks for the feedback. We preferred to move to a >>> conservative mode and keep this feature small which was the first intention. >>>> With best regards, >>>> Tagir Valeev. >>> Vicente >>>> On Sat, Jul 1, 2017 at 12:38 AM, Brian Goetz < [ mailto:brian.goetz at oracle.com | >>>> brian.goetz at oracle.com ] > wrote: >>>>> So, a fair question is whether _ should be supported for methods at all, >>>>> because (in many cases) method parameters are both declaration and >>>>> implementation. This feature started out for lambdas (whose parameters are >>>>> pure implementation), and then got extended to catch formals (also pure >>>>> implementation) and method parameters (not pure implementation.) And once >>>>> we bring in methods, it raises tooling questions like "what about Javadoc." >>>>> So maybe the last step was the problem. >>>>> Here's a menu of defensible options here: >>>>> A. Don't allow _ for method or constructor parameters. >>>>> B. Only allow _ for method parameters in *anonymous* classes. This has the >>>>> advantage that it makes it easier to freely refactor lambdas to/from anon >>>>> classes. >>>>> C. The option I proposed the other day -- only allow _ as a method >>>>> parameter name for concrete class methods that are known to be an @Override >>>>> of some other method. This excludes all interface and abstract methods, >>>>> constructors, and "initial declarations" of methods in base classes. >>>>> D. Allow it in all methods. >>>>> Now that this has been pointed out, I'm pretty down on D. C is >>>>> defensible, but likely will feel arbitrary. B does has a nice symmetry to >>>>> it, but it means it drags tooling support (Javadoc) into the feature. And >>>>> A avoids the problem entirely. (Though, like with LVTI, people will >>>>> inevitably ask "but what about private methods? And they'd get the same >>>>> answer, regarding source compatibility of modifier changes.) >>>>> Leaning towards A.... >>>>> On 6/25/2017 6:51 AM, Tagir Valeev wrote: >>>>>> Hello! >>>>>> Currently in lambda-leftovers underscore is allowed as a parameter name >>>>>> for >>>>>> abstract methods. This looks dubious as normally underscore means that >>>>>> parameter is not used in the corresponding method/lambda/catch body, but >>>>>> there's no actual body and no parameter is actually used anyways (but >>>>>> could >>>>>> be used in abstract method implementations). I think, allowing underscores >>>>>> for interface methods may encorage bad practices of defining interfaces >>>>>> without readable parameter names: >>>>>> interface X { >>>>>> void doSomething(int _, long _, String _); >>>>>> } >>>>>> Should not this be disabled? >>>>>> It's even worse for native methods, because underscore assumes that >>>>>> parameter is not used, but it does not limit the corresponding native >>>>>> implementation from using it. >>>>>> With best regards, >>>>>> Tagir Valeev. >> -- >> Sent from my Android device with K-9 Mail. Please excuse my brevity. From maurizio.cimadamore at oracle.com Tue Jul 18 11:17:32 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 18 Jul 2017 12:17:32 +0100 Subject: CFV: New Amber Committer: Lois Foltan Message-ID: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> I hereby nominate Lois Foltan (lfoltan) to Amber Committer. Lois is a member of the Hotspot Runtime team who's looking to join Project Amber (in the context of the cool constant dynamic feature [3]). A list of most of her OpenJDK contributions is available at [4]. Votes are due by August 01, 2017. Only current Amber Committers [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thank you, Maurizio Cimadamore [1]http://openjdk.java.net/census [2]http://openjdk.java.net/projects/#committer-vote [3]http://openjdk.java.net/jeps/8177279 [4]http://hg.openjdk.java.net/jdk10/jdk10/hotspot/search/?rev=author(lfoltan)&revcount=22 From maurizio.cimadamore at oracle.com Tue Jul 18 11:55:50 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 18 Jul 2017 12:55:50 +0100 Subject: CFV: New Amber Committer: Jan Lahoda Message-ID: I hereby nominate Jan Lahoda (jlahoda) to Amber Committer. Jan is a seasoned member of the langtools team who's looking to join Project Amber and help out with the pattern match implementation [3]. A list of most of his OpenJDK contributions is available at [4]. Votes are due by August 01, 2017. Only current Amber Committers [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thank you, Maurizio Cimadamore [1]http://openjdk.java.net/census [2]http://openjdk.java.net/projects/#committer-vote [3]http://openjdk.java.net/jeps/305 [4]http://hg.openjdk.java.net/jdk10/jdk10/langtools/search/?rev=author(jlahoda)&revcount=22 From maurizio.cimadamore at oracle.com Tue Jul 18 11:56:16 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 18 Jul 2017 12:56:16 +0100 Subject: CFV: New Amber Committer: Srikanth Adayapalam Message-ID: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> I hereby nominate Srikanth Adayapalam (sadayapalam) to Amber Committer. Srikanth is a member of the langtools team who's looking to join Project Amber and help out with the pattern match implementation [3]. A list of most of his OpenJDK contributions is available at [4]. Votes are due by August 01, 2017. Only current Amber Committers [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thank you, Maurizio Cimadamore [1]http://openjdk.java.net/census [2]http://openjdk.java.net/projects/#committer-vote [3]http://openjdk.java.net/jeps/305 [4]http://hg.openjdk.java.net/jdk10/jdk10/langtools/search/?rev=author(sadayapalam)&revcount=22 From brian.goetz at oracle.com Tue Jul 18 12:40:37 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 18 Jul 2017 08:40:37 -0400 Subject: CFV: New Amber Committer: Jan Lahoda In-Reply-To: References: Message-ID: Vote: yes! Sent from my iPad > On Jul 18, 2017, at 7:55 AM, Maurizio Cimadamore wrote: > > I hereby nominate Jan Lahoda (jlahoda) to Amber Committer. > > Jan is a seasoned member of the langtools team who's looking to join Project Amber and help out with the pattern match implementation [3]. A list of most of his OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/305 > [4]http://hg.openjdk.java.net/jdk10/jdk10/langtools/search/?rev=author(jlahoda)&revcount=22 > > > From brian.goetz at oracle.com Tue Jul 18 12:40:52 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 18 Jul 2017 08:40:52 -0400 Subject: CFV: New Amber Committer: Srikanth Adayapalam In-Reply-To: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> References: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> Message-ID: Vote: yes! Sent from my iPad > On Jul 18, 2017, at 7:56 AM, Maurizio Cimadamore wrote: > > I hereby nominate Srikanth Adayapalam (sadayapalam) to Amber Committer. > > Srikanth is a member of the langtools team who's looking to join Project Amber and help out with the pattern match implementation [3]. A list of most of his OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/305 > [4]http://hg.openjdk.java.net/jdk10/jdk10/langtools/search/?rev=author(sadayapalam)&revcount=22 > > From brian.goetz at oracle.com Tue Jul 18 12:41:06 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 18 Jul 2017 08:41:06 -0400 Subject: CFV: New Amber Committer: Lois Foltan In-Reply-To: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> References: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> Message-ID: Vote: yes! Sent from my iPad > On Jul 18, 2017, at 7:17 AM, Maurizio Cimadamore wrote: > > I hereby nominate Lois Foltan (lfoltan) to Amber Committer. > > Lois is a member of the Hotspot Runtime team who's looking to join Project Amber (in the context of the cool constant dynamic feature [3]). A list of most of her OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/8177279 > [4]http://hg.openjdk.java.net/jdk10/jdk10/hotspot/search/?rev=author(lfoltan)&revcount=22 > > > From gavin.bierman at oracle.com Tue Jul 18 12:47:01 2017 From: gavin.bierman at oracle.com (Gavin Bierman) Date: Tue, 18 Jul 2017 13:47:01 +0100 Subject: CFV: New Amber Committer: Jan Lahoda In-Reply-To: References: Message-ID: <703F4329-0A75-424C-8760-36248FD79B4E@oracle.com> Vote: yes > On 18 Jul 2017, at 12:55, Maurizio Cimadamore wrote: > > I hereby nominate Jan Lahoda (jlahoda) to Amber Committer. > > Jan is a seasoned member of the langtools team who's looking to join Project Amber and help out with the pattern match implementation [3]. A list of most of his OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/305 > [4]http://hg.openjdk.java.net/jdk10/jdk10/langtools/search/?rev=author(jlahoda)&revcount=22 > > > From gavin.bierman at oracle.com Tue Jul 18 12:47:15 2017 From: gavin.bierman at oracle.com (Gavin Bierman) Date: Tue, 18 Jul 2017 13:47:15 +0100 Subject: CFV: New Amber Committer: Srikanth Adayapalam In-Reply-To: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> References: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> Message-ID: Vote: yes > On 18 Jul 2017, at 12:56, Maurizio Cimadamore wrote: > > I hereby nominate Srikanth Adayapalam (sadayapalam) to Amber Committer. > > Srikanth is a member of the langtools team who's looking to join Project Amber and help out with the pattern match implementation [3]. A list of most of his OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/305 > [4]http://hg.openjdk.java.net/jdk10/jdk10/langtools/search/?rev=author(sadayapalam)&revcount=22 > > From gavin.bierman at oracle.com Tue Jul 18 12:47:39 2017 From: gavin.bierman at oracle.com (Gavin Bierman) Date: Tue, 18 Jul 2017 13:47:39 +0100 Subject: CFV: New Amber Committer: Lois Foltan In-Reply-To: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> References: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> Message-ID: <69251D1E-50E0-40A7-B40C-24C20A38531B@oracle.com> Vote: yes > On 18 Jul 2017, at 12:17, Maurizio Cimadamore wrote: > > I hereby nominate Lois Foltan (lfoltan) to Amber Committer. > > Lois is a member of the Hotspot Runtime team who's looking to join Project Amber (in the context of the cool constant dynamic feature [3]). A list of most of her OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/8177279 > [4]http://hg.openjdk.java.net/jdk10/jdk10/hotspot/search/?rev=author(lfoltan)&revcount=22 > > > From vicente.romero at oracle.com Tue Jul 18 14:07:07 2017 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 18 Jul 2017 10:07:07 -0400 Subject: CFV: New Amber Committer: Lois Foltan In-Reply-To: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> References: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> Message-ID: <6aa01237-8359-84b5-7731-2a61e2e6ce37@oracle.com> vote: yes Vicente On 07/18/2017 07:17 AM, Maurizio Cimadamore wrote: > I hereby nominate Lois Foltan (lfoltan) to Amber Committer. > > Lois is a member of the Hotspot Runtime team who's looking to join > Project Amber (in the context of the cool constant dynamic feature > [3]). A list of most of her OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/8177279 > [4]http://hg.openjdk.java.net/jdk10/jdk10/hotspot/search/?rev=author(lfoltan)&revcount=22 > > > > From vicente.romero at oracle.com Tue Jul 18 14:07:23 2017 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 18 Jul 2017 10:07:23 -0400 Subject: CFV: New Amber Committer: Jan Lahoda In-Reply-To: References: Message-ID: vote: yes Vicente On 07/18/2017 07:55 AM, Maurizio Cimadamore wrote: > I hereby nominate Jan Lahoda (jlahoda) to Amber Committer. > > Jan is a seasoned member of the langtools team who's looking to join > Project Amber and help out with the pattern match implementation [3]. > A list of most of his OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/305 > [4]http://hg.openjdk.java.net/jdk10/jdk10/langtools/search/?rev=author(jlahoda)&revcount=22 > > > > From vicente.romero at oracle.com Tue Jul 18 14:07:39 2017 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 18 Jul 2017 10:07:39 -0400 Subject: CFV: New Amber Committer: Srikanth Adayapalam In-Reply-To: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> References: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> Message-ID: <015af0ae-0702-627f-9a4f-c7f926e23aaf@oracle.com> vote: yes Vicente On 07/18/2017 07:56 AM, Maurizio Cimadamore wrote: > I hereby nominate Srikanth Adayapalam (sadayapalam) to Amber Committer. > > Srikanth is a member of the langtools team who's looking to join > Project Amber and help out with the pattern match implementation [3]. > A list of most of his OpenJDK contributions is available at [4]. > > Votes are due by August 01, 2017. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Maurizio Cimadamore > > [1]http://openjdk.java.net/census > [2]http://openjdk.java.net/projects/#committer-vote > [3]http://openjdk.java.net/jeps/305 > [4]http://hg.openjdk.java.net/jdk10/jdk10/langtools/search/?rev=author(sadayapalam)&revcount=22 > > > From paul.sandoz at oracle.com Tue Jul 18 17:41:25 2017 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Tue, 18 Jul 2017 10:41:25 -0700 Subject: CFV: New Amber Committer: Lois Foltan In-Reply-To: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> References: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> Message-ID: Vote: yes Paul. From paul.sandoz at oracle.com Tue Jul 18 17:41:39 2017 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Tue, 18 Jul 2017 10:41:39 -0700 Subject: CFV: New Amber Committer: Jan Lahoda In-Reply-To: References: Message-ID: <08D2BF57-A480-40C0-802B-FEF680B65F42@oracle.com> Vote: yes Paul. From paul.sandoz at oracle.com Tue Jul 18 17:41:55 2017 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Tue, 18 Jul 2017 10:41:55 -0700 Subject: CFV: New Amber Committer: Srikanth Adayapalam In-Reply-To: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> References: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> Message-ID: Vote: yes Paul. From john.r.rose at oracle.com Tue Jul 18 18:08:14 2017 From: john.r.rose at oracle.com (John Rose) Date: Tue, 18 Jul 2017 11:08:14 -0700 Subject: CFV: New Amber Committer: Srikanth Adayapalam In-Reply-To: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> References: <00199aa3-ebdd-333c-c98c-37c2de9cc6c9@oracle.com> Message-ID: <916AC8A6-F361-40D4-8679-C9E0140731A0@oracle.com> Vote: yes From john.r.rose at oracle.com Tue Jul 18 18:08:31 2017 From: john.r.rose at oracle.com (John Rose) Date: Tue, 18 Jul 2017 11:08:31 -0700 Subject: CFV: New Amber Committer: Lois Foltan In-Reply-To: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> References: <3cb75f9a-255d-6324-43d3-007bee878a45@oracle.com> Message-ID: <621A0CC6-D174-40F1-BB4F-7C3D29ABA695@oracle.com> Vote: yes From john.r.rose at oracle.com Tue Jul 18 18:08:39 2017 From: john.r.rose at oracle.com (John Rose) Date: Tue, 18 Jul 2017 11:08:39 -0700 Subject: CFV: New Amber Committer: Jan Lahoda In-Reply-To: References: Message-ID: <87266121-0EA7-4673-BD6C-D60B64CA2744@oracle.com> Vote: yes From paul.sandoz at oracle.com Tue Jul 18 20:57:40 2017 From: paul.sandoz at oracle.com (Paul Sandoz) Date: Tue, 18 Jul 2017 13:57:40 -0700 Subject: [condy] Fixing typos in doc of MethodHandle.invokeWithArguments Message-ID: <22A32874-39A2-4BF3-A494-5C28AE930A22@oracle.com> Hi, See patch below. Thanks, Paul. diff -r e63ee1f02d46 src/java.base/share/classes/java/lang/invoke/MethodHandle.java --- a/src/java.base/share/classes/java/lang/invoke/MethodHandle.java Fri Jul 14 00:01:08 2017 +0200 +++ b/src/java.base/share/classes/java/lang/invoke/MethodHandle.java Tue Jul 18 13:53:43 2017 -0700 @@ -615,7 +615,7 @@ * {@code WrongMethodTypeException}. *
  • Replace the logical arguments gathered into the array of * type {@code A[]} with the array itself, thus shortening - * the argument list to length {@code N}. This final argument + * the argument list to length {@code M}. This final argument * retains the static type {@code A[]}.
    • *
  • Adjust the type {@code TN} by changing the {@code N}th * parameter type from {@code Object} to {@code A[]}. @@ -636,18 +636,17 @@ * In this way, jumbo argument lists which would spread into more * than 254 slots can still be processed uniformly. *

    - * Unlike the generic invocation mode, which can "recycle" an array - * argument, passing it directly to the target method, this invocation - * mode always creates a new array parameter, even if - * the original array passed to - * {@link invokeWithArguments(Object[]) invokeWithArguments} would have + * Unlike the {@link #invoke(Object...) generic} invocation mode, which can + * "recycle" an array argument, passing it directly to the target method, + * this invocation mode always creates a new array parameter, even + * if the original array passed to {@code invokeWithArguments} would have * been acceptable as a direct argument to the target method. * Even if the number {@code M} of actual arguments is the arity {@code N}, * and the last argument is dynamically a suitable array of type {@code A[]}, * it will still be boxed into a new one-element array, since the call * site statically types the argument as {@code Object}, not an array type. - * This not a special rule for this method, but rather a regular effect of - * the {@linkplain #asVarargsCollector rules for variable-arity invocation}. + * This is not a special rule for this method, but rather a regular effect + * of the {@linkplain #asVarargsCollector rules for variable-arity invocation}. *

    * Because of the action of the {@code asType} step, the following argument * conversions are applied as necessary: From maurizio.cimadamore at oracle.com Tue Jul 18 21:01:31 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 18 Jul 2017 22:01:31 +0100 Subject: [condy] Fixing typos in doc of MethodHandle.invokeWithArguments In-Reply-To: <22A32874-39A2-4BF3-A494-5C28AE930A22@oracle.com> References: <22A32874-39A2-4BF3-A494-5C28AE930A22@oracle.com> Message-ID: <845cf41e-5710-1fbf-418b-3d1747cfa69e@oracle.com> Looks good Maurizio On 18/07/17 21:57, Paul Sandoz wrote: > Hi, > > See patch below. > > Thanks, > Paul. > > diff -r e63ee1f02d46 src/java.base/share/classes/java/lang/invoke/MethodHandle.java > --- a/src/java.base/share/classes/java/lang/invoke/MethodHandle.java Fri Jul 14 00:01:08 2017 +0200 > +++ b/src/java.base/share/classes/java/lang/invoke/MethodHandle.java Tue Jul 18 13:53:43 2017 -0700 > @@ -615,7 +615,7 @@ > * {@code WrongMethodTypeException}.

    • > *
  • Replace the logical arguments gathered into the array of > * type {@code A[]} with the array itself, thus shortening > - * the argument list to length {@code N}. This final argument > + * the argument list to length {@code M}. This final argument > * retains the static type {@code A[]}.
    • > *
  • Adjust the type {@code TN} by changing the {@code N}th > * parameter type from {@code Object} to {@code A[]}. > @@ -636,18 +636,17 @@ > * In this way, jumbo argument lists which would spread into more > * than 254 slots can still be processed uniformly. > *

    > - * Unlike the generic invocation mode, which can "recycle" an array > - * argument, passing it directly to the target method, this invocation > - * mode always creates a new array parameter, even if > - * the original array passed to > - * {@link invokeWithArguments(Object[]) invokeWithArguments} would have > + * Unlike the {@link #invoke(Object...) generic} invocation mode, which can > + * "recycle" an array argument, passing it directly to the target method, > + * this invocation mode always creates a new array parameter, even > + * if the original array passed to {@code invokeWithArguments} would have > * been acceptable as a direct argument to the target method. > * Even if the number {@code M} of actual arguments is the arity {@code N}, > * and the last argument is dynamically a suitable array of type {@code A[]}, > * it will still be boxed into a new one-element array, since the call > * site statically types the argument as {@code Object}, not an array type. > - * This not a special rule for this method, but rather a regular effect of > - * the {@linkplain #asVarargsCollector rules for variable-arity invocation}. > + * This is not a special rule for this method, but rather a regular effect > + * of the {@linkplain #asVarargsCollector rules for variable-arity invocation}. > *

    > * Because of the action of the {@code asType} step, the following argument > * conversions are applied as necessary: > From paul.sandoz at oracle.com Wed Jul 19 18:48:21 2017 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Wed, 19 Jul 2017 18:48:21 +0000 Subject: hg: amber/amber/jdk: Minor fixes to JavaDoc of MethodHandle.invokeWithArguments. Message-ID: <201707191848.v6JImLeA028526@aojmv0008.oracle.com> Changeset: 1685d5f7f8e7 Author: psandoz Date: 2017-07-19 10:24 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/1685d5f7f8e7 Minor fixes to JavaDoc of MethodHandle.invokeWithArguments. ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java From maurizio.cimadamore at oracle.com Wed Jul 19 18:54:12 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 19 Jul 2017 18:54:12 +0000 Subject: hg: amber/amber/jdk: Automatic merge with condy Message-ID: <201707191854.v6JIsDHE004910@aojmv0008.oracle.com> Changeset: 7aaf0b0ed33b Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-19 20:51 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/7aaf0b0ed33b Automatic merge with condy From gavin.bierman at oracle.com Thu Jul 20 12:42:43 2017 From: gavin.bierman at oracle.com (gavin.bierman at oracle.com) Date: Thu, 20 Jul 2017 12:42:43 +0000 Subject: hg: amber/amber/langtools: * switch now supports patterns in cases Message-ID: <201707201242.v6KCgiIN026723@aojmv0008.oracle.com> Changeset: bfc87a87b923 Author: gbierman Date: 2017-07-20 11:23 +0100 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/bfc87a87b923 * switch now supports patterns in cases ! src/jdk.compiler/share/classes/com/sun/source/tree/CaseTree.java - src/jdk.compiler/share/classes/com/sun/source/tree/ClauseTree.java - src/jdk.compiler/share/classes/com/sun/source/tree/MatchTree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/Tree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/TreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/SimpleTreeVisitor.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/MatchBindingsComputer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransTypes.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/Gen.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/Pretty.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeInfo.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeTranslator.java ! test/tools/javac/patterns/BreakInsideMatch.java ! test/tools/javac/patterns/ConstantPatternTest1.java ! test/tools/javac/patterns/DefaultClauseMustBeLast.java ! test/tools/javac/patterns/DuplicateBindingTest.java ! test/tools/javac/patterns/DuplicateConstantPatternTests.java ! test/tools/javac/patterns/ExamplesFromProposal.java ! test/tools/javac/patterns/FlowAnalysisAndConstantPatterns.java ! test/tools/javac/patterns/FlowAnalysisAndConstantPatterns2.java ! test/tools/javac/patterns/FlowAnalysisTest.java ! test/tools/javac/patterns/MatchBindingScopeTest.java ! test/tools/javac/patterns/MatchStmtTest.java ! test/tools/javac/patterns/NestingMatchAndMatches.java ! test/tools/javac/patterns/NullPatternTest.java + test/tools/javac/patterns/PatternMatchPosTest.java + test/tools/javac/patterns/PatternMatchPosTest.out ! test/tools/javac/patterns/PatternMatchTest1.java ! test/tools/javac/patterns/PatternMatchTest2.java ! test/tools/javac/patterns/PrimitiveSelectorTest.java ! test/tools/javac/patterns/UnreachableStatementInMatchClause.java From gavin.bierman at oracle.com Thu Jul 20 15:56:23 2017 From: gavin.bierman at oracle.com (gavin.bierman at oracle.com) Date: Thu, 20 Jul 2017 15:56:23 +0000 Subject: hg: amber/amber/langtools: Ensure that pattern binding variables are final Message-ID: <201707201556.v6KFuOof008340@aojmv0008.oracle.com> Changeset: 38b9735da6ec Author: gbierman Date: 2017-07-20 16:54 +0100 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/38b9735da6ec Ensure that pattern binding variables are final ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/MatchBindingsComputer.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/patterns/ImpossibleTypeTest.java + test/tools/javac/patterns/PatternVariablesAreFinal.java + test/tools/javac/patterns/PatternVariablesAreFinal.out + test/tools/javac/patterns/PatternVariablesAreFinal2.java From maurizio.cimadamore at oracle.com Thu Jul 20 21:57:05 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 21:57:05 +0000 Subject: hg: amber/amber/jdk: 20 new changesets Message-ID: <201707202157.v6KLv6Q5008205@aojmv0008.oracle.com> Changeset: c296c24385b1 Author: jjg Date: 2017-07-13 17:45 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/c296c24385b1 8184311: Update java.sql and java.sql.rowset API docs for accessibility Reviewed-by: lancea ! src/java.sql.rowset/share/classes/javax/sql/rowset/package.html ! src/java.sql/share/classes/java/sql/Connection.java ! src/java.sql/share/classes/java/sql/DriverManager.java ! src/java.sql/share/classes/java/sql/SQLPermission.java ! src/java.sql/share/classes/java/sql/Statement.java ! src/java.sql/share/classes/javax/sql/package.html Changeset: 9e675fdba74d Author: anazarov Date: 2017-07-14 14:43 +0100 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/9e675fdba74d 8174692: New MultiReleaseJarTest.java tests fail in JDK 10 Reviewed-by: alanb ! test/ProblemList.txt ! test/tools/schemagen/MultiReleaseJarTest.java ! test/tools/wsgen/MultiReleaseJarTest.java Changeset: e208609ec9cd Author: naoto Date: 2017-07-14 10:42 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/e208609ec9cd 8184314: Javadoc for Offsettime has "." where it should be ":" prior to seconds Reviewed-by: rriggs ! src/java.base/share/classes/java/time/OffsetDateTime.java ! src/java.base/share/classes/java/time/OffsetTime.java Changeset: cfdcaedd6da2 Author: igerasim Date: 2017-07-15 14:01 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/cfdcaedd6da2 8184706: Matcher doesn't indicate hitEnd after matching \u0D with \R at EOL Reviewed-by: sherman ! src/java.base/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 46a03a1d296c Author: clanger Date: 2017-07-17 11:47 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/46a03a1d296c 8184673: Fix compatibility issue in AlgorithmChecker for 3rd party JCE providers Reviewed-by: ascarpino, mullan ! src/java.base/share/classes/sun/security/provider/certpath/AlgorithmChecker.java Changeset: 04ad8f0efc06 Author: clanger Date: 2017-07-17 15:46 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/04ad8f0efc06 8183123: JDP packets have no processId context set Reviewed-by: dcubed, clanger Contributed-by: andrew_m_leonard at uk.ibm.com ! src/jdk.management.agent/share/classes/sun/management/jdp/JdpController.java ! test/sun/management/jdp/JdpOnTestCase.java Changeset: 4b649e97ece3 Author: mli Date: 2017-07-17 23:12 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/4b649e97ece3 8177017: com/oracle/security/ucrypto/TestAES.java fails intermittently Summary: Skips CFB128 related cases on Solaris pre-11.3 versions. Reviewed-by: valeriep Contributed-by: John Jiang ! test/com/oracle/security/ucrypto/TestAES.java Changeset: 962144cb4baa Author: redestad Date: 2017-07-18 12:40 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/962144cb4baa 8184603: Create ObjectStreamField signature lazily when possible Reviewed-by: rriggs, chegar, alanb, shade ! src/java.base/share/classes/java/io/ObjectStreamField.java Changeset: b2fada7695e7 Author: bpb Date: 2017-07-18 17:56 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/b2fada7695e7 8184807: (ch) Clean up handling of some Windows function return values in libnio Summary: Properly check and respond to Windows function return values in libnio Reviewed-by: alanb ! src/java.base/windows/native/libnio/ch/FileChannelImpl.c ! src/java.base/windows/native/libnio/ch/FileDispatcherImpl.c ! src/java.base/windows/native/libnio/ch/WindowsAsynchronousFileChannelImpl.c Changeset: 3281b964ab10 Author: redestad Date: 2017-07-19 14:40 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/3281b964ab10 8184665: Skip name and alias checks for standard Charsets Reviewed-by: sherman, rriggs, forax ! src/java.base/share/classes/java/nio/charset/Charset.java ! src/java.base/share/classes/sun/nio/cs/ISO_8859_1.java ! src/java.base/share/classes/sun/nio/cs/StandardCharsets.java.template ! src/java.base/share/classes/sun/nio/cs/US_ASCII.java ! src/java.base/share/classes/sun/nio/cs/UTF_8.java ! test/java/nio/charset/Charset/IllegalCharsetName.java Changeset: 21122d3050b1 Author: bpb Date: 2017-07-19 08:46 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/21122d3050b1 8183320: Better cleanup in java/nio/file/Files/probeContentType/ParallelProbes.java 8183321: Better cleanup for jdk/test/java/io/File/createTempFile/NameTooLong.java 8183343: Better cleanup for jdk/test/java/nio/file/spi/SetDefaultProvider.java 8183344: Better cleanup for jdk/test/java/io/File/createTempFile/SpecialTempFile.java Summary: Change locations where temporary files are created to ensure cleanup Reviewed-by: chegar, alanb ! test/java/io/File/createTempFile/NameTooLong.java ! test/java/io/File/createTempFile/SpecialTempFile.java ! test/java/nio/file/Files/probeContentType/ParallelProbes.java ! test/java/nio/file/spi/SetDefaultProvider.java Changeset: d900d50fd581 Author: alanb Date: 2017-07-19 19:30 +0100 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/d900d50fd581 8184917: System.initPhase1 does not need to pre-load libzip Reviewed-by: redestad ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/util/zip/Adler32.java ! src/java.base/share/classes/java/util/zip/CRC32.java ! src/java.base/share/classes/java/util/zip/Deflater.java ! src/java.base/share/classes/java/util/zip/Inflater.java ! src/java.base/share/classes/java/util/zip/ZipUtils.java Changeset: 4fb5f3049c2c Author: alanb Date: 2017-07-19 19:31 +0100 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/4fb5f3049c2c 8184916: DisabledAlgorithmConstraints loading should be delayed until needed Reviewed-by: mullan ! src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java Changeset: 03088af6fd97 Author: rriggs Date: 2017-07-19 16:24 -0400 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/03088af6fd97 8184808: (process) isAlive should use pid for validity, not /proc/pid Reviewed-by: stuefe, xiaofeya ! src/java.base/unix/native/libjava/ProcessHandleImpl_unix.c Changeset: 31fb812459f8 Author: naoto Date: 2017-07-19 14:48 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/31fb812459f8 8183902: Remove unnecessary definitions in locale_str.h for macOS Reviewed-by: rriggs ! src/java.base/unix/native/libjava/locale_str.h Changeset: 94d661f9c85f Author: anazarov Date: 2017-07-18 15:19 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/94d661f9c85f 8177357: tools/jar/multiRelease/ApiValidatorTest.java failed due to "Exception java.nio.file.DirectoryNotEmptyException" Reviewed-by: psandoz ! test/tools/jar/multiRelease/ApiValidatorTest.java Changeset: 5da856eb4da1 Author: shshahma Date: 2017-07-17 03:58 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/5da856eb4da1 8181500: [TESTBUG] com/sun/jdi/LineNumberInfo.java fails with jArrayIndexOutOfBoundsException Summary: Update line number table and code indices table with missing entry Reviewed-by: vromero ! test/com/sun/jdi/LineNumberInfo.java Changeset: 20dd01e234d1 Author: poonam Date: 2017-07-20 01:18 +0000 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/20dd01e234d1 Merge Changeset: 5d71ff193033 Author: xiaofeya Date: 2017-07-20 06:49 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/5d71ff193033 8184904: jdk/internal/jrtfs/WithSecurityManager fails with exploded builds Reviewed-by: alanb ! test/jdk/internal/jrtfs/Basic.java ! test/jdk/internal/jrtfs/WithSecurityManager.java Changeset: 2c01b46e1ebd Author: tbell Date: 2017-07-20 18:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/2c01b46e1ebd Added tag jdk-10+16 for changeset 3281b964ab10 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 20 21:57:04 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 21:57:04 +0000 Subject: hg: amber/amber/jaxws: Added tag jdk-10+16 for changeset bc8289ce1ed3 Message-ID: <201707202157.v6KLv48v008075@aojmv0008.oracle.com> Changeset: 97e67df03f88 Author: tbell Date: 2017-07-20 18:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/97e67df03f88 Added tag jdk-10+16 for changeset bc8289ce1ed3 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 20 21:57:06 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 21:57:06 +0000 Subject: hg: amber/amber: 5 new changesets Message-ID: <201707202157.v6KLv6TJ008177@aojmv0008.oracle.com> Changeset: 0ef90e8cc2bb Author: phh Date: 2017-07-14 13:02 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/0ef90e8cc2bb 8184022: Build JDK 10 on OSX 10.12 and above Reviewed-by: erikj, tbell ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh ! common/autoconf/spec.gmk.in ! common/conf/jib-profiles.js ! common/nb_native/nbproject/configurations.xml Changeset: 0aaea19fca61 Author: mli Date: 2017-07-17 23:11 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/0aaea19fca61 8177017: com/oracle/security/ucrypto/TestAES.java fails intermittently Summary: Skips CFB128 related cases on Solaris pre-11.3 versions. Reviewed-by: valeriep Contributed-by: John Jiang ! test/lib/jdk/test/lib/Utils.java Changeset: 49a15c503104 Author: mbaesken Date: 2017-07-18 14:42 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/49a15c503104 8184338: switch minimum supported gcc version to 4.7 Reviewed-by: erikj, tbell ! common/autoconf/generated-configure.sh ! common/autoconf/toolchain.m4 ! common/doc/building.md Changeset: 2fe66ca1e2b3 Author: stuefe Date: 2017-07-18 18:05 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/2fe66ca1e2b3 8184344: [aix] libjvm.so TOC overflow for slowdebug Reviewed-by: clanger, simonis ! common/autoconf/flags.m4 ! common/autoconf/generated-configure.sh Changeset: 549b9a8e6dcc Author: tbell Date: 2017-07-20 18:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/549b9a8e6dcc Added tag jdk-10+16 for changeset 2fe66ca1e2b3 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 20 21:57:06 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 21:57:06 +0000 Subject: hg: amber/amber/hotspot: Added tag jdk-10+16 for changeset 2fe2a593e8eb Message-ID: <201707202157.v6KLv6mA008225@aojmv0008.oracle.com> Changeset: 73e2cb8700bf Author: tbell Date: 2017-07-20 18:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/73e2cb8700bf Added tag jdk-10+16 for changeset 2fe2a593e8eb ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 20 21:57:07 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 21:57:07 +0000 Subject: hg: amber/amber/langtools: 5 new changesets Message-ID: <201707202157.v6KLv7W4008285@aojmv0008.oracle.com> Changeset: fe229ee12a5d Author: pmuthuswamy Date: 2017-07-15 11:06 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/fe229ee12a5d 8177048: javadoc should support -version and/or --version Reviewed-by: jjg, ksrini ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/ToolOption.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/resources/javadoc.properties + test/jdk/javadoc/doclet/testVersionOption/TestVersionOption.java ! test/tools/javac/T8003967/DetectMutableStaticFields.java Changeset: c5396fef969a Author: bpatel Date: 2017-07-15 14:51 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/c5396fef969a 8181622: new {@index} tag generates multiple index entries Reviewed-by: jjg, ksrini ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! test/jdk/javadoc/doclet/testModules/TestModules.java ! test/jdk/javadoc/doclet/testModules/moduleA/module-info.java ! test/jdk/javadoc/doclet/testModules/moduletags/module-info.java ! test/jdk/javadoc/doclet/testSearch/TestSearch.java Changeset: f47e45d43b63 Author: pmuthuswamy Date: 2017-07-18 15:50 -0700 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/f47e45d43b63 8182359: Color contrast Error on /pkg-use.html pages Reviewed-by: bpatel, jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css Changeset: 4070d214e887 Author: pmuthuswamy Date: 2017-07-19 11:44 +0530 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/4070d214e887 8057647: javac parser needs updates to have better error recovery for error cases of new array creation with dimensions Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/ExtraneousEquals.java ! test/tools/javac/ExtraneousEquals.out + test/tools/javac/diags/examples/IllegalArrayCreation.java Changeset: 41028d8c0a71 Author: tbell Date: 2017-07-20 18:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/41028d8c0a71 Added tag jdk-10+16 for changeset 4070d214e887 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 20 21:57:08 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 21:57:08 +0000 Subject: hg: amber/amber/jaxp: 2 new changesets Message-ID: <201707202157.v6KLv8p7008292@aojmv0008.oracle.com> Changeset: d109d55cf642 Author: joehw Date: 2017-07-17 14:40 -0700 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/d109d55cf642 8183519: XMLInputFactory.newFactory() is marked as deprecated Reviewed-by: lancea ! src/java.xml/share/classes/javax/xml/stream/XMLEventFactory.java ! src/java.xml/share/classes/javax/xml/stream/XMLInputFactory.java ! src/java.xml/share/classes/javax/xml/stream/XMLOutputFactory.java Changeset: 97d6f14334cf Author: tbell Date: 2017-07-20 18:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/97d6f14334cf Added tag jdk-10+16 for changeset d109d55cf642 ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 20 21:57:10 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 21:57:10 +0000 Subject: hg: amber/amber/nashorn: 2 new changesets Message-ID: <201707202157.v6KLvAvs008312@aojmv0008.oracle.com> Changeset: 4bdf81f41e20 Author: sdama Date: 2017-07-20 19:56 +0530 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/4bdf81f41e20 8184241: Fix nashorn/samples/filebrowser.js Summary: Fixed global/delegate field issue in case of overridden method called from super constructor Reviewed-by: hannesw, jlaskey Contributed-by: srinivas.dama at oracle.com ! src/jdk.scripting.nashorn/share/classes/jdk/nashorn/internal/runtime/linker/JavaAdapterBytecodeGenerator.java + test/script/nosecurity/JDK-8184241.js + test/script/nosecurity/JDK-8184241.js.EXPECTED + test/src/jdk/nashorn/test/models/JDK_8184241Test.java Changeset: 1488f8f8a206 Author: tbell Date: 2017-07-20 18:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/1488f8f8a206 Added tag jdk-10+16 for changeset f456f59dad3f ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 20 21:57:09 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 21:57:09 +0000 Subject: hg: amber/amber/corba: Added tag jdk-10+16 for changeset b82b62ed5deb Message-ID: <201707202157.v6KLv9Xp008303@aojmv0008.oracle.com> Changeset: 50ff1fd66362 Author: tbell Date: 2017-07-20 18:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/50ff1fd66362 Added tag jdk-10+16 for changeset b82b62ed5deb ! .hgtags From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:10 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:10 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707202202.v6KM2AcY011368@aojmv0008.oracle.com> Changeset: 4784a5e425c6 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-20 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/4784a5e425c6 Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:09 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:09 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707202202.v6KM29qA011294@aojmv0008.oracle.com> Changeset: 2f710c447c98 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-20 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/2f710c447c98 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:08 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:08 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707202202.v6KM28p9011239@aojmv0008.oracle.com> Changeset: 3cd615a5e865 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-20 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/3cd615a5e865 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:11 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:11 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707202202.v6KM2BZW011522@aojmv0008.oracle.com> Changeset: 8cbe80a8e8c5 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-20 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/8cbe80a8e8c5 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:11 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:11 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707202202.v6KM2Bcf011497@aojmv0008.oracle.com> Changeset: f83b600bc170 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-20 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/f83b600bc170 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:12 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:12 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707202202.v6KM2CBY011565@aojmv0008.oracle.com> Changeset: 98329a3c376b Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-20 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/98329a3c376b Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:13 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:13 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707202202.v6KM2DJY011597@aojmv0008.oracle.com> Changeset: 49fe3f559178 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-20 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/49fe3f559178 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:14 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:14 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707202202.v6KM2EJ7011601@aojmv0008.oracle.com> Changeset: 28a5a1b52b50 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-20 23:59 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/28a5a1b52b50 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:42 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:42 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707202202.v6KM2gEb013276@aojmv0008.oracle.com> Changeset: f2fb797df24e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/f2fb797df24e Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:40 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:40 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707202202.v6KM2enO013095@aojmv0008.oracle.com> Changeset: 1cb8f401edcc Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/1cb8f401edcc Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:41 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:41 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707202202.v6KM2fai013174@aojmv0008.oracle.com> Changeset: 06331ec73a0f Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/06331ec73a0f Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:43 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:43 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707202202.v6KM2iMX013423@aojmv0008.oracle.com> Changeset: b8b3a2b3c640 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/b8b3a2b3c640 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:43 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:43 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707202202.v6KM2hWS013345@aojmv0008.oracle.com> Changeset: 7356270865ec Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/7356270865ec Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:46 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:46 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707202202.v6KM2kF7013539@aojmv0008.oracle.com> Changeset: 09b533932524 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/09b533932524 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:45 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:45 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707202202.v6KM2jO5013499@aojmv0008.oracle.com> Changeset: 23f1100fb87f Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/23f1100fb87f Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:02:46 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:02:46 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707202202.v6KM2kR8013564@aojmv0008.oracle.com> Changeset: 98b54a4b9167 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/98b54a4b9167 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:16 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:16 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707202203.v6KM3GKG015627@aojmv0008.oracle.com> Changeset: aa1acb7fceb8 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/aa1acb7fceb8 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:15 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:15 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707202203.v6KM3FKI015557@aojmv0008.oracle.com> Changeset: 702f77704350 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/702f77704350 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:14 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:14 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707202203.v6KM3EcW015494@aojmv0008.oracle.com> Changeset: 2f447dff13bd Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/2f447dff13bd Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:17 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:17 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707202203.v6KM3HjU015754@aojmv0008.oracle.com> Changeset: 6542c7186431 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/6542c7186431 Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:16 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:16 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707202203.v6KM3GRr015703@aojmv0008.oracle.com> Changeset: b38b44921b9e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/b38b44921b9e Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:19 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:19 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707202203.v6KM3JGC015773@aojmv0008.oracle.com> Changeset: 92c37315a1f8 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/92c37315a1f8 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:18 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:18 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707202203.v6KM3Ibd015770@aojmv0008.oracle.com> Changeset: 264b6f250467 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/264b6f250467 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:20 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:20 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707202203.v6KM3KsR015780@aojmv0008.oracle.com> Changeset: 90d3dc06d718 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/90d3dc06d718 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:47 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:47 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707202203.v6KM3lgI017083@aojmv0008.oracle.com> Changeset: 8dc2f7d83e8a Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/8dc2f7d83e8a Automatic merge with default ! .hgtags ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:47 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:47 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707202203.v6KM3l6w017024@aojmv0008.oracle.com> Changeset: cadc6539c8ba Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/cadc6539c8ba Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:49 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:49 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707202203.v6KM3nOt017189@aojmv0008.oracle.com> Changeset: 003987956f34 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/003987956f34 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:48 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:48 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707202203.v6KM3mSU017135@aojmv0008.oracle.com> Changeset: 39c86c026d03 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/39c86c026d03 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:51 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:51 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707202203.v6KM3p2L017255@aojmv0008.oracle.com> Changeset: d7909ae0b200 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/d7909ae0b200 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:50 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:50 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707202203.v6KM3oXP017246@aojmv0008.oracle.com> Changeset: 8463a0226a1d Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/8463a0226a1d Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:51 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:51 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707202203.v6KM3q8f017260@aojmv0008.oracle.com> Changeset: 915b3af7a73c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/915b3af7a73c Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:03:53 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:03:53 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707202203.v6KM3rAQ017264@aojmv0008.oracle.com> Changeset: 6df21c2523ea Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/6df21c2523ea Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:19 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:19 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707202204.v6KM4JeN018475@aojmv0008.oracle.com> Changeset: 2e53a54ce8bc Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/2e53a54ce8bc Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:21 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:21 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707202204.v6KM4Ln8018623@aojmv0008.oracle.com> Changeset: 23a6c1d55c73 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/23a6c1d55c73 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:23 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:23 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707202204.v6KM4Nig018733@aojmv0008.oracle.com> Changeset: 7c0505a2aca0 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/7c0505a2aca0 Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:22 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:22 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707202204.v6KM4MFu018673@aojmv0008.oracle.com> Changeset: 3a24423223b4 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/3a24423223b4 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:20 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:20 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707202204.v6KM4KX7018540@aojmv0008.oracle.com> Changeset: cf129b4007f3 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/cf129b4007f3 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:24 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:24 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707202204.v6KM4OKt018753@aojmv0008.oracle.com> Changeset: bde0040aa496 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/bde0040aa496 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:23 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:23 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707202204.v6KM4OsY018750@aojmv0008.oracle.com> Changeset: 9c84756032f9 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/9c84756032f9 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:25 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:25 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707202204.v6KM4PY6018758@aojmv0008.oracle.com> Changeset: e55c341191cf Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:01 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/e55c341191cf Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:55 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:55 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with default Message-ID: <201707202204.v6KM4tqQ020337@aojmv0008.oracle.com> Changeset: 28bf06b72017 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/28bf06b72017 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:54 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:54 +0000 Subject: hg: amber/amber/corba: Automatic merge with default Message-ID: <201707202204.v6KM4sZW020269@aojmv0008.oracle.com> Changeset: 0fa29af0b9d8 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/0fa29af0b9d8 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:53 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:53 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201707202204.v6KM4rVI020176@aojmv0008.oracle.com> Changeset: 2a022060fa93 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/2a022060fa93 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:56 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:56 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with default Message-ID: <201707202204.v6KM4urq020448@aojmv0008.oracle.com> Changeset: bb801911f187 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/bb801911f187 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:57 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:57 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with default Message-ID: <201707202204.v6KM4vxb020542@aojmv0008.oracle.com> Changeset: 5749e48548b0 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/5749e48548b0 Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:59 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:59 +0000 Subject: hg: amber/amber/jdk: Automatic merge with default Message-ID: <201707202204.v6KM4x7X020580@aojmv0008.oracle.com> Changeset: 75b6427e5c5a Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/75b6427e5c5a Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:04:59 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:04:59 +0000 Subject: hg: amber/amber/langtools: Automatic merge with default Message-ID: <201707202204.v6KM4x6q020584@aojmv0008.oracle.com> Changeset: 8366ad5b9dc6 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/8366ad5b9dc6 Automatic merge with default ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:00 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:00 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with default Message-ID: <201707202205.v6KM50c9020603@aojmv0008.oracle.com> Changeset: 7e65c645fa8c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:02 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/7e65c645fa8c Automatic merge with default From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:28 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:28 +0000 Subject: hg: amber/amber: Automatic merge with constant-folding Message-ID: <201707202205.v6KM5SD0021816@aojmv0008.oracle.com> Changeset: ab7efca4ea61 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/ab7efca4ea61 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:27 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:27 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with constant-folding Message-ID: <201707202205.v6KM5RDh021758@aojmv0008.oracle.com> Changeset: b8e4a56263d4 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/b8e4a56263d4 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:29 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:29 +0000 Subject: hg: amber/amber/langtools: Automatic merge with constant-folding Message-ID: <201707202205.v6KM5T62021882@aojmv0008.oracle.com> Changeset: c70099e3eaa5 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/c70099e3eaa5 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:30 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:30 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with constant-folding Message-ID: <201707202205.v6KM5UxD021930@aojmv0008.oracle.com> Changeset: 7d3f97f2558d Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/7d3f97f2558d Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:31 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:31 +0000 Subject: hg: amber/amber/corba: Automatic merge with constant-folding Message-ID: <201707202205.v6KM5Vod022000@aojmv0008.oracle.com> Changeset: 5ad760611982 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/5ad760611982 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:32 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:32 +0000 Subject: hg: amber/amber/jdk: Automatic merge with constant-folding Message-ID: <201707202205.v6KM5W86022009@aojmv0008.oracle.com> Changeset: dd3a2b5877b4 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/dd3a2b5877b4 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:33 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:33 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with constant-folding Message-ID: <201707202205.v6KM5XdX022012@aojmv0008.oracle.com> Changeset: 8017ca76679c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/8017ca76679c Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 20 22:05:34 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:05:34 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with constant-folding Message-ID: <201707202205.v6KM5YhT022015@aojmv0008.oracle.com> Changeset: a2d29a9b5369 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/a2d29a9b5369 Automatic merge with constant-folding From maurizio.cimadamore at oracle.com Thu Jul 20 22:06:01 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:06:01 +0000 Subject: hg: amber/amber: Automatic merge with condy Message-ID: <201707202206.v6KM61aG023351@aojmv0008.oracle.com> Changeset: 4dab166d14b3 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/rev/4dab166d14b3 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 20 22:06:02 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:06:02 +0000 Subject: hg: amber/amber/corba: Automatic merge with condy Message-ID: <201707202206.v6KM6283023409@aojmv0008.oracle.com> Changeset: c108ba239a5a Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/corba/rev/c108ba239a5a Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 20 22:06:03 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:06:03 +0000 Subject: hg: amber/amber/langtools: Automatic merge with condy Message-ID: <201707202206.v6KM63sG023496@aojmv0008.oracle.com> Changeset: 118d328655b0 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/118d328655b0 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 20 22:06:04 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:06:04 +0000 Subject: hg: amber/amber/jaxws: Automatic merge with condy Message-ID: <201707202206.v6KM64tY023558@aojmv0008.oracle.com> Changeset: 37326a66e51c Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxws/rev/37326a66e51c Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 20 22:06:05 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:06:05 +0000 Subject: hg: amber/amber/jdk: Automatic merge with condy Message-ID: <201707202206.v6KM65uG023640@aojmv0008.oracle.com> Changeset: 87b41d2b9010 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/87b41d2b9010 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 20 22:06:06 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:06:06 +0000 Subject: hg: amber/amber/jaxp: Automatic merge with condy Message-ID: <201707202206.v6KM662v023669@aojmv0008.oracle.com> Changeset: a23562bbc8c4 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/jaxp/rev/a23562bbc8c4 Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 20 22:06:08 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:06:08 +0000 Subject: hg: amber/amber/nashorn: Automatic merge with condy Message-ID: <201707202206.v6KM68ad023678@aojmv0008.oracle.com> Changeset: b619a98ec1dc Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/nashorn/rev/b619a98ec1dc Automatic merge with condy From maurizio.cimadamore at oracle.com Thu Jul 20 22:06:07 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 20 Jul 2017 22:06:07 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with condy Message-ID: <201707202206.v6KM6760023672@aojmv0008.oracle.com> Changeset: e70a7ebcc4e2 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 00:03 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/e70a7ebcc4e2 Automatic merge with condy From john.r.rose at oracle.com Fri Jul 21 08:42:38 2017 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Fri, 21 Jul 2017 08:42:38 +0000 Subject: hg: amber/amber/hotspot: Support ldc of condy for primitives. Message-ID: <201707210842.v6L8gcJ3029632@aojmv0008.oracle.com> Changeset: f28cad89fd5e Author: jrose Date: 2017-07-21 01:40 -0700 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/f28cad89fd5e Support ldc of condy for primitives. ! src/cpu/x86/vm/templateTable_x86.cpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/interpreter/bytecode.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/interpreter/templateTable.cpp ! src/share/vm/interpreter/templateTable.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/utilities/globalDefinitions.hpp From john.r.rose at oracle.com Fri Jul 21 09:41:57 2017 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Fri, 21 Jul 2017 09:41:57 +0000 Subject: hg: amber/amber/hotspot: First cut of JIT support for condy Message-ID: <201707210941.v6L9fwKN019926@aojmv0008.oracle.com> Changeset: 974d2b1c2055 Author: jrose Date: 2017-07-21 02:39 -0700 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/974d2b1c2055 First cut of JIT support for condy ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/interpreter/rewriter.cpp ! src/share/vm/opto/parse2.cpp From maurizio.cimadamore at oracle.com Fri Jul 21 09:49:44 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 21 Jul 2017 09:49:44 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with condy Message-ID: <201707210949.v6L9nidL027166@aojmv0008.oracle.com> Changeset: e7a37f46fe57 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 11:47 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/e7a37f46fe57 Automatic merge with condy From paul.sandoz at oracle.com Fri Jul 21 16:45:21 2017 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 21 Jul 2017 16:45:21 +0000 Subject: hg: amber/amber/jdk: Remove cast check (which does not work for primtives). Cast checking is Message-ID: <201707211645.v6LGjMAW018595@aojmv0008.oracle.com> Changeset: b79f75f79d88 Author: psandoz Date: 2017-07-21 09:42 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/b79f75f79d88 Remove cast check (which does not work for primtives). Cast checking is performed in the generic bootstrap invoke code. ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From maurizio.cimadamore at oracle.com Fri Jul 21 16:48:31 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 21 Jul 2017 16:48:31 +0000 Subject: hg: amber/amber/jdk: Automatic merge with condy Message-ID: <201707211648.v6LGmW86025098@aojmv0008.oracle.com> Changeset: 55a6365b1ff0 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 18:46 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/55a6365b1ff0 Automatic merge with condy ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From paul.sandoz at oracle.com Fri Jul 21 16:59:10 2017 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Fri, 21 Jul 2017 16:59:10 +0000 Subject: hg: amber/amber/jdk: remove commented out code Message-ID: <201707211659.v6LGxAbQ003494@aojmv0008.oracle.com> Changeset: 621bc346cfb1 Author: psandoz Date: 2017-07-21 09:46 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/621bc346cfb1 remove commented out code ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From maurizio.cimadamore at oracle.com Fri Jul 21 17:03:27 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Fri, 21 Jul 2017 17:03:27 +0000 Subject: hg: amber/amber/jdk: Automatic merge with condy Message-ID: <201707211703.v6LH3Roo010611@aojmv0008.oracle.com> Changeset: 4d56f268c331 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-21 19:00 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/4d56f268c331 Automatic merge with condy ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From john.r.rose at oracle.com Sat Jul 22 01:34:01 2017 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Sat, 22 Jul 2017 01:34:01 +0000 Subject: hg: amber/amber/hotspot: passes CondyReturnPrimitiveTest Message-ID: <201707220134.v6M1Y1Rr004861@aojmv0008.oracle.com> Changeset: 4296d0851c16 Author: jrose Date: 2017-07-21 18:31 -0700 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/4296d0851c16 passes CondyReturnPrimitiveTest ! src/cpu/x86/vm/interp_masm_x86.cpp ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/cpu/x86/vm/templateTable_x86.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/interpreter/bytecode.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/interpreterRuntime.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/memory/universe.hpp ! src/share/vm/oops/constantPool.cpp ! src/share/vm/oops/generateOopMap.cpp From maurizio.cimadamore at oracle.com Sat Jul 22 01:38:24 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Sat, 22 Jul 2017 01:38:24 +0000 Subject: hg: amber/amber/hotspot: Automatic merge with condy Message-ID: <201707220138.v6M1cOh2009804@aojmv0008.oracle.com> Changeset: 23837790df2e Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-22 03:35 +0200 URL: http://hg.openjdk.java.net/amber/amber/hotspot/rev/23837790df2e Automatic merge with condy From john.r.rose at oracle.com Sat Jul 22 01:49:35 2017 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Sat, 22 Jul 2017 01:49:35 +0000 Subject: hg: amber/amber/jdk: passes CondyReturnPrimitiveTest Message-ID: <201707220149.v6M1nZ7r014442@aojmv0008.oracle.com> Changeset: da23b617a3f6 Author: jrose Date: 2017-07-21 18:47 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/da23b617a3f6 passes CondyReturnPrimitiveTest ! src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From maurizio.cimadamore at oracle.com Sat Jul 22 01:53:32 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Sat, 22 Jul 2017 01:53:32 +0000 Subject: hg: amber/amber/jdk: Automatic merge with condy Message-ID: <201707220153.v6M1rWLG019399@aojmv0008.oracle.com> Changeset: 49f54b7cd043 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-22 03:51 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/49f54b7cd043 Automatic merge with condy ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From john.r.rose at oracle.com Sat Jul 22 05:24:52 2017 From: john.r.rose at oracle.com (john.r.rose at oracle.com) Date: Sat, 22 Jul 2017 05:24:52 +0000 Subject: hg: amber/amber/jdk: 2 new changesets Message-ID: <201707220524.v6M5OqB4028842@aojmv0008.oracle.com> Changeset: c0cceebb85e6 Author: jrose Date: 2017-07-21 22:12 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/c0cceebb85e6 example BSMs for condy ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 5c7ca8bc80d1 Author: jrose Date: 2017-07-21 22:22 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/5c7ca8bc80d1 manual merge ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From paul.sandoz at oracle.com Sat Jul 22 22:39:46 2017 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Sat, 22 Jul 2017 22:39:46 +0000 Subject: hg: amber/amber/jdk: Move VH BSM from DynamicConstants on condy-folding branch. Message-ID: <201707222239.v6MMdkox005345@aojmv0008.oracle.com> Changeset: b8b82424af4e Author: psandoz Date: 2017-07-22 15:37 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/b8b82424af4e Move VH BSM from DynamicConstants on condy-folding branch. Add BSM for obtaining primitive value from an integer value where the primitive value cannot be represented directly in the constant pool. ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From maurizio.cimadamore at oracle.com Sat Jul 22 22:43:25 2017 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Sat, 22 Jul 2017 22:43:25 +0000 Subject: hg: amber/amber/jdk: Automatic merge with condy Message-ID: <201707222243.v6MMhPWF010432@aojmv0008.oracle.com> Changeset: 4531484a5ae9 Author: langtools at sthdev02.uk.oracle.com Date: 2017-07-23 00:40 +0200 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/4531484a5ae9 Automatic merge with condy ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From paul.sandoz at oracle.com Sat Jul 22 23:00:38 2017 From: paul.sandoz at oracle.com (paul.sandoz at oracle.com) Date: Sat, 22 Jul 2017 23:00:38 +0000 Subject: hg: amber/amber/jdk: Shift over to BSMs on j.l.i.ConstantDynamic. Message-ID: <201707222300.v6MN0d3R021054@aojmv0008.oracle.com> Changeset: 7b5f09ffd541 Author: psandoz Date: 2017-07-22 15:57 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/7b5f09ffd541 Shift over to BSMs on j.l.i.ConstantDynamic. ! src/java.base/share/classes/java/lang/invoke/Constables.java ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java - src/java.base/share/classes/java/lang/invoke/DynamicConstants.java ! test/java/lang/invoke/CondyTest.java From vicente.romero at oracle.com Mon Jul 24 15:03:10 2017 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 24 Jul 2017 15:03:10 +0000 Subject: hg: amber/amber/jdk: adding missing javadoc comment Message-ID: <201707241503.v6OF3AbY029971@aojmv0008.oracle.com> Changeset: 1dc54b90be01 Author: vromero Date: 2017-07-24 07:42 -0700 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/1dc54b90be01 adding missing javadoc comment ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From vicente.romero at oracle.com Mon Jul 24 15:21:12 2017 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 24 Jul 2017 15:21:12 +0000 Subject: hg: amber/amber/jdk: merge Message-ID: <201707241521.v6OFLDMV010171@aojmv0008.oracle.com> Changeset: a094fba7c5f7 Author: vromero Date: 2017-07-24 11:18 -0400 URL: http://hg.openjdk.java.net/amber/amber/jdk/rev/a094fba7c5f7 merge ! src/java.base/share/classes/java/lang/invoke/ConstantDynamic.java From gavin.bierman at oracle.com Tue Jul 25 11:10:57 2017 From: gavin.bierman at oracle.com (gavin.bierman at oracle.com) Date: Tue, 25 Jul 2017 11:10:57 +0000 Subject: hg: amber/amber/langtools: Fixing regression tests Message-ID: <201707251110.v6PBAvSw015574@aojmv0008.oracle.com> Changeset: 9fb9ed42c78e Author: gbierman Date: 2017-07-25 10:51 +0100 URL: http://hg.openjdk.java.net/amber/amber/langtools/rev/9fb9ed42c78e Fixing regression tests ! src/jdk.compiler/share/classes/com/sun/source/tree/ConstantPatternTree.java ! src/jdk.compiler/share/classes/com/sun/source/tree/VariablePatternTree.java ! src/jdk.compiler/share/classes/com/sun/source/util/TreeScanner.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.jshell/share/classes/jdk/jshell/CompletenessAnalyzer.java ! test/jdk/jshell/CompletenessTest.java ! test/tools/javac/diags/examples/MatchBindingExists.java + test/tools/javac/diags/examples/PatternBindingMayNotBeAssigned.java ! test/tools/javac/patterns/PatternMatchPosTest.out From brian.goetz at oracle.com Sat Jul 29 14:46:47 2017 From: brian.goetz at oracle.com (Brian Goetz) Date: Sat, 29 Jul 2017 10:46:47 -0400 Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: References: Message-ID: <69d83eac-3ba9-fef9-df2a-d2c2925df11e@oracle.com> As evidence of Tagir's point that people will confuse this for a declaration-site feature, I offer this tweet of a random Java developer who saw the blink-poll on twitter and immediately lept to the wrong conclusion: https://twitter.com/wbasrs/status/891213337454940160 On 6/25/2017 6:51 AM, Tagir Valeev wrote: > Hello! > > Currently in lambda-leftovers underscore is allowed as a parameter name for > abstract methods. This looks dubious as normally underscore means that > parameter is not used in the corresponding method/lambda/catch body, but > there's no actual body and no parameter is actually used anyways (but could > be used in abstract method implementations). I think, allowing underscores > for interface methods may encorage bad practices of defining interfaces > without readable parameter names: > > interface X { > void doSomething(int _, long _, String _); > } > > Should not this be disabled? > > It's even worse for native methods, because underscore assumes that > parameter is not used, but it does not limit the corresponding native > implementation from using it. > > With best regards, > Tagir Valeev. From maurizio.cimadamore at oracle.com Sun Jul 30 10:41:43 2017 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Sun, 30 Jul 2017 11:41:43 +0100 Subject: [lambda-leftovers] Underscore parameter for abstract/native methods In-Reply-To: <69d83eac-3ba9-fef9-df2a-d2c2925df11e@oracle.com> References: <69d83eac-3ba9-fef9-df2a-d2c2925df11e@oracle.com> Message-ID: <735ee5ee-56ad-3051-9bf9-e1681d5a4407@oracle.com> While I understand the point, overriding a method has never been about 'inheriting' parameter names, so I'm also kind of hopeful that the confusion can be cleared up easily. I guess the fact that when you add an override through the IDE, the IDE already prepopulates your overriding declaration with parameter names from the overidden one might throw people of into thinking that there's some 'constraint' between names in the overriding vs. overridden. Of course there's not. Maurizio On 29/07/17 15:46, Brian Goetz wrote: > As evidence of Tagir's point that people will confuse this for a > declaration-site feature, I offer this tweet of a random Java > developer who saw the blink-poll on twitter and immediately lept to > the wrong conclusion: > > https://twitter.com/wbasrs/status/891213337454940160 > > On 6/25/2017 6:51 AM, Tagir Valeev wrote: >> Hello! >> >> Currently in lambda-leftovers underscore is allowed as a parameter >> name for >> abstract methods. This looks dubious as normally underscore means that >> parameter is not used in the corresponding method/lambda/catch body, but >> there's no actual body and no parameter is actually used anyways (but >> could >> be used in abstract method implementations). I think, allowing >> underscores >> for interface methods may encorage bad practices of defining interfaces >> without readable parameter names: >> >> interface X { >> void doSomething(int _, long _, String _); >> } >> >> Should not this be disabled? >> >> It's even worse for native methods, because underscore assumes that >> parameter is not used, but it does not limit the corresponding native >> implementation from using it. >> >> With best regards, >> Tagir Valeev. >