RFR: JDK-8206981 - Compiler support for Raw String Literals

Maurizio Cimadamore maurizio.cimadamore at oracle.com
Mon Aug 27 17:48:54 UTC 2018


Ah - the @module tag in the RawStringLiteralLang test is probably 
unnecessary.

Maurizio


On 27/08/18 18:47, Maurizio Cimadamore wrote:
> Hi,
> looks very polished indeed, great work.
>
> One minor nit is that the API test could be improved by fuzzy testing 
> all raw strings literals with varying number of start/end delimiters. 
> Right now the test only checks unterminated literals where the number 
> of ending delimiters is that of starting delimiters minus one. Not 
> that I think this test will uncover a bug - looking at the tokenizer 
> code it seems it should handle that just right - but just for piece of 
> mind.
>
> Maurizio
>
>
> On 27/08/18 17:13, Jim Laskey wrote:
>> Please review the following changeset to implement raw string 
>> literals in javac as per JEP 326.
>>
>> Thank you,
>>
>> — Jim
>>
>> WEBREV: http://cr.openjdk.java.net/~jlaskey/8206981/webrev/index.html
>>
>>
>> JEP: https://bugs.openjdk.java.net/browse/JDK-8196004
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8206981
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8198986
>>
>



More information about the amber-dev mailing list