hg: amber/amber: Clean up SymRef API; more specs; more error checking

[brian.goetz at oracle.com]

Changeset: 143342743eb6
Author:    briangoetz
Date:      2018-02-07 09:19 -0500
URL:       http://hg.openjdk.java.net/amber/amber/rev/143342743eb6

Clean up SymRef API; more specs; more error checking

! make/CompileJavaModules.gmk
! src/java.base/share/classes/java/lang/Class.java
! src/java.base/share/classes/java/lang/invoke/Intrinsics.java
! src/java.base/share/classes/java/lang/invoke/LambdaMetafactory.java
! src/java.base/share/classes/java/lang/invoke/MethodHandle.java
! src/java.base/share/classes/java/lang/invoke/MethodType.java
! src/java.base/share/classes/java/lang/sym/ClassRef.java
! src/java.base/share/classes/java/lang/sym/Constable.java
+ src/java.base/share/classes/java/lang/sym/DynamicCallSiteRef.java
! src/java.base/share/classes/java/lang/sym/DynamicConstantRef.java
! src/java.base/share/classes/java/lang/sym/EnumRef.java
- src/java.base/share/classes/java/lang/sym/IndyRef.java
! src/java.base/share/classes/java/lang/sym/MethodHandleRef.java
! src/java.base/share/classes/java/lang/sym/MethodTypeRef.java
! src/java.base/share/classes/java/lang/sym/SymbolicRef.java
! src/java.base/share/classes/java/lang/sym/SymbolicRefs.java
! src/java.base/share/classes/java/lang/sym/VarHandleRef.java
+ src/java.base/share/classes/java/lang/sym/package-info.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ConstablesVisitor.java
! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Constables.java
! test/jdk/java/lang/invoke/ConstantRefBootstrapsTest.java
! test/jdk/java/lang/sym/ClassRefTest.java
+ test/jdk/java/lang/sym/CondyRefTest.java
- test/jdk/java/lang/sym/DynamicConstantRefTest.java
! test/jdk/java/lang/sym/IntrinsifiedRefTest.java
! test/jdk/java/lang/sym/MethodHandleRefTest.java
! test/jdk/java/lang/sym/SymbolicRefTest.java
! test/langtools/tools/javac/specialConstantFolding/CondyCodeGenerationTest.java
! test/langtools/tools/javac/specialConstantFolding/IndyCodeGenerationTest.java
! test/langtools/tools/javac/specialConstantFolding/IndyCrashTest.java
! test/langtools/tools/javac/specialConstantFolding/IndyLinkageErrorTest.java
! test/langtools/tools/javac/specialConstantFolding/IndyNegativeTest01.java
! test/langtools/tools/javac/specialConstantFolding/IndyPositiveTest01.java
! test/langtools/tools/javac/specialConstantFolding/IntrinsicsTest.java
! test/langtools/tools/javac/specialConstantFolding/MultipleBSMEntriesTest.java