hg: amber/amber: Move symbolic ref classes from JLI to java.lang.sym; rename ConstantRef to SymbolicRef; reincarnate Constable as 'can be represented with a symbolic ref'; support canonicalization of known bootstraps in DynamicConstantRef

[Brian Goetz]

Yes, it looks like this file got left out of the commit.  BTW, this is 
not a "rename" of Constable, it's actually a redefinition of what the 
Constable abstraction means.  Before, we used Constable to mean 
"symbolic symbolic to constant", but now we're using SymbolicRef for 
that.  Constable now means "a live object for which a symbolic reference 
can be constructed", like Class or MethodType.  This is much more in 
line with what it sounds like -- "const-able" -- something that can be 
described by a constant.

On 12/25/2017 2:51 AM, Ali Ebrahimi wrote:
> Hi,
> Is moved java.lang.invoke.Constable to java.lang.sym.Constable? If so, 
> I don't see that file in your commit. we have build error.
>
> On Fri, Dec 22, 2017 at 9:40 PM, <brian.goetz at oracle.com 
> <mailto:brian.goetz at oracle.com>> wrote:
>
>     Changeset: 534504612399
>     Author:    briangoetz
>     Date:      2017-12-22 13:06 -0500
>     URL: http://hg.openjdk.java.net/amber/amber/rev/534504612399
>     <http://hg.openjdk.java.net/amber/amber/rev/534504612399>
>
>     Move symbolic ref classes from JLI to java.lang.sym; rename
>     ConstantRef to SymbolicRef; reincarnate Constable as 'can be
>     represented with a symbolic ref'; support canonicalization of
>     known bootstraps in DynamicConstantRef
>
>     ! make/CompileJavaModules.gmk
>     ! src/java.base/share/classes/java/lang/Class.java
>     ! src/java.base/share/classes/java/lang/Double.java
>     ! src/java.base/share/classes/java/lang/Enum.java
>     ! src/java.base/share/classes/java/lang/Float.java
>     ! src/java.base/share/classes/java/lang/Integer.java
>     ! src/java.base/share/classes/java/lang/Long.java
>     ! src/java.base/share/classes/java/lang/String.java
>     !
>     src/java.base/share/classes/java/lang/annotation/TrackableConstant.java
>     - src/java.base/share/classes/java/lang/invoke/BootstrapSpecifier.java
>     - src/java.base/share/classes/java/lang/invoke/ClassRef.java
>     - src/java.base/share/classes/java/lang/invoke/Constables.java
>     ! src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java
>     - src/java.base/share/classes/java/lang/invoke/ConstantRef.java
>     - src/java.base/share/classes/java/lang/invoke/DynamicConstantRef.java
>     ! src/java.base/share/classes/java/lang/invoke/Intrinsics.java
>     ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java
>     - src/java.base/share/classes/java/lang/invoke/MethodHandleRef.java
>     ! src/java.base/share/classes/java/lang/invoke/MethodType.java
>     - src/java.base/share/classes/java/lang/invoke/MethodTypeRef.java
>     + src/java.base/share/classes/java/lang/sym/BootstrapSpecifier.java
>     + src/java.base/share/classes/java/lang/sym/ClassRef.java
>     + src/java.base/share/classes/java/lang/sym/DynamicConstantRef.java
>     + src/java.base/share/classes/java/lang/sym/EnumRef.java
>     + src/java.base/share/classes/java/lang/sym/MethodHandleRef.java
>     + src/java.base/share/classes/java/lang/sym/MethodTypeRef.java
>     + src/java.base/share/classes/java/lang/sym/NamedClassRef.java
>     + src/java.base/share/classes/java/lang/sym/PrimitiveClassRef.java
>     + src/java.base/share/classes/java/lang/sym/SymbolicRef.java
>     + src/java.base/share/classes/java/lang/sym/SymbolicRefs.java
>     ! src/java.base/share/classes/module-info.java
>     ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java
>     !
>     src/jdk.compiler/share/classes/com/sun/tools/javac/util/Constables.java
>     ! test/jdk/java/lang/invoke/ConstablesTest.java
>     ! test/jdk/java/lang/invoke/ConstantRefBootstrapsTest.java
>     ! test/jdk/java/lang/invoke/IntrinsicsTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/CondyCodeGenerationTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/CrashWithPrimitiveArgumentsTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/DontCompileIfSymbolCantBeFoundTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/EffectivelyFinalTestNeg.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/IndyCodeGenerationTest.java
>     ! test/langtools/tools/javac/specialConstantFolding/IndyCrashTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/IndyLinkageErrorTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/IndyNegativeTest01.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/IndyPositiveTest01.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/LDCNegativeTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/MultipleBSMEntriesTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/ReflectiveErrorTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/ReflectiveErrorTest.out
>     !
>     test/langtools/tools/javac/specialConstantFolding/ReportIncorrectMHForIndyTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/ConstantDefinitions.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/ConstantFoldingOfMethodTypeDiffContextsTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/ConstantPropagationTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/EffectivelyFinalTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindConstructorTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindGetterTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindMethodWithGenericArgumentsTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindSetterTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindStaticGetterTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindStaticSetterTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindStaticTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindVirtualTest01.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/FindVirtualTest02.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/InstanceTrackableMethodsTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/harness/tests/StringFoldingTest.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/warningNotFoundOrIncorrect/WarningIfClassOrMemberNotFound.java
>     !
>     test/langtools/tools/javac/specialConstantFolding/warningNotFoundOrIncorrect/WarningIfMemberIncorrect.java
>
>
>
>
> -- 
>
> Best Regards,
> Ali Ebrahimi