From vicente.romero at oracle.com Fri Mar 1 03:04:06 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Thu, 28 Feb 2019 22:04:06 -0500 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> Message-ID: On 2/28/19 6:08 PM, Brian Goetz wrote: > So, the realistic cases for Objects::hash are where there are a handful (3-5) of mixed strings and ints. The data we have omits these cases ? could we run a few of them? I have added some additional experiments, please see [1]. In the test names where it says `Reference`, it is referring to a String [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v2.html > > Barring some better numbers on these, it seems the sweet spot is to do String::format but not bother with hash? > >> On Feb 28, 2019, at 5:59 PM, Vicente Romero wrote: >> >> Hi all, >> >> I have done some additional experiments, please see the results at [1]. This document contains a summary of all the experiments done so far. I re-ran the experiments, so some numbers can vary compared to previous data. The first two tables are comparing 3 different implementations: >> >> 1. JDK13 vanilla, >> 2. Intrinsics using loop combinators for producing the callsite for >> Objects::hash, I sent yesterday a patch that implements the loop >> combinators, >> 3. and the current intrinsics tip at [2] >> >> The last table has the results for String::format and as the loop combinators implementation doesn't affect that callsite, I didn't include any results in its corresponding column. This table is provided for completeness only. >> >> The interesting thing is that both intrinsics implementations seem to defeat the other for different types: >> >> * the loop combinators implementation is faster hashing `int` >> variables, see row starting with >> `IntrinsicsBenchmark.testHash100IntVariables` in the first table >> * while the implementation at tip is faster when hashing strings, see >> the next row in the same table and second table which is completely >> dedicated to string hashing. >> >> For both implementations there is a cliff somewhere between 60 and 70 strings, see second table, but it is steeper for the loop combinators implementation. Anyways it could be that massaging the implementations one of them could prove to be significantly better than the other for all types. So I will keep them both for a while to experiment a bit more with them, >> >> Thanks, >> Vicente >> >> [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data.html >> [2] http://hg.openjdk.java.net/amber/amber branch intrinsics-project >> >> On 2/28/19 8:12 AM, Vicente Romero wrote: >>> >>> On 2/27/19 8:18 PM, Alex Buckley wrote: >>>> Believing that the second column is intended to be "Intrinsics_02_26", not "Intrinsics_02_22": >>> that's correct sorry for the mistake on the column naming >>> >>>> The speedups for reference variables get worse with more arguments (though they may still be faster than vanilla invocation for a good while), and the speedups for primitive variables get better with more arguments. >>>> >>>> One metric is how many variables can be passed and still have intrinsification offer a speedup relative to vanilla invocation. (The cliff between 60 and 70.) Another metric is how many variables can be passed before the speedup stops growing, even if intrinsification is always faster than vanilla invocation. (The global maximum of performance, between 10 and 40.) Presumably, each metric is governed by a different factor. >>> right good analysis, I will do some more research to try to see where the execution time is going to >>> >>>> Alex >>> Vicente >>> >>>> On 2/26/2019 8:28 PM, Vicente Romero wrote: >>>>> Hi all, >>>>> >>>>> I have investigated further about the degradation of the intrinsified >>>>> version Objects::hash for reference types. I have made performance >>>>> measures for different number of arguments. Please see the results >>>>> attached. At least on my PC it seems like there is a cliff from 60 to 70 >>>>> arguments. Up to 60 the intrinsified version is faster than vanilla >>>>> JDK13 but at 70 and on the intrinsified version start being slower. >>>>> Interesting, also if the current implementation starts being worst >>>>> starting at 70 non-primitive arguments, that seems like a very good >>>>> compromise. >>>>> >>>>> Thanks, >>>>> Vicente >>>>> >>>>> On 2/26/19 8:49 PM, Vicente Romero wrote: >>>>>> Hi all, >>>>>> >>>>>> I have just pushed [1] which improves the performance of the >>>>>> intrinsified version of Objects::hash in almost all of our performance >>>>>> test cases. This is a big improvement compared to the previous state >>>>>> but there is still work to be done. Please find attached a file with >>>>>> the benchmark results. It includes the performance numbers obtained >>>>>> with the intrinsics repo as of 02/22 plus the ones obtained, almost >>>>>> now :), after pushing [1]. As it can be seen there is a noticeable >>>>>> improvement in the performance. In the last performance measurement we >>>>>> found a noticeable degradation in performance for large number of >>>>>> arguments (~100), even for primitive types. Patch [1] improves the >>>>>> performance for both primitive and reference types with the difference >>>>>> that now the performance is much better than vanilla JDK13 for >>>>>> primitive types but it is still worst than vanilla for reference >>>>>> types. Although we are in better shape now compared to the state as of >>>>>> 02/22. Keep tuned :) >>>>>> >>>>>> Thanks, >>>>>> Vicente >>>>>> >>>>>> [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 >>>>>> >>>>>> On 2/22/19 4:46 PM, Vicente Romero wrote: >>>>>>> Hi, >>>>>>> >>>>>>> To complete the picture please find attached the performance results >>>>>>> for Objects.hash for a number of experiments. In general they don't >>>>>>> look as good as the ones for String::format. In general it seems like >>>>>>> there is no much gain unless the number of parameters is large and >>>>>>> all the parameters are constants. This is understandable because the >>>>>>> compiler generates an LDC of the result. In all other cases the >>>>>>> performance is just a bit better or a lot worst. >>>>>>> >>>>>>> Thanks, >>>>>>> Vicente >>>>>>> >>>>>>> On 2/22/19 12:33 PM, Vicente Romero wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> I have executed some performance tests on the intrinsics code to >>>>>>>> compare the before and after. Please find the benchmark results and >>>>>>>> the JMH based benchmark attached. This benchmark is based on a >>>>>>>> previous one written by Hannes. The benchmark compares the execution >>>>>>>> between the JDK built from [1], referred here as JDK13, and [2] >>>>>>>> which is the amber repo, branch `intrinsics-project`. >>>>>>>> >>>>>>>> Some conclusions from the benchmark results: >>>>>>>> >>>>>>>> * the intrinsified code is faster in all cases, for which >>>>>>>> intrinsified code is produced, compared to the legit (JDK13 >>>>>>>> vanilla) code >>>>>>>> * there are wide variations though >>>>>>>> >>>>>>>> For example for the test: `testStringFormatBoxedArray` which is >>>>>>>> basically benchmarking the performance of: `String.format("%s: %d ", >>>>>>>> args);` where args is: `static final Object[] args = { "Bob", i23 >>>>>>>> };`, there is basically no visible gain as in this case the >>>>>>>> intrinsification is bailing out and producing same code as vanilla >>>>>>>> JDK13. This result is expected. The next test with not so much gain >>>>>>>> is: `testStringFormat1ConstantFloat` which is testing: >>>>>>>> >>>>>>>> `String.format("%g", 1.0)` >>>>>>>> >>>>>>>> the execution is ~2.5 times faster in the intrinsified version but >>>>>>>> nothing compared to: `testStringFormat1ConstantStr` which is ~40 >>>>>>>> times faster. Another interesting conclusion is that the improvement >>>>>>>> fades out with the number of parameters for some cases but keeps >>>>>>>> constant for others. For example it is as fast to concatenate 1 or >>>>>>>> 100 strings but formating one primitive int is ~45 times faster vs a >>>>>>>> 3.5 improvement when formating a hundred. >>>>>>>> >>>>>>>> I have also attached the table I used to play with the numbers. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> Vicente >>>>>>>> >>>>>>>> [1] http://hg.openjdk.java.net/jdk/jdk >>>>>>>> >>>>>>>> [2] http://hg.openjdk.java.net/amber/amber >>>>>>>> From amaembo at gmail.com Fri Mar 1 07:49:38 2019 From: amaembo at gmail.com (Tagir Valeev) Date: Fri, 1 Mar 2019 14:49:38 +0700 Subject: ANN Switch Expressions in IntelliJ 2019.1 EAP In-Reply-To: References: Message-ID: Hello, Brian! Thank you for evaluating the enhanced switch support in IntelliJ IDEA > cal =switch (caltype) { > case "buddhist" ->new BuddhistCalendar(zone, aLocale); > case "japanese" ->new JapaneseImperialCalendar(zone, aLocale); > case "gregory" ->new GregorianCalendar(zone, aLocale); > } > > The latter is much better style (expressions all the way down, less repetition, less error-prone). Agreed, reported: https://youtrack.jetbrains.com/issue/IDEA-208192 This works nicely if the variable is declared right before the switch. In this case switch will be moved to variable initializer. Also, as you noted, pulling return is supported. We could try to pull any common part, but it doesn't always works pretty. E.g. if all switch branches look like callSomeMethod(1, 2, 3, , 4, 5), then pulling the switch inside the arguments list is questionable. So we just support some particular scenarios. > Similarly, if each RHS is a cast to the same target, you may want to factor the cast out as well. Looks rare case (if I understand you correctly), but reported as well: https://youtrack.jetbrains.com/issue/IDEA-208193 > I noticed it didn't merge, say, WHITESPACE and WHITE_SPACE with commas; it did offer to do that as a follow-on refactor. Yes, these actions are orthogonal: branches could be merged without conversion to enhanced switch, and some people may prefer to have separate branches. E.g.: static boolean hasAppointment(DayOfWeek day) { return switch (day) { case MONDAY -> false; case TUESDAY -> true; case WEDNESDAY -> false; case THURSDAY -> true; case FRIDAY -> false; case SATURDAY -> true; case SUNDAY -> false; }; } This indeed has duplicating branches (and we suggest to merge them), but some people may prefer sorted list of days over more compact code. In this case they may disable the second inspection. Also doing both things at once (conversion to enhanced switch and merging branches) may look like too magical, so I think it's fine to have two more clear steps. > Here's one it didn't try to transform at all, even though all paths are basically "status = ..; break": > > switch (state) { > case NORMAL: > status ="[Completed normally]"; > break; > case EXCEPTIONAL: > status ="[Completed exceptionally: " +outcome +"]"; > break; > case CANCELLED: > case INTERRUPTING: > case INTERRUPTED: > status ="[Cancelled]"; > break; > default: > final Callable callable =this.callable; > status = (callable ==null) > ?"[Not completed]" :"[Not completed, task = " + callable +"]"; > } Agreed. Reported: https://youtrack.jetbrains.com/issue/IDEA-208195 > I might factor the switch refactor into two; one for expressions and one for statements. While the -> form is sometimes useful for statements, refactoring often doesn't gain nearly as much as for expressions. Separating them allows people to set them at different levels of severity. Not sure about complete separation, but we may introduce an option to not highlight switches which we cannot convert automatically to switch expression (only to switch statement). Reported: https://youtrack.jetbrains.com/issue/IDEA-208196 Thank you again! With best regards, Tagir Valeev. > > > > On 1/29/2019 12:49 PM, Anna Kozlova wrote: > > Hi all, > > > > we have initially supported switch expressions, please give it a try. > > > > The download link: https://www.jetbrains.com/idea/nextversion/ > > > > Your feedback is very welcome. > > Thanks, > > Anna > From brian.goetz at oracle.com Fri Mar 1 21:55:04 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Fri, 1 Mar 2019 16:55:04 -0500 Subject: Call for feedback -- enhanced switch Message-ID: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> We would like to promote enhanced switch to a permanent feature in Java 13. So far, the only change we are anticipating is: - change ?break value? to ?break-with value?. This is the time for people to try it out on their codebases (there?s even refactoring support in IDEA!) and provide feedback on what works, what doesn?t, and what was surprising. From scolebourne at joda.org Sat Mar 2 04:23:37 2019 From: scolebourne at joda.org (Stephen Colebourne) Date: Sat, 2 Mar 2019 04:23:37 +0000 Subject: Extending try-with-resources to open as well as close Message-ID: Following Stuart's recent core-libs-dev email [1], I wanted to discuss extensions to user-defined control abstraction. Control abstraction remains a very important alternative to lambdas, particularly for return early from a method, checked exceptions and simpler debugging/stack traces. Java's approach of calling out to a helper interface (Iterable/AutoCloseable) is reasonable enough, but definitely only covers a limited subset of use cases. What about java.util.concurrent.locks.Lock for example? Currently, it is possible to write a wrapper to work with try-with-resources [2]: try (Object ignored = new LockWrapper(lock)) { ... } Sadly, the Java 9 changes to try-with-resources don't help, as that only allows a variable, not an expression, so we can't do this via a void-returning default method on Lock: try (lock.open()) { ... } One possible amber change would be to allow arbitrary expressions in try-with-resources but I understand there are concerns with that (and its been looked at twice already). With _ representing an ignored variable, we might soon be able to get to this, which is still non-optimal but doesn't require a language change: try (var _ = lock.open()) { ... } If a new interface was added, `AutoOpenCloseable`, it would be possible to make `java.util.concurrent.locks.Lock` implement it. The try-with-resources JLS spec would also be expanded to say that if the variable passed in implements `AutoOpenCloseable` then `open()` would be called. the code necessary would then be: try (lock) { ... } This feels like a relatively simple change (looks can be deceiving of course). But are there are other use cases for wrapping open/close behaviour around code without needing to use an additional object for the opened state? thanks Stephen [1] https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-March/058780.html [2] https://stackoverflow.com/questions/6965731/are-locks-autocloseable From benjamin.john.evans at gmail.com Mon Mar 4 10:24:16 2019 From: benjamin.john.evans at gmail.com (Ben Evans) Date: Mon, 4 Mar 2019 11:24:16 +0100 Subject: Call for feedback -- enhanced switch In-Reply-To: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> Message-ID: Hi Brian, Can you explain the urgency here? If this is going to be a permanent feature as of Java 13, the deadline for confirming that is surely months away, and I thought that one of the points of Preview Features was that the promotion to permanent was supposed to be a quick flick of the switch (no pun intended). On the other hand, Java 12 isn't even out yet! So no-one who isn't an avid early adopter, or subscribed to this group (& I posit that we're not exactly normal Java developers, for the most part) has tried this feature in anger. As Martijn pointed out, this feature has just landed in the nightly builds of IntelliJ - perhaps Trish or one of the other JetBrains folks can give us an idea of how many downloads they see for the nightlies? - that might give us some idea of how many developers have actually tried out the feature (although, of course, they are still a self-selecting early adopter group). Thanks, Ben On Fri, 1 Mar 2019 at 22:55, Brian Goetz wrote: > > We would like to promote enhanced switch to a permanent feature in Java 13. So far, the only change we are anticipating is: > > - change ?break value? to ?break-with value?. > > This is the time for people to try it out on their codebases (there?s even refactoring support in IDEA!) and provide feedback on what works, what doesn?t, and what was surprising. > > From vicente.romero at oracle.com Mon Mar 4 17:16:06 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 04 Mar 2019 17:16:06 +0000 Subject: hg: amber/amber: better exception capturing for String::format Message-ID: <201903041716.x24HG64v002174@aojmv0008.oracle.com> Changeset: a0a3f9977a7c Author: hannesw Date: 2019-03-04 12:10 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/a0a3f9977a7c better exception capturing for String::format ! src/java.base/share/classes/java/lang/invoke/FormatterBootstraps.java ! src/java.base/share/classes/java/util/IllegalFormatException.java ! test/jdk/java/util/Formatter/FormatLocale.java ! test/jdk/java/util/Formatter/JavacIntrinsicsSupport.java ! test/jdk/java/util/Formatter/JavacIntrinsicsTest.java From brian.goetz at oracle.com Mon Mar 4 20:06:46 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Mon, 4 Mar 2019 20:06:46 +0000 Subject: Preview dynamics (was: Call for feedback -- enhanced switch) In-Reply-To: References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> Message-ID: <7273FA1F-55CA-4C82-B21C-8AF22720E317@oracle.com> > On Mar 4, 2019, at 10:24 AM, Ben Evans wrote: > > Hi Brian, > > Can you explain the urgency here? This could be one of two questions: - What is the urgency for promoting switch expressions to permanent in 13? or - What is the urgency for getting feedback so quickly, the window for 13 doesn?t close for a while? I suspect you mean the latter, but let me address the former briefly. The motivation here is obvious: if we think the feature is good, we want people to be able to use it as soon as is practical. If we have to go through TWO rounds of preview, that means it is at least 15 months from the time the work is ready to push to the time people can gain value from it. Assuming you agree that 13 is a reasonable target, let me address the second. It may seem like there is ?plenty of time?, but let?s work backwards from the deadline. The ?feature freeze? for Java 13 is mid-June. That?s only 3-ish months away. In order to make the feature permanent, we need to file a JEP for this. That?s simple, but there are some lead-times in various JEP transitions (time for comment, etc), and we don?t really want to be pushing on the very last day. There are code change to make the feature permanent; there are spec changes to move the feature description to the main body of the spec. These take some time to prepare. And that?s all in the case where everything is perfect, and we have to ?just push the button.? But, what if there is nontrivial feedback? We will need time to act on it, and either (a) decide we are not going to permanent status for 13, or (b) try to address the issues, resulting in changes. These will take time to discuss, decide, implement, test, and push. The reality is that the window for feedback, should we want to only have one round of preview, is pretty narrow. Hence, the timing of this memo: it would be really great if we got feedback NOW, rather than three months from now (when we?re already staring at a deadline.) You may reply to all this ?one round of preview is too short to get meaningful feedback.? And you might be right; it is pretty short. On the other hand, making people wait 15 months for a feature that is ?probably done? is pretty long. Not clear which is worse. > If this is going to be a permanent feature as of Java 13, the deadline > for confirming that is surely months away, and I thought that one of > the points of Preview Features was that the promotion to permanent was > supposed to be a quick flick of the switch (no pun intended). > > On the other hand, Java 12 isn't even out yet! So no-one who isn't an > avid early adopter, or subscribed to this group (& I posit that we're > not exactly normal Java developers, for the most part) has tried this > feature in anger. > > As Martijn pointed out, this feature has just landed in the nightly > builds of IntelliJ - perhaps Trish or one of the other JetBrains folks > can give us an idea of how many downloads they see for the nightlies? > - that might give us some idea of how many developers have actually > tried out the feature (although, of course, they are still a > self-selecting early adopter group). > > Thanks, > > Ben > > On Fri, 1 Mar 2019 at 22:55, Brian Goetz wrote: >> >> We would like to promote enhanced switch to a permanent feature in Java 13. So far, the only change we are anticipating is: >> >> - change ?break value? to ?break-with value?. >> >> This is the time for people to try it out on their codebases (there?s even refactoring support in IDEA!) and provide feedback on what works, what doesn?t, and what was surprising. >> >> From vicente.romero at oracle.com Tue Mar 5 00:28:22 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Mon, 4 Mar 2019 19:28:22 -0500 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> Message-ID: <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> Hi, I have uploaded another round of experiments for Objects::hash, see [1]. The main variation I have included a variant of most of the tests in which instead of invoking Objects::hash 10 times sequentially, the same invocation occurs inside a loop which is executed 10 times. This shows that when the call site is reused, the execution time trumps vanilla JDK13 most of the time. This adds another aspect to the intrinsification of Objects::hash but there is still an open question: should the intrinsics project include Objects::hash or should we go only with String::format? Please share your feedback on this, Vicente [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v3.html On 2/28/19 6:08 PM, Brian Goetz wrote: > So, the realistic cases for Objects::hash are where there are a handful (3-5) of mixed strings and ints. The data we have omits these cases ? could we run a few of them? > > Barring some better numbers on these, it seems the sweet spot is to do String::format but not bother with hash? > >> On Feb 28, 2019, at 5:59 PM, Vicente Romero wrote: >> >> Hi all, >> >> I have done some additional experiments, please see the results at [1]. This document contains a summary of all the experiments done so far. I re-ran the experiments, so some numbers can vary compared to previous data. The first two tables are comparing 3 different implementations: >> >> 1. JDK13 vanilla, >> 2. Intrinsics using loop combinators for producing the callsite for >> Objects::hash, I sent yesterday a patch that implements the loop >> combinators, >> 3. and the current intrinsics tip at [2] >> >> The last table has the results for String::format and as the loop combinators implementation doesn't affect that callsite, I didn't include any results in its corresponding column. This table is provided for completeness only. >> >> The interesting thing is that both intrinsics implementations seem to defeat the other for different types: >> >> * the loop combinators implementation is faster hashing `int` >> variables, see row starting with >> `IntrinsicsBenchmark.testHash100IntVariables` in the first table >> * while the implementation at tip is faster when hashing strings, see >> the next row in the same table and second table which is completely >> dedicated to string hashing. >> >> For both implementations there is a cliff somewhere between 60 and 70 strings, see second table, but it is steeper for the loop combinators implementation. Anyways it could be that massaging the implementations one of them could prove to be significantly better than the other for all types. So I will keep them both for a while to experiment a bit more with them, >> >> Thanks, >> Vicente >> >> [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data.html >> [2] http://hg.openjdk.java.net/amber/amber branch intrinsics-project >> >> On 2/28/19 8:12 AM, Vicente Romero wrote: >>> >>> On 2/27/19 8:18 PM, Alex Buckley wrote: >>>> Believing that the second column is intended to be "Intrinsics_02_26", not "Intrinsics_02_22": >>> that's correct sorry for the mistake on the column naming >>> >>>> The speedups for reference variables get worse with more arguments (though they may still be faster than vanilla invocation for a good while), and the speedups for primitive variables get better with more arguments. >>>> >>>> One metric is how many variables can be passed and still have intrinsification offer a speedup relative to vanilla invocation. (The cliff between 60 and 70.) Another metric is how many variables can be passed before the speedup stops growing, even if intrinsification is always faster than vanilla invocation. (The global maximum of performance, between 10 and 40.) Presumably, each metric is governed by a different factor. >>> right good analysis, I will do some more research to try to see where the execution time is going to >>> >>>> Alex >>> Vicente >>> >>>> On 2/26/2019 8:28 PM, Vicente Romero wrote: >>>>> Hi all, >>>>> >>>>> I have investigated further about the degradation of the intrinsified >>>>> version Objects::hash for reference types. I have made performance >>>>> measures for different number of arguments. Please see the results >>>>> attached. At least on my PC it seems like there is a cliff from 60 to 70 >>>>> arguments. Up to 60 the intrinsified version is faster than vanilla >>>>> JDK13 but at 70 and on the intrinsified version start being slower. >>>>> Interesting, also if the current implementation starts being worst >>>>> starting at 70 non-primitive arguments, that seems like a very good >>>>> compromise. >>>>> >>>>> Thanks, >>>>> Vicente >>>>> >>>>> On 2/26/19 8:49 PM, Vicente Romero wrote: >>>>>> Hi all, >>>>>> >>>>>> I have just pushed [1] which improves the performance of the >>>>>> intrinsified version of Objects::hash in almost all of our performance >>>>>> test cases. This is a big improvement compared to the previous state >>>>>> but there is still work to be done. Please find attached a file with >>>>>> the benchmark results. It includes the performance numbers obtained >>>>>> with the intrinsics repo as of 02/22 plus the ones obtained, almost >>>>>> now :), after pushing [1]. As it can be seen there is a noticeable >>>>>> improvement in the performance. In the last performance measurement we >>>>>> found a noticeable degradation in performance for large number of >>>>>> arguments (~100), even for primitive types. Patch [1] improves the >>>>>> performance for both primitive and reference types with the difference >>>>>> that now the performance is much better than vanilla JDK13 for >>>>>> primitive types but it is still worst than vanilla for reference >>>>>> types. Although we are in better shape now compared to the state as of >>>>>> 02/22. Keep tuned :) >>>>>> >>>>>> Thanks, >>>>>> Vicente >>>>>> >>>>>> [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 >>>>>> >>>>>> On 2/22/19 4:46 PM, Vicente Romero wrote: >>>>>>> Hi, >>>>>>> >>>>>>> To complete the picture please find attached the performance results >>>>>>> for Objects.hash for a number of experiments. In general they don't >>>>>>> look as good as the ones for String::format. In general it seems like >>>>>>> there is no much gain unless the number of parameters is large and >>>>>>> all the parameters are constants. This is understandable because the >>>>>>> compiler generates an LDC of the result. In all other cases the >>>>>>> performance is just a bit better or a lot worst. >>>>>>> >>>>>>> Thanks, >>>>>>> Vicente >>>>>>> >>>>>>> On 2/22/19 12:33 PM, Vicente Romero wrote: >>>>>>>> Hi, >>>>>>>> >>>>>>>> I have executed some performance tests on the intrinsics code to >>>>>>>> compare the before and after. Please find the benchmark results and >>>>>>>> the JMH based benchmark attached. This benchmark is based on a >>>>>>>> previous one written by Hannes. The benchmark compares the execution >>>>>>>> between the JDK built from [1], referred here as JDK13, and [2] >>>>>>>> which is the amber repo, branch `intrinsics-project`. >>>>>>>> >>>>>>>> Some conclusions from the benchmark results: >>>>>>>> >>>>>>>> * the intrinsified code is faster in all cases, for which >>>>>>>> intrinsified code is produced, compared to the legit (JDK13 >>>>>>>> vanilla) code >>>>>>>> * there are wide variations though >>>>>>>> >>>>>>>> For example for the test: `testStringFormatBoxedArray` which is >>>>>>>> basically benchmarking the performance of: `String.format("%s: %d ", >>>>>>>> args);` where args is: `static final Object[] args = { "Bob", i23 >>>>>>>> };`, there is basically no visible gain as in this case the >>>>>>>> intrinsification is bailing out and producing same code as vanilla >>>>>>>> JDK13. This result is expected. The next test with not so much gain >>>>>>>> is: `testStringFormat1ConstantFloat` which is testing: >>>>>>>> >>>>>>>> `String.format("%g", 1.0)` >>>>>>>> >>>>>>>> the execution is ~2.5 times faster in the intrinsified version but >>>>>>>> nothing compared to: `testStringFormat1ConstantStr` which is ~40 >>>>>>>> times faster. Another interesting conclusion is that the improvement >>>>>>>> fades out with the number of parameters for some cases but keeps >>>>>>>> constant for others. For example it is as fast to concatenate 1 or >>>>>>>> 100 strings but formating one primitive int is ~45 times faster vs a >>>>>>>> 3.5 improvement when formating a hundred. >>>>>>>> >>>>>>>> I have also attached the table I used to play with the numbers. >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> Vicente >>>>>>>> >>>>>>>> [1] http://hg.openjdk.java.net/jdk/jdk >>>>>>>> >>>>>>>> [2] http://hg.openjdk.java.net/amber/amber >>>>>>>> From alex.buckley at oracle.com Tue Mar 5 01:11:13 2019 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 04 Mar 2019 17:11:13 -0800 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> Message-ID: <5C7DCCB1.5010709@oracle.com> // Adopting a zero-decimal-places policy because precision to multiple decimal places is less important than accuracy and repeatability. On 3/4/2019 4:28 PM, Vicente Romero wrote: > I have uploaded another round of experiments for Objects::hash, see [1]. > The main variation I have included a variant of most of the tests in > which instead of invoking Objects::hash 10 times sequentially, the same > invocation occurs inside a loop which is executed 10 times. This shows > that when the call site is reused, the execution time trumps vanilla > JDK13 most of the time. That's not really the story though :-) Yes, the *Int*StringsLoop10 tests run faster with intrinsified invocation than with vanilla invocation, but generally, the *Int*StringsLoop10 tests enjoy less impressive speedups than the *Int*Strings tests. (Example: 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) This is because the *Int*StringsLoop10 tests already run faster on vanilla JDK 13 than the *Int*Strings tests, presumably thanks to inlining ("the call site is reused"). I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would have such high throughput on vanilla JDK 13 that their speedups with intrinsification might be significantly <1. Alex From vicente.romero at oracle.com Tue Mar 5 02:52:24 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Mon, 4 Mar 2019 21:52:24 -0500 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <5C7DCCB1.5010709@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> Message-ID: <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> On 3/4/19 8:11 PM, Alex Buckley wrote: > // Adopting a zero-decimal-places policy because precision to multiple > decimal places is less important than accuracy and repeatability. > > On 3/4/2019 4:28 PM, Vicente Romero wrote: >> I have uploaded another round of experiments for Objects::hash, see [1]. >> The main variation I have included a variant of most of the tests in >> which instead of invoking Objects::hash 10 times sequentially, the same >> invocation occurs inside a loop which is executed 10 times. This shows >> that when the call site is reused, the execution time trumps vanilla >> JDK13 most of the time. > > That's not really the story though :-) Yes, the *Int*StringsLoop10 > tests run faster with intrinsified invocation than with vanilla > invocation, but generally, the *Int*StringsLoop10 tests enjoy less > impressive speedups than the *Int*Strings tests. (Example: > 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets > a 2x speedup.) > > This is because the *Int*StringsLoop10 tests already run faster on > vanilla JDK 13 than the *Int*Strings tests, presumably thanks to > inlining ("the call site is reused"). > > I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would > have such high throughput on vanilla JDK 13 that their speedups with > intrinsification might be significantly <1. not in all cases, see [1] the new information is highlighted in yellow > > Alex Vicente [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html From hannes.wallnoefer at oracle.com Tue Mar 5 14:02:30 2019 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Tue, 5 Mar 2019 15:02:30 +0100 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> Message-ID: <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> Vicente, could it be that your your change in Object::hash bootstraps[1] mostly benefits invocations with very large numbers of parameters (like your original 100 parameter tests) but hurts performance with medium-to-lower number of parameters? I don?t have your latest benchmark sources, but I did some quick tests such as a testHash5Ints5Strings that suggest that may be the case. [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 Hannes > Am 05.03.2019 um 03:52 schrieb Vicente Romero : > > > > On 3/4/19 8:11 PM, Alex Buckley wrote: >> // Adopting a zero-decimal-places policy because precision to multiple decimal places is less important than accuracy and repeatability. >> >> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>> I have uploaded another round of experiments for Objects::hash, see [1]. >>> The main variation I have included a variant of most of the tests in >>> which instead of invoking Objects::hash 10 times sequentially, the same >>> invocation occurs inside a loop which is executed 10 times. This shows >>> that when the call site is reused, the execution time trumps vanilla >>> JDK13 most of the time. >> >> That's not really the story though :-) Yes, the *Int*StringsLoop10 tests run faster with intrinsified invocation than with vanilla invocation, but generally, the *Int*StringsLoop10 tests enjoy less impressive speedups than the *Int*Strings tests. (Example: 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) >> >> This is because the *Int*StringsLoop10 tests already run faster on vanilla JDK 13 than the *Int*Strings tests, presumably thanks to inlining ("the call site is reused"). >> >> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would have such high throughput on vanilla JDK 13 that their speedups with intrinsification might be significantly <1. > > not in all cases, see [1] the new information is highlighted in yellow >> >> Alex > > Vicente > > [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html From vicente.romero at oracle.com Tue Mar 5 15:31:14 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 5 Mar 2019 10:31:14 -0500 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> Message-ID: On 3/5/19 9:02 AM, Hannes Walln?fer wrote: > Vicente, > > could it be that your your change in Object::hash bootstraps[1] mostly benefits invocations with very large numbers of parameters (like your original 100 parameter tests) but hurts performance with medium-to-lower number of parameters? I don?t have your latest benchmark sources, but I did some quick tests such as a testHash5Ints5Strings that suggest that may be the case. that could be, but the intrinsified version is still faster for those cases with small number of arguments. That's probably why I have focused on the larger number of argument case but we can change priorities or even have different callsites depending on the number of arguments > > [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 > > Hannes Vicente > > >> Am 05.03.2019 um 03:52 schrieb Vicente Romero : >> >> >> >> On 3/4/19 8:11 PM, Alex Buckley wrote: >>> // Adopting a zero-decimal-places policy because precision to multiple decimal places is less important than accuracy and repeatability. >>> >>> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>>> I have uploaded another round of experiments for Objects::hash, see [1]. >>>> The main variation I have included a variant of most of the tests in >>>> which instead of invoking Objects::hash 10 times sequentially, the same >>>> invocation occurs inside a loop which is executed 10 times. This shows >>>> that when the call site is reused, the execution time trumps vanilla >>>> JDK13 most of the time. >>> That's not really the story though :-) Yes, the *Int*StringsLoop10 tests run faster with intrinsified invocation than with vanilla invocation, but generally, the *Int*StringsLoop10 tests enjoy less impressive speedups than the *Int*Strings tests. (Example: 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) >>> >>> This is because the *Int*StringsLoop10 tests already run faster on vanilla JDK 13 than the *Int*Strings tests, presumably thanks to inlining ("the call site is reused"). >>> >>> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would have such high throughput on vanilla JDK 13 that their speedups with intrinsification might be significantly <1. >> not in all cases, see [1] the new information is highlighted in yellow >>> Alex >> Vicente >> >> [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html From vicente.romero at oracle.com Tue Mar 5 16:20:07 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 05 Mar 2019 16:20:07 +0000 Subject: hg: amber/amber: initial push records-and-sealed branch Message-ID: <201903051620.x25GK7ow005165@aojmv0008.oracle.com> Changeset: 70fef0ba737b Author: vromero Date: 2019-03-05 11:19 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/70fef0ba737b initial push records-and-sealed branch From vicente.romero at oracle.com Tue Mar 5 17:09:44 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 05 Mar 2019 17:09:44 +0000 Subject: hg: amber/amber: setting branch dependencies Message-ID: <201903051709.x25H9jvh005609@aojmv0008.oracle.com> Changeset: abcc08cc8900 Author: vromero Date: 2019-03-05 12:09 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/abcc08cc8900 setting branch dependencies + deps.txt From maurizio.cimadamore at oracle.com Tue Mar 5 17:16:02 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 05 Mar 2019 17:16:02 +0000 Subject: hg: amber/amber: Automatic merge with sealed Message-ID: <201903051716.x25HG2oe009515@aojmv0008.oracle.com> Changeset: 031e05726d23 Author: mcimadamore Date: 2019-03-05 18:15 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/031e05726d23 Automatic merge with sealed From vicente.romero at oracle.com Tue Mar 5 18:09:01 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 05 Mar 2019 18:09:01 +0000 Subject: hg: amber/amber: manual merge with default Message-ID: <201903051809.x25I91pL011914@aojmv0008.oracle.com> Changeset: b2fae9195c80 Author: vromero Date: 2019-03-05 13:08 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/b2fae9195c80 manual merge with default ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/systemDictionary.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp - src/hotspot/share/prims/evmCompat.cpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotatedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationDesc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationValue.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ClassDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ConstructorDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/DocErrorReporter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doclet.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ExecutableMemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/FieldDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/LanguageVersion.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MethodDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/PackageDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParamTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Parameter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParameterizedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ProgramElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/RootDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SeeTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SerialFieldTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SourcePosition.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Tag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ThrowsTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Type.java - src/jdk.javadoc/share/classes/com/sun/javadoc/TypeVariable.java - src/jdk.javadoc/share/classes/com/sun/javadoc/WildcardType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/Standard.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/Main.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AbstractTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotatedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationDescImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationValueImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ClassDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Comment.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ConstructorDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocEnv.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocLocale.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocletInvoker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ExecutableMemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/FieldDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavaScriptScanner.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocClassFinder.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocMemberEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTodo.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTool.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Messager.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MethodDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ModifierFilter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PackageDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParamTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterizedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PrimitiveType.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ProgramElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/RootDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SeeTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerialFieldTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerializedForm.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Start.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ThrowsTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeMaker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeVariableImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/WildcardTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Headings.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MarkerComments.java - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java - test/langtools/jdk/javadoc/lib/javadoc/tester/ShowHeadings.java - test/langtools/jdk/javadoc/tool/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/6176978/T6176978.java - test/langtools/tools/javadoc/6176978/X.java - test/langtools/tools/javadoc/6227454/Test.java - test/langtools/tools/javadoc/6942366/T6942366.java - test/langtools/tools/javadoc/6942366/Test.java - test/langtools/tools/javadoc/6942366/p/Base.java - test/langtools/tools/javadoc/6958836/Test.java - test/langtools/tools/javadoc/6964914/Error.java - test/langtools/tools/javadoc/6964914/JavacWarning.java - test/langtools/tools/javadoc/6964914/JavadocWarning.java - test/langtools/tools/javadoc/6964914/Test.java - test/langtools/tools/javadoc/6964914/TestStdDoclet.java - test/langtools/tools/javadoc/6964914/TestUserDoclet.java - test/langtools/tools/javadoc/8025693/Test.java - test/langtools/tools/javadoc/8147801/T8147801.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib1.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib2.java - test/langtools/tools/javadoc/8147801/p/Test.java - test/langtools/tools/javadoc/AddOpensTest.java - test/langtools/tools/javadoc/BadOptionsTest.java - test/langtools/tools/javadoc/BooleanConst.java - test/langtools/tools/javadoc/BreakIteratorWarning.java - test/langtools/tools/javadoc/CheckResourceKeys.java - test/langtools/tools/javadoc/CompletionError.java - test/langtools/tools/javadoc/EncodingTest.java - test/langtools/tools/javadoc/FlagsTooEarly.java - test/langtools/tools/javadoc/InlineTagsWithBraces.java - test/langtools/tools/javadoc/LangVers.java - test/langtools/tools/javadoc/MaxWarns.java - test/langtools/tools/javadoc/MethodLinks.java - test/langtools/tools/javadoc/NoStar.java - test/langtools/tools/javadoc/ReleaseOption.java - test/langtools/tools/javadoc/ReleaseOptionSource.java - test/langtools/tools/javadoc/T4994049/FileWithTabs.java - test/langtools/tools/javadoc/T4994049/T4994049.java - test/langtools/tools/javadoc/T6968833.java - test/langtools/tools/javadoc/XWerror.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/Main.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/expected.out - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/B.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/E.java - test/langtools/tools/javadoc/annotations/annotatePackage/Main.java - test/langtools/tools/javadoc/annotations/annotatePackage/expected.out - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package-info.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package.html - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/B.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/package.html - test/langtools/tools/javadoc/annotations/annotateParams/Main.java - test/langtools/tools/javadoc/annotations/annotateParams/expected.out - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/C.java - test/langtools/tools/javadoc/annotations/badVals/Main.java - test/langtools/tools/javadoc/annotations/badVals/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/Main.java - test/langtools/tools/javadoc/annotations/defaults/expected.out - test/langtools/tools/javadoc/annotations/defaults/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/pkg1/B.java - test/langtools/tools/javadoc/annotations/elementTypes/Main.java - test/langtools/tools/javadoc/annotations/elementTypes/expected.out - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/A.java - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/B.java - test/langtools/tools/javadoc/annotations/missing/Main.java - test/langtools/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java - test/langtools/tools/javadoc/annotations/shortcuts/Main.java - test/langtools/tools/javadoc/annotations/shortcuts/expected.out - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/A.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Array.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Marker.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Value.java - test/langtools/tools/javadoc/api/basic/APITest.java - test/langtools/tools/javadoc/api/basic/DocletPathTest.java - test/langtools/tools/javadoc/api/basic/DocumentationToolLocationTest.java - test/langtools/tools/javadoc/api/basic/GetSourceVersionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DiagListenerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileManagerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileObjectsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_OptionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_WriterTest.java - test/langtools/tools/javadoc/api/basic/Task_reuseTest.java - test/langtools/tools/javadoc/api/basic/pkg/C.java - test/langtools/tools/javadoc/api/basic/taglets/UnderlineTaglet.java - test/langtools/tools/javadoc/completionFailure/CompletionFailure.java - test/langtools/tools/javadoc/completionFailure/pkg/A.java - test/langtools/tools/javadoc/completionFailure/pkg/B.java - test/langtools/tools/javadoc/dupOk/DupOk.java - test/langtools/tools/javadoc/dupOk/sp1/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/B.java - test/langtools/tools/javadoc/enum/docComments/Main.java - test/langtools/tools/javadoc/enum/docComments/pkg1/Operation.java - test/langtools/tools/javadoc/enum/enumType/Main.java - test/langtools/tools/javadoc/enum/enumType/expected.out - test/langtools/tools/javadoc/enum/enumType/pkg1/QuotablePerson.java - test/langtools/tools/javadoc/generics/genericClass/Main.java - test/langtools/tools/javadoc/generics/genericClass/expected.out - test/langtools/tools/javadoc/generics/genericClass/pkg1/A.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/Main.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/expected.out - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/O.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/X.java - test/langtools/tools/javadoc/generics/genericInterface/Main.java - test/langtools/tools/javadoc/generics/genericInterface/expected.out - test/langtools/tools/javadoc/generics/genericInterface/pkg1/A.java - test/langtools/tools/javadoc/generics/genericMethod/Main.java - test/langtools/tools/javadoc/generics/genericMethod/expected.out - test/langtools/tools/javadoc/generics/genericMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/genericSuper/Main.java - test/langtools/tools/javadoc/generics/genericSuper/expected.out - test/langtools/tools/javadoc/generics/genericSuper/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/Main.java - test/langtools/tools/javadoc/generics/supertypes/expected.out - test/langtools/tools/javadoc/generics/supertypes/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/pkg1/B.java - test/langtools/tools/javadoc/generics/throwsGeneric/Main.java - test/langtools/tools/javadoc/generics/throwsGeneric/expected.out - test/langtools/tools/javadoc/generics/throwsGeneric/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamCycle/Main.java - test/langtools/tools/javadoc/generics/tparamCycle/pkg1/LikeEnum.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamTagOnType/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnType/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnType/pkg1/A.java - test/langtools/tools/javadoc/generics/wildcards/Main.java - test/langtools/tools/javadoc/generics/wildcards/expected.out - test/langtools/tools/javadoc/generics/wildcards/pkg1/A.java - test/langtools/tools/javadoc/imports/I.java - test/langtools/tools/javadoc/imports/MissingImport.java - test/langtools/tools/javadoc/lib/OldToolTester.java - test/langtools/tools/javadoc/lib/ToyDoclet.java - test/langtools/tools/javadoc/nestedClass/NestedClass.java - test/langtools/tools/javadoc/nestedClass/NestedClassB.java - test/langtools/tools/javadoc/nonConstExprs/Test.java - test/langtools/tools/javadoc/outputRedirect/Test.java - test/langtools/tools/javadoc/outputRedirect/p/OutputRedirect.java - test/langtools/tools/javadoc/parser/7091528/T7091528.java - test/langtools/tools/javadoc/parser/7091528/p/C1.java - test/langtools/tools/javadoc/parser/7091528/p/C3.java - test/langtools/tools/javadoc/parser/7091528/p/q/C2.java - test/langtools/tools/javadoc/sourceOnly/Test.java - test/langtools/tools/javadoc/sourceOnly/p/NonSource.jasm - test/langtools/tools/javadoc/sourceOnly/p/SourceOnly.java - test/langtools/tools/javadoc/sourceOption/SourceOption.java - test/langtools/tools/javadoc/sourceOption/p/LambdaConstructTest.java - test/langtools/tools/javadoc/subpackageIgnore/SubpackageIgnore.java - test/langtools/tools/javadoc/subpackageIgnore/pkg1/not-subpkg/SomeJavaFile.java - test/langtools/tools/javadoc/varArgs/Main.java - test/langtools/tools/javadoc/varArgs/expected.out - test/langtools/tools/javadoc/varArgs/pkg1/A.java From maurizio.cimadamore at oracle.com Tue Mar 5 18:21:57 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 05 Mar 2019 18:21:57 +0000 Subject: hg: amber/amber: Automatic merge with patterns-stage-1 Message-ID: <201903051821.x25ILv2P021561@aojmv0008.oracle.com> Changeset: db99258b6011 Author: mcimadamore Date: 2019-03-05 19:21 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/db99258b6011 Automatic merge with patterns-stage-1 From maurizio.cimadamore at oracle.com Tue Mar 5 18:20:29 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 05 Mar 2019 18:20:29 +0000 Subject: hg: amber/amber: Automatic merge with datum Message-ID: <201903051820.x25IKTU6018742@aojmv0008.oracle.com> Changeset: 78f16dafaf84 Author: mcimadamore Date: 2019-03-05 19:15 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/78f16dafaf84 Automatic merge with datum - src/hotspot/share/prims/evmCompat.cpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotatedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationDesc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationValue.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ClassDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ConstructorDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/DocErrorReporter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doclet.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ExecutableMemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/FieldDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/LanguageVersion.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MethodDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/PackageDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParamTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Parameter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParameterizedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ProgramElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/RootDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SeeTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SerialFieldTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SourcePosition.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Tag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ThrowsTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Type.java - src/jdk.javadoc/share/classes/com/sun/javadoc/TypeVariable.java - src/jdk.javadoc/share/classes/com/sun/javadoc/WildcardType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/Standard.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/Main.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AbstractTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotatedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationDescImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationValueImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ClassDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Comment.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ConstructorDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocEnv.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocLocale.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocletInvoker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ExecutableMemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/FieldDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavaScriptScanner.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocClassFinder.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocMemberEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTodo.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTool.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Messager.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MethodDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ModifierFilter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PackageDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParamTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterizedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PrimitiveType.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ProgramElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/RootDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SeeTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerialFieldTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerializedForm.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Start.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ThrowsTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeMaker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeVariableImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/WildcardTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Headings.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MarkerComments.java - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java - test/langtools/jdk/javadoc/lib/javadoc/tester/ShowHeadings.java - test/langtools/jdk/javadoc/tool/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/6176978/T6176978.java - test/langtools/tools/javadoc/6176978/X.java - test/langtools/tools/javadoc/6227454/Test.java - test/langtools/tools/javadoc/6942366/T6942366.java - test/langtools/tools/javadoc/6942366/Test.java - test/langtools/tools/javadoc/6942366/p/Base.java - test/langtools/tools/javadoc/6958836/Test.java - test/langtools/tools/javadoc/6964914/Error.java - test/langtools/tools/javadoc/6964914/JavacWarning.java - test/langtools/tools/javadoc/6964914/JavadocWarning.java - test/langtools/tools/javadoc/6964914/Test.java - test/langtools/tools/javadoc/6964914/TestStdDoclet.java - test/langtools/tools/javadoc/6964914/TestUserDoclet.java - test/langtools/tools/javadoc/8025693/Test.java - test/langtools/tools/javadoc/8147801/T8147801.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib1.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib2.java - test/langtools/tools/javadoc/8147801/p/Test.java - test/langtools/tools/javadoc/AddOpensTest.java - test/langtools/tools/javadoc/BadOptionsTest.java - test/langtools/tools/javadoc/BooleanConst.java - test/langtools/tools/javadoc/BreakIteratorWarning.java - test/langtools/tools/javadoc/CheckResourceKeys.java - test/langtools/tools/javadoc/CompletionError.java - test/langtools/tools/javadoc/EncodingTest.java - test/langtools/tools/javadoc/FlagsTooEarly.java - test/langtools/tools/javadoc/InlineTagsWithBraces.java - test/langtools/tools/javadoc/LangVers.java - test/langtools/tools/javadoc/MaxWarns.java - test/langtools/tools/javadoc/MethodLinks.java - test/langtools/tools/javadoc/NoStar.java - test/langtools/tools/javadoc/ReleaseOption.java - test/langtools/tools/javadoc/ReleaseOptionSource.java - test/langtools/tools/javadoc/T4994049/FileWithTabs.java - test/langtools/tools/javadoc/T4994049/T4994049.java - test/langtools/tools/javadoc/T6968833.java - test/langtools/tools/javadoc/XWerror.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/Main.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/expected.out - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/B.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/E.java - test/langtools/tools/javadoc/annotations/annotatePackage/Main.java - test/langtools/tools/javadoc/annotations/annotatePackage/expected.out - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package-info.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package.html - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/B.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/package.html - test/langtools/tools/javadoc/annotations/annotateParams/Main.java - test/langtools/tools/javadoc/annotations/annotateParams/expected.out - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/C.java - test/langtools/tools/javadoc/annotations/badVals/Main.java - test/langtools/tools/javadoc/annotations/badVals/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/Main.java - test/langtools/tools/javadoc/annotations/defaults/expected.out - test/langtools/tools/javadoc/annotations/defaults/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/pkg1/B.java - test/langtools/tools/javadoc/annotations/elementTypes/Main.java - test/langtools/tools/javadoc/annotations/elementTypes/expected.out - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/A.java - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/B.java - test/langtools/tools/javadoc/annotations/missing/Main.java - test/langtools/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java - test/langtools/tools/javadoc/annotations/shortcuts/Main.java - test/langtools/tools/javadoc/annotations/shortcuts/expected.out - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/A.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Array.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Marker.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Value.java - test/langtools/tools/javadoc/api/basic/APITest.java - test/langtools/tools/javadoc/api/basic/DocletPathTest.java - test/langtools/tools/javadoc/api/basic/DocumentationToolLocationTest.java - test/langtools/tools/javadoc/api/basic/GetSourceVersionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DiagListenerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileManagerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileObjectsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_OptionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_WriterTest.java - test/langtools/tools/javadoc/api/basic/Task_reuseTest.java - test/langtools/tools/javadoc/api/basic/pkg/C.java - test/langtools/tools/javadoc/api/basic/taglets/UnderlineTaglet.java - test/langtools/tools/javadoc/completionFailure/CompletionFailure.java - test/langtools/tools/javadoc/completionFailure/pkg/A.java - test/langtools/tools/javadoc/completionFailure/pkg/B.java - test/langtools/tools/javadoc/dupOk/DupOk.java - test/langtools/tools/javadoc/dupOk/sp1/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/B.java - test/langtools/tools/javadoc/enum/docComments/Main.java - test/langtools/tools/javadoc/enum/docComments/pkg1/Operation.java - test/langtools/tools/javadoc/enum/enumType/Main.java - test/langtools/tools/javadoc/enum/enumType/expected.out - test/langtools/tools/javadoc/enum/enumType/pkg1/QuotablePerson.java - test/langtools/tools/javadoc/generics/genericClass/Main.java - test/langtools/tools/javadoc/generics/genericClass/expected.out - test/langtools/tools/javadoc/generics/genericClass/pkg1/A.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/Main.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/expected.out - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/O.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/X.java - test/langtools/tools/javadoc/generics/genericInterface/Main.java - test/langtools/tools/javadoc/generics/genericInterface/expected.out - test/langtools/tools/javadoc/generics/genericInterface/pkg1/A.java - test/langtools/tools/javadoc/generics/genericMethod/Main.java - test/langtools/tools/javadoc/generics/genericMethod/expected.out - test/langtools/tools/javadoc/generics/genericMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/genericSuper/Main.java - test/langtools/tools/javadoc/generics/genericSuper/expected.out - test/langtools/tools/javadoc/generics/genericSuper/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/Main.java - test/langtools/tools/javadoc/generics/supertypes/expected.out - test/langtools/tools/javadoc/generics/supertypes/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/pkg1/B.java - test/langtools/tools/javadoc/generics/throwsGeneric/Main.java - test/langtools/tools/javadoc/generics/throwsGeneric/expected.out - test/langtools/tools/javadoc/generics/throwsGeneric/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamCycle/Main.java - test/langtools/tools/javadoc/generics/tparamCycle/pkg1/LikeEnum.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamTagOnType/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnType/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnType/pkg1/A.java - test/langtools/tools/javadoc/generics/wildcards/Main.java - test/langtools/tools/javadoc/generics/wildcards/expected.out - test/langtools/tools/javadoc/generics/wildcards/pkg1/A.java - test/langtools/tools/javadoc/imports/I.java - test/langtools/tools/javadoc/imports/MissingImport.java - test/langtools/tools/javadoc/lib/OldToolTester.java - test/langtools/tools/javadoc/lib/ToyDoclet.java - test/langtools/tools/javadoc/nestedClass/NestedClass.java - test/langtools/tools/javadoc/nestedClass/NestedClassB.java - test/langtools/tools/javadoc/nonConstExprs/Test.java - test/langtools/tools/javadoc/outputRedirect/Test.java - test/langtools/tools/javadoc/outputRedirect/p/OutputRedirect.java - test/langtools/tools/javadoc/parser/7091528/T7091528.java - test/langtools/tools/javadoc/parser/7091528/p/C1.java - test/langtools/tools/javadoc/parser/7091528/p/C3.java - test/langtools/tools/javadoc/parser/7091528/p/q/C2.java - test/langtools/tools/javadoc/sourceOnly/Test.java - test/langtools/tools/javadoc/sourceOnly/p/NonSource.jasm - test/langtools/tools/javadoc/sourceOnly/p/SourceOnly.java - test/langtools/tools/javadoc/sourceOption/SourceOption.java - test/langtools/tools/javadoc/sourceOption/p/LambdaConstructTest.java - test/langtools/tools/javadoc/subpackageIgnore/SubpackageIgnore.java - test/langtools/tools/javadoc/subpackageIgnore/pkg1/not-subpkg/SomeJavaFile.java - test/langtools/tools/javadoc/varArgs/Main.java - test/langtools/tools/javadoc/varArgs/expected.out - test/langtools/tools/javadoc/varArgs/pkg1/A.java From jeynoronha at gmail.com Tue Mar 5 20:28:17 2019 From: jeynoronha at gmail.com (Jeyvison Nascimento) Date: Tue, 5 Mar 2019 17:28:17 -0300 Subject: Call for feedback -- enhanced switch In-Reply-To: References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> Message-ID: Hey all. I'd like to share a few impressions from what I saw about the Enhanced switch. The JEP is really good and it makes the code a lot cleaner. I don't know if we still have time to suggest something but I'd like to suggest three things to be added to it. I'm sorry if it was already discussed but I'm pretty new on this list. *Type Comparison when arg is Object* Imagine we are calculating an insurance risk based on the type of the vehicle we wanna get a quote. So we wanna cal different methods and perform different operations if this vehicle is a boat, a car or a bus. I know we can rely on String for that, adding the type as String attribute or relying on *.getClass().getName()), but the former is error-prone and later is very repetitive. We can also use Enums for that, but again it becomes an instance attribute and there are situations when we cannot use Enums( trust me, it's a thing). We could have some code that looks like this: int insuranceRisk = switch (vehicle){ case Boat -> 3 * analyzeManufacturingDate(vehicle); //vehicle casted to Boat case Bus -> 2 * vehicle.numberOfPassengers(); // vehicle casted to Bus. case Car -> analyzeSeatBeltsAndTires(vehicle); // vehicle casted to Car. default -> 0; }; We compare the type of the instance arg and autocast it at the right of "case L". *Calling default value when no value is returned from expression.* TBH this one is not very clear to me if it's really necessary/good but I'll leave it here if you guys have something to say about this. In resume, there can be some situations when we wanna perform different operations but return the same value and it can be a little repetitive. We could have something like this: int taxes = switch(taxes_type){ case TaxesType.FEDERAL_TAXES -> voidLogFederalTaxes(); case TaxesType.STATE_TAXES -> intCalculateStateTaxes(); case TaxesType.CITY_TAXES -> voidCallCityTaxesAPI(); default -> calculateCommonTaxes(); }; The first and third cases call a void method that performs a specific operation. Of course, I could make then break and return *calculateCommomTaxes()* but you can see that it can get repetitive(as in code duplication) over time. *Break to Break-with* A minor sugestion. * Break value* and * break-with* *value* doesn't seem very descriptive to me. Maybe *break-return value*? *Resume* In resume, all these suggestions are from someone that has no idea if it was already discussed or the implementation cost of it but i'd like to hear what you folks hate to say about it :) Thanks a lot. Em seg, 4 de mar de 2019 ?s 07:24, Ben Evans escreveu: > Hi Brian, > > Can you explain the urgency here? > > If this is going to be a permanent feature as of Java 13, the deadline > for confirming that is surely months away, and I thought that one of > the points of Preview Features was that the promotion to permanent was > supposed to be a quick flick of the switch (no pun intended). > > On the other hand, Java 12 isn't even out yet! So no-one who isn't an > avid early adopter, or subscribed to this group (& I posit that we're > not exactly normal Java developers, for the most part) has tried this > feature in anger. > > As Martijn pointed out, this feature has just landed in the nightly > builds of IntelliJ - perhaps Trish or one of the other JetBrains folks > can give us an idea of how many downloads they see for the nightlies? > - that might give us some idea of how many developers have actually > tried out the feature (although, of course, they are still a > self-selecting early adopter group). > > Thanks, > > Ben > > On Fri, 1 Mar 2019 at 22:55, Brian Goetz wrote: > > > > We would like to promote enhanced switch to a permanent feature in Java > 13. So far, the only change we are anticipating is: > > > > - change ?break value? to ?break-with value?. > > > > This is the time for people to try it out on their codebases (there?s > even refactoring support in IDEA!) and provide feedback on what works, what > doesn?t, and what was surprising. > > > > > -- Jeyvison Nascimento From vicente.romero at oracle.com Tue Mar 5 20:44:33 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 05 Mar 2019 20:44:33 +0000 Subject: hg: amber/amber: manual merge with datum Message-ID: <201903052044.x25KiYMP007220@aojmv0008.oracle.com> Changeset: 12073abe4b93 Author: vromero Date: 2019-03-05 15:44 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/12073abe4b93 manual merge with datum ! make/hotspot/symbols/symbols-unix ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/module-info.java ! src/java.base/share/native/libjava/Class.c ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symbol.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/Attribute.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/ClassWriter.java ! src/jdk.jdeps/share/classes/com/sun/tools/javap/AttributeWriter.java From brian.goetz at oracle.com Wed Mar 6 08:55:43 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Wed, 6 Mar 2019 08:55:43 +0000 Subject: Call for feedback -- enhanced switch In-Reply-To: References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> Message-ID: Just to clarify my request ? I was looking for feedback on the _actual experience of writing code with it_, now that a GA build is imminent and there is IDE support. People often ask how they can contribute to the process. One of the easiest ways is to try out these new features _on real code_ and share your experiences. Sent from my MacBook Wheel > On Mar 5, 2019, at 8:28 PM, Jeyvison Nascimento wrote: > > Hey all. I'd like to share a few impressions from what I saw about the Enhanced switch. > > The JEP is really good and it makes the code a lot cleaner. I don't know if we still have time to suggest something but I'd like to suggest three things to be added to it. I'm sorry if it was already discussed but I'm pretty new on this list. > > Type Comparison when arg is Object > > Imagine we are calculating an insurance risk based on the type of the vehicle we wanna get a quote. So we wanna cal different methods and perform > different operations if this vehicle is a boat, a car or a bus. > > I know we can rely on String for that, adding the type as String attribute or relying on *.getClass().getName()), but the former is error-prone and later is very repetitive. > We can also use Enums for that, but again it becomes an instance attribute and there are situations when we cannot use Enums( trust me, it's a thing). > > We could have some code that looks like this: > > int insuranceRisk = switch (vehicle){ > case Boat -> 3 * analyzeManufacturingDate(vehicle); //vehicle casted to Boat > case Bus -> 2 * vehicle.numberOfPassengers(); // vehicle casted to Bus. > case Car -> analyzeSeatBeltsAndTires(vehicle); // vehicle casted to Car. > default -> 0; > }; > > We compare the type of the instance arg and autocast it at the right of "case L". > > Calling default value when no value is returned from expression. > > TBH this one is not very clear to me if it's really necessary/good but I'll leave it here if you guys have something to say about this. In resume, there can be some situations when we wanna perform different operations but return the same value and it can be a little repetitive. > > We could have something like this: > > int taxes = switch(taxes_type){ > case TaxesType.FEDERAL_TAXES -> voidLogFederalTaxes(); > case TaxesType.STATE_TAXES -> intCalculateStateTaxes(); > case TaxesType.CITY_TAXES -> voidCallCityTaxesAPI(); > default -> calculateCommonTaxes(); > }; > > The first and third cases call a void method that performs a specific operation. Of course, I could make then break and return calculateCommomTaxes() but you can see that it can get repetitive(as in code duplication) over time. > > Break to Break-with > > A minor sugestion. Break value and break-with value doesn't seem very descriptive to me. Maybe break-return value? > > > Resume > > In resume, all these suggestions are from someone that has no idea if it was already discussed or the implementation cost of it but i'd like to hear what you folks hate > to say about it :) > > Thanks a lot. > >> Em seg, 4 de mar de 2019 ?s 07:24, Ben Evans escreveu: >> Hi Brian, >> >> Can you explain the urgency here? >> >> If this is going to be a permanent feature as of Java 13, the deadline >> for confirming that is surely months away, and I thought that one of >> the points of Preview Features was that the promotion to permanent was >> supposed to be a quick flick of the switch (no pun intended). >> >> On the other hand, Java 12 isn't even out yet! So no-one who isn't an >> avid early adopter, or subscribed to this group (& I posit that we're >> not exactly normal Java developers, for the most part) has tried this >> feature in anger. >> >> As Martijn pointed out, this feature has just landed in the nightly >> builds of IntelliJ - perhaps Trish or one of the other JetBrains folks >> can give us an idea of how many downloads they see for the nightlies? >> - that might give us some idea of how many developers have actually >> tried out the feature (although, of course, they are still a >> self-selecting early adopter group). >> >> Thanks, >> >> Ben >> >> On Fri, 1 Mar 2019 at 22:55, Brian Goetz wrote: >> > >> > We would like to promote enhanced switch to a permanent feature in Java 13. So far, the only change we are anticipating is: >> > >> > - change ?break value? to ?break-with value?. >> > >> > This is the time for people to try it out on their codebases (there?s even refactoring support in IDEA!) and provide feedback on what works, what doesn?t, and what was surprising. >> > >> > > > > -- > Jeyvison Nascimento From jeynoronha at gmail.com Wed Mar 6 13:49:13 2019 From: jeynoronha at gmail.com (Jeyvison Nascimento) Date: Wed, 6 Mar 2019 10:49:13 -0300 Subject: Call for feedback -- enhanced switch In-Reply-To: References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> Message-ID: Oh, thanks Brian. Got it totally wrong before. El mi?., 6 mar. 2019 5:55, Brian Goetz escribi?: > Just to clarify my request ? I was looking for feedback on the _actual > experience of writing code with it_, now that a GA build is imminent and > there is IDE support. > > People often ask how they can contribute to the process. One of the > easiest ways is to try out these new features _on real code_ and share your > experiences. > > Sent from my MacBook Wheel > > On Mar 5, 2019, at 8:28 PM, Jeyvison Nascimento > wrote: > > Hey all. I'd like to share a few impressions from what I saw about the > Enhanced switch. > > The JEP is really good and it makes the code a lot cleaner. I don't know > if we still have time to suggest something but I'd like to suggest three > things to be added to it. I'm sorry if it was already discussed but I'm > pretty new on this list. > > *Type Comparison when arg is Object* > > Imagine we are calculating an insurance risk based on the type of the > vehicle we wanna get a quote. So we wanna cal different methods and perform > different operations if this vehicle is a boat, a car or a bus. > > I know we can rely on String for that, adding the type as String attribute > or relying on *.getClass().getName()), but the former is error-prone and > later is very repetitive. > We can also use Enums for that, but again it becomes an instance attribute > and there are situations when we cannot use Enums( trust me, it's a thing). > > We could have some code that looks like this: > > int insuranceRisk = switch (vehicle){ > case Boat -> 3 * analyzeManufacturingDate(vehicle); //vehicle casted to Boat > case Bus -> 2 * vehicle.numberOfPassengers(); // vehicle casted to Bus. > case Car -> analyzeSeatBeltsAndTires(vehicle); // vehicle casted to Car. > default -> 0; > }; > > > We compare the type of the instance arg and autocast it at the right of > "case L". > > *Calling default value when no value is returned from expression.* > > TBH this one is not very clear to me if it's really necessary/good but > I'll leave it here if you guys have something to say about this. In resume, > there can be some situations when we wanna perform different operations but > return the same value and it can be a little repetitive. > > We could have something like this: > > int taxes = switch(taxes_type){ > case TaxesType.FEDERAL_TAXES -> voidLogFederalTaxes(); > case TaxesType.STATE_TAXES -> intCalculateStateTaxes(); > case TaxesType.CITY_TAXES -> voidCallCityTaxesAPI(); > default -> calculateCommonTaxes(); > }; > > > The first and third cases call a void method that performs a specific > operation. Of course, I could make then break and return > *calculateCommomTaxes()* but you can see that it can get repetitive(as in > code duplication) over time. > > *Break to Break-with* > > A minor sugestion. * Break value* and * break-with* *value* doesn't seem > very descriptive to me. Maybe *break-return value*? > > > *Resume* > > In resume, all these suggestions are from someone that has no idea if it > was already discussed or the implementation cost of it but i'd like to hear > what you folks hate > to say about it :) > > Thanks a lot. > > Em seg, 4 de mar de 2019 ?s 07:24, Ben Evans < > benjamin.john.evans at gmail.com> escreveu: > >> Hi Brian, >> >> Can you explain the urgency here? >> >> If this is going to be a permanent feature as of Java 13, the deadline >> for confirming that is surely months away, and I thought that one of >> the points of Preview Features was that the promotion to permanent was >> supposed to be a quick flick of the switch (no pun intended). >> >> On the other hand, Java 12 isn't even out yet! So no-one who isn't an >> avid early adopter, or subscribed to this group (& I posit that we're >> not exactly normal Java developers, for the most part) has tried this >> feature in anger. >> >> As Martijn pointed out, this feature has just landed in the nightly >> builds of IntelliJ - perhaps Trish or one of the other JetBrains folks >> can give us an idea of how many downloads they see for the nightlies? >> - that might give us some idea of how many developers have actually >> tried out the feature (although, of course, they are still a >> self-selecting early adopter group). >> >> Thanks, >> >> Ben >> >> On Fri, 1 Mar 2019 at 22:55, Brian Goetz wrote: >> > >> > We would like to promote enhanced switch to a permanent feature in Java >> 13. So far, the only change we are anticipating is: >> > >> > - change ?break value? to ?break-with value?. >> > >> > This is the time for people to try it out on their codebases (there?s >> even refactoring support in IDEA!) and provide feedback on what works, what >> doesn?t, and what was surprising. >> > >> > >> > > > -- > Jeyvison Nascimento > > From vicente.romero at oracle.com Wed Mar 6 17:18:56 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Wed, 6 Mar 2019 12:18:56 -0500 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> Message-ID: <0d64c9b7-a102-12a9-e9de-515ac7e87f11@oracle.com> Hi all, I have produced a new iteration of performance results with a reorganization of the data proposed by Alex, see [1], I added a link to the benchmark source Thanks Vicente [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v5/benchmarkResults_intrinsics_all_data_v5.html On 3/4/19 9:52 PM, Vicente Romero wrote: > > > On 3/4/19 8:11 PM, Alex Buckley wrote: >> // Adopting a zero-decimal-places policy because precision to >> multiple decimal places is less important than accuracy and >> repeatability. >> >> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>> I have uploaded another round of experiments for Objects::hash, see >>> [1]. >>> The main variation I have included a variant of most of the tests in >>> which instead of invoking Objects::hash 10 times sequentially, the same >>> invocation occurs inside a loop which is executed 10 times. This shows >>> that when the call site is reused, the execution time trumps vanilla >>> JDK13 most of the time. >> >> That's not really the story though :-) Yes, the *Int*StringsLoop10 >> tests run faster with intrinsified invocation than with vanilla >> invocation, but generally, the *Int*StringsLoop10 tests enjoy less >> impressive speedups than the *Int*Strings tests. (Example: >> 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets >> a 2x speedup.) >> >> This is because the *Int*StringsLoop10 tests already run faster on >> vanilla JDK 13 than the *Int*Strings tests, presumably thanks to >> inlining ("the call site is reused"). >> >> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would >> have such high throughput on vanilla JDK 13 that their speedups with >> intrinsification might be significantly <1. > > not in all cases, see [1] the new information is highlighted in yellow >> >> Alex > > Vicente > > [1] > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html From hannes.wallnoefer at oracle.com Wed Mar 6 17:48:26 2019 From: hannes.wallnoefer at oracle.com (=?utf-8?Q?Hannes_Walln=C3=B6fer?=) Date: Wed, 6 Mar 2019 18:48:26 +0100 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> Message-ID: <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> Vicente, I ran a number of the Objects::hash benchmarks ranging from 1 to 100 arguments with current intrinsics-project tip (a0a3f9977a7c) as well as the older version of ObjectsBootstraps.java (pre 0f40d5752eb9, see patch attached). The results I get show that with a single argument, performance is pretty much the same, but with any of number of arguments between 2 and 50 the old version is about 2x faster. It?s only with 100 arguments that the old version becomes pathetically slow, while the new version still performs decently. I guess the change in implementation was based on a too narrow set of benchmarks, and in the light of these results we should go back to the old implementation. Since invocations with > 50 arguments should be fairly uncommon I guess a simple solution such as invoking the original method via a vararg method handle would be sufficient? Hannes -------------- next part -------------- ** intrinsics-project tip ** Benchmark Mode Cnt Score Error Units IntrinsicsBenchmark.testHash1IntLoop10 thrpt 5 41721,730 ? 2477,413 ops/ms IntrinsicsBenchmark.testHash1StringLoop10 thrpt 5 35289,443 ? 1030,636 ops/ms IntrinsicsBenchmark.testHash2Ints thrpt 5 21830,140 ? 852,642 ops/ms IntrinsicsBenchmark.testHash2IntsLoop10 thrpt 5 19806,343 ? 1027,029 ops/ms IntrinsicsBenchmark.testHash2Strings thrpt 5 18409,232 ? 676,311 ops/ms IntrinsicsBenchmark.testHash2StringsLoop10 thrpt 5 16842,651 ? 664,615 ops/ms IntrinsicsBenchmark.testHash5Int5Strings thrpt 5 9183,019 ? 409,206 ops/ms IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5 8349,475 ? 886,015 ops/ms IntrinsicsBenchmark.testHash5Integers5Strings thrpt 5 9155,629 ? 335,129 ops/ms IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt 5 8171,108 ? 385,375 ops/ms IntrinsicsBenchmark.testHash5doubles5Strings thrpt 5 9246,458 ? 502,251 ops/ms IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt 5 8419,192 ? 372,626 ops/ms IntrinsicsBenchmark.testHash100Ints thrpt 5 796,460 ? 27,123 ops/ms IntrinsicsBenchmark.testHash100IntsLoop10 thrpt 5 792,775 ? 23,402 ops/ms IntrinsicsBenchmark.testHash100Strings thrpt 5 69,753 ? 45,947 ops/ms IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5 619,774 ? 14,503 ops/ms IntrinsicsBenchmark.testHash20Int20Strings thrpt 5 1669,774 ? 53,991 ops/ms IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5 1644,342 ? 62,946 ops/ms IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5 1651,428 ? 170,146 ops/ms IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt 5 1635,878 ? 62,007 ops/ms IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5 1673,927 ? 51,559 ops/ms IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt 5 1641,524 ? 52,172 ops/ms IntrinsicsBenchmark.testHash25Int25Strings thrpt 5 1286,407 ? 27,920 ops/ms IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5 1286,250 ? 26,125 ops/ms IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5 1290,251 ? 25,217 ops/ms IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt 5 1285,060 ? 33,297 ops/ms IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5 1288,374 ? 40,727 ops/ms IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt 5 1277,822 ? 20,674 ops/ms IntrinsicsBenchmark.testHash50Int50Strings thrpt 5 185,692 ? 753,244 ops/ms IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5 622,333 ? 12,212 ops/ms IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5 266,784 ? 8,620 ops/ms IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt 5 623,180 ? 15,583 ops/ms IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5 391,497 ? 33,738 ops/ms IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt 5 621,560 ? 12,652 ops/ms ** old version of hash bootstraps ** Benchmark Mode Cnt Score Error Units IntrinsicsBenchmark.testHash1IntLoop10 thrpt 5 42161,466 ? 975,935 ops/ms IntrinsicsBenchmark.testHash1StringLoop10 thrpt 5 35445,612 ? 1320,095 ops/ms IntrinsicsBenchmark.testHash2Ints thrpt 5 52157,722 ? 1089,439 ops/ms IntrinsicsBenchmark.testHash2IntsLoop10 thrpt 5 42223,291 ? 1107,430 ops/ms IntrinsicsBenchmark.testHash2Strings thrpt 5 46702,129 ? 1360,150 ops/ms IntrinsicsBenchmark.testHash2StringsLoop10 thrpt 5 35577,294 ? 939,756 ops/ms IntrinsicsBenchmark.testHash5Int5Strings thrpt 5 20351,503 ? 495,039 ops/ms IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5 20087,351 ? 518,764 ops/ms IntrinsicsBenchmark.testHash5Integers5Strings thrpt 5 20884,773 ? 648,380 ops/ms IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt 5 19990,317 ? 492,250 ops/ms IntrinsicsBenchmark.testHash5doubles5Strings thrpt 5 20913,291 ? 615,744 ops/ms IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt 5 20053,959 ? 538,675 ops/ms IntrinsicsBenchmark.testHash100Ints thrpt 5 6,625 ? 0,157 ops/ms IntrinsicsBenchmark.testHash100IntsLoop10 thrpt 5 6,747 ? 0,201 ops/ms IntrinsicsBenchmark.testHash100Strings thrpt 5 6,305 ? 1,031 ops/ms IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5 6,826 ? 0,154 ops/ms IntrinsicsBenchmark.testHash20Int20Strings thrpt 5 4188,399 ? 61,255 ops/ms IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5 4220,161 ? 55,642 ops/ms IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5 4188,347 ? 126,054 ops/ms IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt 5 4251,327 ? 86,473 ops/ms IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5 4206,733 ? 66,459 ops/ms IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt 5 4227,479 ? 78,542 ops/ms IntrinsicsBenchmark.testHash25Int25Strings thrpt 5 3162,896 ? 68,946 ops/ms IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5 3190,599 ? 71,035 ops/ms IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5 3153,547 ? 59,114 ops/ms IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt 5 3200,687 ? 56,650 ops/ms IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5 3166,884 ? 46,123 ops/ms IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt 5 3202,177 ? 36,159 ops/ms IntrinsicsBenchmark.testHash50Int50Strings thrpt 5 6,485 ? 0,054 ops/ms IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5 6,543 ? 0,265 ops/ms IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5 6,376 ? 0,150 ops/ms IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt 5 6,774 ? 0,159 ops/ms IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5 6,548 ? 0,303 ops/ms IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt 5 6,687 ? 0,081 ops/ms > Am 05.03.2019 um 16:31 schrieb Vicente Romero : > > > > On 3/5/19 9:02 AM, Hannes Walln?fer wrote: >> Vicente, >> >> could it be that your your change in Object::hash bootstraps[1] mostly benefits invocations with very large numbers of parameters (like your original 100 parameter tests) but hurts performance with medium-to-lower number of parameters? I don?t have your latest benchmark sources, but I did some quick tests such as a testHash5Ints5Strings that suggest that may be the case. > > that could be, but the intrinsified version is still faster for those cases with small number of arguments. That's probably why I have focused on the larger number of argument case but we can change priorities or even have different callsites depending on the number of arguments > >> >> [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 >> >> Hannes > > Vicente > >> >> >>> Am 05.03.2019 um 03:52 schrieb Vicente Romero : >>> >>> >>> >>> On 3/4/19 8:11 PM, Alex Buckley wrote: >>>> // Adopting a zero-decimal-places policy because precision to multiple decimal places is less important than accuracy and repeatability. >>>> >>>> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>>>> I have uploaded another round of experiments for Objects::hash, see [1]. >>>>> The main variation I have included a variant of most of the tests in >>>>> which instead of invoking Objects::hash 10 times sequentially, the same >>>>> invocation occurs inside a loop which is executed 10 times. This shows >>>>> that when the call site is reused, the execution time trumps vanilla >>>>> JDK13 most of the time. >>>> That's not really the story though :-) Yes, the *Int*StringsLoop10 tests run faster with intrinsified invocation than with vanilla invocation, but generally, the *Int*StringsLoop10 tests enjoy less impressive speedups than the *Int*Strings tests. (Example: 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) >>>> >>>> This is because the *Int*StringsLoop10 tests already run faster on vanilla JDK 13 than the *Int*Strings tests, presumably thanks to inlining ("the call site is reused"). >>>> >>>> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would have such high throughput on vanilla JDK 13 that their speedups with intrinsification might be significantly <1. >>> not in all cases, see [1] the new information is highlighted in yellow >>>> Alex >>> Vicente >>> >>> [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html > From vicente.romero at oracle.com Wed Mar 6 18:05:56 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Wed, 6 Mar 2019 13:05:56 -0500 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> Message-ID: <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> Hi Hannes, Thanks for the results, yes the change I made was more oriented to large number of arguments so it makes sense that it is not as good for a smaller number of arguments which I agree with you should be the most common case. I think we are gathering a good case for the next amber meeting to come to a decision on the project, on the Objects::hash area. I think that there are two options: 1. do nothing: Objects::hash is not intrisified at all 2. generate the fastest callsite for a small number of arguments and generate the legit code when the number of arguments is above a given threshold Comments? Vicente On 3/6/19 12:48 PM, Hannes Walln?fer wrote: > Vicente, > > I ran a number of the Objects::hash benchmarks ranging from 1 to 100 arguments with current intrinsics-project tip (a0a3f9977a7c) as well as the older version of ObjectsBootstraps.java (pre 0f40d5752eb9, see patch attached). The results I get show that with a single argument, performance is pretty much the same, but with any of number of arguments between 2 and 50 the old version is about 2x faster. It?s only with 100 arguments that the old version becomes pathetically slow, while the new version still performs decently. > > I guess the change in implementation was based on a too narrow set of benchmarks, and in the light of these results we should go back to the old implementation. Since invocations with > 50 arguments should be fairly uncommon I guess a simple solution such as invoking the original method via a vararg method handle would be sufficient? > > Hannes > > > > ** intrinsics-project tip ** > > Benchmark Mode Cnt Score Error Units > IntrinsicsBenchmark.testHash1IntLoop10 thrpt 5 41721,730 ? 2477,413 ops/ms > IntrinsicsBenchmark.testHash1StringLoop10 thrpt 5 35289,443 ? 1030,636 ops/ms > IntrinsicsBenchmark.testHash2Ints thrpt 5 21830,140 ? 852,642 ops/ms > IntrinsicsBenchmark.testHash2IntsLoop10 thrpt 5 19806,343 ? 1027,029 ops/ms > IntrinsicsBenchmark.testHash2Strings thrpt 5 18409,232 ? 676,311 ops/ms > IntrinsicsBenchmark.testHash2StringsLoop10 thrpt 5 16842,651 ? 664,615 ops/ms > IntrinsicsBenchmark.testHash5Int5Strings thrpt 5 9183,019 ? 409,206 ops/ms > IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5 8349,475 ? 886,015 ops/ms > IntrinsicsBenchmark.testHash5Integers5Strings thrpt 5 9155,629 ? 335,129 ops/ms > IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt 5 8171,108 ? 385,375 ops/ms > IntrinsicsBenchmark.testHash5doubles5Strings thrpt 5 9246,458 ? 502,251 ops/ms > IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt 5 8419,192 ? 372,626 ops/ms > IntrinsicsBenchmark.testHash100Ints thrpt 5 796,460 ? 27,123 ops/ms > IntrinsicsBenchmark.testHash100IntsLoop10 thrpt 5 792,775 ? 23,402 ops/ms > IntrinsicsBenchmark.testHash100Strings thrpt 5 69,753 ? 45,947 ops/ms > IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5 619,774 ? 14,503 ops/ms > IntrinsicsBenchmark.testHash20Int20Strings thrpt 5 1669,774 ? 53,991 ops/ms > IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5 1644,342 ? 62,946 ops/ms > IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5 1651,428 ? 170,146 ops/ms > IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt 5 1635,878 ? 62,007 ops/ms > IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5 1673,927 ? 51,559 ops/ms > IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt 5 1641,524 ? 52,172 ops/ms > IntrinsicsBenchmark.testHash25Int25Strings thrpt 5 1286,407 ? 27,920 ops/ms > IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5 1286,250 ? 26,125 ops/ms > IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5 1290,251 ? 25,217 ops/ms > IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt 5 1285,060 ? 33,297 ops/ms > IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5 1288,374 ? 40,727 ops/ms > IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt 5 1277,822 ? 20,674 ops/ms > IntrinsicsBenchmark.testHash50Int50Strings thrpt 5 185,692 ? 753,244 ops/ms > IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5 622,333 ? 12,212 ops/ms > IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5 266,784 ? 8,620 ops/ms > IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt 5 623,180 ? 15,583 ops/ms > IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5 391,497 ? 33,738 ops/ms > IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt 5 621,560 ? 12,652 ops/ms > > ** old version of hash bootstraps ** > > Benchmark Mode Cnt Score Error Units > IntrinsicsBenchmark.testHash1IntLoop10 thrpt 5 42161,466 ? 975,935 ops/ms > IntrinsicsBenchmark.testHash1StringLoop10 thrpt 5 35445,612 ? 1320,095 ops/ms > IntrinsicsBenchmark.testHash2Ints thrpt 5 52157,722 ? 1089,439 ops/ms > IntrinsicsBenchmark.testHash2IntsLoop10 thrpt 5 42223,291 ? 1107,430 ops/ms > IntrinsicsBenchmark.testHash2Strings thrpt 5 46702,129 ? 1360,150 ops/ms > IntrinsicsBenchmark.testHash2StringsLoop10 thrpt 5 35577,294 ? 939,756 ops/ms > IntrinsicsBenchmark.testHash5Int5Strings thrpt 5 20351,503 ? 495,039 ops/ms > IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5 20087,351 ? 518,764 ops/ms > IntrinsicsBenchmark.testHash5Integers5Strings thrpt 5 20884,773 ? 648,380 ops/ms > IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt 5 19990,317 ? 492,250 ops/ms > IntrinsicsBenchmark.testHash5doubles5Strings thrpt 5 20913,291 ? 615,744 ops/ms > IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt 5 20053,959 ? 538,675 ops/ms > IntrinsicsBenchmark.testHash100Ints thrpt 5 6,625 ? 0,157 ops/ms > IntrinsicsBenchmark.testHash100IntsLoop10 thrpt 5 6,747 ? 0,201 ops/ms > IntrinsicsBenchmark.testHash100Strings thrpt 5 6,305 ? 1,031 ops/ms > IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5 6,826 ? 0,154 ops/ms > IntrinsicsBenchmark.testHash20Int20Strings thrpt 5 4188,399 ? 61,255 ops/ms > IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5 4220,161 ? 55,642 ops/ms > IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5 4188,347 ? 126,054 ops/ms > IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt 5 4251,327 ? 86,473 ops/ms > IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5 4206,733 ? 66,459 ops/ms > IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt 5 4227,479 ? 78,542 ops/ms > IntrinsicsBenchmark.testHash25Int25Strings thrpt 5 3162,896 ? 68,946 ops/ms > IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5 3190,599 ? 71,035 ops/ms > IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5 3153,547 ? 59,114 ops/ms > IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt 5 3200,687 ? 56,650 ops/ms > IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5 3166,884 ? 46,123 ops/ms > IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt 5 3202,177 ? 36,159 ops/ms > IntrinsicsBenchmark.testHash50Int50Strings thrpt 5 6,485 ? 0,054 ops/ms > IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5 6,543 ? 0,265 ops/ms > IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5 6,376 ? 0,150 ops/ms > IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt 5 6,774 ? 0,159 ops/ms > IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5 6,548 ? 0,303 ops/ms > IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt 5 6,687 ? 0,081 ops/ms > >> Am 05.03.2019 um 16:31 schrieb Vicente Romero : >> >> >> >> On 3/5/19 9:02 AM, Hannes Walln?fer wrote: >>> Vicente, >>> >>> could it be that your your change in Object::hash bootstraps[1] mostly benefits invocations with very large numbers of parameters (like your original 100 parameter tests) but hurts performance with medium-to-lower number of parameters? I don?t have your latest benchmark sources, but I did some quick tests such as a testHash5Ints5Strings that suggest that may be the case. >> that could be, but the intrinsified version is still faster for those cases with small number of arguments. That's probably why I have focused on the larger number of argument case but we can change priorities or even have different callsites depending on the number of arguments >> >>> [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 >>> >>> Hannes >> Vicente >> >>> >>>> Am 05.03.2019 um 03:52 schrieb Vicente Romero : >>>> >>>> >>>> >>>> On 3/4/19 8:11 PM, Alex Buckley wrote: >>>>> // Adopting a zero-decimal-places policy because precision to multiple decimal places is less important than accuracy and repeatability. >>>>> >>>>> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>>>>> I have uploaded another round of experiments for Objects::hash, see [1]. >>>>>> The main variation I have included a variant of most of the tests in >>>>>> which instead of invoking Objects::hash 10 times sequentially, the same >>>>>> invocation occurs inside a loop which is executed 10 times. This shows >>>>>> that when the call site is reused, the execution time trumps vanilla >>>>>> JDK13 most of the time. >>>>> That's not really the story though :-) Yes, the *Int*StringsLoop10 tests run faster with intrinsified invocation than with vanilla invocation, but generally, the *Int*StringsLoop10 tests enjoy less impressive speedups than the *Int*Strings tests. (Example: 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) >>>>> >>>>> This is because the *Int*StringsLoop10 tests already run faster on vanilla JDK 13 than the *Int*Strings tests, presumably thanks to inlining ("the call site is reused"). >>>>> >>>>> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would have such high throughput on vanilla JDK 13 that their speedups with intrinsification might be significantly <1. >>>> not in all cases, see [1] the new information is highlighted in yellow >>>>> Alex >>>> Vicente >>>> >>>> [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html From vicente.romero at oracle.com Wed Mar 6 18:43:58 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 06 Mar 2019 18:43:58 +0000 Subject: hg: amber/amber: remove dependency Message-ID: <201903061843.x26Ihxcb019622@aojmv0008.oracle.com> Changeset: 2128db408ff7 Author: vromero Date: 2019-03-06 13:43 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/2128db408ff7 remove dependency - deps.txt From maurizio.cimadamore at oracle.com Wed Mar 6 18:46:10 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 06 Mar 2019 18:46:10 +0000 Subject: hg: amber/amber: Automatic merge with datum Message-ID: <201903061846.x26IkBQ9021751@aojmv0008.oracle.com> Changeset: 260e11cced9c Author: mcimadamore Date: 2019-03-06 19:46 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/260e11cced9c Automatic merge with datum From vicente.romero at oracle.com Wed Mar 6 18:42:21 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 06 Mar 2019 18:42:21 +0000 Subject: hg: amber/amber: sealed branch was merged into records-and-sealed branch Message-ID: <201903061842.x26IgLbi019060@aojmv0008.oracle.com> Changeset: f0cd14f9e57f Author: vromero Date: 2019-03-06 13:42 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/f0cd14f9e57f sealed branch was merged into records-and-sealed branch From vicente.romero at oracle.com Wed Mar 6 18:43:00 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 06 Mar 2019 18:43:00 +0000 Subject: hg: amber/amber: datum branch was merged into records-and-sealed branch Message-ID: <201903061843.x26Ih1HA019378@aojmv0008.oracle.com> Changeset: c3ba8937b878 Author: vromero Date: 2019-03-06 13:42 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/c3ba8937b878 datum branch was merged into records-and-sealed branch From francois.green at gmail.com Wed Mar 6 21:53:17 2019 From: francois.green at gmail.com (Francois Green) Date: Wed, 6 Mar 2019 16:53:17 -0500 Subject: New error when combining Concise Method Bodies and Switch Expressions Message-ID: I'm certain this code had worked earlier: public class HowMany { static void howMany(int k) -> switch (k) { case 1 -> System.out.println("one"); default -> throw new IllegalArgumentException("unknown"); }; public static void main(String[] args) { howMany(1); } } An exception has occurred in the compiler (13-amber). Please file a bug against the Java compiler via the Java bug reporting page ( http://bugreport.java.com) after checking the Bug Database ( http://bugs.java.com) for duplicates. Include your program, the following diagnostic, and the parameters passed to the Java compiler in your report. Thank you. java.lang.AssertionError at jdk.compiler/com.sun.tools.javac.jvm.Items$Item.load(Items.java:206) at jdk.compiler/com.sun.tools.javac.jvm.Gen.visitBreak(Gen.java:1733) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBreak.accept(JCTree.java:1596) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genDef(Gen.java:595) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genStat(Gen.java:630) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genStat(Gen.java:616) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genStats(Gen.java:667) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genStats(Gen.java:651) at jdk.compiler/com.sun.tools.javac.jvm.Gen.handleSwitch(Gen.java:1337) at jdk.compiler/com.sun.tools.javac.jvm.Gen.doHandleSwitchExpression(Gen.java:1205) at jdk.compiler/com.sun.tools.javac.jvm.Gen.visitSwitchExpression(Gen.java:1172) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCSwitchExpression.accept(JCTree.java:1350) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genExpr(Gen.java:853) at jdk.compiler/com.sun.tools.javac.jvm.Gen.visitExec(Gen.java:1702) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCExpressionStatement.accept(JCTree.java:1554) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genDef(Gen.java:595) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genStat(Gen.java:630) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genStat(Gen.java:616) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genStats(Gen.java:667) at jdk.compiler/com.sun.tools.javac.jvm.Gen.visitBlock(Gen.java:1067) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCBlock.accept(JCTree.java:1061) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genDef(Gen.java:595) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genStat(Gen.java:630) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genMethod(Gen.java:937) at jdk.compiler/com.sun.tools.javac.jvm.Gen.visitMethodDef(Gen.java:900) at jdk.compiler/com.sun.tools.javac.tree.JCTree$JCMethodDecl.accept(JCTree.java:879) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genDef(Gen.java:595) at jdk.compiler/com.sun.tools.javac.jvm.Gen.genClass(Gen.java:2345) at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.genCode(JavaCompiler.java:756) at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1635) at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.generate(JavaCompiler.java:1603) at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:973) at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104) at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:147) at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100) at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94) at jdk.compiler/com.sun.tools.javac.launcher.Main.compile(Main.java:379) at jdk.compiler/com.sun.tools.javac.launcher.Main.run(Main.java:189) at jdk.compiler/com.sun.tools.javac.launcher.Main.main(Main.java:132) error: compilation failed I'm using the last Concise Method Bodies build from Remi Forax's Github, which is about a month old (so it might already be fixed). PS. Please consider re-adding Concise Method Bodies to the Amber Demo. From maurizio.cimadamore at oracle.com Thu Mar 7 10:45:52 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 07 Mar 2019 10:45:52 +0000 Subject: hg: amber/amber: Automatic merge with patterns-stage-1 Message-ID: <201903071045.x27AjqE7008685@aojmv0008.oracle.com> Changeset: 3f9f3e6eeb64 Author: mcimadamore Date: 2019-03-07 11:45 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/3f9f3e6eeb64 Automatic merge with patterns-stage-1 ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java From jan.lahoda at oracle.com Thu Mar 7 10:43:57 2019 From: jan.lahoda at oracle.com (jan.lahoda at oracle.com) Date: Thu, 07 Mar 2019 10:43:57 +0000 Subject: hg: amber/amber: Properly extend bindings beyond unbalanced ifs (reported by gbierman) Message-ID: <201903071043.x27AhwLj006819@aojmv0008.oracle.com> Changeset: 285e83b11b53 Author: jlahoda Date: 2019-03-07 11:43 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/285e83b11b53 Properly extend bindings beyond unbalanced ifs (reported by gbierman) ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! test/langtools/tools/javac/patterns/BindingsTest1.java From maurizio.cimadamore at oracle.com Thu Mar 7 10:46:12 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 07 Mar 2019 10:46:12 +0000 Subject: hg: amber/amber: Automatic merge with patterns-stage-1 Message-ID: <201903071046.x27AkCdf008970@aojmv0008.oracle.com> Changeset: d234b346770a Author: mcimadamore Date: 2019-03-07 11:46 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/d234b346770a Automatic merge with patterns-stage-1 ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java From shade at redhat.com Thu Mar 7 21:10:24 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 7 Mar 2019 22:10:24 +0100 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <0d64c9b7-a102-12a9-e9de-515ac7e87f11@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <0d64c9b7-a102-12a9-e9de-515ac7e87f11@oracle.com> Message-ID: <45dd5a9d-f1c5-3d9d-7b12-e1eb094b721a@redhat.com> On 3/6/19 6:18 PM, Vicente Romero wrote: > I have produced a new iteration of performance results with a reorganization of the data proposed by > Alex, see [1], I added a link to the benchmark source > > [1] > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v5/benchmarkResults_intrinsics_all_data_v5.html Haven't read the entire thread, Alex asked me for comments about the benchmark itself: *) These two guys are unused? static final Integer i23 = 23; static final Object[] args = { "Bob", i23 }; *) This repetitive block can be put on the IntrinsicsBenchmarks class: @BenchmarkMode(Mode.Throughput) @Fork(value = 1) @Warmup(iterations=3) @Measurement(iterations=5) @OutputTimeUnit(TimeUnit.MILLISECONDS) ...leaving only: @Benchmark public void testHash0001Int(Blackhole b) { ... } *) Is there a reason to do multiple ops per @Benchmark? Why can't it be just: @Benchmark public int testHash0001Int() { int i = 1; return Objects.hash(i); } *) Come to think about it, are those benchmark try to specifically measure the ability to fold local vars? If so, it could be just inlined? @Benchmark public int testHash0001Int() { return Objects.hash(1); } *) If local var is sensible, I guess there is a difference between local "final int i = 1;" and "int i = 1;" from javac perspective? *) I guess what you want to check for performance when arguments read from instance fields -- that would be the target test case that simulates Object.hashCode(), no? JMH would break load commoning across @Benchmark calls, which makes two families of tests sensible: @BenchmarkMode(Mode.Throughput) @Fork(value = 1) @Warmup(iterations=3) @Measurement(iterations=5) @OutputTimeUnit(TimeUnit.MILLISECONDS) @State(Scope.Benchmark) public class IntrinsicsBenchmark { int i1 = 1; @Benchmark public int testHash0001Int_Standalone() { // Single read of field with unknown value return Objects.hash(i1); } @Benchmark public int testHash0001Int_Merge() { // Second read should be able to reuse/fold the value first read got return Objects.hash(i1) + Objects.hash(i1); } } *) Probably needs the test that accepts already boxed varargs via Object[]? *) Is there -prof perfasm output for any of those benchmarks, to see how generated code is actually looking? It might look especially funny for cases that fall off the cliff, like testHash0080String. -Aleksey From vicente.romero at oracle.com Thu Mar 7 21:20:03 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Thu, 7 Mar 2019 16:20:03 -0500 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <45dd5a9d-f1c5-3d9d-7b12-e1eb094b721a@redhat.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <0d64c9b7-a102-12a9-e9de-515ac7e87f11@oracle.com> <45dd5a9d-f1c5-3d9d-7b12-e1eb094b721a@redhat.com> Message-ID: <86a39980-36f3-2398-3f1b-ecf17ba8ba4b@oracle.com> Hi Aleksey, Thansk for taking a look at this On 3/7/19 4:10 PM, Aleksey Shipilev wrote: > On 3/6/19 6:18 PM, Vicente Romero wrote: >> I have produced a new iteration of performance results with a reorganization of the data proposed by >> Alex, see [1], I added a link to the benchmark source >> >> [1] >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v5/benchmarkResults_intrinsics_all_data_v5.html > Haven't read the entire thread, Alex asked me for comments about the benchmark itself: > > *) These two guys are unused? > > static final Integer i23 = 23; > static final Object[] args = { "Bob", i23 }; no, dead code, will remove it > > *) This repetitive block can be put on the IntrinsicsBenchmarks class: > > @BenchmarkMode(Mode.Throughput) > @Fork(value = 1) > @Warmup(iterations=3) > @Measurement(iterations=5) > @OutputTimeUnit(TimeUnit.MILLISECONDS) ok less verbosity > > ...leaving only: > > @Benchmark > public void testHash0001Int(Blackhole b) { > ... > } > > *) Is there a reason to do multiple ops per @Benchmark? Why can't it be just: > > @Benchmark > public int testHash0001Int() { > int i = 1; > return Objects.hash(i); > } not really, will simplify it > > *) Come to think about it, are those benchmark try to specifically measure the ability to fold local > vars? If so, it could be just inlined? > > @Benchmark > public int testHash0001Int() { > return Objects.hash(1); > } not specifically local vars but this project is able to produce an ldc if the argument is / are constants, so we want to measure the case when the arguments are not constants. The constant case is superfast we don't have performance issues there > > *) If local var is sensible, I guess there is a difference between local "final int i = 1;" and "int > i = 1;" from javac perspective? yes: `final int i = 1;` is the same as a constant literal > > *) I guess what you want to check for performance when arguments read from instance fields -- that > would be the target test case that simulates Object.hashCode(), no? reading instance fields or local variables shouldn't make a big difference > JMH would break load commoning > across @Benchmark calls, which makes two families of tests sensible: > > @BenchmarkMode(Mode.Throughput) > @Fork(value = 1) > @Warmup(iterations=3) > @Measurement(iterations=5) > @OutputTimeUnit(TimeUnit.MILLISECONDS) > @State(Scope.Benchmark) > public class IntrinsicsBenchmark { > int i1 = 1; > > @Benchmark > public int testHash0001Int_Standalone() { > // Single read of field with unknown value > return Objects.hash(i1); > } > > @Benchmark > public int testHash0001Int_Merge() { > // Second read should be able to reuse/fold the value first read got > return Objects.hash(i1) + Objects.hash(i1); > } > } > > *) Probably needs the test that accepts already boxed varargs via Object[]? yes we have separate tests for that > > *) Is there -prof perfasm output for any of those benchmarks, to see how generated code is actually > looking? It might look especially funny for cases that fall off the cliff, like testHash0080String. yep a big indy invocation > > -Aleksey > Thanks, Vicente From shade at redhat.com Thu Mar 7 21:40:39 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 7 Mar 2019 22:40:39 +0100 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <86a39980-36f3-2398-3f1b-ecf17ba8ba4b@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <0d64c9b7-a102-12a9-e9de-515ac7e87f11@oracle.com> <45dd5a9d-f1c5-3d9d-7b12-e1eb094b721a@redhat.com> <86a39980-36f3-2398-3f1b-ecf17ba8ba4b@oracle.com> Message-ID: On 3/7/19 10:20 PM, Vicente Romero wrote: >> *) I guess what you want to check for performance when arguments read from instance fields -- that >> would be the target test case that simulates Object.hashCode(), no? > > reading instance fields or local variables shouldn't make a big difference It would for @Benchmarks, because reading from @State field would make sure neither javac nor JIT compiler knows the value during the compilation. See e.g.: https://hg.openjdk.java.net/code-tools/jmh/file/5984e353dca7/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_10_ConstantFold.java Arguably, reading from fields is what would happen "in real world", when Object::hashcode is called on object with unknown identity, object fields have to be read before calling into Object::hash, etc. Measuring folding through the constants is good, but it might not be the target scenario here. -Aleksey From alex.buckley at oracle.com Thu Mar 7 22:15:03 2019 From: alex.buckley at oracle.com (Alex Buckley) Date: Thu, 07 Mar 2019 14:15:03 -0800 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <0d64c9b7-a102-12a9-e9de-515ac7e87f11@oracle.com> <45dd5a9d-f1c5-3d9d-7b12-e1eb094b721a@redhat.com> <86a39980-36f3-2398-3f1b-ecf17ba8ba4b@oracle.com> Message-ID: <5C8197E7.7000509@oracle.com> On 3/7/2019 1:40 PM, Aleksey Shipilev wrote: > On 3/7/19 10:20 PM, Vicente Romero wrote: >>> *) I guess what you want to check for performance when arguments read from instance fields -- that >>> would be the target test case that simulates Object.hashCode(), no? >> >> reading instance fields or local variables shouldn't make a big difference > > It would for @Benchmarks, because reading from @State field would make sure neither javac nor JIT > compiler knows the value during the compilation. See e.g.: > > https://hg.openjdk.java.net/code-tools/jmh/file/5984e353dca7/jmh-samples/src/main/java/org/openjdk/jmh/samples/JMHSample_10_ConstantFold.java > > Arguably, reading from fields is what would happen "in real world", when Object::hashcode is called > on object with unknown identity, object fields have to be read before calling into Object::hash, > etc. Measuring folding through the constants is good, but it might not be the target scenario here. IIUC (and I realize this is basic stuff in JMH-land) you're saying there may be a measurable difference between these two benchmarks: @State(Scope.Benchmark) public class IntrinsicsBenchmark { int i1 = 1; @Benchmark public int testHash0001Int_Field() { // Single read of field with unknown value return Objects.hash(i1); } @Benchmark public int testHash0001Int_Local() { // This local variable is not constant to a Java compiler // but will be constant folded by the JIT compiler int i = 1; return Objects.hash(i); } } Alex From shade at redhat.com Thu Mar 7 22:21:15 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Thu, 7 Mar 2019 23:21:15 +0100 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <5C8197E7.7000509@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <0d64c9b7-a102-12a9-e9de-515ac7e87f11@oracle.com> <45dd5a9d-f1c5-3d9d-7b12-e1eb094b721a@redhat.com> <86a39980-36f3-2398-3f1b-ecf17ba8ba4b@oracle.com> <5C8197E7.7000509@oracle.com> Message-ID: <8e639a63-c623-d76f-c125-0d208afe6693@redhat.com> On 3/7/19 11:15 PM, Alex Buckley wrote: > On 3/7/2019 1:40 PM, Aleksey Shipilev wrote: >> Arguably, reading from fields is what would happen "in real world", when Object::hashcode is called >> on object with unknown identity, object fields have to be read before calling into Object::hash, >> etc. Measuring folding through the constants is good, but it might not be the target scenario here. > > IIUC (and I realize this is basic stuff in JMH-land) you're saying there may be a measurable > difference between these two benchmarks: > > ? @State(Scope.Benchmark) > ? public class IntrinsicsBenchmark { > ??? int i1 = 1; > > ??? @Benchmark > ??? public int testHash0001Int_Field() { > ????? // Single read of field with unknown value > ????? return Objects.hash(i1); > ??? } > > ??? @Benchmark > ??? public int testHash0001Int_Local() { > ????? // This local variable is not constant to a Java compiler > ????? // but will be constant folded by the JIT compiler > ????? int i = 1; > ????? return Objects.hash(i); > ??? } > ? } Yes. Because JIT compiler is ought to realize "i" is constant "1" during JIT compilation time, and fold through. It is trivial to do when compiler parses the bytecode into IR, and the whole thing does not require any speculation, profile, or anything advanced at all, to be honest. Even C1 should be able to pull it off. Seeing these effects is why you use -prof perfasm to study the generated code :) -Aleksey From vicente.romero at oracle.com Sun Mar 10 18:01:10 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sun, 10 Mar 2019 18:01:10 +0000 Subject: hg: amber/amber: adding sealed as a modifier Message-ID: <201903101801.x2AI1AP1013392@aojmv0008.oracle.com> Changeset: a064f85f147a Author: vromero Date: 2019-03-10 13:41 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/a064f85f147a adding sealed as a modifier ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Type.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java ! test/langtools/tools/javac/sealed/CheckingAttributeAtRuntimeTest.java ! test/langtools/tools/javac/sealed/MethodsOfSealedTypesAreNotFinalByDefaultTest.java ! test/langtools/tools/javac/sealed/SealedDiffConfigurationsTest.java ! test/langtools/tools/javac/sealed/SealedTest01.java ! test/langtools/tools/javac/sealed/sealedExtensionNeg/SealedExtensionNegTest.java ! test/langtools/tools/javac/sealed/separate/SealedClasses.java From brian.goetz at oracle.com Tue Mar 12 12:36:21 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Tue, 12 Mar 2019 08:36:21 -0400 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> Message-ID: <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> In the real world, I would think the vast majority of cases are in the 2-10 arguments range. So thats where we need to beat Objects::hash, if we?re going to do it at all. > On Mar 6, 2019, at 1:05 PM, Vicente Romero wrote: > > Hi Hannes, > > Thanks for the results, yes the change I made was more oriented to large number of arguments so it makes sense that it is not as good for a smaller number of arguments which I agree with you should be the most common case. I think we are gathering a good case for the next amber meeting to come to a decision on the project, on the Objects::hash area. I think that there are two options: > > 1. do nothing: Objects::hash is not intrisified at all > 2. generate the fastest callsite for a small number of arguments and > generate the legit code when the number of arguments is above a > given threshold > > Comments? > > Vicente > > > On 3/6/19 12:48 PM, Hannes Walln?fer wrote: >> Vicente, >> >> I ran a number of the Objects::hash benchmarks ranging from 1 to 100 arguments with current intrinsics-project tip (a0a3f9977a7c) as well as the older version of ObjectsBootstraps.java (pre 0f40d5752eb9, see patch attached). The results I get show that with a single argument, performance is pretty much the same, but with any of number of arguments between 2 and 50 the old version is about 2x faster. It?s only with 100 arguments that the old version becomes pathetically slow, while the new version still performs decently. >> >> I guess the change in implementation was based on a too narrow set of benchmarks, and in the light of these results we should go back to the old implementation. Since invocations with > 50 arguments should be fairly uncommon I guess a simple solution such as invoking the original method via a vararg method handle would be sufficient? >> >> Hannes >> >> >> >> ** intrinsics-project tip ** >> >> Benchmark Mode Cnt Score Error Units >> IntrinsicsBenchmark.testHash1IntLoop10 thrpt 5 41721,730 ? 2477,413 ops/ms >> IntrinsicsBenchmark.testHash1StringLoop10 thrpt 5 35289,443 ? 1030,636 ops/ms >> IntrinsicsBenchmark.testHash2Ints thrpt 5 21830,140 ? 852,642 ops/ms >> IntrinsicsBenchmark.testHash2IntsLoop10 thrpt 5 19806,343 ? 1027,029 ops/ms >> IntrinsicsBenchmark.testHash2Strings thrpt 5 18409,232 ? 676,311 ops/ms >> IntrinsicsBenchmark.testHash2StringsLoop10 thrpt 5 16842,651 ? 664,615 ops/ms >> IntrinsicsBenchmark.testHash5Int5Strings thrpt 5 9183,019 ? 409,206 ops/ms >> IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5 8349,475 ? 886,015 ops/ms >> IntrinsicsBenchmark.testHash5Integers5Strings thrpt 5 9155,629 ? 335,129 ops/ms >> IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt 5 8171,108 ? 385,375 ops/ms >> IntrinsicsBenchmark.testHash5doubles5Strings thrpt 5 9246,458 ? 502,251 ops/ms >> IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt 5 8419,192 ? 372,626 ops/ms >> IntrinsicsBenchmark.testHash100Ints thrpt 5 796,460 ? 27,123 ops/ms >> IntrinsicsBenchmark.testHash100IntsLoop10 thrpt 5 792,775 ? 23,402 ops/ms >> IntrinsicsBenchmark.testHash100Strings thrpt 5 69,753 ? 45,947 ops/ms >> IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5 619,774 ? 14,503 ops/ms >> IntrinsicsBenchmark.testHash20Int20Strings thrpt 5 1669,774 ? 53,991 ops/ms >> IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5 1644,342 ? 62,946 ops/ms >> IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5 1651,428 ? 170,146 ops/ms >> IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt 5 1635,878 ? 62,007 ops/ms >> IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5 1673,927 ? 51,559 ops/ms >> IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt 5 1641,524 ? 52,172 ops/ms >> IntrinsicsBenchmark.testHash25Int25Strings thrpt 5 1286,407 ? 27,920 ops/ms >> IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5 1286,250 ? 26,125 ops/ms >> IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5 1290,251 ? 25,217 ops/ms >> IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt 5 1285,060 ? 33,297 ops/ms >> IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5 1288,374 ? 40,727 ops/ms >> IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt 5 1277,822 ? 20,674 ops/ms >> IntrinsicsBenchmark.testHash50Int50Strings thrpt 5 185,692 ? 753,244 ops/ms >> IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5 622,333 ? 12,212 ops/ms >> IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5 266,784 ? 8,620 ops/ms >> IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt 5 623,180 ? 15,583 ops/ms >> IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5 391,497 ? 33,738 ops/ms >> IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt 5 621,560 ? 12,652 ops/ms >> >> ** old version of hash bootstraps ** >> >> Benchmark Mode Cnt Score Error Units >> IntrinsicsBenchmark.testHash1IntLoop10 thrpt 5 42161,466 ? 975,935 ops/ms >> IntrinsicsBenchmark.testHash1StringLoop10 thrpt 5 35445,612 ? 1320,095 ops/ms >> IntrinsicsBenchmark.testHash2Ints thrpt 5 52157,722 ? 1089,439 ops/ms >> IntrinsicsBenchmark.testHash2IntsLoop10 thrpt 5 42223,291 ? 1107,430 ops/ms >> IntrinsicsBenchmark.testHash2Strings thrpt 5 46702,129 ? 1360,150 ops/ms >> IntrinsicsBenchmark.testHash2StringsLoop10 thrpt 5 35577,294 ? 939,756 ops/ms >> IntrinsicsBenchmark.testHash5Int5Strings thrpt 5 20351,503 ? 495,039 ops/ms >> IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5 20087,351 ? 518,764 ops/ms >> IntrinsicsBenchmark.testHash5Integers5Strings thrpt 5 20884,773 ? 648,380 ops/ms >> IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt 5 19990,317 ? 492,250 ops/ms >> IntrinsicsBenchmark.testHash5doubles5Strings thrpt 5 20913,291 ? 615,744 ops/ms >> IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt 5 20053,959 ? 538,675 ops/ms >> IntrinsicsBenchmark.testHash100Ints thrpt 5 6,625 ? 0,157 ops/ms >> IntrinsicsBenchmark.testHash100IntsLoop10 thrpt 5 6,747 ? 0,201 ops/ms >> IntrinsicsBenchmark.testHash100Strings thrpt 5 6,305 ? 1,031 ops/ms >> IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5 6,826 ? 0,154 ops/ms >> IntrinsicsBenchmark.testHash20Int20Strings thrpt 5 4188,399 ? 61,255 ops/ms >> IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5 4220,161 ? 55,642 ops/ms >> IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5 4188,347 ? 126,054 ops/ms >> IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt 5 4251,327 ? 86,473 ops/ms >> IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5 4206,733 ? 66,459 ops/ms >> IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt 5 4227,479 ? 78,542 ops/ms >> IntrinsicsBenchmark.testHash25Int25Strings thrpt 5 3162,896 ? 68,946 ops/ms >> IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5 3190,599 ? 71,035 ops/ms >> IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5 3153,547 ? 59,114 ops/ms >> IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt 5 3200,687 ? 56,650 ops/ms >> IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5 3166,884 ? 46,123 ops/ms >> IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt 5 3202,177 ? 36,159 ops/ms >> IntrinsicsBenchmark.testHash50Int50Strings thrpt 5 6,485 ? 0,054 ops/ms >> IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5 6,543 ? 0,265 ops/ms >> IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5 6,376 ? 0,150 ops/ms >> IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt 5 6,774 ? 0,159 ops/ms >> IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5 6,548 ? 0,303 ops/ms >> IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt 5 6,687 ? 0,081 ops/ms >> >>> Am 05.03.2019 um 16:31 schrieb Vicente Romero : >>> >>> >>> >>> On 3/5/19 9:02 AM, Hannes Walln?fer wrote: >>>> Vicente, >>>> >>>> could it be that your your change in Object::hash bootstraps[1] mostly benefits invocations with very large numbers of parameters (like your original 100 parameter tests) but hurts performance with medium-to-lower number of parameters? I don?t have your latest benchmark sources, but I did some quick tests such as a testHash5Ints5Strings that suggest that may be the case. >>> that could be, but the intrinsified version is still faster for those cases with small number of arguments. That's probably why I have focused on the larger number of argument case but we can change priorities or even have different callsites depending on the number of arguments >>> >>>> [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 >>>> >>>> Hannes >>> Vicente >>> >>>> >>>>> Am 05.03.2019 um 03:52 schrieb Vicente Romero : >>>>> >>>>> >>>>> >>>>> On 3/4/19 8:11 PM, Alex Buckley wrote: >>>>>> // Adopting a zero-decimal-places policy because precision to multiple decimal places is less important than accuracy and repeatability. >>>>>> >>>>>> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>>>>>> I have uploaded another round of experiments for Objects::hash, see [1]. >>>>>>> The main variation I have included a variant of most of the tests in >>>>>>> which instead of invoking Objects::hash 10 times sequentially, the same >>>>>>> invocation occurs inside a loop which is executed 10 times. This shows >>>>>>> that when the call site is reused, the execution time trumps vanilla >>>>>>> JDK13 most of the time. >>>>>> That's not really the story though :-) Yes, the *Int*StringsLoop10 tests run faster with intrinsified invocation than with vanilla invocation, but generally, the *Int*StringsLoop10 tests enjoy less impressive speedups than the *Int*Strings tests. (Example: 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) >>>>>> >>>>>> This is because the *Int*StringsLoop10 tests already run faster on vanilla JDK 13 than the *Int*Strings tests, presumably thanks to inlining ("the call site is reused"). >>>>>> >>>>>> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would have such high throughput on vanilla JDK 13 that their speedups with intrinsification might be significantly <1. >>>>> not in all cases, see [1] the new information is highlighted in yellow >>>>>> Alex >>>>> Vicente >>>>> >>>>> [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html > From vicente.romero at oracle.com Tue Mar 12 12:57:37 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 12 Mar 2019 08:57:37 -0400 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> Message-ID: On 3/12/19 8:36 AM, Brian Goetz wrote: > In the real world, I would think the vast majority of cases are in the 2-10 arguments range. So thats where we need to beat Objects::hash, if we?re going to do it at all. if that is the case we already have a solution for that > >> On Mar 6, 2019, at 1:05 PM, Vicente Romero wrote: >> >> Hi Hannes, >> >> Thanks for the results, yes the change I made was more oriented to large number of arguments so it makes sense that it is not as good for a smaller number of arguments which I agree with you should be the most common case. I think we are gathering a good case for the next amber meeting to come to a decision on the project, on the Objects::hash area. I think that there are two options: >> >> 1. do nothing: Objects::hash is not intrisified at all >> 2. generate the fastest callsite for a small number of arguments and >> generate the legit code when the number of arguments is above a >> given threshold >> >> Comments? >> >> Vicente >> >> >> On 3/6/19 12:48 PM, Hannes Walln?fer wrote: >>> Vicente, >>> >>> I ran a number of the Objects::hash benchmarks ranging from 1 to 100 arguments with current intrinsics-project tip (a0a3f9977a7c) as well as the older version of ObjectsBootstraps.java (pre 0f40d5752eb9, see patch attached). The results I get show that with a single argument, performance is pretty much the same, but with any of number of arguments between 2 and 50 the old version is about 2x faster. It?s only with 100 arguments that the old version becomes pathetically slow, while the new version still performs decently. >>> >>> I guess the change in implementation was based on a too narrow set of benchmarks, and in the light of these results we should go back to the old implementation. Since invocations with > 50 arguments should be fairly uncommon I guess a simple solution such as invoking the original method via a vararg method handle would be sufficient? >>> >>> Hannes >>> >>> >>> >>> ** intrinsics-project tip ** >>> >>> Benchmark Mode Cnt Score Error Units >>> IntrinsicsBenchmark.testHash1IntLoop10 thrpt 5 41721,730 ? 2477,413 ops/ms >>> IntrinsicsBenchmark.testHash1StringLoop10 thrpt 5 35289,443 ? 1030,636 ops/ms >>> IntrinsicsBenchmark.testHash2Ints thrpt 5 21830,140 ? 852,642 ops/ms >>> IntrinsicsBenchmark.testHash2IntsLoop10 thrpt 5 19806,343 ? 1027,029 ops/ms >>> IntrinsicsBenchmark.testHash2Strings thrpt 5 18409,232 ? 676,311 ops/ms >>> IntrinsicsBenchmark.testHash2StringsLoop10 thrpt 5 16842,651 ? 664,615 ops/ms >>> IntrinsicsBenchmark.testHash5Int5Strings thrpt 5 9183,019 ? 409,206 ops/ms >>> IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5 8349,475 ? 886,015 ops/ms >>> IntrinsicsBenchmark.testHash5Integers5Strings thrpt 5 9155,629 ? 335,129 ops/ms >>> IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt 5 8171,108 ? 385,375 ops/ms >>> IntrinsicsBenchmark.testHash5doubles5Strings thrpt 5 9246,458 ? 502,251 ops/ms >>> IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt 5 8419,192 ? 372,626 ops/ms >>> IntrinsicsBenchmark.testHash100Ints thrpt 5 796,460 ? 27,123 ops/ms >>> IntrinsicsBenchmark.testHash100IntsLoop10 thrpt 5 792,775 ? 23,402 ops/ms >>> IntrinsicsBenchmark.testHash100Strings thrpt 5 69,753 ? 45,947 ops/ms >>> IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5 619,774 ? 14,503 ops/ms >>> IntrinsicsBenchmark.testHash20Int20Strings thrpt 5 1669,774 ? 53,991 ops/ms >>> IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5 1644,342 ? 62,946 ops/ms >>> IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5 1651,428 ? 170,146 ops/ms >>> IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt 5 1635,878 ? 62,007 ops/ms >>> IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5 1673,927 ? 51,559 ops/ms >>> IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt 5 1641,524 ? 52,172 ops/ms >>> IntrinsicsBenchmark.testHash25Int25Strings thrpt 5 1286,407 ? 27,920 ops/ms >>> IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5 1286,250 ? 26,125 ops/ms >>> IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5 1290,251 ? 25,217 ops/ms >>> IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt 5 1285,060 ? 33,297 ops/ms >>> IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5 1288,374 ? 40,727 ops/ms >>> IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt 5 1277,822 ? 20,674 ops/ms >>> IntrinsicsBenchmark.testHash50Int50Strings thrpt 5 185,692 ? 753,244 ops/ms >>> IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5 622,333 ? 12,212 ops/ms >>> IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5 266,784 ? 8,620 ops/ms >>> IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt 5 623,180 ? 15,583 ops/ms >>> IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5 391,497 ? 33,738 ops/ms >>> IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt 5 621,560 ? 12,652 ops/ms >>> >>> ** old version of hash bootstraps ** >>> >>> Benchmark Mode Cnt Score Error Units >>> IntrinsicsBenchmark.testHash1IntLoop10 thrpt 5 42161,466 ? 975,935 ops/ms >>> IntrinsicsBenchmark.testHash1StringLoop10 thrpt 5 35445,612 ? 1320,095 ops/ms >>> IntrinsicsBenchmark.testHash2Ints thrpt 5 52157,722 ? 1089,439 ops/ms >>> IntrinsicsBenchmark.testHash2IntsLoop10 thrpt 5 42223,291 ? 1107,430 ops/ms >>> IntrinsicsBenchmark.testHash2Strings thrpt 5 46702,129 ? 1360,150 ops/ms >>> IntrinsicsBenchmark.testHash2StringsLoop10 thrpt 5 35577,294 ? 939,756 ops/ms >>> IntrinsicsBenchmark.testHash5Int5Strings thrpt 5 20351,503 ? 495,039 ops/ms >>> IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5 20087,351 ? 518,764 ops/ms >>> IntrinsicsBenchmark.testHash5Integers5Strings thrpt 5 20884,773 ? 648,380 ops/ms >>> IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt 5 19990,317 ? 492,250 ops/ms >>> IntrinsicsBenchmark.testHash5doubles5Strings thrpt 5 20913,291 ? 615,744 ops/ms >>> IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt 5 20053,959 ? 538,675 ops/ms >>> IntrinsicsBenchmark.testHash100Ints thrpt 5 6,625 ? 0,157 ops/ms >>> IntrinsicsBenchmark.testHash100IntsLoop10 thrpt 5 6,747 ? 0,201 ops/ms >>> IntrinsicsBenchmark.testHash100Strings thrpt 5 6,305 ? 1,031 ops/ms >>> IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5 6,826 ? 0,154 ops/ms >>> IntrinsicsBenchmark.testHash20Int20Strings thrpt 5 4188,399 ? 61,255 ops/ms >>> IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5 4220,161 ? 55,642 ops/ms >>> IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5 4188,347 ? 126,054 ops/ms >>> IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt 5 4251,327 ? 86,473 ops/ms >>> IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5 4206,733 ? 66,459 ops/ms >>> IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt 5 4227,479 ? 78,542 ops/ms >>> IntrinsicsBenchmark.testHash25Int25Strings thrpt 5 3162,896 ? 68,946 ops/ms >>> IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5 3190,599 ? 71,035 ops/ms >>> IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5 3153,547 ? 59,114 ops/ms >>> IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt 5 3200,687 ? 56,650 ops/ms >>> IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5 3166,884 ? 46,123 ops/ms >>> IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt 5 3202,177 ? 36,159 ops/ms >>> IntrinsicsBenchmark.testHash50Int50Strings thrpt 5 6,485 ? 0,054 ops/ms >>> IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5 6,543 ? 0,265 ops/ms >>> IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5 6,376 ? 0,150 ops/ms >>> IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt 5 6,774 ? 0,159 ops/ms >>> IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5 6,548 ? 0,303 ops/ms >>> IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt 5 6,687 ? 0,081 ops/ms >>> >>>> Am 05.03.2019 um 16:31 schrieb Vicente Romero : >>>> >>>> >>>> >>>> On 3/5/19 9:02 AM, Hannes Walln?fer wrote: >>>>> Vicente, >>>>> >>>>> could it be that your your change in Object::hash bootstraps[1] mostly benefits invocations with very large numbers of parameters (like your original 100 parameter tests) but hurts performance with medium-to-lower number of parameters? I don?t have your latest benchmark sources, but I did some quick tests such as a testHash5Ints5Strings that suggest that may be the case. >>>> that could be, but the intrinsified version is still faster for those cases with small number of arguments. That's probably why I have focused on the larger number of argument case but we can change priorities or even have different callsites depending on the number of arguments >>>> >>>>> [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 >>>>> >>>>> Hannes >>>> Vicente >>>> >>>>>> Am 05.03.2019 um 03:52 schrieb Vicente Romero : >>>>>> >>>>>> >>>>>> >>>>>> On 3/4/19 8:11 PM, Alex Buckley wrote: >>>>>>> // Adopting a zero-decimal-places policy because precision to multiple decimal places is less important than accuracy and repeatability. >>>>>>> >>>>>>> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>>>>>>> I have uploaded another round of experiments for Objects::hash, see [1]. >>>>>>>> The main variation I have included a variant of most of the tests in >>>>>>>> which instead of invoking Objects::hash 10 times sequentially, the same >>>>>>>> invocation occurs inside a loop which is executed 10 times. This shows >>>>>>>> that when the call site is reused, the execution time trumps vanilla >>>>>>>> JDK13 most of the time. >>>>>>> That's not really the story though :-) Yes, the *Int*StringsLoop10 tests run faster with intrinsified invocation than with vanilla invocation, but generally, the *Int*StringsLoop10 tests enjoy less impressive speedups than the *Int*Strings tests. (Example: 25Int25Strings gets a 21x speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) >>>>>>> >>>>>>> This is because the *Int*StringsLoop10 tests already run faster on vanilla JDK 13 than the *Int*Strings tests, presumably thanks to inlining ("the call site is reused"). >>>>>>> >>>>>>> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 would have such high throughput on vanilla JDK 13 that their speedups with intrinsification might be significantly <1. >>>>>> not in all cases, see [1] the new information is highlighted in yellow >>>>>>> Alex >>>>>> Vicente >>>>>> >>>>>> [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html From vicente.romero at oracle.com Wed Mar 13 00:18:47 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 12 Mar 2019 20:18:47 -0400 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> Message-ID: <355ed605-b2f6-198e-efdf-06d781d764dd@oracle.com> Hi, I have redone the experiments for Objects::hash. Now accessing fields instead of local variables and using the @State annotation. Please see the results at [1]. I have kept both implementations in the table for comparison. Now the numbers aren't as great as before but they are still better than the non-intrinsified version. Thanks, Vicente [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html On 3/12/19 8:57 AM, Vicente Romero wrote: > > > On 3/12/19 8:36 AM, Brian Goetz wrote: >> In the real world, I would think the vast majority of cases are in >> the 2-10 arguments range.? So thats where we need to beat >> Objects::hash, if we?re going to do it at all. > > if that is the case we already have a solution for that > >> >>> On Mar 6, 2019, at 1:05 PM, Vicente Romero >>> wrote: >>> >>> Hi Hannes, >>> >>> Thanks for the results, yes the change I made was more oriented to >>> large number of arguments so it makes sense that it is not as good >>> for a smaller number of arguments which I agree with you should be >>> the most common case. I think we are gathering a good case for the >>> next amber meeting to come to a decision on the project, on the >>> Objects::hash area. I think that there are two options: >>> >>> 1. do nothing: Objects::hash is not intrisified at all >>> 2. generate the fastest callsite for a small number of arguments and >>> ?? generate the legit code when the number of arguments is above a >>> ?? given threshold >>> >>> Comments? >>> >>> Vicente >>> >>> >>> On 3/6/19 12:48 PM, Hannes Walln?fer wrote: >>>> Vicente, >>>> >>>> I ran a number of the Objects::hash benchmarks ranging from 1 to >>>> 100 arguments with current intrinsics-project tip (a0a3f9977a7c) as >>>> well as the older version of ObjectsBootstraps.java (pre >>>> 0f40d5752eb9, see patch attached). The results I get show that with >>>> a single argument, performance is pretty much the same, but with >>>> any of number of arguments between 2 and 50 the old version is >>>> about 2x faster. It?s only with 100 arguments that the old version >>>> becomes pathetically slow, while the new version still performs >>>> decently. >>>> >>>> I guess the change in implementation was based on a too narrow set >>>> of benchmarks, and in the light of these results we should go back >>>> to the old implementation. Since invocations with > 50 arguments >>>> should be fairly uncommon I guess a simple solution such as >>>> invoking the original method via a vararg method handle would be >>>> sufficient? >>>> >>>> Hannes >>>> >>>> >>>> >>>> ** intrinsics-project tip ** >>>> >>>> Benchmark Mode? Cnt????? Score????? Error?? Units >>>> IntrinsicsBenchmark.testHash1IntLoop10 thrpt??? 5? 41721,730 ? >>>> 2477,413? ops/ms >>>> IntrinsicsBenchmark.testHash1StringLoop10 thrpt??? 5? 35289,443 ? >>>> 1030,636? ops/ms >>>> IntrinsicsBenchmark.testHash2Ints thrpt??? 5? 21830,140 ?? 852,642? >>>> ops/ms >>>> IntrinsicsBenchmark.testHash2IntsLoop10 thrpt??? 5? 19806,343 ? >>>> 1027,029? ops/ms >>>> IntrinsicsBenchmark.testHash2Strings thrpt??? 5? 18409,232 ?? >>>> 676,311? ops/ms >>>> IntrinsicsBenchmark.testHash2StringsLoop10 thrpt??? 5? 16842,651 ?? >>>> 664,615? ops/ms >>>> IntrinsicsBenchmark.testHash5Int5Strings thrpt??? 5?? 9183,019 ?? >>>> 409,206? ops/ms >>>> IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt??? 5?? >>>> 8349,475 ?? 886,015? ops/ms >>>> IntrinsicsBenchmark.testHash5Integers5Strings thrpt??? 5?? 9155,629 >>>> ?? 335,129? ops/ms >>>> IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt??? 5?? >>>> 8171,108 ?? 385,375? ops/ms >>>> IntrinsicsBenchmark.testHash5doubles5Strings thrpt??? 5?? 9246,458 >>>> ?? 502,251? ops/ms >>>> IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt??? 5?? >>>> 8419,192 ?? 372,626? ops/ms >>>> IntrinsicsBenchmark.testHash100Ints thrpt??? 5??? 796,460 ??? >>>> 27,123? ops/ms >>>> IntrinsicsBenchmark.testHash100IntsLoop10 thrpt??? 5??? 792,775 ??? >>>> 23,402? ops/ms >>>> IntrinsicsBenchmark.testHash100Strings thrpt??? 5???? 69,753 ??? >>>> 45,947? ops/ms >>>> IntrinsicsBenchmark.testHash100StringsLoop10 thrpt??? 5??? 619,774 >>>> ??? 14,503? ops/ms >>>> IntrinsicsBenchmark.testHash20Int20Strings thrpt??? 5?? 1669,774 >>>> ??? 53,991? ops/ms >>>> IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt??? 5?? >>>> 1644,342 ??? 62,946? ops/ms >>>> IntrinsicsBenchmark.testHash20Integers20Strings thrpt??? 5?? >>>> 1651,428 ?? 170,146? ops/ms >>>> IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt??? 5?? >>>> 1635,878 ??? 62,007? ops/ms >>>> IntrinsicsBenchmark.testHash20doubles20Strings thrpt??? 5?? >>>> 1673,927 ??? 51,559? ops/ms >>>> IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt??? 5?? >>>> 1641,524 ??? 52,172? ops/ms >>>> IntrinsicsBenchmark.testHash25Int25Strings thrpt??? 5?? 1286,407 >>>> ??? 27,920? ops/ms >>>> IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt??? 5?? >>>> 1286,250 ??? 26,125? ops/ms >>>> IntrinsicsBenchmark.testHash25Integers25Strings thrpt??? 5?? >>>> 1290,251 ??? 25,217? ops/ms >>>> IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt??? 5?? >>>> 1285,060 ??? 33,297? ops/ms >>>> IntrinsicsBenchmark.testHash25doubles25Strings thrpt??? 5?? >>>> 1288,374 ??? 40,727? ops/ms >>>> IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt??? 5?? >>>> 1277,822 ??? 20,674? ops/ms >>>> IntrinsicsBenchmark.testHash50Int50Strings thrpt??? 5??? 185,692 ?? >>>> 753,244? ops/ms >>>> IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt??? 5??? >>>> 622,333 ??? 12,212? ops/ms >>>> IntrinsicsBenchmark.testHash50Integers50Strings thrpt??? 5??? >>>> 266,784 ???? 8,620? ops/ms >>>> IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt??? 5??? >>>> 623,180 ??? 15,583? ops/ms >>>> IntrinsicsBenchmark.testHash50doubles50Strings thrpt??? 5??? >>>> 391,497 ??? 33,738? ops/ms >>>> IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt??? 5??? >>>> 621,560 ??? 12,652? ops/ms >>>> >>>> ** old version of hash bootstraps ** >>>> >>>> Benchmark Mode? Cnt????? Score????? Error?? Units >>>> IntrinsicsBenchmark.testHash1IntLoop10 thrpt??? 5? 42161,466 ?? >>>> 975,935? ops/ms >>>> IntrinsicsBenchmark.testHash1StringLoop10 thrpt??? 5? 35445,612 ? >>>> 1320,095? ops/ms >>>> IntrinsicsBenchmark.testHash2Ints thrpt??? 5? 52157,722 ? 1089,439? >>>> ops/ms >>>> IntrinsicsBenchmark.testHash2IntsLoop10 thrpt??? 5? 42223,291 ? >>>> 1107,430? ops/ms >>>> IntrinsicsBenchmark.testHash2Strings thrpt??? 5? 46702,129 ? >>>> 1360,150? ops/ms >>>> IntrinsicsBenchmark.testHash2StringsLoop10 thrpt??? 5? 35577,294 ?? >>>> 939,756? ops/ms >>>> IntrinsicsBenchmark.testHash5Int5Strings thrpt??? 5? 20351,503 ?? >>>> 495,039? ops/ms >>>> IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt??? 5? >>>> 20087,351 ?? 518,764? ops/ms >>>> IntrinsicsBenchmark.testHash5Integers5Strings thrpt??? 5? 20884,773 >>>> ?? 648,380? ops/ms >>>> IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt??? 5? >>>> 19990,317 ?? 492,250? ops/ms >>>> IntrinsicsBenchmark.testHash5doubles5Strings thrpt??? 5? 20913,291 >>>> ?? 615,744? ops/ms >>>> IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt??? 5? >>>> 20053,959 ?? 538,675? ops/ms >>>> IntrinsicsBenchmark.testHash100Ints thrpt??? 5????? 6,625 ???? >>>> 0,157? ops/ms >>>> IntrinsicsBenchmark.testHash100IntsLoop10 thrpt??? 5????? 6,747 >>>> ???? 0,201? ops/ms >>>> IntrinsicsBenchmark.testHash100Strings thrpt??? 5????? 6,305 ???? >>>> 1,031? ops/ms >>>> IntrinsicsBenchmark.testHash100StringsLoop10 thrpt??? 5????? 6,826 >>>> ???? 0,154? ops/ms >>>> IntrinsicsBenchmark.testHash20Int20Strings thrpt??? 5?? 4188,399 >>>> ??? 61,255? ops/ms >>>> IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt??? 5?? >>>> 4220,161 ??? 55,642? ops/ms >>>> IntrinsicsBenchmark.testHash20Integers20Strings thrpt??? 5?? >>>> 4188,347 ?? 126,054? ops/ms >>>> IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt??? 5?? >>>> 4251,327 ??? 86,473? ops/ms >>>> IntrinsicsBenchmark.testHash20doubles20Strings thrpt??? 5?? >>>> 4206,733 ??? 66,459? ops/ms >>>> IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt??? 5?? >>>> 4227,479 ??? 78,542? ops/ms >>>> IntrinsicsBenchmark.testHash25Int25Strings thrpt??? 5?? 3162,896 >>>> ??? 68,946? ops/ms >>>> IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt??? 5?? >>>> 3190,599 ??? 71,035? ops/ms >>>> IntrinsicsBenchmark.testHash25Integers25Strings thrpt??? 5?? >>>> 3153,547 ??? 59,114? ops/ms >>>> IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt??? 5?? >>>> 3200,687 ??? 56,650? ops/ms >>>> IntrinsicsBenchmark.testHash25doubles25Strings thrpt??? 5?? >>>> 3166,884 ??? 46,123? ops/ms >>>> IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt??? 5?? >>>> 3202,177 ??? 36,159? ops/ms >>>> IntrinsicsBenchmark.testHash50Int50Strings thrpt??? 5????? 6,485 >>>> ???? 0,054? ops/ms >>>> IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt??? 5????? >>>> 6,543 ???? 0,265? ops/ms >>>> IntrinsicsBenchmark.testHash50Integers50Strings thrpt??? 5????? >>>> 6,376 ???? 0,150? ops/ms >>>> IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt??? >>>> 5????? 6,774 ???? 0,159? ops/ms >>>> IntrinsicsBenchmark.testHash50doubles50Strings thrpt??? 5????? >>>> 6,548 ???? 0,303? ops/ms >>>> IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt??? >>>> 5????? 6,687 ???? 0,081? ops/ms >>>> >>>>> Am 05.03.2019 um 16:31 schrieb Vicente Romero >>>>> : >>>>> >>>>> >>>>> >>>>> On 3/5/19 9:02 AM, Hannes Walln?fer wrote: >>>>>> Vicente, >>>>>> >>>>>> could it be that your your change in Object::hash bootstraps[1] >>>>>> mostly benefits invocations with very large numbers of parameters >>>>>> (like your original 100 parameter tests) but hurts performance >>>>>> with medium-to-lower number of parameters? I don?t have your >>>>>> latest benchmark sources, but I did some quick tests such as a >>>>>> testHash5Ints5Strings that suggest that may be the case. >>>>> that could be, but the intrinsified version is still faster for >>>>> those cases with small number of arguments. That's probably why I >>>>> have focused on the larger number of argument case but we can >>>>> change priorities or even have different callsites depending on >>>>> the number of arguments >>>>> >>>>>> [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 >>>>>> >>>>>> Hannes >>>>> Vicente >>>>> >>>>>>> Am 05.03.2019 um 03:52 schrieb Vicente Romero >>>>>>> : >>>>>>> >>>>>>> >>>>>>> >>>>>>> On 3/4/19 8:11 PM, Alex Buckley wrote: >>>>>>>> // Adopting a zero-decimal-places policy because precision to >>>>>>>> multiple decimal places is less important than accuracy and >>>>>>>> repeatability. >>>>>>>> >>>>>>>> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>>>>>>>> I have uploaded another round of experiments for >>>>>>>>> Objects::hash, see [1]. >>>>>>>>> The main variation I have included a variant of most of the >>>>>>>>> tests in >>>>>>>>> which instead of invoking Objects::hash 10 times sequentially, >>>>>>>>> the same >>>>>>>>> invocation occurs inside a loop which is executed 10 times. >>>>>>>>> This shows >>>>>>>>> that when the call site is reused, the execution time trumps >>>>>>>>> vanilla >>>>>>>>> JDK13 most of the time. >>>>>>>> That's not really the story though :-) Yes, the >>>>>>>> *Int*StringsLoop10 tests run faster with intrinsified >>>>>>>> invocation than with vanilla invocation, but generally, the >>>>>>>> *Int*StringsLoop10 tests enjoy less impressive speedups than >>>>>>>> the *Int*Strings tests. (Example: 25Int25Strings gets a 21x >>>>>>>> speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) >>>>>>>> >>>>>>>> This is because the *Int*StringsLoop10 tests already run faster >>>>>>>> on vanilla JDK 13 than the *Int*Strings tests, presumably >>>>>>>> thanks to inlining ("the call site is reused"). >>>>>>>> >>>>>>>> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 >>>>>>>> would have such high throughput on vanilla JDK 13 that their >>>>>>>> speedups with intrinsification might be significantly <1. >>>>>>> not in all cases, see [1] the new information is highlighted in >>>>>>> yellow >>>>>>>> Alex >>>>>>> Vicente >>>>>>> >>>>>>> [1] >>>>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html > From vicente.romero at oracle.com Thu Mar 14 16:19:13 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 14 Mar 2019 16:19:13 +0000 Subject: hg: amber/amber: allowing nested type declaratios in records Message-ID: <201903141619.x2EGJE1Y006266@aojmv0008.oracle.com> Changeset: ee1dea3bfa8f Author: vromero Date: 2019-03-14 12:18 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/ee1dea3bfa8f allowing nested type declaratios in records ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! test/langtools/tools/javac/datum/NoAddFieldsCanBeDeclaredInDatumTest.java ! test/langtools/tools/javac/datum/NoAddFieldsCanBeDeclaredInDatumTest.out From vicente.romero at oracle.com Thu Mar 14 16:43:03 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Thu, 14 Mar 2019 16:43:03 +0000 Subject: hg: amber/amber: manual merge with default Message-ID: <201903141643.x2EGh3Na022069@aojmv0008.oracle.com> Changeset: 868e1b4eb283 Author: vromero Date: 2019-03-14 12:42 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/868e1b4eb283 manual merge with default - src/hotspot/share/prims/evmCompat.cpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotatedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationDesc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationTypeElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/AnnotationValue.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ClassDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ConstructorDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/DocErrorReporter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Doclet.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ExecutableMemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/FieldDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/LanguageVersion.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MemberDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/MethodDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/PackageDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParamTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Parameter.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ParameterizedType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ProgramElementDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/RootDoc.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SeeTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SerialFieldTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/SourcePosition.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Tag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/ThrowsTag.java - src/jdk.javadoc/share/classes/com/sun/javadoc/Type.java - src/jdk.javadoc/share/classes/com/sun/javadoc/TypeVariable.java - src/jdk.javadoc/share/classes/com/sun/javadoc/WildcardType.java - src/jdk.javadoc/share/classes/com/sun/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/Standard.java - src/jdk.javadoc/share/classes/com/sun/tools/doclets/standard/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/Main.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AbstractTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotatedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationDescImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationTypeElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/AnnotationValueImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ClassDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Comment.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ConstructorDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocEnv.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocLocale.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/DocletInvoker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ExecutableMemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/FieldDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavaScriptScanner.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocClassFinder.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocMemberEnter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTodo.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/JavadocTool.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MemberDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Messager.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/MethodDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ModifierFilter.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PackageDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParamTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ParameterizedTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/PrimitiveType.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ProgramElementDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/RootDocImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SeeTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerialFieldTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SerializedForm.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/SourcePositionImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/Start.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ThrowsTagImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/ToolOption.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeMaker.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/TypeVariableImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/main/WildcardTypeImpl.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/package-info.java - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties - src/jdk.javadoc/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Headings.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MarkerComments.java - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java - test/langtools/jdk/javadoc/lib/javadoc/tester/ShowHeadings.java - test/langtools/jdk/javadoc/tool/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/6176978/T6176978.java - test/langtools/tools/javadoc/6176978/X.java - test/langtools/tools/javadoc/6227454/Test.java - test/langtools/tools/javadoc/6942366/T6942366.java - test/langtools/tools/javadoc/6942366/Test.java - test/langtools/tools/javadoc/6942366/p/Base.java - test/langtools/tools/javadoc/6958836/Test.java - test/langtools/tools/javadoc/6964914/Error.java - test/langtools/tools/javadoc/6964914/JavacWarning.java - test/langtools/tools/javadoc/6964914/JavadocWarning.java - test/langtools/tools/javadoc/6964914/Test.java - test/langtools/tools/javadoc/6964914/TestStdDoclet.java - test/langtools/tools/javadoc/6964914/TestUserDoclet.java - test/langtools/tools/javadoc/8025693/Test.java - test/langtools/tools/javadoc/8147801/T8147801.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib1.java - test/langtools/tools/javadoc/8147801/jarsrc/lib/Lib2.java - test/langtools/tools/javadoc/8147801/p/Test.java - test/langtools/tools/javadoc/AddOpensTest.java - test/langtools/tools/javadoc/BadOptionsTest.java - test/langtools/tools/javadoc/BooleanConst.java - test/langtools/tools/javadoc/BreakIteratorWarning.java - test/langtools/tools/javadoc/CheckResourceKeys.java - test/langtools/tools/javadoc/CompletionError.java - test/langtools/tools/javadoc/EncodingTest.java - test/langtools/tools/javadoc/FlagsTooEarly.java - test/langtools/tools/javadoc/InlineTagsWithBraces.java - test/langtools/tools/javadoc/LangVers.java - test/langtools/tools/javadoc/MaxWarns.java - test/langtools/tools/javadoc/MethodLinks.java - test/langtools/tools/javadoc/NoStar.java - test/langtools/tools/javadoc/ReleaseOption.java - test/langtools/tools/javadoc/ReleaseOptionSource.java - test/langtools/tools/javadoc/T4994049/FileWithTabs.java - test/langtools/tools/javadoc/T4994049/T4994049.java - test/langtools/tools/javadoc/T6968833.java - test/langtools/tools/javadoc/XWerror.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/Main.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/expected.out - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/B.java - test/langtools/tools/javadoc/annotations/annotateMethodsFields/pkg1/E.java - test/langtools/tools/javadoc/annotations/annotatePackage/Main.java - test/langtools/tools/javadoc/annotations/annotatePackage/expected.out - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package-info.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg1/package.html - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/B.java - test/langtools/tools/javadoc/annotations/annotatePackage/pkg2/package.html - test/langtools/tools/javadoc/annotations/annotateParams/Main.java - test/langtools/tools/javadoc/annotations/annotateParams/expected.out - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/A.java - test/langtools/tools/javadoc/annotations/annotateParams/pkg1/C.java - test/langtools/tools/javadoc/annotations/badVals/Main.java - test/langtools/tools/javadoc/annotations/badVals/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/Main.java - test/langtools/tools/javadoc/annotations/defaults/expected.out - test/langtools/tools/javadoc/annotations/defaults/pkg1/A.java - test/langtools/tools/javadoc/annotations/defaults/pkg1/B.java - test/langtools/tools/javadoc/annotations/elementTypes/Main.java - test/langtools/tools/javadoc/annotations/elementTypes/expected.out - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/A.java - test/langtools/tools/javadoc/annotations/elementTypes/pkg1/B.java - test/langtools/tools/javadoc/annotations/missing/Main.java - test/langtools/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java - test/langtools/tools/javadoc/annotations/shortcuts/Main.java - test/langtools/tools/javadoc/annotations/shortcuts/expected.out - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/A.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Array.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Marker.java - test/langtools/tools/javadoc/annotations/shortcuts/pkg1/Value.java - test/langtools/tools/javadoc/api/basic/APITest.java - test/langtools/tools/javadoc/api/basic/DocletPathTest.java - test/langtools/tools/javadoc/api/basic/DocumentationToolLocationTest.java - test/langtools/tools/javadoc/api/basic/GetSourceVersionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DiagListenerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_DocletClassTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileManagerTest.java - test/langtools/tools/javadoc/api/basic/GetTask_FileObjectsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_OptionsTest.java - test/langtools/tools/javadoc/api/basic/GetTask_WriterTest.java - test/langtools/tools/javadoc/api/basic/Task_reuseTest.java - test/langtools/tools/javadoc/api/basic/pkg/C.java - test/langtools/tools/javadoc/api/basic/taglets/UnderlineTaglet.java - test/langtools/tools/javadoc/completionFailure/CompletionFailure.java - test/langtools/tools/javadoc/completionFailure/pkg/A.java - test/langtools/tools/javadoc/completionFailure/pkg/B.java - test/langtools/tools/javadoc/dupOk/DupOk.java - test/langtools/tools/javadoc/dupOk/sp1/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/A.java - test/langtools/tools/javadoc/dupOk/sp2/p/B.java - test/langtools/tools/javadoc/enum/docComments/Main.java - test/langtools/tools/javadoc/enum/docComments/pkg1/Operation.java - test/langtools/tools/javadoc/enum/enumType/Main.java - test/langtools/tools/javadoc/enum/enumType/expected.out - test/langtools/tools/javadoc/enum/enumType/pkg1/QuotablePerson.java - test/langtools/tools/javadoc/generics/genericClass/Main.java - test/langtools/tools/javadoc/generics/genericClass/expected.out - test/langtools/tools/javadoc/generics/genericClass/pkg1/A.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/Main.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/expected.out - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/O.java - test/langtools/tools/javadoc/generics/genericInnerAndOuter/pkg1/X.java - test/langtools/tools/javadoc/generics/genericInterface/Main.java - test/langtools/tools/javadoc/generics/genericInterface/expected.out - test/langtools/tools/javadoc/generics/genericInterface/pkg1/A.java - test/langtools/tools/javadoc/generics/genericMethod/Main.java - test/langtools/tools/javadoc/generics/genericMethod/expected.out - test/langtools/tools/javadoc/generics/genericMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/genericSuper/Main.java - test/langtools/tools/javadoc/generics/genericSuper/expected.out - test/langtools/tools/javadoc/generics/genericSuper/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/Main.java - test/langtools/tools/javadoc/generics/supertypes/expected.out - test/langtools/tools/javadoc/generics/supertypes/pkg1/A.java - test/langtools/tools/javadoc/generics/supertypes/pkg1/B.java - test/langtools/tools/javadoc/generics/throwsGeneric/Main.java - test/langtools/tools/javadoc/generics/throwsGeneric/expected.out - test/langtools/tools/javadoc/generics/throwsGeneric/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamCycle/Main.java - test/langtools/tools/javadoc/generics/tparamCycle/pkg1/LikeEnum.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnMethod/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnMethod/pkg1/A.java - test/langtools/tools/javadoc/generics/tparamTagOnType/Main.java - test/langtools/tools/javadoc/generics/tparamTagOnType/expected.out - test/langtools/tools/javadoc/generics/tparamTagOnType/pkg1/A.java - test/langtools/tools/javadoc/generics/wildcards/Main.java - test/langtools/tools/javadoc/generics/wildcards/expected.out - test/langtools/tools/javadoc/generics/wildcards/pkg1/A.java - test/langtools/tools/javadoc/imports/I.java - test/langtools/tools/javadoc/imports/MissingImport.java - test/langtools/tools/javadoc/lib/OldToolTester.java - test/langtools/tools/javadoc/lib/ToyDoclet.java - test/langtools/tools/javadoc/nestedClass/NestedClass.java - test/langtools/tools/javadoc/nestedClass/NestedClassB.java - test/langtools/tools/javadoc/nonConstExprs/Test.java - test/langtools/tools/javadoc/outputRedirect/Test.java - test/langtools/tools/javadoc/outputRedirect/p/OutputRedirect.java - test/langtools/tools/javadoc/parser/7091528/T7091528.java - test/langtools/tools/javadoc/parser/7091528/p/C1.java - test/langtools/tools/javadoc/parser/7091528/p/C3.java - test/langtools/tools/javadoc/parser/7091528/p/q/C2.java - test/langtools/tools/javadoc/sourceOnly/Test.java - test/langtools/tools/javadoc/sourceOnly/p/NonSource.jasm - test/langtools/tools/javadoc/sourceOnly/p/SourceOnly.java - test/langtools/tools/javadoc/sourceOption/SourceOption.java - test/langtools/tools/javadoc/sourceOption/p/LambdaConstructTest.java - test/langtools/tools/javadoc/subpackageIgnore/SubpackageIgnore.java - test/langtools/tools/javadoc/subpackageIgnore/pkg1/not-subpkg/SomeJavaFile.java - test/langtools/tools/javadoc/varArgs/Main.java - test/langtools/tools/javadoc/varArgs/expected.out - test/langtools/tools/javadoc/varArgs/pkg1/A.java From maurizio.cimadamore at oracle.com Thu Mar 14 21:05:35 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 14 Mar 2019 21:05:35 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903142105.x2EL5a8v021196@aojmv0008.oracle.com> Changeset: 06bf5ec8e8f9 Author: mcimadamore Date: 2019-03-14 22:05 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/06bf5ec8e8f9 Automatic merge with default - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From maurizio.cimadamore at oracle.com Thu Mar 14 21:05:57 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 14 Mar 2019 21:05:57 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903142105.x2EL5vlw021667@aojmv0008.oracle.com> Changeset: db61ecbe36dd Author: mcimadamore Date: 2019-03-14 22:05 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/db61ecbe36dd Automatic merge with default - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From maurizio.cimadamore at oracle.com Thu Mar 14 21:02:59 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 14 Mar 2019 21:02:59 +0000 Subject: hg: amber/amber: 178 new changesets Message-ID: <201903142103.x2EL3Bd4019524@aojmv0008.oracle.com> Changeset: 6c3fd94de35a Author: dtitov Date: 2019-02-28 13:12 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/6c3fd94de35a 8207367: 10 vmTestbase/nsk/jdi tests timed out when running with jtreg Reviewed-by: sspitsyn, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassUnloadRequest/addClassExclusionFilter/exclfilter001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ClassUnloadRequest/addClassFilter/filter001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/Event/_itself_/event001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove/remove004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove/remove004a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove_l/remove_l004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove_l/remove_l004a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/suspend/suspend001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose002a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose004.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose004a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/suspend/suspend001.java Changeset: e5b461681b88 Author: redestad Date: 2019-02-28 22:11 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/e5b461681b88 8219922: Simplify and optimize IndexSetIterator::next using count_trailing_zeros Reviewed-by: kvn, neliasso ! src/hotspot/share/opto/indexSet.cpp ! src/hotspot/share/opto/indexSet.hpp Changeset: 2653e078b057 Author: coleenp Date: 2019-02-28 16:30 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/2653e078b057 8218266: G1 crash in AccessInternal::PostRuntimeDispatch Summary: protection_domains can be unloaded in the dictionary pd_set. Reviewed-by: zgu, hseigel ! src/hotspot/share/classfile/dictionary.cpp ! src/hotspot/share/classfile/dictionary.hpp - src/hotspot/share/classfile/dictionary.inline.hpp ! src/hotspot/share/classfile/protectionDomainCache.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! test/hotspot/jtreg/runtime/Dictionary/ProtectionDomainCacheTest.java ! test/hotspot/jtreg/runtime/Dictionary/test.policy Changeset: 7f01a85f2710 Author: naoto Date: 2019-02-28 14:03 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/7f01a85f2710 8219890: Calendar.getDisplayName() returns empty string for new Japanese Era on some locales Reviewed-by: lancea ! src/java.base/share/classes/java/util/JapaneseImperialCalendar.java ! test/jdk/java/util/Calendar/JapaneseEraNameTest.java Changeset: 393348e562c1 Author: naoto Date: 2019-02-28 14:05 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/393348e562c1 Merge - src/hotspot/share/classfile/dictionary.inline.hpp Changeset: 86ee52ca11e3 Author: dholmes Date: 2019-02-28 18:28 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/86ee52ca11e3 8219492: Restore static callsite resolution for the current class Reviewed-by: redestad, lfoltan, vlivanov ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: b378fc877045 Author: kvn Date: 2019-02-28 17:16 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/b378fc877045 8219951: Build failure on Mac and Windows after JDK-8219922 Summary: Add missing parentheses. Reviewed-by: dholmes ! src/hotspot/share/opto/indexSet.hpp Changeset: 2bd3e05d4c6f Author: ngasson Date: 2019-02-19 14:11 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/2bd3e05d4c6f 8209413: AArch64: NPE in clhsdb jstack command Reviewed-by: aph ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64CurrentFrameGuess.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64Frame.java Changeset: 6862a1997fbb Author: mbaesken Date: 2019-02-28 10:28 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/6862a1997fbb 8219746: Provide virtualization related info in the hs_error file on linux ppc64 / ppc64le Reviewed-by: dholmes, lucy, mdoerr ! src/hotspot/os/linux/os_linux.cpp Changeset: b342deab639f Author: clanger Date: 2019-03-01 10:15 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/b342deab639f 8219915: [TESTBUG] Fix test langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java in Standalone mode Reviewed-by: jlahoda ! test/langtools/tools/javac/processing/model/completionfailure/SymbolsDontCumulate.java Changeset: 1ad7c590a6e7 Author: stuefe Date: 2019-02-10 09:10 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/1ad7c590a6e7 8218988: Improve metaspace verifications Reviewed-by: zgu, coleenp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/memory/metaspace/chunkManager.cpp ! src/hotspot/share/memory/metaspace/chunkManager.hpp ! src/hotspot/share/memory/metaspace/metaDebug.hpp ! src/hotspot/share/memory/metaspace/metaspaceCommon.hpp ! src/hotspot/share/memory/metaspace/spaceManager.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp ! src/hotspot/share/runtime/globals.hpp Changeset: 1019c97e1bde Author: dholmes Date: 2019-03-01 08:14 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/1019c97e1bde 8219969: Backout JDK-8219492 Reviewed-by: goetz, hseigel, tschatzl ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: 43c2ab1bdfd3 Author: xuelei Date: 2019-03-01 08:35 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/43c2ab1bdfd3 8215430: Remove the internal package com.sun.net.ssl Reviewed-by: chegar, mullan, wetmore - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java ! src/java.base/share/classes/java/security/Security.java ! src/java.base/share/classes/java/security/Signature.java ! src/java.base/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java ! src/java.base/share/classes/sun/net/www/protocol/https/HttpsURLConnectionImpl.java ! src/java.base/share/classes/sun/security/jca/ProviderConfig.java ! src/java.base/share/classes/sun/security/ssl/SunJSSE.java ! test/jdk/TEST.groups - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java ! test/jdk/java/security/BasicPermission/Wildcard.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java ! test/jdk/javax/net/ssl/GetInstance.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java ! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/CheckMethods.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java ! test/jdk/sun/security/ssl/X509TrustManagerImpl/CheckNullEntity.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java Changeset: db37ce5664e3 Author: mdoerr Date: 2019-03-01 17:48 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/db37ce5664e3 8219582: PPC: Crash after C1 checkcast patched and GC Reviewed-by: akozlov, goetz ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp Changeset: c9f2b71057c1 Author: xuelei Date: 2019-03-01 09:42 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/c9f2b71057c1 8219990: Backout JDK-8219658 Reviewed-by: dfuchs ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: b31780c0c4c9 Author: jiefu Date: 2019-03-01 10:00 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/b31780c0c4c9 8219919: RuntimeStub name lost with PrintFrameConverterAssembly Reviewed-by: kvn ! src/hotspot/share/opto/output.cpp Changeset: 5d97784f08bf Author: jjg Date: 2019-03-01 11:01 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/5d97784f08bf 8219803: Nodeca Pako license text needs to be inserted in JSZip license text Reviewed-by: darcy ! src/jdk.javadoc/share/legal/jszip.md Changeset: 723f665d0596 Author: igerasim Date: 2019-03-01 12:47 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/723f665d0596 8218228: The constructor StringBuffer(CharSequence) violates spec for negatively sized argument Reviewed-by: rriggs, darcy ! src/java.base/share/classes/java/lang/AbstractStringBuilder.java ! src/java.base/share/classes/java/lang/StringBuffer.java ! test/jdk/java/lang/StringBuffer/AppendCharSequence.java Changeset: 581c2f4f82d3 Author: xuelei Date: 2019-03-01 13:08 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/581c2f4f82d3 8219994: CheckSecurityProvider.java fails with unexpected sun.security.ssl.SunJSSE Reviewed-by: mullan, wetmore ! test/jdk/java/lang/SecurityManager/CheckSecurityProvider.java Changeset: 70c7c4db9c9a Author: dchuyko Date: 2019-03-02 11:42 +0300 URL: http://hg.openjdk.java.net/amber/amber/rev/70c7c4db9c9a 8214854: JDWP: Unforseen output truncation in logging Reviewed-by: cjplummer, dholmes ! src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c Changeset: f3fd73c3a077 Author: zgu Date: 2019-03-02 08:33 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/f3fd73c3a077 8219976: GarbageCollectionNotificationInfo always says "No GC" when running Shenandoah Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahUtils.cpp Changeset: d489081c5650 Author: dholmes Date: 2019-03-02 18:09 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/d489081c5650 8219619: Remove UseFakeTimers and related code Reviewed-by: zgu, redestad ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/runtime/globals.hpp Changeset: 05d35241e1e9 Author: jlahoda Date: 2019-03-04 10:19 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/05d35241e1e9 8217868: Crash for overlap between source path and patch module path Summary: When analyzing implicit files, do not look for containing module, but rather use the already known one. Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Modules.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocTool.java ! test/langtools/tools/javac/modules/PatchModulesTest.java Changeset: 7935353a466a Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/7935353a466a 8218880: G1 crashes when issuing a periodic GC while the GCLocker is held Summary: Do not wait for the GC locker in the periodic GC thread as the GC locker being held is an indication for being busy anyway. Reviewed-by: kbarrett, shade ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1VMOperations.cpp ! src/hotspot/share/gc/g1/g1VMOperations.hpp ! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp + test/hotspot/jtreg/gc/g1/TestPeriodicCollectionJNI.java + test/hotspot/jtreg/gc/g1/libTestPeriodicCollectionJNI.c Changeset: 31884d19e945 Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/31884d19e945 8219369: Add named constants for iterating ExtRootScan phases Reviewed-by: kbarrett, sangheki ! src/hotspot/share/gc/g1/g1GCPhaseTimes.cpp ! src/hotspot/share/gc/g1/g1GCPhaseTimes.hpp Changeset: 0da5c17f5e43 Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/0da5c17f5e43 8219747: Remove g1_ prefix to g1_remset and g1_policy members in G1CollectedHeap Reviewed-by: shade, sangheki ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectorPolicy.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.inline.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkThread.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/g1/g1HeapTransition.cpp ! src/hotspot/share/gc/g1/g1HeapVerifier.cpp ! src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.cpp ! src/hotspot/share/gc/g1/g1MonitoringSupport.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RootProcessor.cpp ! src/hotspot/share/gc/g1/g1VMOperations.cpp ! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp ! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/gc/shared/gcVMOperations.cpp ! src/hotspot/share/prims/whitebox.cpp Changeset: 9ad20fd52b19 Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/9ad20fd52b19 8219748: Add and use getter for the timing object in G1 Reviewed-by: shade, kbarrett ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1HeapVerifier.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RootProcessor.cpp Changeset: e1f707ed0757 Author: tschatzl Date: 2019-03-04 11:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/e1f707ed0757 8219856: Spell out G1CollectorPolicy::is_hetero_heap Reviewed-by: sangheki, kbarrett ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectorPolicy.cpp ! src/hotspot/share/gc/g1/g1CollectorPolicy.hpp ! src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.cpp ! src/hotspot/share/gc/g1/g1HeterogeneousCollectorPolicy.hpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1YoungGenSizer.cpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/prims/whitebox.cpp Changeset: efa9bc147d50 Author: gadams Date: 2019-03-04 08:45 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/efa9bc147d50 4903717: nsk/jdi/ThreadReference/isSuspended/issuspended002 failing Reviewed-by: amenkov, sspitsyn ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/isSuspended/issuspended002a.java Changeset: 247f1a85d736 Author: fyang Date: 2019-03-01 14:38 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/247f1a85d736 8219888: aarch64: add CPU detection code for HiSilicon TSV110 Reviewed-by: aph, drwhite, pzhang Contributed-by: dongbo4 at huawei.com ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp ! src/hotspot/cpu/aarch64/vm_version_aarch64.hpp Changeset: 8c82412da698 Author: kevinw Date: 2019-03-01 04:34 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/8c82412da698 8219513: compiler/codegen/aes/TestCipherBlockChainingEncrypt.java timeout on Solaris-sparc Reviewed-by: kvn, iignatyev Contributed-by: fairoz.matte at oracle.com ! test/hotspot/jtreg/compiler/codegen/aes/TestCipherBlockChainingEncrypt.java Changeset: 786825220790 Author: jjg Date: 2019-03-04 11:19 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/786825220790 8219801: Pages do not have

Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/EnumConstantWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Headings.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialMethodWriter.java + src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MarkerComments.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testAnnotationTypes/TestAnnotationTypes.java ! test/langtools/jdk/javadoc/doclet/testHeadings/TestHeadings.java ! test/langtools/jdk/javadoc/doclet/testHiddenTag/TestHiddenTag.java ! test/langtools/jdk/javadoc/doclet/testHref/TestHref.java ! test/langtools/jdk/javadoc/doclet/testHtmlLandmarkRegions/TestHtmlLandmarkRegions.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testIndexTaglet/TestIndexTaglet.java ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModuleServices.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/langtools/jdk/javadoc/doclet/testOptions/TestOptions.java ! test/langtools/jdk/javadoc/doclet/testOrdering/TestOrdering.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestBadOverride.java ! test/langtools/jdk/javadoc/doclet/testSerializedForm/TestSerializedForm.java ! test/langtools/jdk/javadoc/doclet/testSummaryHeading/TestSummaryHeading.java ! test/langtools/jdk/javadoc/doclet/testSummaryTag/TestSummaryTag.java ! test/langtools/jdk/javadoc/doclet/testSystemPropertyTaglet/TestSystemPropertyTaglet.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/A11yChecker.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java + test/langtools/jdk/javadoc/lib/javadoc/tester/ShowHeadings.java Changeset: cf4c3a118d2b Author: erikj Date: 2019-03-04 11:30 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/cf4c3a118d2b 8219988: Change to Visual Studio 2017 15.9.6 for building on Windows at Oracle Reviewed-by: tbell ! make/conf/jib-profiles.js - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh ! make/devkit/createWindowsDevkit2017.sh Changeset: 271f75d4b494 Author: erikj Date: 2019-03-04 11:28 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/271f75d4b494 8219986: Change to Xcode 10.1 for building on Macosx at Oracle Reviewed-by: tbell ! make/conf/jib-profiles.js + make/devkit/createMacosxDevkit.sh - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh Changeset: 77343f5c85cb Author: dholmes Date: 2019-03-04 19:38 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/77343f5c85cb 8219974: REDO JDK-8219492: Restore static callsite resolution for the current class Reviewed-by: redestad, vlivanov, coleenp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/cpCache.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp Changeset: ecc2bcc3beb0 Author: ihse Date: 2019-03-05 11:07 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ecc2bcc3beb0 8219971: Introduce SetupExecute in build system Reviewed-by: erikj ! make/CreateJmods.gmk ! make/Docs.gmk ! make/ExplodedImageOptimize.gmk ! make/Images.gmk ! make/Main.gmk ! make/UpdateX11Wrappers.gmk + make/common/Execute.gmk ! make/gensrc/GensrcCommonJdk.gmk ! make/gensrc/GensrcX11Wrappers.gmk ! make/hotspot/gensrc/GenerateSources.gmk ! make/hotspot/gensrc/GensrcAdlc.gmk ! make/hotspot/gensrc/GensrcDtrace.gmk ! make/hotspot/gensrc/GensrcJfr.gmk ! make/hotspot/gensrc/GensrcJvmti.gmk ! make/hotspot/ide/CreateVSProject.gmk Changeset: 35a30b432396 Author: aoqi Date: 2019-03-05 11:09 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/35a30b432396 8219906: Update test documentation with default test jobs settings Reviewed-by: ihse ! doc/testing.html ! doc/testing.md Changeset: 4ae746de6b86 Author: ihse Date: 2019-03-05 13:41 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/4ae746de6b86 8220155: JDK-8219971 broke hotspot build Reviewed-by: dholmes ! make/hotspot/gensrc/GensrcAdlc.gmk Changeset: d870bb08194a Author: mullan Date: 2019-03-05 08:24 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/d870bb08194a 8217878: ENVELOPING XML signature no longer works in JDK 11 8218629: XML Digital Signature throws NAMESPACE_ERR exception on OpenJDK 11, works 8/9/10 Summary: Backout and restore previous XML signature marshalling implementation Reviewed-by: weijun ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/Base64.java ! src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/utils/XMLUtils.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/AbstractDOMSignatureMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheCanonicalizer.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheOctetStreamData.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/ApacheTransform.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14N11Method.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCanonicalXMLC14NMethod.java + src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMCryptoBinary.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMDigestMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMEnvelopedTransform.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMExcC14NMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMHMACSignatureMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfo.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyInfoFactory.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyName.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMKeyValue.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMManifest.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMPGPData.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMReference.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMRetrievalMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureMethod.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperties.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignatureProperty.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSignedInfo.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMStructure.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMSubTreeData.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMTransform.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMUtils.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509Data.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMX509IssuerSerial.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLObject.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignature.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXMLSignatureFactory.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathFilter2Transform.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXPathTransform.java ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMXSLTTransform.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! test/jdk/javax/xml/crypto/dsig/GenerationTests.java + test/jdk/javax/xml/crypto/dsig/data/envelope2.xml Changeset: d7852bb72332 Author: mbaesken Date: 2019-03-05 09:55 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/d7852bb72332 8219920: dependency help output in configure-step : support zypper tool Reviewed-by: erikj, ihse ! make/autoconf/configure ! make/autoconf/help.m4 Changeset: 3158fae17e80 Author: zgu Date: 2019-03-05 12:30 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/3158fae17e80 8220161: Shenandoah does not need to initialize PLABs for safepoint workers Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: b4e59fc5edd1 Author: simonis Date: 2019-03-05 18:53 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/b4e59fc5edd1 8220164: Fix build instructions for AIX Reviewed-by: mdoerr, erikj, mbaesken ! doc/building.html ! doc/building.md Changeset: fb9541185457 Author: jjg Date: 2019-03-05 10:35 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/fb9541185457 8219946: Set class on body elements Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java ! test/langtools/jdk/javadoc/doclet/JavascriptWinTitle/JavascriptWinTitle.java ! test/langtools/jdk/javadoc/doclet/testFramesNoFrames/TestFramesNoFrames.java ! test/langtools/jdk/javadoc/doclet/testHtmlVersion/TestHtmlVersion.java ! test/langtools/jdk/javadoc/doclet/testJavascript/TestJavascript.java ! test/langtools/jdk/javadoc/doclet/testMetadata/TestMetadata.java Changeset: f3468c1bdf5f Author: cjplummer Date: 2019-03-05 13:40 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/f3468c1bdf5f 8220030: JdbStopThreadidTest.java failed due to "Unexpected IO error while writing command 'quit' to jdb stdin stream" Summary: Use contToExit(1) for safer approach to test exit. Reviewed-by: gadams, amenkov ! test/jdk/com/sun/jdi/JdbStopThreadidTest.java Changeset: 465beebb1071 Author: dtitov Date: 2019-03-05 13:41 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/465beebb1071 8218167: nsk/jvmti/scenarios/sampling/SP02/sp02t003 fails Reviewed-by: dlong, cjplummer ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP02/sp02t003/sp02t003.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t003/sp06t003.cpp Changeset: 6ffb8d7fe1e4 Author: vdeshpande Date: 2019-03-05 14:07 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/6ffb8d7fe1e4 8216580: Fix generation of VNNI vector code by allowing adjacent LoadS nodes to be isomorphic Reviewed-by: kvn, thartmann, rraghavan ! src/hotspot/share/opto/superword.cpp Changeset: a421bdf22394 Author: kbarrett Date: 2019-03-05 19:54 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/a421bdf22394 8219613: Use NonJavaThread PtrQueues Summary: Init and use NJT queues, remove shared SATB queue. Reviewed-by: shade, zgu, pliden, tschatzl Contributed-by: kim.barrett at oracle.com, shade at redhat.com ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.cpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.cpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahTraversalGC.cpp ! src/hotspot/share/gc/z/zBarrierSet.cpp ! src/hotspot/share/gc/z/zBarrierSet.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: b23068def105 Author: vdeshpande Date: 2019-03-05 21:26 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/b23068def105 8220211: Small update to Fix generation of VNNI vector code by allowing adjacent LoadS nodes to be isomorphic (JDK-8216580) Reviewed-by: kvn ! src/hotspot/share/opto/superword.cpp Changeset: 8b341d6728fe Author: jiefu Date: 2019-02-28 09:43 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/8b341d6728fe 8219519: Remove linux_sparc.ad and linux_aarch64.ad Reviewed-by: thartmann, pli, adinn - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad Changeset: 13acb4339895 Author: rehn Date: 2019-03-06 11:15 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/13acb4339895 8220151: SafepointTracing::end_of_last_safepoint_ms should return ms since epoch. Reviewed-by: dholmes, redestad ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/tieredThresholdPolicy.cpp Changeset: 17fb726e6d8e Author: lucy Date: 2019-03-06 12:14 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/17fb726e6d8e 8219214: Infinite Loop in CodeSection::dump() Reviewed-by: kvn, thartmann ! src/hotspot/share/asm/codeBuffer.cpp ! src/hotspot/share/asm/codeBuffer.hpp Changeset: 21ea4076a275 Author: stuefe Date: 2019-02-28 14:22 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/21ea4076a275 8219650: [Testbug] Fix potential crashes in new test hotspot gtest "test_print_hex_dump" Reviewed-by: clanger, shade ! src/hotspot/share/runtime/os.cpp ! test/hotspot/gtest/runtime/test_os.cpp Changeset: 6684c75ab531 Author: dtitov Date: 2019-03-06 09:30 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/6684c75ab531 8218464: vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001/TestDescription.java failed Reviewed-by: sspitsyn, gadams ! test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/allThreads/allthreads001.java Changeset: c5cf23055fcb Author: redestad Date: 2019-03-06 21:58 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/c5cf23055fcb 8219713: Reduce work in DefaultMethods::generate_default_methods Reviewed-by: hseigel, dholmes, lfoltan, acorn ! src/hotspot/share/classfile/defaultMethods.cpp Changeset: 083d7a34bbfd Author: jwilhelm Date: 2019-03-07 00:23 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/083d7a34bbfd Added tag jdk-13+11 for changeset 21ea4076a275 ! .hgtags Changeset: cd701366fcf8 Author: thartmann Date: 2019-03-07 08:38 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/cd701366fcf8 8163511: Allocation of compile task fails with assert: "Leaking compilation tasks?" Summary: Use weak handles for compile tasks to allow unloading of referenced methods. Reviewed-by: kvn, coleenp, eosterlund ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/runtime/compilationPolicy.cpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/tieredThresholdPolicy.cpp + test/hotspot/jtreg/compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java Changeset: a7cccbdf73f3 Author: goetz Date: 2019-03-06 16:01 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/a7cccbdf73f3 8219651: compiler/ciReplay/TestServerVM.java is failing on windows Reviewed-by: thartmann, kvn ! test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java Changeset: 274361bd6915 Author: shade Date: 2019-03-07 10:22 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/274361bd6915 8220228: Improve Shenandoah pacing histogram message Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahPacer.cpp Changeset: 0f9a54a13803 Author: rehn Date: 2019-03-07 10:32 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/0f9a54a13803 8220050: Deprecate -XX:-ThreadLocalHandshakes Reviewed-by: dcubed, mdoerr ! src/hotspot/share/runtime/arguments.cpp ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: 15595ecf9cf1 Author: shade Date: 2019-03-07 10:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/15595ecf9cf1 8215221: Serial GC misreports young GC time Reviewed-by: kbarrett, manc ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp Changeset: c112c2d5a856 Author: gadams Date: 2019-03-07 07:19 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/c112c2d5a856 8201252: unquarantine nsk/jdi/ThreadReference/resume/resume001 Reviewed-by: cjplummer ! test/hotspot/jtreg/ProblemList.txt Changeset: 6347ffe2c3c7 Author: redestad Date: 2019-03-05 16:39 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/6347ffe2c3c7 8220159: Optimize various RegMask operations by introducing watermarks Reviewed-by: neliasso, thartmann ! src/hotspot/share/opto/chaitin.hpp ! src/hotspot/share/opto/regmask.cpp ! src/hotspot/share/opto/regmask.hpp Changeset: ff399127078a Author: bsrbnd Date: 2019-03-07 15:27 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ff399127078a 8217561: X86: Add floating-point Math.min/max intrinsics Summary: Implementation taking care of +/-0.0 and NaN which uses a specific pattern for reductions Reviewed-by: aph, kvn, neliasso, sviswanathan, adinn Contributed-by: Jatin Bhateja ! src/hotspot/cpu/x86/assembler_x86.cpp ! src/hotspot/cpu/x86/assembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/loopTransform.cpp ! test/hotspot/jtreg/compiler/intrinsics/math/TestFpMinMaxIntrinsics.java + test/micro/org/openjdk/bench/vm/compiler/FpMinMaxIntrinsics.java Changeset: a764c49570c6 Author: henryjen Date: 2019-03-07 10:18 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/a764c49570c6 8217216: Launcher does not defend itself against LD_LIBRARY_PATH_64 (Solaris) Reviewed-by: rriggs ! src/java.base/unix/native/libjli/java_md_solinux.c ! test/jdk/tools/launcher/Test7029048.java Changeset: e445608fce9b Author: mullan Date: 2019-03-07 14:29 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/e445608fce9b 8218618: Program fails when using JDK addressed by UNC path and using Security Manager Reviewed-by: weijun ! src/java.base/share/classes/sun/security/provider/PolicyFile.java Changeset: f0af7fd0c9ca Author: mseledtsov Date: 2019-03-07 12:15 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/f0af7fd0c9ca 8213448: [TESTBUG] enhance jfr/jvm/TestDumpOnCrash Summary: added 2 more crash scenarios, removed dumponexit, and more Reviewed-by: egahlin ! test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java Changeset: 3e7fd3fe8411 Author: naoto Date: 2019-03-07 12:56 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/3e7fd3fe8411 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time Reviewed-by: lancea, rgoel ! src/java.base/share/classes/sun/util/cldr/CLDRTimeZoneNameProviderImpl.java ! src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java + test/jdk/java/text/Format/DateFormat/SDFTCKZoneNamesTest.java Changeset: a37939761ff6 Author: neliasso Date: 2019-03-07 22:16 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/a37939761ff6 8219448: split-if update_uses accesses stale idom data Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/split_if.cpp Changeset: dcaced4cbb83 Author: mseledtsov Date: 2019-03-07 13:20 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/dcaced4cbb83 8219997: [TESTBUG] Create test for JFR events in Docker container: CPU, Memory and Process Info Summary: Start docker with limits on CPU/Mem, verify JFR reports correct data Reviewed-by: egahlin + test/hotspot/jtreg/runtime/containers/docker/JfrReporter.java + test/hotspot/jtreg/runtime/containers/docker/TestJFREvents.java Changeset: 4ff6c8365b69 Author: ascarpino Date: 2019-03-07 19:35 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/4ff6c8365b69 8220165: Encryption using GCM results in RuntimeException- input length out of bound Reviewed-by: valeriep ! src/java.base/share/classes/com/sun/crypto/provider/GaloisCounterMode.java + test/jdk/com/sun/crypto/provider/Cipher/AEAD/GCMLargeDataKAT.java Changeset: 889dae20c4c4 Author: sgehwolf Date: 2019-03-07 16:15 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/889dae20c4c4 8220283: ZGC fails to build on GCC 4.4.7: ATTRIBUTE_ALIGNED compatibility issue Reviewed-by: shade, kbarrett ! src/hotspot/share/utilities/globalDefinitions_gcc.hpp Changeset: feea57b38a1c Author: mdoerr Date: 2019-03-08 11:23 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/feea57b38a1c 8219584: Try to dump error file by thread which causes safepoint timeout Reviewed-by: stuefe, dholmes, kvn ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/windows/os_windows.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/utilities/vmError.cpp + test/hotspot/jtreg/runtime/Safepoint/TestAbortVMOnSafepointTimeout.java Changeset: ac09c2498c64 Author: shade Date: 2019-03-08 12:01 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ac09c2498c64 8220290: gc/arguments/TestSurvivorRatioFlag.java fails after JDK-8215221 with CMS Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/shared/genCollectedHeap.cpp Changeset: 07540197d0fd Author: rehn Date: 2019-03-08 12:51 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/07540197d0fd 8220173: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark Reviewed-by: dcubed, redestad ! src/hotspot/share/runtime/handshake.cpp Changeset: fa9b16328e6a Author: hseigel Date: 2019-03-08 08:19 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/fa9b16328e6a 8220085: runtime/CompressedOops/UseCompressedOops.java times out on Windows intermittently Summary: Increase the test's timeout to 480 and move it from tier1 to tier3. Reviewed-by: lfoltan, mseledtsov ! test/hotspot/jtreg/TEST.groups ! test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java Changeset: 65a9f034954f Author: sgehwolf Date: 2019-03-08 13:56 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/65a9f034954f 8220353: [TESTBUG] TestRegisterRestoring uses SafepointALot without UnlockDiagnosticVMOptions Reviewed-by: thartmann, shade ! test/hotspot/jtreg/compiler/runtime/safepoints/TestRegisterRestoring.java Changeset: c70747878f6f Author: neliasso Date: 2019-03-08 15:27 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/c70747878f6f 8219642: ciReplay loads wrong data when MethodData size changes Reviewed-by: kvn, thartmann ! src/hotspot/share/ci/ciReplay.cpp Changeset: e693e12250d3 Author: mseledtsov Date: 2019-03-08 11:08 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/e693e12250d3 8220313: [TESTBUG] Update base image for Docker testing to OL 7.6 Summary: Updated the OL version in Dockerfile in FROM field Reviewed-by: dcubed ! test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest ! test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest Changeset: 2915818a0237 Author: mseledtsov Date: 2019-03-08 11:09 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/2915818a0237 Merge Changeset: fd6c13481231 Author: cushon Date: 2019-03-08 09:41 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/fd6c13481231 8220377: Unused field SourceFileObject.flatname Reviewed-by: jjg Contributed-by: Ron Shapiro ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java Changeset: 56adab1e0edd Author: bobv Date: 2019-03-08 16:20 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/56adab1e0edd 8220323: Fix copyright header text Reviewed-by: lancea ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java Changeset: bba6644b6fe3 Author: bobv Date: 2019-03-08 16:21 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/bba6644b6fe3 8220334: Fix copyright header text Reviewed-by: lancea ! src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java Changeset: 6dd6f988b4e4 Author: redestad Date: 2019-03-08 23:02 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/6dd6f988b4e4 8219860: Cleanup ClassFileParser::parse_linenumber_table Reviewed-by: rehn, lfoltan, hseigel ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp ! src/hotspot/share/classfile/classFileStream.cpp ! src/hotspot/share/classfile/classFileStream.hpp ! src/hotspot/share/code/compressedStream.cpp ! src/hotspot/share/code/compressedStream.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/oops/method.inline.hpp ! src/hotspot/share/runtime/relocator.cpp Changeset: 0324b3756aa2 Author: ecaspole Date: 2019-03-08 17:45 -0500 URL: http://hg.openjdk.java.net/amber/amber/rev/0324b3756aa2 8220368: Update String.indexOf to test all the C2 intrinsics Summary: Add new micros for Latin1 and UTF-16 Reviewed-by: kvn, redestad ! test/micro/org/openjdk/bench/java/lang/StringIndexOf.java Changeset: d9853137aa28 Author: dholmes Date: 2019-03-10 18:53 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/d9853137aa28 8219685: Startup failure: assert(!Universe::is_module_initialized()) failed: Incorrect java.lang.Module pre module system initialization Reviewed-by: lfoltan, redestad ! src/hotspot/share/classfile/javaClasses.cpp Changeset: c97c87e96897 Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/c97c87e96897 8220350: Refactor ShenandoahHeap::initialize Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.inline.hpp Changeset: f02c6b980c04 Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f02c6b980c04 8220153: Shenandoah does not work with TransparentHugePages properly Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp Changeset: 0a9cb99a98a0 Author: shade Date: 2019-03-11 00:06 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/0a9cb99a98a0 8220162: Shenandoah should not commit HugeTLBFS memory Reviewed-by: rkennke, zgu ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp Changeset: 744dc9c33676 Author: kbarrett Date: 2019-03-11 02:05 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/744dc9c33676 8217417: Decorator name typo: C2_TIGHLY_COUPLED_ALLOC Summary: Fixed typo in decorator name, variables, and comments. Reviewed-by: tschatzl ! src/hotspot/share/gc/shared/c2/barrierSetC2.hpp ! src/hotspot/share/gc/shared/c2/modRefBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/opto/arraycopynode.cpp ! src/hotspot/share/opto/arraycopynode.hpp ! src/hotspot/share/opto/library_call.cpp Changeset: e4cc94318c37 Author: pmuthuswamy Date: 2019-03-11 14:17 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/e4cc94318c37 8219632: Remove reference to com.sun.javadoc API in RemoveOldDoclet test Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/Start.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm ! test/langtools/jdk/javadoc/tool/removeOldDoclet/RemoveOldDoclet.java Changeset: 95978e7e8da0 Author: nishjain Date: 2019-03-11 14:22 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/95978e7e8da0 8217254: CompactNumberFormat:: CompactNumberFormat?() constructor does not comply with spec. 8217721: CompactNumberFormat:: format?() method spec for IAEx is not complaint Reviewed-by: naoto ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! test/jdk/java/text/Format/CompactNumberFormat/TestCompactNumber.java ! test/jdk/java/text/Format/CompactNumberFormat/TestCompactPatternsValidity.java Changeset: 9a1dd1203a4f Author: pmuthuswamy Date: 2019-03-11 14:57 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/9a1dd1203a4f 8220087: Remove remnants of HTML4 support Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/DocType.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTag.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Links.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java ! test/langtools/jdk/javadoc/doclet/testNavigation/TestNavigation.java Changeset: a2d3ca8062b9 Author: thartmann Date: 2019-03-11 11:42 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/a2d3ca8062b9 8218201: Failures when vmIntrinsics::_getClass is not inlined Summary: Fix BCEscapeAnalyzer to correctly handle _getClass intrinsic. Reviewed-by: kvn, dlong, redestad, neliasso ! src/hotspot/share/ci/bcEscapeAnalyzer.cpp ! src/hotspot/share/ci/bcEscapeAnalyzer.hpp + test/hotspot/jtreg/compiler/escapeAnalysis/TestGetClass.java Changeset: ab7c5483df44 Author: shade Date: 2019-03-11 12:39 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ab7c5483df44 8074817: Resolve disabled warnings for libverify Reviewed-by: erikj, alanb ! make/lib/CoreLibraries.gmk ! src/java.base/share/native/libverify/check_code.c ! src/java.base/share/native/libverify/check_format.c Changeset: 1def2d745747 Author: rgoel Date: 2019-03-11 17:34 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/1def2d745747 8220414: Correct copyright headers in Norm2AllModes.java and Normalizer2.java Summary: Updated copyright headers Reviewed-by: alanb ! src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java ! src/java.base/share/classes/sun/text/normalizer/Normalizer2.java Changeset: 289fd6cb7480 Author: clanger Date: 2019-03-11 15:34 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/289fd6cb7480 8220409: jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java - testOverlapWithBaseModule tests the wrong thing Reviewed-by: alanb ! test/jdk/jdk/modules/scenarios/overlappingpackages/OverlappingPackagesTest.java Changeset: 17a6681a5118 Author: redestad Date: 2019-03-11 17:33 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/17a6681a5118 8220420: Cleanup c1_LinearScan Reviewed-by: thartmann, neliasso ! src/hotspot/share/c1/c1_LinearScan.cpp ! src/hotspot/share/c1/c1_LinearScan.hpp Changeset: 687e10fefa11 Author: lancea Date: 2019-03-11 13:37 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/687e10fefa11 8220331: Remove extra spaces in copyright header Reviewed-by: naoto ! src/java.sql.rowset/share/classes/javax/sql/rowset/package-info.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/spi/package-info.java Changeset: be40860e8227 Author: zgu Date: 2019-03-11 14:06 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/be40860e8227 8220444: Shenandoah should use parallel version of WeakProcessor in root processor for weak roots Reviewed-by: rkennke, shade ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp Changeset: 1bc8513104f2 Author: darcy Date: 2019-03-11 11:23 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/1bc8513104f2 8220346: Refactor java.lang.Throwable to use Objects.requireNonNull Reviewed-by: lancea, mchung, tvaleev, forax, martin, plevart ! src/java.base/share/classes/java/lang/Throwable.java Changeset: 53a95878619f Author: jjg Date: 2019-03-11 12:59 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/53a95878619f 8220202: Simplify/standardize method naming for HtmlTree Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractExecutableMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractMemberWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractPackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AbstractTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllPackagesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeFieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeOptionalMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeRequiredMemberWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AnnotationTypeWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstantsSummaryWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Contents.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DeprecatedListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/EnumConstantWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FieldWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/FrameOutputWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlDocletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialMethodWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/LinkFactoryImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModulePackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ModuleWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/NestedClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexFrameWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageTreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SerializedFormWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SingleIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SplitIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SubWriterHolderWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TreeWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Comment.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/ContentBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/FixedStringContent.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Head.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Links.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/RawHtml.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Script.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/StringContent.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Table.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/TableHeader.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/Content.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeFieldBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/AnnotationTypeRequiredMemberBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ClassBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ConstructorBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/EnumConstantBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/FieldBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MemberSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MethodBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/ModuleSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PackageSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/PropertyBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ParamTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/ThrowsTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/UserTaglet.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/links/LinkFactory.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/links/LinkInfo.java ! test/langtools/jdk/javadoc/doclet/testHtmlDocument/TestHtmlDocument.java Changeset: c5d0b3acab98 Author: joehw Date: 2019-03-11 15:51 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/c5d0b3acab98 8219705: Wrong media-type for a given serialization method Reviewed-by: lancea ! src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java ! test/jaxp/TEST.ROOT + test/jaxp/javax/xml/jaxp/unittest/transform/OutputPropertiesTest.java Changeset: 62ab0859e7e5 Author: valeriep Date: 2019-03-11 23:48 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/62ab0859e7e5 8213008: Cipher with UNWRAP_MODE should support the generation of an AES key type Summary: Replaced CKK_GENERIC_SECRET with alorithm-specific key type in P11RSACipher unwrap impl Reviewed-by: ascarpino ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11SecretKeyFactory.java Changeset: b17caf731e27 Author: valeriep Date: 2019-03-11 23:51 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/b17caf731e27 Merge Changeset: d3888a37ad03 Author: bsrbnd Date: 2019-03-12 02:13 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/d3888a37ad03 8220407: compiler/intrinsics/math/TestFpMinMaxIntrinsics.java timedout Reviewed-by: kvn ! test/hotspot/jtreg/compiler/intrinsics/math/TestFpMinMaxIntrinsics.java Changeset: f984aca565c1 Author: dholmes Date: 2019-03-11 21:26 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/f984aca565c1 8219721: jcmd from earlier release will hang attaching to VM with JDK-8215622 applied Summary: fix compatibility issue caused by jmap update of 8215622 Reviewed-by: dholmes, ysuenaga, phh, sspitsyn Contributed-by: zanglin5 at jd.com ! src/hotspot/share/services/attachListener.cpp ! src/hotspot/share/services/attachListener.hpp ! src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/solaris/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.jcmd/share/classes/sun/tools/jmap/JMap.java ! test/jdk/java/util/logging/TestLoggerWeakRefLeak.java Changeset: 1dbe0c210134 Author: pli Date: 2019-03-07 02:39 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/1dbe0c210134 8214922: Add vectorization support for fmin/fmax Reviewed-by: adinn, roland ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/share/adlc/formssel.cpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/vectornode.cpp ! src/hotspot/share/opto/vectornode.hpp ! src/hotspot/share/runtime/vmStructs.cpp Changeset: 94d1e2c8fe01 Author: thartmann Date: 2019-03-12 10:09 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/94d1e2c8fe01 8220341: Class redefinition fails with assert(!is_unloaded()) failed: unloaded method on the stack Summary: Skip unloaded methods in compile queue during marking. Reviewed-by: kvn, neliasso, eosterlund, coleenp ! src/hotspot/share/compiler/compileTask.cpp Changeset: b067bd7edc26 Author: chegar Date: 2019-03-12 09:22 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/b067bd7edc26 8184315: Typo in java.net.JarURLConnection.getCertificates() method documentation Reviewed-by: dfuchs ! src/java.base/share/classes/java/net/JarURLConnection.java Changeset: c4fb912f3085 Author: mdoerr Date: 2019-03-12 11:53 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/c4fb912f3085 8220441: [PPC64] Clobber memory effect missing for memory barriers in atomics Reviewed-by: simonis, goetz ! src/hotspot/os_cpu/aix_ppc/atomic_aix_ppc.hpp ! src/hotspot/os_cpu/linux_ppc/atomic_linux_ppc.hpp Changeset: f9092c7d8677 Author: gadams Date: 2019-03-12 07:17 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/f9092c7d8677 8013728: nsk/jdi/BScenarios/hotswap/tc10x001 Unrecognized Windows Sockets error: 0: recv failed Reviewed-by: cjplummer, amenkov ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/hotswap/tc10x001.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/hotswap/tc10x001/newclass/tc10x001a.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/BScenarios/hotswap/tc10x001a.java Changeset: ab17708ec5c3 Author: sgehwolf Date: 2019-03-07 17:34 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ab17708ec5c3 8220294: ZGC fails to build on GCC 4.4.7: Type parameter issue Summary: Specify explicit type in the constructor Reviewed-by: shade, pliden ! src/hotspot/share/gc/z/zStat.cpp Changeset: 9911f18d6a40 Author: rschmelter Date: 2019-03-11 05:09 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/9911f18d6a40 8220363: hotspot-ide project fails Reviewed-by: clanger, erikj ! make/hotspot/ide/CreateVSProject.gmk Changeset: ee53a278b9d8 Author: zgu Date: 2019-03-12 09:59 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/ee53a278b9d8 8220344: Build failures when using --with-jvm-features=-g1gc,-jfr Reviewed-by: tschatzl, zgu Contributed-by: Ao Qi ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp Changeset: 9c6508806663 Author: redestad Date: 2019-03-12 15:29 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/9c6508806663 8220501: Improve c1_ValueStack locks handling Reviewed-by: thartmann, neliasso ! src/hotspot/share/c1/c1_ValueStack.cpp ! src/hotspot/share/c1/c1_ValueStack.hpp Changeset: daec95ed6795 Author: dfuchs Date: 2019-03-12 14:35 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/daec95ed6795 8220262: fix headings in java.logging Reviewed-by: lancea ! src/java.logging/share/classes/java/util/logging/LogManager.java Changeset: 4b4745d185eb Author: erikj Date: 2019-03-12 08:04 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/4b4745d185eb 8220383: Incremental build is broken and inefficient Reviewed-by: tbell ! make/CompileJavaModules.gmk ! make/Images.gmk ! make/common/NativeCompilation.gmk ! make/common/ProcessMarkdown.gmk ! make/common/TestFilesCompilation.gmk ! make/hotspot/lib/CompileJvm.gmk ! make/test/JtregGraalUnit.gmk ! make/test/JtregNativeHotspot.gmk ! make/test/JtregNativeJdk.gmk Changeset: b4f4778cf3d9 Author: redestad Date: 2019-03-12 16:18 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/b4f4778cf3d9 8220515: Revert removal of for_each_lock_value removal Reviewed-by: thartmann ! src/hotspot/share/c1/c1_ValueStack.hpp Changeset: 085309069d3c Author: kbarrett Date: 2019-03-12 11:13 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/085309069d3c 8217576: C1 atomic access handlers use incorrect decorators Summary: Fix decorator defaulting. Reviewed-by: tschatzl, eosterlund ! src/hotspot/share/c1/c1_LIRGenerator.cpp Changeset: 018217e30f5c Author: gadams Date: 2019-03-12 11:51 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/018217e30f5c 8220257: fix headings in java.instrument Reviewed-by: dfuchs ! src/java.instrument/share/classes/java/lang/instrument/package-info.java Changeset: 75268d993deb Author: gadams Date: 2019-03-12 11:53 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/75268d993deb 8220474: Incorrect GPL header in src/java.instrument/share/classes/java/lang/instrument/package-info.java Reviewed-by: dholmes ! src/java.instrument/share/classes/java/lang/instrument/package-info.java Changeset: da14083871bb Author: rriggs Date: 2019-03-12 12:48 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/da14083871bb 8220237: ProcessBuilder API documentation typo Reviewed-by: dfuchs ! src/java.base/share/classes/java/lang/ProcessBuilder.java Changeset: 6a15e411595e Author: lancea Date: 2019-03-12 14:56 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/6a15e411595e 8220005: java/util/Arrays/TimSortStackSize2.java times out Reviewed-by: bchristi ! test/jdk/ProblemList.txt Changeset: d9bcf74fc56a Author: erikj Date: 2019-03-12 12:12 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/d9bcf74fc56a 8220529: JDK-8220383 broke test image build Reviewed-by: tbell ! make/test/JtregNativeHotspot.gmk ! make/test/JtregNativeJdk.gmk Changeset: 84f10bbf993f Author: jwilhelm Date: 2019-03-12 19:17 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/84f10bbf993f 8218074: Update Graal Reviewed-by: kvn ! make/CompileJavaModules.gmk ! make/test/JtregGraalUnit.gmk ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Linker.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/Main.java ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/collect/ClassSearch.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64MacroAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.amd64/src/org/graalvm/compiler/asm/amd64/AMD64BaseAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.sparc/src/org/graalvm/compiler/asm/sparc/SPARCAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.test/src/org/graalvm/compiler/asm/test/AssemblerTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm/src/org/graalvm/compiler/asm/BranchTargetOutOfBoundsException.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.code/src/org/graalvm/compiler/code/CompilationResult.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.code/src/org/graalvm/compiler/code/HexCodeFileDisassemblerProvider.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64.test/src/org/graalvm/compiler/core/aarch64/test/AArch64CbzTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64.test/src/org/graalvm/compiler/core/aarch64/test/AArch64MembarOpTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64.test/src/org/graalvm/compiler/core/aarch64/test/AArch64TestBitAndBranchTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64NodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/GraalOptions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/SpeculativeExecutionAttacksMitigations.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/AbstractBlockBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/CFGVerifier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/cfg/Loop.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/doc-files/MitigateSpeculativeExecutionAttacksHelp.txt ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/AbstractObjectStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/AbstractPointerStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/IllegalStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/ObjectStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/PrimitiveStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/Stamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/StampPair.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/SymbolicJVMCIReference.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/type/VoidStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsignedLong.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CheckGraalInvariants.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ConditionalEliminationTestBase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CountedLoopTest2.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/DumpPathTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GraalCompilerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GraphEncoderTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/GuardPrioritiesTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/IntegerDivRemConstantTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/MemoryScheduleTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/NestedLoopTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/SwitchCanonicalizerTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyCallerSensitiveMethods.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyDebugUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/backend/BackendTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/deopt/RethrowDeoptMaterializeTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EscapeAnalysisTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/GraalCompiler.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/LIRCompilerBackend.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/LIRGenerationProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/NodeLIRBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/HighTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/phases/LowTier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/target/Backend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugOptions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/IgvDumpChannel.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/PathUtilities.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/doc-files/PrintGraphHelp.txt + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph.test/src/org/graalvm/compiler/graph/test/graphio/GraphOutputTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/NodeClass.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotJumpToExceptionHandlerInCallerOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64.test/src/org/graalvm/compiler/hotspot/amd64/test/BinaryMathStubTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64.test/src/org/graalvm/compiler/hotspot/amd64/test/UnaryMathStubTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotAddressLowering.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotJumpToExceptionHandlerInCallerOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLoweringProvider.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64MathStub.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64X87MathIntrinsicNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64X87MathSnippets.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.jdk9.test/src/org/graalvm/compiler/hotspot/jdk9/test/StringUTF16ToBytesGetCharsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.lir.test/src/org/graalvm/compiler/hotspot/lir/test/BenchmarkCounterOverflowTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.sparc/src/org/graalvm/compiler/hotspot/sparc/SPARCHotSpotMove.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CheckGraalIntrinsics.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorld.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/EliminateRedundantInitializationPhaseTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/GraalOSRTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/JVMCIInfopointErrorTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/OptionsInFileTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/ReservedStackAccessTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/WriteBarrierAdditionTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/WriteBarrierVerificationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotBackend.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotCompiledCodeBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotDataBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalCompilerFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalJVMCIServiceLocator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalOptionValues.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalRuntime.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotReplacementsImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotTTYStreamProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/JVMCIVersionCheck.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/SymbolicSnippetEncoder.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1ArrayRangePostWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1ArrayRangePreWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1BarrierSet.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1PostWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1PreWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/g1/G1ReferentFieldReadBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/ArrayRangeWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/BarrierSet.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/CardTableBarrierSet.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/ObjectWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/SerialArrayRangeWriteBarrier.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/gc/shared/SerialWriteBarrier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/DefaultHotSpotLoweringProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotClassInitializationPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraalConstantFieldProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotGraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotHostForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotNodePlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotUnsafeSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotWordOperationPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/AllocaNode.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/DimensionsNode.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/type/KlassPointerStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/OnStackReplacementPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/WriteBarrierAdditionPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/WriteBarrierVerificationPhase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/ArraysSupportSubstitutions.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/CounterModeSubstitutions.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/DigestBaseSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotClassSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/HotSpotReplacementsUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/NewObjectSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHA2Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHA5Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/SHASubstitutions.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/StringUTF16Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/replacements/WriteBarrierSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/OutOfBoundsExceptionStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/stubs/Stub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BytecodeParser.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/optimize/IfNodeCanonicalizationsTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.jtt/src/org/graalvm/compiler/jtt/optimize/SwitchHashTableTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Call.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ControlFlow.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Move.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayEqualsOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ControlFlow.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64HotSpotHelper.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathCosOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathExpOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathIntrinsicBinaryOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathIntrinsicUnaryOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathLog10Op.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathLogOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathPowOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathSinOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64MathTanOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Move.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.jtt/src/org/graalvm/compiler/lir/jtt/SPARCBranchBailoutTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/LIR.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/LIRValueUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/StandardOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/Variable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/alloc/lsra/LinearScanLifetimeAnalysisPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/alloc/lsra/ssa/SSALinearScanLifetimeAnalysisPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/asm/CompilationResultBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/asm/DataBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGeneratorTool.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/hashing/HashFunction.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/hashing/Hasher.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/ssa/SSAUtil.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/ConvertDeoptimizeToGuardPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop.phases/src/org/graalvm/compiler/loop/phases/LoopTransformations.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/BasicInductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/CountedLoopInfo.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DefaultLoopPolicies.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DerivedConvertedInductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DerivedOffsetInductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/DerivedScaledInductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/InductionVariable.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopEx.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragment.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragmentInside.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/LoopFragmentWhole.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.loop/src/org/graalvm/compiler/loop/MathUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.microbenchmarks/src/org/graalvm/compiler/microbenchmarks/lir/GraalCompilerState.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes.test/src/org/graalvm/compiler/nodes/test/IfNodeCanonicalizationTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/AbstractFixedGuardNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/ComputeObjectAddressNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/ConstantNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/EncodedGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/FrameState.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/GraphEncoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/IfNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/LogicNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/LoopBeginNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/LoopExitNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/PiNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/BinaryArithmeticNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IntegerDivRemNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IntegerEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IntegerLessThanNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IntegerMulHighNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/IsNullNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/RightShiftNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/SignedDivNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/SignedRemNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/UnsignedRightShiftNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/cfg/Block.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/cfg/ControlFlowGraph.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/JavaReadNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GeneratedInvocationPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderConfiguration.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/InvocationPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/MethodSubstitutionPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/NodePlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/java/NewArrayNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/address/IndexAddressNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/NodeLIRBuilderTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/Replacements.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/type/NarrowOopStamp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/util/GraphUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options.processor/src/org/graalvm/compiler/options/processor/OptionProcessor.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionDescriptor.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionKey.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionValues.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionsParser.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/FixReadsPhase.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/OptimizeDivPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/RemoveValueProxyPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/graph/ReentrantBlockIterator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/util/GraphOrder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.printer/src/org/graalvm/compiler/printer/GraphPrinterDumpHandler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringLatin1Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringSubstitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64StringUTF16Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.processor/src/org/graalvm/compiler/replacements/processor/GeneratedPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/DeoptimizeOnIntegerExactTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/IntegerExactFoldTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/ReplacementsParseTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringCompareToTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/StringIndexOfTestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.test/src/org/graalvm/compiler/replacements/test/classfile/ClassfileBytecodeProviderTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/CachingPEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/DefaultJavaLoweringProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/GraphKit.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/IntrinsicGraphBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ReplacementsImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetCounter.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetIntegerHistogram.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetTemplate.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StringUTF16Substitutions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopyCallNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/arraycopy/ArrayCopySnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayCompareToNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayRegionEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/BasicArrayCopyNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/BasicObjectCloneNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/BinaryMathIntrinsicNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/MacroNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/UnaryMathIntrinsicNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerAddExactNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerAddExactOverflowNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerExactArithmeticNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerExactArithmeticSplitNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerExactOverflowNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulExactNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulExactOverflowNode.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerSubExactNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerSubExactOverflowNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalServices.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/JavaVersionUtil.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/SpeculationReasonGroup.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/GraalTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.test/src/org/graalvm/compiler/test/SubprocessUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/EffectsClosure.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.graphio/src/org/graalvm/graphio/GraphOutput.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.graphio/src/org/graalvm/graphio/GraphProtocol.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.graphio/src/org/graalvm/graphio/ProtocolImpl.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.util/src/org/graalvm/util/DirectAnnotationAccess.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.util/src/org/graalvm/util/GuardedAnnotationAccess.java ! test/hotspot/jtreg/ProblemList-graal.txt + test/hotspot/jtreg/compiler/graalunit/EA9Test.java + test/hotspot/jtreg/compiler/graalunit/HotspotJdk9Test.java ! test/hotspot/jtreg/compiler/graalunit/TestPackages.txt Changeset: ab87b06dfdc0 Author: manc Date: 2019-01-15 15:59 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/ab87b06dfdc0 8212206: Refactor AdaptiveSizePolicy to separate out code related to GC overhead Summary: Move check_gc_overhead_limit() and related code to its own class Reviewed-by: tschatzl, pliden, jiangli ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/parallel/psGCAdaptivePolicyCounters.cpp ! src/hotspot/share/gc/parallel/psGCAdaptivePolicyCounters.hpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.hpp + src/hotspot/share/gc/shared/gcOverheadChecker.cpp + src/hotspot/share/gc/shared/gcOverheadChecker.hpp ! src/hotspot/share/gc/shared/gcPolicyCounters.cpp ! src/hotspot/share/gc/shared/gcPolicyCounters.hpp ! src/hotspot/share/gc/shared/gc_globals.hpp Changeset: ccb4a50bee06 Author: aeubanks Date: 2019-02-27 13:34 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/ccb4a50bee06 8220083: Use InetAddress.getLoopbackAddress() in place of 127.0.0.1 for some tests Summary: Tests that hardcode "127.0.0.1" fail in an environment where only IPv6 is available and IPv4 is not. Reviewed-by: chegar, dfuchs, michaelm Contributed-by: aeubanks at google.com ! test/jdk/com/sun/net/httpserver/TestLogging.java ! test/jdk/com/sun/net/httpserver/bugs/6725892/Test.java ! test/jdk/com/sun/net/httpserver/bugs/B6361557.java ! test/jdk/com/sun/net/httpserver/bugs/TruncatedRequestBody.java ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/SendFailed.java ! test/jdk/java/net/Authenticator/B6870935.java ! test/jdk/java/net/DatagramSocket/SendDatagramToBadAddress.java ! test/jdk/java/net/HttpURLConnection/SetAuthenticator/HTTPTestServer.java ! test/jdk/java/net/Socket/UrgentDataTest.java ! test/jdk/java/net/SocketOption/OptionsTest.java ! test/jdk/java/net/SocketOption/TcpKeepAliveTest.java ! test/jdk/java/net/httpclient/UnknownBodyLengthTest.java ! test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java ! test/jdk/java/nio/channels/AsynchronousChannelGroup/bootlib/Attack.java ! test/jdk/java/nio/channels/Selector/LotsOfCancels.java ! test/jdk/java/nio/channels/SocketChannel/AsyncCloseChannel.java ! test/jdk/java/nio/channels/SocketChannel/CloseRegisteredChannel.java ! test/jdk/java/nio/channels/SocketChannel/CloseTimeoutChannel.java ! test/jdk/java/nio/channels/SocketChannel/SocketInheritance.java ! test/jdk/java/nio/channels/etc/AdaptorCloseAndInterrupt.java ! test/jdk/java/nio/channels/etc/Shadow.java ! test/jdk/java/nio/charset/coders/StreamTimeout.java ! test/jdk/java/rmi/transport/readTimeout/ReadTimeoutTest.java ! test/jdk/jdk/net/Sockets/QuickAckTest.java ! test/jdk/jdk/net/Sockets/Test.java ! test/jdk/sun/net/www/protocol/http/TunnelThroughProxy.java Changeset: 0bbff075bf41 Author: dtitov Date: 2019-03-12 17:55 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/0bbff075bf41 8220244: vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t003 hasn't been un-problemlisted Reviewed-by: dlong ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: 1cef5fc16af8 Author: weijun Date: 2019-03-13 09:05 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/1cef5fc16af8 8220256: fix headings in java.security.sasl Reviewed-by: mullan ! src/java.security.sasl/share/classes/javax/security/sasl/package-info.java Changeset: fc84d7c22132 Author: valeriep Date: 2019-03-13 02:48 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/fc84d7c22132 8220258: fix headings in java.smartcardio Summary: Replace h3 with h2 Reviewed-by: ascarpino ! src/java.smartcardio/share/classes/javax/smartcardio/package-info.java Changeset: 3086f9259e97 Author: aoqi Date: 2019-03-13 00:48 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/3086f9259e97 8170639: [Linux] jsig is limited to a maximum of 64 signals Reviewed-by: dholmes, iklam ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/aix/os_aix.hpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/bsd/os_bsd.hpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_linux.hpp ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/os_posix.hpp Changeset: efb8569c95d5 Author: clanger Date: 2019-03-13 11:08 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/efb8569c95d5 8220504: Move definition of JAVA_VERSION_INFO_RESOURCE to Launcher-java.base.gmk Reviewed-by: erikj ! make/launcher/Launcher-java.base.gmk ! make/launcher/LauncherCommon.gmk Changeset: 48a02303574e Author: pliden Date: 2019-03-13 11:31 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/48a02303574e 8219816: Add IsArray/RemoveExtent type traits utilities Reviewed-by: kbarrett, eosterlund + src/hotspot/share/metaprogramming/isArray.hpp + src/hotspot/share/metaprogramming/removeExtent.hpp + test/hotspot/gtest/metaprogramming/test_isArray.cpp + test/hotspot/gtest/metaprogramming/test_removeExtent.cpp Changeset: 9d02451b536e Author: pliden Date: 2019-03-13 11:31 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/9d02451b536e 8219817: Remove unused CollectedHeap::block_size() Reviewed-by: shade, stefank ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp Changeset: ed3c6f07faab Author: pliden Date: 2019-03-13 11:31 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ed3c6f07faab 8219633: ZGC: Rename ZPageSizeMin to ZGranuleSize Reviewed-by: eosterlund, stefank ! src/hotspot/os_cpu/linux_x86/gc/z/zGlobals_linux_x86.hpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zCollectorPolicy.cpp ! src/hotspot/share/gc/z/zDebug.gdb ! src/hotspot/share/gc/z/zGlobals.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeapIterator.cpp ! src/hotspot/share/gc/z/zHeapIterator.hpp ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageTable.cpp ! src/hotspot/share/gc/z/zPageTable.hpp ! src/hotspot/share/gc/z/zPhysicalMemory.cpp ! src/hotspot/share/gc/z/zPhysicalMemory.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGlobals.java ! test/hotspot/gtest/gc/z/test_zPhysicalMemory.cpp Changeset: 8b4a1177202d Author: pliden Date: 2019-03-13 11:31 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/8b4a1177202d 8219634: ZGC: Rename ZAddressRangeMap to ZGranuleMap Reviewed-by: eosterlund, stefank ! src/hotspot/share/gc/z/vmStructs_z.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp + src/hotspot/share/gc/z/zGranuleMap.hpp + src/hotspot/share/gc/z/zGranuleMap.inline.hpp ! src/hotspot/share/gc/z/zHeapIterator.cpp ! src/hotspot/share/gc/z/zHeapIterator.hpp ! src/hotspot/share/gc/z/zPageTable.cpp ! src/hotspot/share/gc/z/zPageTable.hpp ! src/hotspot/share/gc/z/zPageTable.inline.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZGranuleMapForPageTable.java < src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZPageTable.java Changeset: acf36e8d61c6 Author: chegar Date: 2019-03-13 12:02 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/acf36e8d61c6 8220480: Typo in java.net.http.HttpResponse.BodySubscriber documentation Reviewed-by: alanb ! src/java.net.http/share/classes/java/net/http/HttpResponse.java Changeset: 9fc262a75638 Author: tnakamura Date: 2019-03-13 13:05 +0900 URL: http://hg.openjdk.java.net/amber/amber/rev/9fc262a75638 8220227: Host Locale Provider getDisplayCountry returns error message under non-English Win10 Summary: Adjusting to detect translated Unknown messages Reviewed-by: naoto ! src/java.base/windows/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java ! src/java.base/windows/native/libjava/HostLocaleProviderAdapter_md.c ! test/jdk/java/util/Locale/LocaleProviders.java ! test/jdk/java/util/Locale/LocaleProvidersRun.java Changeset: 6f75811126c3 Author: chegar Date: 2019-03-13 12:25 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/6f75811126c3 8220475: Malformed copyright header in LinuxSocketOptions.java, MacOSXSocketOptions.java and MacOSXSocketOptions.c Reviewed-by: alanb, dfuchs ! src/jdk.net/linux/classes/jdk/net/LinuxSocketOptions.java ! src/jdk.net/macosx/classes/jdk/net/MacOSXSocketOptions.java ! src/jdk.net/macosx/native/libextnet/MacOSXSocketOptions.c Changeset: fd332722014c Author: xuelei Date: 2019-03-13 07:14 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/fd332722014c 8160247: Mark deprecated javax.security.cert APIs with forRemoval=true Reviewed-by: weijun ! src/java.base/share/classes/com/sun/security/cert/internal/x509/X509V1CertImpl.java ! src/java.base/share/classes/javax/net/ssl/HandshakeCompletedEvent.java ! src/java.base/share/classes/javax/net/ssl/SSLSession.java ! src/java.base/share/classes/javax/security/cert/Certificate.java ! src/java.base/share/classes/javax/security/cert/CertificateEncodingException.java ! src/java.base/share/classes/javax/security/cert/CertificateException.java ! src/java.base/share/classes/javax/security/cert/CertificateExpiredException.java ! src/java.base/share/classes/javax/security/cert/CertificateNotYetValidException.java ! src/java.base/share/classes/javax/security/cert/CertificateParsingException.java ! src/java.base/share/classes/javax/security/cert/X509Certificate.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/ImmutableExtendedSSLSession.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/ImmutableSSLSession.java Changeset: 1a6a5a0260a7 Author: bpb Date: 2019-03-13 07:16 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/1a6a5a0260a7 6504660: HPI panic callback is dead code Reviewed-by: dcubed, cjplummer, redestad ! src/jdk.jdwp.agent/unix/native/libjdwp/linker_md.c Changeset: 195309a6c7d5 Author: neliasso Date: 2019-03-13 15:22 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/195309a6c7d5 8219517: assert(false) failed: infinite loop in PhaseIterGVN::optimize Reviewed-by: kvn, thartmann ! src/hotspot/share/opto/memnode.cpp Changeset: fab8496eb541 Author: redestad Date: 2019-03-13 17:32 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/fab8496eb541 8220496: Race in java_lang_String::length() when deduplicating Reviewed-by: rkennke, pliden ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp ! src/hotspot/share/gc/shared/stringdedup/stringDedupTable.hpp Changeset: 8b61a38be0c5 Author: zgu Date: 2019-03-13 13:33 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/8b61a38be0c5 8220546: Shenandoah Reports timing details for weak root processing Reviewed-by: rkennke ! src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahRootProcessor.hpp Changeset: 954399cb6959 Author: aeubanks Date: 2019-03-13 09:12 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/954399cb6959 8220585: Incorrect code in MulticastSocket sample code Summary: Sample code shows that String.length() can be passed to a DatagramPacket along with String.getBytes(), but is incorrect for non-ASCII Strings. Reviewed-by: martin, chegar Contributed-by: aeubanks at google.com ! src/java.base/share/classes/java/net/MulticastSocket.java Changeset: d58599c7cdef Author: jiangli Date: 2019-03-13 10:37 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/d58599c7cdef Merge Changeset: 9a90236ab64c Author: lancea Date: 2019-03-13 14:10 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/9a90236ab64c 8220253: Fix Headings in java.sql.rowset Reviewed-by: darcy ! src/java.sql.rowset/share/classes/com/sun/rowset/package-info.java ! src/java.sql.rowset/share/classes/com/sun/rowset/providers/RIOptimisticProvider.java ! src/java.sql.rowset/share/classes/com/sun/rowset/providers/RIXMLProvider.java ! src/java.sql.rowset/share/classes/com/sun/rowset/providers/package-info.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/BaseRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/CachedRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/FilteredRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/JdbcRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/JoinRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/Joinable.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/Predicate.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/WebRowSet.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialArray.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialDatalink.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialJavaObject.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialRef.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialStruct.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/package-info.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/spi/SyncFactory.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/spi/SyncProvider.java Changeset: 1d7aec80147a Author: bpb Date: 2019-03-13 11:12 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/1d7aec80147a 8219597: (bf) Heap buffer state changes could provoke unexpected exceptions Reviewed-by: alanb, rriggs ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template Changeset: 43a379369b0e Author: dfuchs Date: 2019-03-13 18:43 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/43a379369b0e 8219197: ThreadGroup.enumerate() may return wrong value Summary: ThreadGroup.enumerate(list,n,recurse) should never return a value that is less than n. Reviewed-by: clanger, chegar, prappo ! src/java.base/share/classes/java/lang/ThreadGroup.java + test/jdk/java/lang/ThreadGroup/Destroy.java Changeset: debb15cc04ee Author: epavlova Date: 2019-03-13 12:30 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/debb15cc04ee 8219882: [AOT] Develop regression test for 8218859 Reviewed-by: kvn + test/hotspot/jtreg/compiler/aot/cli/jaotc/CompileAbsoluteDirectoryTest.java ! test/hotspot/jtreg/compiler/aot/cli/jaotc/CompileDirectoryTest.java Changeset: f4f0dce5d0bb Author: tschatzl Date: 2019-03-13 21:01 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f4f0dce5d0bb 8220301: Remove jbyte use in CardTable Summary: Use CardTable::CardValue aliased to uint8_t instead. Reviewed-by: kbarrett, shade ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/arm/gc/g1/g1BarrierSetAssembler_arm.cpp ! src/hotspot/cpu/arm/gc/shared/cardTableBarrierSetAssembler_arm.cpp ! src/hotspot/cpu/ppc/gc/g1/g1BarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/cardTableBarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/cardTableBarrierSetAssembler_ppc.hpp ! src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp ! src/hotspot/cpu/s390/gc/shared/cardTableBarrierSetAssembler_s390.cpp ! src/hotspot/cpu/sparc/gc/g1/g1BarrierSetAssembler_sparc.cpp ! src/hotspot/cpu/sparc/gc/shared/cardTableBarrierSetAssembler_sparc.cpp ! src/hotspot/cpu/sparc/gc/shared/cardTableBarrierSetAssembler_sparc.hpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/shared/cardTableBarrierSetAssembler_x86.cpp ! src/hotspot/share/ci/ciUtilities.cpp ! src/hotspot/share/ci/ciUtilities.hpp ! src/hotspot/share/gc/cms/cmsCardTable.cpp ! src/hotspot/share/gc/cms/cmsCardTable.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp ! src/hotspot/share/gc/g1/g1CardCounts.cpp ! src/hotspot/share/gc/g1/g1CardCounts.hpp ! src/hotspot/share/gc/g1/g1CardTable.cpp ! src/hotspot/share/gc/g1/g1CardTable.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1HotCardCache.cpp ! src/hotspot/share/gc/g1/g1HotCardCache.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSet.hpp ! src/hotspot/share/gc/parallel/psCardTable.cpp ! src/hotspot/share/gc/parallel/psCardTable.hpp ! src/hotspot/share/gc/shared/c1/cardTableBarrierSetC1.cpp ! src/hotspot/share/gc/shared/c2/cardTableBarrierSetC2.cpp ! src/hotspot/share/gc/shared/cardTable.cpp ! src/hotspot/share/gc/shared/cardTable.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.cpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp ! src/hotspot/share/gc/shared/cardTableRS.cpp ! src/hotspot/share/gc/shared/cardTableRS.hpp ! src/hotspot/share/gc/shared/vmStructs_gc.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp Changeset: e8de5d46ecd4 Author: tschatzl Date: 2019-03-13 21:01 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/e8de5d46ecd4 8220345: Use appropriate type for G1RemSetScanState::IsDirtyRegionState Reviewed-by: kbarrett, lkorinth ! src/hotspot/share/gc/g1/g1RemSet.cpp Changeset: db545bf94fbc Author: cjplummer Date: 2019-03-13 19:42 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/db545bf94fbc 8220352: Crash with assert(external_guard || result != __null) failed: Invalid JNI handle Summary: Don't delete globalrefs that might still be referenced Reviewed-by: gadams, jcbeyler, sspitsyn ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/MonitorWait/monitorwait001/monitorwait001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/MonitorWaited/monitorwaited001/monitorwaited001.cpp Changeset: f7a745888a1e Author: jwilhelm Date: 2019-03-14 04:10 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f7a745888a1e Added tag jdk-13+12 for changeset 1d7aec80147a ! .hgtags Changeset: d295a7d2b933 Author: cushon Date: 2019-03-13 17:26 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/d295a7d2b933 8220634: SymLinkArchiveTest should handle not being able to create symlinks Reviewed-by: jjg ! test/langtools/tools/javac/file/SymLinkArchiveTest.java Changeset: 17bf38efed0e Author: cushon Date: 2019-03-05 12:01 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/17bf38efed0e 8193277: SimpleFileObject inconsistency between getName and getShortName Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/PathFileObject.java + test/langtools/tools/javac/file/SymLinkShortNameTest.java Changeset: d21803f47416 Author: chegar Date: 2019-03-14 09:10 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/d21803f47416 8220598: Malformed copyright year range in a few files in java.base Reviewed-by: dfuchs, lancea, rriggs, weijun ! src/java.base/share/classes/jdk/internal/util/ArraysSupport.java ! src/java.base/share/classes/sun/net/spi/DefaultProxySelector.java ! src/java.base/share/classes/sun/security/util/IOUtils.java Changeset: a6221f993616 Author: pzhang Date: 2019-03-12 11:49 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/a6221f993616 8220566: AArch64: Set default vm features for Ampere eMAG CPUs Summary: Set defaults for vendor specific features Reviewed-by: adinn ! src/hotspot/cpu/aarch64/vm_version_aarch64.cpp Changeset: d611b76d1327 Author: mdoerr Date: 2019-03-14 12:30 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/d611b76d1327 8220660: [s390]: debug build broken after JDK-8220301 Reviewed-by: shade ! src/hotspot/cpu/s390/gc/g1/g1BarrierSetAssembler_s390.cpp Changeset: 6bf8877eb1b9 Author: roland Date: 2019-03-12 15:42 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/6bf8877eb1b9 8220374: C2: LoopStripMining doesn't strip as expected Reviewed-by: rkennke, thartmann, mdoerr ! src/hotspot/share/opto/loopnode.cpp + test/hotspot/jtreg/compiler/loopstripmining/CheckLoopStripMining.java Changeset: 677cede5608e Author: stefank Date: 2019-03-14 09:08 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/677cede5608e 8220411: Remove ScavengeRootsInCode=0 code Reviewed-by: thartmann, coleenp ! src/hotspot/cpu/x86/x86_32.ad ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/ci/ciBaseObject.cpp ! src/hotspot/share/ci/ciBaseObject.hpp ! src/hotspot/share/ci/ciObject.cpp ! src/hotspot/share/ci/ciObject.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/opto/type.cpp Changeset: fce463e39f72 Author: stefank Date: 2019-03-14 09:14 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/fce463e39f72 8220342: Remove scavenge_root_nmethods_do from VM_HeapWalkOperation::collect_simple_roots Reviewed-by: sspitsyn, ehelin ! src/hotspot/share/prims/jvmtiTagMap.cpp Changeset: 4b1426ed1c44 Author: stefank Date: 2019-03-14 09:15 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/4b1426ed1c44 8220343: Move scavenge_root_nmethods from shared code Reviewed-by: kvn, eosterlund ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/pcTasks.cpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psTasks.cpp ! src/hotspot/share/gc/serial/genMarkSweep.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/parallelCleaning.cpp + src/hotspot/share/gc/shared/scavengableNMethods.cpp + src/hotspot/share/gc/shared/scavengableNMethods.hpp + src/hotspot/share/gc/shared/scavengableNMethodsData.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkCompact.cpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeCache.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/NMethod.java ! test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java Changeset: 153419748bf8 Author: sgehwolf Date: 2019-02-25 15:41 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/153419748bf8 8219585: [TESTBUG] sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java passes trivially when it shouldn't Reviewed-by: dfuchs, sballal ! test/jdk/sun/management/jmxremote/bootstrap/JMXAgentInterfaceBinding.java ! test/jdk/sun/management/jmxremote/bootstrap/JMXInterfaceBindingTest.java Changeset: 5d48ae032588 Author: hseigel Date: 2019-03-14 09:38 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/5d48ae032588 8219579: Remove redundant signature parsing from the verifier Summary: Change verifier signature checking into asserts because ClassFileParser checks signatures for files being verified. Reviewed-by: lfoltan, coleenp, redestad, dholmes ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp + test/hotspot/jtreg/runtime/verifier/BadSignatures.jcod + test/hotspot/jtreg/runtime/verifier/TestSigParse.java Changeset: 70a818b1d9db Author: redestad Date: 2019-03-14 15:31 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/70a818b1d9db 8220502: Inefficient pre-sizing of PhiResolverState arrays in c1_LIRGenerator Reviewed-by: thartmann, kvn ! src/hotspot/share/c1/c1_LIRGenerator.cpp ! src/hotspot/share/c1/c1_LIRGenerator.hpp Changeset: 478f1483c511 Author: lancea Date: 2019-03-14 10:50 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/478f1483c511 8220252: Fix Headings in java.naming Reviewed-by: dfuchs ! src/java.naming/share/classes/com/sun/jndi/ldap/EventSupport.java ! src/java.naming/share/classes/javax/naming/CompositeName.java ! src/java.naming/share/classes/javax/naming/CompoundName.java ! src/java.naming/share/classes/javax/naming/Context.java ! src/java.naming/share/classes/javax/naming/directory/DirContext.java ! src/java.naming/share/classes/javax/naming/event/EventContext.java ! src/java.naming/share/classes/javax/naming/ldap/LdapContext.java Changeset: e6a1c4e28294 Author: gadams Date: 2019-03-14 10:58 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/e6a1c4e28294 8218166: com/sun/jdi/SimulResumerTest.java failure Reviewed-by: dlong, jcbeyler ! test/jdk/com/sun/jdi/SimulResumerTest.java Changeset: c0fccca69aff Author: jcbeyler Date: 2019-03-14 09:35 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/c0fccca69aff 8220628: Move the HeapMonitor library to C++ Summary: Migrate libHeapMonitorTest.c to libHeapMonitorTest.cpp Reviewed-by: cjplummer, sspitsyn - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c + test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.cpp Changeset: deb99f13c6cd Author: bpb Date: 2019-03-14 09:43 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/deb99f13c6cd 8220614: (bf) Buffer absolute slice methods should use Objects.checkFromIndexSize() Reviewed-by: alanb, igerasim, rriggs ! src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template ! src/java.base/share/classes/java/nio/StringCharBuffer.java Changeset: 641768acb12e Author: cushon Date: 2019-03-08 09:58 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/641768acb12e 8220378: Unused Names constants Reviewed-by: jjg, mcimadamore Contributed-by: Ron Shapiro ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java Changeset: 41b79b3e21fb Author: itakiguchi Date: 2019-03-15 00:49 +0900 URL: http://hg.openjdk.java.net/amber/amber/rev/41b79b3e21fb 8220281: IBM-858 alias name is missing on IBM00858 charset Summary: Add aliases into IBM charsets Reviewed-by: naoto ! make/data/charsetmapping/charsets ! test/jdk/sun/nio/cs/TestIBMBugs.java Changeset: 2ab55d39fb5b Author: cushon Date: 2019-03-13 22:05 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/2ab55d39fb5b 8220644: Align required/found pairs in diagnostics Reviewed-by: mcimadamore, jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties Changeset: 829bf950287e Author: redestad Date: 2019-03-14 18:56 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/829bf950287e 8220366: Optimize Symbol handling in ClassVerifier and SignatureStream Reviewed-by: hseigel, coleenp, lfoltan ! src/hotspot/share/classfile/stackMapFrame.cpp ! src/hotspot/share/classfile/symbolTable.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp ! src/hotspot/share/oops/symbol.cpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp Changeset: 777110c61b1f Author: mseledtsov Date: 2019-03-14 11:26 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/777110c61b1f 8220676: [TESTBUG] ProblemList TestCPUSets until the test issue is resolved Summary: Added the test to problem list Reviewed-by: lfoltan ! test/hotspot/jtreg/ProblemList.txt Changeset: 67f72165dca5 Author: jjg Date: 2019-03-14 11:39 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/67f72165dca5 8220379: Fix doclint handling of headings Reviewed-by: erikj, jlahoda ! make/CompileJavaModules.gmk ! src/jdk.compiler/share/classes/com/sun/tools/doclint/Checker.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/DocLint.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/Env.java ! src/jdk.compiler/share/classes/com/sun/tools/doclint/resources/doclint.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/Arguments.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/WorkArounds.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java + test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadingsTest.java ! test/langtools/tools/doclint/AccessibilityTest.java ! test/langtools/tools/doclint/AccessibilityTest.out ! test/langtools/tools/doclint/html/BlockTagsTest.java ! test/langtools/tools/doclint/html/HtmlVersionTagsAttrsTest.java ! test/langtools/tools/doclint/tidy/AnchorAlreadyDefined.java ! test/langtools/tools/doclint/tidy/AnchorAlreadyDefined.out ! test/langtools/tools/doclint/tidy/MissingTag.java ! test/langtools/tools/doclint/tidy/MissingTag.out - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java + test/langtools/tools/javac/doclint/ImplicitHeadingsTest.java Changeset: 3cc19f34075b Author: jjg Date: 2019-03-14 11:39 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/3cc19f34075b Merge Changeset: 943cfab99051 Author: jjg Date: 2019-03-14 13:33 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/943cfab99051 8219691: method summary table head should be enclosed in Reviewed-by: jjg Contributed-by: dthomson at google.com ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTag.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/Table.java ! test/langtools/jdk/javadoc/doclet/testDeprecatedDocs/TestDeprecatedDocs.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java ! test/langtools/jdk/javadoc/doclet/testModules/TestIndirectExportsOpens.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModuleServices.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNewLanguageFeatures/TestNewLanguageFeatures.java ! test/langtools/jdk/javadoc/doclet/testPackagePage/TestPackagePage.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testUnnamedPackage/TestUnnamedPackage.java From maurizio.cimadamore at oracle.com Thu Mar 14 21:07:17 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 14 Mar 2019 21:07:17 +0000 Subject: hg: amber/amber: Automatic merge with patterns-stage-1 Message-ID: <201903142107.x2EL7ILg024438@aojmv0008.oracle.com> Changeset: cedb78b3192e Author: mcimadamore Date: 2019-03-14 22:07 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/cedb78b3192e Automatic merge with patterns-stage-1 - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From maurizio.cimadamore at oracle.com Thu Mar 14 21:05:14 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 14 Mar 2019 21:05:14 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903142105.x2EL5FDo020808@aojmv0008.oracle.com> Changeset: 26cf984698d7 Author: mcimadamore Date: 2019-03-14 22:05 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/26cf984698d7 Automatic merge with default - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From maurizio.cimadamore at oracle.com Thu Mar 14 21:06:19 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 14 Mar 2019 21:06:19 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903142106.x2EL6JNI022467@aojmv0008.oracle.com> Changeset: 67ca1f58eccc Author: mcimadamore Date: 2019-03-14 22:06 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/67ca1f58eccc Automatic merge with default - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From maurizio.cimadamore at oracle.com Thu Mar 14 21:06:56 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 14 Mar 2019 21:06:56 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903142106.x2EL6u7U023581@aojmv0008.oracle.com> Changeset: ee4bb0097b16 Author: mcimadamore Date: 2019-03-14 22:06 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ee4bb0097b16 Automatic merge with default - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From vicente.romero at oracle.com Fri Mar 15 02:13:04 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Thu, 14 Mar 2019 22:13:04 -0400 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <355ed605-b2f6-198e-efdf-06d781d764dd@oracle.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> <355ed605-b2f6-198e-efdf-06d781d764dd@oracle.com> Message-ID: Please see the performance of both implementations for the multi-threaded version [1]. [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html On 3/12/19 8:18 PM, Vicente Romero wrote: > Hi, > > I have redone the experiments for Objects::hash. Now accessing fields > instead of local variables and using the @State annotation. Please see > the results at [1]. I have kept both implementations in the table for > comparison. Now the numbers aren't as great as before but they are > still better than the non-intrinsified version. > > Thanks, > Vicente > > [1] > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html > > On 3/12/19 8:57 AM, Vicente Romero wrote: >> >> >> On 3/12/19 8:36 AM, Brian Goetz wrote: >>> In the real world, I would think the vast majority of cases are in >>> the 2-10 arguments range.? So thats where we need to beat >>> Objects::hash, if we?re going to do it at all. >> >> if that is the case we already have a solution for that >> >>> >>>> On Mar 6, 2019, at 1:05 PM, Vicente Romero >>>> wrote: >>>> >>>> Hi Hannes, >>>> >>>> Thanks for the results, yes the change I made was more oriented to >>>> large number of arguments so it makes sense that it is not as good >>>> for a smaller number of arguments which I agree with you should be >>>> the most common case. I think we are gathering a good case for the >>>> next amber meeting to come to a decision on the project, on the >>>> Objects::hash area. I think that there are two options: >>>> >>>> 1. do nothing: Objects::hash is not intrisified at all >>>> 2. generate the fastest callsite for a small number of arguments and >>>> ?? generate the legit code when the number of arguments is above a >>>> ?? given threshold >>>> >>>> Comments? >>>> >>>> Vicente >>>> >>>> >>>> On 3/6/19 12:48 PM, Hannes Walln?fer wrote: >>>>> Vicente, >>>>> >>>>> I ran a number of the Objects::hash benchmarks ranging from 1 to >>>>> 100 arguments with current intrinsics-project tip (a0a3f9977a7c) >>>>> as well as the older version of ObjectsBootstraps.java (pre >>>>> 0f40d5752eb9, see patch attached). The results I get show that >>>>> with a single argument, performance is pretty much the same, but >>>>> with any of number of arguments between 2 and 50 the old version >>>>> is about 2x faster. It?s only with 100 arguments that the old >>>>> version becomes pathetically slow, while the new version still >>>>> performs decently. >>>>> >>>>> I guess the change in implementation was based on a too narrow set >>>>> of benchmarks, and in the light of these results we should go back >>>>> to the old implementation. Since invocations with > 50 arguments >>>>> should be fairly uncommon I guess a simple solution such as >>>>> invoking the original method via a vararg method handle would be >>>>> sufficient? >>>>> >>>>> Hannes >>>>> >>>>> >>>>> >>>>> ** intrinsics-project tip ** >>>>> >>>>> Benchmark Mode? Cnt????? Score????? Error?? Units >>>>> IntrinsicsBenchmark.testHash1IntLoop10 thrpt??? 5 41721,730 ? >>>>> 2477,413? ops/ms >>>>> IntrinsicsBenchmark.testHash1StringLoop10 thrpt??? 5 35289,443 ? >>>>> 1030,636? ops/ms >>>>> IntrinsicsBenchmark.testHash2Ints thrpt??? 5? 21830,140 ? 852,642? >>>>> ops/ms >>>>> IntrinsicsBenchmark.testHash2IntsLoop10 thrpt??? 5 19806,343 ? >>>>> 1027,029? ops/ms >>>>> IntrinsicsBenchmark.testHash2Strings thrpt??? 5? 18409,232 ?? >>>>> 676,311? ops/ms >>>>> IntrinsicsBenchmark.testHash2StringsLoop10 thrpt??? 5 16842,651 ?? >>>>> 664,615? ops/ms >>>>> IntrinsicsBenchmark.testHash5Int5Strings thrpt??? 5 9183,019 ?? >>>>> 409,206? ops/ms >>>>> IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt 5?? 8349,475 >>>>> ?? 886,015? ops/ms >>>>> IntrinsicsBenchmark.testHash5Integers5Strings thrpt??? 5 9155,629 >>>>> ?? 335,129? ops/ms >>>>> IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt??? 5?? >>>>> 8171,108 ?? 385,375? ops/ms >>>>> IntrinsicsBenchmark.testHash5doubles5Strings thrpt??? 5 9246,458 >>>>> ?? 502,251? ops/ms >>>>> IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt??? 5?? >>>>> 8419,192 ?? 372,626? ops/ms >>>>> IntrinsicsBenchmark.testHash100Ints thrpt??? 5??? 796,460 ??? >>>>> 27,123? ops/ms >>>>> IntrinsicsBenchmark.testHash100IntsLoop10 thrpt??? 5 792,775 ??? >>>>> 23,402? ops/ms >>>>> IntrinsicsBenchmark.testHash100Strings thrpt??? 5 69,753 ??? >>>>> 45,947? ops/ms >>>>> IntrinsicsBenchmark.testHash100StringsLoop10 thrpt??? 5 619,774 >>>>> ??? 14,503? ops/ms >>>>> IntrinsicsBenchmark.testHash20Int20Strings thrpt??? 5 1669,774 ??? >>>>> 53,991? ops/ms >>>>> IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5?? >>>>> 1644,342 ??? 62,946? ops/ms >>>>> IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5?? 1651,428 >>>>> ?? 170,146? ops/ms >>>>> IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt??? 5?? >>>>> 1635,878 ??? 62,007? ops/ms >>>>> IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5?? 1673,927 >>>>> ??? 51,559? ops/ms >>>>> IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt??? 5?? >>>>> 1641,524 ??? 52,172? ops/ms >>>>> IntrinsicsBenchmark.testHash25Int25Strings thrpt??? 5 1286,407 ??? >>>>> 27,920? ops/ms >>>>> IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5?? >>>>> 1286,250 ??? 26,125? ops/ms >>>>> IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5?? 1290,251 >>>>> ??? 25,217? ops/ms >>>>> IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt??? 5?? >>>>> 1285,060 ??? 33,297? ops/ms >>>>> IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5?? 1288,374 >>>>> ??? 40,727? ops/ms >>>>> IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt??? 5?? >>>>> 1277,822 ??? 20,674? ops/ms >>>>> IntrinsicsBenchmark.testHash50Int50Strings thrpt??? 5 185,692 ?? >>>>> 753,244? ops/ms >>>>> IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5??? >>>>> 622,333 ??? 12,212? ops/ms >>>>> IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5??? 266,784 >>>>> ???? 8,620? ops/ms >>>>> IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt??? >>>>> 5??? 623,180 ??? 15,583? ops/ms >>>>> IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5??? 391,497 >>>>> ??? 33,738? ops/ms >>>>> IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt??? 5??? >>>>> 621,560 ??? 12,652? ops/ms >>>>> >>>>> ** old version of hash bootstraps ** >>>>> >>>>> Benchmark Mode? Cnt????? Score????? Error?? Units >>>>> IntrinsicsBenchmark.testHash1IntLoop10 thrpt??? 5 42161,466 ?? >>>>> 975,935? ops/ms >>>>> IntrinsicsBenchmark.testHash1StringLoop10 thrpt??? 5 35445,612 ? >>>>> 1320,095? ops/ms >>>>> IntrinsicsBenchmark.testHash2Ints thrpt??? 5? 52157,722 ? >>>>> 1089,439? ops/ms >>>>> IntrinsicsBenchmark.testHash2IntsLoop10 thrpt??? 5 42223,291 ? >>>>> 1107,430? ops/ms >>>>> IntrinsicsBenchmark.testHash2Strings thrpt??? 5? 46702,129 ? >>>>> 1360,150? ops/ms >>>>> IntrinsicsBenchmark.testHash2StringsLoop10 thrpt??? 5 35577,294 ?? >>>>> 939,756? ops/ms >>>>> IntrinsicsBenchmark.testHash5Int5Strings thrpt??? 5 20351,503 ?? >>>>> 495,039? ops/ms >>>>> IntrinsicsBenchmark.testHash5Int5StringsLoop10 thrpt??? 5 >>>>> 20087,351 ?? 518,764? ops/ms >>>>> IntrinsicsBenchmark.testHash5Integers5Strings thrpt??? 5 20884,773 >>>>> ?? 648,380? ops/ms >>>>> IntrinsicsBenchmark.testHash5Integers5StringsLoop10 thrpt??? 5? >>>>> 19990,317 ?? 492,250? ops/ms >>>>> IntrinsicsBenchmark.testHash5doubles5Strings thrpt??? 5 20913,291 >>>>> ?? 615,744? ops/ms >>>>> IntrinsicsBenchmark.testHash5doubles5StringsLoop10 thrpt??? 5? >>>>> 20053,959 ?? 538,675? ops/ms >>>>> IntrinsicsBenchmark.testHash100Ints thrpt??? 5????? 6,625 ???? >>>>> 0,157? ops/ms >>>>> IntrinsicsBenchmark.testHash100IntsLoop10 thrpt??? 5 6,747 ???? >>>>> 0,201? ops/ms >>>>> IntrinsicsBenchmark.testHash100Strings thrpt??? 5 6,305 ???? >>>>> 1,031? ops/ms >>>>> IntrinsicsBenchmark.testHash100StringsLoop10 thrpt 5????? 6,826 >>>>> ???? 0,154? ops/ms >>>>> IntrinsicsBenchmark.testHash20Int20Strings thrpt??? 5 4188,399 ??? >>>>> 61,255? ops/ms >>>>> IntrinsicsBenchmark.testHash20Int20StringsLoop10 thrpt 5?? >>>>> 4220,161 ??? 55,642? ops/ms >>>>> IntrinsicsBenchmark.testHash20Integers20Strings thrpt 5?? 4188,347 >>>>> ?? 126,054? ops/ms >>>>> IntrinsicsBenchmark.testHash20Integers20StringsLoop10 thrpt??? 5?? >>>>> 4251,327 ??? 86,473? ops/ms >>>>> IntrinsicsBenchmark.testHash20doubles20Strings thrpt 5?? 4206,733 >>>>> ??? 66,459? ops/ms >>>>> IntrinsicsBenchmark.testHash20doubles20StringsLoop10 thrpt??? 5?? >>>>> 4227,479 ??? 78,542? ops/ms >>>>> IntrinsicsBenchmark.testHash25Int25Strings thrpt??? 5 3162,896 ??? >>>>> 68,946? ops/ms >>>>> IntrinsicsBenchmark.testHash25Int25StringsLoop10 thrpt 5?? >>>>> 3190,599 ??? 71,035? ops/ms >>>>> IntrinsicsBenchmark.testHash25Integers25Strings thrpt 5?? 3153,547 >>>>> ??? 59,114? ops/ms >>>>> IntrinsicsBenchmark.testHash25Integers25StringsLoop10 thrpt??? 5?? >>>>> 3200,687 ??? 56,650? ops/ms >>>>> IntrinsicsBenchmark.testHash25doubles25Strings thrpt 5?? 3166,884 >>>>> ??? 46,123? ops/ms >>>>> IntrinsicsBenchmark.testHash25doubles25StringsLoop10 thrpt??? 5?? >>>>> 3202,177 ??? 36,159? ops/ms >>>>> IntrinsicsBenchmark.testHash50Int50Strings thrpt??? 5 6,485 ???? >>>>> 0,054? ops/ms >>>>> IntrinsicsBenchmark.testHash50Int50StringsLoop10 thrpt 5????? >>>>> 6,543 ???? 0,265? ops/ms >>>>> IntrinsicsBenchmark.testHash50Integers50Strings thrpt 5????? 6,376 >>>>> ???? 0,150? ops/ms >>>>> IntrinsicsBenchmark.testHash50Integers50StringsLoop10 thrpt??? >>>>> 5????? 6,774 ???? 0,159? ops/ms >>>>> IntrinsicsBenchmark.testHash50doubles50Strings thrpt 5????? 6,548 >>>>> ???? 0,303? ops/ms >>>>> IntrinsicsBenchmark.testHash50doubles50StringsLoop10 thrpt??? >>>>> 5????? 6,687 ???? 0,081? ops/ms >>>>> >>>>>> Am 05.03.2019 um 16:31 schrieb Vicente Romero >>>>>> : >>>>>> >>>>>> >>>>>> >>>>>> On 3/5/19 9:02 AM, Hannes Walln?fer wrote: >>>>>>> Vicente, >>>>>>> >>>>>>> could it be that your your change in Object::hash bootstraps[1] >>>>>>> mostly benefits invocations with very large numbers of >>>>>>> parameters (like your original 100 parameter tests) but hurts >>>>>>> performance with medium-to-lower number of parameters? I don?t >>>>>>> have your latest benchmark sources, but I did some quick tests >>>>>>> such as a testHash5Ints5Strings that suggest that may be the case. >>>>>> that could be, but the intrinsified version is still faster for >>>>>> those cases with small number of arguments. That's probably why I >>>>>> have focused on the larger number of argument case but we can >>>>>> change priorities or even have different callsites depending on >>>>>> the number of arguments >>>>>> >>>>>>> [1] http://hg.openjdk.java.net/amber/amber/rev/0f40d5752eb9 >>>>>>> >>>>>>> Hannes >>>>>> Vicente >>>>>> >>>>>>>> Am 05.03.2019 um 03:52 schrieb Vicente Romero >>>>>>>> : >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> On 3/4/19 8:11 PM, Alex Buckley wrote: >>>>>>>>> // Adopting a zero-decimal-places policy because precision to >>>>>>>>> multiple decimal places is less important than accuracy and >>>>>>>>> repeatability. >>>>>>>>> >>>>>>>>> On 3/4/2019 4:28 PM, Vicente Romero wrote: >>>>>>>>>> I have uploaded another round of experiments for >>>>>>>>>> Objects::hash, see [1]. >>>>>>>>>> The main variation I have included a variant of most of the >>>>>>>>>> tests in >>>>>>>>>> which instead of invoking Objects::hash 10 times >>>>>>>>>> sequentially, the same >>>>>>>>>> invocation occurs inside a loop which is executed 10 times. >>>>>>>>>> This shows >>>>>>>>>> that when the call site is reused, the execution time trumps >>>>>>>>>> vanilla >>>>>>>>>> JDK13 most of the time. >>>>>>>>> That's not really the story though :-) Yes, the >>>>>>>>> *Int*StringsLoop10 tests run faster with intrinsified >>>>>>>>> invocation than with vanilla invocation, but generally, the >>>>>>>>> *Int*StringsLoop10 tests enjoy less impressive speedups than >>>>>>>>> the *Int*Strings tests. (Example: 25Int25Strings gets a 21x >>>>>>>>> speedup, but 25Int25StringsLoop10 only gets a 2x speedup.) >>>>>>>>> >>>>>>>>> This is because the *Int*StringsLoop10 tests already run >>>>>>>>> faster on vanilla JDK 13 than the *Int*Strings tests, >>>>>>>>> presumably thanks to inlining ("the call site is reused"). >>>>>>>>> >>>>>>>>> I guess that 1IntLoop10, 2IntsLoop10, and 2Ints2StringsLoop10 >>>>>>>>> would have such high throughput on vanilla JDK 13 that their >>>>>>>>> speedups with intrinsification might be significantly <1. >>>>>>>> not in all cases, see [1] the new information is highlighted in >>>>>>>> yellow >>>>>>>>> Alex >>>>>>>> Vicente >>>>>>>> >>>>>>>> [1] >>>>>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/benchmarkResults_intrinsics_all_data_v4.html >> > From shade at redhat.com Fri Mar 15 10:05:16 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 15 Mar 2019 11:05:16 +0100 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> <355ed605-b2f6-198e-efdf-06d781d764dd@oracle.com> Message-ID: <21b105a5-51ea-fa77-2410-f0380f3c4b49@redhat.com> On 3/15/19 3:13 AM, Vicente Romero wrote: > Please see the performance of both implementations for the multi-threaded version [1]. > > [1] > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html I'd drop "volatile" qualifier from the fields you are reading from. "volatile" (acquire) semantics probably breaks some optimizations, and might not be the overwhelmingly common case for hashCode computations. JMH breaks the folding across @Benchmark calls already. It might not matter that much for the tests where you read all the fields and then call into Objects.hash, but better be safe than sorry. -Aleksey From vicente.romero at oracle.com Fri Mar 15 13:05:35 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Fri, 15 Mar 2019 09:05:35 -0400 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: <21b105a5-51ea-fa77-2410-f0380f3c4b49@redhat.com> References: <4e2f9519-50fb-9871-9af9-9ddf91a8877a@oracle.com> <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> <355ed605-b2f6-198e-efdf-06d781d764dd@oracle.com> <21b105a5-51ea-fa77-2410-f0380f3c4b49@redhat.com> Message-ID: On 3/15/19 6:05 AM, Aleksey Shipilev wrote: > On 3/15/19 3:13 AM, Vicente Romero wrote: >> Please see the performance of both implementations for the multi-threaded version [1]. >> >> [1] >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html > I'd drop "volatile" qualifier from the fields you are reading from. "volatile" (acquire) semantics will do, thanks for checking this > probably breaks some optimizations, and might not be the overwhelmingly common case for hashCode > computations. JMH breaks the folding across @Benchmark calls already. It might not matter that much > for the tests where you read all the fields and then call into Objects.hash, but better be safe than > sorry. > > -Aleksey > Vicente From vicente.romero at oracle.com Sat Mar 16 01:34:21 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Fri, 15 Mar 2019 21:34:21 -0400 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: References: <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> <355ed605-b2f6-198e-efdf-06d781d764dd@oracle.com> <21b105a5-51ea-fa77-2410-f0380f3c4b49@redhat.com> Message-ID: and here are the results after removing the volative qualifier from the fields: http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v10/benchmarkResults_intrinsics_all_data_v10.html I will be sending another results in another iteration with a minor change proposed by Maurizio, Thanks for the feedback so far, Vicente On 3/15/19 9:05 AM, Vicente Romero wrote: > > > On 3/15/19 6:05 AM, Aleksey Shipilev wrote: >> On 3/15/19 3:13 AM, Vicente Romero wrote: >>> Please see the performance of both implementations for the >>> multi-threaded version [1]. >>> >>> [1] >>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html >>> >> I'd drop "volatile" qualifier from the fields you are reading from. >> "volatile" (acquire) semantics > > will do, thanks for checking this >> probably breaks some optimizations, and might not be the >> overwhelmingly common case for hashCode >> computations. JMH breaks the folding across @Benchmark calls already. >> It might not matter that much >> for the tests where you read all the fields and then call into >> Objects.hash, but better be safe than >> sorry. >> >> -Aleksey >> > Vicente From vicente.romero at oracle.com Tue Mar 19 14:08:51 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 19 Mar 2019 10:08:51 -0400 Subject: [intrinsics] performance improvements for the intrinsified version of Objects::hash In-Reply-To: References: <5C7736F9.6030302@oracle.com> <27d781e1-b2e1-4e4f-0ece-867986a48f57@oracle.com> <9b6d59dc-8cf1-18ef-d42a-7febd9204fbb@oracle.com> <293db375-72c1-f331-17cc-4b3643e4cdb7@oracle.com> <5C7DCCB1.5010709@oracle.com> <3f88dc34-d8b2-0626-f90a-e84e82b9ab01@oracle.com> <00B86C6E-745C-4C7D-AB9F-6463A5017ADD@oracle.com> <1CC325B1-DB9E-4D26-8827-9DC1734A6F7C@oracle.com> <22bc3f55-32e1-7371-7a22-c88ec5af8b34@oracle.com> <81EA3CBC-E66C-4D34-B92F-AB93F0CDA5B0@oracle.com> <355ed605-b2f6-198e-efdf-06d781d764dd@oracle.com> <21b105a5-51ea-fa77-2410-f0380f3c4b49@redhat.com> Message-ID: <00cb821d-94ea-0d7d-9e01-a6a01b61f853@oracle.com> Please check the results for the String::format benchmark at [1]. I have kept the same data types and argument set as with the Objects::hash benchmark to have more context for the comparison, Thanks, Vicente [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/string_format/v1/benchmarkResults_intrinsics_string_format_v1.html On 3/15/19 9:34 PM, Vicente Romero wrote: > and here are the results after removing the volative qualifier from > the fields: > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v10/benchmarkResults_intrinsics_all_data_v10.html > > > I will be sending another results in another iteration with a minor > change proposed by Maurizio, > > Thanks for the feedback so far, > Vicente > > On 3/15/19 9:05 AM, Vicente Romero wrote: >> >> >> On 3/15/19 6:05 AM, Aleksey Shipilev wrote: >>> On 3/15/19 3:13 AM, Vicente Romero wrote: >>>> Please see the performance of both implementations for the >>>> multi-threaded version [1]. >>>> >>>> [1] >>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html >>>> >>> I'd drop "volatile" qualifier from the fields you are reading from. >>> "volatile" (acquire) semantics >> >> will do, thanks for checking this >>> probably breaks some optimizations, and might not be the >>> overwhelmingly common case for hashCode >>> computations. JMH breaks the folding across @Benchmark calls >>> already. It might not matter that much >>> for the tests where you read all the fields and then call into >>> Objects.hash, but better be safe than >>> sorry. >>> >>> -Aleksey >>> >> Vicente > From vicente.romero at oracle.com Wed Mar 20 01:56:35 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 19 Mar 2019 21:56:35 -0400 Subject: how reliable JMH's results are Message-ID: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> Hi, Today at the amber meeting there was a debate about why some JMH's results vary between executions. Well first of all these are experiments and in all experiments, there is a certain degree of variability that can't be controlled. So I got the last version of our beloved IntrinsicsBenchmark class see [1] and made some changes to it, basically every field has been initialized with a different literal, as proposed by Maurizio. Then I took only the `int` oriented tests, the first 9 in the benchmark and executed then a number of times. All executions are done with vanilla JDK13 no intrinsics at play here! First I executed the tests 3 times with the same conditions: 3 warm-up iterations and 5 iterations for measurements. See the wild differences in the score and the error columns [2], mostly for the tests with the smallest number of arguments. I have no explanation for this. Then I started playing with both parameters warm-up and measurements iterations and executed another 4 experiments. As expected it seems like we should trust more those experiments executed with more iterations, both for warm-up and measurements, as the errors gets reduced. But still the variability is high and it's possible to find non-overlapping intervals for the results of the same experiment even when the error is small. See for example: Experiment 6 row: `IntrinsicsBenchmark.testHash0040Int` and the same row at Experiment 7. So should we interpret these numbers qualitatively too? Are we running the right amount of experiments with the right parameters? I have more questions than answers :) Thanks for listening, Vicente PS, OK reading [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java [2] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html From amaembo at gmail.com Wed Mar 20 02:11:40 2019 From: amaembo at gmail.com (Tagir Valeev) Date: Wed, 20 Mar 2019 09:11:40 +0700 Subject: how reliable JMH's results are In-Reply-To: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> Message-ID: Hello! It's possible that JIT compiles methods in slightly different time point getting slightly different profile which affects its decisions on code generation. After the method is JITted its performance is quite stable until JVM restart, but may have different mode. I would check the generated assembly for the hot methods. Probably it correlates with the observed time. With best regards, Tagir Valeev. ??, 20 ????? 2019 ?., 8:57 Vicente Romero : > Hi, > > Today at the amber meeting there was a debate about why some JMH's > results vary between executions. Well first of all these are experiments > and in all experiments, there is a certain degree of variability that > can't be controlled. > > So I got the last version of our beloved IntrinsicsBenchmark class see > [1] and made some changes to it, basically every field has been > initialized with a different literal, as proposed by Maurizio. Then I > took only the `int` oriented tests, the first 9 in the benchmark and > executed then a number of times. All executions are done with vanilla > JDK13 no intrinsics at play here! > > First I executed the tests 3 times with the same conditions: 3 warm-up > iterations and 5 iterations for measurements. See the wild differences > in the score and the error columns [2], mostly for the tests with the > smallest number of arguments. I have no explanation for this. Then I > started playing with both parameters warm-up and measurements iterations > and executed another 4 experiments. As expected it seems like we should > trust more those experiments executed with more iterations, both for > warm-up and measurements, as the errors gets reduced. But still the > variability is high and it's possible to find non-overlapping intervals > for the results of the same experiment even when the error is small. See > for example: Experiment 6 row: `IntrinsicsBenchmark.testHash0040Int` and > the same row at Experiment 7. So should we interpret these numbers > qualitatively too? Are we running the right amount of experiments with > the right parameters? I have more questions than answers :) > > Thanks for listening, > Vicente > > PS, OK reading > > [1] > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java > [2] > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html > From maurizio.cimadamore at oracle.com Thu Mar 21 11:16:18 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 21 Mar 2019 11:16:18 +0000 Subject: how reliable JMH's results are In-Reply-To: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> Message-ID: <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> Hi Vicente, honestly I wouldn't call these differences 'wild'. Looking at the first column, for the first bench you go from a minimum score of 238982 to a max score of 270472. The difference between the two is ~30000, which is around 15% of the measured value, which seems to be a level of noise comparable with the margin of error. What I can't explain is the difference between these two tables: http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html and http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html The latter is markedly faster than the former - and not by a mere 12%, sometimes by a 2x factor. Look at the Table 2: String - in the first table it seems like we struggle to go past 1x (sometimes we're lower even), in the second table we get 2x pretty much all over the place. I think this is way beyond the level of variance you observed, and this is something that should be investigated (perhaps with the help of some JIT guru?). In general all the tables you have shared are more similar to v9 than to v7 - but I'm worried because if the numbers in v7 are to be taken seriously, the speedup shown there doesn't look anything to write home about. Another (smaller) thing I fail to understand is how the mixed String/int case seems to be sometimes faster than the separate String or int case (or, in most case, close to the best speedup between the two). Here, an important point is to notice that mixed StringInt #1 has to be compared with the row #2 in the separate int/String benchmarks (because the mixed bench takes two arguments). I would have expected the mixed test to fall somewhat in between the int and String results (since one is defo faster and the other seems mostly on par) - but that doesn't seem to be the case. Maurizio On 20/03/2019 01:56, Vicente Romero wrote: > Hi, > > Today at the amber meeting there was a debate about why some JMH's > results vary between executions. Well first of all these are > experiments and in all experiments, there is a certain degree of > variability that can't be controlled. > > So I got the last version of our beloved IntrinsicsBenchmark class see > [1] and made some changes to it, basically every field has been > initialized with a different literal, as proposed by Maurizio. Then I > took only the `int` oriented tests, the first 9 in the benchmark and > executed then a number of times. All executions are done with vanilla > JDK13 no intrinsics at play here! > > First I executed the tests 3 times with the same conditions: 3 warm-up > iterations and 5 iterations for measurements. See the wild differences > in the score and the error columns [2], mostly for the tests with the > smallest number of arguments. I have no explanation for this. Then I > started playing with both parameters warm-up and measurements > iterations and executed another 4 experiments. As expected it seems > like we should trust more those experiments executed with more > iterations, both for warm-up and measurements, as the errors gets > reduced. But still the variability is high and it's possible to find > non-overlapping intervals for the results of the same experiment even > when the error is small. See for example: Experiment 6 row: > `IntrinsicsBenchmark.testHash0040Int` and the same row at Experiment > 7. So should we interpret these numbers qualitatively too? Are we > running the right amount of experiments with the right parameters? I > have more questions than answers :) > > Thanks for listening, > Vicente > > PS, OK reading > > [1] > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java > [2] > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html From vicente.romero at oracle.com Thu Mar 21 16:40:18 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Thu, 21 Mar 2019 12:40:18 -0400 Subject: CFV: New Amber Committer: Joe Darcy Message-ID: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> I hereby nominate Joe Darcy (darcy) to Amber Committer. Joe, who doesn't need too much presentation :), will be working on the reflection area of records and sealed types. A list of his most recent OpenJDK contributions is available at [3]. Votes are due by April 04, 2019. Only current Amber Committers [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thank you, Vicente Romero [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=author(darcy) From brian.goetz at oracle.com Thu Mar 21 16:42:25 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Thu, 21 Mar 2019 12:42:25 -0400 Subject: CFV: New Amber Committer: Joe Darcy In-Reply-To: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> References: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> Message-ID: <8a99f913-e8c3-ddf5-e685-3c2f448f9113@oracle.com> Vote: Yes. On 3/21/2019 12:40 PM, Vicente Romero wrote: > I hereby nominate Joe Darcy (darcy) to Amber Committer. > > Joe, who doesn't need too much presentation :), will be working on the > reflection area of records and sealed types. A list of his most recent > OpenJDK contributions is available at [3]. > > Votes are due by April 04, 2019. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Vicente Romero > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=author(darcy) From vicente.romero at oracle.com Thu Mar 21 16:47:26 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Thu, 21 Mar 2019 12:47:26 -0400 Subject: =?UTF-8?Q?CFV=3a_New_Amber_Committer=3a_Hannes_Walln=c3=b6fer?= Message-ID: I hereby nominate Hannes Walln?fer (hannesw) to Amber Committer. Hannes, has been involved in several projects like Nashorn, Metropolis etc. He has already delivered several contributions to the intrinsics project in Amber. A list of his most recent OpenJDK contributions is available at [3]. Votes are due by April 04, 2019. Only current Amber Committers [1] are eligible to vote on this nomination. For Lazy Consensus voting instructions, see [2]. Thank you, Vicente Romero [1] http://openjdk.java.net/census [2] http://openjdk.java.net/projects/#committer-vote [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=author(hannesw) From maurizio.cimadamore at oracle.com Thu Mar 21 18:10:22 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Thu, 21 Mar 2019 18:10:22 +0000 Subject: CFV: New Amber Committer: Joe Darcy In-Reply-To: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> References: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> Message-ID: <52d944ff-d4a4-9156-91da-a60fa2679f98@oracle.com> Vote: yes! Maurizio On 21/03/2019 16:40, Vicente Romero wrote: > I hereby nominate Joe Darcy (darcy) to Amber Committer. > > Joe, who doesn't need too much presentation :), will be working on the > reflection area of records and sealed types. A list of his most recent > OpenJDK contributions is available at [3]. > > Votes are due by April 04, 2019. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Vicente Romero > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=author(darcy) From james.laskey at oracle.com Thu Mar 21 19:26:14 2019 From: james.laskey at oracle.com (James Laskey) Date: Thu, 21 Mar 2019 16:26:14 -0300 Subject: =?utf-8?Q?Re:_CFV:_New_Amber_Committer:_Hannes_Walln=C3=B6fer?= In-Reply-To: References: Message-ID: <6756D9AD-13F5-447F-86C9-D55DDBCB5F10@oracle.com> Vote: yes Sent from my iPhone > On Mar 21, 2019, at 1:47 PM, Vicente Romero wrote: > > I hereby nominate Hannes Walln?fer (hannesw) to Amber Committer. > > Hannes, has been involved in several projects like Nashorn, Metropolis etc. He has already delivered several contributions to the intrinsics project in Amber. A list of his most recent OpenJDK contributions is available at [3]. > > Votes are due by April 04, 2019. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Vicente Romero > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=author(hannesw) From james.laskey at oracle.com Thu Mar 21 19:26:43 2019 From: james.laskey at oracle.com (James Laskey) Date: Thu, 21 Mar 2019 16:26:43 -0300 Subject: CFV: New Amber Committer: Joe Darcy In-Reply-To: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> References: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> Message-ID: <203569AA-25E5-4BF9-B5CD-8DFC28A69B81@oracle.com> Vote: yes Sent from my iPhone > On Mar 21, 2019, at 1:40 PM, Vicente Romero wrote: > > I hereby nominate Joe Darcy (darcy) to Amber Committer. > > Joe, who doesn't need too much presentation :), will be working on the reflection area of records and sealed types. A list of his most recent OpenJDK contributions is available at [3]. > > Votes are due by April 04, 2019. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Vicente Romero > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=author(darcy) From vicente.romero at oracle.com Fri Mar 22 12:12:19 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Fri, 22 Mar 2019 08:12:19 -0400 Subject: how reliable JMH's results are In-Reply-To: <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> Message-ID: <65c74f33-a8da-6e04-e3da-18c4a7e0dd23@oracle.com> On 3/21/19 7:16 AM, Maurizio Cimadamore wrote: > Hi Vicente, > honestly I wouldn't call these differences 'wild'. Looking at the > first column, for the first bench you go from a minimum score of > 238982 to a max score of 270472. The difference between the two is > ~30000, which is around 15% of the measured value, which seems to be a > level of noise comparable with the margin of error. > > What I can't explain is the difference between these two tables: > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html > > > and > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html > I'm rerunning both tests since yesterday with more measurement iterations, to try to get bigger sample and reduce the standard deviation. Then we can make a better comparison and see if the numbers are really different, but recall that we are dividing the average of two random variables so the error of the result could sometimes be bigger than the error of the separate random variables. Plus it seems to me that there was more variability in V7 and V9 in the measurements of vanilla JDK13 while the measurements of the intrinsics in both versions were more stable. > > The latter is markedly faster than the former - and not by a mere 12%, > sometimes by a 2x factor. Look at the Table 2: String - in the first > table it seems like we struggle to go past 1x (sometimes we're lower > even), in the second table we get 2x pretty much all over the place. I > think this is way beyond the level of variance you observed, and this > is something that should be investigated (perhaps with the help of > some JIT guru?). In general all the tables you have shared are more > similar to v9 than to v7 - but I'm worried because if the numbers in > v7 are to be taken seriously, the speedup shown there doesn't look > anything to write home about. > > Another (smaller) thing I fail to understand is how the mixed > String/int case seems to be sometimes faster than the separate String > or int case (or, in most case, close to the best speedup between the > two). Here, an important point is to notice that mixed StringInt #1 > has to be compared with the row #2 in the separate int/String > benchmarks (because the mixed bench takes two arguments). I would have > expected the mixed test to fall somewhat in between the int and String > results (since one is defo faster and the other seems mostly on par) - > but that doesn't seem to be the case. > > Maurizio Vicente > > On 20/03/2019 01:56, Vicente Romero wrote: >> Hi, >> >> Today at the amber meeting there was a debate about why some JMH's >> results vary between executions. Well first of all these are >> experiments and in all experiments, there is a certain degree of >> variability that can't be controlled. >> >> So I got the last version of our beloved IntrinsicsBenchmark class >> see [1] and made some changes to it, basically every field has been >> initialized with a different literal, as proposed by Maurizio. Then I >> took only the `int` oriented tests, the first 9 in the benchmark and >> executed then a number of times. All executions are done with vanilla >> JDK13 no intrinsics at play here! >> >> First I executed the tests 3 times with the same conditions: 3 >> warm-up iterations and 5 iterations for measurements. See the wild >> differences in the score and the error columns [2], mostly for the >> tests with the smallest number of arguments. I have no explanation >> for this. Then I started playing with both parameters warm-up and >> measurements iterations and executed another 4 experiments. As >> expected it seems like we should trust more those experiments >> executed with more iterations, both for warm-up and measurements, as >> the errors gets reduced. But still the variability is high and it's >> possible to find non-overlapping intervals for the results of the >> same experiment even when the error is small. See for example: >> Experiment 6 row: `IntrinsicsBenchmark.testHash0040Int` and the same >> row at Experiment 7. So should we interpret these numbers >> qualitatively too? Are we running the right amount of experiments >> with the right parameters? I have more questions than answers :) >> >> Thanks for listening, >> Vicente >> >> PS, OK reading >> >> [1] >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java >> [2] >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html From kasperni at gmail.com Fri Mar 22 18:40:20 2019 From: kasperni at gmail.com (Kasper Nielsen) Date: Fri, 22 Mar 2019 18:40:20 +0000 Subject: Add #closeExceptionally(Throwable) to AutoClosable Message-ID: Hi, I was looking at some example on transaction management the other day. And no matter if it is JPA, JDBC og something else. They all look similar to this (or uses some kind of @Transactional annotation coupled with AOP) UserTransaction utx = entityManager.getTransaction(); try { utx.begin(); businessLogic(); utx.commit(); } catch(Exception ex) { utx.rollback(); throw ex; } I think we can all agree that this code is repetitive, error-prone and not very readable. And if you have a large codebase, chances are you might forget commit() or rollback() somewhere. And god forbid you start nesting the calls. You cannot really use try-with-resources here because you need to perform one kind of "close" operation if your business logic succeed and another if it fails. So I though why not add the following method to AutoClosable default closeExceptionally(Throwable cause) throws Exception { close(); } With the implementation of try-with-resources changing to try ResourceSpecification_tail Block catch (Throwable #t) { #primaryExc = #t; throw #t; } finally { if (Identifier != null) { if (#primaryExc != null) { try { Identifier.close(); -------------> Identifier.closeExceptionally(primaryExc); } catch (Throwable #suppressedExc) { #primaryExc.addSuppressed(#suppressedExc); } } else { Identifier.close(); } } } This would allow you use something much simpler. try (var ignore = entityManager.runInNewTransaction()) { businessLogic(); } It does change the semantics on Closable a bit. And it might be problematic that your code will compile fine on older Java versions, but not work as expected because closeExceptionally is never invoked. However, I think it is a net win Thoughts? /Kasper From brian.goetz at oracle.com Sat Mar 23 16:21:03 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Sat, 23 Mar 2019 12:21:03 -0400 Subject: Call for feedback -- enhanced switch In-Reply-To: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> Message-ID: <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> Reminder, now that Java 12 is officially out ... On 3/1/2019 4:55 PM, Brian Goetz wrote: > We would like to promote enhanced switch to a permanent feature in Java 13. So far, the only change we are anticipating is: > > - change ?break value? to ?break-with value?. > > This is the time for people to try it out on their codebases (there?s even refactoring support in IDEA!) and provide feedback on what works, what doesn?t, and what was surprising. > > From forax at univ-mlv.fr Sat Mar 23 17:23:24 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 23 Mar 2019 18:23:24 +0100 (CET) Subject: The keyword sealed is not recognized by jshell Message-ID: <345971617.69929.1553361804379.JavaMail.zimbra@u-pem.fr> Hi all, using the branch "records-and-sealed" (hash ee1dea3bfa8f), jshell doesn't work. I get the following error messages: No corresponding jdk.jshell.CompletenessAnalyzer.TK for com.sun.tools.javac.parser.Tokens.TokenKind: sealed No corresponding TK for TokenKind: sealed see https://travis-ci.org/forax/pro/jobs/510319435 regards, R?mi From rgc197.at.zepler.org at gmail.com Sat Mar 23 17:27:24 2019 From: rgc197.at.zepler.org at gmail.com (Richard Clark) Date: Sat, 23 Mar 2019 17:27:24 +0000 Subject: Add #closeExceptionally(Throwable) to AutoClosable In-Reply-To: References: Message-ID: Hi. Faced with similar issues I've generally found that there is a lot of mileage in pushing this sort of code into the transaction manager itself. The calling code then passes the business logic to an executeTransaction method on the manager who then handles the begin, commit or rollback internally. This allows for even simpler code: manager.executeTransaction(this::businessLogic); >From experience it's a good idea to provide at least two versions for code which either does or does not require return values, so that you don't force either mandatory null returns or returns via result holders: void executeTransaction(Runnable logic); R executeTransaction(Supplier logic); If it's common for your business logic to want manually control the transaction then you can throw in a few for variants to support this: void executeTransaction(Consumer logic); R executeTransaction(Function logic); .. of course the executeTransaction logic will have to inspect the status of the transaction to determine which actions the business logic has already performed. Cheers, Richard. On Fri, 22 Mar 2019 at 18:40, Kasper Nielsen wrote: > Hi, > > I was looking at some example on transaction management the other day. > And no matter if it is JPA, JDBC og something else. They all look > similar to this (or uses some kind of @Transactional annotation > coupled with AOP) > > UserTransaction utx = entityManager.getTransaction(); > > try { > utx.begin(); > businessLogic(); > utx.commit(); > } catch(Exception ex) { > utx.rollback(); > throw ex; > } > > I think we can all agree that this code is repetitive, error-prone and > not very readable. > And if you have a large codebase, chances are you might forget > commit() or rollback() somewhere. And god forbid you start nesting the > calls. > > You cannot really use try-with-resources here because you need to > perform one kind of > "close" operation if your business logic succeed and another if it fails. > > So I though why not add the following method to AutoClosable > > default closeExceptionally(Throwable cause) throws Exception { > close(); > } > > With the implementation of try-with-resources changing to > > try ResourceSpecification_tail > Block > catch (Throwable #t) { > #primaryExc = #t; > throw #t; > } finally { > if (Identifier != null) { > if (#primaryExc != null) { > try { > Identifier.close(); -------------> > Identifier.closeExceptionally(primaryExc); > } catch (Throwable #suppressedExc) { > #primaryExc.addSuppressed(#suppressedExc); > } > } else { > Identifier.close(); > } > } > } > > This would allow you use something much simpler. > > try (var ignore = entityManager.runInNewTransaction()) { > businessLogic(); > } > > It does change the semantics on Closable a bit. And it might be > problematic that your code will compile fine on older Java versions, > but not work as expected because closeExceptionally is never invoked. > However, I think it is a net win > > Thoughts? > > /Kasper > From forax at univ-mlv.fr Sat Mar 23 17:38:13 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Sat, 23 Mar 2019 18:38:13 +0100 (CET) Subject: Call for feedback -- enhanced switch In-Reply-To: <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> Message-ID: <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> And the expression switch is supported by the latest releases of both IntelliJ IDEA and Eclipse [1] BTW, it remember me something i have forgotten to ask, for both ecj and javac, when you compile with --enable-preview, all the classes have they minor version changed even the one that doesn't use the switch expression. I've tried to find where this behaviour was documented in the JEP 12 [2] but the "compile-time" section is not clear about that. Also, the section talk about being able to suppress the preview warning when referencing an entity like a record from another class, but it's not clear if the warning emitted because the switch expression is used in the current class can be suppressed or not, the JEP draws a parallel with @Deprecated so i suppose the answer is yes, in that case javac has to be updated because as far as i know @SuppressWarnings("preview") doesn't work (it works with ecj). regards, R?mi [1] for Eclipse you have to install a patch: https://www.youtube.com/watch?v=TPtXIal9APw [2] https://openjdk.java.net/jeps/12 ----- Mail original ----- > De: "Brian Goetz" > ?: "amber-dev" > Envoy?: Samedi 23 Mars 2019 17:21:03 > Objet: Re: Call for feedback -- enhanced switch > Reminder, now that Java 12 is officially out ... > > On 3/1/2019 4:55 PM, Brian Goetz wrote: >> We would like to promote enhanced switch to a permanent feature in Java 13. So >> far, the only change we are anticipating is: >> >> - change ?break value? to ?break-with value?. >> >> This is the time for people to try it out on their codebases (there?s even >> refactoring support in IDEA!) and provide feedback on what works, what doesn?t, >> and what was surprising. >> From brian.goetz at oracle.com Sat Mar 23 17:40:59 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Sat, 23 Mar 2019 13:40:59 -0400 Subject: Call for feedback -- enhanced switch In-Reply-To: <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> Message-ID: > BTW, it remember me something i have forgotten to ask, for both ecj and javac, when you compile with --enable-preview, all the classes have they minor version changed even the one that doesn't use the switch expression. I've tried to find where this behaviour was documented in the JEP 12 [2] but the "compile-time" section is not clear about that. That's correct.? This is not unlike compiling with -source/-target N; even if it doesn't use any features added in N, it writes out that version of the classfile.? This is predictable for users and way simpler for compilers.? The alternative is getting into an interpretation of "could this classfile run on a different version", whose complexity/benefit ratio would be way out of balance. From forax at univ-mlv.fr Sat Mar 23 17:56:34 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Sat, 23 Mar 2019 18:56:34 +0100 (CET) Subject: Call for feedback -- enhanced switch In-Reply-To: References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> Message-ID: <858512483.71029.1553363794263.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "Brian Goetz" > ?: "Remi Forax" > Cc: "amber-dev" , "Alex Buckley" > Envoy?: Samedi 23 Mars 2019 18:40:59 > Objet: Re: Call for feedback -- enhanced switch >> BTW, it remember me something i have forgotten to ask, for both ecj and javac, >> when you compile with --enable-preview, all the classes have they minor version >> changed even the one that doesn't use the switch expression. I've tried to find >> where this behaviour was documented in the JEP 12 [2] but the "compile-time" >> section is not clear about that. > > That's correct.? This is not unlike compiling with -source/-target N; > even if it doesn't use any features added in N, it writes out that > version of the classfile.? This is predictable for users and way simpler > for compilers.? The alternative is getting into an interpretation of > "could this classfile run on a different version", whose > complexity/benefit ratio would be way out of balance. There is also a balance between normal users that should not be able to use a preview feature by error if it's too easy to use and early adopters that will not use preview features because it's too cumbersome to use (because in that case there is no point to have a preview mechanism). In this particular case, it raises the bar to test the feature because you can not just add a dynamic check saying if the Runtime.version() is JDK-12 then calls that method, something early adapters are used too. So i don't disagree with you but i'm afraid that given the few feedbacks we get, we may have to reconsider how users interact with a preview feature. regards, R?mi From maurizio.cimadamore at oracle.com Sat Mar 23 21:27:47 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Sat, 23 Mar 2019 21:27:47 +0000 Subject: Call for feedback -- enhanced switch In-Reply-To: <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> Message-ID: <63cd6df5-69a0-5eec-c401-612fd9132b08@oracle.com> On 23/03/2019 17:38, Remi Forax wrote: > And the expression switch is supported by the latest releases of both IntelliJ IDEA and Eclipse [1] > > BTW, it remember me something i have forgotten to ask, for both ecj and javac, when you compile with --enable-preview, all the classes have they minor version changed even the one that doesn't use the switch expression. I've tried to find where this behaviour was documented in the JEP 12 [2] but the "compile-time" section is not clear about that. Remi, my initial implementation of JEP 12 was actually doing the finer grained treatment you described. But it was suggested in the review comments that it was too much, and the logic was reverted to a more predictable all-on/all-off switch. > > Also, the section talk about being able to suppress the preview warning when referencing an entity like a record from another class, but it's not clear if the warning emitted because the switch expression is used in the current class can be suppressed or not, the JEP draws a parallel with @Deprecated so i suppose the answer is yes, in that case javac has to be updated because as far as i know @SuppressWarnings("preview") doesn't work (it works with ecj). Right now, suppressible warnings in JEP 12 only apply to preview declaration features (e.g. records), not to statement features. The default behavior javac has is to disable preview warnings by default - but generate a mandatory message if any preview feature was used, either directly or indirectly, as per JEP 12. So, if the user wanted more detailed info about uses of preview features, the -Xlint:preview flag can be used. Javac does not treat these warnings as suppressible at the moment. The risk is that if you do -Xint:preview and allgard your warnings have been suppressed with annotations, you will get no message from javac regarding the use of preview features at all. Of course the implementation can change if we feel that warnings related to usage of preview features should be suppressible too (individually, I mean). I don't see a lot of value in that, though. Maurizio > > regards, > R?mi > > [1] for Eclipse you have to install a patch: https://www.youtube.com/watch?v=TPtXIal9APw > [2] https://openjdk.java.net/jeps/12 > > ----- Mail original ----- >> De: "Brian Goetz" >> ?: "amber-dev" >> Envoy?: Samedi 23 Mars 2019 17:21:03 >> Objet: Re: Call for feedback -- enhanced switch >> Reminder, now that Java 12 is officially out ... >> >> On 3/1/2019 4:55 PM, Brian Goetz wrote: >>> We would like to promote enhanced switch to a permanent feature in Java 13. So >>> far, the only change we are anticipating is: >>> >>> - change ?break value? to ?break-with value?. >>> >>> This is the time for people to try it out on their codebases (there?s even >>> refactoring support in IDEA!) and provide feedback on what works, what doesn?t, >>> and what was surprising. >>> From vicente.romero at oracle.com Sun Mar 24 01:00:19 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sun, 24 Mar 2019 01:00:19 +0000 Subject: hg: amber/amber: folding all bootstraps at ObjectMethodBuilders into one Message-ID: <201903240100.x2O10KIa028387@aojmv0008.oracle.com> Changeset: abb07ff1dbe3 Author: vromero Date: 2019-03-23 20:59 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/abb07ff1dbe3 folding all bootstraps at ObjectMethodBuilders into one ! src/java.base/share/classes/java/lang/invoke/ObjectMethodBuilders.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java From jbvernee at xs4all.nl Sun Mar 24 16:17:28 2019 From: jbvernee at xs4all.nl (Jorn Vernee) Date: Sun, 24 Mar 2019 17:17:28 +0100 Subject: Call for feedback -- enhanced switch In-Reply-To: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> Message-ID: <64c49520f5d94bc8df55c0cf7c350f98@xs4all.nl> Hi, Tried this out with some of the Panama code (did not get the build working with --enable-preview though). Some observations; * for 49 switch statements, ~630 lines were dropped with the refactor. * Pretty much any switch statement benefits from a refactor to the '->' style, because of the ability to drop 'break' or 'return' from branches. * Ability to merge multiple 'case XYZ:' is really nice when having lots of fall-through. This brings forward the code in the branch more, and not just the labels. * Expression switch requires a closing ';'. This is pretty annoying, and doesn't feel like it adds anything. * Exhaustive expression switch for enums is nice, but you have to be careful about not removing the default case when not using an expression switch (or when changing code later). This feels like a source of bugs, but maybe it just takes some getting used to. (Probably it would be nice if the IDE showed some marker when an automatic default case is present). * `break value;` seems fine to me. This feels analogous to `return x;` vs. `return;`. No need for `break-with` imho. * Also, maybe a bug: ``` enum MyEnum { X, Y; } public static void main(String[] args) throws Throwable { int x = 5; int y = 10; MyEnum myEnum = MyEnum.X; int o; switch(myEnum) { case X -> o = x; case Y -> o = y; // automatic exception }; System.out.println(o); } ``` Even though the switch should be exhaustive, javac complains that 'o' might not have been initialized. Cheers, Jorn Brian Goetz schreef op 2019-03-01 22:55: > We would like to promote enhanced switch to a permanent feature in > Java 13. So far, the only change we are anticipating is: > > - change ?break value? to ?break-with value?. > > This is the time for people to try it out on their codebases (there?s > even refactoring support in IDEA!) and provide feedback on what works, > what doesn?t, and what was surprising. From jbvernee at xs4all.nl Sun Mar 24 16:21:36 2019 From: jbvernee at xs4all.nl (Jorn Vernee) Date: Sun, 24 Mar 2019 17:21:36 +0100 Subject: Call for feedback -- enhanced switch In-Reply-To: <858512483.71029.1553363794263.JavaMail.zimbra@u-pem.fr> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> <858512483.71029.1553363794263.JavaMail.zimbra@u-pem.fr> Message-ID: <9836490983fcf45edd36b2581f0dcd36@xs4all.nl> > I'm afraid that given the few > feedbacks we get, we may have to reconsider how users interact with a > preview feature. I think for most people it's copying something they see online into their IDE, and if they can't get it working within an hour they give up and go do something else. IntelliJ & Eclipse support switch expressions, but not out of the box (AFAICT IntelliJ also requires an early access version). There are other problems with tooling as well (recent e.g. https://stackoverflow.com/q/55303837). Setting the javac & VM flags on the command line is easy enough, but I'm proposing that this is not the typical usage mode. I think it just takes time for tooling to catch up with the language/compiler changes before the general public feels that it's 'easy enough' to try out these new features on their code bases. I think for enhanced switch we're only just starting to get to that point. Looking at the questions coming up on Stack Overflow tagged with java-12 [1], with half the questions asked in the last week (out of 15), people are only just starting to use Java 12 at all. So, as far as I can tell, it's still 'early days'. Jorn [1] : https://stackoverflow.com/questions/tagged/java-12 forax at univ-mlv.fr schreef op 2019-03-23 18:56: > ----- Mail original ----- >> De: "Brian Goetz" >> ?: "Remi Forax" >> Cc: "amber-dev" , "Alex Buckley" >> >> Envoy?: Samedi 23 Mars 2019 18:40:59 >> Objet: Re: Call for feedback -- enhanced switch > >>> BTW, it remember me something i have forgotten to ask, for both ecj >>> and javac, >>> when you compile with --enable-preview, all the classes have they >>> minor version >>> changed even the one that doesn't use the switch expression. I've >>> tried to find >>> where this behaviour was documented in the JEP 12 [2] but the >>> "compile-time" >>> section is not clear about that. >> >> That's correct.? This is not unlike compiling with -source/-target N; >> even if it doesn't use any features added in N, it writes out that >> version of the classfile.? This is predictable for users and way >> simpler >> for compilers.? The alternative is getting into an interpretation of >> "could this classfile run on a different version", whose >> complexity/benefit ratio would be way out of balance. > > There is also a balance between normal users that should not be able > to use a preview feature by error if it's too easy to use and early > adopters that will not use preview features because it's too > cumbersome to use (because in that case there is no point to have a > preview mechanism). > > In this particular case, it raises the bar to test the feature because > you can not just add a dynamic check saying if the Runtime.version() > is JDK-12 then calls that method, something early adapters are used > too. So i don't disagree with you but i'm afraid that given the few > feedbacks we get, we may have to reconsider how users interact with a > preview feature. > > regards, > R?mi From forax at univ-mlv.fr Sun Mar 24 17:49:59 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Sun, 24 Mar 2019 18:49:59 +0100 (CET) Subject: Call for feedback -- enhanced switch In-Reply-To: <64c49520f5d94bc8df55c0cf7c350f98@xs4all.nl> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <64c49520f5d94bc8df55c0cf7c350f98@xs4all.nl> Message-ID: <186085075.145968.1553449799270.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "Jorn Vernee" > ?: "Brian Goetz" > Cc: "amber-dev" > Envoy?: Dimanche 24 Mars 2019 17:17:28 > Objet: Re: Call for feedback -- enhanced switch > Hi, > [...] > * Also, maybe a bug: > ``` > enum MyEnum { > X, Y; > } > public static void main(String[] args) throws Throwable { > int x = 5; > int y = 10; > MyEnum myEnum = MyEnum.X; > int o; > switch(myEnum) { > case X -> o = x; > case Y -> o = y; > // automatic exception > }; > System.out.println(o); > } > ``` > Even though the switch should be exhaustive, javac complains that 'o' > might not have been initialized. yes, it's a bug. And ecj has the same issue :( > > Cheers, > Jorn regards, R?mi > > Brian Goetz schreef op 2019-03-01 22:55: >> We would like to promote enhanced switch to a permanent feature in >> Java 13. So far, the only change we are anticipating is: >> >> - change ?break value? to ?break-with value?. >> >> This is the time for people to try it out on their codebases (there?s >> even refactoring support in IDEA!) and provide feedback on what works, > > what doesn?t, and what was surprising. From jbvernee at xs4all.nl Sun Mar 24 17:55:48 2019 From: jbvernee at xs4all.nl (Jorn Vernee) Date: Sun, 24 Mar 2019 18:55:48 +0100 Subject: Call for feedback -- enhanced switch In-Reply-To: <186085075.145968.1553449799270.JavaMail.zimbra@u-pem.fr> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <64c49520f5d94bc8df55c0cf7c350f98@xs4all.nl> <186085075.145968.1553449799270.JavaMail.zimbra@u-pem.fr> Message-ID: <534b66173a0f6f3a260001b636814b74@xs4all.nl> Actually, I just realized that there is no `// automatic exception` because this is not an expression switch :) If I remove the println to make it compile I get: ``` 24: lookupswitch { // 2 1: 52 2: 58 default: 61 } 52: iload_1 53: istore 4 55: goto 61 58: iload_2 59: istore 4 61: return ``` (i.e. no exception) I guess this further proves my point that existence of automatic default can be confusing... Jorn Remi Forax schreef op 2019-03-24 18:49: > ----- Mail original ----- >> De: "Jorn Vernee" >> ?: "Brian Goetz" >> Cc: "amber-dev" >> Envoy?: Dimanche 24 Mars 2019 17:17:28 >> Objet: Re: Call for feedback -- enhanced switch > >> Hi, >> > > [...] > >> * Also, maybe a bug: >> ``` >> enum MyEnum { >> X, Y; >> } >> public static void main(String[] args) throws Throwable { >> int x = 5; >> int y = 10; >> MyEnum myEnum = MyEnum.X; >> int o; >> switch(myEnum) { >> case X -> o = x; >> case Y -> o = y; >> // automatic exception >> }; >> System.out.println(o); >> } >> ``` >> Even though the switch should be exhaustive, javac complains that >> 'o' >> might not have been initialized. > > yes, it's a bug. And ecj has the same issue :( > >> >> Cheers, >> Jorn > > regards, > R?mi > >> >> Brian Goetz schreef op 2019-03-01 22:55: >>> We would like to promote enhanced switch to a permanent feature in >>> Java 13. So far, the only change we are anticipating is: >>> >>> - change ?break value? to ?break-with value?. >>> >>> This is the time for people to try it out on their codebases (there?s >>> even refactoring support in IDEA!) and provide feedback on what >>> works, >> > what doesn?t, and what was surprising. From forax at univ-mlv.fr Sun Mar 24 17:57:47 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Sun, 24 Mar 2019 18:57:47 +0100 (CET) Subject: Call for feedback -- enhanced switch In-Reply-To: <63cd6df5-69a0-5eec-c401-612fd9132b08@oracle.com> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> <63cd6df5-69a0-5eec-c401-612fd9132b08@oracle.com> Message-ID: <1000993862.146357.1553450267476.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "Maurizio Cimadamore" > ?: "Remi Forax" , "Brian Goetz" > Cc: "amber-dev" > Envoy?: Samedi 23 Mars 2019 22:27:47 > Objet: Re: Call for feedback -- enhanced switch > On 23/03/2019 17:38, Remi Forax wrote: >> And the expression switch is supported by the latest releases of both IntelliJ >> IDEA and Eclipse [1] >> >> BTW, it remember me something i have forgotten to ask, for both ecj and javac, >> when you compile with --enable-preview, all the classes have they minor version >> changed even the one that doesn't use the switch expression. I've tried to find >> where this behaviour was documented in the JEP 12 [2] but the "compile-time" >> section is not clear about that. > > Remi, my initial implementation of JEP 12 was actually doing the finer > grained treatment you described. I'm not sure which implementation is better, but anyway, at least the current behavior should be documented in the spec, as you said, at least the semantics of the current implementation is clear. > > But it was suggested in the review comments that it was too much, and > the logic was reverted to a more predictable all-on/all-off switch. > >> >> Also, the section talk about being able to suppress the preview warning when >> referencing an entity like a record from another class, but it's not clear if >> the warning emitted because the switch expression is used in the current class >> can be suppressed or not, the JEP draws a parallel with @Deprecated so i >> suppose the answer is yes, in that case javac has to be updated because as far >> as i know @SuppressWarnings("preview") doesn't work (it works with ecj). > > Right now, suppressible warnings in JEP 12 only apply to preview > declaration features (e.g. records), not to statement features. > > The default behavior javac has is to disable preview warnings by default > - but generate a mandatory message if any preview feature was used, > either directly or indirectly, as per JEP 12. > > So, if the user wanted more detailed info about uses of preview > features, the -Xlint:preview flag can be used. Javac does not treat > these warnings as suppressible at the moment. The risk is that if you do > -Xint:preview and allgard your warnings have been suppressed with > annotations, you will get no message from javac regarding the use of > preview features at all. > > Of course the implementation can change if we feel that warnings related > to usage of preview features should be suppressible too (individually, I > mean). I don't see a lot of value in that, though. i disagree, if i don't specify --enable-preview at compile time, i will get an error for each switch expressions, so having the warning non suppressible doesn't give me more info, it just adds noise. > > Maurizio R?mi > > >> >> regards, >> R?mi >> >> [1] for Eclipse you have to install a patch: >> https://www.youtube.com/watch?v=TPtXIal9APw >> [2] https://openjdk.java.net/jeps/12 >> >> ----- Mail original ----- >>> De: "Brian Goetz" >>> ?: "amber-dev" >>> Envoy?: Samedi 23 Mars 2019 17:21:03 >>> Objet: Re: Call for feedback -- enhanced switch >>> Reminder, now that Java 12 is officially out ... >>> >>> On 3/1/2019 4:55 PM, Brian Goetz wrote: >>>> We would like to promote enhanced switch to a permanent feature in Java 13. So >>>> far, the only change we are anticipating is: >>>> >>>> - change ?break value? to ?break-with value?. >>>> >>>> This is the time for people to try it out on their codebases (there?s even >>>> refactoring support in IDEA!) and provide feedback on what works, what doesn?t, >>>> and what was surprising. From forax at univ-mlv.fr Sun Mar 24 18:00:37 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Sun, 24 Mar 2019 19:00:37 +0100 (CET) Subject: Call for feedback -- enhanced switch In-Reply-To: <534b66173a0f6f3a260001b636814b74@xs4all.nl> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <64c49520f5d94bc8df55c0cf7c350f98@xs4all.nl> <186085075.145968.1553449799270.JavaMail.zimbra@u-pem.fr> <534b66173a0f6f3a260001b636814b74@xs4all.nl> Message-ID: <97942090.146710.1553450437275.JavaMail.zimbra@u-pem.fr> ----- Mail original ----- > De: "Jorn Vernee" > ?: "Remi Forax" > Cc: "Brian Goetz" , "amber-dev" > Envoy?: Dimanche 24 Mars 2019 18:55:48 > Objet: Re: Call for feedback -- enhanced switch > Actually, I just realized that there is no `// automatic exception` > because this is not an expression switch :) If I remove the println to > make it compile I get: > > ``` > 24: lookupswitch { // 2 > 1: 52 > 2: 58 > default: 61 > } > 52: iload_1 > 53: istore 4 > 55: goto 61 > 58: iload_2 > 59: istore 4 > 61: return > ``` > (i.e. no exception) > > I guess this further proves my point that existence of automatic default > can be confusing... hum, this one still doesn't work ! enum MyEnum { X, Y; public static void main(String[] args) { MyEnum myEnum = MyEnum.X; int o; var f = switch(myEnum) { case X -> o = 5; case Y -> o = 10; // automatic exception }; System.out.println(o); } } > > Jorn R?mi > > Remi Forax schreef op 2019-03-24 18:49: >> ----- Mail original ----- >>> De: "Jorn Vernee" >>> ?: "Brian Goetz" >>> Cc: "amber-dev" >>> Envoy?: Dimanche 24 Mars 2019 17:17:28 >>> Objet: Re: Call for feedback -- enhanced switch >> >>> Hi, >>> >> >> [...] >> >>> * Also, maybe a bug: >>> ``` >>> enum MyEnum { >>> X, Y; >>> } >>> public static void main(String[] args) throws Throwable { >>> int x = 5; >>> int y = 10; >>> MyEnum myEnum = MyEnum.X; >>> int o; >>> switch(myEnum) { >>> case X -> o = x; >>> case Y -> o = y; >>> // automatic exception >>> }; >>> System.out.println(o); >>> } >>> ``` >>> Even though the switch should be exhaustive, javac complains that >>> 'o' >>> might not have been initialized. >> >> yes, it's a bug. And ecj has the same issue :( >> >>> >>> Cheers, >>> Jorn >> >> regards, >> R?mi >> >>> >>> Brian Goetz schreef op 2019-03-01 22:55: >>>> We would like to promote enhanced switch to a permanent feature in >>>> Java 13. So far, the only change we are anticipating is: >>>> >>>> - change ?break value? to ?break-with value?. >>>> >>>> This is the time for people to try it out on their codebases (there?s >>>> even refactoring support in IDEA!) and provide feedback on what >>>> works, > >> > what doesn?t, and what was surprising. From vicente.romero at oracle.com Sun Mar 24 19:25:58 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sun, 24 Mar 2019 19:25:58 +0000 Subject: hg: amber/amber: allow overriding of accessors / equals / hashCode / toString, pass provided accessors to the extractor Message-ID: <201903241925.x2OJPxgF011704@aojmv0008.oracle.com> Changeset: e752ba81c19d Author: vromero Date: 2019-03-24 15:25 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/e752ba81c19d allow overriding of accessors / equals / hashCode / toString, pass provided accessors to the extractor ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java + test/langtools/tools/javac/datum/RecordsCanReDeclareMembersTest.java - test/langtools/tools/javac/datum/RecordsCantDeclareSomeMembersTest.java - test/langtools/tools/javac/datum/RecordsCantDeclareSomeMembersTest.out From mrjarviscraft at gmail.com Sun Mar 24 19:52:36 2019 From: mrjarviscraft at gmail.com (JARvis PROgrammer) Date: Sun, 24 Mar 2019 22:52:36 +0300 Subject: Method chaining JEP draft Message-ID: Hi there, At current I am working on a draft for the language feature to allow non-static methods to declare themselves as `returning instance on which they were called` (a builder pattern is the best illustration of such type of methods) making it automatic (rather than forcing the developer to use return this) or (as another option to be declared by this JEP) to allow such behaviour for void methods. This is a draft at my local PC (he-he) and Gist at the moment and is only under construction but is it at all worth workin on it? This feature seems to be an obvious one and might have been discussed in past and yet there seems to be no JEP addressed for it. So should I continue working on a draft (for discussion here, of course) or this was already discussed and there are already existing pros&cons for this because of which this feature is not anywhere now? Thanks, Peter P. From forax at univ-mlv.fr Sun Mar 24 20:22:01 2019 From: forax at univ-mlv.fr (Remi Forax) Date: Sun, 24 Mar 2019 21:22:01 +0100 (CET) Subject: Method chaining JEP draft In-Reply-To: References: Message-ID: <836962572.155632.1553458921302.JavaMail.zimbra@u-pem.fr> Hi Peter, this has already discussed and rejected under the umbrella of project Coin (for Java 7), the keywords you are looking for is "chained invocation". see by example https://stackoverflow.com/questions/1011916/chained-invocation-in-java-7 In the case of builders used to initialize a non-mutable value in a mutable way, like StringBuilder allow to initialize a String, this feature is also related to Java support of the new "withfield" opcode introduced in project Valhalla (for initializing value types). But given that you are posting on amber-dev, i suppose that you are thinking in term of records, as far as i know, nobody has proposed to have withers (setter that can be chained) for records but the fact that records are non mutable is something relatively new in term of design. cheers, R?mi ----- Mail original ----- > De: "JARvis PROgrammer" > ?: "amber-dev" > Envoy?: Dimanche 24 Mars 2019 20:52:36 > Objet: Method chaining JEP draft > Hi there, > At current I am working on a draft for the language feature to allow > non-static methods to declare themselves as `returning instance on which > they were called` (a builder pattern is the best illustration of such type > of methods) making it automatic (rather than forcing the developer to > use return > this) or (as another option to be declared by this JEP) to allow such > behaviour for void methods. > This is a draft at my local PC (he-he) and Gist at the moment and is only > under construction but is it at all worth workin on it? This feature seems > to be an obvious one and might have been discussed in past and yet there > seems to be no JEP addressed for it. > > So should I continue working on a draft (for discussion here, of course) or > this was already discussed and there are already existing pros&cons for > this because of which this feature is not anywhere now? > > Thanks, > Peter P. From vicente.romero at oracle.com Sun Mar 24 20:58:02 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sun, 24 Mar 2019 20:58:02 +0000 Subject: hg: amber/amber: user defined accessors and primary constructors must be public Message-ID: <201903242058.x2OKw3CV024750@aojmv0008.oracle.com> Changeset: f2be2adb747f Author: vromero Date: 2019-03-24 16:57 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/f2be2adb747f user defined accessors and primary constructors must be public ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TypeEnter.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/langtools/tools/javac/datum/ParameterLessConstructorsTest.java + test/langtools/tools/javac/datum/PrimaryConstructorMustBePublic.java + test/langtools/tools/javac/datum/PrimaryConstructorMustBePublic.out + test/langtools/tools/javac/datum/UserDefinedAccessorsMustBePublic.java + test/langtools/tools/javac/datum/UserDefinedAccessorsMustBePublic.out From vicente.romero at oracle.com Sun Mar 24 22:06:16 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Sun, 24 Mar 2019 22:06:16 +0000 Subject: hg: amber/amber: allow sealed records Message-ID: <201903242206.x2OM6Hrn026965@aojmv0008.oracle.com> Changeset: cc3d1484e813 Author: vromero Date: 2019-03-24 18:03 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/cc3d1484e813 allow sealed records ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java From amaembo at gmail.com Mon Mar 25 03:06:25 2019 From: amaembo at gmail.com (Tagir Valeev) Date: Mon, 25 Mar 2019 10:06:25 +0700 Subject: Call for feedback -- enhanced switch In-Reply-To: <9836490983fcf45edd36b2581f0dcd36@xs4all.nl> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> <858512483.71029.1553363794263.JavaMail.zimbra@u-pem.fr> <9836490983fcf45edd36b2581f0dcd36@xs4all.nl> Message-ID: Hello! > IntelliJ & Eclipse support switch expressions, but not out of the box > (AFAICT IntelliJ also requires an early access version). It's true that IntelliJ requires non-released version, but we are already on release candidate stage: https://blog.jetbrains.com/idea/2019/03/intellij-idea-2019-1-release-candidate-is-out/ The release is planned this week. Otherwisely the preview features support is available out-of-the-box. You should just install the release candidate and change project level to 12 (Preview) or just type some switch expression and IDE would suggest you to change project level. Well, you also need to install JDK 12 to be able to compile and run the result. Please report if your experience differs and you actually need more steps. Thank you. With best regards, Tagir Valeev. From vicente.romero at oracle.com Mon Mar 25 14:32:39 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Mon, 25 Mar 2019 14:32:39 +0000 Subject: hg: amber/amber: allow sealed classes in jshell Message-ID: <201903251432.x2PEWenh012896@aojmv0008.oracle.com> Changeset: 93c8b30e4755 Author: vromero Date: 2019-03-25 10:32 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/93c8b30e4755 allow sealed classes in jshell ! src/jdk.jshell/share/classes/jdk/jshell/CompletenessAnalyzer.java From vicente.romero at oracle.com Mon Mar 25 14:38:19 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Mon, 25 Mar 2019 10:38:19 -0400 Subject: The keyword sealed is not recognized by jshell In-Reply-To: <345971617.69929.1553361804379.JavaMail.zimbra@u-pem.fr> References: <345971617.69929.1553361804379.JavaMail.zimbra@u-pem.fr> Message-ID: <96c4c2e9-6369-5adf-6187-3e9b77a6cee7@oracle.com> oops, fixed: http://hg.openjdk.java.net/amber/amber/rev/93c8b30e4755 Vicente On 3/23/19 1:23 PM, Remi Forax wrote: > Hi all, > using the branch "records-and-sealed" (hash ee1dea3bfa8f), jshell doesn't work. > > I get the following error messages: > No corresponding jdk.jshell.CompletenessAnalyzer.TK for com.sun.tools.javac.parser.Tokens.TokenKind: sealed > No corresponding TK for TokenKind: sealed > > see https://travis-ci.org/forax/pro/jobs/510319435 > > regards, > R?mi From forax at univ-mlv.fr Mon Mar 25 14:40:10 2019 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Mon, 25 Mar 2019 15:40:10 +0100 (CET) Subject: The keyword sealed is not recognized by jshell In-Reply-To: <96c4c2e9-6369-5adf-6187-3e9b77a6cee7@oracle.com> References: <345971617.69929.1553361804379.JavaMail.zimbra@u-pem.fr> <96c4c2e9-6369-5adf-6187-3e9b77a6cee7@oracle.com> Message-ID: <361183728.214692.1553524810604.JavaMail.zimbra@u-pem.fr> let's test that :) R?mi ----- Mail original ----- > De: "Vicente Romero" > ?: "Remi Forax" , "amber-dev" > Envoy?: Lundi 25 Mars 2019 15:38:19 > Objet: Re: The keyword sealed is not recognized by jshell > oops, fixed: > > http://hg.openjdk.java.net/amber/amber/rev/93c8b30e4755 > > Vicente > > On 3/23/19 1:23 PM, Remi Forax wrote: >> Hi all, >> using the branch "records-and-sealed" (hash ee1dea3bfa8f), jshell doesn't work. >> >> I get the following error messages: >> No corresponding jdk.jshell.CompletenessAnalyzer.TK for >> com.sun.tools.javac.parser.Tokens.TokenKind: sealed >> No corresponding TK for TokenKind: sealed >> >> see https://travis-ci.org/forax/pro/jobs/510319435 >> >> regards, > > R?mi From jan.lahoda at oracle.com Mon Mar 25 15:41:52 2019 From: jan.lahoda at oracle.com (Jan Lahoda) Date: Mon, 25 Mar 2019 16:41:52 +0100 Subject: Call for feedback -- enhanced switch In-Reply-To: <97942090.146710.1553450437275.JavaMail.zimbra@u-pem.fr> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <64c49520f5d94bc8df55c0cf7c350f98@xs4all.nl> <186085075.145968.1553449799270.JavaMail.zimbra@u-pem.fr> <534b66173a0f6f3a260001b636814b74@xs4all.nl> <97942090.146710.1553450437275.JavaMail.zimbra@u-pem.fr> Message-ID: <5C98F6C0.9020207@oracle.com> On 24.3.2019 19:00, forax at univ-mlv.fr wrote: > hum, this one still doesn't work ! > > enum MyEnum { > X, Y; > > public static void main(String[] args) { > MyEnum myEnum = MyEnum.X; > int o; > var f = switch(myEnum) { > case X -> o = 5; > case Y -> o = 10; > // automatic exception > }; > System.out.println(o); > } > } Thanks, I've filled: https://bugs.openjdk.java.net/browse/JDK-8221413 Jan From alex.buckley at oracle.com Mon Mar 25 18:22:02 2019 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 25 Mar 2019 11:22:02 -0700 Subject: Call for feedback -- enhanced switch In-Reply-To: <1000993862.146357.1553450267476.JavaMail.zimbra@u-pem.fr> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> <63cd6df5-69a0-5eec-c401-612fd9132b08@oracle.com> <1000993862.146357.1553450267476.JavaMail.zimbra@u-pem.fr> Message-ID: <5C991C4A.1090900@oracle.com> On 3/24/2019 10:57 AM, forax at univ-mlv.fr wrote: > ----- Mail original ----- >> De: "Maurizio Cimadamore" >> ?: "Remi Forax" , "Brian Goetz" >> Cc: "amber-dev" >> Envoy?: Samedi 23 Mars 2019 22:27:47 >> Objet: Re: Call for feedback -- enhanced switch > >> On 23/03/2019 17:38, Remi Forax wrote: >>> And the expression switch is supported by the latest releases of both IntelliJ >>> IDEA and Eclipse [1] >>> >>> BTW, it remember me something i have forgotten to ask, for both ecj and javac, >>> when you compile with --enable-preview, all the classes have they minor version >>> changed even the one that doesn't use the switch expression. I've tried to find >>> where this behaviour was documented in the JEP 12 [2] but the "compile-time" >>> section is not clear about that. >> >> Remi, my initial implementation of JEP 12 was actually doing the finer >> grained treatment you described. > > I'm not sure which implementation is better, but anyway, at least the current behavior should be documented in the spec, > as you said, at least the semantics of the current implementation is clear. JEP 12 is not a spec for javac. JEP 12 is a policy document which, though its sections "Design of a Preview Feature", "Use of Preview Features", and "Relationship to Java SE APIs", lays groundwork for the Java SE Platform Spec. (See http://cr.openjdk.java.net/~iris/se/12/latestSpec/#Preview-features) Accordingly, JEP 12 mandates the smallest possible behavior for Java compilers and runtimes that is consistent with its policy goals. That's why it requires only: "If Java source code uses a preview language feature of Java SE $N, then a Java compiler must record that the emitted class file depends on the preview VM features of Java SE $N." and does not require the inverse, "If Java source code does not use a preview language feature, then a Java compiler must not record that the emitted class file depends on preview VM features." (For one thing, that inverse requirement, as written, would be inappropriate if a Java compiler started compiling an old language feature into a class file that genuinely uses a preview VM feature.) For convenience, JEP 12 has a section "Example use of preview features" which discusses how javac could enable preview features. That's not a spec, but to help readers, I have added this: "- Every `class` file emitted by `javac` _depends on the preview VM features of Java SE $N_, regardless of whether the source code corresponding to the `class` file actually uses preview language features of Java SE $N." Alex From alex.buckley at oracle.com Mon Mar 25 18:27:42 2019 From: alex.buckley at oracle.com (Alex Buckley) Date: Mon, 25 Mar 2019 11:27:42 -0700 Subject: Call for feedback -- enhanced switch In-Reply-To: <1000993862.146357.1553450267476.JavaMail.zimbra@u-pem.fr> References: <4C2B9CA4-72C9-4722-A515-AD69A0D651D5@oracle.com> <72058d37-b3a6-498a-02d0-5030ba588862@oracle.com> <1495942795.70480.1553362693669.JavaMail.zimbra@u-pem.fr> <63cd6df5-69a0-5eec-c401-612fd9132b08@oracle.com> <1000993862.146357.1553450267476.JavaMail.zimbra@u-pem.fr> Message-ID: <5C991D9E.3080006@oracle.com> On 3/24/2019 10:57 AM, forax at univ-mlv.fr wrote: > ----- Mail original ----- >> De: "Maurizio Cimadamore" >> ?: "Remi Forax" , "Brian Goetz" >> Cc: "amber-dev" >> Envoy?: Samedi 23 Mars 2019 22:27:47 >> Objet: Re: Call for feedback -- enhanced switch > >> On 23/03/2019 17:38, Remi Forax wrote: >>> And the expression switch is supported by the latest releases of both IntelliJ >>> IDEA and Eclipse [1] >>> >>> BTW, it remember me something i have forgotten to ask, for both ecj and javac, >>> when you compile with --enable-preview, all the classes have they minor version >>> changed even the one that doesn't use the switch expression. I've tried to find >>> where this behaviour was documented in the JEP 12 [2] but the "compile-time" >>> section is not clear about that. >> >> Remi, my initial implementation of JEP 12 was actually doing the finer >> grained treatment you described. > > I'm not sure which implementation is better, but anyway, at least the current behavior should be documented in the spec, > as you said, at least the semantics of the current implementation is clear. JEP 12 is not a spec for javac. JEP 12 is a policy document which, through its sections "Design of a Preview Feature", "Use of Preview Features", and "Relationship to Java SE APIs", lays groundwork for the Java SE Platform Spec. (See http://cr.openjdk.java.net/~iris/se/12/latestSpec/#Preview-features) Accordingly, JEP 12 mandates the smallest possible behavior for Java compilers and runtimes that is consistent with its policy goals. That's why it requires only: "If Java source code uses a preview language feature of Java SE $N, then a Java compiler must record that the emitted class file depends on the preview VM features of Java SE $N." and does not require the inverse, "If Java source code does not use a preview language feature, then a Java compiler must not record that the emitted class file depends on preview VM features." (For one thing, that inverse requirement, as written, would be inappropriate if a Java compiler started compiling an old language feature into a class file that genuinely uses a preview VM feature.) For convenience, JEP 12 has a section "Example use of preview features" which discusses how javac could enable preview features. That's not a spec, but to help readers, I have added this: "- Every `class` file emitted by `javac` _depends on the preview VM features of Java SE $N_, regardless of whether the source code corresponding to the `class` file actually uses preview language features of Java SE $N." Alex From vicente.romero at oracle.com Mon Mar 25 20:38:20 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Mon, 25 Mar 2019 16:38:20 -0400 Subject: how reliable JMH's results are In-Reply-To: <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> Message-ID: <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> Hi Maurizio, I have made another run of V7 and V9 and compared them, please see [1]. This time I did 5 warm-up and 20 measurements iterations in order to obtain more data points and reduce the standard deviation. By eyeballing the results, it seemed to me that the reason for the difference came from the fact that while measurements for both intrinsified versions were pretty similar for the two experiments, there were a higher variability in the measurements for vanilla JDK13. Seeming to imply that vanilla JDK13 was more sensible to the changes in the benchmark than any of the intrinsified counterparts. To prove this I added several columns, named Normalized_Diff, to show the the difference between the two previous columns normalized to the (0, 1] interval. The closest to 1 the more similar are the values. The readings of these columns show that the biggest discrepancy is observed when the normalized difference is farthest from 1 for vanilla JDK13. Thanks, Vicente [1] http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v7_vs_v9/benchmarkResults_intrinsics_experiment_comparison_v7_vs_v9.html On 3/21/19 7:16 AM, Maurizio Cimadamore wrote: > Hi Vicente, > honestly I wouldn't call these differences 'wild'. Looking at the > first column, for the first bench you go from a minimum score of > 238982 to a max score of 270472. The difference between the two is > ~30000, which is around 15% of the measured value, which seems to be a > level of noise comparable with the margin of error. > > What I can't explain is the difference between these two tables: > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html > > > and > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html > > > The latter is markedly faster than the former - and not by a mere 12%, > sometimes by a 2x factor. Look at the Table 2: String - in the first > table it seems like we struggle to go past 1x (sometimes we're lower > even), in the second table we get 2x pretty much all over the place. I > think this is way beyond the level of variance you observed, and this > is something that should be investigated (perhaps with the help of > some JIT guru?). In general all the tables you have shared are more > similar to v9 than to v7 - but I'm worried because if the numbers in > v7 are to be taken seriously, the speedup shown there doesn't look > anything to write home about. > > Another (smaller) thing I fail to understand is how the mixed > String/int case seems to be sometimes faster than the separate String > or int case (or, in most case, close to the best speedup between the > two). Here, an important point is to notice that mixed StringInt #1 > has to be compared with the row #2 in the separate int/String > benchmarks (because the mixed bench takes two arguments). I would have > expected the mixed test to fall somewhat in between the int and String > results (since one is defo faster and the other seems mostly on par) - > but that doesn't seem to be the case. > > Maurizio > > On 20/03/2019 01:56, Vicente Romero wrote: >> Hi, >> >> Today at the amber meeting there was a debate about why some JMH's >> results vary between executions. Well first of all these are >> experiments and in all experiments, there is a certain degree of >> variability that can't be controlled. >> >> So I got the last version of our beloved IntrinsicsBenchmark class >> see [1] and made some changes to it, basically every field has been >> initialized with a different literal, as proposed by Maurizio. Then I >> took only the `int` oriented tests, the first 9 in the benchmark and >> executed then a number of times. All executions are done with vanilla >> JDK13 no intrinsics at play here! >> >> First I executed the tests 3 times with the same conditions: 3 >> warm-up iterations and 5 iterations for measurements. See the wild >> differences in the score and the error columns [2], mostly for the >> tests with the smallest number of arguments. I have no explanation >> for this. Then I started playing with both parameters warm-up and >> measurements iterations and executed another 4 experiments. As >> expected it seems like we should trust more those experiments >> executed with more iterations, both for warm-up and measurements, as >> the errors gets reduced. But still the variability is high and it's >> possible to find non-overlapping intervals for the results of the >> same experiment even when the error is small. See for example: >> Experiment 6 row: `IntrinsicsBenchmark.testHash0040Int` and the same >> row at Experiment 7. So should we interpret these numbers >> qualitatively too? Are we running the right amount of experiments >> with the right parameters? I have more questions than answers :) >> >> Thanks for listening, >> Vicente >> >> PS, OK reading >> >> [1] >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java >> [2] >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html From maurizio.cimadamore at oracle.com Mon Mar 25 21:40:08 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Mon, 25 Mar 2019 21:40:08 +0000 Subject: how reliable JMH's results are In-Reply-To: <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> Message-ID: <0bed4002-f390-917d-64bf-a8728d00cc8d@oracle.com> Yep - they do look similar, so it is likely that between your previous v7 and v9 measurements some other environmental factor (e.g. a VM change?) was the likely culprit for the differences. Maurizio On 25/03/2019 20:38, Vicente Romero wrote: > Hi Maurizio, > > I have made another run of V7 and V9 and compared them, please see > [1]. This time I did 5 warm-up and 20 measurements iterations in order > to obtain more data points and reduce the standard deviation. By > eyeballing the results, it seemed to me that the reason for the > difference came from the fact that while measurements for both > intrinsified versions were pretty similar for the two experiments, > there were a higher variability in the measurements for vanilla JDK13. > Seeming to imply that vanilla JDK13 was more sensible to the changes > in the benchmark than any of the intrinsified counterparts. To prove > this I added several columns, named Normalized_Diff, to show the the > difference between the two previous columns normalized to the (0, 1] > interval. The closest to 1 the more similar are the values. The > readings of these columns show that the biggest discrepancy is > observed when the normalized difference is farthest from 1 for vanilla > JDK13. > > Thanks, > Vicente > > [1] > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v7_vs_v9/benchmarkResults_intrinsics_experiment_comparison_v7_vs_v9.html > > On 3/21/19 7:16 AM, Maurizio Cimadamore wrote: >> Hi Vicente, >> honestly I wouldn't call these differences 'wild'. Looking at the >> first column, for the first bench you go from a minimum score of >> 238982 to a max score of 270472. The difference between the two is >> ~30000, which is around 15% of the measured value, which seems to be >> a level of noise comparable with the margin of error. >> >> What I can't explain is the difference between these two tables: >> >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html >> >> >> and >> >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html >> >> >> The latter is markedly faster than the former - and not by a mere >> 12%, sometimes by a 2x factor. Look at the Table 2: String - in the >> first table it seems like we struggle to go past 1x (sometimes we're >> lower even), in the second table we get 2x pretty much all over the >> place. I think this is way beyond the level of variance you observed, >> and this is something that should be investigated (perhaps with the >> help of some JIT guru?). In general all the tables you have shared >> are more similar to v9 than to v7 - but I'm worried because if the >> numbers in v7 are to be taken seriously, the speedup shown there >> doesn't look anything to write home about. >> >> Another (smaller) thing I fail to understand is how the mixed >> String/int case seems to be sometimes faster than the separate String >> or int case (or, in most case, close to the best speedup between the >> two). Here, an important point is to notice that mixed StringInt #1 >> has to be compared with the row #2 in the separate int/String >> benchmarks (because the mixed bench takes two arguments). I would >> have expected the mixed test to fall somewhat in between the int and >> String results (since one is defo faster and the other seems mostly >> on par) - but that doesn't seem to be the case. >> >> Maurizio >> >> On 20/03/2019 01:56, Vicente Romero wrote: >>> Hi, >>> >>> Today at the amber meeting there was a debate about why some JMH's >>> results vary between executions. Well first of all these are >>> experiments and in all experiments, there is a certain degree of >>> variability that can't be controlled. >>> >>> So I got the last version of our beloved IntrinsicsBenchmark class >>> see [1] and made some changes to it, basically every field has been >>> initialized with a different literal, as proposed by Maurizio. Then >>> I took only the `int` oriented tests, the first 9 in the benchmark >>> and executed then a number of times. All executions are done with >>> vanilla JDK13 no intrinsics at play here! >>> >>> First I executed the tests 3 times with the same conditions: 3 >>> warm-up iterations and 5 iterations for measurements. See the wild >>> differences in the score and the error columns [2], mostly for the >>> tests with the smallest number of arguments. I have no explanation >>> for this. Then I started playing with both parameters warm-up and >>> measurements iterations and executed another 4 experiments. As >>> expected it seems like we should trust more those experiments >>> executed with more iterations, both for warm-up and measurements, as >>> the errors gets reduced. But still the variability is high and it's >>> possible to find non-overlapping intervals for the results of the >>> same experiment even when the error is small. See for example: >>> Experiment 6 row: `IntrinsicsBenchmark.testHash0040Int` and the same >>> row at Experiment 7. So should we interpret these numbers >>> qualitatively too? Are we running the right amount of experiments >>> with the right parameters? I have more questions than answers :) >>> >>> Thanks for listening, >>> Vicente >>> >>> PS, OK reading >>> >>> [1] >>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java >>> [2] >>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html > From vicente.romero at oracle.com Mon Mar 25 22:08:23 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Mon, 25 Mar 2019 18:08:23 -0400 Subject: how reliable JMH's results are In-Reply-To: <0bed4002-f390-917d-64bf-a8728d00cc8d@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> <0bed4002-f390-917d-64bf-a8728d00cc8d@oracle.com> Message-ID: On 3/25/19 5:40 PM, Maurizio Cimadamore wrote: > Yep - they do look similar, so it is likely that between your previous > v7 and v9 measurements some other environmental factor (e.g. a VM > change?) was the likely culprit for the differences. nope, I have been using the same builds all the time since then. The only difference between now and before is that now I got more data so the results are more reliable > > Maurizio Vicente > > On 25/03/2019 20:38, Vicente Romero wrote: >> Hi Maurizio, >> >> I have made another run of V7 and V9 and compared them, please see >> [1]. This time I did 5 warm-up and 20 measurements iterations in >> order to obtain more data points and reduce the standard deviation. >> By eyeballing the results, it seemed to me that the reason for the >> difference came from the fact that while measurements for both >> intrinsified versions were pretty similar for the two experiments, >> there were a higher variability in the measurements for vanilla >> JDK13. Seeming to imply that vanilla JDK13 was more sensible to the >> changes in the benchmark than any of the intrinsified counterparts. >> To prove this I added several columns, named Normalized_Diff, to show >> the the difference between the two previous columns normalized to the >> (0, 1] interval. The closest to 1 the more similar are the values. >> The readings of these columns show that the biggest discrepancy is >> observed when the normalized difference is farthest from 1 for >> vanilla JDK13. >> >> Thanks, >> Vicente >> >> [1] >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v7_vs_v9/benchmarkResults_intrinsics_experiment_comparison_v7_vs_v9.html >> >> On 3/21/19 7:16 AM, Maurizio Cimadamore wrote: >>> Hi Vicente, >>> honestly I wouldn't call these differences 'wild'. Looking at the >>> first column, for the first bench you go from a minimum score of >>> 238982 to a max score of 270472. The difference between the two is >>> ~30000, which is around 15% of the measured value, which seems to be >>> a level of noise comparable with the margin of error. >>> >>> What I can't explain is the difference between these two tables: >>> >>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html >>> >>> >>> and >>> >>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html >>> >>> >>> The latter is markedly faster than the former - and not by a mere >>> 12%, sometimes by a 2x factor. Look at the Table 2: String - in the >>> first table it seems like we struggle to go past 1x (sometimes we're >>> lower even), in the second table we get 2x pretty much all over the >>> place. I think this is way beyond the level of variance you >>> observed, and this is something that should be investigated (perhaps >>> with the help of some JIT guru?). In general all the tables you have >>> shared are more similar to v9 than to v7 - but I'm worried because >>> if the numbers in v7 are to be taken seriously, the speedup shown >>> there doesn't look anything to write home about. >>> >>> Another (smaller) thing I fail to understand is how the mixed >>> String/int case seems to be sometimes faster than the separate >>> String or int case (or, in most case, close to the best speedup >>> between the two). Here, an important point is to notice that mixed >>> StringInt #1 has to be compared with the row #2 in the separate >>> int/String benchmarks (because the mixed bench takes two arguments). >>> I would have expected the mixed test to fall somewhat in between the >>> int and String results (since one is defo faster and the other seems >>> mostly on par) - but that doesn't seem to be the case. >>> >>> Maurizio >>> >>> On 20/03/2019 01:56, Vicente Romero wrote: >>>> Hi, >>>> >>>> Today at the amber meeting there was a debate about why some JMH's >>>> results vary between executions. Well first of all these are >>>> experiments and in all experiments, there is a certain degree of >>>> variability that can't be controlled. >>>> >>>> So I got the last version of our beloved IntrinsicsBenchmark class >>>> see [1] and made some changes to it, basically every field has been >>>> initialized with a different literal, as proposed by Maurizio. Then >>>> I took only the `int` oriented tests, the first 9 in the benchmark >>>> and executed then a number of times. All executions are done with >>>> vanilla JDK13 no intrinsics at play here! >>>> >>>> First I executed the tests 3 times with the same conditions: 3 >>>> warm-up iterations and 5 iterations for measurements. See the wild >>>> differences in the score and the error columns [2], mostly for the >>>> tests with the smallest number of arguments. I have no explanation >>>> for this. Then I started playing with both parameters warm-up and >>>> measurements iterations and executed another 4 experiments. As >>>> expected it seems like we should trust more those experiments >>>> executed with more iterations, both for warm-up and measurements, >>>> as the errors gets reduced. But still the variability is high and >>>> it's possible to find non-overlapping intervals for the results of >>>> the same experiment even when the error is small. See for example: >>>> Experiment 6 row: `IntrinsicsBenchmark.testHash0040Int` and the >>>> same row at Experiment 7. So should we interpret these numbers >>>> qualitatively too? Are we running the right amount of experiments >>>> with the right parameters? I have more questions than answers :) >>>> >>>> Thanks for listening, >>>> Vicente >>>> >>>> PS, OK reading >>>> >>>> [1] >>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java >>>> [2] >>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html >> From vicente.romero at oracle.com Mon Mar 25 22:06:25 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Mon, 25 Mar 2019 18:06:25 -0400 Subject: String::format benchmark results Message-ID: Hi all, It seems like I overwrote the benchmark for String::format, thanks Alex, please check the results at [1] Thanks, Vicente [1] http://cr.openjdk.java.net/~vromero/string_format_benchmark_results/v1/benchmarkResults_intrinsics_string_format_v1.html From shade at redhat.com Mon Mar 25 23:54:54 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 26 Mar 2019 00:54:54 +0100 Subject: how reliable JMH's results are In-Reply-To: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> Message-ID: <3c657bab-6bbe-2697-0ca9-454fd0f7c313@redhat.com> On 3/20/19 2:56 AM, Vicente Romero wrote: > Today at the amber meeting there was a debate about why some JMH's results vary between executions. > Well first of all these are experiments and in all experiments, there is a certain degree of > variability that can't be controlled. I said this before, and I feel it needs to be said again: what you have in your tables is *data*, not *results*. The distinction is important: data becomes results when you analyze (explain) why the data is the way it is. One of the ways is to use the profilers to figure out the reason for performance difference, both positive and negative. It is usually pointless to stare and numbers and wonder. It is much, much more effective to dissect the benchmark while is is running. If you are fighting the variance, it is important to understand the source of it. You don't need to run hundreds of iterations for minutes and look at summaries, it is more important to see how the timings differs from iteration to iteration. For example, take IntrinsicsBenchmark.testHash0002Integer, run it with "-w 1s -r 1s": # JMH version: 1.21 # VM version: JDK 13-internal, OpenJDK 64-Bit Server VM, 13-internal+0-adhoc.shade.jdk-jdk # VM invoker: /home/shade/trunks/jdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java # VM options: # Warmup: 10 iterations, 1 s each # Measurement: 20 iterations, 1 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Throughput, ops/time # Benchmark: org.openjdk.IntrinsicsBenchmark.testHash0002Integer # Run progress: 0.00% complete, ETA 00:00:30 # Fork: 1 of 1 # Warmup Iteration 1: 57204.334 ops/ms # Warmup Iteration 2: 103416.259 ops/ms # Warmup Iteration 3: 162178.931 ops/ms # Warmup Iteration 4: 162476.308 ops/ms # Warmup Iteration 5: 144305.570 ops/ms # Warmup Iteration 6: 161836.788 ops/ms # Warmup Iteration 7: 169351.425 ops/ms # Warmup Iteration 8: 164579.568 ops/ms # Warmup Iteration 9: 164465.457 ops/ms # Warmup Iteration 10: 164625.845 ops/ms Iteration 1: 164322.220 ops/ms Iteration 2: 170006.896 ops/ms Iteration 3: 164746.236 ops/ms Iteration 4: 170108.658 ops/ms Iteration 5: 164642.814 ops/ms Iteration 6: 164799.820 ops/ms Iteration 7: 170020.497 ops/ms Iteration 8: 170213.564 ops/ms Iteration 9: 164649.448 ops/ms Iteration 10: 164413.162 ops/ms Iteration 11: 160188.524 ops/ms Iteration 12: 164399.563 ops/ms Iteration 13: 170135.645 ops/ms Iteration 14: 164643.840 ops/ms Iteration 15: 170198.652 ops/ms Iteration 16: 170071.623 ops/ms Iteration 17: 170608.835 ops/ms Iteration 18: 164249.869 ops/ms Iteration 19: 164742.289 ops/ms Iteration 20: 170289.832 ops/ms Result "org.openjdk.IntrinsicsBenchmark.testHash0002Integer": 166872.599 ?(99.9%) 2799.021 ops/ms [Average] (min, avg, max) = (160188.524, 166872.599, 170608.835), stdev = 3223.356 CI (99.9%): [164073.579, 169671.620] (assumes normal distribution) I spy with my little eye the bimodal result: either it is 170 Kops/ms, or 164 Kops/ms. The "dips" in iteration performance is quite often a GC. Okay, -prof gc then! It shows 1.3 GB/sec allocation rate. Of course it is GC, for every reasonable heap size. We can go two ways from here: either make longer iterations (which is tedious [*]), or we can tune down the heap to force more GC cycles in every iterations, thus leveling out it dips. ([*] Philosophically, longer benchmarks are much worse, because they force you to stare at numbers you've got from a day-long experiment, instead of doing tens and hundreds of much shorter experiments, as you adjust, adjust, adjust the experimental setup.) Okay, add --jvmArgs "-Xmx128m": # JMH version: 1.21 # VM version: JDK 13-internal, OpenJDK 64-Bit Server VM, 13-internal+0-adhoc.shade.jdk-jdk # VM invoker: /home/shade/trunks/jdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java # VM options: -Xmx128m # Warmup: 10 iterations, 1 s each # Measurement: 20 iterations, 1 s each # Timeout: 10 min per iteration # Threads: 1 thread, will synchronize iterations # Benchmark mode: Throughput, ops/time # Benchmark: org.openjdk.IntrinsicsBenchmark.testHash0002Integer # Run progress: 0.00% complete, ETA 00:00:30 # Fork: 1 of 1 # Warmup Iteration 1: 90518.942 ops/ms # Warmup Iteration 2: 102680.621 ops/ms # Warmup Iteration 3: 167249.769 ops/ms # Warmup Iteration 4: 167161.628 ops/ms # Warmup Iteration 5: 167234.602 ops/ms # Warmup Iteration 6: 167525.645 ops/ms # Warmup Iteration 7: 164963.326 ops/ms # Warmup Iteration 8: 165397.347 ops/ms # Warmup Iteration 9: 166592.091 ops/ms # Warmup Iteration 10: 167274.903 ops/ms Iteration 1: 167933.613 ops/ms Iteration 2: 167545.883 ops/ms Iteration 3: 167058.631 ops/ms Iteration 4: 167141.522 ops/ms Iteration 5: 166703.878 ops/ms Iteration 6: 166629.714 ops/ms Iteration 7: 167044.802 ops/ms Iteration 8: 167431.836 ops/ms Iteration 9: 167460.619 ops/ms Iteration 10: 167366.268 ops/ms Iteration 11: 167417.515 ops/ms Iteration 12: 167343.442 ops/ms Iteration 13: 167304.245 ops/ms Iteration 14: 167340.101 ops/ms Iteration 15: 167215.482 ops/ms Iteration 16: 166505.524 ops/ms Iteration 17: 165027.276 ops/ms Iteration 18: 165409.731 ops/ms Iteration 19: 165752.616 ops/ms Iteration 20: 167030.566 ops/ms Result "org.openjdk.IntrinsicsBenchmark.testHash0002Integer": 166933.163 ?(99.9%) 649.583 ops/ms [Average] (min, avg, max) = (165027.276, 166933.163, 167933.613), stdev = 748.061 CI (99.9%): [166283.580, 167582.746] (assumes normal distribution) Voila. The mean error was 1.6% in the first run (already quite low), and now it is 0.4%. But this is only single-invocation performance. There could be run-to-run variance lurking. So, we need multiple forks and see what is up there. Adding "-f 5" gives me more iterations: ... Result "org.openjdk.IntrinsicsBenchmark.testHash0002Integer": 166341.783 ?(99.9%) 352.441 ops/ms [Average] (min, avg, max) = (161452.661, 166341.783, 168084.315), stdev = 1039.180 CI (99.9%): [165989.342, 166694.223] (assumes normal distribution) ...and the mean error is even lower, at 0.2%. This is, of course, on the system that is prepared for benchmarking: properly cooled, power management quirks mitigated, process exclusivity either achieved by isolation or checked by monitoring, etc. The real fun part comes when we try to attach profiler to jdk13 build. For example, -prof perfasm. Then, the performance on jdk13 dips to 80 Kops/sec! WTF. jdk12 is fine, though. Notice anything strange in jdk13 profile? http://cr.openjdk.java.net/~shade/amber/intr-bench-jdk12.perfasm http://cr.openjdk.java.net/~shade/amber/intr-bench-jdk13.perfasm I see java.lang.Integer::hashCode is not inlined. What's worse, it looks like the method prolog before Verified Entry Point is hot, which is very weird. (The joys of bleeding edge JVMs, huh!) Bisecting shows it started with JDK-6996807, which curiously takes Arrays.hashCode(sigs), and maybe it pollutes profile enough for VM to break bad: http://hg.openjdk.java.net/jdk/jdk/rev/b561ea19a7b9 Anyway, it seems you need to see what's in there in perfasm/perfnorm in different tests. In intr-bench-jdk12.perfasm above, the cost is clearly in varargs creation of Object[]. Intrinsics have to demonstrate that allocation is gone and generated code is as efficient as it reasonably gets. -Aleksey From vicente.romero at oracle.com Tue Mar 26 01:21:36 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Mon, 25 Mar 2019 21:21:36 -0400 Subject: how reliable JMH's results are In-Reply-To: <3c657bab-6bbe-2697-0ca9-454fd0f7c313@redhat.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <3c657bab-6bbe-2697-0ca9-454fd0f7c313@redhat.com> Message-ID: thanks Aleksey, very interesting, Vicente On 3/25/19 7:54 PM, Aleksey Shipilev wrote: > On 3/20/19 2:56 AM, Vicente Romero wrote: >> Today at the amber meeting there was a debate about why some JMH's results vary between executions. >> Well first of all these are experiments and in all experiments, there is a certain degree of >> variability that can't be controlled. > I said this before, and I feel it needs to be said again: what you have in your tables is *data*, > not *results*. The distinction is important: data becomes results when you analyze (explain) why the > data is the way it is. One of the ways is to use the profilers to figure out the reason for > performance difference, both positive and negative. It is usually pointless to stare and numbers and > wonder. It is much, much more effective to dissect the benchmark while is is running. > > If you are fighting the variance, it is important to understand the source of it. You don't need to > run hundreds of iterations for minutes and look at summaries, it is more important to see how the > timings differs from iteration to iteration. > > For example, take IntrinsicsBenchmark.testHash0002Integer, run it with "-w 1s -r 1s": > > # JMH version: 1.21 > # VM version: JDK 13-internal, OpenJDK 64-Bit Server VM, 13-internal+0-adhoc.shade.jdk-jdk > # VM invoker: /home/shade/trunks/jdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java > # VM options: > # Warmup: 10 iterations, 1 s each > # Measurement: 20 iterations, 1 s each > # Timeout: 10 min per iteration > # Threads: 1 thread, will synchronize iterations > # Benchmark mode: Throughput, ops/time > # Benchmark: org.openjdk.IntrinsicsBenchmark.testHash0002Integer > > # Run progress: 0.00% complete, ETA 00:00:30 > # Fork: 1 of 1 > # Warmup Iteration 1: 57204.334 ops/ms > # Warmup Iteration 2: 103416.259 ops/ms > # Warmup Iteration 3: 162178.931 ops/ms > # Warmup Iteration 4: 162476.308 ops/ms > # Warmup Iteration 5: 144305.570 ops/ms > # Warmup Iteration 6: 161836.788 ops/ms > # Warmup Iteration 7: 169351.425 ops/ms > # Warmup Iteration 8: 164579.568 ops/ms > # Warmup Iteration 9: 164465.457 ops/ms > # Warmup Iteration 10: 164625.845 ops/ms > Iteration 1: 164322.220 ops/ms > Iteration 2: 170006.896 ops/ms > Iteration 3: 164746.236 ops/ms > Iteration 4: 170108.658 ops/ms > Iteration 5: 164642.814 ops/ms > Iteration 6: 164799.820 ops/ms > Iteration 7: 170020.497 ops/ms > Iteration 8: 170213.564 ops/ms > Iteration 9: 164649.448 ops/ms > Iteration 10: 164413.162 ops/ms > Iteration 11: 160188.524 ops/ms > Iteration 12: 164399.563 ops/ms > Iteration 13: 170135.645 ops/ms > Iteration 14: 164643.840 ops/ms > Iteration 15: 170198.652 ops/ms > Iteration 16: 170071.623 ops/ms > Iteration 17: 170608.835 ops/ms > Iteration 18: 164249.869 ops/ms > Iteration 19: 164742.289 ops/ms > Iteration 20: 170289.832 ops/ms > > Result "org.openjdk.IntrinsicsBenchmark.testHash0002Integer": > 166872.599 ?(99.9%) 2799.021 ops/ms [Average] > (min, avg, max) = (160188.524, 166872.599, 170608.835), stdev = 3223.356 > CI (99.9%): [164073.579, 169671.620] (assumes normal distribution) > > I spy with my little eye the bimodal result: either it is 170 Kops/ms, or 164 Kops/ms. The "dips" in > iteration performance is quite often a GC. Okay, -prof gc then! It shows 1.3 GB/sec allocation rate. > Of course it is GC, for every reasonable heap size. We can go two ways from here: either make longer > iterations (which is tedious [*]), or we can tune down the heap to force more GC cycles in every > iterations, thus leveling out it dips. > > ([*] Philosophically, longer benchmarks are much worse, because they force you to stare at numbers > you've got from a day-long experiment, instead of doing tens and hundreds of much shorter > experiments, as you adjust, adjust, adjust the experimental setup.) > > Okay, add --jvmArgs "-Xmx128m": > > # JMH version: 1.21 > # VM version: JDK 13-internal, OpenJDK 64-Bit Server VM, 13-internal+0-adhoc.shade.jdk-jdk > # VM invoker: /home/shade/trunks/jdk-jdk/build/linux-x86_64-server-release/images/jdk/bin/java > # VM options: -Xmx128m > # Warmup: 10 iterations, 1 s each > # Measurement: 20 iterations, 1 s each > # Timeout: 10 min per iteration > # Threads: 1 thread, will synchronize iterations > # Benchmark mode: Throughput, ops/time > # Benchmark: org.openjdk.IntrinsicsBenchmark.testHash0002Integer > > # Run progress: 0.00% complete, ETA 00:00:30 > # Fork: 1 of 1 > # Warmup Iteration 1: 90518.942 ops/ms > # Warmup Iteration 2: 102680.621 ops/ms > # Warmup Iteration 3: 167249.769 ops/ms > # Warmup Iteration 4: 167161.628 ops/ms > # Warmup Iteration 5: 167234.602 ops/ms > # Warmup Iteration 6: 167525.645 ops/ms > # Warmup Iteration 7: 164963.326 ops/ms > # Warmup Iteration 8: 165397.347 ops/ms > # Warmup Iteration 9: 166592.091 ops/ms > # Warmup Iteration 10: 167274.903 ops/ms > Iteration 1: 167933.613 ops/ms > Iteration 2: 167545.883 ops/ms > Iteration 3: 167058.631 ops/ms > Iteration 4: 167141.522 ops/ms > Iteration 5: 166703.878 ops/ms > Iteration 6: 166629.714 ops/ms > Iteration 7: 167044.802 ops/ms > Iteration 8: 167431.836 ops/ms > Iteration 9: 167460.619 ops/ms > Iteration 10: 167366.268 ops/ms > Iteration 11: 167417.515 ops/ms > Iteration 12: 167343.442 ops/ms > Iteration 13: 167304.245 ops/ms > Iteration 14: 167340.101 ops/ms > Iteration 15: 167215.482 ops/ms > Iteration 16: 166505.524 ops/ms > Iteration 17: 165027.276 ops/ms > Iteration 18: 165409.731 ops/ms > Iteration 19: 165752.616 ops/ms > Iteration 20: 167030.566 ops/ms > > Result "org.openjdk.IntrinsicsBenchmark.testHash0002Integer": > 166933.163 ?(99.9%) 649.583 ops/ms [Average] > (min, avg, max) = (165027.276, 166933.163, 167933.613), stdev = 748.061 > CI (99.9%): [166283.580, 167582.746] (assumes normal distribution) > > > Voila. The mean error was 1.6% in the first run (already quite low), and now it is 0.4%. > > But this is only single-invocation performance. There could be run-to-run variance lurking. So, we > need multiple forks and see what is up there. Adding "-f 5" gives me more iterations: > > ... > > Result "org.openjdk.IntrinsicsBenchmark.testHash0002Integer": > 166341.783 ?(99.9%) 352.441 ops/ms [Average] > (min, avg, max) = (161452.661, 166341.783, 168084.315), stdev = 1039.180 > CI (99.9%): [165989.342, 166694.223] (assumes normal distribution) > > ...and the mean error is even lower, at 0.2%. > > This is, of course, on the system that is prepared for benchmarking: properly cooled, power > management quirks mitigated, process exclusivity either achieved by isolation or checked by > monitoring, etc. > > The real fun part comes when we try to attach profiler to jdk13 build. For example, -prof perfasm. > Then, the performance on jdk13 dips to 80 Kops/sec! WTF. jdk12 is fine, though. Notice anything > strange in jdk13 profile? > http://cr.openjdk.java.net/~shade/amber/intr-bench-jdk12.perfasm > http://cr.openjdk.java.net/~shade/amber/intr-bench-jdk13.perfasm > > I see java.lang.Integer::hashCode is not inlined. What's worse, it looks like the method prolog > before Verified Entry Point is hot, which is very weird. (The joys of bleeding edge JVMs, huh!) > Bisecting shows it started with JDK-6996807, which curiously takes Arrays.hashCode(sigs), and maybe > it pollutes profile enough for VM to break bad: > http://hg.openjdk.java.net/jdk/jdk/rev/b561ea19a7b9 > > Anyway, it seems you need to see what's in there in perfasm/perfnorm in different tests. In > intr-bench-jdk12.perfasm above, the cost is clearly in varargs creation of Object[]. Intrinsics have > to demonstrate that allocation is gone and generated code is as efficient as it reasonably gets. > > -Aleksey > From maurizio.cimadamore at oracle.com Tue Mar 26 10:52:04 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 26 Mar 2019 10:52:04 +0000 Subject: how reliable JMH's results are In-Reply-To: References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> <0bed4002-f390-917d-64bf-a8728d00cc8d@oracle.com> Message-ID: <663b84e3-5ecc-84f8-582f-0718f870b99b@oracle.com> Ok. That rules out a factor. But I guess I'm not 100% convinced that it's down to variance. Look again at http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v7.html vs. http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html What I find disturbing, specifically, is lines like these (mixed int and String, raw #1):Intrinsified score v7: 131417 Intrinsified (folding) score v9: 216897 This same result is essentially 2x in v9 than it was in v7. First of all: * am I right in comparing 'intrinsified' column in v7 with 'intrinsified folding' column in v9 ? * while statistical noise is always a factor, a consistent 2x factor across all raws doesn't look like variance The results in your latest bench are in line with v9 - that is, the 'intrinsified folding' seems around 2x faster than in v7. Which leaves to me one explanation (excluding environmental factors such as CPU throttling and the likes): has the JDK intrinsified build changed from v7 to v9? That is, is this an apple to apple comparison, or have some changes been made to the bootstrap methods too, which ended up speeding up the bench? Maurizio On 25/03/2019 22:08, Vicente Romero wrote: > > > On 3/25/19 5:40 PM, Maurizio Cimadamore wrote: >> Yep - they do look similar, so it is likely that between your >> previous v7 and v9 measurements some other environmental factor (e.g. >> a VM change?) was the likely culprit for the differences. > > nope, I have been using the same builds all the time since then. The > only difference between now and before is that now I got more data so > the results are more reliable > >> >> Maurizio > > Vicente > >> >> On 25/03/2019 20:38, Vicente Romero wrote: >>> Hi Maurizio, >>> >>> I have made another run of V7 and V9 and compared them, please see >>> [1]. This time I did 5 warm-up and 20 measurements iterations in >>> order to obtain more data points and reduce the standard deviation. >>> By eyeballing the results, it seemed to me that the reason for the >>> difference came from the fact that while measurements for both >>> intrinsified versions were pretty similar for the two experiments, >>> there were a higher variability in the measurements for vanilla >>> JDK13. Seeming to imply that vanilla JDK13 was more sensible to the >>> changes in the benchmark than any of the intrinsified counterparts. >>> To prove this I added several columns, named Normalized_Diff, to >>> show the the difference between the two previous columns normalized >>> to the (0, 1] interval. The closest to 1 the more similar are the >>> values. The readings of these columns show that the biggest >>> discrepancy is observed when the normalized difference is farthest >>> from 1 for vanilla JDK13. >>> >>> Thanks, >>> Vicente >>> >>> [1] >>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v7_vs_v9/benchmarkResults_intrinsics_experiment_comparison_v7_vs_v9.html >>> >>> On 3/21/19 7:16 AM, Maurizio Cimadamore wrote: >>>> Hi Vicente, >>>> honestly I wouldn't call these differences 'wild'. Looking at the >>>> first column, for the first bench you go from a minimum score of >>>> 238982 to a max score of 270472. The difference between the two is >>>> ~30000, which is around 15% of the measured value, which seems to >>>> be a level of noise comparable with the margin of error. >>>> >>>> What I can't explain is the difference between these two tables: >>>> >>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html >>>> >>>> >>>> and >>>> >>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html >>>> >>>> >>>> The latter is markedly faster than the former - and not by a mere >>>> 12%, sometimes by a 2x factor. Look at the Table 2: String - in the >>>> first table it seems like we struggle to go past 1x (sometimes >>>> we're lower even), in the second table we get 2x pretty much all >>>> over the place. I think this is way beyond the level of variance >>>> you observed, and this is something that should be investigated >>>> (perhaps with the help of some JIT guru?). In general all the >>>> tables you have shared are more similar to v9 than to v7 - but I'm >>>> worried because if the numbers in v7 are to be taken seriously, the >>>> speedup shown there doesn't look anything to write home about. >>>> >>>> Another (smaller) thing I fail to understand is how the mixed >>>> String/int case seems to be sometimes faster than the separate >>>> String or int case (or, in most case, close to the best speedup >>>> between the two). Here, an important point is to notice that mixed >>>> StringInt #1 has to be compared with the row #2 in the separate >>>> int/String benchmarks (because the mixed bench takes two >>>> arguments). I would have expected the mixed test to fall somewhat >>>> in between the int and String results (since one is defo faster and >>>> the other seems mostly on par) - but that doesn't seem to be the case. >>>> >>>> Maurizio >>>> >>>> On 20/03/2019 01:56, Vicente Romero wrote: >>>>> Hi, >>>>> >>>>> Today at the amber meeting there was a debate about why some JMH's >>>>> results vary between executions. Well first of all these are >>>>> experiments and in all experiments, there is a certain degree of >>>>> variability that can't be controlled. >>>>> >>>>> So I got the last version of our beloved IntrinsicsBenchmark class >>>>> see [1] and made some changes to it, basically every field has >>>>> been initialized with a different literal, as proposed by >>>>> Maurizio. Then I took only the `int` oriented tests, the first 9 >>>>> in the benchmark and executed then a number of times. All >>>>> executions are done with vanilla JDK13 no intrinsics at play here! >>>>> >>>>> First I executed the tests 3 times with the same conditions: 3 >>>>> warm-up iterations and 5 iterations for measurements. See the wild >>>>> differences in the score and the error columns [2], mostly for the >>>>> tests with the smallest number of arguments. I have no explanation >>>>> for this. Then I started playing with both parameters warm-up and >>>>> measurements iterations and executed another 4 experiments. As >>>>> expected it seems like we should trust more those experiments >>>>> executed with more iterations, both for warm-up and measurements, >>>>> as the errors gets reduced. But still the variability is high and >>>>> it's possible to find non-overlapping intervals for the results of >>>>> the same experiment even when the error is small. See for example: >>>>> Experiment 6 row: `IntrinsicsBenchmark.testHash0040Int` and the >>>>> same row at Experiment 7. So should we interpret these numbers >>>>> qualitatively too? Are we running the right amount of experiments >>>>> with the right parameters? I have more questions than answers :) >>>>> >>>>> Thanks for listening, >>>>> Vicente >>>>> >>>>> PS, OK reading >>>>> >>>>> [1] >>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java >>>>> [2] >>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html >>> > From maurizio.cimadamore at oracle.com Tue Mar 26 10:56:07 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 26 Mar 2019 10:56:07 +0000 Subject: how reliable JMH's results are In-Reply-To: <3c657bab-6bbe-2697-0ca9-454fd0f7c313@redhat.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <3c657bab-6bbe-2697-0ca9-454fd0f7c313@redhat.com> Message-ID: <4565c38b-8a52-ae3b-ee72-eae4c4f345ba@oracle.com> On 25/03/2019 23:54, Aleksey Shipilev wrote: > I spy with my little eye the bimodal result: either it is 170 Kops/ms, or 164 Kops/ms. The "dips" in > iteration performance is quite often a GC I agree that smaller differences can often be down to GC - I've seen bimodal behavior as well. But note my other email, where we basically have one jump from 131417 to 216897 - that's seem a bit extreme in terms of bimodal (at least I have never encountered such a stark one); and follow up experiments have never been able to replicate the 131Kop/s rate, which to me suggests it's something else (most likely changes/improvements to the BSM code itself). Maurizio From shade at redhat.com Tue Mar 26 11:18:37 2019 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 26 Mar 2019 12:18:37 +0100 Subject: how reliable JMH's results are In-Reply-To: <4565c38b-8a52-ae3b-ee72-eae4c4f345ba@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <3c657bab-6bbe-2697-0ca9-454fd0f7c313@redhat.com> <4565c38b-8a52-ae3b-ee72-eae4c4f345ba@oracle.com> Message-ID: On 3/26/19 11:56 AM, Maurizio Cimadamore wrote: > On 25/03/2019 23:54, Aleksey Shipilev wrote: >> I spy with my little eye the bimodal result: either it is 170 Kops/ms, or 164 Kops/ms. The "dips" in >> iteration performance is quite often a GC > > I agree that smaller differences can often be down to GC - I've seen bimodal behavior as well. But > note my other email, where we basically have one jump from 131417 to 216897 - that's seem a bit > extreme in terms of bimodal (at least I have never encountered such a stark one); and follow up > experiments have never been able to replicate the 131Kop/s rate, which to me suggests it's something > else (most likely changes/improvements to the BSM code itself). My point is that it is much more useful to profile and see why the difference is like that. Silly problems (e.g. experimental setup problems) are found in minutes usually. See, the GC behavior thing in my email: bimodal behavior; hypothesis it is GC; testing the hypothesis with GC profiler -- confirmed; testing the hypothesis that reducing heap size helps to alleviate -- confirmed; final variance is lower -- done, moving on. Do the similar thing for the jumps you observe in your setup. Benchmarking sessions are full of these little phases, each of which brings you a step closer to reliable benchmark with understandable results. -Aleksey From vicente.romero at oracle.com Tue Mar 26 12:38:56 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 26 Mar 2019 08:38:56 -0400 Subject: how reliable JMH's results are In-Reply-To: <663b84e3-5ecc-84f8-582f-0718f870b99b@oracle.com> References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> <0bed4002-f390-917d-64bf-a8728d00cc8d@oracle.com> <663b84e3-5ecc-84f8-582f-0718f870b99b@oracle.com> Message-ID: On 3/26/19 6:52 AM, Maurizio Cimadamore wrote: > Ok. That rules out a factor. > > But I guess I'm not 100% convinced that it's down to variance. Look > again at > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v7.html > > > vs. > > http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html > > > What I find disturbing, specifically, is lines like these (mixed int > and String, raw #1):Intrinsified score v7: 131417 > Intrinsified (folding) score v9: 216897 > > This same result is essentially 2x in v9 than it was in v7. First of all: > > * am I right in comparing 'intrinsified' column in v7 with > 'intrinsified folding' column in v9 ? the "Intrinsified" column in V7 corresponds to the "Intrinsified Filtering" column in V9, sorry about the name change, it could be confusing > * while statistical noise is always a factor, a consistent 2x factor > across all raws doesn't look like variance > > The results in your latest bench are in line with v9 - that is, the > 'intrinsified folding' seems around 2x faster than in v7. Which leaves > to me one explanation (excluding environmental factors such as CPU > throttling and the likes): has the JDK intrinsified build changed from > v7 to v9? That is, is this an apple to apple comparison, or have some > changes been made to the bootstrap methods too, which ended up > speeding up the bench? the only difference here is the benchmark, the builds used are exactly the same, and I think those original data you are referring to have a lot of noise, so I would trust more the table I published yesterday > > Maurizio Vicente > > > On 25/03/2019 22:08, Vicente Romero wrote: >> >> >> On 3/25/19 5:40 PM, Maurizio Cimadamore wrote: >>> Yep - they do look similar, so it is likely that between your >>> previous v7 and v9 measurements some other environmental factor >>> (e.g. a VM change?) was the likely culprit for the differences. >> >> nope, I have been using the same builds all the time since then. The >> only difference between now and before is that now I got more data so >> the results are more reliable >> >>> >>> Maurizio >> >> Vicente >> >>> >>> On 25/03/2019 20:38, Vicente Romero wrote: >>>> Hi Maurizio, >>>> >>>> I have made another run of V7 and V9 and compared them, please see >>>> [1]. This time I did 5 warm-up and 20 measurements iterations in >>>> order to obtain more data points and reduce the standard deviation. >>>> By eyeballing the results, it seemed to me that the reason for the >>>> difference came from the fact that while measurements for both >>>> intrinsified versions were pretty similar for the two experiments, >>>> there were a higher variability in the measurements for vanilla >>>> JDK13. Seeming to imply that vanilla JDK13 was more sensible to the >>>> changes in the benchmark than any of the intrinsified counterparts. >>>> To prove this I added several columns, named Normalized_Diff, to >>>> show the the difference between the two previous columns normalized >>>> to the (0, 1] interval. The closest to 1 the more similar are the >>>> values. The readings of these columns show that the biggest >>>> discrepancy is observed when the normalized difference is farthest >>>> from 1 for vanilla JDK13. >>>> >>>> Thanks, >>>> Vicente >>>> >>>> [1] >>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v7_vs_v9/benchmarkResults_intrinsics_experiment_comparison_v7_vs_v9.html >>>> >>>> On 3/21/19 7:16 AM, Maurizio Cimadamore wrote: >>>>> Hi Vicente, >>>>> honestly I wouldn't call these differences 'wild'. Looking at the >>>>> first column, for the first bench you go from a minimum score of >>>>> 238982 to a max score of 270472. The difference between the two is >>>>> ~30000, which is around 15% of the measured value, which seems to >>>>> be a level of noise comparable with the margin of error. >>>>> >>>>> What I can't explain is the difference between these two tables: >>>>> >>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html >>>>> >>>>> >>>>> and >>>>> >>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html >>>>> >>>>> >>>>> The latter is markedly faster than the former - and not by a mere >>>>> 12%, sometimes by a 2x factor. Look at the Table 2: String - in >>>>> the first table it seems like we struggle to go past 1x (sometimes >>>>> we're lower even), in the second table we get 2x pretty much all >>>>> over the place. I think this is way beyond the level of variance >>>>> you observed, and this is something that should be investigated >>>>> (perhaps with the help of some JIT guru?). In general all the >>>>> tables you have shared are more similar to v9 than to v7 - but I'm >>>>> worried because if the numbers in v7 are to be taken seriously, >>>>> the speedup shown there doesn't look anything to write home about. >>>>> >>>>> Another (smaller) thing I fail to understand is how the mixed >>>>> String/int case seems to be sometimes faster than the separate >>>>> String or int case (or, in most case, close to the best speedup >>>>> between the two). Here, an important point is to notice that mixed >>>>> StringInt #1 has to be compared with the row #2 in the separate >>>>> int/String benchmarks (because the mixed bench takes two >>>>> arguments). I would have expected the mixed test to fall somewhat >>>>> in between the int and String results (since one is defo faster >>>>> and the other seems mostly on par) - but that doesn't seem to be >>>>> the case. >>>>> >>>>> Maurizio >>>>> >>>>> On 20/03/2019 01:56, Vicente Romero wrote: >>>>>> Hi, >>>>>> >>>>>> Today at the amber meeting there was a debate about why some >>>>>> JMH's results vary between executions. Well first of all these >>>>>> are experiments and in all experiments, there is a certain degree >>>>>> of variability that can't be controlled. >>>>>> >>>>>> So I got the last version of our beloved IntrinsicsBenchmark >>>>>> class see [1] and made some changes to it, basically every field >>>>>> has been initialized with a different literal, as proposed by >>>>>> Maurizio. Then I took only the `int` oriented tests, the first 9 >>>>>> in the benchmark and executed then a number of times. All >>>>>> executions are done with vanilla JDK13 no intrinsics at play here! >>>>>> >>>>>> First I executed the tests 3 times with the same conditions: 3 >>>>>> warm-up iterations and 5 iterations for measurements. See the >>>>>> wild differences in the score and the error columns [2], mostly >>>>>> for the tests with the smallest number of arguments. I have no >>>>>> explanation for this. Then I started playing with both parameters >>>>>> warm-up and measurements iterations and executed another 4 >>>>>> experiments. As expected it seems like we should trust more those >>>>>> experiments executed with more iterations, both for warm-up and >>>>>> measurements, as the errors gets reduced. But still the >>>>>> variability is high and it's possible to find non-overlapping >>>>>> intervals for the results of the same experiment even when the >>>>>> error is small. See for example: Experiment 6 row: >>>>>> `IntrinsicsBenchmark.testHash0040Int` and the same row at >>>>>> Experiment 7. So should we interpret these numbers qualitatively >>>>>> too? Are we running the right amount of experiments with the >>>>>> right parameters? I have more questions than answers :) >>>>>> >>>>>> Thanks for listening, >>>>>> Vicente >>>>>> >>>>>> PS, OK reading >>>>>> >>>>>> [1] >>>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java >>>>>> [2] >>>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html >>>> >> From vicente.romero at oracle.com Tue Mar 26 13:09:26 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 26 Mar 2019 09:09:26 -0400 Subject: how reliable JMH's results are In-Reply-To: References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> <0bed4002-f390-917d-64bf-a8728d00cc8d@oracle.com> <663b84e3-5ecc-84f8-582f-0718f870b99b@oracle.com> Message-ID: <2e1a4040-6573-9cb8-abf7-7c78c31d4586@oracle.com> On 3/26/19 8:38 AM, Vicente Romero wrote: > > > On 3/26/19 6:52 AM, Maurizio Cimadamore wrote: >> Ok. That rules out a factor. >> >> But I guess I'm not 100% convinced that it's down to variance. Look >> again at >> >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v7.html >> >> >> vs. >> >> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html >> >> >> What I find disturbing, specifically, is lines like these (mixed int >> and String, raw #1):Intrinsified score v7: 131417 >> Intrinsified (folding) score v9: 216897 >> >> This same result is essentially 2x in v9 than it was in v7. First of >> all: >> >> * am I right in comparing 'intrinsified' column in v7 with >> 'intrinsified folding' column in v9 ? > the "Intrinsified" column in V7 corresponds to the "Intrinsified > Filtering" column in V9, sorry about the name change, it could be > confusing >> * while statistical noise is always a factor, a consistent 2x factor >> across all raws doesn't look like variance >> >> The results in your latest bench are in line with v9 - that is, the >> 'intrinsified folding' seems around 2x faster than in v7. Which >> leaves to me one explanation (excluding environmental factors such as >> CPU throttling and the likes): has the JDK intrinsified build changed >> from v7 to v9? That is, is this an apple to apple comparison, or have >> some changes been made to the bootstrap methods too, which ended up >> speeding up the bench? > > the only difference here is the benchmark, the builds used are exactly > the same, and I think those original data you are referring to have a > lot of noise, so I would trust more the table I published yesterday I mean the same build has been used to obtain the same comparable column in each table > >> >> Maurizio > > Vicente > >> >> >> On 25/03/2019 22:08, Vicente Romero wrote: >>> >>> >>> On 3/25/19 5:40 PM, Maurizio Cimadamore wrote: >>>> Yep - they do look similar, so it is likely that between your >>>> previous v7 and v9 measurements some other environmental factor >>>> (e.g. a VM change?) was the likely culprit for the differences. >>> >>> nope, I have been using the same builds all the time since then. The >>> only difference between now and before is that now I got more data >>> so the results are more reliable >>> >>>> >>>> Maurizio >>> >>> Vicente >>> >>>> >>>> On 25/03/2019 20:38, Vicente Romero wrote: >>>>> Hi Maurizio, >>>>> >>>>> I have made another run of V7 and V9 and compared them, please see >>>>> [1]. This time I did 5 warm-up and 20 measurements iterations in >>>>> order to obtain more data points and reduce the standard >>>>> deviation. By eyeballing the results, it seemed to me that the >>>>> reason for the difference came from the fact that while >>>>> measurements for both intrinsified versions were pretty similar >>>>> for the two experiments, there were a higher variability in the >>>>> measurements for vanilla JDK13. Seeming to imply that vanilla >>>>> JDK13 was more sensible to the changes in the benchmark than any >>>>> of the intrinsified counterparts. To prove this I added several >>>>> columns, named Normalized_Diff, to show the the difference between >>>>> the two previous columns normalized to the (0, 1] interval. The >>>>> closest to 1 the more similar are the values. The readings of >>>>> these columns show that the biggest discrepancy is observed when >>>>> the normalized difference is farthest from 1 for vanilla JDK13. >>>>> >>>>> Thanks, >>>>> Vicente >>>>> >>>>> [1] >>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v7_vs_v9/benchmarkResults_intrinsics_experiment_comparison_v7_vs_v9.html >>>>> >>>>> On 3/21/19 7:16 AM, Maurizio Cimadamore wrote: >>>>>> Hi Vicente, >>>>>> honestly I wouldn't call these differences 'wild'. Looking at the >>>>>> first column, for the first bench you go from a minimum score of >>>>>> 238982 to a max score of 270472. The difference between the two >>>>>> is ~30000, which is around 15% of the measured value, which seems >>>>>> to be a level of noise comparable with the margin of error. >>>>>> >>>>>> What I can't explain is the difference between these two tables: >>>>>> >>>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v7/benchmarkResults_intrinsics_all_data_v7.html >>>>>> >>>>>> >>>>>> and >>>>>> >>>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/v9/benchmarkResults_intrinsics_all_data_v9.html >>>>>> >>>>>> >>>>>> The latter is markedly faster than the former - and not by a mere >>>>>> 12%, sometimes by a 2x factor. Look at the Table 2: String - in >>>>>> the first table it seems like we struggle to go past 1x >>>>>> (sometimes we're lower even), in the second table we get 2x >>>>>> pretty much all over the place. I think this is way beyond the >>>>>> level of variance you observed, and this is something that should >>>>>> be investigated (perhaps with the help of some JIT guru?). In >>>>>> general all the tables you have shared are more similar to v9 >>>>>> than to v7 - but I'm worried because if the numbers in v7 are to >>>>>> be taken seriously, the speedup shown there doesn't look anything >>>>>> to write home about. >>>>>> >>>>>> Another (smaller) thing I fail to understand is how the mixed >>>>>> String/int case seems to be sometimes faster than the separate >>>>>> String or int case (or, in most case, close to the best speedup >>>>>> between the two). Here, an important point is to notice that >>>>>> mixed StringInt #1 has to be compared with the row #2 in the >>>>>> separate int/String benchmarks (because the mixed bench takes two >>>>>> arguments). I would have expected the mixed test to fall somewhat >>>>>> in between the int and String results (since one is defo faster >>>>>> and the other seems mostly on par) - but that doesn't seem to be >>>>>> the case. >>>>>> >>>>>> Maurizio >>>>>> >>>>>> On 20/03/2019 01:56, Vicente Romero wrote: >>>>>>> Hi, >>>>>>> >>>>>>> Today at the amber meeting there was a debate about why some >>>>>>> JMH's results vary between executions. Well first of all these >>>>>>> are experiments and in all experiments, there is a certain >>>>>>> degree of variability that can't be controlled. >>>>>>> >>>>>>> So I got the last version of our beloved IntrinsicsBenchmark >>>>>>> class see [1] and made some changes to it, basically every field >>>>>>> has been initialized with a different literal, as proposed by >>>>>>> Maurizio. Then I took only the `int` oriented tests, the first 9 >>>>>>> in the benchmark and executed then a number of times. All >>>>>>> executions are done with vanilla JDK13 no intrinsics at play here! >>>>>>> >>>>>>> First I executed the tests 3 times with the same conditions: 3 >>>>>>> warm-up iterations and 5 iterations for measurements. See the >>>>>>> wild differences in the score and the error columns [2], mostly >>>>>>> for the tests with the smallest number of arguments. I have no >>>>>>> explanation for this. Then I started playing with both >>>>>>> parameters warm-up and measurements iterations and executed >>>>>>> another 4 experiments. As expected it seems like we should trust >>>>>>> more those experiments executed with more iterations, both for >>>>>>> warm-up and measurements, as the errors gets reduced. But still >>>>>>> the variability is high and it's possible to find >>>>>>> non-overlapping intervals for the results of the same experiment >>>>>>> even when the error is small. See for example: Experiment 6 row: >>>>>>> `IntrinsicsBenchmark.testHash0040Int` and the same row at >>>>>>> Experiment 7. So should we interpret these numbers qualitatively >>>>>>> too? Are we running the right amount of experiments with the >>>>>>> right parameters? I have more questions than answers :) >>>>>>> >>>>>>> Thanks for listening, >>>>>>> Vicente >>>>>>> >>>>>>> PS, OK reading >>>>>>> >>>>>>> [1] >>>>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/IntrinsicsBenchmark.java >>>>>>> [2] >>>>>>> http://cr.openjdk.java.net/~vromero/intrinsics_benchmark_results/experiments/v1/benchmarkResults_intrinsics_experiments_v1.html >>>>> >>> > From maurizio.cimadamore at oracle.com Tue Mar 26 15:07:22 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 26 Mar 2019 15:07:22 +0000 Subject: how reliable JMH's results are In-Reply-To: References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> <0bed4002-f390-917d-64bf-a8728d00cc8d@oracle.com> <663b84e3-5ecc-84f8-582f-0718f870b99b@oracle.com> Message-ID: On 26/03/2019 12:38, Vicente Romero wrote: > the only difference here is the benchmark, the builds used are exactly > the same, and I think those original data you are referring to have a > lot of noise, so I would trust more the table I published yesterday Not sure - it seems to me that after V7 we never had another run which featured similar 'high' scores for JDK13. Anyway, if we can't seem to no longer be able to reproduce these numbers, I think we have to file them under 'anomaly/bogus run' category. If there was a real issue, I would expect the numbers to have popped out in some others of your run. Maurizio From maurizio.cimadamore at oracle.com Tue Mar 26 15:08:08 2019 From: maurizio.cimadamore at oracle.com (Maurizio Cimadamore) Date: Tue, 26 Mar 2019 15:08:08 +0000 Subject: how reliable JMH's results are In-Reply-To: References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <3c657bab-6bbe-2697-0ca9-454fd0f7c313@redhat.com> <4565c38b-8a52-ae3b-ee72-eae4c4f345ba@oracle.com> Message-ID: <6d59e2c0-eaa1-4aa0-78cc-641fadede7d8@oracle.com> On 26/03/2019 11:18, Aleksey Shipilev wrote: > My point is that it is much more useful to profile and see why the difference is like that. I'm all for that, except we don't seem to have a run in which the same result is reproducible. Maurizio From vicente.romero at oracle.com Tue Mar 26 15:44:19 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 26 Mar 2019 11:44:19 -0400 Subject: how reliable JMH's results are In-Reply-To: References: <9c9655c7-cc24-e762-b955-99f422bccd77@oracle.com> <8e43ecbe-b63c-3414-1769-500dbc1b5ecd@oracle.com> <430a37f4-590d-61aa-3b7a-8bff4d8e109b@oracle.com> <0bed4002-f390-917d-64bf-a8728d00cc8d@oracle.com> <663b84e3-5ecc-84f8-582f-0718f870b99b@oracle.com> Message-ID: On 3/26/19 11:07 AM, Maurizio Cimadamore wrote: > > On 26/03/2019 12:38, Vicente Romero wrote: >> the only difference here is the benchmark, the builds used are >> exactly the same, and I think those original data you are referring >> to have a lot of noise, so I would trust more the table I published >> yesterday > > Not sure - it seems to me that after V7 we never had another run which > featured similar 'high' scores for JDK13. > > Anyway, if we can't seem to no longer be able to reproduce these > numbers, I think we have to file them under 'anomaly/bogus run' > category. If there was a real issue, I would expect the numbers to > have popped out in some others of your run. yes I think that that run was an outlier > > Maurizio > From vicente.romero at oracle.com Tue Mar 26 19:01:53 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 26 Mar 2019 15:01:53 -0400 Subject: String::format benchmark results In-Reply-To: References: Message-ID: <9ec946df-0696-aafb-e4a3-f02c13153d5b@oracle.com> Hello, I have published another version [1], same benchmark, same builds, this one include the standard errors of the measurements. The variability of some of the data is significantly large (46% in one case) Thanks, Vicente [1] http://cr.openjdk.java.net/~vromero/string_format_benchmark_results/v2/benchmarkResults_intrinsics_string_format_v2.html On 3/25/19 6:06 PM, Vicente Romero wrote: > Hi all, > > It seems like I overwrote the benchmark for String::format, thanks > Alex, please check the results at [1] > > Thanks, > Vicente > > [1] > http://cr.openjdk.java.net/~vromero/string_format_benchmark_results/v1/benchmarkResults_intrinsics_string_format_v1.html From vicente.romero at oracle.com Tue Mar 26 19:40:42 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 26 Mar 2019 19:40:42 +0000 Subject: hg: amber/amber: manual merge with default Message-ID: <201903261940.x2QJegwR013637@aojmv0008.oracle.com> Changeset: 158efa324ed9 Author: vromero Date: 2019-03-26 15:40 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/158efa324ed9 manual merge with default ! .hgtags ! make/CompileJavaModules.gmk ! make/conf/jib-profiles.js - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh ! make/test/JtregGraalUnit.gmk ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! src/hotspot/cpu/x86/x86.ad ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/linux/os_linux.hpp ! src/hotspot/os/windows/os_windows.cpp - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad ! src/hotspot/share/ci/bcEscapeAnalyzer.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/dictionary.hpp - src/hotspot/share/classfile/dictionary.inline.hpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/gc/epsilon/epsilonHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.inline.hpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1SATBMarkQueueSet.hpp ! src/hotspot/share/gc/g1/g1YoungRemSetSamplingThread.cpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/gcPolicyCounters.hpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahPhaseTimings.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp ! src/hotspot/share/oops/method.hpp ! src/hotspot/share/oops/symbol.hpp ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/regmask.cpp ! src/hotspot/share/opto/regmask.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/compilationPolicy.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/os.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/tieredThresholdPolicy.cpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/DocFilesHandlerImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/IndexRedirectWriter.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c ! test/jdk/ProblemList.txt - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java ! test/jdk/tools/launcher/Test7029048.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From vicente.romero at oracle.com Tue Mar 26 19:51:04 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 26 Mar 2019 19:51:04 +0000 Subject: hg: amber/amber: manual merge with default Message-ID: <201903261951.x2QJp4fv019742@aojmv0008.oracle.com> Changeset: 72b856dc0a05 Author: vromero Date: 2019-03-26 15:50 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/72b856dc0a05 manual merge with default - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileParser.hpp - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp ! src/hotspot/share/oops/method.cpp ! src/hotspot/share/oops/method.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TagletWriterImpl.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/MemberSummaryBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletWriter.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From vicente.romero at oracle.com Tue Mar 26 20:14:59 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 26 Mar 2019 20:14:59 +0000 Subject: hg: amber/amber: manual merge with default Message-ID: <201903262015.x2QKF0Pr003181@aojmv0008.oracle.com> Changeset: ab0ce28f8f56 Author: vromero Date: 2019-03-26 16:14 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/ab0ce28f8f56 manual merge with default ! make/CompileJavaModules.gmk ! make/CreateJmods.gmk ! make/Docs.gmk ! make/Images.gmk ! make/Main.gmk ! make/autoconf/help.m4 ! make/common/NativeCompilation.gmk - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh ! make/hotspot/ide/CreateVSProject.gmk ! make/test/JtregNativeHotspot.gmk ! make/test/JtregNativeJdk.gmk - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/classfile/classFileParser.cpp - src/hotspot/share/classfile/dictionary.inline.hpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/signature.cpp ! src/hotspot/share/runtime/signature.hpp ! src/hotspot/share/runtime/vmStructs.cpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Names.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From vicente.romero at oracle.com Tue Mar 26 20:30:01 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 26 Mar 2019 20:30:01 +0000 Subject: hg: amber/amber: manual merge with default Message-ID: <201903262030.x2QKU11G012030@aojmv0008.oracle.com> Changeset: e91fe45b592f Author: vromero Date: 2019-03-26 16:29 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/e91fe45b592f manual merge with default ! make/CompileJavaModules.gmk - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From vicente.romero at oracle.com Tue Mar 26 20:37:22 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 26 Mar 2019 20:37:22 +0000 Subject: hg: amber/amber: manual merge with records Message-ID: <201903262037.x2QKbNqB017997@aojmv0008.oracle.com> Changeset: 682ec3519ae0 Author: vromero Date: 2019-03-26 16:37 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/682ec3519ae0 manual merge with records - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Flags.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/Tokens.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeMaker.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java ! src/jdk.jshell/share/classes/jdk/jshell/CompletenessAnalyzer.java - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/datum/RecordsCantDeclareSomeMembersTest.java - test/langtools/tools/javac/datum/RecordsCantDeclareSomeMembersTest.out - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java From maurizio.cimadamore at oracle.com Tue Mar 26 20:41:09 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Tue, 26 Mar 2019 20:41:09 +0000 Subject: hg: amber/amber: Automatic merge with patterns-stage-1 Message-ID: <201903262041.x2QKf97N020356@aojmv0008.oracle.com> Changeset: f95285563b00 Author: mcimadamore Date: 2019-03-26 21:40 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f95285563b00 Automatic merge with patterns-stage-1 ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From vicente.romero at oracle.com Tue Mar 26 20:39:04 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Tue, 26 Mar 2019 20:39:04 +0000 Subject: hg: amber/amber: changing dependency to records-and-sealed Message-ID: <201903262039.x2QKd4Os018785@aojmv0008.oracle.com> Changeset: 01f34d396fad Author: vromero Date: 2019-03-26 16:38 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/01f34d396fad changing dependency to records-and-sealed ! deps.txt From vicente.romero at oracle.com Wed Mar 27 02:40:18 2019 From: vicente.romero at oracle.com (Vicente Romero) Date: Tue, 26 Mar 2019 22:40:18 -0400 Subject: String::format benchmark results In-Reply-To: <9ec946df-0696-aafb-e4a3-f02c13153d5b@oracle.com> References: <9ec946df-0696-aafb-e4a3-f02c13153d5b@oracle.com> Message-ID: <433189e0-b2ce-9f0f-2366-3b5567f32a6e@oracle.com> This version [1] includes two new tables for floats, the numbers are not so great for them. There was also a SOE during execution of test testFormat0080float0080String, see last row of `Table 7`, that's why there is no information in the last half of the table. I will investigate the reason for the error, Vicente [1] http://cr.openjdk.java.net/~vromero/string_format_benchmark_results/v3/benchmarkResults_intrinsics_string_format_v3.html On 3/26/19 3:01 PM, Vicente Romero wrote: > Hello, > > I have published another version [1], same benchmark, same builds, > this one include the standard errors of the measurements. The > variability of some of the data is significantly large (46% in one case) > > Thanks, > Vicente > > [1] > http://cr.openjdk.java.net/~vromero/string_format_benchmark_results/v2/benchmarkResults_intrinsics_string_format_v2.html > > On 3/25/19 6:06 PM, Vicente Romero wrote: >> Hi all, >> >> It seems like I overwrote the benchmark for String::format, thanks >> Alex, please check the results at [1] >> >> Thanks, >> Vicente >> >> [1] >> http://cr.openjdk.java.net/~vromero/string_format_benchmark_results/v1/benchmarkResults_intrinsics_string_format_v1.html > From vicente.romero at oracle.com Wed Mar 27 15:15:44 2019 From: vicente.romero at oracle.com (vicente.romero at oracle.com) Date: Wed, 27 Mar 2019 15:15:44 +0000 Subject: hg: amber/amber: minor doc fix Message-ID: <201903271515.x2RFFiEJ025240@aojmv0008.oracle.com> Changeset: ad255bb46593 Author: vromero Date: 2019-03-27 11:14 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/ad255bb46593 minor doc fix ! src/java.base/share/classes/java/lang/invoke/ObjectMethodBuilders.java From maurizio.cimadamore at oracle.com Wed Mar 27 15:20:56 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Wed, 27 Mar 2019 15:20:56 +0000 Subject: hg: amber/amber: Automatic merge with records-and-sealed Message-ID: <201903271520.x2RFKuT8028736@aojmv0008.oracle.com> Changeset: db11f27a40bf Author: mcimadamore Date: 2019-03-27 16:20 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/db11f27a40bf Automatic merge with records-and-sealed From maurizio.cimadamore at oracle.com Thu Mar 28 21:03:08 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:03:08 +0000 Subject: hg: amber/amber: 194 new changesets Message-ID: <201903282103.x2SL3IxY016629@aojmv0008.oracle.com> Changeset: b70c65a946a0 Author: ngasson Date: 2019-03-14 14:25 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/b70c65a946a0 8219628: [TESTBUG] javadoc/doclet/InheritDocForUserTags fails with -othervm Reviewed-by: jjg, clanger ! test/langtools/jdk/javadoc/doclet/InheritDocForUserTags/DocTest.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java Changeset: b6134b6d75ff Author: jjg Date: 2019-03-14 15:30 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/b6134b6d75ff 8220249: fix headings in java.compiler Reviewed-by: erikj, darcy ! make/CompileJavaModules.gmk ! src/java.compiler/share/classes/javax/annotation/processing/Generated.java Changeset: 8a66c92526cb Author: iignatyev Date: 2019-03-14 16:17 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/8a66c92526cb 8220689: problem list RandomCommandsTest in graal runs Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-graal.txt Changeset: 421b47214391 Author: dtitov Date: 2019-03-14 16:28 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/421b47214391 8218812: vmTestbase/nsk/jvmti/GetAllThreads/allthr001/TestDescription.java failed Reviewed-by: dlong, sspitsyn, jcbeyler ! test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp Changeset: 6ab293f66cae Author: iignatyev Date: 2019-03-14 19:37 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/6ab293f66cae 8219139: move hotspot tests from test/jdk/vm Reviewed-by: dholmes, mseledtsov + test/hotspot/jtreg/compiler/codegen/BadLogicCode.java + test/hotspot/jtreg/compiler/codegen/ShiftTest.java + test/hotspot/jtreg/compiler/exceptions/ExceptionInInit.java + test/hotspot/jtreg/compiler/runtime/JITClassInit.java + test/hotspot/jtreg/gc/ArraySize.java + test/hotspot/jtreg/gc/InfiniteList.java + test/hotspot/jtreg/runtime/ErrorHandling/ExplicitArithmeticCheck.java + test/hotspot/jtreg/runtime/Thread/MonitorCacheMaybeExpand_DeadLock.java + test/hotspot/jtreg/runtime/interpreter/WideStrictInline.java + test/hotspot/jtreg/runtime/reflect/ReflectStackOverflow.java + test/hotspot/jtreg/runtime/verifier/TestStaticIF.java + test/hotspot/jtreg/runtime/verifier/VerifyProtectedConstructor.java + test/hotspot/jtreg/runtime/verifier/VerifyStackForExceptionHandlers.java + test/hotspot/jtreg/runtime/verifier/defaultMethods/DefaultMethodRegressionTests.java + test/hotspot/jtreg/runtime/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java ! test/jdk/TEST.groups + test/jdk/tools/launcher/JniInvocationTest.java + test/jdk/tools/launcher/exeJniInvocationTest.c - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java Changeset: 8ff8b3734549 Author: thartmann Date: 2019-03-15 08:27 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/8ff8b3734549 8220611: compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java timeout Summary: Test should not be executed with Graal as JIT. Reviewed-by: kvn ! test/hotspot/jtreg/compiler/classUnloading/methodUnloading/TestOverloadCompileQueues.java Changeset: fb7a1fdeaea7 Author: gadams Date: 2019-03-15 06:16 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/fb7a1fdeaea7 8220678: unquarantine nsk/jdi/ThreadReference/setEnabled/setenabled003 Reviewed-by: cjplummer, sspitsyn ! test/hotspot/jtreg/ProblemList.txt Changeset: 6f14d52d5e10 Author: shade Date: 2019-03-15 13:01 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/6f14d52d5e10 8220712: [TESTBUG] gc/shenandoah/compiler/TestMaybeNullUnsafeAccess should run with Shenandoah enabled Reviewed-by: rkennke, roland ! test/hotspot/jtreg/gc/shenandoah/compiler/TestMaybeNullUnsafeAccess.java Changeset: 81605c74b980 Author: chegar Date: 2019-03-15 14:50 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/81605c74b980 8179549: Typo in network properties documentation Reviewed-by: clanger, coffeys ! src/java.base/share/classes/java/net/doc-files/net-properties.html Changeset: 8f91e1a7ebdc Author: chegar Date: 2019-03-15 14:54 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/8f91e1a7ebdc 8213912: Semantic typo in HttpExchange.java Reviewed-by: dfuchs ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java Changeset: 62e4ada7c4c8 Author: erikj Date: 2019-03-15 09:13 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/62e4ada7c4c8 8220093: Change to GCC 8.2 for building on Linux at Oracle Reviewed-by: tbell ! make/autoconf/toolchain.m4 ! make/conf/jib-profiles.js ! make/devkit/Makefile + make/devkit/Tars.gmk ! make/devkit/Tools.gmk Changeset: c61f09122d3b Author: jwilhelm Date: 2019-03-15 18:59 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/c61f09122d3b 8220704: ZGC: gc tests complain Java heap too small Reviewed-by: iignatyev, tschatzl ! test/hotspot/jtreg/gc/ArraySize.java ! test/hotspot/jtreg/gc/InfiniteList.java Changeset: 5529640c5f67 Author: coleenp Date: 2019-03-15 16:00 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/5529640c5f67 8220512: Deoptimize redefinition functions that have dirty ICs Summary: Walk ICs to determine whether nmethods are dependent on redefined classes. Reviewed-by: sspitsyn, eosterlund ! src/hotspot/share/aot/aotCodeHeap.cpp ! src/hotspot/share/aot/aotCodeHeap.hpp ! src/hotspot/share/aot/aotCompiledMethod.cpp ! src/hotspot/share/aot/aotCompiledMethod.hpp ! src/hotspot/share/aot/aotLoader.cpp ! src/hotspot/share/aot/aotLoader.hpp ! src/hotspot/share/ci/ciEnv.hpp ! src/hotspot/share/ci/ciObjectFactory.cpp ! src/hotspot/share/ci/ciObjectFactory.hpp ! src/hotspot/share/classfile/metadataOnStackMark.cpp ! src/hotspot/share/code/codeCache.cpp ! src/hotspot/share/code/codeCache.hpp ! src/hotspot/share/code/compiledMethod.cpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/memory/iterator.hpp ! src/hotspot/share/runtime/frame.cpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: d2f8b7b33013 Author: bpb Date: 2019-03-15 16:24 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/d2f8b7b33013 8219876: (bf) Improve IndexOutOfBoundsException messages in $Type$Buffer classes Reviewed-by: alanb, rriggs ! src/java.base/share/classes/java/nio/Buffer.java ! src/java.base/share/classes/java/nio/ByteBufferAs-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template ! src/java.base/share/classes/java/nio/Heap-X-Buffer.java.template ! src/java.base/share/classes/java/nio/StringCharBuffer.java ! src/java.base/share/classes/java/nio/X-Buffer.java.template Changeset: 5274462d5725 Author: jwilhelm Date: 2019-03-16 02:08 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/5274462d5725 8220745: Fix problemlist entry to refer to 8220613 Reviewed-by: dcubed ! test/jdk/ProblemList.txt Changeset: 4985c8ca55b9 Author: ysuenaga Date: 2019-03-16 21:27 +0900 URL: http://hg.openjdk.java.net/amber/amber/rev/4985c8ca55b9 8220555: JFR tool shows potentially misleading message when it cannot access a file Reviewed-by: egahlin, mseledtsov ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Command.java ! test/jdk/jdk/jfr/tool/TestPrint.java Changeset: 1caf2daef7cf Author: alanb Date: 2019-03-16 12:31 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/1caf2daef7cf 8220738: (sc) Move ServerSocketChannelImpl remaining native method to Net Reviewed-by: bpb ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/share/classes/sun/nio/ch/ServerSocketChannelImpl.java ! src/java.base/unix/classes/sun/nio/ch/UnixAsynchronousServerSocketChannelImpl.java ! src/java.base/unix/native/libnio/ch/IOUtil.c ! src/java.base/unix/native/libnio/ch/Net.c - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c ! src/java.base/unix/native/libnio/ch/nio_util.h ! src/java.base/windows/native/libnio/ch/IOUtil.c ! src/java.base/windows/native/libnio/ch/Net.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c ! src/java.base/windows/native/libnio/ch/nio_util.h ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpServerChannelImpl.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c ! test/jdk/com/sun/nio/sctp/SctpMultiChannel/SendFailed.java Changeset: b5a73f22b2bd Author: alanb Date: 2019-03-16 19:44 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/b5a73f22b2bd 8220493: Prepare Socket/ServerSocket for alternative platform SocketImpl Reviewed-by: chegar Contributed-by: alan.bateman at oracle.com, michael.x.mcmahon at oracle.com ! src/java.base/share/classes/java/net/AbstractPlainSocketImpl.java + src/java.base/share/classes/java/net/DelegatingSocketImpl.java ! src/java.base/share/classes/java/net/HttpConnectSocketImpl.java ! src/java.base/share/classes/java/net/ServerSocket.java ! src/java.base/share/classes/java/net/Socket.java ! src/java.base/share/classes/java/net/SocketImpl.java ! src/java.base/share/classes/java/net/SocksSocketImpl.java + src/java.base/share/classes/sun/net/PlatformSocketImpl.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketInputStreamInstrumentor.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/instrument/SocketOutputStreamInstrumentor.java + test/jdk/java/net/SocketImpl/SocketImplCombinations.java ! test/jdk/jdk/jfr/event/io/TestInstrumentation.java Changeset: 56e9781e6044 Author: igerasim Date: 2019-03-16 13:44 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/56e9781e6044 6307456: UnixFileSystem_md.c use of chmod() and access() should handle EINTR signal appropriately (unix) Reviewed-by: bpb, dholmes, alanb ! src/java.base/unix/native/libjava/UnixFileSystem_md.c ! src/java.base/unix/native/libjava/io_util_md.h Changeset: 1a18b8d56d73 Author: igerasim Date: 2019-03-16 15:05 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/1a18b8d56d73 8220684: Process.waitFor(long, TimeUnit) can return false for a process that exited within the timeout Reviewed-by: prappo, dholmes, rriggs ! src/java.base/share/classes/java/lang/Process.java + test/jdk/java/lang/Process/WaitFor.java Changeset: 5e1480a38a43 Author: chegar Date: 2019-03-17 08:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/5e1480a38a43 8220719: Allow other named NetPermissions to be used Reviewed-by: mullan, alanb ! src/java.base/share/classes/java/net/NetPermission.java Changeset: 7c23a4432610 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/7c23a4432610 8220569: ZGC: Rename and rework ZUnmapBadViews to ZVerifyViews Reviewed-by: stefank, eosterlund ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.cpp ! src/hotspot/os_cpu/linux_x86/gc/z/zPhysicalMemoryBacking_linux_x86.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp ! src/hotspot/share/gc/z/zPhysicalMemory.cpp ! src/hotspot/share/gc/z/zPhysicalMemory.hpp ! src/hotspot/share/gc/z/z_globals.hpp ! test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java Changeset: 759a63069fac Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/759a63069fac 8220741: ZGC: Move CPU agnostic files from linux_x86 to linux Reviewed-by: stefank, eosterlund + src/hotspot/os/linux/gc/z/zLargePages_linux.cpp + src/hotspot/os/linux/gc/z/zNUMA_linux.cpp + src/hotspot/os/linux/gc/z/zVirtualMemory_linux.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp Changeset: 349843ebb209 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/349843ebb209 8220586: ZGC: Move relocation logic from ZPage to ZRelocate Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocate.hpp Changeset: f344a0c6e19e Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f344a0c6e19e 8220587: ZGC: Break out forwarding information from ZPage Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zBarrier.cpp + src/hotspot/share/gc/z/zForwarding.cpp + src/hotspot/share/gc/z/zForwarding.hpp + src/hotspot/share/gc/z/zForwarding.inline.hpp + src/hotspot/share/gc/z/zForwardingEntry.hpp ! src/hotspot/share/gc/z/zForwardingTable.cpp ! src/hotspot/share/gc/z/zForwardingTable.hpp ! src/hotspot/share/gc/z/zForwardingTable.inline.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp ! src/hotspot/share/gc/z/zGranuleMap.hpp ! src/hotspot/share/gc/z/zGranuleMap.inline.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageCache.cpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocate.hpp + test/hotspot/gtest/gc/z/test_zForwarding.cpp - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp ! test/hotspot/jtreg/ProblemList-zgc.txt Changeset: 790679f86a51 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/790679f86a51 8220588: ZGC: Convert ZRelocationSet to hold ZForwardings instead of ZPages Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zDriver.cpp ! src/hotspot/share/gc/z/zDriver.hpp ! src/hotspot/share/gc/z/zForwarding.cpp ! src/hotspot/share/gc/z/zForwarding.hpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! src/hotspot/share/gc/z/zForwardingTable.cpp ! src/hotspot/share/gc/z/zForwardingTable.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zRelocate.cpp ! src/hotspot/share/gc/z/zRelocationSet.cpp ! src/hotspot/share/gc/z/zRelocationSet.hpp ! src/hotspot/share/gc/z/zRelocationSet.inline.hpp ! src/hotspot/share/gc/z/zRelocationSetSelector.cpp ! src/hotspot/share/gc/z/zRelocationSetSelector.hpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: c585ef187216 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/c585ef187216 8220589: ZGC: Remove superfluous ZPageTableEntry Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zDebug.gdb ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zHeap.inline.hpp ! src/hotspot/share/gc/z/zMark.cpp ! src/hotspot/share/gc/z/zMark.hpp ! src/hotspot/share/gc/z/zPageTable.cpp ! src/hotspot/share/gc/z/zPageTable.hpp ! src/hotspot/share/gc/z/zPageTable.inline.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZHeap.java Changeset: 84295bd6d359 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/84295bd6d359 8220590: ZGC: Remove ZPages from ZPageTable when freed Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPageTable.cpp Changeset: b9f030844be4 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/b9f030844be4 8220591: ZGC: Don't delay reclaimation of ZVirtualMemory Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zPageAllocator.cpp Changeset: d0d26fc836dd Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/d0d26fc836dd 8220592: ZGC: Move destruction of detached ZPages into ZPageAllocator Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp Changeset: eb54b34af2be Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/eb54b34af2be 8220593: ZGC: Remove superfluous ZPage::is_detached() Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageCache.cpp Changeset: 5748eae24183 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/5748eae24183 8220594: ZGC: Remove superfluous ZPage::is_active() Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zPage.cpp ! src/hotspot/share/gc/z/zPage.hpp ! src/hotspot/share/gc/z/zPage.inline.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageCache.cpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: 8f1771ea1e39 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/8f1771ea1e39 8220595: ZGC: Introduce ZAttachedArray Reviewed-by: stefank, eosterlund + src/hotspot/share/gc/z/zAttachedArray.hpp + src/hotspot/share/gc/z/zAttachedArray.inline.hpp Changeset: 07943af21b96 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/07943af21b96 8220596: ZGC: Convert ZNMethodData to use ZAttachedArray Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zNMethodData.cpp ! src/hotspot/share/gc/z/zNMethodData.hpp Changeset: f92f1f1045ad Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f92f1f1045ad 8220597: ZGC: Convert ZForwarding to use ZAttachedArray Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/vmStructs_z.hpp ! src/hotspot/share/gc/z/zForwarding.cpp ! src/hotspot/share/gc/z/zForwarding.hpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: e6a92f2f37a9 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/e6a92f2f37a9 8220599: ZGC: Introduce ZSafeDelete Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zArray.hpp ! src/hotspot/share/gc/z/zArray.inline.hpp + src/hotspot/share/gc/z/zSafeDelete.hpp + src/hotspot/share/gc/z/zSafeDelete.inline.hpp Changeset: 6d1caebf8d37 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/6d1caebf8d37 8220600: ZGC: Delete ZPages using ZSafeDelete Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zDriver.cpp ! src/hotspot/share/gc/z/zDriver.hpp ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeap.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp Changeset: 36e0665773e7 Author: pliden Date: 2019-03-18 11:50 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/36e0665773e7 8220601: ZGC: Delete ZNMethodTableEntry arrays using ZSafeDelete Reviewed-by: stefank, eosterlund - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp ! src/hotspot/share/gc/z/zNMethodTable.cpp ! src/hotspot/share/gc/z/zNMethodTable.hpp Changeset: 2786541e4f91 Author: sgehwolf Date: 2019-03-13 20:07 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/2786541e4f91 8220579: [Containers] SubSystem.java out of sync with osContainer_linux.cpp Reviewed-by: bobv, adinn ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java Changeset: b4779a44476b Author: stefank Date: 2019-03-18 15:19 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/b4779a44476b 8220606: Move ScavengableNMethods unlinking to unregister_nmethod Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.hpp Changeset: 98e21d4da074 Author: stefank Date: 2019-03-18 15:21 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/98e21d4da074 8220609: Cleanups in ScavengableNMethods Reviewed-by: pliden, eosterlund ! src/hotspot/share/gc/cms/concurrentMarkSweepGeneration.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psMarkSweep.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psTasks.cpp ! src/hotspot/share/gc/serial/genMarkSweep.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/scavengableNMethods.cpp ! src/hotspot/share/gc/shared/scavengableNMethods.hpp Changeset: e81b44c68680 Author: rkennke Date: 2019-03-18 16:33 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/e81b44c68680 8220780: ShenandoahBS::AccessBarrier::oop_store_in_heap ignores AS_NO_KEEPALIVE Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahBarrierSet.inline.hpp Changeset: 564043cbe138 Author: erikj Date: 2019-03-18 17:33 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/564043cbe138 8220737: Jib based 32 bit windows builds fail Reviewed-by: tbell, dholmes ! make/conf/jib-profiles.js Changeset: d265655be483 Author: jjg Date: 2019-03-18 11:50 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/d265655be483 8220693: jdk/javadoc/doclet/MetaTag/MetaTag.java with unexpected date Reviewed-by: hannesw ! test/langtools/jdk/javadoc/doclet/MetaTag/MetaTag.java Changeset: 2e586b74722e Author: jnimeh Date: 2019-03-18 15:26 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/2e586b74722e 8218723: Use SunJCE Mac in SecretKeyFactory PBKDF2 implementation Reviewed-by: apetcher ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java + test/jdk/javax/crypto/SecretKeyFactory/SecKeyFacSunJCEPrf.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov.jar + test/jdk/javax/crypto/SecretKeyFactory/evilprov/Makefile + test/jdk/javax/crypto/SecretKeyFactory/evilprov/README + test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilHmacSHA1.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov/com/evilprovider/EvilProvider.java + test/jdk/javax/crypto/SecretKeyFactory/evilprov/module-info.java Changeset: 7418b266e1c7 Author: jjiang Date: 2019-03-19 10:36 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/7418b266e1c7 8220410: sun/security/tools/jarsigner/warnings/NoTimestampTest.java failed with missing expected output Summary: Using the same timezone for jar verifying and date formatting Reviewed-by: weijun ! test/jdk/sun/security/tools/jarsigner/warnings/NoTimestampTest.java ! test/jdk/sun/security/tools/jarsigner/warnings/Test.java Changeset: 5f4dedb4dcf5 Author: aoqi Date: 2019-03-19 17:03 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/5f4dedb4dcf5 8220812: gc/shenandoah/options/TestLoopMiningArguments.java fails if default GC is serial/parallel/cms Reviewed-by: shade Contributed-by: Ao Qi ! test/hotspot/jtreg/gc/shenandoah/options/TestLoopMiningArguments.java Changeset: 8717d7424861 Author: chegar Date: 2019-03-19 11:15 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/8717d7424861 8170705: sun/net/www/protocol/http/StackTraceTest.java fails intermittently with Invalid Http response Reviewed-by: dfuchs ! test/jdk/sun/net/www/protocol/http/StackTraceTest.java Changeset: 3827cd66e788 Author: mbaesken Date: 2019-03-18 16:04 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/3827cd66e788 8220781: linux-s390 : os::get_summary_cpu_info gives bad output Reviewed-by: dholmes, lucy ! src/hotspot/os/linux/os_linux.cpp Changeset: f554d3e88da3 Author: mbaesken Date: 2019-03-18 15:29 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f554d3e88da3 8220355: Improve assertion texts and exception messages in eventHandlerVMInit Reviewed-by: alanb, sspitsyn, jcbeyler ! src/java.instrument/share/native/libinstrument/InvocationAdapter.c ! src/java.instrument/share/native/libinstrument/JPLISAgent.c Changeset: 791052cc88db Author: chegar Date: 2019-03-19 14:27 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/791052cc88db 8220663: Incorrect handling of IPv6 addresses in Socket(Proxy.HTTP) Reviewed-by: alanb, michaelm ! src/java.base/share/classes/java/net/HttpConnectSocketImpl.java ! test/jdk/java/net/Socket/HttpProxy.java Changeset: dfde3bb48c03 Author: rriggs Date: 2019-03-19 10:47 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/dfde3bb48c03 8220613: java/util/Arrays/TimSortStackSize2.java times out with fastdebug build Reviewed-by: lancea, alanb ! test/jdk/ProblemList.txt ! test/jdk/TEST.ROOT ! test/jdk/java/util/Arrays/TimSortStackSize2.java Changeset: 021448dc442c Author: kbarrett Date: 2019-03-19 14:08 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/021448dc442c 8220690: ATTRIBUTE_ALIGNED requires GNU extensions enabled Summary: Use __typeof__(x) instead of typeof(x). Reviewed-by: shade, sgehwolf ! src/hotspot/share/utilities/globalDefinitions_gcc.hpp Changeset: da7f6755ba71 Author: bobv Date: 2019-03-19 12:00 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/da7f6755ba71 8219562: Line of code in osContainer_linux.cpp L102 appears unreachable Reviewed-by: rriggs, sgehwolf ! src/hotspot/os/linux/osContainer_linux.cpp Changeset: d909d0a883c4 Author: bobv Date: 2019-03-19 12:10 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/d909d0a883c4 8212528: Wrong cgroup subsystem being used for some CPU Container Metrics Reviewed-by: rriggs, sgehwolf ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java Changeset: d5da034032e9 Author: bobv Date: 2019-03-19 12:29 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/d5da034032e9 8217766: Container Support doesn't work for some Join Controllers combinations Reviewed-by: rriggs, sgehwolf ! src/hotspot/os/linux/osContainer_linux.cpp ! src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java Changeset: c2238a12f259 Author: bobv Date: 2019-03-19 14:31 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/c2238a12f259 Merge Changeset: 4b6a629d0615 Author: kbarrett Date: 2019-03-19 14:32 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/4b6a629d0615 8218975: Bug in macOSX kernel's pthread support Summary: Use freelist of pthread_mutex/condvar pairs on macOSX. Reviewed-by: tschatzl, dholmes, dcubed Contributed-by: kim.barrett at oracle.com, patricio.chilano.mateo at oracle.com ! src/hotspot/os/posix/os_posix.cpp ! src/hotspot/os/posix/os_posix.hpp ! src/hotspot/os/posix/os_posix.inline.hpp Changeset: 6146ab937899 Author: coleenp Date: 2019-03-19 14:22 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/6146ab937899 8220744: Move RedefineTests to from runtime to serviceability Summary: move tests out of runtime to jvmti/RedefineClasses Reviewed-by: sspitsyn, dcubed, cjplummer, hseigel, mseledtsov ! test/hotspot/jtreg/TEST.groups - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c ! test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineBasicTest.java ! test/hotspot/jtreg/runtime/appcds/redefineClass/RedefineRunningMethods_Shared.java ! test/hotspot/jtreg/runtime/logging/RedefineClasses.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/Agent.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/ModifyAnonymous.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAddLambdaExpression.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineAnnotations.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDeleteJmethod.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineDoubleDelete.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineFinalizer.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceCall.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineInterfaceMethods.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineLeak.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethods.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithBacktrace.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineRunningMethodsWithResolutionErrors.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RedefineSubtractLambdaExpression.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/RetransformClassesZeroLength.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestLambdaFormRetransformation.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestMultipleClasses.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineObject.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineWithUnresolvedClass.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/UnresolvedClassAgent.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/UnresolvedClassAgent.mf + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/WalkThroughInvoke.java + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/libRedefineDeleteJmethod.c + test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/libRedefineDoubleDelete.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf Changeset: ddfb658c8ce3 Author: apetcher Date: 2019-03-19 15:18 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/ddfb658c8ce3 8147502: Digest is incorrectly truncated for ECDSA signatures when the bit length of n is less than the field size Summary: Truncate the digest according to the group order, not the field size Reviewed-by: jnimeh ! src/jdk.crypto.ec/share/classes/sun/security/ec/ECDSASignature.java ! src/jdk.crypto.ec/share/native/libsunec/impl/ec.c + test/jdk/sun/security/ec/SignatureDigestTruncate.java Changeset: 6ba98ff89499 Author: pmuthuswamy Date: 2019-03-20 09:58 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/6ba98ff89499 8219958: Automatically load taglets from a jar file Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java + test/langtools/jdk/javadoc/doclet/testAutoLoadTaglets/TestAutoLoadTaglets.java Changeset: 40296a51aeb0 Author: chegar Date: 2019-03-20 08:33 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/40296a51aeb0 8153508: ContentHandler API contains link to private contentPathProp Reviewed-by: dfuchs, vtewari ! src/java.base/share/classes/java/net/ContentHandler.java Changeset: af3f568cbd2d Author: dcherepanov Date: 2019-03-20 11:51 +0300 URL: http://hg.openjdk.java.net/amber/amber/rev/af3f568cbd2d 8211100: hotspot C1 issue with comparing long numbers on x86 32-bit Reviewed-by: iveresov, thartmann ! src/hotspot/share/c1/c1_LIRGenerator.cpp + test/hotspot/jtreg/compiler/c1/Test8211100.java Changeset: 83cace4142c8 Author: chegar Date: 2019-03-20 09:17 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/83cace4142c8 8221098: Run java/net/URL/HandlerLoop.java in othervm mode Reviewed-by: alanb, martin ! test/jdk/java/net/URL/HandlerLoop.java Changeset: 06222165c35f Author: jwilhelm Date: 2019-03-20 17:13 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/06222165c35f Added tag jdk-12-ga for changeset b67884871b5f ! .hgtags Changeset: 18547cad9ec6 Author: jwilhelm Date: 2019-03-20 17:28 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/18547cad9ec6 Merge ! .hgtags Changeset: 55c262f4f5a1 Author: jwilhelm Date: 2019-03-20 22:53 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/55c262f4f5a1 8220389: Update Graal Reviewed-by: kvn, dlong + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/IntegerStampShiftTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/CompilationWrapper.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/GraalCompilerOptions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationFailureActionHelp.txt + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64ArrayEqualsStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.jdk9.test/src/org/graalvm/compiler/hotspot/jdk9/test/StringUTF16ToBytesGetCharsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/BigIntegerIntrinsicsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorld.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/CompileTheWorldTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/GraalOSRTestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalOptionValues.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayIndexOfOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGeneratorTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/calc/UnsignedRightShiftNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayEqualsNode.java Changeset: d9f43dfbe524 Author: dholmes Date: 2019-03-20 18:01 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/d9f43dfbe524 8218446: SuspendAtExit hangs Reviewed-by: rehn, dcubed ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 003cc64366da Author: jjg Date: 2019-03-20 15:35 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/003cc64366da 8220249: fix headings in java.compiler Reviewed-by: erikj, darcy ! src/java.base/share/classes/java/io/DataInput.java ! src/java.base/share/classes/java/io/File.java ! src/java.base/share/classes/java/lang/Character.java ! src/java.base/share/classes/java/lang/ClassLoader.java ! src/java.base/share/classes/java/lang/ModuleLayer.java ! src/java.base/share/classes/java/lang/doc-files/ValueBased.html ! src/java.base/share/classes/java/lang/doc-files/threadPrimitiveDeprecation.html ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleInfo.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/MutableCallSite.java ! src/java.base/share/classes/java/lang/invoke/VarHandle.java ! src/java.base/share/classes/java/lang/invoke/package-info.java ! src/java.base/share/classes/java/lang/module/Configuration.java ! src/java.base/share/classes/java/lang/module/package-info.java ! src/java.base/share/classes/java/lang/reflect/Proxy.java ! src/java.base/share/classes/java/net/Inet4Address.java ! src/java.base/share/classes/java/net/Inet6Address.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/net/URI.java ! src/java.base/share/classes/java/text/ChoiceFormat.java ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! src/java.base/share/classes/java/text/DateFormat.java ! src/java.base/share/classes/java/text/DecimalFormat.java ! src/java.base/share/classes/java/text/Format.java ! src/java.base/share/classes/java/text/MessageFormat.java ! src/java.base/share/classes/java/text/NumberFormat.java ! src/java.base/share/classes/java/text/SimpleDateFormat.java ! src/java.base/share/classes/java/time/Instant.java ! src/java.base/share/classes/java/time/ZoneId.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDate.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDateImpl.java ! src/java.base/share/classes/java/time/chrono/ChronoLocalDateTime.java ! src/java.base/share/classes/java/time/chrono/ChronoZonedDateTime.java ! src/java.base/share/classes/java/time/chrono/Chronology.java ! src/java.base/share/classes/java/time/format/DateTimeFormatter.java ! src/java.base/share/classes/java/time/temporal/IsoFields.java ! src/java.base/share/classes/java/time/temporal/JulianFields.java ! src/java.base/share/classes/java/time/temporal/Temporal.java ! src/java.base/share/classes/java/time/temporal/WeekFields.java ! src/java.base/share/classes/java/util/Calendar.java ! src/java.base/share/classes/java/util/Formatter.java ! src/java.base/share/classes/java/util/GregorianCalendar.java ! src/java.base/share/classes/java/util/Locale.java ! src/java.base/share/classes/java/util/ResourceBundle.java ! src/java.base/share/classes/java/util/Scanner.java ! src/java.base/share/classes/java/util/ServiceLoader.java ! src/java.base/share/classes/java/util/TimeZone.java ! src/java.base/share/classes/java/util/doc-files/coll-designfaq.html ! src/java.base/share/classes/java/util/regex/Pattern.java ! src/java.base/share/classes/java/util/spi/LocaleServiceProvider.java ! src/java.base/share/classes/java/util/spi/ResourceBundleProvider.java Changeset: ce78fac1f6d5 Author: jwilhelm Date: 2019-03-21 01:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ce78fac1f6d5 Added tag jdk-13+13 for changeset 83cace4142c8 ! .hgtags Changeset: 79fcfc6c02e8 Author: dholmes Date: 2019-03-20 23:32 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/79fcfc6c02e8 8221180: Deprecate AllowJNIEnvProxy Reviewed-by: coleenp, dcubed ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/runtime/CommandLine/VMDeprecatedOptions.java Changeset: a8e7194c2b0d Author: dholmes Date: 2019-03-21 03:00 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/a8e7194c2b0d 8221208: Backout JDK-8218446 Reviewed-by: iignatyev, rehn ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: 8d9d71bba199 Author: clanger Date: 2019-03-21 09:16 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/8d9d71bba199 8172695: (scanner) java/util/Scanner/ScanTest.java fails Reviewed-by: smarks, bpb ! test/jdk/java/util/Scanner/ScanTest.java Changeset: 67c58bd66e82 Author: jiefu Date: 2019-03-21 04:55 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/67c58bd66e82 8220658: Improve the readability of container information in the error log Reviewed-by: dholmes, bobv ! src/hotspot/os/linux/os_linux.cpp Changeset: ed40b61fed96 Author: ysuenaga Date: 2019-03-21 21:17 +0900 URL: http://hg.openjdk.java.net/amber/amber/rev/ed40b61fed96 8220784: hsdis cannot be built with MinGW64 Reviewed-by: iklam, dholmes ! src/utils/hsdis/Makefile Changeset: d8d45286ffa9 Author: mbalao Date: 2019-03-21 01:51 -0300 URL: http://hg.openjdk.java.net/amber/amber/rev/d8d45286ffa9 8220753: Re-introduce the test case for TLS 1.2 algorithms in SunPKCS11 crypto provider Reviewed-by: xuelei + test/jdk/sun/security/pkcs11/tls/tls12/TestTLS12.java + test/jdk/sun/security/pkcs11/tls/tls12/cert8.db + test/jdk/sun/security/pkcs11/tls/tls12/key3.db + test/jdk/sun/security/pkcs11/tls/tls12/keystore + test/jdk/sun/security/pkcs11/tls/tls12/nss.cfg + test/jdk/sun/security/pkcs11/tls/tls12/secmod.db Changeset: 0288c6919a20 Author: hseigel Date: 2019-03-21 10:47 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/0288c6919a20 8221096: Description of -XX:+PrintFlagsRanges is incorrect Summary: Remove the phrase: and exit VM Reviewed-by: lfoltan ! src/hotspot/share/runtime/globals.hpp Changeset: b00a4187d5ec Author: apetcher Date: 2019-03-21 13:10 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/b00a4187d5ec 8221172: SunEC specific test is not limited to SunEC Summary: Fixing a minor test bug in the SignatureDigestTruncate regression test Reviewed-by: mullan ! test/jdk/sun/security/ec/SignatureDigestTruncate.java Changeset: f10ca228b22f Author: alanb Date: 2019-03-21 17:38 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/f10ca228b22f 8221259: New tests for java.net.Socket to exercise long standing behavior Reviewed-by: chegar + test/jdk/java/net/Socket/AsyncShutdown.java + test/jdk/java/net/Socket/ConnectionReset.java + test/jdk/java/net/Socket/Timeouts.java + test/jdk/java/net/Socket/UdpSocket.java Changeset: 98a01c1344aa Author: bobv Date: 2019-03-21 14:40 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/98a01c1344aa 8220674: [TESTBUG] MetricsMemoryTester failcount test in docker container only works with debug JVMs Reviewed-by: sspitsyn, sgehwolf ! test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java ! test/jdk/jdk/internal/platform/docker/TestDockerMemoryMetrics.java Changeset: 3fe41815505c Author: bchristi Date: 2019-03-21 11:58 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/3fe41815505c 8211941: Enable checking/ignoring of non-conforming Class-Path entries Reviewed-by: alanb, mchung ! src/java.base/share/classes/jdk/internal/loader/URLClassPath.java Changeset: 35e8d1eb4040 Author: igerasim Date: 2019-03-21 12:28 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/35e8d1eb4040 8170494: JNI exception pending in PlainDatagramSocketImpl.c Reviewed-by: clanger, vtewari ! src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c Changeset: 7fbb4340b125 Author: dtitov Date: 2019-03-21 19:56 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/7fbb4340b125 8218401: WRONG_PHASE: vmTestbase/nsk/jvmti test crash Reviewed-by: sspitsyn, jcbeyler ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/Breakpoint/breakpoint001/breakpoint001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/FramePop/framepop002/framepop002.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SingleStep/singlestep003/singlestep003.cpp Changeset: 727ab25a4e24 Author: xuelei Date: 2019-03-21 13:32 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/727ab25a4e24 8221270: Duplicated synchronized keywords in SSLSocketImpl Reviewed-by: mullan ! src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java Changeset: 1928a50e7e83 Author: xuelei Date: 2019-03-21 14:18 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/1928a50e7e83 8221273: put sun/security/pkcs11/tls/tls12/TestTLS12.java on ProblemList.txt Reviewed-by: mullan ! test/jdk/ProblemList.txt Changeset: 8478c8c48886 Author: rkennke Date: 2019-03-21 22:37 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/8478c8c48886 8221278: Shenandoah should not enqueue string dedup candidates during root scan Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp Changeset: eed9f74eab87 Author: rkennke Date: 2019-03-15 09:57 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/eed9f74eab87 8220714: C2 Compilation failure when accessing off-heap memory using Unsafe Reviewed-by: vlivanov, roland ! src/hotspot/share/opto/library_call.cpp + test/hotspot/jtreg/gc/shenandoah/compiler/TestUnsafeOffheapSwap.java Changeset: ed34367d4e9f Author: ngasson Date: 2019-03-22 03:04 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/ed34367d4e9f 8220451: jdi/EventQueue/remove/remove004 failed due to "ERROR: thread2 is not alive" 8220456: jdi/EventQueue/remove_l/remove_l004 failed due to "TIMEOUT while waiting for event" Reviewed-by: sspitsyn, dcubed, gadams ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove/remove004/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jdi/EventQueue/remove_l/remove_l004/TestDescription.java Changeset: fce15a3c1922 Author: clanger Date: 2019-03-22 08:56 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/fce15a3c1922 8200286: (testbug) MOptionTest test fails with java.lang.AssertionError: Classfiles too old! Reviewed-by: stuefe, jjg ! test/langtools/tools/javac/modules/MOptionTest.java Changeset: 17da5f618aaf Author: akolarkunnu Date: 2019-02-26 03:24 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/17da5f618aaf 8211322: Reduce the timeout of tooltip in SwingSet2DemoTest Reviewed-by: serb, shurailine Contributed-by: gauri.patil at oracle.com ! test/jdk/sanity/client/SwingSet/src/SwingSet2DemoTest.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JToolTipOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/version_info Changeset: a17f46493e0b Author: dmarkov Date: 2019-02-26 18:12 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/a17f46493e0b 8214109: XToolkit is not correctly displayed color on 16-bit high color setting Reviewed-by: serb, prr ! src/java.desktop/unix/classes/sun/awt/X11/XWindow.java Changeset: 6673d2b7e084 Author: psadhukhan Date: 2019-02-27 14:48 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/6673d2b7e084 Merge - src/java.smartcardio/unix/native/libj2pcsc/MUSCLE/COPYING - src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StripDebugPlugin.java - test/jdk/tools/jlink/plugins/StripDebugPluginTest.java Changeset: d9d9655bb077 Author: prr Date: 2019-02-27 14:30 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/d9d9655bb077 Merge Changeset: e4813eded7cb Author: serb Date: 2019-02-27 18:46 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/e4813eded7cb 8213110: Remove the use of applets in automatic tests Reviewed-by: prr ! test/jdk/ProblemList.txt - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html ! test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.java - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html ! test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.java - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html ! test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.java - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html ! test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.java ! test/jdk/java/awt/ComponentOrientation/BorderTest.java ! test/jdk/java/awt/ComponentOrientation/FlowTest.java - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html ! test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.java - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html ! test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java ! test/jdk/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowBlockingTest.java ! test/jdk/java/awt/Focus/ActualFocusedWindowTest/ActualFocusedWindowRetaining.java - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html ! test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.java - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html ! test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java ! test/jdk/java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusSetVisibleTest.java ! test/jdk/java/awt/Focus/AutoRequestFocusTest/AutoRequestFocusToFrontTest.java - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html ! test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.java ! test/jdk/java/awt/Focus/ClearLwQueueBreakTest/ClearLwQueueBreakTest.java ! test/jdk/java/awt/Focus/CloseDialogActivateOwnerTest/CloseDialogActivateOwnerTest.java ! test/jdk/java/awt/Focus/ConsumeNextKeyTypedOnModalShowTest/ConsumeNextKeyTypedOnModalShowTest.java ! test/jdk/java/awt/Focus/ContainerFocusAutoTransferTest/ContainerFocusAutoTransferTest.java - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html ! test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.java ! test/jdk/java/awt/Focus/FocusEmbeddedFrameTest/FocusEmbeddedFrameTest.java ! test/jdk/java/awt/Focus/FocusOwnerFrameOnClick/FocusOwnerFrameOnClick.java - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html ! test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.java ! test/jdk/java/awt/Focus/FrameJumpingToMouse/FrameJumpingToMouse.java ! test/jdk/java/awt/Focus/IconifiedFrameFocusChangeTest/IconifiedFrameFocusChangeTest.java - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html ! test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.java - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html ! test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.java - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html ! test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.java ! test/jdk/java/awt/Focus/NoAutotransferToDisabledCompTest/NoAutotransferToDisabledCompTest.java - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html ! test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.java ! test/jdk/java/awt/Focus/NonFocusableWindowTest/NonfocusableOwnerTest.java ! test/jdk/java/awt/Focus/RequestFocusToDisabledCompTest/RequestFocusToDisabledCompTest.java ! test/jdk/java/awt/Focus/ResetMostRecentFocusOwnerTest/ResetMostRecentFocusOwnerTest.java ! test/jdk/java/awt/Focus/RestoreFocusOnDisabledComponentTest/RestoreFocusOnDisabledComponentTest.java ! test/jdk/java/awt/Focus/ShowFrameCheckForegroundTest/ShowFrameCheckForegroundTest.java - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html ! test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.java - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html ! test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.java - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html ! test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.java ! test/jdk/java/awt/Focus/WrongKeyTypedConsumedTest/WrongKeyTypedConsumedTest.java ! test/jdk/java/awt/FontClass/CreateFont/BigFont.java - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html ! test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.java - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html ! test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.java ! test/jdk/java/awt/FullScreen/SetFSWindow/FSFrame.java - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html ! test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html ! test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.java - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html ! test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.java - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html ! test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.java - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html ! test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.java - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html ! test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.java - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html ! test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.java - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html ! test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.java - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html ! test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.java - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html ! test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.java - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html ! test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.java - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html ! test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.java - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html ! test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.java - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html ! test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.java - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.java - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html ! test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.java - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html ! test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.java - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html ! test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html ! test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.java - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.java - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html ! test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.java - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html ! test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.java - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html ! test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.java - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html ! test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.java - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html ! test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.java - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html ! test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.java - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html ! test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.java - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html ! test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.java - test/jdk/javax/imageio/AppletResourceTest.html ! test/jdk/javax/imageio/AppletResourceTest.java - test/jdk/javax/swing/JFrame/4962534/bug4962534.html ! test/jdk/javax/swing/JFrame/4962534/bug4962534.java - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html ! test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.java - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html ! test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.java - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html ! test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.java - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html ! test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.java Changeset: 7c11a7cc7c1d Author: prr Date: 2019-03-01 16:59 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/7c11a7cc7c1d 8210782: Upgrade HarfBuzz to the latest 2.3.1 Reviewed-by: serb, ihse, erikj ! make/lib/Awt2dLibraries.gmk ! src/java.desktop/share/legal/harfbuzz.md + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-fdsc-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-ankr-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-bsln-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-feat-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-just-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-kerx-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-lcar-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-morx-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout-trak-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-layout.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-ltag-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat-map.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-aat.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-array.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-json.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-deserialize-text.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-serialize.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-cs-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff-interp-dict-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff1-interp-cs.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-cff2-interp-cs.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-common.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-coretext.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-debug.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-deprecated.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-dsalgs.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-fallback-shape.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ft.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-iter.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-kern.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-machinery.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-null.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff1-table.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff1-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff2-table.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cff2-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-cmap-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cbdt-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-colr-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-cpal-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-sbix-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color-svg-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-color.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-deprecated.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-face.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-face.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-font.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-gasp-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-glyf-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hdmx-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-head-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hhea-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-hmtx-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-kern-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-base-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gdef-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gpos-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsub-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-jstf-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-math-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-math.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-maxp-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-language.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-language.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-name.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-os2-unicode-ranges.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-macroman.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-post-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-fallback.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-win1256.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-default.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hangul.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-hebrew.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-table.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-thai.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-machine.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-table.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-vowel-constraints.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-vowel-constraints.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-stat-table.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-avar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-fvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-hvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var-mvar-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-var.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-vorg-table.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-list.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-static.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-string-array.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff-common.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff-common.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff1.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff1.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff2.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-cff2.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-glyf.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-input.cc + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-input.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-plan.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ucdn/ucdn.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-emoji-table.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf.hh + src/java.desktop/share/native/libfontmanager/harfbuzz/hb-vector.hh ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-version.h ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb-warning.cc ! src/java.desktop/share/native/libfontmanager/harfbuzz/hb.h + src/java.desktop/share/native/libfontmanager/harfbuzz/hb.hh ! src/java.desktop/share/native/libfontmanager/hb-jdk-font.cc Changeset: 9413f1a4dc2b Author: serb Date: 2019-03-04 01:44 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/9413f1a4dc2b 8061381: [macosx] Accelerators does not spelled for JMenuItems by Voice Over Reviewed-by: prr, kaddepalli ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java ! src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java Changeset: 6b2f2ec0f618 Author: pbansal Date: 2019-03-05 13:09 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/6b2f2ec0f618 8214253: Tooltip is transparent rather than having a black background Reviewed-by: serb, psadhukhan ! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c Changeset: 63946f20c24f Author: pbansal Date: 2019-03-05 14:03 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/63946f20c24f 8214112: The whole text in target JPasswordField image are not selected Reviewed-by: serb, psadhukhan ! src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c Changeset: a5af6175d62b Author: kaddepalli Date: 2019-03-07 12:51 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/a5af6175d62b 8218674: HTML Tooltip with "img=src" on component doesn't show Reviewed-by: serb, psadhukhan ! src/java.desktop/share/classes/javax/swing/text/html/ImageView.java + test/jdk/javax/swing/text/html/8218674/TooltipImageTest.java + test/jdk/javax/swing/text/html/8218674/circle.png Changeset: 7d5e595cb7aa Author: psadhukhan Date: 2019-03-08 14:07 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/7d5e595cb7aa 8215396: JTabbedPane preferred size calculation is wrong for SCROLL_TAB_LAYOUT Reviewed-by: serb ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTabbedPaneUI.java + test/jdk/javax/swing/JTabbedPane/TabProb.java Changeset: 371d29d4add5 Author: serb Date: 2019-03-09 14:48 -0800 URL: http://hg.openjdk.java.net/amber/amber/rev/371d29d4add5 8219504: Test for JDK-8211435 can be run on all platforms Reviewed-by: kaddepalli, dmarkov, sveerabhadra ! test/jdk/java/awt/Focus/NullActiveWindowOnFocusLost/NullActiveWindowOnFocusLost.java Changeset: 0804f29e8be7 Author: mbalao Date: 2019-03-01 12:21 -0300 URL: http://hg.openjdk.java.net/amber/amber/rev/0804f29e8be7 8218854: FontMetrics.getMaxAdvance may be less than the maximum FontMetrics.charWidth Summary: Consider algorithmic bold in FontMetrics.getMaxAdvance value and update obliqueness. Reviewed-by: prr, serb ! src/java.desktop/share/native/libfontmanager/freetypeScaler.c + test/jdk/java/awt/FontMetrics/MaxAdvanceIsMax.java Changeset: 5294813fe931 Author: vagarwal Date: 2019-03-13 00:04 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/5294813fe931 8219552: bump jtreg requiredVersion to b14 in test/jdk/sanity/client/ Reviewed-by: prr, iignatyev ! test/jdk/TEST.ROOT ! test/jdk/sanity/client/README ! test/jdk/sanity/client/SwingSet/src/ButtonDemoScreenshotTest.java ! test/jdk/sanity/client/SwingSet/src/EditorPaneDemoTest.java - test/jdk/sanity/client/TEST.ROOT.template ! test/jdk/sanity/client/TEST.properties Changeset: 3c369ad8c4ac Author: vagarwal Date: 2019-03-13 00:51 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/3c369ad8c4ac 8216353: Use utility APIs introduced in org/netbeans/jemmy/util/LookAndFeel class in client sanity test cases Reviewed-by: serb ! test/jdk/sanity/client/SwingSet/src/FileChooserDemoTest.java ! test/jdk/sanity/client/SwingSet/src/SliderDemoTest.java ! test/jdk/sanity/client/SwingSet/src/SplitPaneDemoTest.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/drivers/DefaultDriverInstaller.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JFileChooserOperator.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/operators/JInternalFrameOperator.java + test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/util/LookAndFeel.java ! test/jdk/sanity/client/lib/jemmy/src/org/netbeans/jemmy/version_info Changeset: 132590e72765 Author: serb Date: 2019-03-16 17:50 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/132590e72765 7106851: Test should not use System.exit Reviewed-by: aivanov, psadhukhan, kaddepalli + test/jdk/javax/accessibility/6192422/bug6192422.java Changeset: 0b9fb3cfb6f2 Author: prr Date: 2019-03-18 14:55 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/0b9fb3cfb6f2 8218914: Support fonts installed per-user on Windows 10 Reviewed-by: prr, serb Contributed-by: Mikhail Filippov ! src/java.desktop/windows/native/libfontmanager/fontpath.c Changeset: 3ee03f1d88c9 Author: psadhukhan Date: 2019-03-20 16:07 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/3ee03f1d88c9 Merge - make/devkit/createMacosxDevkit6.sh - make/devkit/createMacosxDevkit9.sh - make/devkit/createWindowsDevkit2013.sh - make/devkit/createWindowsDevkit2015.sh - src/hotspot/os_cpu/linux_aarch64/linux_aarch64.ad - src/hotspot/os_cpu/linux_sparc/linux_sparc.ad - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/classfile/dictionary.inline.hpp - src/hotspot/share/gc/z/zAddressRangeMap.hpp - src/hotspot/share/gc/z/zAddressRangeMap.inline.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/hotspot/share/prims/evmCompat.cpp - src/hotspot/share/utilities/intHisto.cpp - src/hotspot/share/utilities/intHisto.hpp - src/java.base/share/classes/com/sun/net/ssl/HostnameVerifier.java - src/java.base/share/classes/com/sun/net/ssl/HttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/KeyManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLContext.java - src/java.base/share/classes/com/sun/net/ssl/SSLContextSpi.java - src/java.base/share/classes/com/sun/net/ssl/SSLPermission.java - src/java.base/share/classes/com/sun/net/ssl/SSLSecurity.java - src/java.base/share/classes/com/sun/net/ssl/TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactory.java - src/java.base/share/classes/com/sun/net/ssl/TrustManagerFactorySpi.java - src/java.base/share/classes/com/sun/net/ssl/X509KeyManager.java - src/java.base/share/classes/com/sun/net/ssl/X509TrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/Provider.java - src/java.base/share/classes/com/sun/net/ssl/internal/ssl/X509ExtendedTrustManager.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/Handler.java - src/java.base/share/classes/com/sun/net/ssl/internal/www/protocol/https/HttpsURLConnectionOldImpl.java - src/java.base/share/classes/com/sun/net/ssl/package-info.java - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/BaseStructure.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/Marshaller.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriter.java - src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/XmlWriterToTree.java - src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/gc/z/ZAddressRangeMapForPageTable.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotMaths.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ArrayRangePreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PostWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1PreWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/G1ReferentFieldReadBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/ObjectWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialArrayRangeWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/nodes/SerialWriteBarrier.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/IntegerExactOpSpeculation.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ConvertDeoptimizeToGuardPhase.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.amd64/src/org/graalvm/compiler/replacements/amd64/AMD64MathSubstitutions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/arithmetic/IntegerMulHighNode.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlConstants.java - src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlVersion.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/gtest/memory/test_virtualSpaceNode.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/serviceability/jvmti/HeapMonitor/libHeapMonitorTest.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf ! test/jdk/ProblemList.txt ! test/jdk/TEST.ROOT - test/jdk/com/sun/net/ssl/SSLSecurity/ComKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ComTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxKeyManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxSSLContextImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/JavaxTrustManagerFactoryImpl.java - test/jdk/com/sun/net/ssl/SSLSecurity/ProviderTest.java - test/jdk/com/sun/net/ssl/SSLSecurity/TruncateArray.java - test/jdk/javax/net/ssl/FixingJavadocs/ComURLNulls.java - test/jdk/javax/net/ssl/SSLSession/CheckMyTrustedKeystore.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHTTPSConnection.java - test/jdk/sun/net/www/protocol/https/NewImpl/ComHostnameVerifier.java - test/jdk/sun/security/ssl/X509TrustManagerImpl/ClientServer.java - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java - test/langtools/jdk/javadoc/tool/doclint/ImplicitHeadersTest.java - test/langtools/jdk/javadoc/tool/removeOldDoclet/OldDoclet.jasm - test/langtools/tools/javac/doclint/ImplicitHeadersTest.java Changeset: 96c45aa61056 Author: psadhukhan Date: 2019-03-22 13:42 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/96c45aa61056 Merge - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt ! test/jdk/ProblemList.txt Changeset: f04e3492fd88 Author: alanb Date: 2019-03-22 11:35 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/f04e3492fd88 8221252: (sc) SocketChannel and its socket adaptor need to handle connection reset Reviewed-by: bpb ! src/java.base/share/classes/sun/nio/ch/IOStatus.java ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/share/classes/sun/nio/ch/SocketAdaptor.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/java.base/unix/classes/sun/nio/ch/SocketDispatcher.java ! src/java.base/unix/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! src/java.base/unix/native/libnio/ch/Net.c + src/java.base/unix/native/libnio/ch/SocketDispatcher.c ! src/java.base/windows/classes/sun/nio/ch/SocketDispatcher.java ! src/java.base/windows/native/libnio/ch/Net.c ! src/java.base/windows/native/libnio/ch/SocketDispatcher.c ! src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java + test/jdk/java/nio/channels/SocketChannel/ConnectionReset.java Changeset: 3e7fccdb6181 Author: pliden Date: 2019-03-22 12:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/3e7fccdb6181 8221212: ZGC: Command-line flags should be marked experimental Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/z_globals.hpp Changeset: b9cd87da3211 Author: pliden Date: 2019-03-22 12:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/b9cd87da3211 8221219: ZGC: Remove ZStallOnOutOfMemory option Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zObjectAllocator.cpp ! src/hotspot/share/gc/z/z_globals.hpp Changeset: 931247e90857 Author: dbuck Date: 2019-03-22 09:05 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/931247e90857 8217564: idempotent protection missing in crc32c.h Summary: added include guard to crc32c.h Reviewed-by: dcubed ! src/hotspot/cpu/x86/crc32c.h Changeset: 601326fead41 Author: erikj Date: 2019-03-22 08:14 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/601326fead41 8221179: Zero builds fail when linking with gold and bundling libffi.so Reviewed-by: sgehwolf, tbell ! make/hotspot/lib/JvmFeatures.gmk Changeset: 51195881bd3a Author: bpb Date: 2019-03-22 08:18 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/51195881bd3a 8078860: (spec) InputStream.read(byte[] b, int off, int len) claims to not affect element b[off] Reviewed-by: lancea, darcy, rriggs ! src/java.base/share/classes/java/io/InputStream.java Changeset: 83deaa8f0c8e Author: naoto Date: 2019-03-22 09:31 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/83deaa8f0c8e 8220224: With CLDR provider, NumberFormat.format could not handle locale with number extension correctly. Reviewed-by: darcy ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! src/java.base/share/classes/java/text/DecimalFormat.java ! src/java.base/share/classes/java/text/DecimalFormatSymbols.java + test/jdk/java/text/Format/NumberFormat/DFSMinusPerCentMill.java Changeset: 01d8eae542ff Author: xuelei Date: 2019-03-22 13:47 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/01d8eae542ff 8218889: Improperly use of the Optional API Reviewed-by: jnimeh, wetmore ! src/java.base/share/classes/sun/security/ssl/NewSessionTicket.java ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java ! src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java ! src/java.base/share/classes/sun/security/ssl/ServerHello.java Changeset: a2956337451b Author: coleenp Date: 2019-03-22 16:16 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/a2956337451b 8218399: runtime/RedefineObject/TestRedefineObject.java timeout Summary: exclude this test for graal Reviewed-by: hseigel, lfoltan ! test/hotspot/jtreg/ProblemList-graal.txt ! test/hotspot/jtreg/serviceability/jvmti/RedefineClasses/TestRedefineObject.java Changeset: c81fbf340ceb Author: kbarrett Date: 2019-03-22 15:42 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/c81fbf340ceb 8220240: Refactor shared dirty card queue Summary: Add G1SharedDirtyCardQueue class. Reviewed-by: tschatzl, lkorinth ! src/hotspot/share/gc/g1/g1BarrierSet.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.cpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp + src/hotspot/share/gc/g1/g1SharedDirtyCardQueue.cpp + src/hotspot/share/gc/g1/g1SharedDirtyCardQueue.hpp ! src/hotspot/share/gc/shared/ptrQueue.cpp ! src/hotspot/share/gc/shared/ptrQueue.hpp ! src/hotspot/share/gc/shared/satbMarkQueue.cpp ! src/hotspot/share/gc/shared/satbMarkQueue.hpp Changeset: aa937fac07f3 Author: shade Date: 2019-03-23 17:18 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/aa937fac07f3 8221363: Build failure after JDK-8220240 (Refactor shared dirty card queue) Reviewed-by: stuefe ! src/hotspot/share/gc/shenandoah/shenandoahSATBMarkQueueSet.hpp Changeset: 21702e87efdf Author: iklam Date: 2019-03-23 21:51 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/21702e87efdf 8220095: Assertion failure when symlink (with different name) is used for lib/modules file Summary: Removed confusing function ClassLoader::is_modules_image(char*) Reviewed-by: lfoltan, ccheung Contributed-by: Jiangli Zhou ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/classFileStream.cpp ! src/hotspot/share/classfile/classFileStream.hpp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/classfile/classLoader.hpp ! src/hotspot/share/oops/instanceKlass.cpp + test/hotspot/jtreg/runtime/modules/ModulesSymLink.java Changeset: 0db90e99f13b Author: qpzhang Date: 2019-03-21 16:45 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/0db90e99f13b 8221220: AArch64: Add StoreStore membar explicitly for Volatile Writes in TemplateTable Reviewed-by: aph ! src/hotspot/cpu/aarch64/templateTable_aarch64.cpp Changeset: d25b24c70126 Author: dholmes Date: 2019-03-25 00:57 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/d25b24c70126 8221207: Redo JDK-8218446 - SuspendAtExit hangs Reviewed-by: rehn, dcubed ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp Changeset: bb8828626944 Author: gadams Date: 2019-03-25 07:31 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/bb8828626944 8221164: jstatLineCounts tests need to be more resilient for NaN outputs Reviewed-by: cjplummer, phh, jcbeyler ! test/jdk/sun/tools/jstat/lineCounts3.awk ! test/jdk/sun/tools/jstat/lineCounts4.awk Changeset: b1605a40e336 Author: gadams Date: 2019-03-25 08:37 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/b1605a40e336 8220295: sun/tools/jps/TestJps.java still timing out Reviewed-by: cjplummer, jcbeyler ! test/jdk/TEST.ROOT Changeset: 1f9ad92e337b Author: tschatzl Date: 2019-03-25 14:11 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/1f9ad92e337b 8219100: Improve do_collection_pause_at_safepoint Reviewed-by: kbarrett, sangheki ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1Policy.hpp ! test/hotspot/jtreg/gc/g1/TestVerifyGCType.java Changeset: 3cabb47758c9 Author: mgronlun Date: 2019-03-25 15:37 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/3cabb47758c9 8217362: Emergency dump does not work when disk=false is set Reviewed-by: egahlin, ysuenaga Contributed-by: yasuenag at gmail.com ! src/hotspot/share/jfr/recorder/repository/jfrChunkWriter.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.hpp ! src/hotspot/share/jfr/recorder/repository/jfrRepository.cpp ! test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java Changeset: 41af8d0546bc Author: lkorinth Date: 2019-03-25 14:46 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/41af8d0546bc 8221260: Initialize more class members on construction, remove some unused ones Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp ! src/hotspot/share/gc/parallel/adjoiningGenerations.cpp ! src/hotspot/share/gc/parallel/adjoiningGenerations.hpp ! src/hotspot/share/gc/parallel/gcTaskThread.cpp ! src/hotspot/share/gc/parallel/gcTaskThread.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.cpp ! src/hotspot/share/gc/parallel/psAdaptiveSizePolicy.hpp ! src/hotspot/share/gc/parallel/psFileBackedVirtualspace.cpp ! src/hotspot/share/gc/parallel/psFileBackedVirtualspace.hpp ! src/hotspot/share/gc/parallel/psMarkSweepDecorator.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psVirtualspace.cpp ! src/hotspot/share/gc/parallel/psVirtualspace.hpp ! src/hotspot/share/gc/parallel/psYoungGen.cpp ! src/hotspot/share/gc/shared/adaptiveSizePolicy.cpp ! src/hotspot/share/gc/shared/gcStats.cpp Changeset: 1b0163c877c0 Author: erikj Date: 2019-03-25 09:07 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/1b0163c877c0 8220445: Support for side by side MSVC Toolset versions Reviewed-by: tbell Contributed-by: ali.ince at gmail.com, erik.joelsson at oracle.com ! make/autoconf/toolchain_windows.m4 Changeset: 7816d989bf21 Author: dpochepk Date: 2019-03-25 19:49 +0300 URL: http://hg.openjdk.java.net/amber/amber/rev/7816d989bf21 8216989: CardTableBarrierSetAssembler::gen_write_ref_array_post_barrier() does not check for zero length on AARCH64 Reviewed-by: adinn ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/cardTableBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shared/modRefBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/shenandoah/shenandoahBarrierSetAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 75445a7c2c04 Author: redestad Date: 2019-03-25 20:57 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/75445a7c2c04 8221343: x86_32 crashes on startup with "_hwm out of range" Reviewed-by: thartmann, kvn ! src/hotspot/share/opto/matcher.cpp Changeset: 0cf2c87ce79a Author: dholmes Date: 2019-03-25 17:29 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/0cf2c87ce79a 8221357: Update test documentation by deleting "cd test && make" Reviewed-by: dholmes, tbell, erikj Contributed-by: Jing Tian ! doc/testing.html ! doc/testing.md Changeset: 418fbdb1b581 Author: gromero Date: 2019-03-25 19:40 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/418fbdb1b581 8221434: Fix typo in lib-x11 autoconf error message about missing headers Reviewed-by: dholmes ! make/autoconf/lib-x11.m4 Changeset: 176e8aec3097 Author: sspitsyn Date: 2019-03-25 19:16 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/176e8aec3097 8146986: JDI: Signature lookups for unprepared classes can take a long time Summary: Do not cache classes if signature is not provided Reviewed-by: sspitsyn, jcbeyler ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java Changeset: 44edf64cb206 Author: darcy Date: 2019-03-25 19:40 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/44edf64cb206 8221264: Refactor and update SourceVersion.latestSupported Reviewed-by: jjg, cushon, martin ! src/java.compiler/share/classes/javax/lang/model/SourceVersion.java Changeset: 85657f4753e4 Author: dtitov Date: 2019-03-26 04:19 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/85657f4753e4 8217827: [Graal] Some vmTestbase/nsk/jvmti/ResourceExhausted tests failing Reviewed-by: cjplummer, jcbeyler, dholmes ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted002/TestDescription.java Changeset: f0490ada4712 Author: clanger Date: 2019-03-26 09:16 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f0490ada4712 8221262: Cleanups in UnixFileSystem/WinNTFileSystem implementation classes Reviewed-by: alanb, igerasim ! src/java.base/unix/classes/java/io/UnixFileSystem.java ! src/java.base/unix/native/libjava/UnixFileSystem_md.c ! src/java.base/windows/classes/java/io/WinNTFileSystem.java Changeset: a7358438d463 Author: redestad Date: 2019-03-26 10:23 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/a7358438d463 8220682: Heap dumping and inspection fails with JDK-8214712 Reviewed-by: jcbeyler, jiangli, sspitsyn ! src/hotspot/share/memory/heapInspection.cpp ! src/hotspot/share/services/heapDumper.cpp Changeset: 5ee30b6991a7 Author: redestad Date: 2018-12-03 16:25 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/5ee30b6991a7 8214712: Archive Attributes$Name.KNOWN_NAMES Reviewed-by: alanb, jiangli ! src/hotspot/share/memory/heapShared.cpp ! src/java.base/share/classes/java/util/jar/Attributes.java Changeset: 5487a925f70d Author: simonis Date: 2019-03-26 11:51 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/5487a925f70d 8221083: [ppc64] Wrong oop compare in C1-generated code Reviewed-by: mdoerr, goetz ! src/hotspot/cpu/ppc/c1_LIRAssembler_ppc.cpp + test/hotspot/jtreg/compiler/codegen/TestOopCmp.java Changeset: f283f6871336 Author: gadams Date: 2019-03-26 07:09 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/f283f6871336 8203026: java.rmi.NoSuchObjectException: no such object in table Reviewed-by: rriggs, sspitsyn ! src/jdk.jstatd/share/classes/sun/tools/jstatd/Jstatd.java ! src/jdk.jstatd/share/classes/sun/tools/jstatd/RemoteHostImpl.java Changeset: 16999bd91ba6 Author: rehn Date: 2019-03-26 12:08 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/16999bd91ba6 8220774: Add HandshakeALot diag option Reviewed-by: dcubed, dholmes ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/runtime/vmThread.hpp ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/runtime/Thread/SuspendAtExit.java + test/hotspot/jtreg/runtime/handshake/HandshakeSuspendExitTest.java ! test/hotspot/jtreg/runtime/handshake/HandshakeTransitionTest.java - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java Changeset: 368757835b97 Author: gadams Date: 2019-03-26 07:24 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/368757835b97 8218128: vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003 and 004 use wrong path to test classes Reviewed-by: cjplummer, dholmes, lmesnik ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003.java + test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TEST.properties ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted003/TestDescription.java ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted004/TestDescription.java Changeset: a33c42262338 Author: rschmelter Date: 2019-03-22 04:47 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/a33c42262338 8220570: Additonal trace when native thread creation fails Summary: Added additonal trace when native thread creation fails Reviewed-by: dholmes, goetz ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/solaris/os_solaris.cpp ! src/hotspot/os/windows/os_windows.cpp Changeset: ca554363aed3 Author: weijun Date: 2019-03-26 21:33 +0800 URL: http://hg.openjdk.java.net/amber/amber/rev/ca554363aed3 8217690: Update public suffix version Reviewed-by: mullan ! make/data/publicsuffixlist/VERSION ! make/data/publicsuffixlist/public_suffix_list.dat Changeset: 6ddb9e3f1654 Author: rehn Date: 2019-03-26 14:49 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/6ddb9e3f1654 8221472: Fix HandshakeSuspendExitTest Reviewed-by: dcubed, redestad ! test/hotspot/jtreg/runtime/handshake/HandshakeSuspendExitTest.java Changeset: e61065c08924 Author: gromero Date: 2019-03-20 16:59 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/e61065c08924 8220794: PPC64: Fix signal handler for SIGSEGV on branch to illegal address Reviewed-by: stuefe, goetz ! src/hotspot/os_cpu/linux_ppc/os_linux_ppc.cpp Changeset: a2897fb258f1 Author: gromero Date: 2019-03-20 16:43 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/a2897fb258f1 8221175: Fix bad function case for controlled JVM crash on PPC64 big-endian Reviewed-by: chrisphi, stuefe, goetz ! src/hotspot/share/utilities/vmError.cpp Changeset: 33f0b34c9dd7 Author: redestad Date: 2019-03-26 15:20 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/33f0b34c9dd7 8221473: Configuration::reads can use Set.copyOf Reviewed-by: alanb, forax ! src/java.base/share/classes/java/lang/module/Configuration.java Changeset: 6640fd9196d9 Author: stuefe Date: 2019-03-26 15:46 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/6640fd9196d9 8221406: Windows 32bit build error in NetworkInterface_winXP.c Reviewed-by: clanger ! src/java.base/windows/native/libnet/NetworkInterface_winXP.c Changeset: c02b8d6384ab Author: stuefe Date: 2019-03-26 15:52 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/c02b8d6384ab 8221407: Windows 32bit build error in libsunmscapi/security.cpp Reviewed-by: clanger ! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp Changeset: c12b897021ea Author: erikj Date: 2019-03-26 09:24 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/c12b897021ea 8221414: Bump required boot jdk version to 12 Reviewed-by: mikael, tbell ! make/autoconf/version-numbers ! make/conf/jib-profiles.js Changeset: 6183f835b9b6 Author: chegar Date: 2019-03-26 17:02 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/6183f835b9b6 8219446: Specify behaviour of timeout accepting methods of Socket and ServerSocket if timeout is negative Reviewed-by: alanb, dfuchs ! src/java.base/share/classes/java/net/ServerSocket.java ! src/java.base/share/classes/java/net/Socket.java ! test/jdk/java/net/Socket/Timeouts.java Changeset: 8af48416e31f Author: simonis Date: 2019-03-26 18:42 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/8af48416e31f 8221483: TestOopCmp.java fails due to "Multiple garbage collectors selected" Reviewed-by: kvn, mdoerr ! test/hotspot/jtreg/compiler/codegen/TestOopCmp.java Changeset: e6c86f6012bf Author: dcubed Date: 2019-03-26 15:27 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/e6c86f6012bf 8221350: more monitor logging updates from Async Monitor Deflation project Reviewed-by: dholmes, coleenp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: c31faeacf00a Author: zgu Date: 2019-03-26 15:50 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/c31faeacf00a 8204552: NMT: Separate thread stack tracking from virtual memory tracking Reviewed-by: stuefe, minqi ! make/hotspot/lib/JvmFeatures.gmk ! src/hotspot/share/services/memBaseline.cpp ! src/hotspot/share/services/memReporter.cpp ! src/hotspot/share/services/memTracker.cpp ! src/hotspot/share/services/memTracker.hpp + src/hotspot/share/services/threadStackTracker.cpp + src/hotspot/share/services/threadStackTracker.hpp ! src/hotspot/share/services/virtualMemoryTracker.cpp Changeset: dae71635cc3a Author: mseledtsov Date: 2019-03-26 13:25 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/dae71635cc3a 8221342: [TESTBUG] Generate Dockerfile for docker testing Summary: Dockerfile is generated; introduced properties to specify custom base image Reviewed-by: sgehwolf, dholmes, jiefu - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x ! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java + test/lib/jdk/test/lib/containers/docker/DockerfileConfig.java Changeset: add0810ec2fa Author: sspitsyn Date: 2019-03-26 14:43 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/add0810ec2fa 8221513: Add vmTestbase/nsk/jdb/eval/eval001/eval001.java to ProblemList.txt Summary: Add test to the ProblemList.txt Reviewed-by: dcubed ! test/hotspot/jtreg/ProblemList.txt Changeset: 49c4b23d8d0a Author: afarley Date: 2019-03-26 15:53 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/49c4b23d8d0a 8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields Reviewed-by: mchung ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! test/jdk/java/lang/invoke/MethodHandlesGeneralTest.java ! test/jdk/java/lang/invoke/MethodHandlesTest.java ! test/jdk/java/lang/invoke/VarHandles/accessibility/TestFieldLookupAccessibility.java Changeset: dc66ada06693 Author: cushon Date: 2019-03-26 15:36 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/dc66ada06693 8220633: Optimize CacheFSInfo Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/CacheFSInfo.java Changeset: f98f158c1db8 Author: iklam Date: 2019-03-26 11:34 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/f98f158c1db8 8217347: [TESTBUG] runtime/appcds/jvmti/InstrumentationTest.java timed out Summary: Avoid using VirtualMachine.list(). Use Process.pid() instead. Reviewed-by: dholmes ! test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationApp.java ! test/hotspot/jtreg/runtime/appcds/jvmti/InstrumentationTest.java Changeset: 6207397a6603 Author: cushon Date: 2019-03-26 15:00 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/6207397a6603 8220687: Add StandardJavaFileManager.getJavaFileObjectsFromPaths overload Reviewed-by: jjg ! src/java.compiler/share/classes/javax/tools/StandardJavaFileManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/ClientCodeWrapper.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/main/DelegatingJavaFileManager.java ! test/langtools/tools/javac/api/file/SJFM_GetFileObjects.java Changeset: 656789f95658 Author: ghaug Date: 2019-03-26 16:00 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/656789f95658 8221479: Fix JFR profiling on s390 Reviewed-by: mdoerr, clanger ! src/hotspot/os_cpu/linux_s390/thread_linux_s390.cpp Changeset: 1b85f55c9aa2 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/1b85f55c9aa2 8221396: Clean up serviceability/sa/TestUniverse.java Reviewed-by: stefank, jcbeyler ! test/hotspot/jtreg/serviceability/sa/TestUniverse.java Changeset: 2f522c487791 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/2f522c487791 8221392: Reduce ConcurrentGCThreads spinning during start up Reviewed-by: eosterlund, kbarrett ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/init.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp Changeset: 0a2d73e02076 Author: pliden Date: 2019-03-27 10:38 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/0a2d73e02076 8221537: ZGC: Fix incorrect comment in zNMethod table entry layout Reviewed-by: stefank ! src/hotspot/share/gc/z/zNMethodTableEntry.hpp Changeset: 3022f7d70897 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/3022f7d70897 8220198: Lots of com/sun/crypto/provider/Cipher tests fail on x86_32 due to missing SHA512 stubs Reviewed-by: kvn, thartmann ! src/hotspot/cpu/x86/vm_version_x86.cpp ! src/hotspot/share/opto/graphKit.cpp ! src/hotspot/share/opto/library_call.cpp Changeset: 78f88c4423a4 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/78f88c4423a4 8221400: java/lang/String/StringRepeat.java test requests too much heap Reviewed-by: stuefe, alanb ! test/jdk/java/lang/String/StringRepeat.java Changeset: 848859723503 Author: shade Date: 2019-03-27 11:35 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/848859723503 8221401: java/math/BigInteger/LargeValueExceptions.java test should be disabled on 32-bit platforms Reviewed-by: stuefe, bpb ! test/jdk/java/math/BigInteger/LargeValueExceptions.java Changeset: 828c4889adfc Author: shade Date: 2019-03-27 12:38 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/828c4889adfc 8221524: java/util/Base64/TestEncodingDecodingLength.java test should be disabled on 32-bit platforms Reviewed-by: stuefe, alanb ! test/jdk/java/util/Base64/TestEncodingDecodingLength.java Changeset: df62ea1da6ad Author: rraghavan Date: 2019-03-27 18:33 +0530 URL: http://hg.openjdk.java.net/amber/amber/rev/df62ea1da6ad 8219612: compiler.codecache.stress.Helper.TestCaseImpl can't be defined in different runtime package as its nest host Summary: Test rewritten to use top level classes rather then nested ones Reviewed-by: iignatyev, kvn, thartmann ! test/hotspot/jtreg/compiler/codecache/stress/Helper.java ! test/hotspot/jtreg/compiler/codecache/stress/RandomAllocationTest.java ! test/hotspot/jtreg/compiler/codecache/stress/ReturnBlobToWrongHeapTest.java + test/hotspot/jtreg/compiler/codecache/stress/TestCaseImpl.java ! test/hotspot/jtreg/compiler/codecache/stress/UnexpectedDeoptimizationTest.java Changeset: 1dcacbe612ae Author: hseigel Date: 2019-03-27 09:29 -0400 URL: http://hg.openjdk.java.net/amber/amber/rev/1dcacbe612ae 8059357: ClassVerifier redundantly checks constant pool entries multiple times Summary: Store translated signature verificationTypes in a hashtable where they can be fetched, instead of having to re-translating the signatures Reviewed-by: iklam, coleenp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp Changeset: c4c225b49c5f Author: bpb Date: 2019-03-27 07:21 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/c4c225b49c5f 8219196: DataOutputStream.writeUTF may throw unexpected exceptions Reviewed-by: martin, darcy, rriggs Contributed-by: Martin Buchholz ! src/java.base/share/classes/java/io/DataOutputStream.java ! test/jdk/java/io/DataOutputStream/WriteUTF.java Changeset: 646c54d5989b Author: mseledtsov Date: 2019-03-27 08:38 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/646c54d5989b 8221527: [TESTBUG] DockerBasicTest.java contains hard-coded reference to JDK 10 Summary: Using Docker test library to get the image name Reviewed-by: dholmes ! test/hotspot/jtreg/runtime/containers/docker/DockerBasicTest.java Changeset: 3fedbfdb25b6 Author: pliden Date: 2019-03-27 18:30 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/3fedbfdb25b6 8221456: nmethod::make_unloaded() clears _method member too early Reviewed-by: eosterlund, thartmann ! src/hotspot/share/code/nmethod.cpp Changeset: 0223b7b8a1c5 Author: simonis Date: 2019-03-27 19:47 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/0223b7b8a1c5 8220528: [AIX] Fix basic Xinerama and Xrender functionality Reviewed-by: clanger, stuefe, serb ! src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c Changeset: 440cbcf3b268 Author: bpb Date: 2019-03-27 13:00 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/440cbcf3b268 8221531: Incorrect copyright header in src/java.base/windows/native/libnio/ch/FileChannelImpl.c Reviewed-by: lancea, bchristi ! src/java.base/windows/native/libnio/ch/FileChannelImpl.c Changeset: 46cf212cdcca Author: aeubanks Date: 2019-03-27 09:06 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/46cf212cdcca 8220575: Replace hardcoded 127.0.0.1 in URLs with new URI builder Reviewed-by: dfuchs, chegar Contributed-by: aeubanks at google.com ! test/jdk/com/sun/net/httpserver/TestLogging.java ! test/jdk/com/sun/net/httpserver/bugs/6725892/Test.java ! test/jdk/com/sun/net/httpserver/bugs/B6373555.java ! test/jdk/com/sun/net/httpserver/bugs/B6401598.java ! test/jdk/java/net/HttpCookie/ExpiredCookieTest.java ! test/jdk/java/net/HttpURLConnection/NoProxyTest.java ! test/jdk/java/net/ProxySelector/NullSelector.java ! test/jdk/java/net/ResponseCache/Test2.java ! test/jdk/java/net/URLClassLoader/closetest/CloseTest.java ! test/jdk/java/net/URLConnection/TimeoutTest.java ! test/jdk/java/net/URLPermission/OpenURL.java ! test/jdk/java/net/httpclient/AuthSchemesTest.java ! test/jdk/java/net/httpclient/LargeResponseContent.java ! test/jdk/sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java ! test/jdk/sun/net/www/protocol/http/6550798/test.java ! test/jdk/sun/net/www/protocol/http/B6890349.java ! test/jdk/sun/net/www/protocol/http/B8012625.java ! test/jdk/sun/net/www/protocol/http/NoNTLM.java ! test/jdk/sun/net/www/protocol/http/RedirectOnPost.java ! test/jdk/sun/net/www/protocol/http/ResponseCacheStream.java ! test/jdk/sun/net/www/protocol/http/RetryUponTimeout.java ! test/jdk/sun/net/www/protocol/http/SetChunkedStreamingMode.java ! test/jdk/sun/net/www/protocol/http/UserAgent.java ! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressDNSIdentities.java ! test/jdk/sun/net/www/protocol/https/HttpsURLConnection/IPAddressIPIdentities.java + test/lib/jdk/test/lib/net/URIBuilder.java Changeset: 7d5a4a48e876 Author: joehw Date: 2019-03-27 14:40 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/7d5a4a48e876 8221533: Incorrect copyright header in DurationDayTimeImpl.java, DurationYearMonthImpl.java and XMLStreamException.java Reviewed-by: bpb, lancea ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationDayTimeImpl.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/jaxp/datatype/DurationYearMonthImpl.java ! src/java.xml/share/classes/javax/xml/stream/XMLStreamException.java Changeset: f714e4cebceb Author: bpb Date: 2019-03-27 16:35 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/f714e4cebceb 8221568: DataOutputStream/WriteUTF.java fails due to "OutOfMemoryError: Java heap space" Reviewed-by: shade ! test/jdk/java/io/DataOutputStream/WriteUTF.java Changeset: 5b5bd291ca32 Author: jwilhelm Date: 2019-03-28 01:43 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/5b5bd291ca32 Added tag jdk-13+14 for changeset 46cf212cdcca ! .hgtags Changeset: c0037e86ec02 Author: dtitov Date: 2019-03-28 04:26 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/c0037e86ec02 8218727: vmTestbase/nsk/jvmti/scenarios/events/EM04/em04t001/TestDescription.java crash in native library Reviewed-by: sspitsyn, gadams ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM04/em04t001/em04t001.cpp ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/events/EM07/em07t002/em07t002.cpp Changeset: 55025f677f68 Author: dtitov Date: 2019-03-28 04:30 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/55025f677f68 8221532: Incorrect copyright header in FileSystemSupport_md.c Reviewed-by: cjplummer, gadams ! src/java.instrument/unix/native/libinstrument/FileSystemSupport_md.c ! src/java.instrument/windows/native/libinstrument/FileSystemSupport_md.c Changeset: e9618b37f0a5 Author: goetz Date: 2019-03-28 09:15 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/e9618b37f0a5 8221398: Move test NoClassDefFoundMsg.java to subdir exceptionMsgs/ Reviewed-by: coleenp + test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/NoClassDefFoundErrorTest.java + test/hotspot/jtreg/runtime/exceptionMsgs/NoClassDefFoundError/libNoClassDefFoundErrorTest.c - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c Changeset: c9a492ad1aed Author: jlahoda Date: 2019-03-28 10:32 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/c9a492ad1aed 8221413: javac does not recognize variable assigned in switch expression as DA Summary: Fixing definite assignment in presence of implicit throws clause in switch expressions over enums. Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! test/langtools/tools/javac/switchexpr/DefiniteAssignment1.java Changeset: cf75ea6af695 Author: stuefe Date: 2019-03-25 09:35 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/cf75ea6af695 8220786: Create new switch to redirect error reporting output to stdout or stderr Reviewed-by: dholmes, goetz ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/utilities/vmError.cpp + test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileRedirectTest.java Changeset: 846bc643f4ef Author: rehn Date: 2019-03-28 11:08 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/846bc643f4ef 8220351: Cross-modifying code Reviewed-by: rrich, mdoerr, dholmes, eosterlund ! src/hotspot/os_cpu/aix_ppc/orderAccess_aix_ppc.hpp ! src/hotspot/os_cpu/bsd_x86/orderAccess_bsd_x86.hpp ! src/hotspot/os_cpu/bsd_zero/orderAccess_bsd_zero.hpp ! src/hotspot/os_cpu/linux_aarch64/orderAccess_linux_aarch64.hpp ! src/hotspot/os_cpu/linux_arm/orderAccess_linux_arm.hpp ! src/hotspot/os_cpu/linux_ppc/orderAccess_linux_ppc.hpp ! src/hotspot/os_cpu/linux_s390/orderAccess_linux_s390.hpp ! src/hotspot/os_cpu/linux_sparc/orderAccess_linux_sparc.hpp ! src/hotspot/os_cpu/linux_x86/orderAccess_linux_x86.hpp ! src/hotspot/os_cpu/linux_zero/orderAccess_linux_zero.hpp ! src/hotspot/os_cpu/solaris_sparc/orderAccess_solaris_sparc.hpp ! src/hotspot/os_cpu/solaris_x86/orderAccess_solaris_x86.hpp ! src/hotspot/os_cpu/windows_x86/orderAccess_windows_x86.hpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/interfaceSupport.inline.hpp ! src/hotspot/share/runtime/orderAccess.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/safepointMechanism.cpp ! src/hotspot/share/runtime/safepointMechanism.hpp ! src/hotspot/share/runtime/safepointMechanism.inline.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: 9d5c84b0a598 Author: dfuchs Date: 2019-03-28 12:16 +0000 URL: http://hg.openjdk.java.net/amber/amber/rev/9d5c84b0a598 8221395: HttpClient leaving connections in CLOSE_WAIT state until Java process ends Summary: When a non WebSocket connection is not returned to the pool, it needs to be closed even if HttpConnection::isOpen yields false. Reviewed-by: chegar, michaelm ! src/java.net.http/share/classes/jdk/internal/net/http/HttpConnection.java ! test/jdk/java/net/httpclient/whitebox/ConnectionPoolTestDriver.java ! test/jdk/java/net/httpclient/whitebox/java.net.http/jdk/internal/net/http/ConnectionPoolTest.java Changeset: 04f1a0f925db Author: erikj Date: 2019-03-28 08:37 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/04f1a0f925db 8220530: Build compare script does not compare the contents of the test image Reviewed-by: tbell ! make/conf/jib-profiles.js ! make/scripts/compare.sh ! make/scripts/compare_exceptions.sh.incl Changeset: eb7f2c367f73 Author: erikj Date: 2019-03-28 10:04 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/eb7f2c367f73 8205934: Define jdk -source/-target version in version-numbers file Reviewed-by: tbell ! make/autoconf/jdk-version.m4 ! make/autoconf/spec.gmk.in ! make/autoconf/version-numbers ! make/common/SetupJavaCompilers.gmk Changeset: a4d19817609c Author: jcbeyler Date: 2019-03-28 11:06 -0700 URL: http://hg.openjdk.java.net/amber/amber/rev/a4d19817609c 8157372: C2: Node::cmp() should return bool Summary: The method Node::cmp() should return a boolean Reviewed-by: vlivanov, kvn Contributed-by: dthomson at google.com ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.hpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp ! src/hotspot/share/opto/callnode.cpp ! src/hotspot/share/opto/callnode.hpp ! src/hotspot/share/opto/castnode.cpp ! src/hotspot/share/opto/castnode.hpp ! src/hotspot/share/opto/cfgnode.cpp ! src/hotspot/share/opto/cfgnode.hpp ! src/hotspot/share/opto/locknode.cpp ! src/hotspot/share/opto/locknode.hpp ! src/hotspot/share/opto/machnode.cpp ! src/hotspot/share/opto/machnode.hpp ! src/hotspot/share/opto/memnode.cpp ! src/hotspot/share/opto/memnode.hpp ! src/hotspot/share/opto/multnode.cpp ! src/hotspot/share/opto/multnode.hpp ! src/hotspot/share/opto/node.cpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/opaquenode.cpp ! src/hotspot/share/opto/opaquenode.hpp ! src/hotspot/share/opto/subnode.cpp ! src/hotspot/share/opto/subnode.hpp Changeset: 37648a9c4a6a Author: jwilhelm Date: 2019-03-28 19:39 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/37648a9c4a6a 8221341: Update Graal Reviewed-by: kvn ! src/jdk.aot/share/classes/jdk.tools.jaotc/src/jdk/tools/jaotc/DataPatchProcessor.java ! src/jdk.internal.vm.ci/share/classes/module-info.java ! src/jdk.internal.vm.compiler.management/share/classes/org.graalvm.compiler.hotspot.management/src/org/graalvm/compiler/hotspot/management/HotSpotGraalRuntimeMBean.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm.aarch64/src/org/graalvm/compiler/asm/aarch64/AArch64MacroAssembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.asm/src/org/graalvm/compiler/asm/Assembler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.aarch64/src/org/graalvm/compiler/core/aarch64/AArch64LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64.test/src/org/graalvm/compiler/core/amd64/test/AMD64MatchRuleTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.amd64/src/org/graalvm/compiler/core/amd64/AMD64ArithmeticLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/Fields.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/FieldsScanner.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/GraalOptions.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeArrayTypeReader.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeArrayTypeWriter.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.match.processor/src/org/graalvm/compiler/core/match/processor/MatchProcessor.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/CheckGraalInvariants.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/FinalizableSubclassTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/NewInstanceTest.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/SwitchTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/UnbalancedMonitorsTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyBailoutUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyCallerSensitiveMethods.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyDebugUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyFoldableMethods.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyGetOptionsUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyGraphAddUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyInstanceOfUsage.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifySystemPropertyUsage.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyUnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyUpdateUsages.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyUsageWithEquals.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/VerifyVirtualizableUsage.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/ea/EATestBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/tutorial/StaticAnalysis.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.test/src/org/graalvm/compiler/core/test/tutorial/StaticAnalysisTests.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/LIRGenerationPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/NodeLIRBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/gen/NodeMatchRules.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/match/MatchContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/match/MatchPattern.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/match/MatchStatement.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/match/MatchableNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/DebugContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/LogStream.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/MemUseTrackerKey.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.debug/src/org/graalvm/compiler/debug/Versions.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/Edges.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/Node.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/NodeClass.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/NodeSourcePosition.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotBackendFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.aarch64/src/org/graalvm/compiler/hotspot/aarch64/AArch64IndirectCallOp.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64ArrayCompareToStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64ArrayEqualsStub.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotForeignCallsProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotLIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.amd64/src/org/graalvm/compiler/hotspot/amd64/AMD64HotSpotNodeLIRBuilder.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/NodeCostDumpUtil.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot.test/src/org/graalvm/compiler/hotspot/test/StringInternConstantTest.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/BootstrapWatchDog.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationStatistics.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationTask.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/CompilationWatchDog.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfig.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/GraalHotSpotVMConfigBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalCompiler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalCompilerFactory.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotGraalRuntime.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/HotSpotTTYStreamProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/IsGraalPredicate.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/IsGraalPredicateBase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/JVMCIVersionCheck.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/SymbolicSnippetEncoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/debug/BenchmarkCounters.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotNodePlugin.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotObjdumpDisassemblerProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/meta/HotSpotSuitesProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/phases/AheadOfTimeVerificationPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/BytecodeParser.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/FrameStateBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.java/src/org/graalvm/compiler/java/GraphBuilderPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ArithmeticLIRGeneratorTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Call.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Compare.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64ControlFlow.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64MathIntrinsicBinaryOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.aarch64/src/org/graalvm/compiler/lir/aarch64/AArch64Move.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64ArrayIndexOfOp.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64Binary.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir.amd64/src/org/graalvm/compiler/lir/amd64/AMD64BinaryConsumer.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGenerator.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/gen/LIRGeneratorTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/hashing/HashFunction.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.lir/src/org/graalvm/compiler/lir/hashing/Hasher.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/SimplifyingGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/extended/JavaWriteNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderConfiguration.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/GraphBuilderTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/graphbuilderconf/NodePlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/memory/AbstractWriteNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/CoreProviders.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/CoreProvidersImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/LoweringTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.nodes/src/org/graalvm/compiler/nodes/spi/NodeLIRBuilderTool.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.options/src/org/graalvm/compiler/options/OptionsParser.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/LoweringPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/ProfileCompiledMethodsPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases.common/src/org/graalvm/compiler/phases/common/inlining/walker/InliningData.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/VerifyPhase.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/tiers/PhaseContext.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.phases/src/org/graalvm/compiler/phases/util/Providers.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.printer/src/org/graalvm/compiler/printer/CFGPrinterObserver.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.printer/src/org/graalvm/compiler/printer/GraphPrinterDumpHandler.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements.aarch64/src/org/graalvm/compiler/replacements/aarch64/AArch64GraphBuilderPlugins.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/CachingPEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ConstantStringIndexOfSnippets.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/GraphKit.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/InlineDuringParsingPlugin.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/IntrinsicGraphBuilder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/PEGraphDecoder.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/ReplacementsImpl.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/SnippetCounterNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/StandardGraphBuilderPlugins.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/classfile/ClassfileBytecodeProvider.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayCompareToNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/ArrayRegionEqualsNode.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/nodes/MacroNode.java + src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/GraalUnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.serviceprovider/src/org/graalvm/compiler/serviceprovider/JavaVersionUtil.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/EffectsClosure.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.virtual/src/org/graalvm/compiler/virtual/phases/ea/PartialEscapeClosure.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java ! src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/Word.java Changeset: ddd60ad787d4 Author: pliden Date: 2019-03-28 19:43 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/ddd60ad787d4 8221394: Clean up ConcurrentGCThread Reviewed-by: kbarrett, eosterlund ! src/hotspot/share/gc/shared/concurrentGCThread.cpp ! src/hotspot/share/gc/shared/concurrentGCThread.hpp ! src/hotspot/share/runtime/thread.cpp Changeset: 69e80a82db9a Author: pliden Date: 2019-03-28 19:43 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/69e80a82db9a 8221540: ZGC: Reduce width of zForwardingEntry::from_index field Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zForwarding.cpp ! src/hotspot/share/gc/z/zForwarding.inline.hpp ! src/hotspot/share/gc/z/zForwardingEntry.hpp ! src/hotspot/share/gc/z/zRelocate.cpp ! test/hotspot/gtest/gc/z/test_zForwarding.cpp Changeset: f0fec71d2fff Author: pliden Date: 2019-03-28 19:43 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f0fec71d2fff 8221153: ZGC: Heap iteration and verification pollutes GC statistics Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zHeap.cpp ! src/hotspot/share/gc/z/zHeapIterator.cpp ! src/hotspot/share/gc/z/zStat.cpp ! src/hotspot/share/gc/z/zStat.hpp From maurizio.cimadamore at oracle.com Thu Mar 28 21:05:12 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:05:12 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282105.x2SL5D1u017375@aojmv0008.oracle.com> Changeset: f9d570e2ba6a Author: mcimadamore Date: 2019-03-28 22:05 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/f9d570e2ba6a Automatic merge with default - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:05:34 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:05:34 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282105.x2SL5Ypu017708@aojmv0008.oracle.com> Changeset: d50c86358833 Author: mcimadamore Date: 2019-03-28 22:05 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/d50c86358833 Automatic merge with default ! make/autoconf/spec.gmk.in - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp ! src/hotspot/share/classfile/classFileParser.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/hotspot/share/oops/instanceKlass.cpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:06:17 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:06:17 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282106.x2SL6Hvh018424@aojmv0008.oracle.com> Changeset: 806d745ab425 Author: mcimadamore Date: 2019-03-28 22:06 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/806d745ab425 Automatic merge with default - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:07:00 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:07:00 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282107.x2SL70vJ019001@aojmv0008.oracle.com> Changeset: cc1939f0dcc9 Author: mcimadamore Date: 2019-03-28 22:06 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/cc1939f0dcc9 Automatic merge with default - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:08:06 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:08:06 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282108.x2SL86md020286@aojmv0008.oracle.com> Changeset: 759c1c513f95 Author: mcimadamore Date: 2019-03-28 22:07 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/759c1c513f95 Automatic merge with default ! make/CompileJavaModules.gmk - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:08:48 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:08:48 +0000 Subject: hg: amber/amber: Automatic merge with patterns-stage-1 Message-ID: <201903282108.x2SL8niq021639@aojmv0008.oracle.com> Changeset: 2504fec85fe6 Author: mcimadamore Date: 2019-03-28 22:08 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/2504fec85fe6 Automatic merge with patterns-stage-1 ! make/autoconf/spec.gmk.in - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp ! src/hotspot/share/classfile/classFileParser.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/hotspot/share/oops/instanceKlass.cpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseConfiguration.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/TagletManager.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:05:55 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:05:55 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282105.x2SL5u0Z018129@aojmv0008.oracle.com> Changeset: 5a7bfdbcb1a5 Author: mcimadamore Date: 2019-03-28 22:05 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/5a7bfdbcb1a5 Automatic merge with default - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:06:39 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:06:39 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282106.x2SL6dkG018704@aojmv0008.oracle.com> Changeset: e74ea164eaeb Author: mcimadamore Date: 2019-03-28 22:06 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/e74ea164eaeb Automatic merge with default - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:07:22 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:07:22 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282107.x2SL7NVN019328@aojmv0008.oracle.com> Changeset: e094cae32946 Author: mcimadamore Date: 2019-03-28 22:07 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/e094cae32946 Automatic merge with default ! .hgtags ! make/CompileJavaModules.gmk ! make/common/SetupJavaCompilers.gmk ! make/conf/jib-profiles.js ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/windows/os_windows.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp ! src/hotspot/share/ci/ciEnv.hpp ! src/hotspot/share/ci/ciObjectFactory.hpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/code/compiledMethod.hpp ! src/hotspot/share/code/nmethod.hpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1DirtyCardQueue.hpp ! src/hotspot/share/gc/shared/ptrQueue.hpp ! src/hotspot/share/gc/shenandoah/c2/shenandoahSupport.cpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.cpp ! src/hotspot/share/gc/z/c2/zBarrierSetC2.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/opto/callnode.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/VarHandle.java ! src/java.base/share/classes/java/util/Formatter.java ! src/java.base/share/classes/sun/nio/ch/Net.java ! src/java.base/share/classes/sun/nio/ch/SocketChannelImpl.java ! src/java.base/unix/native/libnio/ch/Net.c - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c ! src/java.base/windows/native/libnio/ch/Net.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh ! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp ! test/hotspot/jtreg/ProblemList.txt - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf ! test/jdk/ProblemList.txt - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:09:07 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:09:07 +0000 Subject: hg: amber/amber: Automatic merge with records-and-sealed Message-ID: <201903282109.x2SL98KM022464@aojmv0008.oracle.com> Changeset: 0cc4d237e74e Author: mcimadamore Date: 2019-03-28 22:08 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/0cc4d237e74e Automatic merge with records-and-sealed ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:07:44 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:07:44 +0000 Subject: hg: amber/amber: Automatic merge with default Message-ID: <201903282107.x2SL7ic9019711@aojmv0008.oracle.com> Changeset: 991e04edd61d Author: mcimadamore Date: 2019-03-28 22:07 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/991e04edd61d Automatic merge with default ! make/CompileJavaModules.gmk ! make/autoconf/spec.gmk.in ! make/autoconf/toolchain.m4 ! make/devkit/Makefile ! make/devkit/Tools.gmk ! make/scripts/compare.sh - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/classfile/verifier.cpp ! src/hotspot/share/classfile/verifier.hpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp ! src/hotspot/share/runtime/globals.hpp ! src/java.base/share/classes/java/lang/invoke/MethodHandle.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/invoke/VarHandle.java ! src/java.base/share/classes/java/lang/invoke/package-info.java - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java ! test/langtools/jdk/javadoc/lib/javadoc/tester/JavadocTester.java From maurizio.cimadamore at oracle.com Thu Mar 28 21:08:27 2019 From: maurizio.cimadamore at oracle.com (maurizio.cimadamore at oracle.com) Date: Thu, 28 Mar 2019 21:08:27 +0000 Subject: hg: amber/amber: Automatic merge with patterns-stage-1 Message-ID: <201903282108.x2SL8RGW020743@aojmv0008.oracle.com> Changeset: 3a3ab2f576c7 Author: mcimadamore Date: 2019-03-28 22:08 +0100 URL: http://hg.openjdk.java.net/amber/amber/rev/3a3ab2f576c7 Automatic merge with patterns-stage-1 - src/hotspot/os_cpu/linux_x86/gc/z/zLargePages_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zNUMA_linux_x86.cpp - src/hotspot/os_cpu/linux_x86/gc/z/zVirtualMemory_linux_x86.cpp - src/hotspot/share/gc/z/zForwardingTableEntry.hpp - src/hotspot/share/gc/z/zNMethodAllocator.cpp - src/hotspot/share/gc/z/zNMethodAllocator.hpp - src/hotspot/share/gc/z/zPageTableEntry.hpp - src/java.base/unix/native/libnio/ch/ServerSocketChannelImpl.c - src/java.base/unix/native/libnio/ch/UnixAsynchronousServerSocketChannelImpl.c - src/java.base/windows/native/libnio/ch/ServerSocketChannelImpl.c - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-blob-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-buffer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-face-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-font-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-mutex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-object-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-file-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-open-type-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-common-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-gsubgpos-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-layout-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-map-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-arabic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-indic-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-khmer-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-myanmar-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-tibetan.cc - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-complex-use-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-fallback-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-normalize-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-shape-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-ot-tag.h - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-digest-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-set-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shape-plan-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-impl-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-shaper-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-subset-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-unicode-private.hh - src/java.desktop/share/native/libfontmanager/harfbuzz/hb-utf-private.hh ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core.common/src/org/graalvm/compiler/core/common/util/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.core/src/org/graalvm/compiler/core/doc-files/CompilationBailoutActionHelp.txt - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.graph/src/org/graalvm/compiler/graph/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.hotspot/src/org/graalvm/compiler/hotspot/NodeCostDumpUtil.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.replacements/src/org/graalvm/compiler/replacements/UnsafeAccess.java - src/jdk.internal.vm.compiler/share/classes/org.graalvm.compiler.word/src/org/graalvm/compiler/word/UnsafeAccess.java - src/jdk.sctp/unix/native/libsctp/SctpServerChannelImpl.c - test/hotspot/gtest/gc/z/test_zForwardingTable.cpp - test/hotspot/jtreg/runtime/RedefineObject/Agent.java - test/hotspot/jtreg/runtime/RedefineObject/TestRedefineObject.java - test/hotspot/jtreg/runtime/RedefineObject/WalkThroughInvoke.java - test/hotspot/jtreg/runtime/RedefineTests/ModifyAnonymous.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAddLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineAnnotations.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDeleteJmethod.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineDoubleDelete.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineFinalizer.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceCall.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineInterfaceMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineLeak.java - test/hotspot/jtreg/runtime/RedefineTests/RedefinePreviousVersions.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethods.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithBacktrace.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineRunningMethodsWithResolutionErrors.java - test/hotspot/jtreg/runtime/RedefineTests/RedefineSubtractLambdaExpression.java - test/hotspot/jtreg/runtime/RedefineTests/TestMultipleClasses.java - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDeleteJmethod.c - test/hotspot/jtreg/runtime/RedefineTests/libRedefineDoubleDelete.c - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-aarch64 - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-ppc64le - test/hotspot/jtreg/runtime/containers/docker/Dockerfile-BasicTest-s390x - test/hotspot/jtreg/runtime/handshake/HandshakeWalkSuspendExitTest.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/NoClassDefFoundMsg.java - test/hotspot/jtreg/runtime/noClassDefFoundMsg/libNoClassDefFoundMsg.c - test/hotspot/jtreg/serviceability/jvmti/RetransformClassesZeroLength.java - test/hotspot/jtreg/serviceability/jvmti/TestLambdaFormRetransformation.java - test/hotspot/jtreg/serviceability/jvmti/TestRedefineWithUnresolvedClass.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.java - test/hotspot/jtreg/serviceability/jvmti/UnresolvedClassAgent.mf - test/jdk/java/awt/Choice/PopdownGeneratesMouseEvents/PopdownGeneratesMouseEvents.html - test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html - test/jdk/java/awt/Clipboard/HTMLTransferTest/HTMLTransferTest.html - test/jdk/java/awt/Component/F10TopToplevel/F10TopToplevel.html - test/jdk/java/awt/EventDispatchThread/LoopRobustness/LoopRobustness.html - test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest.html - test/jdk/java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.html - test/jdk/java/awt/Focus/ChildWindowFocusTest/ChildWindowFocusTest.html - test/jdk/java/awt/Focus/DeiconifiedFrameLoosesFocus/DeiconifiedFrameLoosesFocus.html - test/jdk/java/awt/Focus/FocusSubRequestTest/FocusSubRequestTest.html - test/jdk/java/awt/Focus/ModalBlockedStealsFocusTest/ModalBlockedStealsFocusTest.html - test/jdk/java/awt/Focus/ModalDialogInitialFocusTest/ModalDialogInitialFocusTest.html - test/jdk/java/awt/Focus/ModalExcludedWindowClickTest/ModalExcludedWindowClickTest.html - test/jdk/java/awt/Focus/NonFocusableBlockedOwnerTest/NonFocusableBlockedOwnerTest.html - test/jdk/java/awt/Focus/ToFrontFocusTest/ToFrontFocus.html - test/jdk/java/awt/Focus/WindowInitialFocusTest/WindowInitialFocusTest.html - test/jdk/java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html - test/jdk/java/awt/FontClass/CreateFont/bigfont.html - test/jdk/java/awt/Frame/DisposeStressTest/DisposeStressTest.html - test/jdk/java/awt/Frame/NonEDT_GUI_DeadlockTest/NonEDT_GUI_Deadlock.html - test/jdk/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeForModalDialogTest/ConsumeForModalDialogTest.html - test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/ButtonActionKeyTest/ButtonActionKeyTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/MenuItemActivatedTest/MenuItemActivatedTest.html - test/jdk/java/awt/KeyboardFocusmanager/TypeAhead/TestDialogTypeAhead.html - test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html - test/jdk/java/awt/List/FocusEmptyListTest/FocusEmptyListTest.html - test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html - test/jdk/java/awt/Mouse/ExtraMouseClick/ExtraMouseClick.html - test/jdk/java/awt/Mouse/TitleBarDoubleClick/TitleBarDoubleClick.html - test/jdk/java/awt/Multiscreen/WindowGCChangeTest/WindowGCChangeTest.html - test/jdk/java/awt/Window/HandleWindowDestroyTest/HandleWindowDestroyTest.html - test/jdk/java/awt/datatransfer/DragUnicodeBetweenJVMTest/DragUnicodeBetweenJVMTest.html - test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html - test/jdk/java/awt/dnd/DragInterceptorAppletTest/DragInterceptorAppletTest.html - test/jdk/java/awt/dnd/FileListBetweenJVMsTest/FileListBetweenJVMsTest.html - test/jdk/java/awt/dnd/ImageDecoratedDnDInOut/ImageDecoratedDnDInOut.html - test/jdk/java/awt/dnd/ImageDecoratedDnDNegative/ImageDecoratedDnDNegative.html - test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.html - test/jdk/java/awt/dnd/NoFormatsCrashTest/NoFormatsCrashTest.html - test/jdk/java/awt/dnd/URIListBetweenJVMsTest/URIListBetweenJVMsTest.html - test/jdk/java/awt/dnd/URIListToFileListBetweenJVMsTest/URIListToFileListBetweenJVMsTest.html - test/jdk/java/awt/event/ComponentEvent/MovedResizedTardyEventTest/MovedResizedTardyEventTest.html - test/jdk/java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html - test/jdk/java/awt/event/MouseEvent/FrameMouseEventAbsoluteCoordsTest/FrameMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MenuDragMouseEventAbsoluteCoordsTest/MenuDragMouseEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/MouseClickTest/MouseClickTest.html - test/jdk/java/awt/event/MouseEvent/MouseWheelEventAbsoluteCoordsTest/MouseWheelEventAbsoluteCoordsTest.html - test/jdk/java/awt/event/MouseEvent/RobotLWTest/RobotLWTest.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_2.html - test/jdk/java/awt/event/MouseWheelEvent/InfiniteRecursion/InfiniteRecursion_3.html - test/jdk/javax/imageio/AppletResourceTest.html - test/jdk/javax/swing/JFrame/4962534/bug4962534.html - test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.html - test/jdk/javax/swing/MultiUIDefaults/4300666/bug4300666.html - test/jdk/javax/swing/text/StyledEditorKit/4506788/bug4506788.html - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-aarch64 - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-ppc64le - test/jdk/jdk/internal/platform/docker/Dockerfile-BasicTest-s390x - test/jdk/sanity/client/TEST.ROOT.template - test/jdk/sun/java2d/cmm/ColorConvertOp/ConstructorsNullTest/ConstructorsNullTest.html - test/jdk/vm/JniInvocationTest.java - test/jdk/vm/exeJniInvocationTest.c - test/jdk/vm/gc/ArraySize.java - test/jdk/vm/gc/InfiniteList.java - test/jdk/vm/jit/BadLogicCode.java - test/jdk/vm/jit/ExceptionInInit.java - test/jdk/vm/jit/JITClassInit.java - test/jdk/vm/runtime/ExplicitArithmeticCheck.java - test/jdk/vm/runtime/MonitorCacheMaybeExpand_DeadLock.java - test/jdk/vm/runtime/ReflectStackOverflow.java - test/jdk/vm/runtime/ShiftTest.java - test/jdk/vm/runtime/WideStrictInline.java - test/jdk/vm/verifier/TestStaticIF.java - test/jdk/vm/verifier/VerifyProtectedConstructor.java - test/jdk/vm/verifier/VerifyStackForExceptionHandlers.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTests.java - test/jdk/vm/verifier/defaultMethods/DefaultMethodRegressionTestsRun.java From gavin.bierman at oracle.com Thu Mar 28 23:10:14 2019 From: gavin.bierman at oracle.com (Gavin Bierman) Date: Fri, 29 Mar 2019 00:10:14 +0100 Subject: CFV: New Amber Committer: Joe Darcy In-Reply-To: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> References: <039a4877-5b05-dfe5-28d6-89b32c78e681@oracle.com> Message-ID: <789D8A3F-CD19-4C23-BC36-C93C632C65BA@oracle.com> Vote: Yes. > On 21 Mar 2019, at 17:40, Vicente Romero wrote: > > I hereby nominate Joe Darcy (darcy) to Amber Committer. > > Joe, who doesn't need too much presentation :), will be working on the reflection area of records and sealed types. A list of his most recent OpenJDK contributions is available at [3]. > > Votes are due by April 04, 2019. > > Only current Amber Committers [1] are eligible to vote on this > nomination. > > For Lazy Consensus voting instructions, see [2]. > > Thank you, > Vicente Romero > > [1] http://openjdk.java.net/census > [2] http://openjdk.java.net/projects/#committer-vote > [3] http://hg.openjdk.java.net/jdk/jdk/search/?rev=author(darcy) From brian.goetz at oracle.com Sun Mar 31 15:33:23 2019 From: brian.goetz at oracle.com (Brian Goetz) Date: Sun, 31 Mar 2019 11:33:23 -0400 Subject: Method chaining JEP draft In-Reply-To: References: Message-ID: <12ad4443-5d73-cfd9-9f22-f1b89d3334aa@oracle.com> You are correct, this request has come up quite a few times over the years, including in Project Coin, and there is nothing intrinsically unsound about this feature.? (Though, it's not all roses and sunshine either -- it does blur the definition of what "void method" means, among other issues.? So there are definitely "pros and cons", as you say.) But, underlying your question is an assumption: that the bar for adding a feature is "it's a good idea."? Surely we don't want to add bad ideas, but the bar is much higher than that.? The main reason we've not done this is not that we think its terrible (its OK, not great, not terrible), nor that it never occurred to us (trust me, this is never the reason); it's that there are other, better features we could be spending our limited { analysis, implementation, specification, complexity, novelty, education } budgets on.? It just doesn't seem to be very close to the top of the list. (For the record, what I like best about this feature is that it allows us to make more computations into expressions; this is good because expressions compose better than statements.) Now, I hear you thinking: "but it's such a simple feature, surely we can just sneak it in?"? Which is an attractive thought, but in reality, nothing is a simple feature -- and once we have this feature, it may constrain the development of future features.? So, it's on the "list", and it might come to the top eventually, but right now, other features (records, sealed types, pattern matching, value types, specialized generics) seem like better investments. > Hi there, > At current I am working on a draft for the language feature to allow > non-static methods to declare themselves as `returning instance on which > they were called` (a builder pattern is the best illustration of such type > of methods) making it automatic (rather than forcing the developer to > use return > this) or (as another option to be declared by this JEP) to allow such > behaviour for void methods. > This is a draft at my local PC (he-he) and Gist at the moment and is only > under construction but is it at all worth workin on it? This feature seems > to be an obvious one and might have been discussed in past and yet there > seems to be no JEP addressed for it. > > So should I continue working on a draft (for discussion here, of course) or > this was already discussed and there are already existing pros&cons for > this because of which this feature is not anywhere now? > > Thanks, > Peter P. From mrjarviscraft at gmail.com Sun Mar 31 20:34:34 2019 From: mrjarviscraft at gmail.com (JARvis PROgrammer) Date: Sun, 31 Mar 2019 23:34:34 +0300 Subject: Method chaining JEP draft In-Reply-To: <12ad4443-5d73-cfd9-9f22-f1b89d3334aa@oracle.com> References: <12ad4443-5d73-cfd9-9f22-f1b89d3334aa@oracle.com> Message-ID: Got it, thanks a lot Remi and Brian for your detailed feedback to this topic. ??, 31 ???. 2019 ?. ? 18:33, Brian Goetz : > You are correct, this request has come up quite a few times over the > years, including in Project Coin, and there is nothing intrinsically > unsound about this feature. (Though, it's not all roses and sunshine > either -- it does blur the definition of what "void method" means, among > other issues. So there are definitely "pros and cons", as you say.) > > But, underlying your question is an assumption: that the bar for adding > a feature is "it's a good idea." Surely we don't want to add bad ideas, > but the bar is much higher than that. The main reason we've not done > this is not that we think its terrible (its OK, not great, not > terrible), nor that it never occurred to us (trust me, this is never the > reason); it's that there are other, better features we could be spending > our limited { analysis, implementation, specification, complexity, > novelty, education } budgets on. It just doesn't seem to be very close > to the top of the list. > > (For the record, what I like best about this feature is that it allows > us to make more computations into expressions; this is good because > expressions compose better than statements.) > > Now, I hear you thinking: "but it's such a simple feature, surely we can > just sneak it in?" Which is an attractive thought, but in reality, > nothing is a simple feature -- and once we have this feature, it may > constrain the development of future features. So, it's on the "list", > and it might come to the top eventually, but right now, other features > (records, sealed types, pattern matching, value types, specialized > generics) seem like better investments. > > > Hi there, > > At current I am working on a draft for the language feature to allow > > non-static methods to declare themselves as `returning instance on which > > they were called` (a builder pattern is the best illustration of such > type > > of methods) making it automatic (rather than forcing the developer to > > use return > > this) or (as another option to be declared by this JEP) to allow such > > behaviour for void methods. > > This is a draft at my local PC (he-he) and Gist at the moment and is only > > under construction but is it at all worth workin on it? This feature > seems > > to be an obvious one and might have been discussed in past and yet there > > seems to be no JEP addressed for it. > > > > So should I continue working on a draft (for discussion here, of course) > or > > this was already discussed and there are already existing pros&cons for > > this because of which this feature is not anywhere now? > > > > Thanks, > > Peter P. > >