RFR: JDK-8240998: Implement javac changes for deconstruction patterns.

Jan Lahoda jan.lahoda at oracle.com
Thu Mar 19 17:25:27 UTC 2020


Hi,

Turned out the patch had two bugs - one related to the owners of the 
temporary variables created, which then broke type annotations; and 
another that broken de-duplication. I am deeply sorry for that. An 
updated webrev is here:
http://cr.openjdk.java.net/~jlahoda/8240998/webrev.01/

A delta from previous round:
http://cr.openjdk.java.net/~jlahoda/8240998/webrev.delta.00.01/

I am sorry for any inconvenience.

Jan

On 18. 03. 20 9:55, Jan Lahoda wrote:
> Hi,
> 
> I would like to ask for a review for a patch that implements the 
> deconstruction patterns, as described in JEP 375:
> https://bugs.openjdk.java.net/browse/JDK-8235186
> 
> The current specification draft is here:
> http://cr.openjdk.java.net/~gbierman/jep375/jep375-20200316/specs/patterns-instanceof-jls.html 
> 
> 
> For this phase, the proposal is for javac to desugar the deconstruction 
> patterns using record accessors.
> 
> The CSR for this change is being written here:
> https://bugs.openjdk.java.net/browse/JDK-8240999
> 
> The proposed patch:
> http://cr.openjdk.java.net/~jlahoda/8240998/webrev.00
> 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8240998
> 
> Any feedback is welcome!
> 
> Thanks,
>      Jan


More information about the amber-dev mailing list