RFR: JDK-8225056 VM support for sealed classes
Harold Seigel
harold.seigel at oracle.com
Thu May 21 18:43:17 UTC 2020
Hi Mandy,
Thanks for the suggestions. They have been incorporated in the revised
webrev.
http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/
Harold
On 5/20/2020 1:05 PM, Mandy Chung wrote:
> Hi Vicente,
>
> On 5/20/20 8:40 AM, Vicente Romero wrote:
>> Hi David,
>>
>>> src/java.base/share/classes/java/lang/Class.java
>>>
>>> There needs to be a CSR request for these changes.
>>
>> yes there is one already:
>> https://bugs.openjdk.java.net/browse/JDK-8244556
>
> Adding to David's comment w.r.t. @throws IAE:
>
> The Class::getXXX APIs returns `Class` or `Class[]` if the result is
> about type(s). This new `getPermittedSubclasses` returns
> `ClassDesc[]`. I wonder if this should be renamed to
> `permittedSubclasses` to follow the convention of the new APIs added
> to support descriptors e.g. `describeConstable`
>
> Nit: {@linkplain Class} should be {@code Class}
>
> Mandy
More information about the amber-dev
mailing list