From forax at univ-mlv.fr Fri Oct 1 17:17:01 2021 From: forax at univ-mlv.fr (Remi Forax) Date: Fri, 1 Oct 2021 19:17:01 +0200 (CEST) Subject: Jshell: instanceof binding can re-define a local variable Message-ID: <785002892.2761819.1633108621876.JavaMail.zimbra@u-pem.fr> Hi everybody, jshell allows the binding of instanceof to re-define a local variable so something like this is valid Object o = 3; if (o instanceof String o) {} ^ ^ regards, R?mi From duke at openjdk.java.net Thu Oct 7 22:08:03 2021 From: duke at openjdk.java.net (duke) Date: Thu, 7 Oct 2021 22:08:03 GMT Subject: git: openjdk/amber: stats-before-this-super: 84 new changesets Message-ID: Changeset: a8edd1b3 Author: Jie Fu Date: 2021-09-30 23:11:56 +0000 URL: https://git.openjdk.java.net/amber/commit/a8edd1b360d4e5f35aff371a91fda42eeb00d395 8274527: Minimal VM build fails after JDK-8273459 Reviewed-by: kvn ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/macroAssembler_x86_adler.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp Changeset: 2e690ba8 Author: Kim Barrett Date: 2021-10-01 00:25:35 +0000 URL: https://git.openjdk.java.net/amber/commit/2e690ba8bda30902f1188cabad63fb60f4eb828f 8274322: Problems with oopDesc construction Reviewed-by: dholmes, stefank ! src/hotspot/share/oops/instanceOop.hpp ! src/hotspot/share/oops/markWord.hpp ! src/hotspot/share/oops/objArrayOop.hpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/typeArrayOop.hpp Changeset: 5e4b514e Author: Martin Doerr Date: 2021-10-01 08:20:51 +0000 URL: https://git.openjdk.java.net/amber/commit/5e4b514e6e7e1b9f51fac1983b6c12a988f7f5a8 8274550: c2i entry barriers read int as long on PPC Reviewed-by: eosterlund, shade ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp Changeset: b7b78ff1 Author: Ao Qi Committer: Jie Fu Date: 2021-10-01 08:52:04 +0000 URL: https://git.openjdk.java.net/amber/commit/b7b78ff1f380d19214dbca48455772bc87cc137d 8274561: sun/net/ftp/TestFtpTimeValue.java timed out on slow machines Reviewed-by: jiefu, dfuchs ! test/jdk/sun/net/ftp/TestFtpTimeValue.java Changeset: 18870284 Author: Jan Lahoda Date: 2021-10-01 08:53:04 +0000 URL: https://git.openjdk.java.net/amber/commit/18870284084aaaf729640de0105ce21e253546b9 8269113: Javac throws when compiling switch (null) Co-authored-by: Guoxiong Li Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/TransPatterns.java ! test/langtools/tools/javac/patterns/SwitchErrors.java ! test/langtools/tools/javac/patterns/SwitchErrors.out ! test/langtools/tools/javac/patterns/Switches.java Changeset: 292d7bb1 Author: Jan Lahoda Date: 2021-10-01 08:54:18 +0000 URL: https://git.openjdk.java.net/amber/commit/292d7bb1d5d311b517b2cd6d0f6dc77e35b3f649 8274363: Transitively sealed classes not considered exhaustive in switches Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java ! test/langtools/tools/javac/patterns/Exhaustiveness.java Changeset: cc14c6f0 Author: Aleksei Efimov Date: 2021-10-01 09:48:09 +0000 URL: https://git.openjdk.java.net/amber/commit/cc14c6f076356731f78aea4e890027f4e2a91642 8274227: Remove "impl.prefix" jdk system property usage from InetAddress Reviewed-by: alanb, dfuchs ! src/java.base/share/classes/java/net/Inet4AddressImpl.java ! src/java.base/share/classes/java/net/Inet6AddressImpl.java ! src/java.base/share/classes/java/net/InetAddress.java ! src/java.base/share/classes/java/net/InetAddressImpl.java Changeset: c05dc268 Author: Ekaterina Vergizova Committer: Yuri Nesterenko Date: 2021-10-01 12:53:08 +0000 URL: https://git.openjdk.java.net/amber/commit/c05dc268acaf87236f30cf700ea3ac778e3b20e5 8274435: EXCEPTION_ACCESS_VIOLATION in BFSClosure::closure_impl Reviewed-by: stefank ! src/hotspot/share/jfr/leakprofiler/chains/bitset.cpp Changeset: 3d7671b6 Author: Brian Burkhalter Date: 2021-10-01 15:30:55 +0000 URL: https://git.openjdk.java.net/amber/commit/3d7671b65e8491f3b1fcac8b96401401f783c9f4 8274562: (fs) UserDefinedFileAttributeView doesn't correctly determine if supported when using OverlayFS Reviewed-by: alanb ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c Changeset: 05d38604 Author: Pavel Rappo Date: 2021-10-01 16:15:48 +0000 URL: https://git.openjdk.java.net/amber/commit/05d38604a2c620dcaf8682f02dae2fddab8e0c0b 8274605: Fix predicate guarantees on returned values in (Doc)SourcePositions Reviewed-by: jlahoda, jjg ! src/jdk.compiler/share/classes/com/sun/source/util/DocSourcePositions.java ! src/jdk.compiler/share/classes/com/sun/source/util/SourcePositions.java Changeset: bb4500d0 Author: Alexey Ivanov Date: 2021-10-01 18:41:51 +0000 URL: https://git.openjdk.java.net/amber/commit/bb4500d0d227cbb238bd6c862e143f864106a31a 8274465: Fix javax/swing/text/ParagraphView/6364882/bug6364882.java failures Reviewed-by: jiefu, serb ! test/jdk/javax/swing/text/ParagraphView/6364882/bug6364882.java Changeset: 0786d8b7 Author: Brian Burkhalter Date: 2021-10-01 20:15:44 +0000 URL: https://git.openjdk.java.net/amber/commit/0786d8b7b367e3aa3ffa54a3e339572938378dca 8268435: (ch) ChannelInputStream could override readAllBytes Reviewed-by: alanb, lancea ! src/java.base/share/classes/java/io/FileInputStream.java ! src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java + test/jdk/java/nio/channels/Channels/ReadXBytes.java Changeset: 9ca6bf0d Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-02 03:06:29 +0000 URL: https://git.openjdk.java.net/amber/commit/9ca6bf0d22ac39d4ee29c756903038f09087ca12 8274505: Too weak variable type leads to unnecessary cast in java.desktop Reviewed-by: serb, kizune, pbansal ! src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/java.desktop/share/classes/javax/swing/JFormattedTextField.java ! src/java.desktop/share/classes/javax/swing/JRootPane.java ! src/java.desktop/share/classes/javax/swing/JTree.java ! src/java.desktop/share/classes/javax/swing/plaf/synth/SynthParser.java ! src/java.desktop/share/classes/javax/swing/text/html/AccessibleHTML.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFGenerator.java ! src/java.desktop/share/classes/sun/awt/SunToolkit.java ! src/java.desktop/share/classes/sun/java2d/Disposer.java Changeset: 79579942 Author: Robbin Ehn Date: 2021-10-04 06:47:27 +0000 URL: https://git.openjdk.java.net/amber/commit/7957994273e20d541b8f2a873781be7fedf712f1 8273695: Safepoint deadlock on VMOperation_lock Reviewed-by: dcubed, pchilanomate, eosterlund ! src/hotspot/share/runtime/safepointMechanism.hpp ! src/hotspot/share/runtime/safepointMechanism.inline.hpp ! src/hotspot/share/runtime/stackWatermarkSet.cpp ! src/hotspot/share/runtime/stackWatermarkSet.hpp ! test/hotspot/jtreg/ProblemList.txt Changeset: 32811026 Author: Prasanta Sadhukhan Date: 2021-10-04 06:49:10 +0000 URL: https://git.openjdk.java.net/amber/commit/32811026ce5ecb1d27d835eac33de9ccbd51fcbf 8268084: [macos] Disabled JMenuItem arrow is not disabled Reviewed-by: serb, jdv ! src/java.desktop/macosx/classes/com/apple/laf/AquaImageFactory.java + test/jdk/javax/swing/plaf/aqua/JMenuItemDisableArrowButtonTest.java Changeset: 6726c592 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-04 10:27:20 +0000 URL: https://git.openjdk.java.net/amber/commit/6726c592ed01b112f5eb85d8f1e4406b25c8df2b 8274634: Use String.equals instead of String.compareTo in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java ! src/java.desktop/share/classes/javax/swing/JList.java ! src/java.desktop/share/classes/javax/swing/JTable.java Changeset: 0828273b Author: Aleksey Shipilev Date: 2021-10-04 12:22:55 +0000 URL: https://git.openjdk.java.net/amber/commit/0828273b898cca5368344e75f1c3f4c3a29dde80 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected Reviewed-by: kbarrett, tschatzl ! test/jdk/jdk/jfr/event/gc/detailed/TestGCLockerEvent.java Changeset: 47bfc8aa Author: Aleksey Shipilev Date: 2021-10-04 12:35:58 +0000 URL: https://git.openjdk.java.net/amber/commit/47bfc8aa9367ff852ea5d901f1fa3c6ef316913e 8274563: jfr/event/oldobject/TestClassLoaderLeak.java fails when GC cycles are not happening Reviewed-by: egahlin ! test/jdk/jdk/jfr/event/oldobject/TestClassLoaderLeak.java Changeset: 7eb0372e Author: Alex Kasko Committer: Aleksey Shipilev Date: 2021-10-04 12:38:34 +0000 URL: https://git.openjdk.java.net/amber/commit/7eb0372e55f23275b12470593adc97f1b79bc965 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test Reviewed-by: joehw, shade ! test/jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java Changeset: f2404d60 Author: Naoto Sato Date: 2021-10-04 15:06:48 +0000 URL: https://git.openjdk.java.net/amber/commit/f2404d60de2b58c590bf885f5cce50c289073673 8274658: ISO 4217 Amendment 170 Update Reviewed-by: lancea, iris ! make/data/currency/CurrencyData.properties ! src/java.base/share/classes/sun/util/resources/CurrencyNames.properties ! test/jdk/java/util/Currency/ValidateISO4217.java ! test/jdk/java/util/Currency/tablea1.txt ! test/jdk/sun/text/resources/LocaleData ! test/jdk/sun/text/resources/LocaleDataTest.java Changeset: f63c4a83 Author: Weijun Wang Date: 2021-10-04 15:30:44 +0000 URL: https://git.openjdk.java.net/amber/commit/f63c4a832a1aea451f47aaf86d5361e970c6a28f 8274471: Verification of OCSP Response signed with RSASSA-PSS fails Reviewed-by: hchao, jnimeh ! src/java.base/share/classes/sun/security/provider/certpath/OCSP.java ! src/java.base/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/java.base/share/classes/sun/security/util/SignatureUtil.java ! src/java.base/share/classes/sun/security/x509/AlgorithmId.java ! src/java.base/share/classes/sun/security/x509/X509CRLImpl.java ! src/java.base/share/classes/sun/security/x509/X509CertImpl.java ! test/jdk/java/security/testlibrary/CertificateBuilder.java ! test/jdk/java/security/testlibrary/SimpleOCSPServer.java ! test/jdk/javax/net/ssl/Stapling/HttpsUrlConnClient.java Changeset: 139a8334 Author: Adam Sotona Date: 2021-10-04 15:48:09 +0000 URL: https://git.openjdk.java.net/amber/commit/139a8334cbc0c8e1a7a708efe18bd488d28292fd 8268869: java in source-file mode suggests javac-only Xlint flags Reviewed-by: jjg ! src/jdk.compiler/share/classes/com/sun/tools/javac/launcher/Main.java ! test/langtools/tools/javac/launcher/SourceLauncherTest.java Changeset: 6f727d83 Author: Jonathan Gibbons Date: 2021-10-04 16:58:23 +0000 URL: https://git.openjdk.java.net/amber/commit/6f727d831d8f8fb9b44f4c6bdbdd6ae44316a5d8 8274666: rename HtmlStyle.descfrmTypeLabel to be less cryptic Reviewed-by: hannesw ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Contents.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/MethodWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PropertyWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlStyle.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/testInterface/TestInterface.java ! test/langtools/jdk/javadoc/doclet/testOptions/custom-stylesheet.css ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverriddenMethodDocCopy.java ! test/langtools/jdk/javadoc/doclet/testOverriddenMethods/TestOverrideMethods.java ! test/langtools/jdk/javadoc/doclet/testPrivateClasses/TestPrivateClasses.java ! test/langtools/jdk/javadoc/doclet/testReturnTag/TestReturnTag.java Changeset: 0ca094bc Author: Jonathan Gibbons Date: 2021-10-04 16:59:30 +0000 URL: https://git.openjdk.java.net/amber/commit/0ca094bc5f568842b1619229206ec4a385e5ebf6 8273244: Improve diagnostic output related to ErroneousTree Reviewed-by: prappo ! src/jdk.compiler/share/classes/com/sun/tools/javac/api/JavacTrees.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/ReferenceParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DCTree.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/AbstractLog.java ! src/jdk.compiler/share/classes/jdk/internal/shellsupport/doc/JavadocHelper.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/tool/JavadocLog.java ! test/langtools/tools/doclint/CrashInAnnotateTest.out ! test/langtools/tools/doclint/EndWithIdentifierTest.out ! test/langtools/tools/doclint/UnfinishedInlineTagTest.out ! test/langtools/tools/doclint/tidy/README.txt ! test/langtools/tools/doclint/tidy/UnescapedOrUnknownEntity.out ! test/langtools/tools/javac/doctree/AttrTest.java ! test/langtools/tools/javac/doctree/AuthorTest.java ! test/langtools/tools/javac/doctree/BadTest.java ! test/langtools/tools/javac/doctree/CodeTest.java + test/langtools/tools/javac/doctree/CoverageTest.java ! test/langtools/tools/javac/doctree/DeprecatedTest.java ! test/langtools/tools/javac/doctree/DocCommentTester.java ! test/langtools/tools/javac/doctree/DocRootTest.java ! test/langtools/tools/javac/doctree/ElementTest.java ! test/langtools/tools/javac/doctree/EntityTest.java ! test/langtools/tools/javac/doctree/ExceptionTest.java ! test/langtools/tools/javac/doctree/FirstSentenceTest.java ! test/langtools/tools/javac/doctree/HiddenTest.java ! test/langtools/tools/javac/doctree/InPreTest.java ! test/langtools/tools/javac/doctree/IndexTest.java ! test/langtools/tools/javac/doctree/InheritDocTest.java ! test/langtools/tools/javac/doctree/LinkPlainTest.java ! test/langtools/tools/javac/doctree/LinkTest.java ! test/langtools/tools/javac/doctree/LiteralTest.java ! test/langtools/tools/javac/doctree/ParamTest.java ! test/langtools/tools/javac/doctree/ProvidesTest.java ! test/langtools/tools/javac/doctree/ReturnTest.java ! test/langtools/tools/javac/doctree/SeeTest.java ! test/langtools/tools/javac/doctree/SerialDataTest.java ! test/langtools/tools/javac/doctree/SerialFieldTest.java ! test/langtools/tools/javac/doctree/SerialTest.java ! test/langtools/tools/javac/doctree/SinceTest.java ! test/langtools/tools/javac/doctree/SummaryTest.java ! test/langtools/tools/javac/doctree/SystemPropertyTest.java ! test/langtools/tools/javac/doctree/TagTest.java ! test/langtools/tools/javac/doctree/ThrowableTest.java ! test/langtools/tools/javac/doctree/UsesTest.java ! test/langtools/tools/javac/doctree/ValueTest.java ! test/langtools/tools/javac/doctree/VersionTest.java ! test/langtools/tools/javac/doctree/positions/TestPosition.java ! test/langtools/tools/javac/tree/AbstractTreeScannerTest.java Changeset: 9914e5c4 Author: Mikhailo Seledtsov Date: 2021-10-04 17:20:05 +0000 URL: https://git.openjdk.java.net/amber/commit/9914e5c416b518f408837e31ba0a35138bfcadc7 8274610: Add linux-aarch64 to bootcycle build profiles Reviewed-by: erikj ! make/conf/jib-profiles.js Changeset: 75d6688d Author: Jonathan Gibbons Date: 2021-10-04 19:00:21 +0000 URL: https://git.openjdk.java.net/amber/commit/75d6688df9845ecb8f370b4cd2d5a36f13d3cdc0 8274745: ProblemList TestSnippetTag.java Reviewed-by: prappo ! test/langtools/ProblemList.txt Changeset: 7e757f6a Author: Erik Gahlin Date: 2021-10-04 21:19:19 +0000 URL: https://git.openjdk.java.net/amber/commit/7e757f6a2cbfd03ba9ac602b800d15ba33f6f5f4 8274559: JFR: Typo in 'jfr help configure' text Reviewed-by: iris, mikael ! src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Configure.java Changeset: 2e542e33 Author: David Holmes Date: 2021-10-04 23:14:12 +0000 URL: https://git.openjdk.java.net/amber/commit/2e542e33b81a53652956bb5e9636e7f4af5540f7 8274349: ForkJoinPool.commonPool() does not work with 1 CPU Co-authored-by: Doug Lea
Reviewed-by: shade, martin ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java + test/jdk/java/util/concurrent/forkjoin/Uniprocessor.java ! test/jdk/java/util/concurrent/tck/ForkJoinPoolTest.java Changeset: e43f540c Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-05 00:53:17 +0000 URL: https://git.openjdk.java.net/amber/commit/e43f540cde58ee973b97a943f14d3c60e064b801 8274651: Possible race in FontDesignMetrics.KeyReference.dispose Reviewed-by: prr, serb ! src/java.desktop/share/classes/sun/font/FontDesignMetrics.java Changeset: 53d7e95b Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-05 06:39:29 +0000 URL: https://git.openjdk.java.net/amber/commit/53d7e95bc637c8b629efc4587b2ae7961d719b00 8274635: Use String.equals instead of String.compareTo in jdk.accessibility Reviewed-by: serb ! src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/AccessibilityEventMonitor.java ! src/jdk.accessibility/windows/classes/com/sun/java/accessibility/internal/AccessBridge.java Changeset: 3953e077 Author: Christian Hagedorn Date: 2021-10-05 07:02:06 +0000 URL: https://git.openjdk.java.net/amber/commit/3953e0774c59c5e936e752aa08b6b6778e232994 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity Reviewed-by: roland, thartmann, neliasso ! src/hotspot/share/opto/stringopts.cpp + test/hotspot/jtreg/compiler/c2/irTests/stringopts/TestNegativeArraySize.java ! test/hotspot/jtreg/compiler/lib/ir_framework/IRNode.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java Changeset: 8f7a37c9 Author: Matthias Baesken Date: 2021-10-05 07:25:00 +0000 URL: https://git.openjdk.java.net/amber/commit/8f7a37c92f5713f7728f54d4a5924484a535e968 8274434: move os::get_default_process_handle and os::dll_lookup to os_posix for POSIX platforms Reviewed-by: dholmes, lucy ! src/hotspot/os/aix/os_aix.cpp ! src/hotspot/os/bsd/os_bsd.cpp ! src/hotspot/os/linux/os_linux.cpp ! src/hotspot/os/posix/os_posix.cpp Changeset: a914ee72 Author: Kim Barrett Date: 2021-10-05 08:07:02 +0000 URL: https://git.openjdk.java.net/amber/commit/a914ee72167f642b76b1c1cdddd7ff0698d061cc 8274632: Possible pointer overflow in PretouchTask chunk claiming Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/shared/pretouchTask.cpp ! src/hotspot/share/gc/shared/pretouchTask.hpp Changeset: a5080eff Author: Jan Lahoda Date: 2021-10-05 10:17:24 +0000 URL: https://git.openjdk.java.net/amber/commit/a5080effc7ec7e260e84e3169c36c5217f18d231 8272564: Incorrect attribution of method invocations of Object methods on interfaces Reviewed-by: jlaskey, mcimadamore, vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/langtools/tools/javac/api/TestGetElementReference.java ! test/langtools/tools/javac/api/TestGetElementReferenceData.java + test/langtools/tools/javac/api/TestIsAccessible.java + test/langtools/tools/javac/resolve/NoObjectToString.java Changeset: 8609ea55 Author: Harold Seigel Date: 2021-10-05 12:39:56 +0000 URL: https://git.openjdk.java.net/amber/commit/8609ea55acdcc203408f58f7bf96ea9228aef613 8273342: Null pointer dereference in classFileParser.cpp:2817 Reviewed-by: coleenp, dholmes ! src/hotspot/share/runtime/fieldDescriptor.cpp Changeset: 1459180f Author: Andrey Turbanov Committer: Weijun Wang Date: 2021-10-05 13:36:37 +0000 URL: https://git.openjdk.java.net/amber/commit/1459180f352a5632c0afca2ed55abf31e4b0bfb0 8274079: Cleanup unnecessary calls to Throwable.initCause() in java.base module Reviewed-by: weijun ! src/java.base/share/classes/com/sun/crypto/provider/AESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/ConstructKeys.java ! src/java.base/share/classes/com/sun/crypto/provider/DESedeWrapCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java ! src/java.base/share/classes/com/sun/crypto/provider/PBES2Core.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEWithMD5AndDESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/PBEWithMD5AndTripleDESCipher.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2Core.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2HmacSHA1Factory.java ! src/java.base/share/classes/com/sun/crypto/provider/PBKDF2KeyImpl.java ! src/java.base/share/classes/com/sun/crypto/provider/PBMAC1Core.java ! src/java.base/share/classes/com/sun/crypto/provider/RSACipher.java ! src/java.base/share/classes/java/io/ObjectStreamClass.java ! src/java.base/share/classes/java/security/cert/TrustAnchor.java ! src/java.base/share/classes/java/security/cert/X509CRLSelector.java ! src/java.base/share/classes/java/time/Duration.java ! src/java.base/share/classes/javax/net/ssl/SSLContext.java ! src/java.base/share/classes/javax/security/auth/login/Configuration.java ! src/java.base/share/classes/javax/security/auth/x500/X500Principal.java ! src/java.base/share/classes/sun/security/provider/DigestBase.java ! src/java.base/share/classes/sun/security/provider/JavaKeyStore.java ! src/java.base/share/classes/sun/security/util/HostnameChecker.java Changeset: 7ad74d82 Author: Peter Levart Date: 2021-10-05 14:16:20 +0000 URL: https://git.openjdk.java.net/amber/commit/7ad74d82d7117113dd73966a0dd96168adfd6463 8274299: Make Method/Constructor/Field accessors @Stable Reviewed-by: redestad, mchung ! src/java.base/share/classes/java/lang/reflect/Constructor.java ! src/java.base/share/classes/java/lang/reflect/Field.java ! src/java.base/share/classes/java/lang/reflect/Method.java ! src/java.base/share/classes/jdk/internal/reflect/DelegatingConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/DelegatingMethodAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/FieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeMethodAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java ! src/java.base/share/classes/jdk/internal/reflect/UnsafeFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/UnsafeStaticFieldAccessorImpl.java + test/micro/org/openjdk/bench/java/lang/reflect/ReflectionColdstartBenchmark.java + test/micro/org/openjdk/bench/java/lang/reflect/ReflectionSpeedBenchmark.java Changeset: bb0bab57 Author: Albert Mingkun Yang Date: 2021-10-05 14:31:17 +0000 URL: https://git.openjdk.java.net/amber/commit/bb0bab57a1ff447bfb41cfe10c91838a6812b93d 8274286: Skip null for make_referent_alive in referenceProcessor Reviewed-by: kbarrett, tschatzl ! src/hotspot/share/gc/shared/referenceProcessor.cpp Changeset: 90a5ae80 Author: Coleen Phillimore Date: 2021-10-05 15:13:54 +0000 URL: https://git.openjdk.java.net/amber/commit/90a5ae802e6ef0a6d0a5096a595b0680069960c3 8274282: Clarify special wait assert Reviewed-by: dholmes, pchilanomate ! src/hotspot/share/runtime/mutex.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp Changeset: 92b64a20 Author: Jonathan Gibbons Date: 2021-10-05 15:21:44 +0000 URL: https://git.openjdk.java.net/amber/commit/92b64a2053e3f3e0314ed489b92afd37c285ac5f 8273745: VerifyLocale.java occasionally times out Reviewed-by: prappo ! test/langtools/jdk/javadoc/tool/VerifyLocale.java Changeset: 4e3948f1 Author: Jonathan Gibbons Date: 2021-10-05 15:27:02 +0000 URL: https://git.openjdk.java.net/amber/commit/4e3948f18b9b8dab96239ad24473134b712ada1a 8274744: TestSnippetTag test fails after recent integration Reviewed-by: prappo ! test/langtools/ProblemList.txt ! test/langtools/jdk/javadoc/doclet/testSnippetTag/TestSnippetTag.java Changeset: e1f0df0d Author: Hannes Walln?fer Date: 2021-10-05 16:57:12 +0000 URL: https://git.openjdk.java.net/amber/commit/e1f0df0de3b205cecdb1aa1d74562536c06097dd 8267853: Remove unused styles from stylesheet Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java ! test/langtools/jdk/javadoc/doclet/testStylesheet/TestStylesheet.java Changeset: 37890650 Author: Phil Race Date: 2021-10-05 17:30:31 +0000 URL: https://git.openjdk.java.net/amber/commit/37890650a7c97d484b6b520d909f677dac4e46e1 8274397: [macOS] Stop setting env. var JAVA_MAIN_CLASS_ in launcher code Reviewed-by: rriggs, serb ! src/java.base/macosx/native/libjli/java_md_macosx.m ! src/java.desktop/macosx/native/libosxapp/NSApplicationAWT.m + test/jdk/tools/launcher/MacOSAppNamePropertyTest.java + test/jdk/tools/launcher/SystemPropertyTest.java ! test/jdk/tools/launcher/TestSpecialArgs.java Changeset: c391e59e Author: Joe Darcy Date: 2021-10-05 17:31:57 +0000 URL: https://git.openjdk.java.net/amber/commit/c391e59ea6fe6759553425e342b2d97824dd9323 8274244: ReportOnImportedModuleAnnotation.java fails on rerun Reviewed-by: jjg ! test/langtools/tools/javac/processing/ReportOnImportedModuleAnnotation/ReportOnImportedModuleAnnotation.java Changeset: 03d3c033 Author: Weijun Wang Date: 2021-10-05 18:18:51 +0000 URL: https://git.openjdk.java.net/amber/commit/03d3c0338437bf10b631881c8910ca85985742f6 8273670: Remove weak etypes from default krb5 etype list Reviewed-by: valeriep, mullan ! src/java.security.jgss/share/classes/sun/security/krb5/internal/crypto/EType.java ! test/jdk/sun/security/krb5/auto/DupEtypes.java ! test/jdk/sun/security/krb5/auto/OneKDC.java ! test/jdk/sun/security/krb5/auto/W83.java ! test/jdk/sun/security/krb5/config/YesNo.java ! test/jdk/sun/security/krb5/config/yesno.conf ! test/jdk/sun/security/krb5/etype/WeakCrypto.java Changeset: 1e752033 Author: Weijun Wang Date: 2021-10-05 18:19:45 +0000 URL: https://git.openjdk.java.net/amber/commit/1e75203356666a3213deddd775ad1e883ea6d78d 8274656: Remove default_checksum and safe_checksum_type from krb5.conf Reviewed-by: valeriep ! src/java.security.jgss/share/classes/sun/security/krb5/Checksum.java ! src/java.security.jgss/share/classes/sun/security/krb5/Config.java ! src/java.security.jgss/share/classes/sun/security/krb5/EncryptedData.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbAppMessage.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbPriv.java - src/java.security.jgss/share/classes/sun/security/krb5/KrbSafe.java ! src/java.security.jgss/share/classes/sun/security/krb5/KrbTgsReq.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/AuthContext.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/EncKrbPrivPart.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBPriv.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBSafe.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBSafeBody.java - src/java.security.jgss/share/classes/sun/security/krb5/internal/MethodData.java Changeset: 332f0673 Author: Jonathan Gibbons Date: 2021-10-05 18:54:19 +0000 URL: https://git.openjdk.java.net/amber/commit/332f0673880d547a5f09cb4efd3b952868a84b91 8274729: Define Position.NOPOS == Diagnostic.NOPOS Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/util/Position.java Changeset: d34ec6cc Author: Joe Darcy Date: 2021-10-05 19:10:29 +0000 URL: https://git.openjdk.java.net/amber/commit/d34ec6ccfc27d9401acce0e03595b910764fbfaf 8274793: Suppress warnings on non-serializable non-transient instance fields in sun.net Reviewed-by: alanb ! src/java.base/share/classes/sun/net/www/http/KeepAliveCache.java ! src/java.base/unix/classes/sun/net/www/protocol/http/ntlm/NTLMAuthentication.java Changeset: 83b22192 Author: Igor Veresov Date: 2021-10-05 19:44:17 +0000 URL: https://git.openjdk.java.net/amber/commit/83b2219220266c1365466970d08606fef766c4fa 8273612: Fix for JDK-8272873 causes timeout in running some tests with -Xcomp Reviewed-by: kvn, neliasso ! src/hotspot/share/compiler/compilationPolicy.cpp ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/IsMatureTest.java ! test/hotspot/jtreg/compiler/jvmci/compilerToVM/IsMatureVsReprofileTest.java Changeset: 47262670 Author: Christoph Langer Date: 2021-10-05 21:06:52 +0000 URL: https://git.openjdk.java.net/amber/commit/47262670f371923a704ec521da40010c2a46be5a 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287 Reviewed-by: jlahoda ! test/langtools/jdk/jshell/CommandCompletionTest.java Changeset: d4e8712c Author: Daniel D. Daugherty Date: 2021-10-05 21:47:18 +0000 URL: https://git.openjdk.java.net/amber/commit/d4e8712c0acc786e64f81ad29e54e6e50134f0e0 8274797: ProblemList resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java on macosx-x64 Reviewed-by: darcy ! test/hotspot/jtreg/ProblemList.txt Changeset: df7b0c70 Author: Sergey Tsypanov Committer: Martin Buchholz Date: 2021-10-05 22:19:35 +0000 URL: https://git.openjdk.java.net/amber/commit/df7b0c707713195c93ff4e745c89155ee8e4c571 8274715: Implement forEach in Collections.CopiesList Reviewed-by: martin ! src/java.base/share/classes/java/util/Collections.java + test/micro/org/openjdk/bench/java/util/NCopiesBenchmarks.java Changeset: 986ee5d0 Author: Yasumasa Suenaga Date: 2021-10-06 00:36:50 +0000 URL: https://git.openjdk.java.net/amber/commit/986ee5d0bfd407dc1b7ce75c7c94b6585bfb497d 8274670: Improve version string handling in SA Reviewed-by: cjplummer, sspitsyn ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VM.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/VMVersionMismatchException.java Changeset: 8a4d2b4a Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-06 02:53:09 +0000 URL: https://git.openjdk.java.net/amber/commit/8a4d2b4aa76e6aae1cb27f476c6cc71dcd9779f0 8274680: Remove unnecessary conversion to String in java.desktop Reviewed-by: pbansal, jdv, serb, kizune ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DHTMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DQTMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/DRIMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/JFIFMarkerSegment.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/png/PNGMetadata.java ! src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFField.java ! src/java.desktop/share/classes/javax/swing/DefaultListSelectionModel.java ! src/java.desktop/share/classes/javax/swing/GroupLayout.java ! src/java.desktop/share/classes/javax/swing/event/TreeModelEvent.java ! src/java.desktop/share/classes/javax/swing/text/TabStop.java ! src/java.desktop/share/classes/javax/swing/text/html/OptionListModel.java ! src/java.desktop/share/classes/javax/swing/tree/DefaultTreeSelectionModel.java ! src/java.desktop/share/classes/sun/java2d/marlin/RendererContext.java ! src/java.desktop/share/classes/sun/print/PSPrinterJob.java ! src/java.desktop/share/classes/sun/swing/plaf/synth/DefaultSynthStyle.java ! src/java.desktop/windows/classes/sun/awt/windows/WDesktopProperties.java Changeset: 2faced09 Author: Per Liden Date: 2021-10-06 07:44:47 +0000 URL: https://git.openjdk.java.net/amber/commit/2faced09ce0f6901dcdc969e6c85f2a5b55778f1 8274738: ZGC: Use relaxed atomic load when reading bits in the live map Reviewed-by: stefank, eosterlund ! src/hotspot/share/gc/z/zLiveMap.inline.hpp Changeset: c74726db Author: Andrew Haley Date: 2021-10-06 08:18:10 +0000 URL: https://git.openjdk.java.net/amber/commit/c74726dbd0767d02abf9535361a86ffb69b646d9 8274730: AArch64: AES/GCM acceleration is broken by the fix for JDK-8273297 Reviewed-by: adinn, roland, kvn ! src/hotspot/cpu/aarch64/matcher_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/share/opto/library_call.cpp Changeset: df125f68 Author: Christian Hagedorn Date: 2021-10-06 08:21:18 +0000 URL: https://git.openjdk.java.net/amber/commit/df125f680b6a4517109be80512a113064ca6281d 8273410: IR verification framework fails with "Should find method name in validIrRulesMap" Reviewed-by: thartmann, neliasso ! test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestBadFormat.java + test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java Changeset: cdf89304 Author: Hannes Walln?fer Date: 2021-10-06 09:28:37 +0000 URL: https://git.openjdk.java.net/amber/commit/cdf89304eafce58e66127d4e277f5fcaf07c9954 8274625: Search field placeholder behavior Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Navigation.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlAttr.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlTree.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/search.js.template ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css ! test/langtools/jdk/javadoc/doclet/checkStylesheetClasses/CheckStylesheetClasses.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testStylesheet/TestStylesheet.java Changeset: 9759fcb1 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-06 10:50:38 +0000 URL: https://git.openjdk.java.net/amber/commit/9759fcb17b62d76d75b893481bbd4ef45e7ad366 8274496: Use String.contains() instead of String.indexOf() in java.desktop Reviewed-by: pbansal, serb ! src/java.desktop/share/classes/javax/swing/text/html/CSS.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLWriter.java ! src/java.desktop/share/classes/javax/swing/text/html/InlineView.java ! src/java.desktop/share/classes/sun/font/Font2D.java ! src/java.desktop/unix/classes/sun/awt/X11/XWM.java ! src/java.desktop/unix/classes/sun/font/NativeFont.java ! src/java.desktop/unix/classes/sun/font/XMap.java ! src/java.desktop/unix/classes/sun/print/IPPPrintService.java ! src/java.desktop/windows/classes/sun/awt/windows/WDataTransferer.java Changeset: c80a6127 Author: Kim Barrett Date: 2021-10-06 11:14:26 +0000 URL: https://git.openjdk.java.net/amber/commit/c80a612709f1e483575e2843c1f0ea84e1b9a257 8273381: Assert in PtrQueueBufferAllocatorTest.stress_free_list_allocator_vm Reviewed-by: sjohanss, tschatzl ! test/hotspot/gtest/gc/shared/test_ptrQueueBufferAllocator.cpp Changeset: b8af6a9b Author: Coleen Phillimore Date: 2021-10-06 12:14:33 +0000 URL: https://git.openjdk.java.net/amber/commit/b8af6a9bfb28aaf0fea0cfdaba13236dc8cbaa3a 8273917: Remove 'leaf' ranking for Mutex Reviewed-by: eosterlund, dholmes ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.hpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/services/heapDumper.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp ! test/hotspot/gtest/runtime/test_safepoint_locks.cpp Changeset: c10de353 Author: Christian Stein Committer: Alan Bateman Date: 2021-10-06 15:11:28 +0000 URL: https://git.openjdk.java.net/amber/commit/c10de3538b47c182d7bfeb02f348fac9b2ad0641 8262944: Improve exception message when automatic module lists provider class not in JAR file Reviewed-by: dfuchs, jvernee, alanb, lancea, mchung ! src/java.base/share/classes/jdk/internal/module/ModulePath.java ! test/jdk/java/lang/module/AutomaticModulesTest.java Changeset: f3cedbe9 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:11:07 +0000 URL: https://git.openjdk.java.net/amber/commit/f3cedbe9288e7aea8d5603a2dc9bdc2661c391a6 8274464: Remove redundant stream() call before forEach in java.* modules Reviewed-by: dfuchs, amenkov, vtewari ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIJRMPServerImpl.java ! src/java.management/share/classes/java/lang/management/DefaultPlatformMBeanProvider.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogFeatures.java ! src/java.xml/share/classes/javax/xml/catalog/CatalogImpl.java Changeset: 4e7d7caa Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:17:58 +0000 URL: https://git.openjdk.java.net/amber/commit/4e7d7caa0ce1a3c9fc45ca6a85b1a7ec209775b2 8273711: Remove redundant stream() call before forEach in jdk.jlink Reviewed-by: alanb, psandoz, dfuchs ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageFileCreator.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginConfiguration.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImagePluginStack.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PerfectHashBuilder.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/PluginRepository.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ResourcePoolConfiguration.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ResourceFilter.java ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/StringSharingPlugin.java Changeset: 754bc82c Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:20:18 +0000 URL: https://git.openjdk.java.net/amber/commit/754bc82c4c03e1bedb4b36b5c52873b0a78a6ceb 8274525: Replace uses of StringBuffer with StringBuilder in java.xml Reviewed-by: joehw, iris, naoto, dfuchs ! src/java.xml/share/classes/com/sun/xml/internal/stream/Entity.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/StaxErrorReporter.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/XMLEventReaderImpl.java ! src/java.xml/share/classes/com/sun/xml/internal/stream/events/LocationImpl.java ! src/java.xml/share/classes/javax/xml/datatype/Duration.java Changeset: 9945f7a0 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-06 18:23:46 +0000 URL: https://git.openjdk.java.net/amber/commit/9945f7a0744db2470bcfa856e8f831b6a6eb2de8 8274318: Replace 'for' cycles with iterator with enhanced-for in java.management Reviewed-by: cjplummer, sspitsyn, dfuchs ! src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIServerImpl.java ! src/java.management/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessController.java ! src/java.management/share/classes/javax/management/relation/RoleResult.java Changeset: 9561fea7 Author: Sergey Bylokhov Date: 2021-10-06 22:31:23 +0000 URL: https://git.openjdk.java.net/amber/commit/9561fea79035f23ca3a6619c9e150433cdf4a232 8273102: Delete deprecated for removal the empty finalize() in java.desktop module Reviewed-by: pbansal, aivanov, iris, prr ! src/java.desktop/share/classes/java/awt/color/ICC_Profile.java ! src/java.desktop/share/classes/java/awt/image/ColorModel.java ! src/java.desktop/share/classes/java/awt/image/IndexColorModel.java Changeset: 734d1fbd Author: Jonathan Gibbons Date: 2021-10-06 22:40:44 +0000 URL: https://git.openjdk.java.net/amber/commit/734d1fbd33be0aa20b26e6e8c776709f478069de 8274211: Test man page that options are documented Reviewed-by: prappo + test/langtools/jdk/javadoc/tool/CheckManPageOptions.java Changeset: d57fb6f6 Author: lawrence.andrews Committer: Sergey Bylokhov Date: 2021-10-06 23:12:56 +0000 URL: https://git.openjdk.java.net/amber/commit/d57fb6f684eac5a7e68842dcf3284309e3867521 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java Reviewed-by: serb ! test/jdk/java/awt/print/PrinterJob/PageDialogTest.java Changeset: c833b4d1 Author: Jie Fu Date: 2021-10-06 23:22:04 +0000 URL: https://git.openjdk.java.net/amber/commit/c833b4d130fabfa6a6f3a38313f76eb7e392c6a5 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern Reviewed-by: iklam, ihse, kvn ! src/hotspot/share/compiler/methodMatcher.cpp Changeset: 4e960fe5 Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-07 03:42:50 +0000 URL: https://git.openjdk.java.net/amber/commit/4e960fe53f0948c0b0decfeb13f6dd8f74bf3d6f 8274497: Unnecessary Vector usage in AquaFileSystemModel Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/com/apple/laf/AquaFileSystemModel.java Changeset: 5762ec25 Author: Florian Weimer Committer: Alan Bateman Date: 2021-10-07 07:02:01 +0000 URL: https://git.openjdk.java.net/amber/commit/5762ec25877ab9207a2fb05888f952690737e318 8274780: ChannelInputStream.readNBytes(int) incorrectly calls readAllBytes() Reviewed-by: alanb, bpb ! src/java.base/share/classes/sun/nio/ch/ChannelInputStream.java ! test/jdk/java/nio/channels/Channels/ReadXBytes.java Changeset: 29dcbb72 Author: Richard Reingruber Date: 2021-10-07 08:20:20 +0000 URL: https://git.openjdk.java.net/amber/commit/29dcbb72a2d9b224203d92ad3224cf149a7d08de 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume. Reviewed-by: alanb, cjplummer, sspitsyn ! make/data/jdwp/jdwp.spec Changeset: d5ccfa2a Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-10-07 09:38:42 +0000 URL: https://git.openjdk.java.net/amber/commit/d5ccfa2ae965a9ae0f3597b0b90d702a3e0ea558 8274755: Replace 'while' cycles with iterator with enhanced-for in jdk.jdi Reviewed-by: alanb, amenkov, sspitsyn, cjplummer ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConcreteMethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ConnectorImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/EventRequestManagerImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/InvokableTypeImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/TargetVM.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ThreadReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VMState.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/VirtualMachineImpl.java Changeset: 83198361 Author: Yude Lin Committer: Thomas Schatzl Date: 2021-10-07 11:28:49 +0000 URL: https://git.openjdk.java.net/amber/commit/8319836152cbd0aa5bf6c93d3ba04733cacf83b4 8274546: Shenandoah: Remove unused ShenandoahUpdateRootsTask copy Reviewed-by: zgu, tschatzl ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp Changeset: 340c715c Author: Lin Zang Date: 2021-10-07 11:57:18 +0000 URL: https://git.openjdk.java.net/amber/commit/340c715c3b0f5ad5204f9dddb17a787b07426543 8273929: Remove GzipRandomAccess in heap dump test Reviewed-by: cjplummer, sspitsyn - test/lib/jdk/test/lib/hprof/parser/GzipRandomAccess.java ! test/lib/jdk/test/lib/hprof/parser/Reader.java Changeset: 722d639f Author: Jie Fu Date: 2021-10-07 12:42:16 +0000 URL: https://git.openjdk.java.net/amber/commit/722d639fad2e4fc6eb2aabd427e2719501899cfe 8274838: runtime/cds/appcds/TestSerialGCWithCDS.java fails on Windows Reviewed-by: iklam, hseigel ! test/hotspot/jtreg/runtime/cds/appcds/TestSerialGCWithCDS.java Changeset: 03a8d342 Author: Sean Coffey Date: 2021-10-07 15:12:13 +0000 URL: https://git.openjdk.java.net/amber/commit/03a8d342b86e720d3cba08d540182b4ab161fba3 8273826: Correct Manifest file name and NPE checks Reviewed-by: weijun, hchao, mullan ! src/java.base/share/classes/java/util/jar/JarFile.java ! src/java.base/share/classes/java/util/jar/JarInputStream.java ! src/java.base/share/classes/java/util/jar/JarVerifier.java ! src/java.base/share/classes/sun/security/util/ManifestEntryVerifier.java + test/jdk/sun/security/tools/jarsigner/warnings/LowerCaseManifest.java Changeset: 4ab274ac Author: Coleen Phillimore Date: 2021-10-07 15:24:00 +0000 URL: https://git.openjdk.java.net/amber/commit/4ab274ac1a241b2d63f46084ec23aa7cff4bc28e 8274858: Remove unused dictionary_classes_do functions Reviewed-by: dholmes, hseigel ! src/hotspot/share/classfile/classLoaderDataGraph.cpp ! src/hotspot/share/classfile/classLoaderDataGraph.hpp ! src/hotspot/share/memory/universe.cpp Changeset: 8ca08461 Author: Naoto Sato Date: 2021-10-07 15:32:11 +0000 URL: https://git.openjdk.java.net/amber/commit/8ca084617f331b6af934179f3f776c8158da5bba 8274407: (tz) Update Timezone Data to 2021c 8274467: TestZoneInfo310.java fails with tzdata2021b 8274468: TimeZoneTest.java fails with tzdata2021b Reviewed-by: rriggs, iris, coffeys ! make/data/tzdata/VERSION ! make/data/tzdata/africa ! make/data/tzdata/antarctica ! make/data/tzdata/asia ! make/data/tzdata/australasia ! make/data/tzdata/backward ! make/data/tzdata/europe ! make/data/tzdata/leapseconds ! make/data/tzdata/northamerica ! make/data/tzdata/southamerica ! make/data/tzdata/zone.tab ! src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java ! test/jdk/java/util/TimeZone/TimeZoneTest.java Changeset: 7de2cf85 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-07 16:55:45 +0000 URL: https://git.openjdk.java.net/amber/commit/7de2cf852d75ea6eb039e69067d4e32421283de5 8273910: Redundant condition and assignment in java.net.URI Reviewed-by: dfuchs ! src/java.base/share/classes/java/net/URI.java Changeset: 920e7070 Author: Daniel D. Daugherty Date: 2021-10-07 17:14:26 +0000 URL: https://git.openjdk.java.net/amber/commit/920e70701da9699765c993e11feba3cc0fd0362c 8274920: ProblemList 2 VectorAPI tests failing due to "assert(!vbox->is_Phi()) failed" Reviewed-by: kvn ! test/hotspot/jtreg/ProblemList-Xcomp.txt Changeset: 8de77634 Author: Yumin Qi Date: 2021-10-07 21:33:32 +0000 URL: https://git.openjdk.java.net/amber/commit/8de77634c414cc348a6eb7b28fd6339befdb12d7 8273152: Refactor CDS FileMapHeader loading code Reviewed-by: ccheung, iklam ! src/hotspot/share/cds/archiveBuilder.cpp ! src/hotspot/share/cds/cdsConstants.cpp ! src/hotspot/share/cds/dynamicArchive.cpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! src/hotspot/share/include/cds.h ! src/hotspot/share/runtime/arguments.cpp ! src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c ! test/hotspot/jtreg/runtime/cds/appcds/SharedArchiveConsistency.java ! test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/ArchiveConsistency.java ! test/lib/jdk/test/lib/cds/CDSArchiveUtils.java Changeset: 025721a4 Author: duke Date: 2021-10-07 22:01:58 +0000 URL: https://git.openjdk.java.net/amber/commit/025721a4044a3fd39664904836e8d97c80bf5556 Automatic merge of master into stats-before-this-super ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java From gavin.bierman at oracle.com Fri Oct 8 13:07:06 2021 From: gavin.bierman at oracle.com (Gavin Bierman) Date: Fri, 8 Oct 2021 13:07:06 +0000 Subject: Pattern Matching for switch (Second Preview) In-Reply-To: <158903792.1719028.1632343025468.JavaMail.zimbra@u-pem.fr> References: <5321c128-ba4d-e405-255a-72025a002e0d@oracle.com> <158903792.1719028.1632343025468.JavaMail.zimbra@u-pem.fr> Message-ID: <4CEFC4F1-C3CC-4E89-A358-FF8F6A77FEE3@oracle.com> > On 22 Sep 2021, at 21:37, Remi Forax wrote: > > And i think we should also fix the following > > 5. add an partial order edge between a guarded pattern and a constant of a subtypes of the type of the guarded pattern > This code currently compiles > switch(value) { > case Integer i && bar() -> {} > case 3 -> {} > case Integer i -> {} > } > > but i think it should be written > switch(value) { > case 3 -> {} > case Integer i && bar() -> {} > case Integer i -> {} > } > > so the code is easier to read. Agreed. I?ll make this change. From forax at univ-mlv.fr Fri Oct 8 16:51:46 2021 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Fri, 8 Oct 2021 18:51:46 +0200 (CEST) Subject: Pattern Matching for switch (Second Preview) In-Reply-To: <4CEFC4F1-C3CC-4E89-A358-FF8F6A77FEE3@oracle.com> References: <5321c128-ba4d-e405-255a-72025a002e0d@oracle.com> <158903792.1719028.1632343025468.JavaMail.zimbra@u-pem.fr> <4CEFC4F1-C3CC-4E89-A358-FF8F6A77FEE3@oracle.com> Message-ID: <877786988.2843823.1633711906506.JavaMail.zimbra@u-pem.fr> ----- Original Message ----- > From: "Gavin Bierman" > To: "Remi Forax" > Cc: "jan lahoda" , "amber-dev" > Sent: Vendredi 8 Octobre 2021 15:07:06 > Subject: Re: Pattern Matching for switch (Second Preview) >> On 22 Sep 2021, at 21:37, Remi Forax wrote: >> >> And i think we should also fix the following >> >> 5. add an partial order edge between a guarded pattern and a constant of a >> subtypes of the type of the guarded pattern >> This code currently compiles >> switch(value) { >> case Integer i && bar() -> {} >> case 3 -> {} >> case Integer i -> {} >> } >> >> but i think it should be written >> switch(value) { >> case 3 -> {} >> case Integer i && bar() -> {} >> case Integer i -> {} >> } >> >> so the code is easier to read. > > > Agreed. I?ll make this change. I'm glad to hear that, thank you. R?mi From sritter at azul.com Tue Oct 12 20:10:14 2021 From: sritter at azul.com (Simon Ritter) Date: Tue, 12 Oct 2021 21:10:14 +0100 Subject: Combining records and enumerations Message-ID: <6c8fa4a6-e71b-52f4-7ee0-a8b7bb013c7b@azul.com> I hope this is the right list to post this to. I was recently using an enumeration and it struck me that enums containing a constructor and member declarations could be simplified by adopting some of the syntax from records. Here is an example of such an enumeration: public enum Planet { ? MERCURY(0.4, 0.055), ? VENUS(0.7, 0.815), ? EARTH(1.0, 1.0), ? MARS(0.107, 1.5); ? private double orbitalDistance; ? private double earthMass; ? Planet(double orbitalDistance, double earthMass) { ??? this.orbitalDistance = orbitalDistance; ??? this.earthMass = earthMass; ? } ? public double orbitalDistance() { ??? return orbitalDistance; ? } ? public double earthMass() { ??? return earthMass; ? } } Most of this boiler-plate code is identical to the code eliminated by a record from a simple data class.? If we took the same approach we could simplify this as: public enum Planet(double orbitalDistance, double earthMass) { ? MERCURY(0.4, 0.055), ? VENUS(0.7, 0.815), ? EARTH(1.0, 1.0), ? MARS(0.107, 1.5); } The grammar for enumerations would only need to be extended to include an EnumHeader EnumDeclaration: {ClassModifier} enum TypeIdentifier EnumHeader [ClassImplements] EnumBody with EnumHeader using the same format as RecordHeader EnumHeader: ? ( [EnumComponentList] ) I'm assuming changes to the compiler to implement this would not be overly complex (although I have not looked at the code). I'd be very interested to hear other people's opinion on this. Regards, Simon. From francois.green at gmail.com Tue Oct 5 23:04:17 2021 From: francois.green at gmail.com (Francois Green) Date: Tue, 5 Oct 2021 19:04:17 -0400 Subject: Issues with pattern variables inside Enum Message-ID: I don't know if it should, but this works: public class PatNum { public static void main(String[] args) { enum Suit { Heart("?"), Club("?"), Spade("?"), Diamond("?"); String symbol; Suit(String symbol) { this.symbol = symbol; } public String color() { return switch(this) { case Club, Spade -> "Black"; case Diamond, Heart -> "Red"; }; } } for (var suit : Suit.values()) System.out.println(suit.color()); } } Trying to use a pattern variable causes an error: public class PatNum { public static void main(String[] args) { enum Suit { Heart("?"), Club("?"), Spade("?"), Diamond("?"); String symbol; Suit(String symbol) { this.symbol = symbol; } public String color() { return switch(this) { case Club c -> "Red"; case Spade s -> "Black"; case Diamond d -> "Red"; case Heart h -> "Red"; }; } } for (var suit : Suit.values()) System.out.println(suit.color()); } } PatNum.java:16: error: cannot find symbol case Club c -> "Red"; ^ symbol: class Club location: class Suit PatNum.java:17: error: cannot find symbol case Spade s -> "Black"; ^ symbol: class Spade location: class Suit PatNum.java:18: error: cannot find symbol case Diamond d -> "Red"; ^ symbol: class Diamond location: class Suit PatNum.java:19: error: cannot find symbol case Heart h -> "Red"; ^ symbol: class Heart location: class Suit Note: PatNum.java uses preview features of Java SE 17. Note: Recompile with -Xlint:preview for details. 4 errors error: compilation failed From faucct at yandex-team.ru Thu Oct 7 10:18:25 2021 From: faucct at yandex-team.ru (Nikita An. Sokolov) Date: Thu, 7 Oct 2021 13:18:25 +0300 Subject: Loosen checking of unreachable suppressed exceptions in try-with-resources Message-ID: (jep-submit at openjdk.java.net is unknown, so I am sending this proposal here) Summary ------- Do not require to catch checked exceptions from closed resources when they are being suppressed by an unconditional throw inside try-block body. Success Metrics --------------- Method fileInputStream should compile and not require to handle IOException from closing fileInputStream, as it will always be suppressed by rethrown RuntimeException: ``` FileInputStream fileInputStream(File file) throws FileNotFoundException { final var fileInputStream = new FileInputStream(file); try { checkSomething(); } catch (Exception e) { try (fileInputStream) { throw e; } } return fileInputStream; } void checkSomething() { throw new RuntimeException(); } ``` Motivation ---------- This would let skipping unreachable catch sections. Description ----------- I guess this would only require changes in Java compiler. Risks and Assumptions --------------------- This change might require to delete unreachable catch blocks in some existing code. To smooth this change such blocks may be allowed, maybe producing a warning. From gavin.bierman at oracle.com Wed Oct 13 13:09:49 2021 From: gavin.bierman at oracle.com (Gavin Bierman) Date: Wed, 13 Oct 2021 13:09:49 +0000 Subject: Issues with pattern variables inside Enum In-Reply-To: References: Message-ID: <581E16ED-9E7C-4500-89E9-3402A5272507@oracle.com> Hi Francois, > On 6 Oct 2021, at 00:04, Francois Green wrote: > > I don't know if it should, but this works: > > public class PatNum { > > public static void main(String[] args) { > > enum Suit { > Heart("?"), Club("?"), Spade("?"), Diamond("?"); > > String symbol; > > Suit(String symbol) { > this.symbol = symbol; > } > > public String color() { > return switch(this) { > case Club, Spade -> "Black"; > case Diamond, Heart -> "Red"; > }; > } > } > > for (var suit : Suit.values()) System.out.println(suit.color()); > } > } > Yes, that is correct - you are using enum constants as switch labels in a switch expression. All good. > > > Trying to use a pattern variable causes an error: > > public class PatNum { > > public static void main(String[] args) { > > enum Suit { > Heart("?"), Club("?"), Spade("?"), Diamond("?"); > > String symbol; > > Suit(String symbol) { > this.symbol = symbol; > } > > public String color() { > return switch(this) { > case Club c -> "Red"; > case Spade s -> "Black"; > case Diamond d -> "Red"; > case Heart h -> "Red"; > }; > } > } > > for (var suit : Suit.values()) System.out.println(suit.color()); > } > } > > PatNum.java:16: error: cannot find symbol > case Club c -> "Red"; > ^ > symbol: class Club > location: class Suit > PatNum.java:17: error: cannot find symbol > case Spade s -> "Black"; > ^ > symbol: class Spade > location: class Suit > PatNum.java:18: error: cannot find symbol > case Diamond d -> "Red"; > ^ > symbol: class Diamond > location: class Suit > PatNum.java:19: error: cannot find symbol > case Heart h -> "Red"; > ^ > symbol: class Heart > location: class Suit > Note: PatNum.java uses preview features of Java SE 17. > Note: Recompile with -Xlint:preview for details. > 4 errors > error: compilation failed I?m afraid that *is* an error. This preview feature only allows type patterns to appear as switch labels. You have written, e.g. Club c, but Club is not a type, it?s an enum constant; so the compiler correctly complains. Gavin From forax at univ-mlv.fr Wed Oct 13 13:38:59 2021 From: forax at univ-mlv.fr (Remi Forax) Date: Wed, 13 Oct 2021 15:38:59 +0200 (CEST) Subject: Issues with pattern variables inside Enum In-Reply-To: <581E16ED-9E7C-4500-89E9-3402A5272507@oracle.com> References: <581E16ED-9E7C-4500-89E9-3402A5272507@oracle.com> Message-ID: <1631947019.1551944.1634132339693.JavaMail.zimbra@u-pem.fr> ----- Original Message ----- > From: "Gavin Bierman" > To: "Francois Green" > Cc: "amber-dev" > Sent: Mercredi 13 Octobre 2021 15:09:49 > Subject: Re: Issues with pattern variables inside Enum > Hi Francois, > >> On 6 Oct 2021, at 00:04, Francois Green wrote: >> >> I don't know if it should, but this works: >> >> public class PatNum { >> >> public static void main(String[] args) { >> >> enum Suit { >> Heart("?"), Club("?"), Spade("?"), Diamond("?"); >> >> String symbol; >> >> Suit(String symbol) { >> this.symbol = symbol; >> } >> >> public String color() { >> return switch(this) { >> case Club, Spade -> "Black"; >> case Diamond, Heart -> "Red"; >> }; >> } >> } >> >> for (var suit : Suit.values()) System.out.println(suit.color()); >> } >> } >> > > Yes, that is correct - you are using enum constants as switch labels in a switch > expression. All good. > >> >> >> Trying to use a pattern variable causes an error: >> >> public class PatNum { >> >> public static void main(String[] args) { >> >> enum Suit { >> Heart("?"), Club("?"), Spade("?"), Diamond("?"); >> >> String symbol; >> >> Suit(String symbol) { >> this.symbol = symbol; >> } >> >> public String color() { >> return switch(this) { >> case Club c -> "Red"; >> case Spade s -> "Black"; >> case Diamond d -> "Red"; >> case Heart h -> "Red"; >> }; >> } >> } >> >> for (var suit : Suit.values()) System.out.println(suit.color()); >> } >> } >> >> PatNum.java:16: error: cannot find symbol >> case Club c -> "Red"; >> ^ >> symbol: class Club >> location: class Suit >> PatNum.java:17: error: cannot find symbol >> case Spade s -> "Black"; >> ^ >> symbol: class Spade >> location: class Suit >> PatNum.java:18: error: cannot find symbol >> case Diamond d -> "Red"; >> ^ >> symbol: class Diamond >> location: class Suit >> PatNum.java:19: error: cannot find symbol >> case Heart h -> "Red"; >> ^ >> symbol: class Heart >> location: class Suit >> Note: PatNum.java uses preview features of Java SE 17. >> Note: Recompile with -Xlint:preview for details. >> 4 errors >> error: compilation failed > > I?m afraid that *is* an error. This preview feature only allows type patterns to > appear as switch labels. You have written, e.g. Club c, but Club is not a type, > it?s an enum constant; so the compiler correctly complains. Hi Francois A way to see the issue is to declare the enum constants in all caps enum Suit { HEART("?"), CLUB("?"), SPADE("?"), DIAMOND("?") } with this renaming, the switch you are trying to compile becomes public String color() { return switch(this) { case CLUB c -> "Red"; case SPADE s -> "Black"; case DIAMOND d -> "Red"; case HEART h -> "Red"; }; } As Gavin said CLUB is not a type, it's a constant. R?mi From reinier at zwitserloot.com Wed Oct 13 15:15:52 2021 From: reinier at zwitserloot.com (Reinier Zwitserloot) Date: Wed, 13 Oct 2021 17:15:52 +0200 Subject: Strings and things In-Reply-To: References: Message-ID: I love where this feature is going. There are a few use cases and intended effects (at least, I assume they are intended) that this feature would have which the document doesn't name. I'm not sure if it's fully on the radar of Jim and Brian. ## Regexp literals "Make the language support regexp literals natively" is a feature request that (in my experience) comes up _a lot_, and it was more or less determined to be part of the bathwater during the text-block discussion (in that 'raw strings' were ejected from that proposal). That was mostly about changing how java interpolates backslashes in string literals which this feature will not solve. However, surely: Pattern."^foo|bar$" is all around an improvement over the current `Pattern.compile("^foo|bar$")`. There are many things that native regexp literals are supposed to accomplish, and this string interpolation proposal doesn't cover all of it, but 'have the constant itself be of type Pattern' is one of them, and this proposal can do that, which is awesome. The vast majority of regexp strings out there are straight constants with no need for string interpolation at all, and yet this feature improves matters some; in that sense, this goes further than merely 'a nice way to add string interpolation to java' - it's also a way to add "typed strings" to java! Now to find a way to go back in time and eliminate String::replaceAll from having ever existed. At least it can be overloaded with one that takes a Pattern as first param, perhaps. That leads to... ## Compile/Write-time identification (IDEs) To an extent IDEs can already do this, but this feature would streamline and simplify this idea: IDEs can now definitely identify the nature of a string literal in your source code, by checking the type of the TemplatePolicy. If you were to type: Pattern."^hello(there$" in your IDE, an IDE should flag this, immediately (as you type, before saving, before running any compilers or build tooling), as erroneous code; that regexp has an unclosed paren. It should also syntax color the string literal because the IDE 'knows' that it is a regexp. It can even offer regexp editor and in-line tester popups if they want to go that far. Piling that kind of functionality on top of the above feels a little cleaner than piling it on top of `Pattern.compile("string-literal-here")`. Without going overboard and bringing compiler plugins into scope, the IDE needs to just 'hard code' Pattern and all that that implies for now, but it's a start. ## This _improves_ security! The same principle applies to SQL. The IDE can know the type of the 'receiver', and from there figure out that it is SQL, and thus apply syntax checking and highlighting suitable for SQL strings. This then pushes people __towards__ better security instead of asking them to trade it off, as they'd want these IDE features and can't get them without using these templated strings. Something like: con.prepareStatement("SELECT * FROM foo WHERE username = '" + username + "'"); is a disaster waiting to happen but isn't flagged, but: con."SELECT * FROM foo WHERE username = '" + username + "'"; either doesn't compile at all, or if it does, will fail at runtime (I'm with Stephen on this one; failing at compile time would be even better, but, one step at a time): the TemplatePolicy applied by `con` on templatestring `SELECT * FROM foo WHERE username = '` has the opportunity to read through that, notice the unbalanced quote, and throw an exception. I implore JDBC driver writers to do just that. Thus, if you want the benefits of IDE supported SQL highlighting and auto-complete and such, you must use this construct, and in doing so, you mostly eliminate the SQL injection opportunity. Marvellous. It's things like this that make me excited about this feature :) ## A small issue: The type of the formatted string. Cay mentioned this as well (in the context of how other languages do it), but right now the proposal uses `String templateString` (in TemplatedString / TemplatePolicy), but it's not obvious what this string would contain. Presumably not just "Hello {name} you are {age} years old" - a policy would have no way to differentiate a 'hole' like "{name}" from a literal open brace character. I assume this is something to be worked on later? One way out is to pass a string where the holes are gone entirely, plus an int array with the positions where the holes are. Turn the above into: new TemplateString("Hello you are years old", new int[] {6, 16}). or possibly: new String[] {"Hello ", " you are ", " years old"}. and then hand _that_ to the TemplatePolicy instead of `String templatedString`. As long as that object is constructed only once in the runtime, that doesn't seem like a costly move, performance-wise. But, it would be nice if the code that actually runs to process that object + the `List` of params gets to also rely on some pre-processing "only once" without handrolling a lazy-initializing system. As Stephen indicated, some of the use cases of this feature have non-trivial preprocessing needs (and usually validation needs as well). Brian mentioned that a lot of the 'cost' in the java ecosystem's use of `String.format` is the overhead of reparsing that format string over and over again. This would eliminate the runtime cost down to once-per-literal which sounds like a worthwhile endeavour, no? A 'static method' in an interface (not a thing in java right now) seems like an answer here, so that as part of constructing that TemplateString (which is done once, presumably as part of loading in the class, similar to a `static {}` block in one), it is handed to some factory to pre-process it. Some care needs to be taken here, as the 'receiver' needs to be statically available (as it gets run during class load time, no instances are available or can be resolved here), and yet the point of this feature is that the receiver can be just about anything, such as `con."SELECT * ..."`. `con` is not available during class-init time, of course. Hence, it needs to be a 'static method' on the compile-time type of `con`, and java doesn't have a readily available mechanism to do such things. Perhaps an annotation on the `java.sql.Connection` type pointing at a type for which the classload mechanism can cook up a new instance via the no-args constructor which can then do this processing? Or go the route of `main` and `agentmain` and the serialization mechanism and employ structural typing: Look for a method with a specific name (that's.. not a part of the java spec I'm particular fond of). It goes some ways to address Stephen Colebourne's concerns, so perhaps it should be in scope. * Right now, writing `Pattern.compile("foo|bar")`, or even `input.replaceAll("someregexp", "replacement")` anywhere in java code is a performance problem: That means the regexp needs to be parsed every time that code is executed. The only way out right now is to have e.g. a `private static final Pattern p = "PATTERN_GOES_HERE"` at the top so that the regexp value itself is parsed, validated, and processed only once. That's annoying to do. That kind of trick isn't even available for `String.format`. However, adding this pre-processing step would solve the problem! You can write `Pattern."foo|bar"` anywhere, and during class load and init time, that is first turned into a `new TemplateString("foo|bar", new int[] {})`, handed to the 'RegexpValidator', which turns that into whatever it wants (presumably some sort of ValidatedRegExpTree object), and the actual code `Pattern."foo|bar"` is turned into an invoke that hands this ValidatedRegExpTree together with the parameters (which, here, is a zero-length list) to the TemplatePolicy. Analogous process for `String.format`. * The validation of these strings is now at least always done at class-init time instead of first-execution. This is a very pale shadow of compile-time checked of course as Stephen indicates, but still better presumably. If code has bugs, best that they occur sooner rather than later. * With this system in place, meshing this feature together with compiler-constant folding (see Brian's post and link to presentation) is a little closer: If the path to the RegexpValidator instance which turns a TemplateString into a ValidatedRegExpTree is entirely statically determinable and ValidatedRegExpTree is serializable, one day the compiler could run that step at compile time instead of at class-init time. Perhaps the answer for that need is to keep it out of scope for the first release of this feature but needs to be on the horizon as 'eventually we do want to get there'. --Reinier Zwitserloot On Thu, 16 Sept 2021 at 16:30, Jim Laskey wrote: > Dear amber-dev, > > Over on amber-spec-experts, I?ve posted a proposal for ?string templates?. > I > hope people are as excited about this feature as we expect they will be. > > As a brief reminder, the amber-dev list is not, in general, for language > design discussions; this list is primarily for discussion of > implementation, > bug repoorts, experience reports, etc. We should let the experts do their > job without having to follow parallel discussions on multiple lists. > > If people want to post brief, reasoned feedback on the approach, > applicability, or usefulness (but *NOT* the syntax) of the proposal here, > that would be fine. Please, let?s keep it constructive. > > Cheers, > > -- Jim > > > From brian.goetz at oracle.com Wed Oct 13 20:22:13 2021 From: brian.goetz at oracle.com (Brian Goetz) Date: Wed, 13 Oct 2021 16:22:13 -0400 Subject: Combining records and enumerations In-Reply-To: <6c8fa4a6-e71b-52f4-7ee0-a8b7bb013c7b@azul.com> References: <6c8fa4a6-e71b-52f4-7ee0-a8b7bb013c7b@azul.com> Message-ID: Yes, we considered exactly this during the design process of records. There's nothing _wrong_ with this, and it's consistent with what records does with the component list.? But we concluded that it fell short of the "carries its weight" threshold.? Records acquire fields, accessors, ctors, equals, hashCode, toString, and soon, dtors.? But enums already have their own equals/hashCode/toString, and deconstruction makes less sense, so for enums it would be only fields and ctor, and maybe accessors.? So the benefit is less.? Add to that that there are many fewer enums than there are likely to be records, the benefit is even lesser. Finally, we have deliberately held the corresponding syntactic position for classes uncolonized: ??? class Foo(SOMETHING MIGHT GO HERE EVENTUALLY) { ... } pending deeper thinking on what the right thing to do is.? There were many eager suggestions in the previous round, none of them seemed quite right, but its quite possible something good might emerge.? In which case it might make more sense for whatever goes in that position for enums, to be more like what classes do than like what records do.? So that's another reason to hold off doing anything special for enums. On 10/12/2021 4:10 PM, Simon Ritter wrote: > I hope this is the right list to post this to. > > I was recently using an enumeration and it struck me that enums > containing a constructor and member declarations could be simplified > by adopting some of the syntax from records. > > Here is an example of such an enumeration: > > public enum Planet { > ? MERCURY(0.4, 0.055), > ? VENUS(0.7, 0.815), > ? EARTH(1.0, 1.0), > ? MARS(0.107, 1.5); > > ? private double orbitalDistance; > ? private double earthMass; > > ? Planet(double orbitalDistance, double earthMass) { > ??? this.orbitalDistance = orbitalDistance; > ??? this.earthMass = earthMass; > ? } > > ? public double orbitalDistance() { > ??? return orbitalDistance; > ? } > > ? public double earthMass() { > ??? return earthMass; > ? } > } > > Most of this boiler-plate code is identical to the code eliminated by > a record from a simple data class.? If we took the same approach we > could simplify this as: > > public enum Planet(double orbitalDistance, double earthMass) { > ? MERCURY(0.4, 0.055), > ? VENUS(0.7, 0.815), > ? EARTH(1.0, 1.0), > ? MARS(0.107, 1.5); > } > > The grammar for enumerations would only need to be extended to include > an EnumHeader > > EnumDeclaration: {ClassModifier} enum TypeIdentifier EnumHeader > [ClassImplements] EnumBody > > with EnumHeader using the same format as RecordHeader > > EnumHeader: > ? ( [EnumComponentList] ) > > I'm assuming changes to the compiler to implement this would not be > overly complex (although I have not looked at the code). > > I'd be very interested to hear other people's opinion on this. > > Regards, > > Simon. > From brian.goetz at oracle.com Wed Oct 13 20:46:30 2021 From: brian.goetz at oracle.com (Brian Goetz) Date: Wed, 13 Oct 2021 16:46:30 -0400 Subject: Strings and things In-Reply-To: References: Message-ID: > I love where this feature is going. I like that you are excited about it, but maybe a little too excited; there's a real danger that it gets taken too far, and I think you're there.? Notes inline. > There are a few use cases and intended effects (at least, I assume they are > intended) that this feature would have which the document doesn't name. I'm > not sure if it's fully on the radar of Jim and Brian. > > ## Regexp literals > > "Make the language support regexp literals natively" is a feature request > that (in my experience) comes up _a lot_, and it was more or less > determined to be part of the bathwater during the text-block discussion (in > that 'raw strings' were ejected from that proposal). That was mostly about > changing how java interpolates backslashes in string literals which this > feature will not solve. However, surely: > > Pattern."^foo|bar$" Meh.? Aside from the "long" name of "compile", this is no different than, and only trivially shorter than, ??? Pattern.of("^foo|bar$"); What you want is _opportunistic constant folding_, as outlined here https://www.youtube.com/watch?v=iSEjlLFCS3E , where the pattern factory can be marked as "if you call me with constants, I can return a constant", and translated with condy.? (See the video for bonus points; it might even be evaluatable at compile time, and syntax errors in the regex could be turned into compilation errors.)? But all of this is orthogonal to the syntax. (Note too that putting a type on the LHS is not currently supported, and won't be until we have something like type classes.) At this point, using this feature _just_ because you get constantization is kind of an abuse.? You could easily do the same with ??? private static final Pattern PAT = Pattern.compile(...); Sure, moving it to the point of use is cool, but that's not the goal.? Its a cute hack, though! > ## A small issue: The type of the formatted string. > > Cay mentioned this as well (in the context of how other languages do it), > but right now the proposal uses `String templateString` (in TemplatedString > / TemplatePolicy), but it's not obvious what this string would contain. > Presumably not just "Hello {name} you are {age} years old" - a policy would > have no way to differentiate a 'hole' like "{name}" from a literal open > brace character. I assume this is something to be worked on later? There's a special unicode character for "insertion point." > As long as that object is constructed only once in the runtime, that > doesn't seem like a costly move, performance-wise. But, it would be nice if > the code that actually runs to process that object + the `List` of > params gets to also rely on some pre-processing "only once" without > handrolling a lazy-initializing system. As Stephen indicated, some of the > use cases of this feature have non-trivial preprocessing needs (and usually > validation needs as well). Brian mentioned that a lot of the 'cost' in the > java ecosystem's use of `String.format` is the overhead of reparsing that > format string over and over again. This would eliminate the runtime cost > down to once-per-literal which sounds like a worthwhile endeavour, no? See the comments on the amber-spec-experts today; we have this working already (the JEP alludes to this, but doesn't dwell on it much) but our approach is pretty different.? We get there without adding language complexity. > A 'static method' in an interface (not a thing in java right now) seems > like an answer here This is one of those ideas that seems obviously sensible until you work the details and realize how `static` has messed up nearly every job it's ever been given, and we don't want to give it more jobs to mess up.? (Our C# friends have exposed something like type classes with abstract statics in interfaces for C#10, but their language is different, and they're able to get away with it in ways we are not.)? There's an equally "obvious but wrong" path called "implements static", that dead-ends in the same place.? Really, you're waiting for type classes. > * Right now, writing `Pattern.compile("foo|bar")`, or even > `input.replaceAll("someregexp", "replacement")` anywhere in java code is a > performance problem: That means the regexp needs to be parsed every time > that code is executed. I get it, but you're summoning the devil to make a bad bargain here.? This isn't a feature about constantization of arbitrary expressions.? I get that today you're saying "it would be just good enough if I could have 10% of that feature", but I promise you, the other 90% will eventually whisper into your ear.? That's a whole feature area in itself -- and a much bigger one. From forax at univ-mlv.fr Wed Oct 13 22:31:51 2021 From: forax at univ-mlv.fr (Remi Forax) Date: Thu, 14 Oct 2021 00:31:51 +0200 (CEST) Subject: Combining records and enumerations In-Reply-To: References: <6c8fa4a6-e71b-52f4-7ee0-a8b7bb013c7b@azul.com> Message-ID: <563836659.1721021.1634164311980.JavaMail.zimbra@u-pem.fr> ----- Original Message ----- > From: "Brian Goetz" > To: "Simon Ritter" , "amber-dev" > Sent: Mercredi 13 Octobre 2021 22:22:13 > Subject: Re: Combining records and enumerations > Yes, we considered exactly this during the design process of records. > > There's nothing _wrong_ with this, and it's consistent with what records > does with the component list.? But we concluded that it fell short of > the "carries its weight" threshold.? Records acquire fields, accessors, > ctors, equals, hashCode, toString, and soon, dtors.? But enums already > have their own equals/hashCode/toString, and deconstruction makes less > sense, so for enums it would be only fields and ctor, and maybe > accessors.? So the benefit is less.? Add to that that there are many > fewer enums than there are likely to be records, the benefit is even lesser. There is a benefit, you can not declare a non final field with this syntax. I'm not sure it's enough to tip of the balance ... > > Finally, we have deliberately held the corresponding syntactic position > for classes uncolonized: > > ??? class Foo(SOMETHING MIGHT GO HERE EVENTUALLY) { ... } > > pending deeper thinking on what the right thing to do is.? There were > many eager suggestions in the previous round, none of them seemed quite > right, but its quite possible something good might emerge.? In which > case it might make more sense for whatever goes in that position for > enums, to be more like what classes do than like what records do.? So > that's another reason to hold off doing anything special for enums. R?mi > > > > On 10/12/2021 4:10 PM, Simon Ritter wrote: >> I hope this is the right list to post this to. >> >> I was recently using an enumeration and it struck me that enums >> containing a constructor and member declarations could be simplified >> by adopting some of the syntax from records. >> >> Here is an example of such an enumeration: >> >> public enum Planet { >> ? MERCURY(0.4, 0.055), >> ? VENUS(0.7, 0.815), >> ? EARTH(1.0, 1.0), >> ? MARS(0.107, 1.5); >> >> ? private double orbitalDistance; >> ? private double earthMass; >> >> ? Planet(double orbitalDistance, double earthMass) { >> ??? this.orbitalDistance = orbitalDistance; >> ??? this.earthMass = earthMass; >> ? } >> >> ? public double orbitalDistance() { >> ??? return orbitalDistance; >> ? } >> >> ? public double earthMass() { >> ??? return earthMass; >> ? } >> } >> >> Most of this boiler-plate code is identical to the code eliminated by >> a record from a simple data class.? If we took the same approach we >> could simplify this as: >> >> public enum Planet(double orbitalDistance, double earthMass) { >> ? MERCURY(0.4, 0.055), >> ? VENUS(0.7, 0.815), >> ? EARTH(1.0, 1.0), >> ? MARS(0.107, 1.5); >> } >> >> The grammar for enumerations would only need to be extended to include >> an EnumHeader >> >> EnumDeclaration: {ClassModifier} enum TypeIdentifier EnumHeader >> [ClassImplements] EnumBody >> >> with EnumHeader using the same format as RecordHeader >> >> EnumHeader: >> ? ( [EnumComponentList] ) >> >> I'm assuming changes to the compiler to implement this would not be >> overly complex (although I have not looked at the code). >> >> I'd be very interested to hear other people's opinion on this. >> >> Regards, >> >> Simon. From gavin.bierman at oracle.com Thu Oct 14 09:19:44 2021 From: gavin.bierman at oracle.com (Gavin Bierman) Date: Thu, 14 Oct 2021 09:19:44 +0000 Subject: Pattern Matching for switch (Second Preview) In-Reply-To: <158903792.1719028.1632343025468.JavaMail.zimbra@u-pem.fr> References: <5321c128-ba4d-e405-255a-72025a002e0d@oracle.com> <158903792.1719028.1632343025468.JavaMail.zimbra@u-pem.fr> Message-ID: <7DBCD1AF-67C6-44F6-B10F-D8614BEE8BD5@oracle.com> Hi Remi, Just circling back to this suggestion of yours: > On 22 Sep 2021, at 21:37, Remi Forax wrote: > > And i think we should also fix the following > > 4. a case that mix constants and a type pattern (or a guard) of a supertype of the types of the constants should be allowed > By example, > case 3, Integer i -> > or > case 4, Object o -> I?m not really convinced this carries its own weight. Both examples are a little odd as the type pattern subsumes the constant, so they don?t really offer much in terms of expressiveness. I tried following this train of thought and fiddled around with new ways of writing enum constant labels, but still the benefits seems modest at best, at least to me. I think my main concern about this train of thought is that it is really tinkering at the level of switch labels. (I know we did something for null, but null is very special/annoying.) I believe it will be more profitable for us to consider better *patterns* in this area. For example, (nested) constant patterns - e.g. Point(=0, var y) - range patterns - e.g. Point(0..42, var y) etc. Thanks, Gavin From forax at univ-mlv.fr Thu Oct 14 09:46:54 2021 From: forax at univ-mlv.fr (forax at univ-mlv.fr) Date: Thu, 14 Oct 2021 11:46:54 +0200 (CEST) Subject: Pattern Matching for switch (Second Preview) In-Reply-To: <7DBCD1AF-67C6-44F6-B10F-D8614BEE8BD5@oracle.com> References: <5321c128-ba4d-e405-255a-72025a002e0d@oracle.com> <158903792.1719028.1632343025468.JavaMail.zimbra@u-pem.fr> <7DBCD1AF-67C6-44F6-B10F-D8614BEE8BD5@oracle.com> Message-ID: <730001460.1945510.1634204814982.JavaMail.zimbra@u-pem.fr> ----- Original Message ----- > From: "Gavin Bierman" > To: "Remi Forax" > Cc: "amber-dev" > Sent: Jeudi 14 Octobre 2021 11:19:44 > Subject: Re: Pattern Matching for switch (Second Preview) > Hi Remi, > > Just circling back to this suggestion of yours: > >> On 22 Sep 2021, at 21:37, Remi Forax wrote: >> >> And i think we should also fix the following >> >> 4. a case that mix constants and a type pattern (or a guard) of a supertype of >> the types of the constants should be allowed >> By example, >> case 3, Integer i -> >> or >> case 4, Object o -> > > I?m not really convinced this carries its own weight. Both examples are a little > odd as the type pattern subsumes the constant, so they don?t really offer much > in terms of expressiveness. I tried following this train of thought and fiddled > around with new ways of writing enum constant labels, but still the benefits > seems modest at best, at least to me. Yes, it's more a comfort in term of reading because you can always remove the constant and only keep the type pattern. Here is an example using an AST tree. sealed interface Expr permits ... {} sealed interface Lit permits ... extends Expr {} enum Bool implements Lit { TRUE, FALSE } switch(expr) { // some Expr case Bool.TRUE -> ... case Bool.FALSE, Lit lit -> ... // other Expr } which is i believe more readable than switch(expr) { // some Expr case Bool.TRUE -> ... case Lit lit -> ... // other Expr } but you're right that it may not worth the trouble. > > I think my main concern about this train of thought is that it is really > tinkering at the level of switch labels. (I know we did something for null, but > null is very special/annoying.) I believe it will be more profitable for us to > consider better *patterns* in this area. For example, (nested) constant > patterns - e.g. Point(=0, var y) - range patterns - e.g. Point(0..42, var y) > etc. =0 is quite weird but i see why you do not want to use ==0 like in C# > > Thanks, > Gavin R?mi From talden at gmail.com Thu Oct 14 11:43:54 2021 From: talden at gmail.com (Aaron Scott-Boddendijk) Date: Fri, 15 Oct 2021 00:43:54 +1300 Subject: Combining records and enumerations In-Reply-To: References: <6c8fa4a6-e71b-52f4-7ee0-a8b7bb013c7b@azul.com> Message-ID: In two of my projects (unfortunately closed-source), both with over 100 enums, nearly half look like they would convert to this pattern (our enums often have additional attributes, a strength of Java enums). There's a significant percentage of the enum-type body dedicated to ceremony that this would eliminate. For a small proportion in each it also looks likely that destructuring _would_ be useful as the enums implement interfaces (another nice Java enum strength) and apply logic that should map well to pattern-matching. A single-line method syntax for delegation to the interface methods would further build on this. FYI, I really dislike the deconstruction term, as in general conversation 'construction' tends to imply allocation as well as constructor invocation. Destructuring seems a more precise term and one that several languages already use - and it then also covers destructuring patterns for types for which there was no equivalent 'constructor' (eg array/slice destructuring patterns). -- Aaron On Thu, Oct 14, 2021 at 9:22 AM Brian Goetz wrote: > Yes, we considered exactly this during the design process of records. > > There's nothing _wrong_ with this, and it's consistent with what records > does with the component list. But we concluded that it fell short of > the "carries its weight" threshold. Records acquire fields, accessors, > ctors, equals, hashCode, toString, and soon, dtors. But enums already > have their own equals/hashCode/toString, and deconstruction makes less > sense, so for enums it would be only fields and ctor, and maybe > accessors. So the benefit is less. Add to that that there are many > fewer enums than there are likely to be records, the benefit is even > lesser. > > Finally, we have deliberately held the corresponding syntactic position > for classes uncolonized: > > class Foo(SOMETHING MIGHT GO HERE EVENTUALLY) { ... } > > pending deeper thinking on what the right thing to do is. There were > many eager suggestions in the previous round, none of them seemed quite > right, but its quite possible something good might emerge. In which > case it might make more sense for whatever goes in that position for > enums, to be more like what classes do than like what records do. So > that's another reason to hold off doing anything special for enums. > > > > On 10/12/2021 4:10 PM, Simon Ritter wrote: > > I hope this is the right list to post this to. > > > > I was recently using an enumeration and it struck me that enums > > containing a constructor and member declarations could be simplified > > by adopting some of the syntax from records. > > > > Here is an example of such an enumeration: > > > > public enum Planet { > > MERCURY(0.4, 0.055), > > VENUS(0.7, 0.815), > > EARTH(1.0, 1.0), > > MARS(0.107, 1.5); > > > > private double orbitalDistance; > > private double earthMass; > > > > Planet(double orbitalDistance, double earthMass) { > > this.orbitalDistance = orbitalDistance; > > this.earthMass = earthMass; > > } > > > > public double orbitalDistance() { > > return orbitalDistance; > > } > > > > public double earthMass() { > > return earthMass; > > } > > } > > > > Most of this boiler-plate code is identical to the code eliminated by > > a record from a simple data class. If we took the same approach we > > could simplify this as: > > > > public enum Planet(double orbitalDistance, double earthMass) { > > MERCURY(0.4, 0.055), > > VENUS(0.7, 0.815), > > EARTH(1.0, 1.0), > > MARS(0.107, 1.5); > > } > > > > The grammar for enumerations would only need to be extended to include > > an EnumHeader > > > > EnumDeclaration: {ClassModifier} enum TypeIdentifier EnumHeader > > [ClassImplements] EnumBody > > > > with EnumHeader using the same format as RecordHeader > > > > EnumHeader: > > ( [EnumComponentList] ) > > > > I'm assuming changes to the compiler to implement this would not be > > overly complex (although I have not looked at the code). > > > > I'd be very interested to hear other people's opinion on this. > > > > Regards, > > > > Simon. > > > > From brian.goetz at oracle.com Thu Oct 14 12:40:35 2021 From: brian.goetz at oracle.com (Brian Goetz) Date: Thu, 14 Oct 2021 08:40:35 -0400 Subject: Combining records and enumerations In-Reply-To: References: <6c8fa4a6-e71b-52f4-7ee0-a8b7bb013c7b@azul.com> Message-ID: <54a44bbb-261c-0773-49d8-c36abccfdc5e@oracle.com> On 10/14/2021 7:43 AM, Aaron Scott-Boddendijk wrote: > In two of my projects (unfortunately closed-source), both with over 100 > enums, nearly half look like they would convert to this pattern (our enums > often have additional attributes, a strength of Java enums). > > There's a significant percentage of the enum-type body dedicated to > ceremony that this would eliminate. As I said, it's not a *bad* feature, it just has a worse return on investment than other features we could be working on.? We could prioritize this, but we'd have to deprioritize something else. Should we delay deconstruction patterns for six more months to make room for this?? Deconstruction patterns seem way more powerful. > FYI, I really dislike the deconstruction term, as in general conversation > 'construction' tends to imply allocation as well as constructor invocation. > Destructuring seems a more precise term and one that several languages > already use - and it then also covers destructuring patterns for types for > which there was no equivalent 'constructor' (eg array/slice destructuring > patterns). Naming things is hard. We considered using "destructuring" for all the reasons you suggest, but it is not without its problems either.? First, destructuring is a more general term than the concept being described here; what we are callling a "deconstruction pattern" is merely one form of destructuring, and there will be others.? And the name "destructurer" is impossible to spell or pronounce correctly.? More importantly, in the object model, this is the dual of construction, and to the degree users can see it that way, they will understand the concept more immediately.? Later features will be built on matching pairs of constructor and deconstructor (or deconstruction pattern).? The similarity in naming is important. The main problem with "deconstructor" is the potential confusion with "destructor" in C++. Naming things is hard. From duke at openjdk.java.net Thu Oct 14 22:06:56 2021 From: duke at openjdk.java.net (duke) Date: Thu, 14 Oct 2021 22:06:56 GMT Subject: git: openjdk/amber: stats-before-this-super: 75 new changesets Message-ID: Changeset: 97ea9dd2 Author: Matthias Baesken Date: 2021-10-08 06:40:18 +0000 URL: https://git.openjdk.java.net/amber/commit/97ea9dd2f24f9f1fb9b9345a4202a825ee28e014 8274840: Update OS detection code to recognize Windows 11 Co-authored-by: Arno Zeller Reviewed-by: clanger, dholmes ! src/hotspot/os/windows/os_windows.cpp ! src/java.base/windows/native/libjava/java_props_md.c Changeset: b60837a7 Author: Doug Simon Date: 2021-10-08 08:06:53 +0000 URL: https://git.openjdk.java.net/amber/commit/b60837a7d5d6f920d2fb968369564df155dc1018 8272586: emit abstract machine code in hs-err logs Reviewed-by: kvn, dholmes ! src/hotspot/share/code/nmethod.cpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/compiler/disassembler.cpp ! src/hotspot/share/utilities/vmError.cpp ! src/hotspot/share/utilities/vmError.hpp + test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: 6364719c Author: Coleen Phillimore Date: 2021-10-08 12:23:19 +0000 URL: https://git.openjdk.java.net/amber/commit/6364719cd1c57220769ea580d958da8dc2fdf7f9 8274004: Change 'nonleaf' rank name 8273956: Add checking for rank values Reviewed-by: dholmes, pchilanomate ! src/hotspot/os/aix/osThread_aix.cpp ! src/hotspot/os/bsd/osThread_bsd.cpp ! src/hotspot/os/linux/osThread_linux.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/compiler/compileTask.hpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1ServiceThread.cpp ! src/hotspot/share/gc/g1/heapRegion.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/shared/gcLogPrecious.cpp ! src/hotspot/share/gc/shared/oopStorage.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/taskTerminator.cpp ! src/hotspot/share/gc/shared/workgroup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp ! src/hotspot/share/gc/shenandoah/shenandoahPacer.hpp ! src/hotspot/share/gc/z/zMessagePort.inline.hpp ! src/hotspot/share/gc/z/zMetronome.cpp ! src/hotspot/share/memory/heapInspection.hpp ! src/hotspot/share/memory/metaspace/testHelpers.cpp ! src/hotspot/share/oops/methodData.cpp ! src/hotspot/share/prims/jvmtiTagMap.cpp ! src/hotspot/share/runtime/handshake.cpp ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/stackWatermark.cpp ! src/hotspot/share/runtime/vmOperations.cpp ! src/hotspot/share/runtime/vmThread.cpp ! src/hotspot/share/services/heapDumper.cpp ! src/hotspot/share/services/heapDumperCompression.cpp ! src/hotspot/share/services/memoryManager.cpp ! src/hotspot/share/utilities/concurrentHashTable.inline.hpp ! src/hotspot/share/utilities/events.hpp ! test/hotspot/gtest/metaspace/test_is_metaspace_obj.cpp ! test/hotspot/gtest/metaspace/test_metaspacearena.cpp ! test/hotspot/gtest/metaspace/test_metaspacearena_stress.cpp ! test/hotspot/gtest/runtime/test_mutex.cpp - test/hotspot/gtest/runtime/test_safepoint_locks.cpp ! test/hotspot/gtest/utilities/test_filterQueue.cpp Changeset: 2aacd422 Author: Roland Westrelin Date: 2021-10-08 14:48:35 +0000 URL: https://git.openjdk.java.net/amber/commit/2aacd4220a01b467de671212c7a74e6c81a2ad3c 8274145: C2: condition incorrectly made redundant with dominating main loop exit condition Reviewed-by: kvn, neliasso ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/loopopts.cpp + test/hotspot/jtreg/compiler/loopopts/TestIfReplacedByMainLoopExit.java Changeset: 36b89a18 Author: Christian Hagedorn Date: 2021-10-08 14:51:18 +0000 URL: https://git.openjdk.java.net/amber/commit/36b89a18931d42b8002a843ec8218b5c1ba54374 8274785: ciReplay: Potential crash due to uninitialized Compile::_ilt variable Reviewed-by: neliasso, kvn ! src/hotspot/share/opto/compile.cpp Changeset: ccbce107 Author: Sergey Tsypanov Committer: Jayathirth D V Date: 2021-10-08 15:58:36 +0000 URL: https://git.openjdk.java.net/amber/commit/ccbce107f299c3b1c444e819c1fda7ae3c4866b5 8272756: Remove unnecessary explicit initialization of volatile variables in java.desktop Reviewed-by: jdv, aivanov ! src/java.desktop/macosx/classes/sun/lwawt/LWLightweightFramePeer.java ! src/java.desktop/macosx/classes/sun/lwawt/LWWindowPeer.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CCheckboxMenuItem.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformEmbeddedFrame.java ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CWarningWindow.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/tiff/TIFFIFD.java ! src/java.desktop/share/classes/com/sun/media/sound/DirectAudioDevice.java ! src/java.desktop/share/classes/com/sun/media/sound/SoftAudioPusher.java ! src/java.desktop/share/classes/com/sun/media/sound/SoftSynthesizer.java ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/java/awt/Container.java ! src/java.desktop/share/classes/java/awt/Dialog.java ! src/java.desktop/share/classes/java/awt/Window.java ! src/java.desktop/share/classes/java/awt/event/InvocationEvent.java ! src/java.desktop/share/classes/java/awt/font/NumericShaper.java ! src/java.desktop/share/classes/javax/swing/JComponent.java ! src/java.desktop/share/classes/sun/awt/AppContext.java ! src/java.desktop/share/classes/sun/awt/datatransfer/SunClipboard.java ! src/java.desktop/share/classes/sun/awt/dnd/SunDragSourceContextPeer.java ! src/java.desktop/share/classes/sun/java2d/Disposer.java ! src/java.desktop/share/classes/sun/java2d/marlin/RendererStats.java ! src/java.desktop/unix/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/java.desktop/unix/classes/sun/awt/X11/ListHelper.java ! src/java.desktop/unix/classes/sun/awt/X11/XInputMethod.java ! src/java.desktop/unix/classes/sun/awt/X11/XLightweightFramePeer.java ! src/java.desktop/unix/classes/sun/awt/X11/XWarningWindow.java ! src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java ! src/java.desktop/windows/classes/sun/awt/windows/WObjectPeer.java Changeset: ec199072 Author: Naoto Sato Date: 2021-10-08 16:11:22 +0000 URL: https://git.openjdk.java.net/amber/commit/ec199072c5867624d66840238cc8828e16ae8da7 8274864: Remove Amman/Cairo hacks in ZoneInfoFile Reviewed-by: iris, joehw ! src/java.base/share/classes/sun/util/calendar/ZoneInfoFile.java Changeset: 239a35aa Author: Brian Burkhalter Date: 2021-10-08 16:43:16 +0000 URL: https://git.openjdk.java.net/amber/commit/239a35aa9166d0cb0b20850e1b52ad23b653d8d0 8233749: Files.exists javadoc doesn't mention eating IOException Reviewed-by: lancea, alanb ! src/java.base/share/classes/java/nio/file/Files.java Changeset: 3cb9724e Author: Coleen Phillimore Date: 2021-10-08 21:10:42 +0000 URL: https://git.openjdk.java.net/amber/commit/3cb9724ed94a7267853c5cddb18b4ae868ecf2e9 8274934: Attempting to acquire lock JNICritical_lock/41 out of order with lock MultiArray_lock/41 Reviewed-by: dcubed, iklam ! src/hotspot/share/runtime/mutexLocker.cpp Changeset: 9c431dd1 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-08 23:08:05 +0000 URL: https://git.openjdk.java.net/amber/commit/9c431dd168c8a752d4aa1bde2268db0425d76990 8274900: Too weak variable type leads to unnecessary cast in jdk.javadoc Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SourceToHTMLConverter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/builders/SerializedFormBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/SummaryAPIListBuilder.java Changeset: f640c7aa Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-09 00:46:20 +0000 URL: https://git.openjdk.java.net/amber/commit/f640c7aaa852b6c0e9144654b7222a6777201370 8274806: Simplify equals() call on nullable variable and a constant in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CMenuItem.java ! src/java.desktop/share/classes/java/awt/Window.java ! src/java.desktop/share/classes/javax/swing/DefaultDesktopManager.java ! src/java.desktop/share/classes/javax/swing/JLayeredPane.java ! src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java ! src/java.desktop/share/classes/javax/swing/text/html/HTMLEditorKit.java ! src/java.desktop/share/classes/sun/java2d/SurfaceDataProxy.java ! src/java.desktop/share/classes/sun/print/RasterPrinterJob.java ! src/java.desktop/unix/classes/sun/awt/X11/XTaskbarPeer.java ! src/java.desktop/unix/classes/sun/print/UnixPrintJob.java ! src/java.desktop/windows/classes/sun/awt/windows/WDesktopProperties.java Changeset: aac6c4ea Author: Pankaj Bansal Date: 2021-10-09 03:52:53 +0000 URL: https://git.openjdk.java.net/amber/commit/aac6c4ea707fa592b2bcd7586c1fe61a19e3725e 8272229: BasicSplitPaneDivider:oneTouchExpandableChanged() returns leftButton and rightButton as null with GTKLookAndFeel Reviewed-by: serb, jdv, kizune ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java Changeset: 6d1d4d52 Author: Wang Huang Committer: Hamlin Li Date: 2021-10-09 08:19:17 +0000 URL: https://git.openjdk.java.net/amber/commit/6d1d4d52928ed38bbc73ddcbede5389995a8e65f 8268231: Aarch64: Use ldp in intrinsics for String.compareTo Co-authored-by: Wang Huang Co-authored-by: Sun Jianye Co-authored-by: Wu Yan Reviewed-by: ngasson, aph ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp Changeset: 2c83559e Author: Andrey Turbanov Committer: Sergey Bylokhov Date: 2021-10-10 08:41:52 +0000 URL: https://git.openjdk.java.net/amber/commit/2c83559eda410d268c6d8a56d7fd1c34f817cb83 8274882: Cleanup redundant boxing in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/Metacity.java ! src/java.desktop/share/classes/javax/swing/SwingUtilities.java ! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java ! src/java.desktop/share/classes/sun/awt/SunToolkit.java ! src/java.desktop/share/classes/sun/awt/image/VSyncedBSManager.java ! src/java.desktop/share/classes/sun/java2d/marlin/MarlinProperties.java ! src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java ! src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/java.desktop/windows/classes/sun/awt/windows/TranslucentWindowPainter.java Changeset: 296f8537 Author: lawrence.andrews Committer: Sergey Bylokhov Date: 2021-10-10 08:46:04 +0000 URL: https://git.openjdk.java.net/amber/commit/296f8537f71b84f194cf2718ac9b85ba6843cfa3 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java Reviewed-by: serb ! test/jdk/java/awt/print/Dialog/DialogOrient.java Changeset: 2ff3977a Author: Jie Fu Date: 2021-10-10 14:00:58 +0000 URL: https://git.openjdk.java.net/amber/commit/2ff3977a66c8d8b521cd0ad266ba954682a268ce 8275004: CDS build failure with gcc11 Reviewed-by: shade ! src/hotspot/share/cds/cdsConstants.hpp Changeset: 5ecc99bb Author: Lin Zang Date: 2021-10-11 01:56:34 +0000 URL: https://git.openjdk.java.net/amber/commit/5ecc99bbf55e631b5bfa07e2c36b38e820682363 8274620: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java is timing out Reviewed-by: cjplummer, dholmes ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! test/hotspot/jtreg/ProblemList.txt Changeset: a05873a2 Author: Ao Qi Committer: Jie Fu Date: 2021-10-11 02:17:56 +0000 URL: https://git.openjdk.java.net/amber/commit/a05873a225c40d12e60870794b9c993d1ea89cfe 8274952: jdk/jfr/api/consumer/TestRecordedFrameType.java failed when c1 disabled Reviewed-by: egahlin, jiefu ! test/jdk/jdk/jfr/api/consumer/TestRecordedFrameType.java Changeset: c032186b Author: Fei Gao Committer: Pengfei Li Date: 2021-10-11 06:59:37 +0000 URL: https://git.openjdk.java.net/amber/commit/c032186b421c64b44397cb7aa101b40e5f93dfff 8272968: AArch64: Remove redundant matching rules for commutative ops Reviewed-by: ngasson ! src/hotspot/cpu/aarch64/aarch64.ad Changeset: 49f8ce6e Author: Martin Doerr Date: 2021-10-11 10:31:54 +0000 URL: https://git.openjdk.java.net/amber/commit/49f8ce6e9c797cd11ea586e3cf87398888bc8cf1 8274773: [TESTBUG] UnsafeIntrinsicsTest intermittently fails on weak memory model platform Reviewed-by: eosterlund, goetz ! test/hotspot/jtreg/compiler/gcbarriers/UnsafeIntrinsicsTest.java Changeset: 3edee1e1 Author: Roman Kennke Date: 2021-10-11 10:37:54 +0000 URL: https://git.openjdk.java.net/amber/commit/3edee1e1feed564397ac47a32c0394d7798bac17 8272723: Don't use Access API to access primitive fields Reviewed-by: stefank, eosterlund ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/jvmci/jvmciJavaClasses.cpp ! src/hotspot/share/oops/instanceKlass.inline.hpp ! src/hotspot/share/oops/oop.cpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/typeArrayOop.inline.hpp ! src/hotspot/share/prims/unsafe.cpp Changeset: c55dd365 Author: Jie Fu Date: 2021-10-11 10:51:39 +0000 URL: https://git.openjdk.java.net/amber/commit/c55dd365e3463670697b09de0ff70877203e5a69 8275008: gtest build failure due to stringop-overflow warning with gcc11 Reviewed-by: dholmes, ihse ! make/hotspot/lib/CompileGtest.gmk Changeset: aaf2401b Author: Thomas Schatzl Date: 2021-10-11 11:46:46 +0000 URL: https://git.openjdk.java.net/amber/commit/aaf2401bc7d766dee5ffc623db86c4723c7e3760 8274927: Remove unnecessary G1ArchiveAllocator code Reviewed-by: kbarrett, ayang ! src/hotspot/share/gc/g1/g1Allocator.cpp ! src/hotspot/share/gc/g1/g1Allocator.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp Changeset: b7af8905 Author: Thomas Schatzl Date: 2021-10-11 11:48:50 +0000 URL: https://git.openjdk.java.net/amber/commit/b7af890574b3c13122fe7de987a8c9458c05f625 8274430: Remove some debug error printing code added in JDK-8017163 Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/heapRegion.cpp Changeset: 110e38de Author: Coleen Phillimore Date: 2021-10-11 12:11:11 +0000 URL: https://git.openjdk.java.net/amber/commit/110e38ded8e09361f24c582c770d35f5cfdabf82 8274753: ZGC: SEGV in MetaspaceShared::link_shared_classes 8274935: dumptime_table has stale entry Reviewed-by: eosterlund, iklam ! src/hotspot/share/cds/metaspaceShared.cpp ! src/hotspot/share/classfile/classLoaderData.cpp ! test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java Changeset: b870468b Author: Jan Lahoda Date: 2021-10-11 12:38:08 +0000 URL: https://git.openjdk.java.net/amber/commit/b870468bdc99938fbb19a41b0ede0a3e3769ace2 8274347: Passing a *nested* switch expression as a parameter causes an NPE during compile Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! test/langtools/tools/javac/api/TestGetScopeResult.java ! test/langtools/tools/javac/switchexpr/ExpressionSwitchInfer.java Changeset: 0d80f6cf Author: Patricio Chilano Mateo Date: 2021-10-11 13:34:42 +0000 URL: https://git.openjdk.java.net/amber/commit/0d80f6cf82ddab85f2461c7cc663a93bb222e988 8274379: Allow process of unsafe access errors in check_special_condition_for_native_trans Reviewed-by: rehn, dholmes ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/jvmtiEnv.cpp ! src/hotspot/share/runtime/safepoint.hpp ! src/hotspot/share/runtime/thread.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/runtime/thread.inline.hpp ! src/hotspot/share/runtime/vmStructs.cpp Changeset: 3f073377 Author: Zhengyu Gu Date: 2021-10-11 15:10:57 +0000 URL: https://git.openjdk.java.net/amber/commit/3f07337722a0c8c6b452a44745598268d67c0864 8273614: Shenandoah: intermittent timeout with ConcurrentGCBreakpoint tests Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp Changeset: 3f01d03a Author: Lin Zang Date: 2021-10-11 15:27:28 +0000 URL: https://git.openjdk.java.net/amber/commit/3f01d03a10cb3f647735ed4bbea1768ff18bf8f2 8275021: Test serviceability/sa/TestJmapCore.java fails with: java.io.IOException: Stack frame 0x4 not found Reviewed-by: dholmes, dcubed ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java Changeset: 83c37719 Author: Thomas Stuefe Date: 2021-10-11 15:48:10 +0000 URL: https://git.openjdk.java.net/amber/commit/83c37719290039672cf261701028c8eb044a2e77 8273881: Metaspace: test repeated deallocations Reviewed-by: dholmes, shade ! test/hotspot/gtest/metaspace/test_metaspacearena.cpp Changeset: 75f5145e Author: Zhengyu Gu Date: 2021-10-11 16:58:53 +0000 URL: https://git.openjdk.java.net/amber/commit/75f5145e21a1320c1a08080af861497ce7c3f266 8274925: Shenandoah: shenandoah/TestAllocHumongousFragment.java test failed on lock rank check Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp Changeset: 829dea45 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-11 19:19:39 +0000 URL: https://git.openjdk.java.net/amber/commit/829dea45c9ab90518f03a66aad7e681cd4fda8b3 8274945: Cleanup unnecessary calls to Throwable.initCause() in java.desktop Reviewed-by: jdv, serb, pbansal ! src/java.desktop/share/classes/com/sun/imageio/plugins/jpeg/MarkerSegment.java ! src/java.desktop/share/classes/javax/imageio/metadata/IIOMetadata.java ! src/java.desktop/share/classes/javax/imageio/spi/ImageReaderWriterSpi.java ! src/java.desktop/share/classes/sun/awt/datatransfer/TransferableProxy.java Changeset: dd93c6e2 Author: Sergey Bylokhov Date: 2021-10-12 00:14:00 +0000 URL: https://git.openjdk.java.net/amber/commit/dd93c6e27b66acebb221583fd28d03c65bfc1f24 8272167: AbsPathsInImage.java should skip *.dSYM directories Reviewed-by: ihse, erikj ! test/jdk/build/AbsPathsInImage.java Changeset: 1e306959 Author: Hamlin Li Date: 2021-10-12 01:25:00 +0000 URL: https://git.openjdk.java.net/amber/commit/1e3069593e6f56714e1ee557b70930c2749d820c 8274466: G1: use field directly rather than method in G1CollectorState::in_mixed_phase Reviewed-by: ayang, sjohanss ! src/hotspot/share/gc/g1/g1CollectorState.hpp Changeset: ef0922e8 Author: Aleksey Shipilev Date: 2021-10-12 05:56:15 +0000 URL: https://git.openjdk.java.net/amber/commit/ef0922e88528bdf4fe75537ddf4e82123e3f58b3 8274560: JFR: Add test for OldObjectSample event when using Shenandoah Reviewed-by: mgronlun ! test/jdk/jdk/jfr/event/oldobject/TestObjectDescription.java + test/jdk/jdk/jfr/event/oldobject/TestShenandoah.java Changeset: a5f09d10 Author: Aleksey Shipilev Date: 2021-10-12 06:22:13 +0000 URL: https://git.openjdk.java.net/amber/commit/a5f09d1088d9dd610139370739e9fbd6e34416cb 8275031: runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present Reviewed-by: dholmes, dnsimon ! src/hotspot/share/code/nmethod.cpp ! test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: cfe7471f Author: Aleksey Shipilev Date: 2021-10-12 07:24:15 +0000 URL: https://git.openjdk.java.net/amber/commit/cfe7471f1769eca2a4e623f5ba9cddceb005f0bf 8177814: jdk/editpad is not in jdk TEST.groups Reviewed-by: serb ! test/jdk/TEST.groups Changeset: 7d2633f7 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-12 09:37:54 +0000 URL: https://git.openjdk.java.net/amber/commit/7d2633f795c27edc2dfbbd7a9d9e44bdb23ec6a1 8275002: Remove unused AbstractStringBuilder.MAX_ARRAY_SIZE Reviewed-by: prappo, jlaskey, martin ! src/java.base/share/classes/java/lang/AbstractStringBuilder.java Changeset: 8de26361 Author: Kim Barrett Date: 2021-10-12 09:40:35 +0000 URL: https://git.openjdk.java.net/amber/commit/8de26361f7d789c7b317536198c891756038a8ea 8274615: Support relaxed atomic add for linux-aarch64 Reviewed-by: aph, dholmes ! src/hotspot/cpu/aarch64/atomic_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.S ! src/hotspot/os_cpu/linux_aarch64/atomic_linux_aarch64.hpp Changeset: 33050f80 Author: Doug Simon Date: 2021-10-12 09:49:50 +0000 URL: https://git.openjdk.java.net/amber/commit/33050f8013366f5e3a01ab1a75ba3fee9cc73089 8274986: max code printed in hs-err logs should be configurable Reviewed-by: never, dholmes ! src/hotspot/share/code/codeBlob.cpp ! src/hotspot/share/runtime/flags/jvmFlagLimit.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/utilities/vmError.cpp ! src/hotspot/share/utilities/vmError.hpp ! test/hotspot/jtreg/runtime/ErrorHandling/MachCodeFramesInErrorFile.java Changeset: d04d4ee2 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-12 11:14:31 +0000 URL: https://git.openjdk.java.net/amber/commit/d04d4ee2c193baf4339ee3025e3fbcd31d62f484 8274894: Use Optional.empty() instead of ofNullable(null) in HttpResponse.BodySubscribers.discarding Reviewed-by: dfuchs ! src/java.net.http/share/classes/java/net/http/HttpResponse.java Changeset: b460d6dd Author: kabutz Committer: Markus Gr?nlund Date: 2021-10-12 11:38:21 +0000 URL: https://git.openjdk.java.net/amber/commit/b460d6ddafcd1be76bcf407254f843df6bbfb70b 8275091: /src/jdk.management.jfr/share/classes/module-info.java has non-canonical order Reviewed-by: mgronlun ! src/jdk.management.jfr/share/classes/module-info.java Changeset: 1ab64143 Author: Zhengyu Gu Date: 2021-10-12 11:58:35 +0000 URL: https://git.openjdk.java.net/amber/commit/1ab64143c06e33e23172dd77c39e434443347364 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp Changeset: e16b93ad Author: Martin Doerr Date: 2021-10-12 12:18:49 +0000 URL: https://git.openjdk.java.net/amber/commit/e16b93ad52c96fddd9097c2cb0fa78ae781c547b 8274770: [PPC64] resolve_jobject needs a generic implementation to support load barriers Reviewed-by: goetz, nradomski ! src/hotspot/cpu/ppc/gc/shared/barrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/modRefBarrierSetAssembler_ppc.cpp ! src/hotspot/cpu/ppc/gc/shared/modRefBarrierSetAssembler_ppc.hpp Changeset: e393c5ea Author: Roman Kennke Date: 2021-10-12 13:16:20 +0000 URL: https://git.openjdk.java.net/amber/commit/e393c5ea9d9a254cdacbd311498c55c560e8ab25 8275074: Cleanup unused code in JFR LeakProfiler Reviewed-by: mgronlun ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.cpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.hpp - src/hotspot/share/jfr/leakprofiler/utilities/saveRestore.cpp - src/hotspot/share/jfr/leakprofiler/utilities/saveRestore.hpp Changeset: f6234606 Author: Christian Hagedorn Date: 2021-10-12 13:21:35 +0000 URL: https://git.openjdk.java.net/amber/commit/f62346066869b681d1cc9f63775393b11a48722a 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception" Reviewed-by: kvn, thartmann ! test/hotspot/jtreg/compiler/lib/ir_framework/driver/IRMatcher.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestRunTests.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/Utils.java Changeset: 07b1f1c2 Author: Brian Burkhalter Date: 2021-10-12 15:25:53 +0000 URL: https://git.openjdk.java.net/amber/commit/07b1f1c282ee0a7df6a6b0f240962a032ea3a413 8274548: (fc) FileChannel gathering write fails with IOException "Invalid argument" on macOS 11.6 Reviewed-by: alanb ! src/java.base/share/classes/sun/nio/ch/IOUtil.java ! src/java.base/unix/native/libnio/ch/IOUtil.c ! src/java.base/windows/native/libnio/ch/IOUtil.c + test/jdk/java/nio/channels/FileChannel/LargeGatheringWrite.java Changeset: 89999f70 Author: Dmitry Batrak Date: 2021-10-12 15:36:41 +0000 URL: https://git.openjdk.java.net/amber/commit/89999f70e06b41704c7c5b0f9a19582f90806a10 8275131: Exceptions after a touchpad gesture on macOS Reviewed-by: dmarkov, prr ! src/java.desktop/macosx/native/libawt_lwawt/awt/AWTWindow.m Changeset: b8bd259b Author: Evgeny Astigeevich Committer: Paul Hohensee Date: 2021-10-12 16:56:06 +0000 URL: https://git.openjdk.java.net/amber/commit/b8bd259bb83096f8727222a4e5cd84e80e096275 8271737: Only normalize the cached user.dir property once Reviewed-by: phh ! src/java.base/windows/classes/java/io/WinNTFileSystem.java Changeset: 8657f776 Author: Daniel D. Daugherty Date: 2021-10-12 17:05:47 +0000 URL: https://git.openjdk.java.net/amber/commit/8657f77608f37d7ff5254032858f2f16c7c204d5 8271514: support JFR use of new ThreadsList::Iterator Co-authored-by: Kim Barrett Reviewed-by: sspitsyn, mgronlun ! src/hotspot/share/jfr/utilities/jfrThreadIterator.cpp ! src/hotspot/share/jfr/utilities/jfrThreadIterator.hpp Changeset: 124f8237 Author: Sergey Tsypanov Committer: Sergey Bylokhov Date: 2021-10-12 19:13:17 +0000 URL: https://git.openjdk.java.net/amber/commit/124f82377ba93359bc59118ee315ba194080fa92 8268764: Use Long.hashCode() instead of int-cast where applicable Reviewed-by: kevinw, prr, kizune, serb ! src/java.desktop/share/classes/com/sun/media/sound/DLSSoundbank.java ! src/java.desktop/share/classes/com/sun/media/sound/WaveExtensibleFileReader.java ! src/java.rmi/share/classes/java/rmi/server/ObjID.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotResolvedJavaMethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/FieldImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/MethodImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ObjectReferenceImpl.java ! src/jdk.jdi/share/classes/com/sun/tools/jdi/ReferenceTypeImpl.java ! src/jdk.security.auth/share/classes/com/sun/security/auth/NTNumericCredential.java Changeset: 03c2b73e Author: Magnus Ihse Bursie Date: 2021-10-12 23:28:53 +0000 URL: https://git.openjdk.java.net/amber/commit/03c2b73e2112cdbcbd1230009de0a15a9bd31815 8275128: Build hsdis using normal build system Reviewed-by: erikj + make/Hsdis.gmk ! make/Main.gmk ! make/autoconf/configure.ac ! make/autoconf/help.m4 ! make/autoconf/jdk-options.m4 ! make/autoconf/spec.gmk.in ! src/utils/hsdis/README - src/utils/hsdis/hsdis-demo.c Changeset: b1b83500 Author: Daniel D. Daugherty Date: 2021-10-12 23:43:40 +0000 URL: https://git.openjdk.java.net/amber/commit/b1b83500a9c3a74bf39894e49eefd031d208b9b9 8275171: ProblemList compiler/codegen/aes/TestAESMain.java on linux-x64 and windows-x64 in -Xcomp mode Reviewed-by: iignatyev ! test/hotspot/jtreg/ProblemList-Xcomp.txt Changeset: ab34cced Author: Joe Darcy Date: 2021-10-13 05:26:33 +0000 URL: https://git.openjdk.java.net/amber/commit/ab34cced3beae765fe9d6b6acfef7e6a7f3082cd 8275186: Suppress warnings on non-serializable array component types in xml Reviewed-by: joehw ! src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/TargetLostException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/dv/DatatypeException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/io/MalformedByteSequenceException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaException.java ! src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/traversers/XSDComplexTypeTraverser.java ! src/java.xml/share/classes/com/sun/org/apache/xpath/internal/axes/UnionPathIterator.java Changeset: cf828673 Author: Martin Doerr Date: 2021-10-13 07:12:52 +0000 URL: https://git.openjdk.java.net/amber/commit/cf828673a9b76fd3f26db9a3f714166861a65c9e 8275049: [ZGC] missing null check in ZNMethod::log_register Reviewed-by: nradomski, eosterlund, pliden ! src/hotspot/share/gc/z/zNMethod.cpp Changeset: 337b73a4 Author: Niklas Radomski Committer: Martin Doerr Date: 2021-10-13 07:36:52 +0000 URL: https://git.openjdk.java.net/amber/commit/337b73a459ba24aa529b7b097617434be1d0030e 8274851: [PPC64] Port zgc to linux on ppc64le Reviewed-by: ihse, pliden, mdoerr, eosterlund ! make/autoconf/jvm-features.m4 ! make/hotspot/gensrc/GensrcAdlc.gmk ! src/hotspot/cpu/ppc/assembler_ppc.hpp + src/hotspot/cpu/ppc/gc/z/zBarrierSetAssembler_ppc.cpp + src/hotspot/cpu/ppc/gc/z/zBarrierSetAssembler_ppc.hpp + src/hotspot/cpu/ppc/gc/z/zGlobals_ppc.cpp + src/hotspot/cpu/ppc/gc/z/zGlobals_ppc.hpp + src/hotspot/cpu/ppc/gc/z/z_ppc.ad ! src/hotspot/cpu/ppc/ppc.ad ! src/hotspot/cpu/ppc/vmreg_ppc.hpp + src/hotspot/os_cpu/linux_ppc/gc/z/zSyscall_linux_ppc.hpp Changeset: c3b75c6c Author: Thomas Schatzl Date: 2021-10-13 08:10:55 +0000 URL: https://git.openjdk.java.net/amber/commit/c3b75c6cdf03ffa3c887bf3db29e17668b228f79 8274516: [REDO] JDK-8271880: Tighten condition for excluding regions from collecting cards with cross-references Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1EvacFailure.hpp ! src/hotspot/share/gc/g1/g1HeapRegionAttr.hpp ! src/hotspot/share/gc/g1/g1OopClosures.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/g1/g1YoungCollector.hpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.hpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp Changeset: dcf428c7 Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-10-13 09:07:07 +0000 URL: https://git.openjdk.java.net/amber/commit/dcf428c7a74e568deaededfc11d3c4e1bf7821f2 8275075: Remove unnecessary conversion to String in jdk.hotspot.agent Reviewed-by: sspitsyn, cjplummer ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/HSDB.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/interpreter/BytecodeLoadConstant.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/PerfDataEntry.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java Changeset: b8cb76ad Author: Jan Lahoda Date: 2021-10-13 10:15:54 +0000 URL: https://git.openjdk.java.net/amber/commit/b8cb76ad210cb3e7524c7f5b13cfe57746ac05d4 8273682: Upgrade Jline to 3.20.0 Reviewed-by: sundar ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Candidate.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/CompletionMatcher.java - src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/ConfigurationPath.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/EndOfFileException.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/LineReaderBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/Parser.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/PrintAboveWriter.java - src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/ScriptEngine.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/CompletionMatcherImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultHighlighter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/DefaultParser.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/LineReaderImpl.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/ReaderUtils.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/StringsCompleter.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/completer/SystemCompleter.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/reader/impl/history/DefaultHistory.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/Terminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/TerminalBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/impl/AbstractWindowsTerminal.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JansiSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/terminal/spi/JnaSupport.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedCharSequence.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedString.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedStringBuilder.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/AttributedStyle.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/ColorPalette.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Colors.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Curses.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Display.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/InfoCmp.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Log.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpInputStream.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/NonBlockingPumpReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/PumpReader.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/Signals.java ! src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/StyleResolver.java + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-basic.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-unicode-256color.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt-unicode.caps + src/jdk.internal.le/share/classes/jdk/internal/org/jline/utils/rxvt.caps ! src/jdk.internal.le/share/legal/jline.md ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/JnaSupportImpl.java ! src/jdk.internal.le/windows/classes/jdk/internal/org/jline/terminal/impl/jna/win/JnaWinSysTerminal.java ! test/jdk/jdk/internal/jline/AbstractWindowsTerminalTest.java ! test/jdk/jdk/internal/jline/KeyConversionTest.java Changeset: 5ffb5d10 Author: Andrey Turbanov Committer: Pavel Rappo Date: 2021-10-13 11:34:24 +0000 URL: https://git.openjdk.java.net/amber/commit/5ffb5d100f3383f9afaf20c8a659971522153505 8272992: Replace usages of Collections.sort with List.sort call in jdk.* modules Reviewed-by: cjplummer, prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassUseWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Group.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/JStatLogger.java ! src/jdk.jcmd/share/classes/sun/tools/jstat/Jstat.java ! src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XOpenTypeViewer.java Changeset: 451a2965 Author: Jie Fu Date: 2021-10-13 14:30:11 +0000 URL: https://git.openjdk.java.net/amber/commit/451a296510994ff9fe1e0381900ffa9a8a1caa54 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 Reviewed-by: chagedorn, thartmann ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCheckedTests.java Changeset: d8f6b6c1 Author: Fairoz Matte Committer: Ioi Lam Date: 2021-10-13 15:38:36 +0000 URL: https://git.openjdk.java.net/amber/commit/d8f6b6c19a591512ff4e956823cb87a83e088ae8 8274718: runtime/cds/appcds/LambdaEagerInit.java fails with -XX:-CompactStrings Reviewed-by: iklam, ccheung ! test/hotspot/jtreg/runtime/cds/appcds/LambdaEagerInit.java Changeset: d15fbc28 Author: Joe Darcy Date: 2021-10-13 16:53:46 +0000 URL: https://git.openjdk.java.net/amber/commit/d15fbc28afc3f2d509b4e46e70877a4650fafdc2 8275187: Suppress warnings on non-serializable array component types in java.sql.rowset Reviewed-by: lancea ! src/java.sql.rowset/share/classes/com/sun/rowset/internal/BaseRow.java ! src/java.sql.rowset/share/classes/com/sun/rowset/internal/CachedRowSetWriter.java ! src/java.sql.rowset/share/classes/com/sun/rowset/internal/Row.java Changeset: 1e0184d1 Author: lawrence.andrews Committer: Sergey Bylokhov Date: 2021-10-13 20:04:30 +0000 URL: https://git.openjdk.java.net/amber/commit/1e0184d142deb18e719fc28814a293b44bab6c63 8275234: java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java is entered twice in ProblemList Reviewed-by: serb, pbansal ! test/jdk/ProblemList.txt Changeset: 7dc2db4a Author: lawrence.andrews Committer: Sergey Bylokhov Date: 2021-10-13 20:06:35 +0000 URL: https://git.openjdk.java.net/amber/commit/7dc2db4aacfeea0caffcc76fd352eabf64ee34c4 8274032: Remove jtreg tag manual=yesno for java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java & show test UI Reviewed-by: serb, pbansal ! test/jdk/java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java Changeset: d9e03e42 Author: Joe Darcy Date: 2021-10-13 20:19:04 +0000 URL: https://git.openjdk.java.net/amber/commit/d9e03e42afbb2e5115b67accfffad4938b8314b1 8275244: Suppress warnings on non-serializable array component types in jdk.management Reviewed-by: alanb ! src/jdk.management/share/classes/com/sun/management/internal/GcInfoCompositeData.java Changeset: 8b1b6f9f Author: TatWai Chong Committer: Nick Gasson Date: 2021-10-14 05:27:12 +0000 URL: https://git.openjdk.java.net/amber/commit/8b1b6f9fb375bbc2de339ad8f526ca4d5f83dc70 8269559: AArch64: Implement string_compare intrinsic in SVE Reviewed-by: ngasson, aph ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_sve.ad ! src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/register_aarch64.hpp ! src/hotspot/cpu/aarch64/register_definitions_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! test/hotspot/gtest/aarch64/aarch64-asmtest.py ! test/hotspot/gtest/aarch64/asmtest.out.h + test/micro/org/openjdk/bench/java/lang/StringCompareToDifferentLength.java Changeset: 333c4692 Author: Nick Gasson Date: 2021-10-14 09:35:48 +0000 URL: https://git.openjdk.java.net/amber/commit/333c4692d898d582fe162cc9621acd3e1c242d67 8275262: [BACKOUT] AArch64: Implement string_compare intrinsic in SVE Reviewed-by: dholmes, tschatzl ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_sve.ad ! src/hotspot/cpu/aarch64/aarch64_sve_ad.m4 ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/register_aarch64.hpp ! src/hotspot/cpu/aarch64/register_definitions_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! test/hotspot/gtest/aarch64/aarch64-asmtest.py ! test/hotspot/gtest/aarch64/asmtest.out.h - test/micro/org/openjdk/bench/java/lang/StringCompareToDifferentLength.java Changeset: 8d9004b7 Author: Hannes Walln?fer Date: 2021-10-14 12:19:26 +0000 URL: https://git.openjdk.java.net/amber/commit/8d9004b7f4fd9b53d3f2240b382e7d71d7399125 8274781: Use monospace font for enclosing interface Reviewed-by: prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ClassWriterImpl.java ! test/langtools/jdk/javadoc/doclet/testHiddenTag/TestHiddenTag.java ! test/langtools/jdk/javadoc/doclet/testLinkTaglet/TestLinkTaglet.java Changeset: 3b0b6adc Author: Zhengyu Gu Date: 2021-10-14 12:52:12 +0000 URL: https://git.openjdk.java.net/amber/commit/3b0b6adc3d547fcf4b971536d2404c342d18046f 8275226: Shenandoah: Relax memory constraint for worker claiming tasks/ranges Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahNMethod.cpp ! src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahTaskqueue.hpp Changeset: 54b88707 Author: Per Liden Date: 2021-10-14 14:05:36 +0000 URL: https://git.openjdk.java.net/amber/commit/54b887076612c0eaa410a849178f8ba0c4ed3eeb 8275035: Clean up worker thread infrastructure Reviewed-by: stefank, ayang ! src/hotspot/share/gc/epsilon/epsilonArguments.cpp ! src/hotspot/share/gc/epsilon/epsilonHeap.cpp - src/hotspot/share/gc/g1/g1BatchedGangTask.cpp - src/hotspot/share/gc/g1/g1BatchedGangTask.hpp + src/hotspot/share/gc/g1/g1BatchedTask.cpp + src/hotspot/share/gc/g1/g1BatchedTask.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectionSetCandidates.hpp ! src/hotspot/share/gc/g1/g1CollectionSetChooser.cpp ! src/hotspot/share/gc/g1/g1CollectionSetChooser.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1EvacFailure.cpp ! src/hotspot/share/gc/g1/g1EvacFailure.hpp ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/g1/g1FullCollector.hpp ! src/hotspot/share/gc/g1/g1FullGCTask.hpp ! src/hotspot/share/gc/g1/g1HeapVerifier.cpp ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.cpp ! src/hotspot/share/gc/g1/g1PageBasedVirtualSpace.hpp ! src/hotspot/share/gc/g1/g1ParallelCleaning.cpp ! src/hotspot/share/gc/g1/g1ParallelCleaning.hpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.cpp ! src/hotspot/share/gc/g1/g1RegionToSpaceMapper.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSet.hpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/g1/g1YoungCollector.hpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.hpp ! src/hotspot/share/gc/g1/heapRegionManager.cpp ! src/hotspot/share/gc/g1/heapRegionManager.hpp ! src/hotspot/share/gc/parallel/mutableNUMASpace.cpp ! src/hotspot/share/gc/parallel/mutableNUMASpace.hpp ! src/hotspot/share/gc/parallel/mutableSpace.cpp ! src/hotspot/share/gc/parallel/mutableSpace.hpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.cpp ! src/hotspot/share/gc/parallel/parallelScavengeHeap.hpp ! src/hotspot/share/gc/parallel/psCompactionManager.cpp ! src/hotspot/share/gc/parallel/psOldGen.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/gc/parallel/psYoungGen.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.hpp ! src/hotspot/share/gc/shared/parallelCleaning.hpp ! src/hotspot/share/gc/shared/preservedMarks.cpp ! src/hotspot/share/gc/shared/preservedMarks.hpp ! src/hotspot/share/gc/shared/pretouchTask.cpp ! src/hotspot/share/gc/shared/pretouchTask.hpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp ! src/hotspot/share/gc/shared/space.hpp ! src/hotspot/share/gc/shared/weakProcessor.cpp ! src/hotspot/share/gc/shared/weakProcessor.hpp ! src/hotspot/share/gc/shared/weakProcessor.inline.hpp - src/hotspot/share/gc/shared/workerManager.hpp + src/hotspot/share/gc/shared/workerThread.cpp + src/hotspot/share/gc/shared/workerThread.hpp + src/hotspot/share/gc/shared/workerUtils.cpp + src/hotspot/share/gc/shared/workerUtils.hpp - src/hotspot/share/gc/shared/workgroup.cpp - src/hotspot/share/gc/shared/workgroup.hpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.cpp ! src/hotspot/share/gc/shenandoah/shenandoahCodeRoots.hpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahParallelCleaning.cpp ! src/hotspot/share/gc/shenandoah/shenandoahParallelCleaning.hpp ! src/hotspot/share/gc/shenandoah/shenandoahParallelCleaning.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.hpp ! src/hotspot/share/gc/shenandoah/shenandoahSTWMark.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/shenandoah/shenandoahWorkGroup.cpp ! src/hotspot/share/gc/shenandoah/shenandoahWorkGroup.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/gc/z/zRuntimeWorkers.cpp ! src/hotspot/share/gc/z/zRuntimeWorkers.hpp ! src/hotspot/share/gc/z/zTask.cpp ! src/hotspot/share/gc/z/zTask.hpp ! src/hotspot/share/gc/z/zWorkers.cpp ! src/hotspot/share/gc/z/zWorkers.hpp ! src/hotspot/share/logging/logPrefix.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/heapInspection.cpp ! src/hotspot/share/memory/heapInspection.hpp ! src/hotspot/share/runtime/nonJavaThread.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/sweeper.cpp ! src/hotspot/share/runtime/thread.hpp ! src/hotspot/share/services/heapDumper.cpp ! test/hotspot/gtest/gc/g1/test_g1BatchedGangTask.cpp ! test/hotspot/gtest/gc/g1/test_g1CardSet.cpp ! test/hotspot/gtest/gc/g1/test_stressCommitUncommit.cpp ! test/hotspot/gtest/gc/shared/test_oopStorage.cpp ! test/hotspot/gtest/gc/shared/test_oopStorage_parperf.cpp Changeset: 40d69f0c Author: Jaikiran Pai Date: 2021-10-14 14:38:16 +0000 URL: https://git.openjdk.java.net/amber/commit/40d69f0c41c8550605c3a1e6e572aecd3a8cf138 8254267: javax/xml/crypto/dsig/LogParameters.java failed with "RuntimeException: Unexpected log output:" Reviewed-by: weijun, dfuchs ! test/jdk/javax/xml/crypto/dsig/LogParameters.java Changeset: ede3f4e9 Author: Bernhard Urban-Forster Committer: Andrew Haley Date: 2021-10-14 16:58:14 +0000 URL: https://git.openjdk.java.net/amber/commit/ede3f4e94c752a8457b7c24e001bd122845d2f6a 8274795: AArch64: avoid spilling and restoring r18 in macro assembler Reviewed-by: aph ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp Changeset: a16f2d0a Author: Fernando Guallini Committer: Rajan Halade Date: 2021-10-14 18:26:27 +0000 URL: https://git.openjdk.java.net/amber/commit/a16f2d0a3c326dd8b3b2133a9c170d998b7aa631 8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security Reviewed-by: rhalade + test/jdk/com/sun/org/apache/xml/internal/security/SignatureKeyInfo.java ! test/jdk/com/sun/org/apache/xml/internal/security/TruncateHMAC.java + test/jdk/com/sun/org/apache/xml/internal/security/signature-enveloping-hmac-sha1-keyinfo.xml Changeset: e68d7d7c Author: duke Date: 2021-10-14 22:02:02 +0000 URL: https://git.openjdk.java.net/amber/commit/e68d7d7c962ccc2eda1f706710183641289ffa47 Automatic merge of master into stats-before-this-super ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java From pholder at gmail.com Thu Oct 14 22:44:50 2021 From: pholder at gmail.com (P Holder) Date: Thu, 14 Oct 2021 18:44:50 -0400 Subject: Suggestion for a special "invalid" record? Message-ID: I practically never write code that uses nulls. I prefer instead to make a specific instance of the class or interface that is known to be UNSPECIFIED or INVALID (or whatever else reads well in the specific case) and have it throw if someone tries to access it. In cases where a null would be returned as an error, I can then return this specific case, or I can use it as an initializer for variables that will expect a valid object eventually. Here's an example of some [incomplete] code I just wrote that did this: interface EndpointID { public static final EndpointID UNDEFINED = new EndpointID() { @Override public String getEndpointIDAsString() { throw getException("getEnpointIDAsString"); } private RuntimeException getException(final String source) { return new IllegalStateException(String.format("Use of %s.UNDEFINED by %s", EndpointID.class.getSimpleName(), source)); } }; String getEndpointIDAsString(); } Now I came across a point in my code where it would have been more handy (in some sense) to use a record instead of an interface as I did above, and I wanted to do something similar. I can't really think of a way to do this easily because I can't inline instantiate the record the same way I can a class (or can I somehow?) This was the best I could come up with, and it's not very satisfying to me: @org.eclipse.jdt.annotation.NonNullByDefault({}) // Need to disable NULL processing for records record LogMessageData(EndpointID endpointLogOriginatedFrom, Long logMessageID, String SubsystemOfLog, String logMessage, String[] parameters) { public static final LogMessageData UNDEFINED_LOG_MESSAGE_DATA = new LogMessageData(EndpointID.UNDEFINED, -1L, "UNDEFINED", "UNDEFINED", new String[0]); int getNumberOfParameters() { return parameters.length; } } Can anyone suggest a better way, or can records be evolved to allow for a better way? From talden at gmail.com Fri Oct 15 00:39:26 2021 From: talden at gmail.com (Aaron Scott-Boddendijk) Date: Fri, 15 Oct 2021 13:39:26 +1300 Subject: Combining records and enumerations In-Reply-To: <54a44bbb-261c-0773-49d8-c36abccfdc5e@oracle.com> References: <6c8fa4a6-e71b-52f4-7ee0-a8b7bb013c7b@azul.com> <54a44bbb-261c-0773-49d8-c36abccfdc5e@oracle.com> Message-ID: > But we concluded that it fell short of the "carries its weight" threshold. This wording seemed stronger than 'we have other priorities' (which I agree with)... There is a distinction between a feature whose value fails to balance the complexity it adds to the platform and a feature which we don't have time for. I was challenging the first interpretation, as the feature would be useful in enough cases and reduce such a substantial proportion of the ceremony otherwise involved that it seems valuable given so many moving parts already exist. I agree the pattern-matching work is more immediately valuable. I don't agree with discarding good ideas based on immediately available engineering effort... Sometimes lower priority ideas combine in ways that warrant reevaluation of their priority (at least this has been my experience). It would be interesting to keep an ideas bucket around, maybe even with captured topical threads. Such a beast would be useful for reexamination (and deflecting it when it covers the same ground) but also as a trove of 'how might this interact with...' > Naming things is hard. I have to give you that one - especially with "destructurer" :) -- Aaron On Fri, Oct 15, 2021 at 1:40 AM Brian Goetz wrote: > > > On 10/14/2021 7:43 AM, Aaron Scott-Boddendijk wrote: > > In two of my projects (unfortunately closed-source), both with over 100 > > enums, nearly half look like they would convert to this pattern (our > enums > > often have additional attributes, a strength of Java enums). > > > > There's a significant percentage of the enum-type body dedicated to > > ceremony that this would eliminate. > > As I said, it's not a *bad* feature, it just has a worse return on > investment than other features we could be working on. We could > prioritize this, but we'd have to deprioritize something else. Should we > delay deconstruction patterns for six more months to make room for > this? Deconstruction patterns seem way more powerful. > > > FYI, I really dislike the deconstruction term, as in general conversation > > 'construction' tends to imply allocation as well as constructor > invocation. > > Destructuring seems a more precise term and one that several languages > > already use - and it then also covers destructuring patterns for types > for > > which there was no equivalent 'constructor' (eg array/slice destructuring > > patterns). > > Naming things is hard. > > We considered using "destructuring" for all the reasons you suggest, but > it is not without its problems either. First, destructuring is a more > general term than the concept being described here; what we are callling > a "deconstruction pattern" is merely one form of destructuring, and > there will be others. And the name "destructurer" is impossible to > spell or pronounce correctly. More importantly, in the object model, > this is the dual of construction, and to the degree users can see it > that way, they will understand the concept more immediately. Later > features will be built on matching pairs of constructor and > deconstructor (or deconstruction pattern). The similarity in naming is > important. > > The main problem with "deconstructor" is the potential confusion with > "destructor" in C++. > > Naming things is hard. > > From brian.goetz at oracle.com Fri Oct 15 01:07:28 2021 From: brian.goetz at oracle.com (Brian Goetz) Date: Thu, 14 Oct 2021 21:07:28 -0400 Subject: [External] : Re: Combining records and enumerations In-Reply-To: References: <6c8fa4a6-e71b-52f4-7ee0-a8b7bb013c7b@azul.com> <54a44bbb-261c-0773-49d8-c36abccfdc5e@oracle.com> Message-ID: <72e5f151-a528-3ea4-9850-84bb70307d15@oracle.com> > It would be interesting to keep an ideas bucket around, maybe even > with captured topical > threads. Such a beast would be useful for reexamination (and > deflecting it when it covers > the same ground) but also as a trove of 'how might this interact with...' I would love it if someone stepped up to curate this! From mark.reinhold at oracle.com Tue Oct 19 19:10:31 2021 From: mark.reinhold at oracle.com (mark.reinhold at oracle.com) Date: Tue, 19 Oct 2021 12:10:31 -0700 (PDT) Subject: New candidate JEP: 420: Pattern Matching for switch (Second Preview) Message-ID: <20211019191031.41E414C4E31@eggemoggin.niobe.net> https://openjdk.java.net/jeps/420 Summary: Enhance the Java programming language with pattern matching for switch expressions and statements, along with extensions to the language of patterns. Extending pattern matching to switch allows an expression to be tested against a number of patterns, each with a specific action, so that complex data-oriented queries can be expressed concisely and safely. - Mark From nlisker at gmail.com Wed Oct 20 23:11:31 2021 From: nlisker at gmail.com (Nir Lisker) Date: Thu, 21 Oct 2021 02:11:31 +0300 Subject: Pattern Matching for Switch Expressions feedback Message-ID: Hi, I've used pattern matching in switch expressions in my codebase. While my use cases are simple (no need to deal with nulls and ordering due to 2 patterns potentially matching), I can say that it works well. My biggest request is to be able to differentiate between parametric types: case List -> ... case List -> ... I've seen some discussion on this previously on the mailing list, but not a conclusion. Is this something that can be addressed in this JEP? Is it planned for a future change outside of this JEP? - Nir From brian.goetz at oracle.com Wed Oct 20 23:35:19 2021 From: brian.goetz at oracle.com (Brian Goetz) Date: Wed, 20 Oct 2021 19:35:19 -0400 Subject: Pattern Matching for Switch Expressions feedback In-Reply-To: References: Message-ID: This comes from the current limitations of generics.? Generics in Java are checked at compile time, and then erased -- the runtime only knows about List, not List vs List.? So there is no way to dynamically test whether a given List is a List vs a List, which is what a pattern would have to do. We do take generic information into account in type checking; if you have a switch over a List, we can immediately reject ArrayList as a possible type test, but know that ArrayList is possible.? But if you are switching over a List or a raw List, there's simply nothing we can do (today) to dynamically dispatch the switch. Project Valhalla will eventually bring some progress to this, but by way of expectation setting, this problem is several orders of magnitude bigger than pattern matching, and even then, there will be some limitations that stem from migration compatibility. On 10/20/2021 7:11 PM, Nir Lisker wrote: > Hi, > > I've used pattern matching in switch expressions in my codebase. While my > use cases are simple (no need to deal with nulls and ordering due to 2 > patterns potentially matching), I can say that it works well. My biggest > request is to be able to differentiate between parametric types: > > case List -> ... > case List -> ... > > I've seen some discussion on this previously on the mailing list, but not a > conclusion. Is this something that can be addressed in this JEP? Is it > planned for a future change outside of this JEP? > > - Nir From duke at openjdk.java.net Thu Oct 21 22:09:43 2021 From: duke at openjdk.java.net (duke) Date: Thu, 21 Oct 2021 22:09:43 GMT Subject: git: openjdk/amber: stats-before-this-super: 116 new changesets Message-ID: Changeset: 21df412b Author: Andrey Turbanov Committer: Serguei Spitsyn Date: 2021-10-14 23:12:05 +0000 URL: https://git.openjdk.java.net/amber/commit/21df412bd9a02f0c3f351467951415141d920e03 8275240: Change nested classes in jdk.attach to static nested classes Reviewed-by: cjplummer, dholmes, sspitsyn ! src/jdk.attach/aix/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/linux/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/macosx/classes/sun/tools/attach/VirtualMachineImpl.java ! src/jdk.attach/windows/classes/sun/tools/attach/VirtualMachineImpl.java Changeset: 9623d5bb Author: Jie Fu Date: 2021-10-14 23:12:56 +0000 URL: https://git.openjdk.java.net/amber/commit/9623d5bb46d14018a2b777fb7ffed6c66d912c84 8275265: java/nio/channels tests needing large heap sizes fail on x86_32 Reviewed-by: alanb, bpb ! test/jdk/java/nio/channels/Channels/ReadXBytes.java ! test/jdk/java/nio/channels/FileChannel/LargeGatheringWrite.java Changeset: c355704a Author: Sergey Bylokhov Date: 2021-10-15 02:21:26 +0000 URL: https://git.openjdk.java.net/amber/commit/c355704a4b3d376b5429daba1576442b575f41ea 8041125: ColorConvertOp filter much slower in JDK 8 compared to JDK7 Reviewed-by: prr ! src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMS.java ! src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMSImageLayout.java ! src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java ! src/java.desktop/share/native/liblcms/LCMS.c Changeset: 322b1301 Author: Andrey Turbanov Committer: Pankaj Bansal Date: 2021-10-15 07:09:11 +0000 URL: https://git.openjdk.java.net/amber/commit/322b1301061ba113dc5f7f3710dde2d80a18a14e 8275106: Cleanup Iterator usages in java.desktop Reviewed-by: serb, pbansal ! src/java.desktop/macosx/classes/sun/font/CStrike.java ! src/java.desktop/share/classes/com/sun/beans/introspect/EventSetInfo.java ! src/java.desktop/share/classes/com/sun/beans/introspect/PropertyInfo.java ! src/java.desktop/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/java.desktop/share/classes/java/beans/beancontext/BeanContextServicesSupport.java ! src/java.desktop/share/classes/javax/imageio/plugins/tiff/TIFFTag.java ! src/java.desktop/share/classes/javax/print/attribute/standard/PrinterStateReasons.java ! src/java.desktop/share/classes/javax/swing/JDesktopPane.java ! src/java.desktop/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/java.desktop/share/classes/sun/awt/im/InputContext.java ! src/java.desktop/share/classes/sun/java2d/loops/GraphicsPrimitive.java ! src/java.desktop/unix/classes/sun/awt/X11/ListHelper.java ! src/java.desktop/unix/classes/sun/awt/X11/XAtomList.java ! src/java.desktop/unix/classes/sun/awt/X11/XCreateWindowParams.java ! src/java.desktop/unix/classes/sun/awt/X11/XDropTargetRegistry.java ! src/java.desktop/unix/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/java.desktop/unix/classes/sun/awt/X11/XMSelection.java ! src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java Changeset: 4cb7124c Author: Christian Hagedorn Date: 2021-10-15 07:38:38 +0000 URL: https://git.openjdk.java.net/amber/commit/4cb7124c1e9c5fd1d3a82fd8933cc63fefde9531 8262912: ciReplay: replay does not simulate unresolved classes Reviewed-by: kvn, dlong ! src/hotspot/share/ci/ciEnv.cpp ! src/hotspot/share/ci/ciEnv.hpp ! src/hotspot/share/ci/ciInstanceKlass.hpp ! src/hotspot/share/ci/ciObjectFactory.cpp ! src/hotspot/share/ci/ciReplay.cpp ! src/hotspot/share/ci/ciReplay.hpp ! test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java + test/hotspot/jtreg/compiler/ciReplay/TestUnresolvedClasses.java Changeset: c0f3e1d6 Author: Artem Semenov Committer: Anton Tarasov Date: 2021-10-15 09:51:28 +0000 URL: https://git.openjdk.java.net/amber/commit/c0f3e1d6beab94a6b361814585b6d77fa617e7e4 8271071: accessibility of a table on macOS lacks cell navigation Reviewed-by: ant, kizune, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CellAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.h ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableRowAccessibility.m Changeset: ced79091 Author: Aleksey Shipilev Date: 2021-10-15 11:15:49 +0000 URL: https://git.openjdk.java.net/amber/commit/ced79091f6ce1791f33c3e5e153eb0535c4d53db 8275286: Check current thread when calling JRT methods that expect it Reviewed-by: zgu, coleenp, dholmes ! src/hotspot/share/runtime/interfaceSupport.inline.hpp Changeset: 172aed1a Author: Coleen Phillimore Date: 2021-10-15 12:10:27 +0000 URL: https://git.openjdk.java.net/amber/commit/172aed1a2d75756b140cb723133ac5fb67f7745e 8274338: com/sun/jdi/RedefineCrossEvent.java failed "assert(m != __null) failed: NULL mirror" Reviewed-by: dholmes, iklam ! src/hotspot/share/classfile/classLoaderData.cpp ! src/hotspot/share/oops/instanceKlass.cpp Changeset: 8e020642 Author: Weijun Wang Date: 2021-10-15 13:51:52 +0000 URL: https://git.openjdk.java.net/amber/commit/8e02064288a5954ab71b306fc31978a47012ef50 8049520: FileCredentialsCache loads cache once and is never refreshed Reviewed-by: mullan ! src/java.security.jgss/share/classes/sun/security/krb5/Credentials.java + test/jdk/sun/security/krb5/ccache/Refresh.java Changeset: da8da3a1 Author: Alexander Zvegintsev Date: 2021-10-15 14:03:55 +0000 URL: https://git.openjdk.java.net/amber/commit/da8da3a16148a750ce502f7b7281fe289acaef40 8269698: Specification for methods of java.awt.im.InputContext should mention that they do nothing Reviewed-by: serb ! src/java.desktop/share/classes/java/awt/im/InputContext.java Changeset: 8c4da9c1 Author: Joe Darcy Date: 2021-10-15 16:17:29 +0000 URL: https://git.openjdk.java.net/amber/commit/8c4da9c15fec7bd27e243e9a6c9ebcad63109506 8275013: Improve discussion of serialization method declarations in java.io.Object{Input, Output}Stream Reviewed-by: smarks, rriggs ! src/java.base/share/classes/java/io/ObjectInputStream.java ! src/java.base/share/classes/java/io/ObjectOutputStream.java Changeset: ee64ce9f Author: Calvin Cheung Date: 2021-10-15 16:53:00 +0000 URL: https://git.openjdk.java.net/amber/commit/ee64ce9f14c36c38fc4fadf8e5f350daa46e3a78 8274937: Revert the timeout setting for DynamicLoaderConstraintsTest Reviewed-by: dcubed, minqi ! test/hotspot/jtreg/runtime/cds/appcds/loaderConstraints/DynamicLoaderConstraintsTest.java Changeset: f1781851 Author: Joe Darcy Date: 2021-10-15 17:24:30 +0000 URL: https://git.openjdk.java.net/amber/commit/f17818516cf80e6e208309200c98b23919c3cddb 8275249: Suppress warnings on non-serializable array component types in jdk.jlink Reviewed-by: iris ! src/jdk.jlink/share/classes/jdk/tools/jlink/internal/TaskHelper.java Changeset: ad9e234f Author: Naoto Sato Date: 2021-10-15 20:36:30 +0000 URL: https://git.openjdk.java.net/amber/commit/ad9e234f5ed61635f926618a40f453fe7b6b491f 8275145: file.encoding system property has an incorrect value on Windows Reviewed-by: mchung, iris, rriggs, alanb ! src/java.base/share/native/libjava/System.c Changeset: 831802dd Author: Lance Andersen Date: 2021-10-15 20:38:43 +0000 URL: https://git.openjdk.java.net/amber/commit/831802ddb103f8f9747a9fb139af8365924da801 8275163: Deflater::deflate methods omit javadoc for ReadOnlyBufferException Reviewed-by: bpb, iris, naoto ! src/java.base/share/classes/java/util/zip/Deflater.java Changeset: 7fc3a8d0 Author: Brian Burkhalter Date: 2021-10-15 22:58:21 +0000 URL: https://git.openjdk.java.net/amber/commit/7fc3a8d052bfb8d31fedec56f72b10a40ba7bf83 8275149: (ch) ReadableByteChannel returned by Channels.newChannel(InputStream) throws ReadOnlyBufferException Reviewed-by: alanb ! src/java.base/share/classes/java/nio/channels/Channels.java ! test/jdk/java/nio/channels/Channels/Basic.java Changeset: 96fef40b Author: Jonathan Gibbons Date: 2021-10-16 03:04:11 +0000 URL: https://git.openjdk.java.net/amber/commit/96fef40b8206c7027c6688bc0cb0bd979bea4b4b 8189591: No way to locally suppress doclint warnings Reviewed-by: hannesw, prappo ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Env.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Messages.java ! test/langtools/jdk/javadoc/doclet/testJavaFX/TestJavaFX.java + test/langtools/tools/doclint/SuppressWarningsTest.java Changeset: bfcf6a29 Author: Thomas Schatzl Date: 2021-10-16 11:05:48 +0000 URL: https://git.openjdk.java.net/amber/commit/bfcf6a29a16bc12d77a897fbec304868957c3188 8275277: assert(dest_attr.is_in_cset() == (obj->forwardee() == obj)) failed: Only evac-failed objects must be in the collection set here but is not Reviewed-by: ayang, rkennke ! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp Changeset: 31500692 Author: Yasumasa Suenaga Date: 2021-10-17 08:59:13 +0000 URL: https://git.openjdk.java.net/amber/commit/31500692d1503cb73249e0425e6930aaaa49258a 8271949: dumppath in -XX:FlightRecorderOptions does not affect Reviewed-by: ddong, mgronlun ! src/hotspot/share/jfr/jni/jfrJniMethod.cpp ! src/hotspot/share/jfr/jni/jfrJniMethod.hpp ! src/hotspot/share/jfr/jni/jfrJniMethodRegistration.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.hpp ! src/hotspot/share/jfr/recorder/service/jfrOptionSet.cpp ! src/jdk.jfr/share/classes/jdk/jfr/internal/JVM.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/Options.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/SecuritySupport.java ! test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java Changeset: bb7dacdc Author: Stefan Karlsson Date: 2021-10-18 07:03:17 +0000 URL: https://git.openjdk.java.net/amber/commit/bb7dacdc78ad50797900e7e9610a1ed8e7ab1b00 8275334: Move class loading Events to a separate section in hs_err files Reviewed-by: stuefe, coleenp ! src/hotspot/share/classfile/classLoader.cpp ! src/hotspot/share/utilities/events.cpp ! src/hotspot/share/utilities/events.hpp Changeset: ebb1363e Author: Tobias Holenstein Committer: Tobias Hartmann Date: 2021-10-18 07:32:17 +0000 URL: https://git.openjdk.java.net/amber/commit/ebb1363e5d6b47daf1badad93490580fedcb0572 8251513: Code around Parse::do_lookupswitch/do_tableswitch should be cleaned up Reviewed-by: roland, thartmann ! src/hotspot/share/ci/ciStreams.hpp ! src/hotspot/share/opto/parse2.cpp Changeset: 45ebf85c Author: Stefan Karlsson Date: 2021-10-18 11:20:51 +0000 URL: https://git.openjdk.java.net/amber/commit/45ebf85ca9a1e071955ba2e3cb32449bfbd85d14 8275333: Print count in "Too many recored phases?" assert Reviewed-by: eosterlund, tschatzl ! src/hotspot/share/gc/shared/gcTimer.cpp Changeset: 1afddb25 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-18 12:02:00 +0000 URL: https://git.openjdk.java.net/amber/commit/1afddb2560504c533d30b2f79d735f59f519e7c5 8275322: Change nested classes in java.management to static nested classes Reviewed-by: alanb, dfuchs, mchung, sspitsyn ! src/java.management/share/classes/com/sun/jmx/mbeanserver/DefaultMXBeanMappingFactory.java ! src/java.management/share/classes/sun/management/MemoryPoolImpl.java ! src/java.management/share/classes/sun/management/NotificationEmitterSupport.java Changeset: a619f890 Author: Weijun Wang Date: 2021-10-18 13:24:39 +0000 URL: https://git.openjdk.java.net/amber/commit/a619f8909bb074712db22746e785f7485795a8f5 8274721: UnixSystem fails to provide uid, gid or groups if no username is available Reviewed-by: mullan ! src/jdk.security.auth/unix/native/libjaas/Unix.c Changeset: d548f2fc Author: Andy Herrick Date: 2021-10-18 13:28:41 +0000 URL: https://git.openjdk.java.net/amber/commit/d548f2fc0dbc9e7864dd1701873bbf3d12a75ecb 8274346: Support for additional content in an app-image. Reviewed-by: asemenyuk, almatvee ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/AbstractAppImageBuilder.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/ApplicationLayout.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/DeployParams.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources.properties ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_ja.properties ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/HelpResources_zh_CN.properties + test/jdk/tools/jpackage/share/AppContentTest.java Changeset: fb8e5cf4 Author: Joe Darcy Date: 2021-10-18 15:48:59 +0000 URL: https://git.openjdk.java.net/amber/commit/fb8e5cf4ecee1b737bdcc806d219709854185764 8275368: Correct statement of kinds of elements Processor.process operates over Reviewed-by: jlahoda ! src/java.compiler/share/classes/javax/annotation/processing/Processor.java ! src/java.compiler/share/classes/javax/annotation/processing/RoundEnvironment.java Changeset: 4d383b9f Author: Albert Mingkun Yang Date: 2021-10-18 16:02:22 +0000 URL: https://git.openjdk.java.net/amber/commit/4d383b9fcd2e1cb3afde17a37bc2dc5a37247d04 8275298: Remove unnecessary weak_oops_do call in adjust weak roots phase Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1FullGCAdjustTask.cpp ! src/hotspot/share/gc/g1/g1FullGCAdjustTask.hpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psScavenge.cpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp Changeset: 426bcee9 Author: Joe Darcy Date: 2021-10-18 16:11:16 +0000 URL: https://git.openjdk.java.net/amber/commit/426bcee9274bb3ec7dce551f85adb2ab61c22481 8275360: Use @Override in javax.annotation.processing Reviewed-by: iris ! src/java.compiler/share/classes/javax/annotation/processing/AbstractProcessor.java ! src/java.compiler/share/classes/javax/annotation/processing/Completions.java Changeset: bcbe3845 Author: Gerard Ziemski Date: 2021-10-18 16:24:02 +0000 URL: https://git.openjdk.java.net/amber/commit/bcbe3845d92e38ad0086cc337dc5957842eef056 8269175: [macosx-aarch64] wrong CPU speed in hs_err file Reviewed-by: dholmes, dcubed, stuefe ! src/hotspot/os/bsd/os_bsd.cpp Changeset: 72a976ef Author: Markus Gr?nlund Date: 2021-10-18 16:52:36 +0000 URL: https://git.openjdk.java.net/amber/commit/72a976ef05fc2c62657920a560a0abc60b27c852 8266936: Add a finalization JFR event Reviewed-by: coleenp, mchung, egahlin ! make/data/hotspot-symbols/symbols-unix ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/include/jvm.h ! src/hotspot/share/jfr/jni/jfrJavaSupport.cpp ! src/hotspot/share/jfr/jni/jfrJavaSupport.hpp ! src/hotspot/share/jfr/metadata/metadata.xml + src/hotspot/share/jfr/periodic/jfrFinalizerStatisticsEvent.cpp + src/hotspot/share/jfr/periodic/jfrFinalizerStatisticsEvent.hpp ! src/hotspot/share/jfr/periodic/jfrPeriodic.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSet.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetUtils.cpp ! src/hotspot/share/jfr/recorder/checkpoint/types/jfrTypeSetUtils.hpp ! src/hotspot/share/jfr/recorder/service/jfrPostBox.cpp ! src/hotspot/share/jfr/recorder/service/jfrRecorderThreadLoop.cpp ! src/hotspot/share/jfr/support/jfrKlassUnloading.cpp + src/hotspot/share/jfr/support/jfrSymbolTable.cpp + src/hotspot/share/jfr/support/jfrSymbolTable.hpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/serviceThread.cpp ! src/hotspot/share/services/classLoadingService.cpp ! src/hotspot/share/services/classLoadingService.hpp + src/hotspot/share/services/finalizerService.cpp + src/hotspot/share/services/finalizerService.hpp ! src/hotspot/share/services/management.cpp ! src/hotspot/share/services/management.hpp ! src/hotspot/share/utilities/macros.hpp ! src/java.base/share/classes/java/lang/ref/Finalizer.java + src/java.base/share/native/libjava/Finalizer.c ! src/jdk.jfr/share/conf/jfr/default.jfc ! src/jdk.jfr/share/conf/jfr/profile.jfc + test/jdk/jdk/jfr/event/runtime/TestFinalizerStatisticsEvent.java ! test/lib/jdk/test/lib/jfr/EventNames.java ! test/lib/jdk/test/lib/jfr/TestClassLoader.java Changeset: bad75e67 Author: Calvin Cheung Date: 2021-10-18 18:05:39 +0000 URL: https://git.openjdk.java.net/amber/commit/bad75e6796aa7940a9418e317021242ba11d8d50 8275150: URLClassLoaderTable should store OopHandle instead of Handle Reviewed-by: stefank, minqi ! src/hotspot/share/cds/unregisteredClasses.cpp Changeset: a03119ce Author: Daniel D. Daugherty Date: 2021-10-18 18:25:53 +0000 URL: https://git.openjdk.java.net/amber/commit/a03119ce1a34642565c669bd2471f52eec088b96 8275436: [BACKOUT] JDK-8271949 dumppath in -XX:FlightRecorderOptions does not affect Reviewed-by: mgronlun ! src/hotspot/share/jfr/jni/jfrJniMethod.cpp ! src/hotspot/share/jfr/jni/jfrJniMethod.hpp ! src/hotspot/share/jfr/jni/jfrJniMethodRegistration.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.cpp ! src/hotspot/share/jfr/recorder/repository/jfrEmergencyDump.hpp ! src/hotspot/share/jfr/recorder/service/jfrOptionSet.cpp ! src/jdk.jfr/share/classes/jdk/jfr/internal/JVM.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/Options.java ! src/jdk.jfr/share/classes/jdk/jfr/internal/SecuritySupport.java ! test/jdk/jdk/jfr/jvm/TestDumpOnCrash.java Changeset: 947d52c4 Author: Jayathirth D V Date: 2021-10-19 04:04:25 +0000 URL: https://git.openjdk.java.net/amber/commit/947d52c4c3deec1bdea43959c200201c614ae114 8255898: Test java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java fails on Mac OS Reviewed-by: prr, serb ! test/jdk/ProblemList.txt ! test/jdk/java/awt/FileDialog/FilenameFilterTest/FilenameFilterTest.java Changeset: 9d191fce Author: Julia Boes Date: 2021-10-19 10:19:15 +0000 URL: https://git.openjdk.java.net/amber/commit/9d191fce55fa70d6a2affc724fad57b0e20e4bde 8245095: Implementation of JEP 408: Simple Web Server Co-authored-by: Julia Boes Co-authored-by: Chris Hegarty Co-authored-by: Michael McMahon Co-authored-by: Daniel Fuchs Co-authored-by: Jan Lahoda Co-authored-by: Ivan ?ipka Reviewed-by: ihse, jlaskey, michaelm, chegar, dfuchs ! make/CreateJmods.gmk ! make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java + make/modules/jdk.httpserver/Gensrc.gmk ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/Filter.java ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/Headers.java ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java + src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpHandlers.java ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpServer.java ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java + src/jdk.httpserver/share/classes/com/sun/net/httpserver/Request.java + src/jdk.httpserver/share/classes/com/sun/net/httpserver/SimpleFileServer.java ! src/jdk.httpserver/share/classes/com/sun/net/httpserver/package-info.java ! src/jdk.httpserver/share/classes/module-info.java + src/jdk.httpserver/share/classes/sun/net/httpserver/DelegatingHttpExchange.java ! src/jdk.httpserver/share/classes/sun/net/httpserver/ExchangeImpl.java + src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/FileServerHandler.java + src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/Main.java + src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/OutputFilter.java + src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/ResourceBundleHelper.java + src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/SimpleFileServerImpl.java + src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/resources/simpleserver.properties ! test/jdk/TEST.ROOT ! test/jdk/com/sun/net/httpserver/FilterTest.java ! test/jdk/com/sun/net/httpserver/HeadersTest.java ! test/jdk/com/sun/net/httpserver/UnmodifiableHeadersTest.java + test/jdk/com/sun/net/httpserver/simpleserver/CommandLineNegativeTest.java + test/jdk/com/sun/net/httpserver/simpleserver/CommandLinePositiveTest.java + test/jdk/com/sun/net/httpserver/simpleserver/CustomFileSystemTest.java + test/jdk/com/sun/net/httpserver/simpleserver/FileServerHandlerTest.java + test/jdk/com/sun/net/httpserver/simpleserver/HttpHandlersTest.java + test/jdk/com/sun/net/httpserver/simpleserver/HttpsServerTest.java + test/jdk/com/sun/net/httpserver/simpleserver/IdempotencyAndCommutativityTest.java + test/jdk/com/sun/net/httpserver/simpleserver/MapToPathTest.java + test/jdk/com/sun/net/httpserver/simpleserver/OutputFilterTest.java + test/jdk/com/sun/net/httpserver/simpleserver/RequestTest.java + test/jdk/com/sun/net/httpserver/simpleserver/SecurityManagerTest.java + test/jdk/com/sun/net/httpserver/simpleserver/SecurityManagerTestNoRead.policy + test/jdk/com/sun/net/httpserver/simpleserver/SecurityManagerTestRead.policy + test/jdk/com/sun/net/httpserver/simpleserver/ServerMimeTypesResolutionTest.java + test/jdk/com/sun/net/httpserver/simpleserver/SimpleFileServerTest.java + test/jdk/com/sun/net/httpserver/simpleserver/StressDirListings.java + test/jdk/com/sun/net/httpserver/simpleserver/ZipFileSystemTest.java Changeset: a4491f22 Author: Zhengyu Gu Date: 2021-10-19 12:00:30 +0000 URL: https://git.openjdk.java.net/amber/commit/a4491f22533370f481de71b7ddc8f6105fa2d414 8275413: Remove unused InstanceKlass::set_array_klasses() method Reviewed-by: coleenp ! src/hotspot/share/oops/instanceKlass.hpp Changeset: d17d81a8 Author: Hamlin Li Date: 2021-10-19 12:24:21 +0000 URL: https://git.openjdk.java.net/amber/commit/d17d81a8b2a6336f37e17f31413a62c7adf49936 8273626: G1: Factor out concurrent segmented array from G1CardSetAllocator Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1CardSet.cpp ! src/hotspot/share/gc/g1/g1CardSet.hpp ! src/hotspot/share/gc/g1/g1CardSetFreeMemoryTask.hpp ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp ! src/hotspot/share/gc/g1/g1CardSetMemory.hpp ! src/hotspot/share/gc/g1/g1CardSetMemory.inline.hpp + src/hotspot/share/gc/g1/g1SegmentedArray.hpp + src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp Changeset: dcd6e0da Author: Jayathirth D V Date: 2021-10-19 12:25:32 +0000 URL: https://git.openjdk.java.net/amber/commit/dcd6e0da245338de68d9dede451e233f4bfaa934 8255724: [XRender] the BlitRotateClippedArea test fails on Linux in the XR pipeline Reviewed-by: psadhukhan ! test/jdk/ProblemList.txt ! test/jdk/java/awt/image/DrawImage/BlitRotateClippedArea.java Changeset: 98ab4b03 Author: Markus Gr?nlund Date: 2021-10-19 13:00:50 +0000 URL: https://git.openjdk.java.net/amber/commit/98ab4b03b311dcd8374cbbb21a898298798750d6 8275445: RunThese30M.java failed "assert(ZAddress::is_marked(addr)) failed: Should be marked" Reviewed-by: egahlin, coleenp ! src/hotspot/share/jfr/periodic/jfrFinalizerStatisticsEvent.cpp ! src/hotspot/share/services/finalizerService.cpp ! src/hotspot/share/services/finalizerService.hpp ! test/jdk/jdk/jfr/event/runtime/TestFinalizerStatisticsEvent.java Changeset: 002c538b Author: Zhengyu Gu Date: 2021-10-19 14:14:23 +0000 URL: https://git.openjdk.java.net/amber/commit/002c538bc03f55fa600f331a66242ee8575919dc 8275287: Relax memory ordering constraints on updating instance class and array class counters Reviewed-by: dholmes, rkennke ! src/hotspot/share/classfile/classLoaderDataGraph.inline.hpp Changeset: a579483c Author: Andrey Turbanov Committer: Albert Mingkun Yang Date: 2021-10-19 14:46:30 +0000 URL: https://git.openjdk.java.net/amber/commit/a579483c88e94bdaa787d109e5ae204e7fb308c0 8274899: Replace usages of Collections.sort with List.sort call in jdk.hotspot.agent Reviewed-by: sspitsyn, cjplummer, ayang ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/BasicCDebugInfoDataBase.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/cdbg/basic/BasicLineNumberMapping.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHistogram.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/FinalizerInfo.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/ProcessListPanel.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/table/SortableTableModel.java Changeset: 8a3e0a1f Author: Naoto Sato Date: 2021-10-19 15:54:14 +0000 URL: https://git.openjdk.java.net/amber/commit/8a3e0a1fc1fef02edf9621b13e8be8b96a12bb0f 7008363: TEST_BUG: test/java/lang/StringCoding/CheckEncodings.sh does nothing and is very slow at that Reviewed-by: iris, lancea, bpb, whuang ! test/jdk/ProblemList.txt - test/jdk/java/lang/StringCoding/CheckEncodings.sh - test/jdk/java/lang/StringCoding/locales.txt Changeset: 99bf7dd8 Author: Markus Gr?nlund Date: 2021-10-19 16:20:45 +0000 URL: https://git.openjdk.java.net/amber/commit/99bf7dd8ddac1b5870534af50c97bec554004248 8275517: Off-by-one error in allocation Reviewed-by: tschatzl ! src/hotspot/share/services/finalizerService.cpp Changeset: fd10f199 Author: Vicente Romero Date: 2021-10-19 16:46:14 +0000 URL: https://git.openjdk.java.net/amber/commit/fd10f1996ef94529b5b12e547957cd904ade1956 8275302: unexpected compiler error: cast, intersection types and sealed Reviewed-by: jlahoda ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java ! test/langtools/tools/javac/sealed/SealedCompilationTests.java Changeset: 895e2bd7 Author: Alexander Zvegintsev Date: 2021-10-19 17:24:20 +0000 URL: https://git.openjdk.java.net/amber/commit/895e2bd7c0bded5283eca8792fbfb287bb75016b 8274160: java/awt/Window/ShapedAndTranslucentWindows/Common.java delay is too high Reviewed-by: psadhukhan, pbansal ! test/jdk/java/awt/Window/ShapedAndTranslucentWindows/Common.java Changeset: a26f9db7 Author: Weijun Wang Committer: Henry Jen Date: 2021-03-26 14:52:55 +0000 URL: https://git.openjdk.java.net/amber/commit/a26f9db704a0ded15e467676a72de8955eb0d9f6 8263314: Enhance XML Dsig modes Reviewed-by: rhalade, mschoene, valeriep, mullan ! src/java.xml.crypto/share/classes/org/jcp/xml/dsig/internal/dom/DOMURIDereferencer.java ! test/jdk/javax/xml/crypto/dsig/GenerationTests.java Changeset: 34628ff8 Author: Weijun Wang Committer: Henry Jen Date: 2021-05-11 20:00:26 +0000 URL: https://git.openjdk.java.net/amber/commit/34628ff8ac4acf72070945d030d6cd7999afe617 8266115: More Manifest Jar Loading Reviewed-by: mschoene, ahgross, mullan, rhalade ! src/java.base/share/classes/java/util/jar/JarFile.java - test/jdk/java/util/jar/JarFile/LargeManifestOOMTest.java Changeset: 3a7b663b Author: Michael McMahon Committer: Henry Jen Date: 2021-05-20 11:37:13 +0000 URL: https://git.openjdk.java.net/amber/commit/3a7b663b6f3712c51cd14634c28777bd68200156 8265776: Improve Stream handling for SSL Reviewed-by: dfuchs, chegar, rhalade, ahgross ! src/jdk.httpserver/share/classes/sun/net/httpserver/SSLStreams.java Changeset: dd199ee0 Author: Julia Boes Committer: Henry Jen Date: 2021-05-25 10:19:55 +0000 URL: https://git.openjdk.java.net/amber/commit/dd199ee0631f7da10c91e2e99621e683e889ef87 8266097: Better hashing support Reviewed-by: chegar, dfuchs, ahgross, smarks, rhalade ! src/java.base/share/classes/java/util/HashMap.java ! src/java.base/share/classes/java/util/HashSet.java Changeset: 470e8a0f Author: Valerie Peng Committer: Henry Jen Date: 2021-06-03 22:42:55 +0000 URL: https://git.openjdk.java.net/amber/commit/470e8a0fda5248f22e1cd90ed8064cdf04513c28 8266103: Better specified spec values Reviewed-by: mullan, rhalade, mschoene ! src/java.base/share/classes/javax/crypto/spec/IvParameterSpec.java ! src/java.base/share/classes/javax/crypto/spec/RC5ParameterSpec.java ! src/java.base/share/classes/javax/crypto/spec/SecretKeySpec.java Changeset: bddcc8ea Author: Aleksei Efimov Committer: Henry Jen Date: 2021-06-08 10:18:09 +0000 URL: https://git.openjdk.java.net/amber/commit/bddcc8ea9d567f05a5944d9a9794dd1743a36593 8267712: Better LDAP reference processing Reviewed-by: dfuchs, ahgross, rhalade ! src/java.naming/share/classes/com/sun/jndi/ldap/Obj.java ! src/java.naming/share/classes/com/sun/jndi/ldap/VersionHelper.java Changeset: a48251cb Author: Hai-May Chao Committer: Henry Jen Date: 2021-06-08 21:58:23 +0000 URL: https://git.openjdk.java.net/amber/commit/a48251cb4ad86f7554ba6a97b54d512e6fd98237 8266137: Improve Keystore integrity Reviewed-by: mschoene, rhalade, weijun ! src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java ! src/java.base/share/classes/sun/security/tools/keytool/Main.java Changeset: fde3839c Author: Prasanta Sadhukhan Committer: Henry Jen Date: 2021-06-16 04:10:50 +0000 URL: https://git.openjdk.java.net/amber/commit/fde3839c0c40f48b435e4fd5ebf5b137e96c7f90 8265167: Richer Text Editors Reviewed-by: prr, rhalade, mschoene, azvegint ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFParser.java Changeset: a07a046c Author: Xue-Lei Andrew Fan Committer: Henry Jen Date: 2021-06-18 04:04:43 +0000 URL: https://git.openjdk.java.net/amber/commit/a07a046c9254a426c1805485537e345f30a4377c 8267729: Improve TLS client handshaking Reviewed-by: ahgross, jnimeh, rhalade ! src/java.base/share/classes/sun/security/ssl/ECDHClientKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/ECDHServerKeyExchange.java ! src/java.base/share/classes/sun/security/ssl/KeyShareExtension.java ! src/java.base/share/classes/sun/security/ssl/NamedGroup.java ! src/java.base/share/classes/sun/security/ssl/SSLLogger.java Changeset: 3470e7b3 Author: Weijun Wang Committer: Henry Jen Date: 2021-06-18 20:26:49 +0000 URL: https://git.openjdk.java.net/amber/commit/3470e7b300b5301326369892a4291f4904106e05 8266109: More Resilient Classloading Reviewed-by: lancea, rhalade, mschoene, bchristi ! src/java.base/share/classes/java/net/URLClassLoader.java ! src/java.base/share/classes/jdk/internal/loader/Resource.java ! src/java.base/share/classes/jdk/internal/loader/URLClassPath.java Changeset: c70f7cad Author: Jayathirth D V Committer: Henry Jen Date: 2021-06-22 12:42:51 +0000 URL: https://git.openjdk.java.net/amber/commit/c70f7cad47c9be0a203079de52ffab0ce53ba965 8267735: Better BMP support Reviewed-by: prr, rhalade, azvegint, ahgross, mschoene ! src/java.desktop/share/classes/com/sun/imageio/plugins/bmp/BMPImageReader.java ! src/java.desktop/share/classes/com/sun/imageio/plugins/common/iio-plugin.properties Changeset: ab917095 Author: Weijun Wang Committer: Henry Jen Date: 2021-06-22 21:25:33 +0000 URL: https://git.openjdk.java.net/amber/commit/ab9170957f76905251384a597c721c8f1c250c45 8270212: ArrayIndexOutOfBoundsException in java.security.KeyFactory.generatePublic Reviewed-by: ahgross, valeriep ! src/java.base/share/classes/sun/security/util/DerIndefLenConverter.java Changeset: 790dcc66 Author: Hai-May Chao Committer: Henry Jen Date: 2021-06-30 18:02:46 +0000 URL: https://git.openjdk.java.net/amber/commit/790dcc667dcf312a7cd807e1dd06e50c299e3ac3 8268506: More Manifest Digests Reviewed-by: xuelei, ahgross, weijun, rhalade ! src/java.base/share/classes/sun/security/util/ManifestDigester.java ! src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java ! src/jdk.jartool/share/classes/jdk/security/jarsigner/JarSigner.java Changeset: 20e1a273 Author: Hai-May Chao Committer: Henry Jen Date: 2021-07-07 00:49:23 +0000 URL: https://git.openjdk.java.net/amber/commit/20e1a273c2de268c6540abfd78e985170cfa0c75 8268500: Better specified ParameterSpecs Reviewed-by: weijun, ahgross, rhalade ! src/java.base/share/classes/sun/security/pkcs/SignerInfo.java Changeset: 365a2d42 Author: Xue-Lei Andrew Fan Committer: Henry Jen Date: 2021-07-08 00:23:08 +0000 URL: https://git.openjdk.java.net/amber/commit/365a2d428cd67e5d9e01afc838e170132564133e 8269618: Better session identification Reviewed-by: jnimeh, rhalade, ahgross ! src/java.base/share/classes/sun/security/ssl/HelloCookieManager.java ! src/java.base/share/classes/sun/security/ssl/PreSharedKeyExtension.java ! src/java.base/share/classes/sun/security/ssl/RandomCookie.java ! src/java.base/share/classes/sun/security/ssl/RenegoInfoExtension.java ! src/java.base/share/classes/sun/security/ssl/SessionId.java + src/java.base/share/classes/sun/security/util/ByteArrays.java Changeset: c714707e Author: Xue-Lei Andrew Fan Committer: Henry Jen Date: 2021-07-08 04:37:39 +0000 URL: https://git.openjdk.java.net/amber/commit/c714707eac85b0771c86314f388f286c6a0b6f84 8268205: Enhance DTLS client handshake Reviewed-by: jnimeh, ahgross, rhalade ! src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java Changeset: 9c4988da Author: Jamil Nimeh Committer: Henry Jen Date: 2021-07-08 16:14:37 +0000 URL: https://git.openjdk.java.net/amber/commit/9c4988daeb2098c26c02a6b31fbf88d01d03883a 8268193: Improve requests of certificates Reviewed-by: xuelei, rhalade, ahgross ! src/java.base/share/classes/sun/security/ssl/CertificateRequest.java ! src/java.base/share/classes/sun/security/ssl/ClientHandshakeContext.java ! src/java.base/share/classes/sun/security/ssl/ServerKeyExchange.java Changeset: 44ce8673 Author: Jamil Nimeh Committer: Henry Jen Date: 2021-07-08 17:17:34 +0000 URL: https://git.openjdk.java.net/amber/commit/44ce8673146ceb724ace75f4790f7f9c7d0e2bad 8270105: Fix ServerKeyExchange copyright Reviewed-by: jnimeh, weijun ! src/java.base/share/classes/sun/security/ssl/ServerKeyExchange.java Changeset: f2c5728a Author: Jamil Nimeh Committer: Henry Jen Date: 2021-07-08 21:08:49 +0000 URL: https://git.openjdk.java.net/amber/commit/f2c5728a86729ebfd9303e3abef53b90dbf3d7f7 8268199: Correct certificate requests Reviewed-by: xuelei, ahgross, rhalade ! src/java.base/share/classes/sun/security/ssl/CertificateRequest.java Changeset: 3ab35633 Author: Prasanta Sadhukhan Committer: Henry Jen Date: 2021-07-12 15:37:22 +0000 URL: https://git.openjdk.java.net/amber/commit/3ab356335dfe3c8ece88797de22b75fef247bd39 8265574: Improve handling of sheets Reviewed-by: azvegint, prr, rhalade, mschoene, ahgross ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java Changeset: af82404b Author: Jamsheed Mohammed C M Committer: Henry Jen Date: 2021-07-15 21:05:00 +0000 URL: https://git.openjdk.java.net/amber/commit/af82404b3cd04c00212c19afcaa703bb3e56f40e 8269624: Enhance method selection support Reviewed-by: vlivanov, rhalade, thartmann, iignatyev, jwilhelm, ahgross ! src/hotspot/share/code/dependencies.cpp Changeset: 4e4a3cf6 Author: Prasanta Sadhukhan Committer: Henry Jen Date: 2021-07-16 03:46:32 +0000 URL: https://git.openjdk.java.net/amber/commit/4e4a3cf657fc5bf34e47e5ef6ebe9e73038dc605 8269763: The JEditorPane is blank after JDK-8265167 Reviewed-by: azvegint, prr ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFParser.java Changeset: 333b9d57 Author: Prasanta Sadhukhan Committer: Henry Jen Date: 2021-07-16 16:25:11 +0000 URL: https://git.openjdk.java.net/amber/commit/333b9d57150b0c4518f0fac1b0002a6f8a924080 8265580: Enhanced style for RTF kit Reviewed-by: rhalade, azvegint, prr, mschoene ! src/java.desktop/share/classes/javax/swing/text/rtf/RTFReader.java Changeset: b774d31c Author: Weijun Wang Committer: Henry Jen Date: 2021-07-23 17:52:57 +0000 URL: https://git.openjdk.java.net/amber/commit/b774d31c48838c2e1224fffd417d6d2d1b127666 8266689: More Constrained Delegation Reviewed-by: valeriep, rhalade, ahgross ! src/java.security.jgss/share/classes/sun/security/jgss/krb5/SubjectComber.java ! src/jdk.security.auth/share/classes/com/sun/security/auth/module/Krb5LoginModule.java Changeset: 24b588ed Author: Harold Seigel Committer: Henry Jen Date: 2021-07-26 14:37:15 +0000 URL: https://git.openjdk.java.net/amber/commit/24b588eddb1505dd563cf21103b9491b2d26a6ca 8270398: Enhance canonicalization Reviewed-by: rhalade, mschoene, coleenp ! src/hotspot/share/classfile/verifier.cpp Changeset: 76373ae3 Author: Harold Seigel Committer: Henry Jen Date: 2021-07-26 17:32:18 +0000 URL: https://git.openjdk.java.net/amber/commit/76373ae3c80b31aff3df98e701ca919ca8dae0bd 8270404: Better canonicalization Reviewed-by: coleenp, rhalade, mschoene ! src/hotspot/share/classfile/classFileParser.cpp ! src/hotspot/share/oops/instanceKlass.cpp Changeset: 25c85848 Author: Jamsheed Mohammed C M Committer: Henry Jen Date: 2021-08-03 10:39:35 +0000 URL: https://git.openjdk.java.net/amber/commit/25c85848794f0d42cada95309cd83f0baf091df8 8271723: Unproblemlist runtime/InvocationTests/invokevirtualTests.java Reviewed-by: thartmann ! test/hotspot/jtreg/ProblemList.txt Changeset: 4b9303b7 Author: Ian Graves Committer: Henry Jen Date: 2021-09-07 18:54:25 +0000 URL: https://git.openjdk.java.net/amber/commit/4b9303b77b43d890ebacbec38b4ac5db7e171886 8273308: PatternMatchTest.java fails on CI Reviewed-by: dfuchs, smarks ! src/java.base/share/classes/java/util/regex/Pattern.java Changeset: 54a29a44 Author: Phil Race Date: 2021-10-19 20:45:27 +0000 URL: https://git.openjdk.java.net/amber/commit/54a29a4470a0482c6b7f9f2d695e357044e684a7 8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails Reviewed-by: serb, jdv, kizune ! test/jdk/ProblemList.txt - test/jdk/java/awt/font/TextLayout/CombiningPerf.java Changeset: bd2b41dd Author: Weijun Wang Date: 2021-10-19 20:48:17 +0000 URL: https://git.openjdk.java.net/amber/commit/bd2b41dd7062c50f3aaebec2137d5fdd9546c120 8275252: Migrate cacerts from JKS to password-less PKCS12 Reviewed-by: erikj, ihse, mullan ! make/ToolsJdk.gmk ! make/jdk/src/classes/build/tools/generatecacerts/GenerateCacerts.java ! test/jdk/sun/security/lib/cacerts/VerifyCACerts.java Changeset: e63c1486 Author: Valerie Peng Date: 2021-10-19 20:50:56 +0000 URL: https://git.openjdk.java.net/amber/commit/e63c1486dc00ee64dea1a76b5a44e34f06eb144f 8264849: Add KW and KWP support to PKCS11 provider Reviewed-by: ascarpino ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11AEADCipher.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Cipher.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyFactory.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyStore.java + src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11KeyWrapCipher.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Mac.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11PSSSignature.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11Signature.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/Token.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11.java ! src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11Exception.java + test/jdk/sun/security/pkcs11/Cipher/KeyWrap/NISTWrapKAT.java + test/jdk/sun/security/pkcs11/Cipher/KeyWrap/TestCipherKeyWrapperTest.java + test/jdk/sun/security/pkcs11/Cipher/KeyWrap/TestGeneral.java + test/jdk/sun/security/pkcs11/Cipher/KeyWrap/TestKeySizeCheck.java + test/jdk/sun/security/pkcs11/Cipher/KeyWrap/XMLEncKAT.java Changeset: 926966be Author: Joe Darcy Date: 2021-10-19 20:53:23 +0000 URL: https://git.openjdk.java.net/amber/commit/926966be7ad91d2b4a750583c78721b2cdb26981 8275003: Suppress warnings on non-serializable non-transient instance fields in windows mscapi Reviewed-by: valeriep ! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CKey.java ! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CPublicKey.java Changeset: c24fb852 Author: Weijun Wang Date: 2021-10-19 21:04:14 +0000 URL: https://git.openjdk.java.net/amber/commit/c24fb852f20bf0fc2817dfed52ff1609a5bced59 8275512: Upgrade required version of jtreg to 6.1 Reviewed-by: ihse, iignatyev, joehw, lancea, jjg, mchung ! make/conf/jib-profiles.js ! make/conf/test-dependencies ! test/hotspot/jtreg/TEST.ROOT ! test/jaxp/TEST.ROOT ! test/jdk/TEST.ROOT ! test/langtools/TEST.ROOT ! test/lib-test/TEST.ROOT Changeset: 77b27893 Author: Prasanta Sadhukhan Date: 2021-10-20 06:31:59 +0000 URL: https://git.openjdk.java.net/amber/commit/77b27893969d84de7c890a60c3cccb99e89d5d91 7124287: [macosx] JTableHeader doesn't get focus after pressing F8 key Reviewed-by: kizune ! src/java.desktop/macosx/classes/com/apple/laf/AquaKeyBindings.java + test/jdk/javax/swing/plaf/basic/BasicTableHeaderUI/6394566/bug6394566.java Changeset: bd0bed71 Author: sunguoyun Committer: Tobias Hartmann Date: 2021-10-20 06:37:20 +0000 URL: https://git.openjdk.java.net/amber/commit/bd0bed71e55f0bb8b4619495c79184f94c0701fb 8273317: crash in cmovP_cmpP_zero_zeroNode::bottom_type() Reviewed-by: thartmann, kvn ! src/hotspot/share/adlc/output_h.cpp Changeset: 5454a767 Author: Hannes Walln?fer Date: 2021-10-20 09:59:55 +0000 URL: https://git.openjdk.java.net/amber/commit/5454a76752ba6f9042e6f60706753ce6c3aebe34 8275273: Add missing HtmlStyle documentation Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/HtmlStyle.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/stylesheet.css Changeset: 50a57238 Author: Thomas Schatzl Date: 2021-10-20 11:42:58 +0000 URL: https://git.openjdk.java.net/amber/commit/50a57238a8e34a976354b1de91c14cddacb3d88f 8274910: Compile in G1 evacuation failure injection code based on define Reviewed-by: sjohanss, ayang ! src/hotspot/share/gc/g1/g1ParScanThreadState.cpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.hpp ! src/hotspot/share/gc/g1/g1YoungGCEvacFailureInjector.cpp ! src/hotspot/share/gc/g1/g1YoungGCEvacFailureInjector.hpp ! src/hotspot/share/gc/g1/g1YoungGCEvacFailureInjector.inline.hpp ! src/hotspot/share/gc/g1/g1_globals.hpp Changeset: 135cf3c9 Author: Zhengyu Gu Date: 2021-10-20 11:46:13 +0000 URL: https://git.openjdk.java.net/amber/commit/135cf3c94d4bce1b23c4dd7697030f558a5f682b 8275439: Remove PrintVtableStats Reviewed-by: coleenp, dholmes ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/arrayKlass.hpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/klassVtable.cpp ! src/hotspot/share/oops/klassVtable.hpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/java.cpp Changeset: 1271fbf3 Author: Harold Seigel Date: 2021-10-20 12:15:40 +0000 URL: https://git.openjdk.java.net/amber/commit/1271fbf3d45ee654faf6e30ffff03c7fb2e5c4a0 8248584: Enable CHECK_UNHANDLED_OOPS for Windows fastdebug builds Reviewed-by: dholmes, erikj ! make/hotspot/lib/JvmFlags.gmk Changeset: a91a0a52 Author: Harold Seigel Date: 2021-10-20 12:20:50 +0000 URL: https://git.openjdk.java.net/amber/commit/a91a0a523a8d781d35950941cd87cdc430d32a71 8233724: Remove -Wc++14-compat warning suppression in operator_new.cpp Reviewed-by: coleenp ! src/hotspot/share/memory/operator_new.cpp Changeset: 043cde22 Author: Daniel Jelinski Committer: Daniel Fuchs Date: 2021-10-20 14:06:08 +0000 URL: https://git.openjdk.java.net/amber/commit/043cde22d4d6bd975e75daa9ad52770cf79df934 8275319: java.net.NetworkInterface throws java.lang.Error instead of SocketException Reviewed-by: alanb, dfuchs ! src/java.base/windows/native/libnet/NetworkInterface.c ! src/java.base/windows/native/libnet/NetworkInterface_winXP.c Changeset: 35e5bb5f Author: Jaikiran Pai Date: 2021-10-20 15:10:28 +0000 URL: https://git.openjdk.java.net/amber/commit/35e5bb5f59c01a1b07893780fa73f93c2abab653 8269336: Malformed jdk.serialFilter incorrectly handled Reviewed-by: rriggs ! src/java.base/share/classes/java/io/ObjectInputFilter.java + test/jdk/java/io/Serializable/serialFilter/InvalidGlobalFilterTest.java Changeset: 7e28bdd1 Author: Thomas Schatzl Date: 2021-10-20 15:33:50 +0000 URL: https://git.openjdk.java.net/amber/commit/7e28bdd1eb8276a5f78802febc9bd6f1cf597f55 8275055: Improve HeapRegionRemSet::split_card() Reviewed-by: sjohanss, ayang + src/hotspot/share/gc/g1/g1CardSetContainers.cpp ! src/hotspot/share/gc/g1/g1CardSetContainers.hpp ! src/hotspot/share/gc/g1/g1CardSetContainers.inline.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.cpp ! src/hotspot/share/gc/g1/heapRegionRemSet.hpp ! src/hotspot/share/gc/g1/heapRegionRemSet.inline.hpp Changeset: bbc60611 Author: Harold Seigel Date: 2021-10-20 15:48:43 +0000 URL: https://git.openjdk.java.net/amber/commit/bbc606117fcd8b48fc8f830c50cf7eb573da1c4c 8272614: Unused parameters in MethodHandleNatives linking methods Reviewed-by: dholmes, lfoltan ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java Changeset: 46b5bfbc Author: Alexander Zvegintsev Date: 2021-10-20 16:44:47 +0000 URL: https://git.openjdk.java.net/amber/commit/46b5bfbc38f14607f0db686a42f1fa96d2f61891 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos Reviewed-by: pbansal, serb, psadhukhan, prr ! test/jdk/ProblemList.txt ! test/jdk/com/apple/eawt/DefaultMenuBar/DefaultMenuBarTest.java Changeset: 0021a2f4 Author: Mikhailo Seledtsov Date: 2021-10-20 18:16:58 +0000 URL: https://git.openjdk.java.net/amber/commit/0021a2f462eab38b1a4c5c38736dfc7735f3c00a 8275449: Add linux-aarch64-zero build profile Reviewed-by: erikj ! make/autoconf/lib-ffi.m4 ! make/conf/jib-profiles.js Changeset: 913f9281 Author: Markus Karg Committer: Brian Burkhalter Date: 2021-10-20 18:30:52 +0000 URL: https://git.openjdk.java.net/amber/commit/913f9281ada7ebb670ed93a088d28afeaa635eb7 8273507: Convert test/jdk/java/nio/channels/Channels/TransferTo.java to TestNG test Reviewed-by: shade, bpb ! test/jdk/java/nio/channels/Channels/TransferTo.java Changeset: d1e3ca4e Author: Alisen Chung Committer: Phil Race Date: 2021-10-20 18:51:00 +0000 URL: https://git.openjdk.java.net/amber/commit/d1e3ca4ee35bf4c2ce9b6dae2518f533f36a98dd 8233558: [TESTBUG] WindowOwnedByEmbeddedFrameTest.java fails on macos Reviewed-by: serb, kizune, prr ! test/jdk/ProblemList.txt ! test/jdk/java/awt/Window/WindowOwnedByEmbeddedFrameTest/WindowOwnedByEmbeddedFrameTest.java Changeset: cea3f010 Author: Igor Ignatyev Date: 2021-10-20 19:24:46 +0000 URL: https://git.openjdk.java.net/amber/commit/cea3f010460c4b45e76bfac8a5b193c49fdd274a 8275666: serviceability/jvmti/GetObjectSizeClass.java shouldn't have vm.flagless Reviewed-by: lmesnik ! test/hotspot/jtreg/serviceability/jvmti/GetObjectSizeClass.java Changeset: af7c56b8 Author: vamsi-parasa Committer: Sandhya Viswanathan Date: 2021-10-20 22:40:51 +0000 URL: https://git.openjdk.java.net/amber/commit/af7c56b85bb2828a9d68f9e1c753a4adfa7ebb4f 8275167: x86 intrinsic for unsignedMultiplyHigh Reviewed-by: kvn, sviswanathan ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/classfile/vmIntrinsics.hpp ! src/hotspot/share/opto/c2compiler.cpp ! src/hotspot/share/opto/classes.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/library_call.hpp ! src/hotspot/share/opto/mulnode.cpp ! src/hotspot/share/opto/mulnode.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/java.base/share/classes/java/lang/Math.java ! test/micro/org/openjdk/bench/java/lang/MathBench.java Changeset: c7a80e60 Author: Hamlin Li Date: 2021-10-21 01:16:10 +0000 URL: https://git.openjdk.java.net/amber/commit/c7a80e60e2e201b573d4653fa978df527addc8a6 8275607: G1: G1CardSetAllocator::drop_all needs to call G1SegmentedArray::drop_all Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp Changeset: a120937e Author: Hamlin Li Date: 2021-10-21 01:17:52 +0000 URL: https://git.openjdk.java.net/amber/commit/a120937e8194a897ed4af9e7a2e33beb857987e5 8274988: G1: refine G1SegmentedArrayAllocOptions and G1CardSetAllocOptions Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1CardSetMemory.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.hpp Changeset: 09f5235c Author: Stefan Karlsson Date: 2021-10-21 07:47:10 +0000 URL: https://git.openjdk.java.net/amber/commit/09f5235c65de546640d5f923fa9369e28643c6ed 8275405: Linking error for classes with lambda template parameters and virtual functions Reviewed-by: ihse, pliden ! make/hotspot/lib/JvmMapfile.gmk Changeset: 0c3eaea1 Author: Alexander Zuev Date: 2021-10-21 09:51:18 +0000 URL: https://git.openjdk.java.net/amber/commit/0c3eaea11c83b3ee63d80de85d58a1cb6f870fd3 8168388: GetMousePositionTest fails with the message "Mouse position should not be null" Reviewed-by: psadhukhan, serb ! test/jdk/ProblemList.txt ! test/jdk/java/awt/Mouse/GetMousePositionTest/GetMousePositionWithOverlay.java Changeset: c41ce6d1 Author: Markus Gr?nlund Date: 2021-10-21 10:12:19 +0000 URL: https://git.openjdk.java.net/amber/commit/c41ce6d159e59a8c05dbeacde2d2612b58733d46 8275415: Prepare Leak Profiler for Lilliput Reviewed-by: rkennke ! src/hotspot/share/jfr/leakprofiler/chains/edgeStore.cpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeStore.hpp ! src/hotspot/share/jfr/leakprofiler/checkpoint/eventEmitter.cpp Changeset: 819d2df8 Author: Coleen Phillimore Date: 2021-10-21 11:28:22 +0000 URL: https://git.openjdk.java.net/amber/commit/819d2df8b01e04bcc89a0a995e21b68799f890be 8274794: Print all owned locks in hs_err file Reviewed-by: stuefe, dholmes ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/utilities/vmError.cpp ! test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileOverwriteTest.java + test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileScanner.java + test/hotspot/jtreg/runtime/ErrorHandling/TestErrorFileMutex.java Changeset: cd07b3ca Author: Coleen Phillimore Date: 2021-10-21 11:46:24 +0000 URL: https://git.openjdk.java.net/amber/commit/cd07b3cab00e6656e73a29f82210e2dedf26df8c 8257534: misc tests failed with "NoClassDefFoundError: Could not initialize class java.util.concurrent.ThreadLocalRandom" Reviewed-by: hseigel ! test/hotspot/jtreg/vmTestbase/nsk/share/gc/gp/GarbageUtils.java Changeset: 60cb27dc Author: Kim Barrett Date: 2021-10-21 13:28:25 +0000 URL: https://git.openjdk.java.net/amber/commit/60cb27dcda475a66e329359ac1ee3ffcde95c657 8275426: PretouchTask num_chunks calculation can overflow Reviewed-by: ayang, tschatzl ! src/hotspot/share/gc/shared/pretouchTask.cpp Changeset: 45ce06c9 Author: Evan Whelan Committer: Sean Coffey Date: 2021-10-21 13:33:21 +0000 URL: https://git.openjdk.java.net/amber/commit/45ce06c9f3e9bee7d4bda313c38f0f0e8786a4db 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST Reviewed-by: dfuchs, coffeys, vtewari, michaelm ! src/java.base/share/classes/sun/net/www/http/HttpClient.java ! src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java + test/jdk/sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java + test/jdk/sun/net/www/http/RequestMethodCheck/java.base/sun/net/www/http/HttpClientAccess.java Changeset: e39bdc9d Author: Harold Seigel Date: 2021-10-21 13:50:32 +0000 URL: https://git.openjdk.java.net/amber/commit/e39bdc9ddb7ba50160d07a27e6038cdea6a594a8 8274714: Incorrect verifier protected access error message Reviewed-by: dholmes, coleenp ! src/hotspot/share/classfile/verifier.cpp + test/hotspot/jtreg/runtime/verifier/PutfieldProtectedTest.java + test/hotspot/jtreg/runtime/verifier/putfieldProtected.jasm Changeset: d589b664 Author: Weijun Wang Date: 2021-10-21 14:04:48 +0000 URL: https://git.openjdk.java.net/amber/commit/d589b664cc809aea39ec094e99b1898df1bf3c19 8270380: Change the default value of the java.security.manager system property to disallow Reviewed-by: lancea, mullan, rriggs ! src/java.base/share/classes/java/lang/SecurityManager.java ! src/java.base/share/classes/java/lang/System.java ! test/jdk/java/lang/System/AllowSecurityManager.java ! test/jdk/java/lang/System/SecurityManagerWarnings.java ! test/jdk/sun/security/pkcs11/KeyStore/Basic.java ! test/jdk/sun/security/pkcs11/Provider/MultipleLogins.sh Changeset: 3b0ce23b Author: Christian Hagedorn Date: 2021-10-21 14:05:45 +0000 URL: https://git.openjdk.java.net/amber/commit/3b0ce23bcd827d0998fe9b43e5b0220c915dab21 8274888: Dump "-DReproduce=true" to the test VM command line output Reviewed-by: thartmann, kvn ! test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java Changeset: 3cb241a9 Author: Joe Darcy Date: 2021-10-21 15:25:10 +0000 URL: https://git.openjdk.java.net/amber/commit/3cb241a91fd2cc6b0b3b333288028694e60f723f 8275686: Suppress warnings on non-serializable non-transient instance fields in java.rmi Reviewed-by: bpb, iris, rriggs ! src/java.rmi/share/classes/sun/rmi/server/UnicastRef.java Changeset: 0761a4b9 Author: Joe Darcy Date: 2021-10-21 15:26:07 +0000 URL: https://git.openjdk.java.net/amber/commit/0761a4b915217abb08ef9b5c1a60878aedf5572c 8275688: Suppress warnings on non-serializable non-transient instance fields in DualPivotQuicksort Reviewed-by: rriggs ! src/java.base/share/classes/java/util/DualPivotQuicksort.java Changeset: af146501 Author: Mikhailo Seledtsov Date: 2021-10-21 15:31:03 +0000 URL: https://git.openjdk.java.net/amber/commit/af14650127de47058b958be411503584c0ba6323 8275569: Add linux-aarch64 to test-make profiles Reviewed-by: ihse ! make/conf/jib-profiles.js Changeset: bef8cf1b Author: Albert Mingkun Yang Date: 2021-10-21 15:49:21 +0000 URL: https://git.openjdk.java.net/amber/commit/bef8cf1ba14d3846977942844f341f5c5a1f44c4 8275714: G1: remove unused variable in G1Policy::transfer_survivors_to_cset Reviewed-by: tschatzl ! src/hotspot/share/gc/g1/g1Policy.cpp Changeset: 49f9d803 Author: Sean Mullan Date: 2021-10-21 17:28:40 +0000 URL: https://git.openjdk.java.net/amber/commit/49f9d8031e9c678e20dcfc1ba06758b511a26b07 8243585: AlgorithmChecker::check throws confusing exception when it rejects the signer key Reviewed-by: ascarpino ! src/java.base/share/classes/sun/security/provider/certpath/AlgorithmChecker.java ! src/java.base/share/classes/sun/security/provider/certpath/CertPathConstraintsParameters.java ! src/java.base/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/java.base/share/classes/sun/security/util/AlgorithmDecomposer.java ! src/java.base/share/classes/sun/security/util/DisabledAlgorithmConstraints.java ! test/jdk/sun/security/ssl/SSLContextImpl/TrustTrustedCert.java ! test/jdk/sun/security/tools/jarsigner/CheckSignerCertChain.java ! test/jdk/sun/security/tools/jarsigner/Warning.java Changeset: 7dd82374 Author: Yumin Qi Date: 2021-10-21 18:30:21 +0000 URL: https://git.openjdk.java.net/amber/commit/7dd823740f7bfc55f456a5c8c199475cc85dfea3 8275084: CDS warning when building with LOG=debug Reviewed-by: dholmes, iklam ! src/hotspot/share/cds/classListWriter.cpp Changeset: 0961de47 Author: Dean Long Date: 2021-10-21 19:02:38 +0000 URL: https://git.openjdk.java.net/amber/commit/0961de47de1bf4379089e010978bcb4708fde767 8275347: ciReplay: staticfield lines not properly terminated Reviewed-by: neliasso, chagedorn ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/ci/ciReplay.cpp ! test/hotspot/jtreg/compiler/ciReplay/CiReplayBase.java Changeset: 4e9dd4bd Author: Andrey Turbanov Committer: Mandy Chung Date: 2021-10-21 20:52:31 +0000 URL: https://git.openjdk.java.net/amber/commit/4e9dd4bddb888717d774147d4ba1acecc750629c 8275384: Change nested classes in jdk.jconsole to static nested classes Reviewed-by: alanb, sspitsyn, mchung ! src/jdk.jconsole/share/classes/sun/tools/jconsole/MaximizableInternalFrame.java ! src/jdk.jconsole/share/classes/sun/tools/jconsole/MemoryTab.java ! src/jdk.jconsole/share/classes/sun/tools/jconsole/ThreadTab.java ! src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XMBeanAttributes.java ! src/jdk.jconsole/share/classes/sun/tools/jconsole/inspector/XMBeanNotifications.java Changeset: 6a466fe7 Author: Joe Darcy Date: 2021-10-21 21:11:01 +0000 URL: https://git.openjdk.java.net/amber/commit/6a466fe7ae281967d1cc4c8029b306f2d66567c9 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields 8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type Reviewed-by: erikj, sspitsyn, jlahoda, vromero, rriggs, smarks ! src/jdk.compiler/share/classes/com/sun/tools/javac/code/Symtab.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Check.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties ! src/jdk.internal.opt/share/classes/jdk/internal/joptsimple/OptionException.java ! src/jdk.jdeps/share/classes/com/sun/tools/classfile/ConstantPool.java ! src/jdk.jdeps/share/classes/com/sun/tools/javap/InternalError.java ! src/jdk.jdeps/share/classes/com/sun/tools/javap/JavapTask.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java ! src/jdk.jdeps/share/classes/com/sun/tools/jdeps/MultiReleaseException.java + test/langtools/tools/javac/diags/examples/ImproperSPF.java ! test/langtools/tools/javac/diags/examples/ImproperSVUID.java + test/langtools/tools/javac/diags/examples/IneffectualSerialEnum.java + test/langtools/tools/javac/diags/examples/IneffectualSerialExtern.java + test/langtools/tools/javac/diags/examples/IneffectualSerialRecord.java + test/langtools/tools/javac/diags/examples/SerialInterfaceMethodsAndFields.java + test/langtools/tools/javac/diags/examples/SerialMissingNoArgCtor.java + test/langtools/tools/javac/diags/examples/SerialNonPrivateMethod.java + test/langtools/tools/javac/warnings/Serial/CtorAccess.java + test/langtools/tools/javac/warnings/Serial/CtorAccess.out + test/langtools/tools/javac/warnings/Serial/DeepNestingSuppression.java + test/langtools/tools/javac/warnings/Serial/DeepNestingSuppression.out + test/langtools/tools/javac/warnings/Serial/EnumSerial.java + test/langtools/tools/javac/warnings/Serial/EnumSerial.out + test/langtools/tools/javac/warnings/Serial/Extern.java + test/langtools/tools/javac/warnings/Serial/Extern.out + test/langtools/tools/javac/warnings/Serial/ImproperReturnTypes.java + test/langtools/tools/javac/warnings/Serial/ImproperReturnTypes.out + test/langtools/tools/javac/warnings/Serial/ImproperSerialPF.java + test/langtools/tools/javac/warnings/Serial/ImproperSerialPF.out + test/langtools/tools/javac/warnings/Serial/InstanceField.java + test/langtools/tools/javac/warnings/Serial/InstanceField.out + test/langtools/tools/javac/warnings/Serial/InterfaceFields.java + test/langtools/tools/javac/warnings/Serial/InterfaceFields.out + test/langtools/tools/javac/warnings/Serial/InterfaceNonPrivateMethods.java + test/langtools/tools/javac/warnings/Serial/InterfaceNonPrivateMethods.out + test/langtools/tools/javac/warnings/Serial/RecordSerial.java + test/langtools/tools/javac/warnings/Serial/RecordSerial.out + test/langtools/tools/javac/warnings/Serial/SerialMethodArity.java + test/langtools/tools/javac/warnings/Serial/SerialMethodArity.out + test/langtools/tools/javac/warnings/Serial/SerialMethodMods.java + test/langtools/tools/javac/warnings/Serial/SerialMethodMods.out + test/langtools/tools/javac/warnings/Serial/SerialMethodThrows.java + test/langtools/tools/javac/warnings/Serial/SerialMethodThrows.out Changeset: b813f8c4 Author: duke Date: 2021-10-21 22:01:42 +0000 URL: https://git.openjdk.java.net/amber/commit/b813f8c48c89f326918fc99f2010484d404c0503 Automatic merge of master into stats-before-this-super ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties From mr at openjdk.java.net Fri Oct 22 18:58:34 2021 From: mr at openjdk.java.net (Mark Reinhold) Date: Fri, 22 Oct 2021 18:58:34 GMT Subject: [amber-docs] RFR: Revise and restructure for the new web-page generator Message-ID: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> Please review these changes to revise and restructure the amber-docs repository for use with the new web-page generator for `openjdk.java.net`. That generator is presently defined in https://github.com/mbreinhold/ojweb-generate, which will shortly be moved over to the OpenJDK organization. Please see the `README.md` file in that repository for instructions on how to use it. I?ve tried to keep content changes to a minimum, primarily adjusting minor things such as heading levels and code examples for better rendering. You can preview the output here: https://openjdk.java.net/_test/amber/ For easy reviewing, there?s also a map of the entire subtree: https://openjdk.java.net/_test/amber/_map ------------- Commit messages: - Drop execute bits on text files - Use a real Makefile instead of a symbolic link - Further minor layout tweaks - Restructure templated-strings.md, and add it to the project page - Merge remote-tracking branch 'origin/master' into ojweb - Create symbolic link to ojweb-generate/Makefile - Update .gitignore - Remove old publication infrastructure - Extending switch for Patterns: Expose inherent list structure - Text blocks guide: Shift position of table of contents - ... and 17 more: https://git.openjdk.java.net/amber-docs/compare/c182d1e6...b198f1b6 Changes: https://git.openjdk.java.net/amber-docs/pull/10/files Webrev: https://webrevs.openjdk.java.net/?repo=amber-docs&pr=10&range=00 Stats: 3116 lines in 27 files changed: 223 ins; 1841 del; 1052 mod Patch: https://git.openjdk.java.net/amber-docs/pull/10.diff Fetch: git fetch https://git.openjdk.java.net/amber-docs pull/10/head:pull/10 PR: https://git.openjdk.java.net/amber-docs/pull/10 From briangoetz at openjdk.java.net Fri Oct 22 18:58:34 2021 From: briangoetz at openjdk.java.net (Brian Goetz) Date: Fri, 22 Oct 2021 18:58:34 GMT Subject: [amber-docs] RFR: Revise and restructure for the new web-page generator In-Reply-To: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> References: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> Message-ID: On Fri, 22 Oct 2021 00:00:08 GMT, Mark Reinhold wrote: > Please review these changes to revise and restructure the amber-docs repository for use with the new web-page generator for `openjdk.java.net`. > > That generator is presently defined in https://github.com/mbreinhold/ojweb-generate, which will shortly be moved over to the OpenJDK organization. Please see the `README.md` file in that repository for instructions on how to use it. > > I?ve tried to keep content changes to a minimum, primarily adjusting minor things such as heading levels and code examples for better rendering. > > You can preview the output here: https://openjdk.java.net/_test/amber/ > > For easy reviewing, there?s also a map of the entire subtree: https://openjdk.java.net/_test/amber/_map Marked as reviewed by briangoetz (Lead). Marked as reviewed by briangoetz (Lead). ------------- PR: https://git.openjdk.java.net/amber-docs/pull/10 From jlaskey at openjdk.java.net Fri Oct 22 18:58:35 2021 From: jlaskey at openjdk.java.net (Jim Laskey) Date: Fri, 22 Oct 2021 18:58:35 GMT Subject: [amber-docs] RFR: Revise and restructure for the new web-page generator In-Reply-To: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> References: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> Message-ID: <7j9W7c24ZZB6NSjDIeXC2KCUwObbR4cJ1albHjmQzYc=.e9f53b72-e6b8-43c2-b16e-68922e3fd872@github.com> On Fri, 22 Oct 2021 00:00:08 GMT, Mark Reinhold wrote: > Please review these changes to revise and restructure the amber-docs repository for use with the new web-page generator for `openjdk.java.net`. > > That generator is presently defined in https://github.com/mbreinhold/ojweb-generate, which will shortly be moved over to the OpenJDK organization. Please see the `README.md` file in that repository for instructions on how to use it. > > I?ve tried to keep content changes to a minimum, primarily adjusting minor things such as heading levels and code examples for better rendering. > > You can preview the output here: https://openjdk.java.net/_test/amber/ > > For easy reviewing, there?s also a map of the entire subtree: https://openjdk.java.net/_test/amber/_map Marked as reviewed by jlaskey (Committer). ------------- PR: https://git.openjdk.java.net/amber-docs/pull/10 From jlaskey at openjdk.java.net Fri Oct 22 19:20:14 2021 From: jlaskey at openjdk.java.net (Jim Laskey) Date: Fri, 22 Oct 2021 19:20:14 GMT Subject: [amber-docs] RFR: Revise and restructure for the new web-page generator In-Reply-To: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> References: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> Message-ID: On Fri, 22 Oct 2021 00:00:08 GMT, Mark Reinhold wrote: > Please review these changes to revise and restructure the amber-docs repository for use with the new web-page generator for `openjdk.java.net`. > > That generator is presently defined in https://github.com/mbreinhold/ojweb-generate, which will shortly be moved over to the OpenJDK organization. Please see the `README.md` file in that repository for instructions on how to use it. > > I?ve tried to keep content changes to a minimum, primarily adjusting minor things such as heading levels and code examples for better rendering. > > You can preview the output here: https://openjdk.java.net/_test/amber/ > > For easy reviewing, there?s also a map of the entire subtree: https://openjdk.java.net/_test/amber/_map site/guides/text-blocks-guide.md line 522: > 520: `\u0020` _cannot_ be used as a substitute for `\040`. > 521: > 522: ### New Escape Sequences Is   a glitch? site/guides/text-blocks-guide.md line 845: > 843: is done for text blocks. > 844: > 845: ### `String translateEscapes()`   again ------------- PR: https://git.openjdk.java.net/amber-docs/pull/10 From mr at openjdk.java.net Fri Oct 22 21:42:13 2021 From: mr at openjdk.java.net (Mark Reinhold) Date: Fri, 22 Oct 2021 21:42:13 GMT Subject: [amber-docs] RFR: Revise and restructure for the new web-page generator In-Reply-To: References: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> Message-ID: On Fri, 22 Oct 2021 19:18:05 GMT, Jim Laskey wrote: >> Please review these changes to revise and restructure the amber-docs repository for use with the new web-page generator for `openjdk.java.net`. >> >> That generator is presently defined in https://github.com/mbreinhold/ojweb-generate, which will shortly be moved over to the OpenJDK organization. Please see the `README.md` file in that repository for instructions on how to use it. >> >> I?ve tried to keep content changes to a minimum, primarily adjusting minor things such as heading levels and code examples for better rendering. >> >> You can preview the output here: https://openjdk.java.net/_test/amber/ >> >> For easy reviewing, there?s also a map of the entire subtree: https://openjdk.java.net/_test/amber/_map > > site/guides/text-blocks-guide.md line 845: > >> 843: is done for text blocks. >> 844: >> 845: ### `String translateEscapes()` > >   again The ` `s that you see are tweaks to defend against poor line breaks in the table of contents at the top of the document. Without them then at normal width ?New Escape Sequences? would break after ?New,? and ?`String translateEscapes()`? would break after ?`String`?. ------------- PR: https://git.openjdk.java.net/amber-docs/pull/10 From duke at openjdk.java.net Fri Oct 22 22:19:21 2021 From: duke at openjdk.java.net (duke) Date: Fri, 22 Oct 2021 22:19:21 GMT Subject: git: openjdk/amber-docs: Revise and restructure for the new web-page generator (#10) Message-ID: Changeset: b1b1c46c Author: Mark Reinhold Committer: GitHub Date: 2021-10-22 15:18:36 +0000 URL: https://git.openjdk.java.net/amber-docs/commit/b1b1c46cde6653383df878ecc9c6160ef3cd8593 Revise and restructure for the new web-page generator (#10) * Rename site/index.md -> site/_index.md * Names of generated files no longer end in ?.html? * Add JEP numbers to site index * Fix site index * Remove JavaScript from the Text Blocks guide * Remove extraneous paragraph elements from the Text Blocks guide * Remove extraneous from site index * Fix broken internal links * Assorted markup fixes - Raise `

`s to `

`s (`s/^#### /### /`) - Add `{.author}` to `

`s listing authors and dates - Use `
` in multi-line author blocks - Adjust emphasis in a few places, using blockquotes and italics - Use `## Sub title {.subtitle}` for subtitles - Use unordered lists where appropriate * Remove redundant copy of extending-switch-for-patterns.md * Place date information into date-classed H2 elements * Restore historical ?Data Classes? documents * Highlight control characters in the Text Blocks guide This change restores the JavaScript-driven highlighting of control characters in this guide. It also replaces the control characters that do not exist in the Deja Vu fonts, namely - 2409 SYMBOL FOR HORIZONTAL TABULATION (?) - 240D SYMBOL FOR CARRIAGE RETURN (?) - 240A SYMBOL FOR LINE FEED (?) with corresponding arrow symbols that do exist in those fonts: - 21A6 RIGHTWARDS ARROW FROM BAR (?) - 2190 LEFTWARDS ARROW (?) - 2193 DOWNWARDS ARROW (?) * Add missing documents to the index page * Capitalize titles consistently * Define short anchors for FAQ and guideline items * Text blocks guide: Add table of contents * Text blocks guide: Shift position of table of contents * Extending switch for Patterns: Expose inherent list structure * Remove old publication infrastructure * Update .gitignore * Create symbolic link to ojweb-generate/Makefile * Restructure templated-strings.md, and add it to the project page * Further minor layout tweaks * Use a real Makefile instead of a symbolic link Skara doesn?t (yet) like symbolic links. * Drop execute bits on text files - .github/workflows/publish.yaml ! .gitignore - .nojeckyll ! Makefile ! eg-drafts/deconstruction-patterns-records-and-classes.md ! eg-drafts/reconstruction-records-and-classes.md - etc/footer.html - etc/style.css + site/_index.md ! site/design-notes/constables.md ! site/design-notes/data-classes-historical-1.html ! site/design-notes/data-classes-historical-2.html - site/design-notes/extending-switch-for-patterns.md ! site/design-notes/patterns/extending-switch-for-patterns.md ! site/design-notes/patterns/pattern-match-object-model.md ! site/design-notes/patterns/pattern-match-semantics.md ! site/design-notes/patterns/pattern-match-translation.md ! site/design-notes/patterns/pattern-matching-for-java.md ! site/design-notes/patterns/type-patterns-in-switch.md ! site/design-notes/records-and-sealed-classes.md ! site/design-notes/templated-strings.md ! site/design-notes/towards-better-serialization.md ! site/guides/lvti-faq.md ! site/guides/lvti-style-guide.md + site/guides/text-blocks-guide.head ! site/guides/text-blocks-guide.md - site/index.md From briangoetz at openjdk.java.net Fri Oct 22 22:21:21 2021 From: briangoetz at openjdk.java.net (Brian Goetz) Date: Fri, 22 Oct 2021 22:21:21 GMT Subject: [amber-docs] Withdrawn: Revise and restructure for the new web-page generator In-Reply-To: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> References: <8Tqn5Ka_vWvx97HRPkBrat8TT2Re33ZRdsp1FqCCgZM=.34286257-7dbf-43b0-aebf-1cbda9f2d726@github.com> Message-ID: On Fri, 22 Oct 2021 00:00:08 GMT, Mark Reinhold wrote: > Please review these changes to revise and restructure the amber-docs repository for use with the new web-page generator for `openjdk.java.net`. > > That generator is presently defined in https://github.com/mbreinhold/ojweb-generate, which will shortly be moved over to the OpenJDK organization. Please see the `README.md` file in that repository for instructions on how to use it. > > I?ve tried to keep content changes to a minimum, primarily adjusting minor things such as heading levels and code examples for better rendering. > > You can preview the output here: https://openjdk.java.net/_test/amber/ > > For easy reviewing, there?s also a map of the entire subtree: https://openjdk.java.net/_test/amber/_map This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/amber-docs/pull/10 From amaembo at gmail.com Mon Oct 25 06:01:20 2021 From: amaembo at gmail.com (Tagir Valeev) Date: Mon, 25 Oct 2021 13:01:20 +0700 Subject: Guarded pattern with total primary pattern inside instanceof Message-ID: Hello! I tried the following code: public class Demo { static void test(Object obj) { if (obj instanceof (Object o && String.valueOf(o).equals("null"))) { System.out.println("null"); } } public static void main(String[] args) { test(null); test("null"); } } As (Object o && String.valueOf(o).equals("null")) is not a total pattern, I expect this code to be compilable successfully (and it should print "null" once). However, javac has its own opinion: Demo.java:5: error: expression type Object is a subtype of pattern type Object if (obj instanceof (Object o && String.valueOf(o).equals("null"))) { ^ I'm using openjdk version "17" 2021-09-14 OpenJDK Runtime Environment (build 17+35-2724) Spec is quite unambiguous here [1], so I believe it's a javac problem. [1] https://docs.oracle.com/javase/specs/jls/se17/preview/specs/patterns-switch-jls.html#jls-15.20.2 From duke at openjdk.java.net Thu Oct 28 22:07:04 2021 From: duke at openjdk.java.net (duke) Date: Thu, 28 Oct 2021 22:07:04 GMT Subject: git: openjdk/amber: stats-before-this-super: 76 new changesets Message-ID: <0d0efa8c-5164-4270-a30c-312ef5d54073@openjdk.org> Changeset: c978ca87 Author: Sergey Bylokhov Date: 2021-10-22 03:05:16 +0000 URL: https://git.openjdk.java.net/amber/commit/c978ca87de2d9152345dfd85983278c42bb28cd3 8275344: -Xcheck:jni produces some warnings in the LCMS.c Reviewed-by: azvegint, prr, kizune ! src/java.desktop/share/native/liblcms/LCMS.c ! test/jdk/java/awt/color/ICC_ColorSpace/MTTransformReplacedProfile.java Changeset: fab3d6c6 Author: David Holmes Date: 2021-10-22 04:47:53 +0000 URL: https://git.openjdk.java.net/amber/commit/fab3d6c6122b2ce23dfa12db489923d8261f8f35 8275761: Backout: JDK-8274794 Print all owned locks in hs_err file Reviewed-by: mikael ! src/hotspot/share/runtime/mutex.cpp ! src/hotspot/share/runtime/mutex.hpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/mutexLocker.hpp ! src/hotspot/share/utilities/vmError.cpp ! test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileOverwriteTest.java - test/hotspot/jtreg/runtime/ErrorHandling/ErrorFileScanner.java - test/hotspot/jtreg/runtime/ErrorHandling/TestErrorFileMutex.java Changeset: 1efe946d Author: Stefan Karlsson Date: 2021-10-22 08:20:43 +0000 URL: https://git.openjdk.java.net/amber/commit/1efe946db77e38507511a9c898b8b59fe9ba1aeb 8275712: Hashtable literal_size functions are broken Reviewed-by: coleenp, zgu ! src/hotspot/share/classfile/stringTable.cpp ! src/hotspot/share/utilities/hashtable.cpp Changeset: b2128a96 Author: Andy Herrick Date: 2021-10-22 12:17:45 +0000 URL: https://git.openjdk.java.net/amber/commit/b2128a96670daeca93aca84ee7613b2b337ddfa4 8263155: Allow additional contents for DMG Reviewed-by: asemenyuk, almatvee ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgBundler.java ! src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/DMGsetup.scpt ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/DeployParams.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/StandardBundlerParam.java ! src/jdk.jpackage/share/classes/jdk/jpackage/internal/ValidOptions.java ! test/jdk/tools/jpackage/helpers/jdk/jpackage/test/MacHelper.java + test/jdk/tools/jpackage/macosx/DmgContentTest.java Changeset: dd622e55 Author: Albert Mingkun Yang Date: 2021-10-22 12:47:35 +0000 URL: https://git.openjdk.java.net/amber/commit/dd622e55c01966f8b2deddaba09164a0a302df2e 8275783: G1: fix incorrect region type documentation in HeapRegionType Reviewed-by: tschatzl ! src/hotspot/share/gc/g1/heapRegionType.hpp Changeset: 4e647aa5 Author: Albert Mingkun Yang Date: 2021-10-22 13:01:24 +0000 URL: https://git.openjdk.java.net/amber/commit/4e647aa584cf12dae76e81e203ad4f1ebc08c1a2 8275416: G1: remove unnecessary make_referent_alive in precleaning phase Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/shared/referenceProcessor.cpp ! src/hotspot/share/gc/shared/referenceProcessor.hpp Changeset: 4dec8fc4 Author: Doug Simon Date: 2021-10-22 16:20:31 +0000 URL: https://git.openjdk.java.net/amber/commit/4dec8fc4cc2b1762fba554d0401da8be0d6d1166 8275645: [JVMCI] avoid unaligned volatile reads on AArch64 Reviewed-by: kvn, never ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotConstantReflectionProvider.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotMemoryAccessProviderImpl.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/HotSpotObjectConstantImpl.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/MemoryAccessProviderData.java Changeset: 88bbf3c2 Author: Wu Yan Committer: Naoto Sato Date: 2021-10-22 16:23:25 +0000 URL: https://git.openjdk.java.net/amber/commit/88bbf3c2e6ac9f6d88cbb361cfbb4c16bb8eafc1 8273111: Default timezone should return zone ID if /etc/localtime is valid but not canonicalization on linux Co-authored-by: Sun Jianye Reviewed-by: naoto, mli ! src/java.base/unix/native/libjava/TimeZone_md.c ! src/java.base/unix/native/libjava/canonicalize_md.c + src/java.base/unix/native/libjava/path_util.c = src/java.base/unix/native/libjava/path_util.h Changeset: 6523c558 Author: Phil Race Date: 2021-10-22 17:22:12 +0000 URL: https://git.openjdk.java.net/amber/commit/6523c558d92dedf350576126960dee6cff8f6067 8198336: java/awt/FontMetrics/FontCrash.java fails in headless mode Reviewed-by: serb ! src/java.desktop/share/classes/java/awt/Component.java ! src/java.desktop/share/classes/sun/font/SunFontManager.java ! src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java ! test/jdk/ProblemList.txt - test/jdk/java/awt/FontMetrics/FontCrash.java Changeset: fec470f2 Author: Hai-May Chao Date: 2021-10-22 20:53:38 +0000 URL: https://git.openjdk.java.net/amber/commit/fec470f262d1df581f2a5fc2f0bdfea66757a8ad 8272163: Add -version option to keytool and jarsigner Reviewed-by: weijun ! src/java.base/share/classes/sun/security/tools/keytool/Main.java ! src/java.base/share/classes/sun/security/tools/keytool/Resources.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java ! src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Resources.java + test/jdk/sun/security/tools/jarsigner/VersionTest.java + test/jdk/sun/security/tools/keytool/VersionTest.java Changeset: c94dc2ab Author: Igor Ignatyev Date: 2021-10-23 03:59:55 +0000 URL: https://git.openjdk.java.net/amber/commit/c94dc2ab60f0548afa868e41a0b87a68030e0cac 8272854: split runtime/CommandLine/PrintTouchedMethods.java test Reviewed-by: iklam ! test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethods.java + test/hotspot/jtreg/runtime/CommandLine/PrintTouchedMethodsJcmd.java Changeset: 5bbe4cae Author: Sergey Tsypanov Committer: Stuart Marks Date: 2021-10-23 21:07:58 +0000 URL: https://git.openjdk.java.net/amber/commit/5bbe4cae8746765d2ce965b06fd1e5cf512326ae 8275293: A change done with JDK-8268764 mismatches the java.rmi.server.ObjID.hashCode spec Reviewed-by: rriggs, smarks ! src/java.rmi/share/classes/java/rmi/server/ObjID.java Changeset: 5dab76b9 Author: Hamlin Li Date: 2021-10-25 01:03:51 +0000 URL: https://git.openjdk.java.net/amber/commit/5dab76b939e381312ce5c89b9aebca628238a387 8275381: G1: refactor 2 constructors of G1CardSetConfiguration Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1CardSet.cpp ! src/hotspot/share/gc/g1/g1CardSet.hpp ! test/hotspot/gtest/gc/g1/test_g1CardSet.cpp Changeset: 1da5e6b0 Author: Christian Hagedorn Date: 2021-10-25 07:25:19 +0000 URL: https://git.openjdk.java.net/amber/commit/1da5e6b0e2c284c5dd295a0d48cc1c6c2fecf5b5 8275104: IR framework does not handle client VM builds correctly Reviewed-by: kvn, thartmann ! test/hotspot/jtreg/compiler/lib/ir_framework/flag/FlagVM.java ! test/hotspot/jtreg/compiler/lib/ir_framework/test/TestVM.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/examples/IRExample.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestCompLevels.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestDIgnoreCompilerControls.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestIRMatching.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestSanity.java ! test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestWithHelperClasses.java Changeset: f6232982 Author: Alexey Bakhtin Committer: Yuri Nesterenko Date: 2021-10-25 08:00:40 +0000 URL: https://git.openjdk.java.net/amber/commit/f6232982b91cb2314e96ddbde3984836a810a556 8271199: Mutual TLS handshake fails signing client certificate with custom sensitive PKCS11 key Reviewed-by: xuelei, valeriep ! src/java.base/share/classes/sun/security/rsa/RSAPSSSignature.java ! src/java.base/share/classes/sun/security/rsa/RSAPrivateCrtKeyImpl.java Changeset: 0bcc1749 Author: Stefan Karlsson Date: 2021-10-25 09:07:51 +0000 URL: https://git.openjdk.java.net/amber/commit/0bcc1749eaea20cb983a983073ad33d305681879 8275717: Reimplement STATIC_ASSERT to use static_assert Reviewed-by: stuefe, eosterlund, kbarrett ! src/hotspot/share/utilities/debug.hpp Changeset: 7f94302c Author: Albert Mingkun Yang Date: 2021-10-25 13:18:20 +0000 URL: https://git.openjdk.java.net/amber/commit/7f94302ceca001ded89ba9a653bf176ef90b16cd 8275511: G1: Rename needs_remset_update to remset_is_tracked in G1HeapRegionAttr Reviewed-by: tschatzl, sjohanss ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.inline.hpp ! src/hotspot/share/gc/g1/g1CollectionSet.cpp ! src/hotspot/share/gc/g1/g1HeapRegionAttr.hpp ! src/hotspot/share/gc/g1/g1ParScanThreadState.inline.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp Changeset: f143d2a8 Author: Jaikiran Pai Date: 2021-10-25 14:24:05 +0000 URL: https://git.openjdk.java.net/amber/commit/f143d2a88e1972cdce9eb6f61c2eb9754cb89251 8268595: java/io/Serializable/serialFilter/GlobalFilterTest.java#id1 failed in timeout Reviewed-by: chegar, rriggs ! test/jdk/java/io/Serializable/serialFilter/GlobalFilterTest.java Changeset: f610ef0d Author: Alexander Zvegintsev Date: 2021-10-25 14:27:17 +0000 URL: https://git.openjdk.java.net/amber/commit/f610ef0dbc17cd3066da799a02f7f5e977261d44 8196440: Regression automated Test 'java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java' fails Reviewed-by: serb, psadhukhan ! test/jdk/ProblemList.txt ! test/jdk/java/awt/TrayIcon/PopupMenuLeakTest/PopupMenuLeakTest.java Changeset: 7cf68b19 Author: Alexander Zvegintsev Date: 2021-10-25 14:34:36 +0000 URL: https://git.openjdk.java.net/amber/commit/7cf68b1901cc6f8ab30f8f8496de10f4017bfc58 8202932: java/awt/Component/NativeInLightShow/NativeInLightShow.java fails Reviewed-by: serb ! test/jdk/ProblemList.txt ! test/jdk/java/awt/Component/NativeInLightShow/NativeInLightShow.java Changeset: 3221a14f Author: Artem Semenov Committer: Anton Tarasov Date: 2021-10-25 16:26:43 +0000 URL: https://git.openjdk.java.net/amber/commit/3221a14f9eaf002d91597d84efdb125704710a4c 8273678: TableAccessibility and TableRowAccessibility miss autorelease Reviewed-by: ant, kizune, pbansal ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessible.java ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ColumnAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableAccessibility.h ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableAccessibility.m ! test/jdk/java/awt/a11y/AccessibleJTableTest.java Changeset: 89671aa1 Author: Igor Veresov Date: 2021-10-25 17:03:57 +0000 URL: https://git.openjdk.java.net/amber/commit/89671aa164ea500954b0d5caa5ce6190dfbc0d4e 8273712: C2: Add mechanism for rejecting inlining of low frequency call sites and deprecate MinInliningThreshold. Reviewed-by: kvn, rbackman ! src/hotspot/share/compiler/compilationPolicy.hpp ! src/hotspot/share/opto/bytecodeInfo.cpp ! src/hotspot/share/opto/parse.hpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/globals.hpp ! test/hotspot/jtreg/compiler/intrinsics/string/TestStringIntrinsics2.java Changeset: 97d3280e Author: Clive Verghese Committer: Paul Hohensee Date: 2021-10-25 18:33:57 +0000 URL: https://git.openjdk.java.net/amber/commit/97d3280eb4735f5b84cd4a9a1286e35c1c48113a 8275536: Add test to check that File::lastModified returns same time stamp as Files.getLastModifiedTime Reviewed-by: alanb, bpb + test/jdk/java/io/File/LastModifiedTest.java Changeset: 337a9b73 Author: Harold Seigel Date: 2021-10-25 19:44:25 +0000 URL: https://git.openjdk.java.net/amber/commit/337a9b73a75981d14eb4125e4354edda8d541361 8269853: Prefetch::read should accept pointer to const Reviewed-by: coleenp ! src/hotspot/os_cpu/aix_ppc/prefetch_aix_ppc.inline.hpp ! src/hotspot/os_cpu/bsd_aarch64/prefetch_bsd_aarch64.inline.hpp ! src/hotspot/os_cpu/bsd_x86/prefetch_bsd_x86.inline.hpp ! src/hotspot/os_cpu/bsd_zero/prefetch_bsd_zero.inline.hpp ! src/hotspot/os_cpu/linux_aarch64/prefetch_linux_aarch64.inline.hpp ! src/hotspot/os_cpu/linux_arm/prefetch_linux_arm.inline.hpp ! src/hotspot/os_cpu/linux_ppc/prefetch_linux_ppc.inline.hpp ! src/hotspot/os_cpu/linux_s390/prefetch_linux_s390.inline.hpp ! src/hotspot/os_cpu/linux_x86/prefetch_linux_x86.inline.hpp ! src/hotspot/os_cpu/linux_zero/prefetch_linux_zero.inline.hpp ! src/hotspot/os_cpu/windows_aarch64/prefetch_windows_aarch64.inline.hpp ! src/hotspot/os_cpu/windows_x86/prefetch_windows_x86.inline.hpp ! src/hotspot/share/runtime/prefetch.hpp Changeset: 43619458 Author: Weijun Wang Date: 2021-10-26 02:39:05 +0000 URL: https://git.openjdk.java.net/amber/commit/43619458d183bbbaec745887314ddcf7a8aa4136 8185844: MSCAPI doesn't list aliases correctly Reviewed-by: valeriep ! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CKeyStore.java + test/jdk/sun/security/mscapi/SetDupNameEntry.java Changeset: 10e1610f Author: Weijun Wang Date: 2021-10-26 02:45:23 +0000 URL: https://git.openjdk.java.net/amber/commit/10e1610f7b99f42f834478528df7ecfb4320aec1 8251134: Unwrapping a key with a Private Key generated by Microsoft CNG fails Reviewed-by: valeriep ! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CKeyStore.java ! src/jdk.crypto.mscapi/windows/classes/sun/security/mscapi/CRSACipher.java ! src/jdk.crypto.mscapi/windows/native/libsunmscapi/security.cpp + test/jdk/sun/security/mscapi/CngCipher.java Changeset: 3ff085e2 Author: Thomas Stuefe Date: 2021-10-26 04:52:01 +0000 URL: https://git.openjdk.java.net/amber/commit/3ff085e2967508ad312c9d32fa908807aefe69ee 8275582: Don't purge metaspace mapping lists Reviewed-by: coleenp, lkorinth ! src/hotspot/share/memory/metaspace/chunkManager.cpp ! src/hotspot/share/memory/metaspace/internalStats.hpp ! src/hotspot/share/memory/metaspace/rootChunkArea.cpp ! src/hotspot/share/memory/metaspace/rootChunkArea.hpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.hpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceNode.hpp ! test/hotspot/jtreg/runtime/Metaspace/elastic/MetaspaceTestWithThreads.java Changeset: 174f553f Author: Harold Seigel Date: 2021-10-26 12:05:09 +0000 URL: https://git.openjdk.java.net/amber/commit/174f553f7e3dbc91662ba51bc3813a4be0ee97c4 8275869: Problem list applications/jcstress/copy.java on Linux-aarch64 Reviewed-by: lfoltan, dholmes ! test/hotspot/jtreg/ProblemList.txt Changeset: 4961373a Author: Julia Boes Date: 2021-10-26 12:17:47 +0000 URL: https://git.openjdk.java.net/amber/commit/4961373a676126cd557f92a2e7bbc8c66b2976b1 8275137: jdk.unsupported/sun.reflect.ReflectionFactory.readObjectNoDataForSerialization uses wrong signature Reviewed-by: dfuchs ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java ! src/jdk.unsupported/share/classes/sun/reflect/ReflectionFactory.java ! test/jdk/sun/reflect/ReflectionFactory/ReflectionFactoryTest.java Changeset: 63e0f344 Author: Naoto Sato Date: 2021-10-26 12:32:49 +0000 URL: https://git.openjdk.java.net/amber/commit/63e0f344e9a2da135c76caff11e437dfc40408a6 8275767: JDK source code contains redundant boolean operations in jdk.charsets Reviewed-by: lancea, rriggs, iris ! src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM964.java.template ! src/jdk.charsets/share/classes/sun/nio/cs/ext/SimpleEUCEncoder.java.template Changeset: 4be88d54 Author: Jatin Bhateja Date: 2021-10-26 12:34:56 +0000 URL: https://git.openjdk.java.net/amber/commit/4be88d5482d45e22eb756a6e2ad19ebd7110639a 8275047: Optimize existing fill stubs for AVX-512 target Reviewed-by: kvn, redestad ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/stubRoutines_x86.hpp ! src/hotspot/cpu/x86/vm_version_x86.cpp ! test/micro/org/openjdk/bench/java/util/ArraysFill.java Changeset: 7ca053de Author: Harold Seigel Date: 2021-10-26 12:37:54 +0000 URL: https://git.openjdk.java.net/amber/commit/7ca053de218bf76ea06bbeed860d142db381ca53 8251904: vmTestbase/nsk/sysdict/vm/stress/btree/btree010/btree010.java fails with ClassNotFoundException: nsk.sysdict.share.BTree0LLRLRLRRLR Reviewed-by: dholmes, lmesnik ! test/hotspot/jtreg/vmTestbase/nsk/sysdict/share/BTreeTest.java ! test/hotspot/jtreg/vmTestbase/nsk/sysdict/share/SysDictTest.java Changeset: 71d593ed Author: Coleen Phillimore Date: 2021-10-26 14:33:22 +0000 URL: https://git.openjdk.java.net/amber/commit/71d593ede6e1d0a50798d4ba6bfbd78aa65ae7d8 8275162: Use varargs in 'def' macros in mutexLocker.cpp Reviewed-by: dholmes, pchilanomate ! src/hotspot/share/runtime/mutexLocker.cpp Changeset: b98ed550 Author: Anton Tarasov Date: 2021-10-26 15:23:43 +0000 URL: https://git.openjdk.java.net/amber/commit/b98ed55060b5f3b7832ec28064b04577e3725cc2 8275819: [TableRowAccessibility accessibilityChildren] method is ineffective Reviewed-by: pbansal, kizune ! src/java.desktop/macosx/classes/sun/lwawt/macosx/CAccessibility.java ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableRowAccessibility.m Changeset: c9dec2f9 Author: Andrey Turbanov Committer: Weijun Wang Date: 2021-10-26 15:25:23 +0000 URL: https://git.openjdk.java.net/amber/commit/c9dec2f9849f98048f32ccef4e5573ce21204fbb 8273299: Unnecessary Vector usage in java.security.jgss Reviewed-by: weijun ! src/java.security.jgss/share/classes/sun/security/jgss/GSSCredentialImpl.java ! src/java.security.jgss/share/classes/sun/security/krb5/PrincipalName.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/Authenticator.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/AuthorizationData.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/EncAPRepPart.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/HostAddresses.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/KDCReqBody.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/KRBCred.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/KrbCredInfo.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/LastReq.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/PAData.java ! src/java.security.jgss/share/classes/sun/security/krb5/internal/ccache/FileCredentialsCache.java Changeset: 7c88a59b Author: Anton Tarasov Date: 2021-10-26 15:26:45 +0000 URL: https://git.openjdk.java.net/amber/commit/7c88a59b7bca50061f120a1cf2c1d4457a1d741b 8275809: crash in [CommonComponentAccessibility getCAccessible:withEnv:] Reviewed-by: kizune, pbansal ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m Changeset: 574f8903 Author: Anton Tarasov Date: 2021-10-26 15:47:17 +0000 URL: https://git.openjdk.java.net/amber/commit/574f8903ee1f74bdf7154d670d96c36d94b38b4d 8275720: CommonComponentAccessibility.createWithParent isWrapped causes mem leak Reviewed-by: kizune, pbansal ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CellAccessibility.h ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CellAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.h ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/CommonComponentAccessibility.m + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ComponentWrapperAccessibility.h + src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ComponentWrapperAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ListRowAccessibility.h ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/ListRowAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/OutlineRowAccessibility.m ! src/java.desktop/macosx/native/libawt_lwawt/awt/a11y/TableRowAccessibility.m Changeset: 82f4aacb Author: Roland Westrelin Date: 2021-10-26 15:53:37 +0000 URL: https://git.openjdk.java.net/amber/commit/82f4aacb42e60e9cd00e199703a869e7ad4465ff 8259609: C2: optimize long range checks in long counted loops Co-authored-by: John R Rose Reviewed-by: thartmann, jrose ! src/hotspot/share/opto/addnode.cpp ! src/hotspot/share/opto/loopPredicate.cpp ! src/hotspot/share/opto/loopTransform.cpp ! src/hotspot/share/opto/loopnode.cpp ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/loopopts.cpp ! src/hotspot/share/opto/mulnode.hpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/opto/phaseX.cpp ! src/hotspot/share/opto/subnode.hpp + test/hotspot/jtreg/compiler/c2/irTests/TestLongRangeChecks.java + test/hotspot/jtreg/compiler/rangechecks/TestLongRangeCheck.java + test/hotspot/jtreg/compiler/rangechecks/TestRCMinInt.java Changeset: e5cd2692 Author: Calvin Cheung Date: 2021-10-26 16:26:57 +0000 URL: https://git.openjdk.java.net/amber/commit/e5cd2692da6327c6fde954f86595a08fe5edf43f 8274944: AppCDS dump causes SEGV in VM thread while adjusting lambda proxy class info Reviewed-by: minqi, dholmes ! src/hotspot/share/cds/dynamicArchive.cpp ! src/hotspot/share/cds/metaspaceShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp ! test/hotspot/jtreg/TEST.groups + test/hotspot/jtreg/runtime/cds/appcds/LambdaContainsOldInf.java + test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/LambdaContainsOldInf.java + test/hotspot/jtreg/runtime/cds/appcds/test-classes/LambdaContainsOldInfApp.java + test/hotspot/jtreg/runtime/cds/appcds/test-classes/OldProvider.jasm Changeset: 19f76c21 Author: Andrey Turbanov Committer: Daniel Fuchs Date: 2021-10-26 16:40:55 +0000 URL: https://git.openjdk.java.net/amber/commit/19f76c215dbe9528dde10acd744be54618ea5e4c 8275079: Remove unnecessary conversion to String in java.net.http Reviewed-by: dfuchs ! src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http1AsyncReceiver.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http1Response.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! src/java.net.http/share/classes/jdk/internal/net/http/HttpRequestImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/Demand.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/SSLFlowDelegate.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/SubscriberWrapper.java ! src/java.net.http/share/classes/jdk/internal/net/http/common/Utils.java ! src/java.net.http/share/classes/jdk/internal/net/http/frame/ErrorFrame.java ! src/java.net.http/share/classes/jdk/internal/net/http/frame/Http2Frame.java ! src/java.net.http/share/classes/jdk/internal/net/http/frame/SettingsFrame.java Changeset: f1f5e269 Author: Ji?? Van?k Committer: Magnus Ihse Bursie Date: 2021-10-26 16:54:55 +0000 URL: https://git.openjdk.java.net/amber/commit/f1f5e2690cb93c07eb8be96a4cbfbf140e8a15e0 8275872: Sync J2DBench run and analyze Makefile targets with build.xml Reviewed-by: ihse, andrew ! src/demo/share/java2d/J2DBench/Makefile Changeset: 2448b3f5 Author: Doug Simon Date: 2021-10-26 18:50:21 +0000 URL: https://git.openjdk.java.net/amber/commit/2448b3f5f96ec4d9ea8fe9dae32a0aab725fb4ad 8275874: [JVMCI] only support aligned reads in c2v_readFieldValue Reviewed-by: never, shade ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.hotspot/src/jdk/vm/ci/hotspot/CompilerToVM.java ! src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MemoryAccessProvider.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/MemoryAccessProviderData.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.hotspot.test/src/jdk/vm/ci/hotspot/test/MemoryAccessProviderTest.java Changeset: 7addcd7c Author: Daniel D. Daugherty Date: 2021-10-26 22:03:18 +0000 URL: https://git.openjdk.java.net/amber/commit/7addcd7cfb73652841c65c54e84b6ebffcbd664e 8276034: ProblemList gtest dll_address_to_function_and_library_name on macosx-x64 Reviewed-by: prr ! test/hotspot/gtest/runtime/test_os.cpp Changeset: b0d1e4ff Author: Yi Yang Date: 2021-10-27 01:21:12 +0000 URL: https://git.openjdk.java.net/amber/commit/b0d1e4ff4d3806851fe998717822e8e52987357c 8273585: String.charAt performance degrades due to JDK-8268698 Reviewed-by: roland, kvn ! src/hotspot/share/opto/loopnode.cpp Changeset: d98b7c25 Author: Alexander Zvegintsev Date: 2021-10-27 01:58:11 +0000 URL: https://git.openjdk.java.net/amber/commit/d98b7c25910d38ac644838f59cb41ecd131c87a9 8202926: Test java/awt/Focus/WindowUpdateFocusabilityTest/WindowUpdateFocusabilityTest.html fails Reviewed-by: serb ! test/jdk/ProblemList.txt Changeset: 9f75d5ce Author: Wang Huang Committer: Ningsheng Jian Date: 2021-10-27 05:32:50 +0000 URL: https://git.openjdk.java.net/amber/commit/9f75d5ce500886b32175cc541939b7f0eee190ca 8259948: Aarch64: Add cast nodes for Aarch64 Neon backend Co-authored-by: Wang Huang Co-authored-by: Wu Yan Co-authored-by: Miao Zhuojun Reviewed-by: aph, eliu, njian ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_neon.ad ! src/hotspot/cpu/aarch64/aarch64_neon_ad.m4 ! src/hotspot/cpu/aarch64/assembler_aarch64.hpp ! test/hotspot/gtest/aarch64/aarch64-asmtest.py ! test/hotspot/gtest/aarch64/asmtest.out.h Changeset: 9e831bcc Author: Albert Mingkun Yang Date: 2021-10-27 08:24:44 +0000 URL: https://git.openjdk.java.net/amber/commit/9e831bccd2fc90681b32d1504eca753462afc6f6 8275886: G1: remove obsolete comment in HeapRegion::setup_heap_region_size Reviewed-by: mli, tschatzl ! src/hotspot/share/gc/g1/heapRegion.cpp Changeset: 2f979ecb Author: Jayathirth D V Date: 2021-10-27 09:29:37 +0000 URL: https://git.openjdk.java.net/amber/commit/2f979ecb5b642d04ad280687de76a6ee46818b35 8213120: java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java fails on mac10.13 Reviewed-by: psadhukhan ! test/jdk/ProblemList.txt ! test/jdk/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java Changeset: 6c05cc9d Author: Claes Redestad Date: 2021-10-27 10:07:46 +0000 URL: https://git.openjdk.java.net/amber/commit/6c05cc9d15fb6014b8293a66ef132f3461badca1 8275863: Use encodeASCII for ASCII-compatible DoubleByte encodings Reviewed-by: naoto, rriggs, alanb ! src/java.base/share/classes/module-info.java ! src/java.base/share/classes/sun/nio/cs/DoubleByte.java ! src/java.base/share/classes/sun/nio/cs/HKSCS.java ! src/java.base/share/lib/security/default.policy ! src/jdk.charsets/share/classes/sun/nio/cs/ext/EUC_JP.java.template Changeset: b3f45f86 Author: Jayathirth D V Date: 2021-10-27 10:21:28 +0000 URL: https://git.openjdk.java.net/amber/commit/b3f45f868d9c91d630a118e43cef54cdb3216fd0 8275689: [TESTBUG] Use color tolerance only for XRender in BlitRotateClippedArea test Reviewed-by: serb ! test/jdk/java/awt/image/DrawImage/BlitRotateClippedArea.java Changeset: 485d6586 Author: Prasanta Sadhukhan Date: 2021-10-27 10:24:21 +0000 URL: https://git.openjdk.java.net/amber/commit/485d65865ea8af3f7275e9aa8b75057326486a4d 8275851: Deproblemlist open/test/jdk/javax/swing/JComponent/6683775/bug6683775.java Reviewed-by: serb ! test/jdk/ProblemList.txt ! test/jdk/javax/swing/JComponent/6683775/bug6683775.java Changeset: 40606021 Author: Coleen Phillimore Date: 2021-10-27 12:09:46 +0000 URL: https://git.openjdk.java.net/amber/commit/40606021ee6b7d18674e36b3f6249f1ca8a7647e 8275800: Redefinition leaks MethodData::_extra_data_lock Reviewed-by: sspitsyn, dholmes ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/klass.cpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/prims/jvmtiRedefineClasses.cpp Changeset: a2927333 Author: Tobias Hartmann Date: 2021-10-27 12:27:43 +0000 URL: https://git.openjdk.java.net/amber/commit/a29273336bae75e8d185fa7f7c789acbec50a619 8275975: Remove dead code in ciInstanceKlass Reviewed-by: chagedorn, kvn ! src/hotspot/share/ci/ciArrayKlass.hpp ! src/hotspot/share/ci/ciInstanceKlass.cpp ! src/hotspot/share/ci/ciInstanceKlass.hpp Changeset: 168081ef Author: Naoto Sato Date: 2021-10-27 12:39:46 +0000 URL: https://git.openjdk.java.net/amber/commit/168081efc8af1f5d1d7524246eb4a0675bd49ae0 8270490: Charset.forName() taking fallback default value Reviewed-by: joehw, rriggs, serb, dfuchs ! src/java.base/share/classes/java/io/Console.java ! src/java.base/share/classes/java/nio/charset/Charset.java + test/jdk/java/nio/charset/Charset/ForName.java Changeset: 93be099c Author: Stefan Karlsson Date: 2021-10-27 13:23:24 +0000 URL: https://git.openjdk.java.net/amber/commit/93be099ccb73c88532866ae6d0c288c12a592cc4 4718400: Many quantities are held as signed that should be unsigned Reviewed-by: coleenp, rbackman, dholmes ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/hotspot/share/classfile/javaClasses.inline.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkBitMap.inline.hpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkObjArrayProcessor.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMarkObjArrayProcessor.inline.hpp ! src/hotspot/share/gc/g1/g1RegionMarkStatsCache.cpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp ! src/hotspot/share/gc/g1/heapRegion.inline.hpp ! src/hotspot/share/gc/parallel/parMarkBitMap.hpp ! src/hotspot/share/gc/parallel/parMarkBitMap.inline.hpp ! src/hotspot/share/gc/parallel/psClosure.inline.hpp ! src/hotspot/share/gc/parallel/psParallelCompact.inline.hpp ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/serial/markSweep.hpp ! src/hotspot/share/gc/serial/markSweep.inline.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.cpp ! src/hotspot/share/gc/shared/collectedHeap.hpp ! src/hotspot/share/gc/shared/collectedHeap.inline.hpp ! src/hotspot/share/gc/shared/genCollectedHeap.cpp ! src/hotspot/share/gc/shared/generation.cpp ! src/hotspot/share/gc/shared/memAllocator.cpp ! src/hotspot/share/gc/shared/space.cpp ! src/hotspot/share/gc/shared/space.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.inline.hpp ! src/hotspot/share/gc/z/zCollectedHeap.cpp ! src/hotspot/share/gc/z/zCollectedHeap.hpp ! src/hotspot/share/jfr/leakprofiler/chains/edgeUtils.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.cpp ! src/hotspot/share/memory/heapInspection.hpp ! src/hotspot/share/oops/arrayKlass.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/oops/instanceMirrorKlass.cpp ! src/hotspot/share/oops/instanceMirrorKlass.hpp ! src/hotspot/share/oops/klass.hpp ! src/hotspot/share/oops/objArrayKlass.cpp ! src/hotspot/share/oops/objArrayKlass.hpp ! src/hotspot/share/oops/objArrayOop.hpp ! src/hotspot/share/oops/oop.hpp ! src/hotspot/share/oops/oop.inline.hpp ! src/hotspot/share/oops/typeArrayKlass.cpp ! src/hotspot/share/oops/typeArrayKlass.hpp ! src/hotspot/share/oops/typeArrayOop.hpp ! src/hotspot/share/oops/typeArrayOop.inline.hpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/deoptimization.cpp Changeset: 809488bf Author: Thomas Stuefe Date: 2021-10-27 13:40:51 +0000 URL: https://git.openjdk.java.net/amber/commit/809488bf38c250db3c263f200e5eb1a269059c3d 8276046: codestrings.validate_vm gtest fails on ppc64, s390 Reviewed-by: shade, mdoerr ! test/hotspot/gtest/code/test_codestrings.cpp Changeset: e6fa5fa3 Author: Daniel D. Daugherty Date: 2021-10-27 14:24:02 +0000 URL: https://git.openjdk.java.net/amber/commit/e6fa5fa37e73cd952fb93cc57091775b748ace9a 8276063: ProblemList gtest dll_address_to_function_and_library_name on macosx-generic Reviewed-by: tschatzl ! test/hotspot/gtest/runtime/test_os.cpp Changeset: 9a3e9542 Author: Andrey Turbanov Committer: Naoto Sato Date: 2021-10-27 16:18:12 +0000 URL: https://git.openjdk.java.net/amber/commit/9a3e9542997860de79d07a4411b1007e9cd5c348 8274879: Replace uses of StringBuffer with StringBuilder within java.base classes Reviewed-by: naoto ! src/java.base/share/classes/java/io/FilePermission.java ! src/java.base/share/classes/java/net/SocketPermission.java ! src/java.base/share/classes/java/net/URL.java ! src/java.base/share/classes/java/text/AttributedString.java ! src/java.base/share/classes/java/text/ChoiceFormat.java ! src/java.base/share/classes/java/text/CompactNumberFormat.java ! src/java.base/share/classes/java/text/DecimalFormat.java ! src/java.base/share/classes/java/text/RBTableBuilder.java ! src/java.base/share/classes/sun/security/util/Debug.java ! src/java.base/share/classes/sun/util/calendar/JulianCalendar.java ! src/java.base/share/classes/sun/util/calendar/LocalGregorianCalendar.java Changeset: d9b0138d Author: Thomas Stuefe Date: 2021-10-28 05:29:58 +0000 URL: https://git.openjdk.java.net/amber/commit/d9b0138d7d02ceddc5d9c73908177f0b0d2e7c54 8275704: Metaspace::contains() should be threadsafe Reviewed-by: coleenp, dholmes ! src/hotspot/share/memory/metaspace/virtualSpaceList.cpp ! src/hotspot/share/memory/metaspace/virtualSpaceList.hpp Changeset: 1750a6e2 Author: Per Liden Date: 2021-10-28 05:44:32 +0000 URL: https://git.openjdk.java.net/amber/commit/1750a6e2c06960b734f646018fc99b336bd966a5 8276055: ZGC: Defragment address space Reviewed-by: eosterlund, stefank ! src/hotspot/share/gc/z/zMemory.cpp ! src/hotspot/share/gc/z/zMemory.hpp ! src/hotspot/share/gc/z/zPageAllocator.cpp ! src/hotspot/share/gc/z/zPageAllocator.hpp ! src/hotspot/share/gc/z/zPhysicalMemory.cpp ! src/hotspot/share/gc/z/zVirtualMemory.cpp ! src/hotspot/share/gc/z/zVirtualMemory.hpp ! src/hotspot/share/gc/z/zVirtualMemory.inline.hpp Changeset: a2f2d8fc Author: Aleksey Shipilev Date: 2021-10-28 08:27:44 +0000 URL: https://git.openjdk.java.net/amber/commit/a2f2d8fcf511de2754a76a5d9f9acdfef462919b 8276057: Update JMH devkit to 1.33 Reviewed-by: aph, redestad, erikj ! make/devkit/createJMHBundle.sh Changeset: 593401fe Author: Andrey Turbanov Committer: Aleksei Efimov Date: 2021-10-28 08:42:10 +0000 URL: https://git.openjdk.java.net/amber/commit/593401fe8b38bbb8d331a862818fe077af157fcb 8276042: Remove unused local variables in java.naming Reviewed-by: aefimov, dfuchs, vtewari ! src/java.naming/share/classes/com/sun/jndi/ldap/Filter.java ! src/java.naming/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/java.naming/share/classes/com/sun/jndi/ldap/sasl/SaslOutputStream.java ! src/java.naming/share/classes/com/sun/jndi/toolkit/ctx/Continuation.java ! src/java.naming/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java Changeset: d88b89f8 Author: Per Liden Date: 2021-10-28 10:10:05 +0000 URL: https://git.openjdk.java.net/amber/commit/d88b89f89643dd97092b1debf98e871f873e8f9c 8276067: ZGC: Remove unused function alloc_high_address_at_most() Reviewed-by: eosterlund, stefank ! src/hotspot/share/gc/z/zMemory.cpp ! src/hotspot/share/gc/z/zMemory.hpp Changeset: 7c996d57 Author: Hannes Walln?fer Date: 2021-10-28 10:41:49 +0000 URL: https://git.openjdk.java.net/amber/commit/7c996d572cc10045b7f6bc301916dcbd349b6ef4 8269401: Merge "Exceptions" and "Errors" into "Exception Classes" Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/Contents.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HelpWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/PackageWriterImpl.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/SummaryListWriter.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_ja.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/resources/doclets_zh_CN.properties ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/SummaryAPIListBuilder.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/TypeElementCatalog.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java ! test/langtools/jdk/javadoc/doclet/testDeprecatedDocs/TestDeprecatedDocs.java ! test/langtools/jdk/javadoc/doclet/testHtmlTableTags/TestHtmlTableTags.java ! test/langtools/jdk/javadoc/doclet/testModules/TestModules.java ! test/langtools/jdk/javadoc/doclet/testNewApiList/TestNewApiList.java ! test/langtools/jdk/javadoc/doclet/testSearch/TestSearch.java ! test/langtools/jdk/javadoc/doclet/testSystemPropertyTaglet/TestSystemPropertyTaglet.java ! test/langtools/jdk/javadoc/tool/CheckResourceKeys.java Changeset: bec977c7 Author: Coleen Phillimore Date: 2021-10-28 11:57:21 +0000 URL: https://git.openjdk.java.net/amber/commit/bec977c778a35ea48a45db662f1feaeab79308b2 8275917: Some locks shouldn't allow_vm_block Reviewed-by: dholmes, pchilanomate ! src/hotspot/share/classfile/systemDictionary.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/runtime/mutexLocker.cpp Changeset: a343fa87 Author: Volker Simonis Date: 2021-10-28 12:40:30 +0000 URL: https://git.openjdk.java.net/amber/commit/a343fa8766bb12188881319f06b1d93161cf1619 8275865: Print deoptimization statistics in product builds Reviewed-by: thartmann, kvn ! src/hotspot/share/runtime/java.cpp + test/hotspot/jtreg/runtime/logging/DeoptStats.java Changeset: 85d8cd85 Author: Thomas Schatzl Date: 2021-10-28 12:58:03 +0000 URL: https://git.openjdk.java.net/amber/commit/85d8cd85665d92d67bbc88399baaa8fe7eba14a6 8276100: Remove G1SegmentedArray constructor name parameter Reviewed-by: ayang ! src/hotspot/share/gc/g1/g1CardSetMemory.cpp ! src/hotspot/share/gc/g1/g1SegmentedArray.hpp ! src/hotspot/share/gc/g1/g1SegmentedArray.inline.hpp Changeset: abe52aea Author: Ludvig Janiuk Committer: Jonathan Gibbons Date: 2021-10-28 14:40:53 +0000 URL: https://git.openjdk.java.net/amber/commit/abe52aea23d6025737666dfc2b265fdf1aae14bb 8275518: accessibility issue in Inet6Address docs Reviewed-by: ihse, jjg ! src/java.base/share/classes/java/net/Inet6Address.java Changeset: 309acbf0 Author: Mandy Chung Date: 2021-10-28 15:27:26 +0000 URL: https://git.openjdk.java.net/amber/commit/309acbf0e86a0d248294503fccc7a936fa0a846e 8275703: System.loadLibrary fails on Big Sur for libraries hidden from filesystem Reviewed-by: dholmes, alanb, mcimadamore ! make/test/JtregNativeJdk.gmk ! src/hotspot/share/include/jvm.h ! src/hotspot/share/prims/jvm.cpp ! src/java.base/macosx/classes/jdk/internal/loader/ClassLoaderHelper.java ! src/java.base/share/classes/jdk/internal/loader/NativeLibraries.java ! src/java.base/share/native/libjava/NativeLibraries.c ! src/java.base/unix/classes/jdk/internal/loader/ClassLoaderHelper.java ! src/java.base/windows/classes/jdk/internal/loader/ClassLoaderHelper.java + test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache/LibraryFromCache.java + test/jdk/java/lang/RuntimeTests/loadLibrary/exeLibraryCache/exeLibraryCache.c Changeset: c92f2305 Author: Prasanta Sadhukhan Date: 2021-10-28 15:37:15 +0000 URL: https://git.openjdk.java.net/amber/commit/c92f23055724d2df462f64fc51e57f5a13f679bb 8276110: Problemlist javax/swing/JMenu/4515762/bug4515762.java for macos12 Reviewed-by: azvegint ! test/jdk/ProblemList.txt Changeset: cb989cf3 Author: Andrew Haley Date: 2021-10-28 15:51:29 +0000 URL: https://git.openjdk.java.net/amber/commit/cb989cf3a182ee07fe127b4536e7ff4213f31eaf 8275052: AArch64: Severe AES/GCM slowdown on MacOS for short blocks Reviewed-by: ngasson, adinn ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/os_cpu/bsd_aarch64/vm_version_bsd_aarch64.cpp Changeset: 63b9f8c0 Author: Mitsuru Kariya Committer: Lance Andersen Date: 2021-10-28 15:56:17 +0000 URL: https://git.openjdk.java.net/amber/commit/63b9f8c0da2ed3634002f0f67b18555826aeddc4 8153490: Cannot setBytes() if incoming buffer's length is bigger than number of elements we want to insert. Reviewed-by: lancea ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialBlob.java ! src/java.sql.rowset/share/classes/javax/sql/rowset/serial/SerialClob.java ! test/jdk/javax/sql/testng/test/rowset/serial/SerialBlobTests.java ! test/jdk/javax/sql/testng/test/rowset/serial/SerialClobTests.java Changeset: 6d8fa8f6 Author: Aleksey Shipilev Date: 2021-10-28 17:13:08 +0000 URL: https://git.openjdk.java.net/amber/commit/6d8fa8f6632a78dc79786cb102ba20f6834ad3f4 8255286: Implement ParametersTypeData::print_data_on fully Reviewed-by: dholmes ! src/hotspot/share/oops/methodData.cpp Changeset: 5a768f75 Author: Aleksey Shipilev Date: 2021-10-28 17:32:39 +0000 URL: https://git.openjdk.java.net/amber/commit/5a768f75c9cb013edbf6c61e79820bd180cad4ba 8276054: JMH benchmarks for Fences Reviewed-by: redestad + test/micro/org/openjdk/bench/vm/fences/Multiple.java + test/micro/org/openjdk/bench/vm/fences/MultipleWithLoads.java + test/micro/org/openjdk/bench/vm/fences/MultipleWithStores.java + test/micro/org/openjdk/bench/vm/fences/SafePublishing.java + test/micro/org/openjdk/bench/vm/fences/Single.java Changeset: c6339cb8 Author: Mandy Chung Date: 2021-10-28 18:32:50 +0000 URL: https://git.openjdk.java.net/amber/commit/c6339cb8a255d387bb182ad20dd69f3d460cf1ed 8271820: Implementation of JEP 416: Reimplement Core Reflection with Method Handle 8013527: calling MethodHandles.lookup on itself leads to errors Co-authored-by: Peter Levart Co-authored-by: Claes Redestad Co-authored-by: Mandy Chung Reviewed-by: mcimadamore, plevart, egahlin, redestad, cjplummer, alanb ! make/jdk/src/classes/build/tools/classlist/HelloClasslist.java ! src/hotspot/share/ci/ciField.cpp ! src/java.base/share/classes/java/lang/Class.java ! src/java.base/share/classes/java/lang/ClassLoader.java ! src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleImpl.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleNatives.java ! src/java.base/share/classes/java/lang/invoke/MethodHandles.java ! src/java.base/share/classes/java/lang/reflect/Constructor.java ! src/java.base/share/classes/java/lang/reflect/Field.java ! src/java.base/share/classes/java/lang/reflect/Method.java ! src/java.base/share/classes/jdk/internal/access/JavaLangInvokeAccess.java ! src/java.base/share/classes/jdk/internal/access/SharedSecrets.java ! src/java.base/share/classes/jdk/internal/misc/VM.java + src/java.base/share/classes/jdk/internal/reflect/AccessorUtils.java + src/java.base/share/classes/jdk/internal/reflect/CallerSensitiveAdapter.java + src/java.base/share/classes/jdk/internal/reflect/CsMethodAccessorAdapter.java ! src/java.base/share/classes/jdk/internal/reflect/DelegatingConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/DelegatingMethodAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/DirectConstructorHandleAccessor.java + src/java.base/share/classes/jdk/internal/reflect/DirectMethodHandleAccessor.java ! src/java.base/share/classes/jdk/internal/reflect/FieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/MethodAccessor.java ! src/java.base/share/classes/jdk/internal/reflect/MethodAccessorGenerator.java ! src/java.base/share/classes/jdk/internal/reflect/MethodAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleAccessorFactory.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleBooleanFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleByteFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleCharacterFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleDoubleFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleFloatFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleIntegerFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleLongFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleObjectFieldAccessorImpl.java + src/java.base/share/classes/jdk/internal/reflect/MethodHandleShortFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeConstructorAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/NativeMethodAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java ! src/java.base/share/classes/jdk/internal/reflect/UnsafeFieldAccessorImpl.java ! src/java.base/share/classes/jdk/internal/reflect/UnsafeStaticFieldAccessorImpl.java ! src/java.base/share/native/libjava/NativeAccessors.c ! src/java.logging/share/classes/java/util/logging/Logger.java ! src/java.sql/share/classes/java/sql/DriverManager.java ! test/hotspot/jtreg/ProblemList.txt ! test/hotspot/jtreg/serviceability/dcmd/vm/ShowReflectionTargetTest.java ! test/jdk/com/sun/jdi/EATests.java ! test/jdk/java/lang/StackWalker/DumpStackTest.java ! test/jdk/java/lang/StackWalker/NativeMethod.java ! test/jdk/java/lang/StackWalker/VerifyStackTrace.java + test/jdk/java/lang/StackWalker/libnativeMethod.c + test/jdk/java/lang/invoke/CallerSensitiveMethodHandle.java + test/jdk/java/lang/invoke/MethodHandleInvokeUOE.java = test/jdk/java/lang/invoke/callerSensitive/CallerSensitiveAccess.java + test/jdk/java/lang/invoke/callerSensitive/Main.java + test/jdk/java/lang/invoke/callerSensitive/csm/jdk/test/MethodInvokeTest.java + test/jdk/java/lang/invoke/callerSensitive/csm/module-info.java + test/jdk/java/lang/invoke/callerSensitive/src/java.base/java/util/CSM.java + test/jdk/java/lang/invoke/lookup/ChainedLookupTest.java ! test/jdk/java/lang/invoke/lookup/ReflectiveLookupTest.java ! test/jdk/java/lang/invoke/lookup/java.base/java/lang/LookupTest.java + test/jdk/java/lang/reflect/ChainedReflection.java ! test/jdk/java/lang/reflect/Field/TestFieldReflectValueOf.java + test/jdk/java/lang/reflect/Method/MethodArityLimit.java + test/jdk/java/lang/reflect/MethodHandleAccessorsTest.java + test/jdk/java/lang/reflect/callerCache/CustomLoaderTest.java + test/jdk/java/lang/reflect/callerCache/ReflectTest.java + test/jdk/java/lang/reflect/classInitialization/ExceptionInClassInitialization.java + test/jdk/java/lang/reflect/classInitialization/Initializer.java + test/jdk/java/lang/reflect/classInitialization/Test.java ! test/jdk/jdk/internal/reflect/CallerSensitive/CheckCSMs.java ! test/jdk/jdk/internal/reflect/Reflection/GetCallerClass.java ! test/jdk/jdk/internal/reflect/Reflection/GetCallerClassTest.java ! test/jdk/jdk/jfr/api/consumer/TestHiddenMethod.java ! test/langtools/jdk/jshell/ExceptionsTest.java ! test/micro/org/openjdk/bench/java/lang/reflect/ReflectionColdstartBenchmark.java ! test/micro/org/openjdk/bench/java/lang/reflect/ReflectionSpeedBenchmark.java Changeset: afc0a4b9 Author: duke Date: 2021-10-28 22:01:52 +0000 URL: https://git.openjdk.java.net/amber/commit/afc0a4b9bd1838c01c4ae10d9ee9aa9ba238f53e Automatic merge of master into stats-before-this-super