[amber-docs] RFR: Fixing syntax in example

David Alayachew duke at openjdk.org
Tue Jul 11 12:15:14 UTC 2023


On Tue, 11 Jul 2023 12:09:27 GMT, Gavin Bierman <gbierman at openjdk.org> wrote:

>> Missing a parentheses
>
> I believe I messed up but the change has been made. Sorry about that.
> 
> On 11 Jul 2023, at 13:05, David Alayachew ***@***.***> wrote:
> 
> 
> 
> @GavinBierman<https://urldefense.com/v3/__https://github.com/GavinBierman__;!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlCRkhC_U$> @davidalayachew<https://urldefense.com/v3/__https://github.com/davidalayachew__;!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlEB5DMB8$> Warning! This commit did not result in any changes! No push attempt will be made.
> 
> Does this mean anything, or are we good? I know for a fact that it indeed changed stuff, so I am thinking that this warning is being given in error?
> 
>> Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/openjdk/amber-docs/pull/20*issuecomment-1630702126__;Iw!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlyavvk-k$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABVJVO5C4J7LZYPZ43BVIATXPU6PHANCNFSM6AAAAAA2FGUUNA__;!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlYHOIfAY$>.
> You are receiving this because you were mentioned.Message ID: ***@***.***>

> I believe I messed up but the change has been made. Sorry about that. On 11 Jul 2023, at 13:05, David Alayachew ***@***.***> wrote: @GavinBierman<[https://urldefense.com/v3/__https://github.com/GavinBierman__;!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlCRkhC_U$](https://urldefense.com/v3/__https://github.com/GavinBierman__;!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlCRkhC_U%24)> @davidalayachew<[https://urldefense.com/v3/__https://github.com/davidalayachew__;!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlEB5DMB8$](https://urldefense.com/v3/__https://github.com/davidalayachew__;!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlEB5DMB8%24)> Warning! This commit did not result in any changes! No push attempt will be made. Does this mean anything, or are we good? I k
 now for a fact that it indeed changed stuff, so I am thinking that this warning is being given in error? — Reply to this email directly, view it on GitHub<[https://urldefense.com/v3/__https://github.com/openjdk/amber-docs/pull/20*issuecomment-1630702126__;Iw!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlyavvk-k$](https://urldefense.com/v3/__https://github.com/openjdk/amber-docs/pull/20*issuecomment-1630702126__;Iw!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlyavvk-k%24)>, or unsubscribe<[https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABVJVO5C4J7LZYPZ43BVIATXPU6PHANCNFSM6AAAAAA2FGUUNA__;!!ACWV5N9M2RV99hQ!LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlYHOIfAY$](https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ABVJVO5C4J7LZYPZ43BVIATXPU6PHANCNFSM6AAAAAA2FGUUNA__;!!ACWV5N9M2RV99hQ
 !LdwkA5XaeqAA1JHyj4tq5iCRkRJwFw5KTLk6gMLXoZZOn29_X61rPb_nuo7F2jL7BuHGYyGXmBH76QUfWBOlYHOIfAY%24)>. You are receiving this because you were mentioned.Message ID: ***@***.***>

All good. Let me know if I need to do anything.

-------------

PR Comment: https://git.openjdk.org/amber-docs/pull/20#issuecomment-1630712876


More information about the amber-dev mailing list