<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 20/06/2024 19:54, Archie Cobbs
wrote:<br>
</div>
<blockquote type="cite" cite="mid:CANSoFxvY0-ETuCuZS5RzpDo=+Vi1f+5CdA8QZJmvRgBEKkLV+g@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">On Thu, Jun 20, 2024 at 12:04 PM Maurizio
Cimadamore <<a href="mailto:maurizio.cimadamore@oracle.com" moz-do-not-send="true" class="moz-txt-link-freetext">maurizio.cimadamore@oracle.com</a>>
wrote:</div>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div>
<div>
<p style="margin:0px 0px 1.2em">I think that
this fix, coupled with the translation fixes
I shared last week should implement JEP 482
“as intended”</p>
</div>
</div>
</blockquote>
<div>Awesome, thanks for tackling this! Fyi, I've
merged this patch into my <a href="https://urldefense.com/v3/__https://github.com/openjdk/jdk/compare/master...archiecobbs:jdk:javac-pre-capture-fixes?expand=1__;!!ACWV5N9M2RV99hQ!LNS_Z7ARnFzONoErnZklxoEZgNNqB6Z94YH73CC6lr9bNGs2ity2KjdM20yZjTgLM7aJTjO6MNMN0sLbdJaN4ojJJcfNUQ$" target="_blank" moz-do-not-send="true">javac-pre-capture-fixes</a>
branch (already includes your lambda refactoring).</div>
</div>
</div>
</blockquote>
<p>Let me know if that fixes all the issue we're seeing
(it would be great if we could collect all test cases in
some github repo, so that we can add to them easily).</p>
</div>
</blockquote>
</div>
<div class="gmail_quote">It fixes all the tests I've been
running - these tests are already being collected in the
aforementioned github branch.</div>
<div class="gmail_quote"><br>
</div>
<div class="gmail_quote">And I just added a couple more, so that
now all of the "javac-pre-capture" issues are represented with
tests, and they are all passing.</div>
</div>
</blockquote>
Thanks for checking.<br>
<blockquote type="cite" cite="mid:CANSoFxvY0-ETuCuZS5RzpDo=+Vi1f+5CdA8QZJmvRgBEKkLV+g@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote"><br>
</div>
<div class="gmail_quote">So we're looking good! Let me know how
you'd like to proceed and if I can help in any way.</div>
</div>
</blockquote>
<p>I think we need to start to roll in the patches. I think there's
a dependency between the two translation patches I shared last
week, whereas this latest one seems more independent.</p>
<p>I believe it would probably be best to start from the
LambdaToMethod move, as that's probably the biggest change.<br>
</p>
<blockquote type="cite" cite="mid:CANSoFxvY0-ETuCuZS5RzpDo=+Vi1f+5CdA8QZJmvRgBEKkLV+g@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote"><br>
</div>
<div class="gmail_quote">A few housekeeping notes about the
current "javac-pre-capture" branch:</div>
<div class="gmail_quote">
<ul>
<li>I fixed a typo in your "canRefThis" comment in
Lower.java ("is" → "if")<br>
</li>
</ul>
</div>
</div>
</blockquote>
Thanks<br>
<blockquote type="cite" cite="mid:CANSoFxvY0-ETuCuZS5RzpDo=+Vi1f+5CdA8QZJmvRgBEKkLV+g@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<ul>
<li>The fix for JDK-8334252 (already committed) had the
wrong bug # in the unit test (now fixed - does this need a
separate bug?)</li>
</ul>
</div>
</div>
</blockquote>
Yes, my feeling is that it would be better to file more general bugs
and fix those, and then in the PR say that the fix also fixes the
other bugs we know about (there's a Skara command for that,
"\solves").<br>
<blockquote type="cite" cite="mid:CANSoFxvY0-ETuCuZS5RzpDo=+Vi1f+5CdA8QZJmvRgBEKkLV+g@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">
<ul>
<li>We may want a new error message for the JDK-8322882
error, which e.g. now reports "non-static method
foo(Object) cannot be referenced from a static context"
for the test case even though foo() is a static method.<br>
</li>
</ul>
</div>
</div>
</blockquote>
<p>Yeah, error messages are all equally bad. I think they should be
addressed in a separate and follow up PR from the ones we
discussed.</p>
<p>So, to recap, we need 4 issues:<br>
<br>
1. move LambdaToMethod after Lower<br>
2. fix Lower so that it doesn't include inaccessible enclosing
instances in the this$xyz chain<br>
3. fix the frontend, so that type-checking of instance creation
expression behaves as expected<br>
4. do a final pass on the error messages</p>
<p>Maurizio<br>
</p>
<br>
<blockquote type="cite" cite="mid:CANSoFxvY0-ETuCuZS5RzpDo=+Vi1f+5CdA8QZJmvRgBEKkLV+g@mail.gmail.com">
<div dir="ltr">
<div class="gmail_quote">Thanks, <br>
</div>
<div class="gmail_quote">-Archie<br>
</div>
<div class="gmail_quote"><br>
</div>
<span class="gmail_signature_prefix">-- </span><br>
<div dir="ltr" class="gmail_signature">Archie L. Cobbs<br>
</div>
</div>
</blockquote>
</body>
</html>