Use of "assignment compatible" in the switch statement specifications

[Robbe Pincket]

Hi experts

A while back I was reading the new amber spec on switch pattern matching, and read something that felt off, but after checking the normal spec, I noticed the issue existed there too.
It was late when I sent my review of the amber spec to their group, so I wanted to sent this the day after but I managed to forget it.

In 5.2, the concept of "assignment compatible" is introduced:

> If the type of an expression can be converted to the type of a variable by assignment conversion, we say the expression (or its value) is assignable to the variable or, equivalently, that the type of the expression is assignment compatible with the type of the variable.

It is a useful concept that is used a total of 16 times in the spec for java 18 (and the current 19 spec).

Although this concept is introduced as a relation between two types, in the switch statement specifications (14.11) the following appears:

> 14.11.1 Switch Blocks
> ...
> The switch block of a switch statement or a switch expression is compatible with
the type of the selector expression, T, if both of the following are true:
> * If T is not an enum type, then **every case constant associated with the switch
block is assignment compatible with T (§5.2)**.
> * ...

Here the relation is used between a constant and a type, which seems to be incorrect.

For the Amber experts, this section has been rewritten due to there being more valid possible selector types, but the issue remains:

> A case constant c is switch compatible with a type T where T is either char, byte, short, int, Character, Byte, Short, Integer, or String if c is assignment compatible with T (5.2).


Greetings
Robbe Pincket
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/amber-spec-comments/attachments/20220707/7fceae5a/attachment.htm>