From duke at openjdk.org Mon Aug 12 22:45:53 2024 From: duke at openjdk.org (duke) Date: Mon, 12 Aug 2024 22:45:53 GMT Subject: git: openjdk/apidiff: Initial load Message-ID: <2fae669f-eecd-42ed-be83-224ddbec259c@openjdk.org> Changeset: ce67f025 Branch: master Author: Iris Clark Date: 2024-08-11 21:43:28 +0000 URL: https://git.openjdk.org/apidiff/commit/ce67f025bb1bed05b493eb7492dbeb896efe819e Initial load + .jcheck/conf From jjg at openjdk.org Wed Aug 21 20:28:42 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Wed, 21 Aug 2024 20:28:42 GMT Subject: RFR: 7903798: apidiff: Fix .jcheck/conf setting for tags Message-ID: Please review a change to align apidiff tags with jdk tags ------------- Commit messages: - 7903798: apidiff: Fix .jcheck/conf setting for tags Changes: https://git.openjdk.org/apidiff/pull/1/files Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=1&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903798 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/apidiff/pull/1.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/1/head:pull/1 PR: https://git.openjdk.org/apidiff/pull/1 From iris at openjdk.org Wed Aug 21 20:54:14 2024 From: iris at openjdk.org (Iris Clark) Date: Wed, 21 Aug 2024 20:54:14 GMT Subject: RFR: 7903798: apidiff: Fix .jcheck/conf setting for tags In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 20:24:29 GMT, Jonathan Gibbons wrote: > Please review a change to align apidiff tags with jdk tags Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/apidiff/pull/1#pullrequestreview-2251922770 From iris at openjdk.org Wed Aug 21 21:18:45 2024 From: iris at openjdk.org (Iris Clark) Date: Wed, 21 Aug 2024 21:18:45 GMT Subject: RFR: 7903799: apidiff: add initial code In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 20:54:48 GMT, Jonathan Gibbons wrote: > Please review the initial code for the new apidiff tool. So glad to see this contribution in Code Tools! Thank you! ------------- Marked as reviewed by iris (Reviewer). PR Review: https://git.openjdk.org/apidiff/pull/2#pullrequestreview-2251942168 From jjg at openjdk.org Wed Aug 21 21:18:45 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Wed, 21 Aug 2024 21:18:45 GMT Subject: RFR: 7903799: apidiff: add initial code Message-ID: Please review the initial code for the new apidiff tool. ------------- Commit messages: - fix whitespace - fix COPYRIGHT date - 7903799: apidiff: add initial code Changes: https://git.openjdk.org/apidiff/pull/2/files Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=2&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903799 Stats: 40655 lines in 175 files changed: 40655 ins; 0 del; 0 mod Patch: https://git.openjdk.org/apidiff/pull/2.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/2/head:pull/2 PR: https://git.openjdk.org/apidiff/pull/2 From jjg at openjdk.org Wed Aug 21 21:26:37 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Wed, 21 Aug 2024 21:26:37 GMT Subject: RFR: 7903799: apidiff: add initial code [v2] In-Reply-To: References: Message-ID: > Please review the initial code for the new apidiff tool. Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: fix text about CodeTools project ------------- Changes: - all: https://git.openjdk.org/apidiff/pull/2/files - new: https://git.openjdk.org/apidiff/pull/2/files/9ace4da6..75924761 Webrevs: - full: https://webrevs.openjdk.org/?repo=apidiff&pr=2&range=01 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=2&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/apidiff/pull/2.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/2/head:pull/2 PR: https://git.openjdk.org/apidiff/pull/2 From jjg at openjdk.org Wed Aug 21 21:30:16 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Wed, 21 Aug 2024 21:30:16 GMT Subject: Integrated: 7903798: apidiff: Fix .jcheck/conf setting for tags In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 20:24:29 GMT, Jonathan Gibbons wrote: > Please review a change to align apidiff tags with jdk tags This pull request has now been integrated. Changeset: 60b6ab30 Author: Jonathan Gibbons URL: https://git.openjdk.org/apidiff/commit/60b6ab30fe6c5fa9bdc61c7a7e64622311314420 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 7903798: apidiff: Fix .jcheck/conf setting for tags Reviewed-by: iris ------------- PR: https://git.openjdk.org/apidiff/pull/1 From iris at openjdk.org Thu Aug 22 02:51:13 2024 From: iris at openjdk.org (Iris Clark) Date: Thu, 22 Aug 2024 02:51:13 GMT Subject: RFR: 7903799: apidiff: add initial code [v2] In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 21:26:37 GMT, Jonathan Gibbons wrote: >> Please review the initial code for the new apidiff tool. > > Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: > > fix text about CodeTools project Marked as reviewed by iris (Reviewer). CONTRIBUTING.md line 5: > 3: APIDiff is part of the OpenJDK [CodeTools] Project. > 4: > 5: Please see for how to contribute. openjdk.org. Similar comment for line 8. ------------- PR Review: https://git.openjdk.org/apidiff/pull/2#pullrequestreview-2252794734 PR Review Comment: https://git.openjdk.org/apidiff/pull/2#discussion_r1726121731 From jjg at openjdk.org Thu Aug 22 17:36:40 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Thu, 22 Aug 2024 17:36:40 GMT Subject: RFR: 7903799: apidiff: add initial code [v3] In-Reply-To: References: Message-ID: > Please review the initial code for the new apidiff tool. Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: change `openjdk.java.net` to `openjdk.org` ------------- Changes: - all: https://git.openjdk.org/apidiff/pull/2/files - new: https://git.openjdk.org/apidiff/pull/2/files/75924761..3cd9f85d Webrevs: - full: https://webrevs.openjdk.org/?repo=apidiff&pr=2&range=02 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=2&range=01-02 Stats: 17 lines in 2 files changed: 0 ins; 0 del; 17 mod Patch: https://git.openjdk.org/apidiff/pull/2.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/2/head:pull/2 PR: https://git.openjdk.org/apidiff/pull/2 From jjg at openjdk.org Thu Aug 22 17:36:41 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Thu, 22 Aug 2024 17:36:41 GMT Subject: RFR: 7903799: apidiff: add initial code [v2] In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 01:42:58 GMT, Iris Clark wrote: >> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: >> >> fix text about CodeTools project > > CONTRIBUTING.md line 5: > >> 3: APIDiff is part of the OpenJDK [CodeTools] Project. >> 4: >> 5: Please see for how to contribute. > > openjdk.org. Similar comment for line 8. Fixed ------------- PR Review Comment: https://git.openjdk.org/apidiff/pull/2#discussion_r1727547895 From jjg at openjdk.org Thu Aug 22 17:36:41 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Thu, 22 Aug 2024 17:36:41 GMT Subject: Integrated: 7903799: apidiff: add initial code In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 20:54:48 GMT, Jonathan Gibbons wrote: > Please review the initial code for the new apidiff tool. This pull request has now been integrated. Changeset: 220ad180 Author: Jonathan Gibbons URL: https://git.openjdk.org/apidiff/commit/220ad1807c9c90de4afd41170fbd4a97f37d5640 Stats: 40655 lines in 175 files changed: 40655 ins; 0 del; 0 mod 7903799: apidiff: add initial code Reviewed-by: iris ------------- PR: https://git.openjdk.org/apidiff/pull/2 From jjg at openjdk.org Thu Aug 22 18:13:43 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Thu, 22 Aug 2024 18:13:43 GMT Subject: RFR: 7903800: apidiff: fix test docs and Makefile Message-ID: Please review a trivial fix to address some "TestNG leftovers" from the change to use JUnit ------------- Commit messages: - 7903800: apidiff: fix test docs and Makefile Changes: https://git.openjdk.org/apidiff/pull/3/files Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=3&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903800 Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod Patch: https://git.openjdk.org/apidiff/pull/3.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/3/head:pull/3 PR: https://git.openjdk.org/apidiff/pull/3 From iris at openjdk.org Thu Aug 22 18:49:14 2024 From: iris at openjdk.org (Iris Clark) Date: Thu, 22 Aug 2024 18:49:14 GMT Subject: RFR: 7903800: apidiff: fix test docs and Makefile In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 18:09:34 GMT, Jonathan Gibbons wrote: > Please review a trivial fix to address some "TestNG leftovers" from the change to use JUnit Marked as reviewed by iris (Reviewer). ------------- PR Review: https://git.openjdk.org/apidiff/pull/3#pullrequestreview-2255405493 From jjg at openjdk.org Thu Aug 22 18:57:14 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Thu, 22 Aug 2024 18:57:14 GMT Subject: Integrated: 7903800: apidiff: fix test docs and Makefile In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 18:09:34 GMT, Jonathan Gibbons wrote: > Please review a trivial fix to address some "TestNG leftovers" from the change to use JUnit This pull request has now been integrated. Changeset: f73e256e Author: Jonathan Gibbons URL: https://git.openjdk.org/apidiff/commit/f73e256ef56462b6c23748736fc012a4015fee31 Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod 7903800: apidiff: fix test docs and Makefile Reviewed-by: iris ------------- PR: https://git.openjdk.org/apidiff/pull/3 From jjg at openjdk.org Fri Aug 23 19:05:43 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Fri, 23 Aug 2024 19:05:43 GMT Subject: RFR: 7903802: apidiff: minor doc and related updates Message-ID: <4gE1zf_B8ztdC2pTXZUKXsgG6nE9DROu90oUDI-gRoQ=.0736f889-e3f2-4ff2-8987-a96128e4b208@github.com> Please review some minor doc changes for apidiff ------------- Commit messages: - 7903802: apidiff: minor doc and related updates Changes: https://git.openjdk.org/apidiff/pull/4/files Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=4&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903802 Stats: 18 lines in 2 files changed: 2 ins; 4 del; 12 mod Patch: https://git.openjdk.org/apidiff/pull/4.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/4/head:pull/4 PR: https://git.openjdk.org/apidiff/pull/4 From iris at openjdk.org Fri Aug 23 19:16:15 2024 From: iris at openjdk.org (Iris Clark) Date: Fri, 23 Aug 2024 19:16:15 GMT Subject: RFR: 7903802: apidiff: minor doc and related updates In-Reply-To: <4gE1zf_B8ztdC2pTXZUKXsgG6nE9DROu90oUDI-gRoQ=.0736f889-e3f2-4ff2-8987-a96128e4b208@github.com> References: <4gE1zf_B8ztdC2pTXZUKXsgG6nE9DROu90oUDI-gRoQ=.0736f889-e3f2-4ff2-8987-a96128e4b208@github.com> Message-ID: On Fri, 23 Aug 2024 19:01:12 GMT, Jonathan Gibbons wrote: > Please review some minor doc changes for apidiff Marked as reviewed by iris (Reviewer). src/share/doc/apidiff.md line 26: > 24: > 25: title: 'APIDIFF(1) 1.0 | CodeTools' > 26: date: 2024 Suggest you update the copyright year on line 3 too. ------------- PR Review: https://git.openjdk.org/apidiff/pull/4#pullrequestreview-2257946296 PR Review Comment: https://git.openjdk.org/apidiff/pull/4#discussion_r1729414827 From jjg at openjdk.org Fri Aug 23 22:58:30 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Fri, 23 Aug 2024 22:58:30 GMT Subject: RFR: 7903802: apidiff: minor doc and related updates In-Reply-To: References: <4gE1zf_B8ztdC2pTXZUKXsgG6nE9DROu90oUDI-gRoQ=.0736f889-e3f2-4ff2-8987-a96128e4b208@github.com> Message-ID: On Fri, 23 Aug 2024 19:13:36 GMT, Iris Clark wrote: >> Please review some minor doc changes for apidiff > > src/share/doc/apidiff.md line 26: > >> 24: >> 25: title: 'APIDIFF(1) 1.0 | CodeTools' >> 26: date: 2024 > > Suggest you update the copyright year on line 3 too. Thank you; will do. ------------- PR Review Comment: https://git.openjdk.org/apidiff/pull/4#discussion_r1729586111 From jjg at openjdk.org Mon Aug 26 17:59:57 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Mon, 26 Aug 2024 17:59:57 GMT Subject: RFR: 7903802: apidiff: minor doc and related updates [v2] In-Reply-To: <4gE1zf_B8ztdC2pTXZUKXsgG6nE9DROu90oUDI-gRoQ=.0736f889-e3f2-4ff2-8987-a96128e4b208@github.com> References: <4gE1zf_B8ztdC2pTXZUKXsgG6nE9DROu90oUDI-gRoQ=.0736f889-e3f2-4ff2-8987-a96128e4b208@github.com> Message-ID: > Please review some minor doc changes for apidiff Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision: update copyright year ------------- Changes: - all: https://git.openjdk.org/apidiff/pull/4/files - new: https://git.openjdk.org/apidiff/pull/4/files/6b530694..a01c7502 Webrevs: - full: https://webrevs.openjdk.org/?repo=apidiff&pr=4&range=01 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=4&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/apidiff/pull/4.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/4/head:pull/4 PR: https://git.openjdk.org/apidiff/pull/4 From jjg at openjdk.org Mon Aug 26 17:59:58 2024 From: jjg at openjdk.org (Jonathan Gibbons) Date: Mon, 26 Aug 2024 17:59:58 GMT Subject: Integrated: 7903802: apidiff: minor doc and related updates In-Reply-To: <4gE1zf_B8ztdC2pTXZUKXsgG6nE9DROu90oUDI-gRoQ=.0736f889-e3f2-4ff2-8987-a96128e4b208@github.com> References: <4gE1zf_B8ztdC2pTXZUKXsgG6nE9DROu90oUDI-gRoQ=.0736f889-e3f2-4ff2-8987-a96128e4b208@github.com> Message-ID: On Fri, 23 Aug 2024 19:01:12 GMT, Jonathan Gibbons wrote: > Please review some minor doc changes for apidiff This pull request has now been integrated. Changeset: 5783eede Author: Jonathan Gibbons URL: https://git.openjdk.org/apidiff/commit/5783eede351433dafb15c41ae7ad2597e4f97099 Stats: 19 lines in 2 files changed: 2 ins; 4 del; 13 mod 7903802: apidiff: minor doc and related updates Reviewed-by: iris ------------- PR: https://git.openjdk.org/apidiff/pull/4