RFR: 7903852: apidiff: IllegalArgumentException for RECORD_COMPONENT

Pavel Rappo prappo at openjdk.org
Tue Oct 1 18:28:50 UTC 2024


On Tue, 1 Oct 2024 18:16:42 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> > Does this PR simply improves the exception message?
> 
> No. In `RecordComponentComparator` it no longer calls the method that throws the exception. There's actually no change in the exception message; the edits in the visitor are somewhat cosmetic, to improve the stack trace (!!) and to provide a place for a more specific explanatory comment.

Right, I see the problematic method has been removed:

        allEqual &= compareDocComments(rcPos, rcMap);
     -> allEqual &= compareApiDescriptions(rcPos, rcMap);

-------------

PR Comment: https://git.openjdk.org/apidiff/pull/20#issuecomment-2386677730


More information about the apidiff-dev mailing list