From jjg at openjdk.org  Wed Sep 18 19:46:26 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 18 Sep 2024 19:46:26 GMT
Subject: RFR: 7903822: Add toString for some internal types
Message-ID: <y0MgBHjpkFcQsGZK341kkKKpmT5H0VgRgkM9NPwKyNc=.0f321d36-607c-470a-ab25-c38791db1577@github.com>

Please review a trivial update to add a useful definition of `.toString()` for some internal classes.

-------------

Commit messages:
 - CODETOOLS-7903822: Add toString for some internal types

Changes: https://git.openjdk.org/apidiff/pull/5/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=5&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903822
  Stats: 13 lines in 2 files changed: 13 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/apidiff/pull/5.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/5/head:pull/5

PR: https://git.openjdk.org/apidiff/pull/5

From iris at openjdk.org  Wed Sep 18 20:25:17 2024
From: iris at openjdk.org (Iris Clark)
Date: Wed, 18 Sep 2024 20:25:17 GMT
Subject: RFR: 7903822: Add toString for some internal types
In-Reply-To: <y0MgBHjpkFcQsGZK341kkKKpmT5H0VgRgkM9NPwKyNc=.0f321d36-607c-470a-ab25-c38791db1577@github.com>
References: <y0MgBHjpkFcQsGZK341kkKKpmT5H0VgRgkM9NPwKyNc=.0f321d36-607c-470a-ab25-c38791db1577@github.com>
Message-ID: <YPjm_wdQxURV9JsJrMp3AWa_SPSO7_vj7C7gi9BoRPM=.7b0294bd-e891-4dd4-b737-83a214977da9@github.com>

On Wed, 18 Sep 2024 19:41:41 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial update to add a useful definition of `.toString()` for some internal classes.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/5#pullrequestreview-2313710226

From jjg at openjdk.org  Wed Sep 18 20:40:47 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 18 Sep 2024 20:40:47 GMT
Subject: RFR: 7903823: Use correct key when building display of method return
 types
Message-ID: <cqJW6B0Pt7tPU3u6-mSv8pYYH-_UwFa843PgBtcXpXk=.2d4a9c2f-a063-4c99-99c5-94258420793e@github.com>

Please review a simple fix to use the correct position-key to identify the different return types of a method.

-------------

Commit messages:
 - CODETOOLS-7903823

Changes: https://git.openjdk.org/apidiff/pull/6/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=6&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903823
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/apidiff/pull/6.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/6/head:pull/6

PR: https://git.openjdk.org/apidiff/pull/6

From iris at openjdk.org  Wed Sep 18 20:45:46 2024
From: iris at openjdk.org (Iris Clark)
Date: Wed, 18 Sep 2024 20:45:46 GMT
Subject: RFR: 7903823: Use correct key when building display of method
 return types
In-Reply-To: <cqJW6B0Pt7tPU3u6-mSv8pYYH-_UwFa843PgBtcXpXk=.2d4a9c2f-a063-4c99-99c5-94258420793e@github.com>
References: <cqJW6B0Pt7tPU3u6-mSv8pYYH-_UwFa843PgBtcXpXk=.2d4a9c2f-a063-4c99-99c5-94258420793e@github.com>
Message-ID: <-Zvwf4b_N9a3NJaPIc3gCdomfHt-_Ix2kYtDvdiBBao=.fe5fd61b-91ee-434a-bedd-fa23de6b87ac@github.com>

On Wed, 18 Sep 2024 20:27:48 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple fix to use the correct position-key to identify the different return types of a method.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/6#pullrequestreview-2313762610

From jjg at openjdk.org  Wed Sep 18 20:57:47 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 18 Sep 2024 20:57:47 GMT
Subject: Integrated: 7903823: Use correct key when building display of method
 return types
In-Reply-To: <cqJW6B0Pt7tPU3u6-mSv8pYYH-_UwFa843PgBtcXpXk=.2d4a9c2f-a063-4c99-99c5-94258420793e@github.com>
References: <cqJW6B0Pt7tPU3u6-mSv8pYYH-_UwFa843PgBtcXpXk=.2d4a9c2f-a063-4c99-99c5-94258420793e@github.com>
Message-ID: <9ENWbW7Ct8a_ektCiNhc5l8AY4g2CESuM0GzNbuxipw=.92ee4e29-8103-4a1c-9d37-1cf6f62793a2@github.com>

On Wed, 18 Sep 2024 20:27:48 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple fix to use the correct position-key to identify the different return types of a method.

This pull request has now been integrated.

Changeset: 7a1dfd2a
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/7a1dfd2ac8581126fd66092df215bb20af3716fb
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7903823: Use correct key when building display of method return types

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/apidiff/pull/6

From jjg at openjdk.org  Wed Sep 18 21:02:50 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 18 Sep 2024 21:02:50 GMT
Subject: Integrated: 7903822: Add toString for some internal types
In-Reply-To: <y0MgBHjpkFcQsGZK341kkKKpmT5H0VgRgkM9NPwKyNc=.0f321d36-607c-470a-ab25-c38791db1577@github.com>
References: <y0MgBHjpkFcQsGZK341kkKKpmT5H0VgRgkM9NPwKyNc=.0f321d36-607c-470a-ab25-c38791db1577@github.com>
Message-ID: <rm1iyXm3FUfUAP61Tcwo48-2Kvm2No4F5JyfnX2fYEY=.01e4686d-e744-4e6e-88d5-52004bc002cb@github.com>

On Wed, 18 Sep 2024 19:41:41 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial update to add a useful definition of `.toString()` for some internal classes.

This pull request has now been integrated.

Changeset: f2455f44
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/f2455f44d3e927aac415bf927d2cec2f85f588f8
Stats:     13 lines in 2 files changed: 13 ins; 0 del; 0 mod

7903822: Add toString for some internal types

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/apidiff/pull/5

From jjg at openjdk.org  Tue Sep 24 21:45:16 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Tue, 24 Sep 2024 21:45:16 GMT
Subject: RFR: 7903829: apidiff: update TestNG reference to JUnit
Message-ID: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>

Please review some simple doc fixes to README files.

-------------

Commit messages:
 - CODETOOLS-7903829: apidiff: update TestNG reference to JUnit

Changes: https://git.openjdk.org/apidiff/pull/7/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=7&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903829
  Stats: 19 lines in 2 files changed: 3 ins; 0 del; 16 mod
  Patch: https://git.openjdk.org/apidiff/pull/7.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/7/head:pull/7

PR: https://git.openjdk.org/apidiff/pull/7

From iris at openjdk.org  Tue Sep 24 23:52:53 2024
From: iris at openjdk.org (Iris Clark)
Date: Tue, 24 Sep 2024 23:52:53 GMT
Subject: RFR: 7903829: apidiff: update TestNG reference to JUnit
In-Reply-To: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>
References: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>
Message-ID: <Wdmkf-UVUM4NwU71GxE5wQi9bPz6qyoZygxtvaW1LsU=.0dd166f1-89cc-4d41-bfdb-1d0751f55e57@github.com>

On Tue, 24 Sep 2024 21:41:17 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some simple doc fixes to README files.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/7#pullrequestreview-2326707958

From cstein at openjdk.org  Wed Sep 25 05:13:46 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 05:13:46 GMT
Subject: RFR: 7903829: apidiff: update TestNG reference to JUnit
In-Reply-To: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>
References: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>
Message-ID: <0W_XAvg1XfHYtbWowQC_UJN-8VmxJesnOzI5GZburOI=.6b20145b-8d2a-4323-86d2-ef5949859af8@github.com>

On Tue, 24 Sep 2024 21:41:17 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some simple doc fixes to README files.

?

-------------

Marked as reviewed by cstein (Committer).

PR Review: https://git.openjdk.org/apidiff/pull/7#pullrequestreview-2327083007

From jjg at openjdk.org  Wed Sep 25 15:17:50 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 15:17:50 GMT
Subject: RFR: 7903829: apidiff: update TestNG reference to JUnit
In-Reply-To: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>
References: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>
Message-ID: <uOcY2pxdCdPCDmwD9fqFuNqMMt2mO7uZ_tKdNPkmX18=.1a272fd5-870f-4bf0-a386-5ac4a1db22b3@github.com>

On Tue, 24 Sep 2024 21:41:17 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some simple doc fixes to README files.

/integrate\

-------------

PR Comment: https://git.openjdk.org/apidiff/pull/7#issuecomment-2374387315

From jjg at openjdk.org  Wed Sep 25 15:33:52 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 15:33:52 GMT
Subject: Integrated: 7903829: apidiff: update TestNG reference to JUnit
In-Reply-To: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>
References: <XmFCkQqdZt_H0ZNIBi7DfLR8cyUoT3pOt3Dy1XCI6IM=.b89c35d4-6057-46d7-8e58-cb3e8f453110@github.com>
Message-ID: <cyz2KVrqSZ3bqCze3V7gYg7IV9cZ11HasczJb2DR0SA=.049c0a8e-03cc-4843-a346-3ef089adfbdf@github.com>

On Tue, 24 Sep 2024 21:41:17 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review some simple doc fixes to README files.

This pull request has now been integrated.

Changeset: b8685aee
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/b8685aee0aaee16e7d728c974c61ebc68670cc1d
Stats:     19 lines in 2 files changed: 3 ins; 0 del; 16 mod

7903829: apidiff: update TestNG reference to JUnit

Reviewed-by: iris, cstein

-------------

PR: https://git.openjdk.org/apidiff/pull/7

From jjg at openjdk.org  Wed Sep 25 15:49:17 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 15:49:17 GMT
Subject: RFR: 7903834: apidiff: DocPath issue on Windows
Message-ID: <vgRMspAof3-lRSZwXbd13PYD9wuP4liEZbFZw-nGEYI=.f362783c-6613-4ef6-96d3-a7386f7f04d4@github.com>

Please review a small fix to correctly handle Windows paths.

-------------

Commit messages:
 - CODETOOLS-7903834: apidiff: DocPath issue on Windows

Changes: https://git.openjdk.org/apidiff/pull/8/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=8&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903834
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/apidiff/pull/8.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/8/head:pull/8

PR: https://git.openjdk.org/apidiff/pull/8

From cstein at openjdk.org  Wed Sep 25 15:49:17 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 15:49:17 GMT
Subject: RFR: 7903834: apidiff: DocPath issue on Windows
In-Reply-To: <vgRMspAof3-lRSZwXbd13PYD9wuP4liEZbFZw-nGEYI=.f362783c-6613-4ef6-96d3-a7386f7f04d4@github.com>
References: <vgRMspAof3-lRSZwXbd13PYD9wuP4liEZbFZw-nGEYI=.f362783c-6613-4ef6-96d3-a7386f7f04d4@github.com>
Message-ID: <YaRjR0iN84NU60r5qXS9_E9WyEWehSzPULwBzClcUpo=.0c07239c-5dcb-4eac-92aa-a11ea9a0e28a@github.com>

On Wed, 25 Sep 2024 15:43:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small fix to correctly handle Windows paths.

? users are happy now

-------------

Marked as reviewed by cstein (Committer).

PR Review: https://git.openjdk.org/apidiff/pull/8#pullrequestreview-2328688038

From jjg at openjdk.org  Wed Sep 25 16:09:05 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 16:09:05 GMT
Subject: RFR: ODETOOLS-7903835: apidiff: CompareOptionsTest fails on recent JDK
Message-ID: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>

Please review a simple fix to not include line numbers in the reference output for this test. The underlying javadoc output has changed, so the line numbers in the diff have also changed.

-------------

Commit messages:
 - ODETOOLS-7903835: apidiff: CompareOptionsTest fails on recent JDK

Changes: https://git.openjdk.org/apidiff/pull/10/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=10&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903835
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/apidiff/pull/10.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/10/head:pull/10

PR: https://git.openjdk.org/apidiff/pull/10

From cstein at openjdk.org  Wed Sep 25 16:11:05 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 16:11:05 GMT
Subject: RFR: 7903836: Add GitHub Actions test workflow
Message-ID: <TMShCPJNDSV7JQX5C47RF364TqIThOMy35iJJJ58tp0=.ef3d5328-3cef-4b0b-bfa1-bf6664c6cdc4@github.com>

Please review this test workflow for building ApiDiff on every pull request.

-------------

Commit messages:
 - Add GitHub Actions test workflow

Changes: https://git.openjdk.org/apidiff/pull/9/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=9&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903836
  Stats: 30 lines in 1 file changed: 30 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/apidiff/pull/9.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/9/head:pull/9

PR: https://git.openjdk.org/apidiff/pull/9

From jjg at openjdk.org  Wed Sep 25 16:19:55 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 16:19:55 GMT
Subject: RFR: 7903836: apidiff: Add GitHub Actions test workflow
In-Reply-To: <TMShCPJNDSV7JQX5C47RF364TqIThOMy35iJJJ58tp0=.ef3d5328-3cef-4b0b-bfa1-bf6664c6cdc4@github.com>
References: <TMShCPJNDSV7JQX5C47RF364TqIThOMy35iJJJ58tp0=.ef3d5328-3cef-4b0b-bfa1-bf6664c6cdc4@github.com>
Message-ID: <xBTzpXs8I6S7ZR1En3a8OnIeB1XxkvfkUo-6Ca07J-Y=.2a2d89c1-f3a5-4818-8be0-189ec05ccdc9@github.com>

On Wed, 25 Sep 2024 15:56:16 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this test workflow for building ApiDiff on every pull request.

"Provisional" approval, to enable the workflow

-------------

Marked as reviewed by jjg (Reviewer).

PR Review: https://git.openjdk.org/apidiff/pull/9#pullrequestreview-2328775629

From cstein at openjdk.org  Wed Sep 25 16:26:48 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 16:26:48 GMT
Subject: Integrated: 7903836: apidiff: Add GitHub Actions test workflow
In-Reply-To: <TMShCPJNDSV7JQX5C47RF364TqIThOMy35iJJJ58tp0=.ef3d5328-3cef-4b0b-bfa1-bf6664c6cdc4@github.com>
References: <TMShCPJNDSV7JQX5C47RF364TqIThOMy35iJJJ58tp0=.ef3d5328-3cef-4b0b-bfa1-bf6664c6cdc4@github.com>
Message-ID: <DkVTQLEYw-v0S5v2dYn5Ac-PiXYGQ9tZAwCsqXlYwB8=.ac174c1c-f167-430f-9678-9cf01580fcd9@github.com>

On Wed, 25 Sep 2024 15:56:16 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this test workflow for building ApiDiff on every pull request.

This pull request has now been integrated.

Changeset: a1bacee7
Author:    Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/a1bacee742b6ed7813a29acc23b8b843e472dce6
Stats:     30 lines in 1 file changed: 30 ins; 0 del; 0 mod

7903836: apidiff: Add GitHub Actions test workflow

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/apidiff/pull/9

From cstein at openjdk.org  Wed Sep 25 16:45:21 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 16:45:21 GMT
Subject: Integrated: 7903836: apidiff: Add GitHub Actions test workflow
Message-ID: <aWt1tzS-qiA_udeqQd5nxIiPAgOyJTpLVsXzVmai7HU=.e12333a1-e023-45f5-8024-94fafc005168@github.com>

Please review this follow-up change to use the correct directory name for `workflows`.

-------------

Commit messages:
 - Fix directory name

Changes: https://git.openjdk.org/apidiff/pull/11/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=11&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903836
  Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/apidiff/pull/11.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/11/head:pull/11

PR: https://git.openjdk.org/apidiff/pull/11

From jjg at openjdk.org  Wed Sep 25 16:45:21 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 16:45:21 GMT
Subject: Integrated: 7903836: apidiff: Add GitHub Actions test workflow
In-Reply-To: <aWt1tzS-qiA_udeqQd5nxIiPAgOyJTpLVsXzVmai7HU=.e12333a1-e023-45f5-8024-94fafc005168@github.com>
References: <aWt1tzS-qiA_udeqQd5nxIiPAgOyJTpLVsXzVmai7HU=.e12333a1-e023-45f5-8024-94fafc005168@github.com>
Message-ID: <tg34sEDlvBRpOX2ey9HbYe-jpiQoT13YCwBAe3RprLY=.c05d09d6-3646-453c-ae14-298dd5c180f9@github.com>

On Wed, 25 Sep 2024 16:37:53 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this follow-up change to use the correct directory name for `workflows`.

Marked as reviewed by jjg (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/11#pullrequestreview-2328859098

From cstein at openjdk.org  Wed Sep 25 16:45:21 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 16:45:21 GMT
Subject: Integrated: 7903836: apidiff: Add GitHub Actions test workflow
In-Reply-To: <aWt1tzS-qiA_udeqQd5nxIiPAgOyJTpLVsXzVmai7HU=.e12333a1-e023-45f5-8024-94fafc005168@github.com>
References: <aWt1tzS-qiA_udeqQd5nxIiPAgOyJTpLVsXzVmai7HU=.e12333a1-e023-45f5-8024-94fafc005168@github.com>
Message-ID: <NcSpkZ9VBKZM7THqoHSE1l3Rpk0_SUrG9gME2MoWDqU=.a9c12f51-cafb-45b3-a2b4-223266780f2c@github.com>

On Wed, 25 Sep 2024 16:37:53 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this follow-up change to use the correct directory name for `workflows`.

This pull request has now been integrated.

Changeset: a10e1426
Author:    Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/a10e1426e21978b522d93e1406731240197c2d37
Stats:     0 lines in 1 file changed: 0 ins; 0 del; 0 mod

7903836: apidiff: Add GitHub Actions test workflow

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/apidiff/pull/11

From iris at openjdk.org  Wed Sep 25 17:01:48 2024
From: iris at openjdk.org (Iris Clark)
Date: Wed, 25 Sep 2024 17:01:48 GMT
Subject: RFR: ODETOOLS-7903835: apidiff: CompareOptionsTest fails on recent
 JDK
In-Reply-To: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>
References: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>
Message-ID: <at-4Xbgr-RYSXEEGc2eiF7jqcAQspRlvPQQRwvFFx-c=.a842cc5e-5ff0-41de-8644-5e8d93b80683@github.com>

On Wed, 25 Sep 2024 16:05:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple fix to not include line numbers in the reference output for this test. The underlying javadoc output has changed, so the line numbers in the diff have also changed.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/10#pullrequestreview-2328929405

From iris at openjdk.org  Wed Sep 25 17:02:51 2024
From: iris at openjdk.org (Iris Clark)
Date: Wed, 25 Sep 2024 17:02:51 GMT
Subject: RFR: 7903834: apidiff: DocPath issue on Windows
In-Reply-To: <vgRMspAof3-lRSZwXbd13PYD9wuP4liEZbFZw-nGEYI=.f362783c-6613-4ef6-96d3-a7386f7f04d4@github.com>
References: <vgRMspAof3-lRSZwXbd13PYD9wuP4liEZbFZw-nGEYI=.f362783c-6613-4ef6-96d3-a7386f7f04d4@github.com>
Message-ID: <jCcoISF4AVRLmzOmOFVbTIhBsgGvJXE5gZZy6rD3Ggg=.b75a4656-2f65-4451-ba06-f4dd6e3e535c@github.com>

On Wed, 25 Sep 2024 15:43:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small fix to correctly handle Windows paths.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/8#pullrequestreview-2328930747

From jjg at openjdk.org  Wed Sep 25 17:57:15 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 17:57:15 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows
Message-ID: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>

Please review some `build.sh` and `Makefile` changes to address issues building on Windows.

The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.

This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?

-------------

Commit messages:
 - CODETOOLS-7903837: apidiff: build.sh issues on Windows

Changes: https://git.openjdk.org/apidiff/pull/12/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=12&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903837
  Stats: 33 lines in 3 files changed: 13 ins; 3 del; 17 mod
  Patch: https://git.openjdk.org/apidiff/pull/12.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/12/head:pull/12

PR: https://git.openjdk.org/apidiff/pull/12

From jjg at openjdk.org  Wed Sep 25 19:21:20 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 19:21:20 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows [v2]
In-Reply-To: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
References: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
Message-ID: <AVjJoNC5eq4DxlTQdWEe4seBJp6WRDfgNJxgZXs7-Wc=.8de5fd1f-fd53-4ad2-afa6-02077b0d366b@github.com>

> Please review some `build.sh` and `Makefile` changes to address issues building on Windows.
> 
> The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
> There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.
> 
> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  address review feedback

-------------

Changes:
  - all: https://git.openjdk.org/apidiff/pull/12/files
  - new: https://git.openjdk.org/apidiff/pull/12/files/61a3c05c..25765982

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=apidiff&pr=12&range=01
 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=12&range=00-01

  Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/apidiff/pull/12.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/12/head:pull/12

PR: https://git.openjdk.org/apidiff/pull/12

From cstein at openjdk.org  Wed Sep 25 19:21:20 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 19:21:20 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows
In-Reply-To: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
References: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
Message-ID: <Bhxl1trwJWbPIolcQE48psdKZHISn4_lq3hp4LXUlQ8=.bcc22935-59ce-4197-ab1b-f0ac6836e4f2@github.com>

On Wed, 25 Sep 2024 17:51:53 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?

On it. An empty classpath element results in a `::` sequence, which seems to make MSYS2/Cygwin fail the build.

-------------

PR Comment: https://git.openjdk.org/apidiff/pull/12#issuecomment-2375017112

From cstein at openjdk.org  Wed Sep 25 19:23:48 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 19:23:48 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows [v2]
In-Reply-To: <AVjJoNC5eq4DxlTQdWEe4seBJp6WRDfgNJxgZXs7-Wc=.8de5fd1f-fd53-4ad2-afa6-02077b0d366b@github.com>
References: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
 <AVjJoNC5eq4DxlTQdWEe4seBJp6WRDfgNJxgZXs7-Wc=.8de5fd1f-fd53-4ad2-afa6-02077b0d366b@github.com>
Message-ID: <8Dyt_eFVZkDzuLNa0OvjtMRS_Thh0KapWxWcM05FAyA=.3b21b51e-04d9-4daa-bd4c-758b5df0ae09@github.com>

On Wed, 25 Sep 2024 19:21:20 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review some `build.sh` and `Makefile` changes to address issues building on Windows.
>> 
>> The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
>> There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.
>> 
>> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address review feedback

Marked as reviewed by cstein (Committer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/12#pullrequestreview-2329335838

From cstein at openjdk.org  Wed Sep 25 19:30:47 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 19:30:47 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows [v2]
In-Reply-To: <AVjJoNC5eq4DxlTQdWEe4seBJp6WRDfgNJxgZXs7-Wc=.8de5fd1f-fd53-4ad2-afa6-02077b0d366b@github.com>
References: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
 <AVjJoNC5eq4DxlTQdWEe4seBJp6WRDfgNJxgZXs7-Wc=.8de5fd1f-fd53-4ad2-afa6-02077b0d366b@github.com>
Message-ID: <vSSyYtx6alSyujSgcGgDdK_p7Vzn8X70TkBggyvWJdg=.cf3fc1ff-62df-4374-954b-fabe65406bdb@github.com>

On Wed, 25 Sep 2024 19:21:20 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review some `build.sh` and `Makefile` changes to address issues building on Windows.
>> 
>> The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
>> There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.
>> 
>> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address review feedback

https://github.com/openjdk/apidiff/blob/a10e1426e21978b522d93e1406731240197c2d37/test/junit/JUnitTests.gmk#L33 also needs some extra care to not pass an empty `$(DAISYDIFF_JAR)` element.

-------------

Changes requested by cstein (Committer).

PR Review: https://git.openjdk.org/apidiff/pull/12#pullrequestreview-2329364618

From jjg at openjdk.org  Wed Sep 25 19:52:23 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 19:52:23 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows [v3]
In-Reply-To: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
References: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
Message-ID: <mYbkStgCsaptje-AhBJyCnAHOABmFIAOHgBYPfHYFdk=.a9aae2bd-8a90-4e1a-b302-4801ac177a9d@github.com>

> Please review some `build.sh` and `Makefile` changes to address issues building on Windows.
> 
> The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
> There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.
> 
> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  fix test classpath when DAISYDIFF_JAR is empty (for Windows)

-------------

Changes:
  - all: https://git.openjdk.org/apidiff/pull/12/files
  - new: https://git.openjdk.org/apidiff/pull/12/files/25765982..afc38f77

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=apidiff&pr=12&range=02
 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=12&range=01-02

  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/apidiff/pull/12.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/12/head:pull/12

PR: https://git.openjdk.org/apidiff/pull/12

From cstein at openjdk.org  Wed Sep 25 19:52:23 2024
From: cstein at openjdk.org (Christian Stein)
Date: Wed, 25 Sep 2024 19:52:23 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows [v3]
In-Reply-To: <mYbkStgCsaptje-AhBJyCnAHOABmFIAOHgBYPfHYFdk=.a9aae2bd-8a90-4e1a-b302-4801ac177a9d@github.com>
References: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
 <mYbkStgCsaptje-AhBJyCnAHOABmFIAOHgBYPfHYFdk=.a9aae2bd-8a90-4e1a-b302-4801ac177a9d@github.com>
Message-ID: <LEf3oVpszlmjoHmj4n5LJGAn3MfabXjbYj_k0wpY5e0=.b8614975-4abe-466d-b03f-129614b9512b@github.com>

On Wed, 25 Sep 2024 19:49:16 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review some `build.sh` and `Makefile` changes to address issues building on Windows.
>> 
>> The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
>> There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.
>> 
>> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix test classpath when DAISYDIFF_JAR is empty (for Windows)

Marked as reviewed by cstein (Committer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/12#pullrequestreview-2329400081

From jjg at openjdk.org  Wed Sep 25 20:05:17 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 20:05:17 GMT
Subject: RFR: 7903838: apidiff: Update Vintage JUnit test
Message-ID: <p2EyJCnwCbW9cyzChS1F-iKUD5dTzpHXpITufnf393s=.1d711e88-1b05-4dbd-95e3-0fab90da4442@github.com>

Please review a trivial fix to upgrade a test to use the recommended `@Test` annotation.

-------------

Commit messages:
 - CODETOOLS-7903838: apidiff: Update Vintage JUnit test

Changes: https://git.openjdk.org/apidiff/pull/13/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=13&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903838
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/apidiff/pull/13.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/13/head:pull/13

PR: https://git.openjdk.org/apidiff/pull/13

From jjg at openjdk.org  Wed Sep 25 22:43:56 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Wed, 25 Sep 2024 22:43:56 GMT
Subject: RFR: 7903841: apidiff: IllegalStateException for RECORD in
 TypePageReporter
Message-ID: <YrE_79cOVg7HrMWivVRr2TSdw18foOrHMeqO2gjh6Sg=.0c7559a5-f65d-4d97-ab03-48d3ca3e0ee6@github.com>

Please review a trivial fix to include RECORD in the set of known element kinds for classes and interfaces

-------------

Commit messages:
 - CODETOOLS-7903841: apidiff: IllegalStateException for RECORD in TypePageReporter

Changes: https://git.openjdk.org/apidiff/pull/15/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=15&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903841
  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/apidiff/pull/15.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/15/head:pull/15

PR: https://git.openjdk.org/apidiff/pull/15

From cstein at openjdk.org  Thu Sep 26 05:22:49 2024
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 26 Sep 2024 05:22:49 GMT
Subject: RFR: 7903838: apidiff: Update Vintage JUnit test
In-Reply-To: <p2EyJCnwCbW9cyzChS1F-iKUD5dTzpHXpITufnf393s=.1d711e88-1b05-4dbd-95e3-0fab90da4442@github.com>
References: <p2EyJCnwCbW9cyzChS1F-iKUD5dTzpHXpITufnf393s=.1d711e88-1b05-4dbd-95e3-0fab90da4442@github.com>
Message-ID: <4z46vaLO19FLXhs2M89Idicy3sHe8kXNyyw7t8Kk6rc=.a34afc21-0222-45e6-b0de-4052bebb024d@github.com>

On Wed, 25 Sep 2024 20:00:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial fix to upgrade a test to use the recommended `@Test` annotation.

Marked as reviewed by cstein (Committer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/13#pullrequestreview-2330091717

From cstein at openjdk.org  Thu Sep 26 06:31:48 2024
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 26 Sep 2024 06:31:48 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows [v3]
In-Reply-To: <mYbkStgCsaptje-AhBJyCnAHOABmFIAOHgBYPfHYFdk=.a9aae2bd-8a90-4e1a-b302-4801ac177a9d@github.com>
References: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
 <mYbkStgCsaptje-AhBJyCnAHOABmFIAOHgBYPfHYFdk=.a9aae2bd-8a90-4e1a-b302-4801ac177a9d@github.com>
Message-ID: <Npt0WzflU51K7358xFiSVXZfc7LZy7LxjcP9Gtc_yyM=.b6f5e57c-8430-482b-8392-060674d6559a@github.com>

On Wed, 25 Sep 2024 19:52:23 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review some `build.sh` and `Makefile` changes to address issues building on Windows.
>> 
>> The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
>> There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.
>> 
>> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix test classpath when DAISYDIFF_JAR is empty (for Windows)

Changes requested by cstein (Committer).

test/junit/JUnitTests.gmk line 33:

> 31: 
> 32: JUnitTest.classpath = \
> 33: 		$(BUILDTESTDIR)/JUnitTests/classes:$(APIDIFF_IMAGEDIR)/lib/apidiff.jar:$(JAVADIFFUTILS_JAR):$(HTMLCLEANER_JAR)

Suggestion:

		$(BUILDTESTDIR)/JUnitTests/classes:$(APIDIFF_IMAGEDIR)/lib/apidiff.jar:$(JAVADIFFUTILS_JAR):$(HTMLCLEANER_JAR):$(EQUINOX_JAR)

-------------

PR Review: https://git.openjdk.org/apidiff/pull/12#pullrequestreview-2330234646
PR Review Comment: https://git.openjdk.org/apidiff/pull/12#discussion_r1776456144

From cstein at openjdk.org  Thu Sep 26 15:32:49 2024
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 26 Sep 2024 15:32:49 GMT
Subject: RFR: ODETOOLS-7903835: apidiff: CompareOptionsTest fails on recent
 JDK
In-Reply-To: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>
References: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>
Message-ID: <UclBfSnW9ucv5xURuXZi2j6odO2vId_srPaZ2McDNPQ=.c4992e85-5dff-4aa9-8976-d0d31d45f679@github.com>

On Wed, 25 Sep 2024 16:05:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple fix to not include line numbers in the reference output for this test. The underlying javadoc output has changed, so the line numbers in the diff have also changed.

Marked as reviewed by cstein (Committer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/10#pullrequestreview-2331668396

From iris at openjdk.org  Thu Sep 26 16:36:36 2024
From: iris at openjdk.org (Iris Clark)
Date: Thu, 26 Sep 2024 16:36:36 GMT
Subject: RFR: ODETOOLS-7903835: apidiff: CompareOptionsTest fails on recent
 JDK
In-Reply-To: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>
References: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>
Message-ID: <fOh6phRi59VWbD3sqxXA71bx4x7kTO8ENQ8808lLrHs=.07a44be6-fa9c-4258-a738-264910087d86@github.com>

On Wed, 25 Sep 2024 16:05:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple fix to not include line numbers in the reference output for this test. The underlying javadoc output has changed, so the line numbers in the diff have also changed.

Commit message: "ODETOOLS-7903835" -> "**C**ODETOOLS-7903835" (missing 'C')

-------------

PR Comment: https://git.openjdk.org/apidiff/pull/10#issuecomment-2377435844

From jjg at openjdk.org  Thu Sep 26 17:19:48 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 26 Sep 2024 17:19:48 GMT
Subject: Integrated: 7903834: apidiff: DocPath issue on Windows
In-Reply-To: <vgRMspAof3-lRSZwXbd13PYD9wuP4liEZbFZw-nGEYI=.f362783c-6613-4ef6-96d3-a7386f7f04d4@github.com>
References: <vgRMspAof3-lRSZwXbd13PYD9wuP4liEZbFZw-nGEYI=.f362783c-6613-4ef6-96d3-a7386f7f04d4@github.com>
Message-ID: <_4Y5s0dXE-P0mdj1QTWRO5-pN7nddgUAtxxenzHo4pI=.37b6a362-b351-4dcd-ab89-600813daf326@github.com>

On Wed, 25 Sep 2024 15:43:32 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a small fix to correctly handle Windows paths.

This pull request has now been integrated.

Changeset: 95b73453
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/95b7345320ddb5471f71a4789aa1beb4645a9143
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

7903834: apidiff: DocPath issue on Windows

Reviewed-by: cstein, iris

-------------

PR: https://git.openjdk.org/apidiff/pull/8

From jjg at openjdk.org  Thu Sep 26 17:21:48 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 26 Sep 2024 17:21:48 GMT
Subject: Integrated: 7903835: apidiff: CompareOptionsTest fails on recent JDK
In-Reply-To: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>
References: <Lkrj9oA0brV9BKGqXQGYCuwqs-3_7CbP9KQCVzi4ljU=.4601549a-0d35-46e8-b0ca-41adb76d4f3f@github.com>
Message-ID: <ODd9O5GlhyMoBABjsd4oOiwty41F6x7m7gPzQKLh49U=.3a99b525-82a4-43e3-a2e3-8d9bf89062ef@github.com>

On Wed, 25 Sep 2024 16:05:26 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a simple fix to not include line numbers in the reference output for this test. The underlying javadoc output has changed, so the line numbers in the diff have also changed.

This pull request has now been integrated.

Changeset: a7e2218c
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/a7e2218c686f4bba855bd32b57839d20270a5b3d
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

7903835: apidiff: CompareOptionsTest fails on recent JDK

Reviewed-by: iris, cstein

-------------

PR: https://git.openjdk.org/apidiff/pull/10

From jjg at openjdk.org  Thu Sep 26 19:01:16 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Thu, 26 Sep 2024 19:01:16 GMT
Subject: RFR: 7903846: apidiff: test issues on Windows
Message-ID: <d-hldtBbZ67sgBciDobUI0gjB0WJLIn-pPo231FRboQ=.403f3752-2c5f-4bb4-b910-fcf04990f624@github.com>

Please review a fix for some issues reported when running tests on Windows.

For `GetSerialVersionUITest`, the derivation of the working directory was broken in a couple of ways, which have both been fixed:
1. the computation of the path name assumed all members were fields; whereas the test cases have evolved to include other complex members
2. the work/scratch directory was being emptied between test cases, so that only the last one remained. there is a more appropriate method to use instead, so that all the working files are preserved

-------------

Commit messages:
 - CODETOOLS-7903846: apidiff: test issues on Windows

Changes: https://git.openjdk.org/apidiff/pull/16/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=16&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903846
  Stats: 12 lines in 2 files changed: 2 ins; 0 del; 10 mod
  Patch: https://git.openjdk.org/apidiff/pull/16.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/16/head:pull/16

PR: https://git.openjdk.org/apidiff/pull/16

From cstein at openjdk.org  Fri Sep 27 14:49:47 2024
From: cstein at openjdk.org (Christian Stein)
Date: Fri, 27 Sep 2024 14:49:47 GMT
Subject: RFR: 7903846: apidiff: test issues on Windows
In-Reply-To: <d-hldtBbZ67sgBciDobUI0gjB0WJLIn-pPo231FRboQ=.403f3752-2c5f-4bb4-b910-fcf04990f624@github.com>
References: <d-hldtBbZ67sgBciDobUI0gjB0WJLIn-pPo231FRboQ=.403f3752-2c5f-4bb4-b910-fcf04990f624@github.com>
Message-ID: <QywBAa4wUmRGU4p0lhwVzLUpDh9A2e164IPLqrHJXVU=.a52f6b16-6c03-446c-99d6-f602b560e7bc@github.com>

On Thu, 26 Sep 2024 18:56:36 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a fix for some issues reported when running tests on Windows.
> 
> For `GetSerialVersionUITest`, the derivation of the working directory was broken in a couple of ways, which have both been fixed:
> 1. the computation of the path name assumed all members were fields; whereas the test cases have evolved to include other complex members
> 2. the work/scratch directory was being emptied between test cases, so that only the last one remained. there is a more appropriate method to use instead, so that all the working files are preserved

Marked as reviewed by cstein (Committer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/16#pullrequestreview-2333944801

From jjg at openjdk.org  Fri Sep 27 15:00:25 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 27 Sep 2024 15:00:25 GMT
Subject: RFR: 7903846: apidiff: test issues on Windows [v2]
In-Reply-To: <d-hldtBbZ67sgBciDobUI0gjB0WJLIn-pPo231FRboQ=.403f3752-2c5f-4bb4-b910-fcf04990f624@github.com>
References: <d-hldtBbZ67sgBciDobUI0gjB0WJLIn-pPo231FRboQ=.403f3752-2c5f-4bb4-b910-fcf04990f624@github.com>
Message-ID: <JyykelgFKN2mdyHUBrbuvEv0-gd_EjdS5ZR2U7eVo2E=.b12219a6-e715-45d7-8e93-7ae646ecb8ad@github.com>

> Please review a fix for some issues reported when running tests on Windows.
> 
> For `GetSerialVersionUITest`, the derivation of the working directory was broken in a couple of ways, which have both been fixed:
> 1. the computation of the path name assumed all members were fields; whereas the test cases have evolved to include other complex members
> 2. the work/scratch directory was being emptied between test cases, so that only the last one remained. there is a more appropriate method to use instead, so that all the working files are preserved

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  review feedback: proactively remove edit to JUnitTests.gmk to avoid a merge conflict with an equivalent change in another PR.

-------------

Changes:
  - all: https://git.openjdk.org/apidiff/pull/16/files
  - new: https://git.openjdk.org/apidiff/pull/16/files/616a1d77..c1463766

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=apidiff&pr=16&range=01
 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=16&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/apidiff/pull/16.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/16/head:pull/16

PR: https://git.openjdk.org/apidiff/pull/16

From iris at openjdk.org  Fri Sep 27 15:42:50 2024
From: iris at openjdk.org (Iris Clark)
Date: Fri, 27 Sep 2024 15:42:50 GMT
Subject: RFR: 7903846: apidiff: test issues on Windows [v2]
In-Reply-To: <JyykelgFKN2mdyHUBrbuvEv0-gd_EjdS5ZR2U7eVo2E=.b12219a6-e715-45d7-8e93-7ae646ecb8ad@github.com>
References: <d-hldtBbZ67sgBciDobUI0gjB0WJLIn-pPo231FRboQ=.403f3752-2c5f-4bb4-b910-fcf04990f624@github.com>
 <JyykelgFKN2mdyHUBrbuvEv0-gd_EjdS5ZR2U7eVo2E=.b12219a6-e715-45d7-8e93-7ae646ecb8ad@github.com>
Message-ID: <PnXZvwJGYCOhNJbYseHHXxFBTq9n5Y9b5Yx9XSsXJZA=.caf7c7f8-35d6-46df-be9d-06b0913dc477@github.com>

On Fri, 27 Sep 2024 15:00:25 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a fix for some issues reported when running tests on Windows.
>> 
>> For `GetSerialVersionUITest`, the derivation of the working directory was broken in a couple of ways, which have both been fixed:
>> 1. the computation of the path name assumed all members were fields; whereas the test cases have evolved to include other complex members
>> 2. the work/scratch directory was being emptied between test cases, so that only the last one remained. there is a more appropriate method to use instead, so that all the working files are preserved
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review feedback: proactively remove edit to JUnitTests.gmk to avoid a merge conflict with an equivalent change in another PR.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/16#pullrequestreview-2334075674

From iris at openjdk.org  Fri Sep 27 18:07:48 2024
From: iris at openjdk.org (Iris Clark)
Date: Fri, 27 Sep 2024 18:07:48 GMT
Subject: RFR: 7903841: apidiff: IllegalStateException for RECORD in
 TypePageReporter
In-Reply-To: <YrE_79cOVg7HrMWivVRr2TSdw18foOrHMeqO2gjh6Sg=.0c7559a5-f65d-4d97-ab03-48d3ca3e0ee6@github.com>
References: <YrE_79cOVg7HrMWivVRr2TSdw18foOrHMeqO2gjh6Sg=.0c7559a5-f65d-4d97-ab03-48d3ca3e0ee6@github.com>
Message-ID: <S21wGmfmPwTjQrlez0cSCcuuK0FpXjWQgF_hFAt61Xo=.8c76a930-632c-4468-9592-2055fa460518@github.com>

On Wed, 25 Sep 2024 22:39:46 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial fix to include RECORD in the set of known element kinds for classes and interfaces

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/15#pullrequestreview-2334333673

From jjg at openjdk.org  Fri Sep 27 18:36:48 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 27 Sep 2024 18:36:48 GMT
Subject: Integrated: 7903841: apidiff: IllegalStateException for RECORD in
 TypePageReporter
In-Reply-To: <YrE_79cOVg7HrMWivVRr2TSdw18foOrHMeqO2gjh6Sg=.0c7559a5-f65d-4d97-ab03-48d3ca3e0ee6@github.com>
References: <YrE_79cOVg7HrMWivVRr2TSdw18foOrHMeqO2gjh6Sg=.0c7559a5-f65d-4d97-ab03-48d3ca3e0ee6@github.com>
Message-ID: <BDzRbFbWCQ-PP8EaLiJsoPDaWX6NYK-61Z-nFbYtNUA=.1dd3a6f5-5d10-487f-ba15-50f89f8e6a2f@github.com>

On Wed, 25 Sep 2024 22:39:46 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial fix to include RECORD in the set of known element kinds for classes and interfaces

This pull request has now been integrated.

Changeset: c432f4ae
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/c432f4aeca2c18d6c6140d8fba08d7add983b910
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

7903841: apidiff: IllegalStateException for RECORD in TypePageReporter

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/apidiff/pull/15

From iris at openjdk.org  Fri Sep 27 19:07:49 2024
From: iris at openjdk.org (Iris Clark)
Date: Fri, 27 Sep 2024 19:07:49 GMT
Subject: RFR: 7903838: apidiff: Update Vintage JUnit test
In-Reply-To: <p2EyJCnwCbW9cyzChS1F-iKUD5dTzpHXpITufnf393s=.1d711e88-1b05-4dbd-95e3-0fab90da4442@github.com>
References: <p2EyJCnwCbW9cyzChS1F-iKUD5dTzpHXpITufnf393s=.1d711e88-1b05-4dbd-95e3-0fab90da4442@github.com>
Message-ID: <5T-ZR-jgQNnZcLrACJcvbXSw4UbnYxEb0z85I9WwFeE=.c79319ba-5a3b-4c8d-9b1c-39354c864843@github.com>

On Wed, 25 Sep 2024 20:00:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial fix to upgrade a test to use the recommended `@Test` annotation.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/13#pullrequestreview-2334448029

From jjg at openjdk.org  Fri Sep 27 21:42:22 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 27 Sep 2024 21:42:22 GMT
Subject: RFR: 7903830: apidiff: Review glyphs used to indicate same/difference
Message-ID: <WXfFNxBW9WNlJVAgH_j0Yzj8vrnZIDiv3KJ42b10wc4=.2ccd2137-4230-430e-991f-2a708a786880@github.com>

Please review a medium small fix to change the glyphs used to visually indicate whether elements are the same, different, or in the case of a two-way comparison, added or removed.

-------------

Commit messages:
 - CODETOOLS-7903830: apidiff: Review glyphs used to indicate same/difference

Changes: https://git.openjdk.org/apidiff/pull/17/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=17&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903830
  Stats: 59 lines in 3 files changed: 48 ins; 0 del; 11 mod
  Patch: https://git.openjdk.org/apidiff/pull/17.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/17/head:pull/17

PR: https://git.openjdk.org/apidiff/pull/17

From jjg at openjdk.org  Fri Sep 27 21:42:54 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 27 Sep 2024 21:42:54 GMT
Subject: Integrated: 7903838: apidiff: Update Vintage JUnit test
In-Reply-To: <p2EyJCnwCbW9cyzChS1F-iKUD5dTzpHXpITufnf393s=.1d711e88-1b05-4dbd-95e3-0fab90da4442@github.com>
References: <p2EyJCnwCbW9cyzChS1F-iKUD5dTzpHXpITufnf393s=.1d711e88-1b05-4dbd-95e3-0fab90da4442@github.com>
Message-ID: <rdScETfT811H1kJ-_ACuSSZncNDfR73N1GMsmoKBTfw=.3a37ffe7-0703-4a40-9a98-155711fea8b9@github.com>

On Wed, 25 Sep 2024 20:00:59 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a trivial fix to upgrade a test to use the recommended `@Test` annotation.

This pull request has now been integrated.

Changeset: bb3eb153
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/bb3eb15350dd74ce1d1f764ba14ba800679d700b
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

7903838: apidiff: Update Vintage JUnit test

Reviewed-by: cstein, iris

-------------

PR: https://git.openjdk.org/apidiff/pull/13

From jjg at openjdk.org  Fri Sep 27 22:00:57 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 27 Sep 2024 22:00:57 GMT
Subject: Integrated: 7903846: apidiff: test issues on Windows
In-Reply-To: <d-hldtBbZ67sgBciDobUI0gjB0WJLIn-pPo231FRboQ=.403f3752-2c5f-4bb4-b910-fcf04990f624@github.com>
References: <d-hldtBbZ67sgBciDobUI0gjB0WJLIn-pPo231FRboQ=.403f3752-2c5f-4bb4-b910-fcf04990f624@github.com>
Message-ID: <OLkl_Xm_BsROjLnXXde4Hw5rKMdsPPq7_1MBsGe_hbo=.bdbd3944-96a2-49be-b18f-428c14344b2d@github.com>

On Thu, 26 Sep 2024 18:56:36 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a fix for some issues reported when running tests on Windows.
> 
> For `GetSerialVersionUITest`, the derivation of the working directory was broken in a couple of ways, which have both been fixed:
> 1. the computation of the path name assumed all members were fields; whereas the test cases have evolved to include other complex members
> 2. the work/scratch directory was being emptied between test cases, so that only the last one remained. there is a more appropriate method to use instead, so that all the working files are preserved

This pull request has now been integrated.

Changeset: dbaa7ac2
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/dbaa7ac25ce0e73714c10503ac30af4ca2e7173a
Stats:     10 lines in 1 file changed: 2 ins; 0 del; 8 mod

7903846: apidiff: test issues on Windows

Reviewed-by: cstein, iris

-------------

PR: https://git.openjdk.org/apidiff/pull/16

From jjg at openjdk.org  Fri Sep 27 23:00:27 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Fri, 27 Sep 2024 23:00:27 GMT
Subject: RFR: 7903830: apidiff: Review glyphs used to indicate
 same/difference [v2]
In-Reply-To: <WXfFNxBW9WNlJVAgH_j0Yzj8vrnZIDiv3KJ42b10wc4=.2ccd2137-4230-430e-991f-2a708a786880@github.com>
References: <WXfFNxBW9WNlJVAgH_j0Yzj8vrnZIDiv3KJ42b10wc4=.2ccd2137-4230-430e-991f-2a708a786880@github.com>
Message-ID: <VivXLygbOFFF1o3AZLFlVXojVcvmYMcdqdntsXgtMwI=.dde1475e-b7e1-437b-8350-3473f55f6f4e@github.com>

> Please review a medium small fix to change the glyphs used to visually indicate whether elements are the same, different, or in the case of a two-way comparison, added or removed.

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  Add TODO comment in Main

-------------

Changes:
  - all: https://git.openjdk.org/apidiff/pull/17/files
  - new: https://git.openjdk.org/apidiff/pull/17/files/d8fa4a23..5e3bf9e5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=apidiff&pr=17&range=01
 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=17&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/apidiff/pull/17.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/17/head:pull/17

PR: https://git.openjdk.org/apidiff/pull/17

From iris at openjdk.org  Fri Sep 27 23:10:52 2024
From: iris at openjdk.org (Iris Clark)
Date: Fri, 27 Sep 2024 23:10:52 GMT
Subject: RFR: 7903830: apidiff: Review glyphs used to indicate
 same/difference [v2]
In-Reply-To: <VivXLygbOFFF1o3AZLFlVXojVcvmYMcdqdntsXgtMwI=.dde1475e-b7e1-437b-8350-3473f55f6f4e@github.com>
References: <WXfFNxBW9WNlJVAgH_j0Yzj8vrnZIDiv3KJ42b10wc4=.2ccd2137-4230-430e-991f-2a708a786880@github.com>
 <VivXLygbOFFF1o3AZLFlVXojVcvmYMcdqdntsXgtMwI=.dde1475e-b7e1-437b-8350-3473f55f6f4e@github.com>
Message-ID: <Sn5_6j6gaX8vJamzvOOIDY7A3HMYfF55zlELwnNDsjM=.86dde6ba-d8a5-4a63-83a8-24950a10e5a1@github.com>

On Fri, 27 Sep 2024 23:00:27 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a medium small fix to change the glyphs used to visually indicate whether elements are the same, different, or in the case of a two-way comparison, added or removed.
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add TODO comment in Main

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/17#pullrequestreview-2334785697

From prappo at openjdk.org  Mon Sep 30 15:38:22 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Mon, 30 Sep 2024 15:38:22 GMT
Subject: RFR: 7903849: Scrape off Apache Ant remnants from APIDiff
Message-ID: <rLKDcCYUQSDVwFPNaxpUpwLDzBtdxKpnpH5Hhx6xq0U=.7c1ed47a-274c-435d-bc0a-e521e746ab7d@github.com>

Apache Ant build described in README.md does not work. It seems out of date and out of sync with GNU make build. It should be removed.

-------------

Commit messages:
 - Initial commit

Changes: https://git.openjdk.org/apidiff/pull/18/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=18&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903849
  Stats: 273 lines in 5 files changed: 0 ins; 264 del; 9 mod
  Patch: https://git.openjdk.org/apidiff/pull/18.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/18/head:pull/18

PR: https://git.openjdk.org/apidiff/pull/18

From jjg at openjdk.org  Mon Sep 30 15:38:22 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 30 Sep 2024 15:38:22 GMT
Subject: RFR: 7903849: Scrape off Apache Ant remnants from APIDiff
In-Reply-To: <rLKDcCYUQSDVwFPNaxpUpwLDzBtdxKpnpH5Hhx6xq0U=.7c1ed47a-274c-435d-bc0a-e521e746ab7d@github.com>
References: <rLKDcCYUQSDVwFPNaxpUpwLDzBtdxKpnpH5Hhx6xq0U=.7c1ed47a-274c-435d-bc0a-e521e746ab7d@github.com>
Message-ID: <bebBNIHvaMS64J4paxefSNveiATVCu5MO4tT0iCJcIQ=.f51ca536-6760-4f4c-8594-85f20c60fe68@github.com>

On Mon, 30 Sep 2024 15:28:50 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Apache Ant build described in README.md does not work. It seems out of date and out of sync with GNU make build. It should be removed.

Welcome to `apidiff`.

Yes, less in more. 

I encourage you to look at adding appropriate text and files for working on the code in an IDE, and being able to run tests there.

-------------

Marked as reviewed by jjg (Reviewer).

PR Review: https://git.openjdk.org/apidiff/pull/18#pullrequestreview-2337927014

From duke at openjdk.org  Mon Sep 30 15:41:48 2024
From: duke at openjdk.org (duke)
Date: Mon, 30 Sep 2024 15:41:48 GMT
Subject: RFR: 7903849: Scrape off Apache Ant remnants from APIDiff
In-Reply-To: <rLKDcCYUQSDVwFPNaxpUpwLDzBtdxKpnpH5Hhx6xq0U=.7c1ed47a-274c-435d-bc0a-e521e746ab7d@github.com>
References: <rLKDcCYUQSDVwFPNaxpUpwLDzBtdxKpnpH5Hhx6xq0U=.7c1ed47a-274c-435d-bc0a-e521e746ab7d@github.com>
Message-ID: <3zEGw0ybhuc4VVMpk7KchyM210VljvepOK6mdqfz8H0=.f1f52eb6-e939-47e5-9c01-7bd76ae040d3@github.com>

On Mon, 30 Sep 2024 15:28:50 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Apache Ant build described in README.md does not work. It seems out of date and out of sync with GNU make build. It should be removed.

@pavelrappo 
Your change (at version da473d2cbee4d686b0183d9b1e88037c5325d30c) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/apidiff/pull/18#issuecomment-2383550561

From prappo at openjdk.org  Mon Sep 30 16:08:50 2024
From: prappo at openjdk.org (Pavel Rappo)
Date: Mon, 30 Sep 2024 16:08:50 GMT
Subject: Integrated: 7903849: Scrape off Apache Ant remnants from APIDiff
In-Reply-To: <rLKDcCYUQSDVwFPNaxpUpwLDzBtdxKpnpH5Hhx6xq0U=.7c1ed47a-274c-435d-bc0a-e521e746ab7d@github.com>
References: <rLKDcCYUQSDVwFPNaxpUpwLDzBtdxKpnpH5Hhx6xq0U=.7c1ed47a-274c-435d-bc0a-e521e746ab7d@github.com>
Message-ID: <BRjaNLVK_xk8K4un4qYu95IPqY6TWQ-8SDA_K3fxw5E=.a426755b-8235-41a9-b133-6b902eaab08c@github.com>

On Mon, 30 Sep 2024 15:28:50 GMT, Pavel Rappo <prappo at openjdk.org> wrote:

> Apache Ant build described in README.md does not work. It seems out of date and out of sync with GNU make build. It should be removed.

This pull request has now been integrated.

Changeset: e0b049ae
Author:    Pavel Rappo <prappo at openjdk.org>
Committer: Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/e0b049ae0748ac2816676e337f4223bc8242bd71
Stats:     273 lines in 5 files changed: 0 ins; 264 del; 9 mod

7903849: Scrape off Apache Ant remnants from APIDiff

Reviewed-by: jjg

-------------

PR: https://git.openjdk.org/apidiff/pull/18

From jjg at openjdk.org  Mon Sep 30 21:31:23 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 30 Sep 2024 21:31:23 GMT
Subject: RFR: 7903840: apidiff: optionally show expansion of `--jdk-build`
Message-ID: <CQVFY1VpqKR_uYrNFRRzt4dco0Iq8qE_hGgiEMcJAj8=.66a4e9c2-fee3-410f-9870-c5d3f3a82597@github.com>

Please review a small-ish PR to add support for `--verbose options` which outputs details about the upfront option handling.

-------------

Commit messages:
 - fix test compilation failure, and fix some IDE suggestions
 - CODETOOLS-7903840: apidiff: optionally show expansion of `--jdk-build`

Changes: https://git.openjdk.org/apidiff/pull/19/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=19&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903840
  Stats: 120 lines in 6 files changed: 99 ins; 1 del; 20 mod
  Patch: https://git.openjdk.org/apidiff/pull/19.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/19/head:pull/19

PR: https://git.openjdk.org/apidiff/pull/19

From jjg at openjdk.org  Mon Sep 30 22:05:56 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 30 Sep 2024 22:05:56 GMT
Subject: Integrated: 7903830: apidiff: Review glyphs used to indicate
 same/difference
In-Reply-To: <WXfFNxBW9WNlJVAgH_j0Yzj8vrnZIDiv3KJ42b10wc4=.2ccd2137-4230-430e-991f-2a708a786880@github.com>
References: <WXfFNxBW9WNlJVAgH_j0Yzj8vrnZIDiv3KJ42b10wc4=.2ccd2137-4230-430e-991f-2a708a786880@github.com>
Message-ID: <EbQXoLchjazahUcl1mBxpUGajPiVAKbPKu0p8K90bFc=.977898dc-e415-4262-977a-365a62aa9d20@github.com>

On Fri, 27 Sep 2024 21:37:07 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

> Please review a medium small fix to change the glyphs used to visually indicate whether elements are the same, different, or in the case of a two-way comparison, added or removed.

This pull request has now been integrated.

Changeset: 10a494c1
Author:    Jonathan Gibbons <jjg at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/10a494c177cca703dda8005fce4eee34c4150156
Stats:     61 lines in 4 files changed: 50 ins; 0 del; 11 mod

7903830: apidiff: Review glyphs used to indicate same/difference

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/apidiff/pull/17

From jjg at openjdk.org  Mon Sep 30 22:10:25 2024
From: jjg at openjdk.org (Jonathan Gibbons)
Date: Mon, 30 Sep 2024 22:10:25 GMT
Subject: RFR: 7903837: apidiff: build.sh issues on Windows [v4]
In-Reply-To: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
References: <p10rhB88Coerc6z01jV02JW82CO6JowwfG2bxZ9TXnc=.35a09780-82a5-464d-9cf5-e35d6e496a65@github.com>
Message-ID: <s6s9Vi9xduGNaMCPPE2ksvpPQ2xy8qDfTL2hBVOBvtQ=.013379ce-7856-4407-b59c-47bcd06f01de@github.com>

> Please review some `build.sh` and `Makefile` changes to address issues building on Windows.
> 
> The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
> There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.
> 
> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?

Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:

  add EQUINOX_JAR, per suggestion in review

-------------

Changes:
  - all: https://git.openjdk.org/apidiff/pull/12/files
  - new: https://git.openjdk.org/apidiff/pull/12/files/afc38f77..6d3c8943

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=apidiff&pr=12&range=03
 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=12&range=02-03

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/apidiff/pull/12.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/12/head:pull/12

PR: https://git.openjdk.org/apidiff/pull/12