RFR: 7903837: apidiff: build.sh issues on Windows [v3]

[Christian Stein]

On Wed, 25 Sep 2024 19:52:23 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review some `build.sh` and `Makefile` changes to address issues building on Windows.
>> 
>> The primary Windows issue was missing use of `mixed_path` when passing some filenames into `make`.
>> There is some additional cleanup (for all platforms) to normalize the `DEPS_DIR` and add missing items to the `sanity` and `check_build_vars` targets.
>> 
>> This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix test classpath when DAISYDIFF_JAR is empty (for Windows)

Changes requested by cstein (Committer).

test/junit/JUnitTests.gmk line 33:

> 31: 
> 32: JUnitTest.classpath = \
> 33: 		$(BUILDTESTDIR)/JUnitTests/classes:$(APIDIFF_IMAGEDIR)/lib/apidiff.jar:$(JAVADIFFUTILS_JAR):$(HTMLCLEANER_JAR)

Suggestion:

		$(BUILDTESTDIR)/JUnitTests/classes:$(APIDIFF_IMAGEDIR)/lib/apidiff.jar:$(JAVADIFFUTILS_JAR):$(HTMLCLEANER_JAR):$(EQUINOX_JAR)

-------------

PR Review: https://git.openjdk.org/apidiff/pull/12#pullrequestreview-2330234646
PR Review Comment: https://git.openjdk.org/apidiff/pull/12#discussion_r1776456144