RFR: 7903846: apidiff: test issues on Windows
Christian Stein
cstein at openjdk.org
Fri Sep 27 14:49:47 UTC 2024
On Thu, 26 Sep 2024 18:56:36 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:
> Please review a fix for some issues reported when running tests on Windows.
>
> For `GetSerialVersionUITest`, the derivation of the working directory was broken in a couple of ways, which have both been fixed:
> 1. the computation of the path name assumed all members were fields; whereas the test cases have evolved to include other complex members
> 2. the work/scratch directory was being emptied between test cases, so that only the last one remained. there is a more appropriate method to use instead, so that all the working files are preserved
Marked as reviewed by cstein (Committer).
-------------
PR Review: https://git.openjdk.org/apidiff/pull/16#pullrequestreview-2333944801
More information about the apidiff-dev
mailing list