RFR: 7903846: apidiff: test issues on Windows [v2]

Iris Clark iris at openjdk.org
Fri Sep 27 15:42:50 UTC 2024


On Fri, 27 Sep 2024 15:00:25 GMT, Jonathan Gibbons <jjg at openjdk.org> wrote:

>> Please review a fix for some issues reported when running tests on Windows.
>> 
>> For `GetSerialVersionUITest`, the derivation of the working directory was broken in a couple of ways, which have both been fixed:
>> 1. the computation of the path name assumed all members were fields; whereas the test cases have evolved to include other complex members
>> 2. the work/scratch directory was being emptied between test cases, so that only the last one remained. there is a more appropriate method to use instead, so that all the working files are preserved
>
> Jonathan Gibbons has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review feedback: proactively remove edit to JUnitTests.gmk to avoid a merge conflict with an equivalent change in another PR.

Marked as reviewed by iris (Reviewer).

-------------

PR Review: https://git.openjdk.org/apidiff/pull/16#pullrequestreview-2334075674


More information about the apidiff-dev mailing list