From cstein at openjdk.org  Thu Aug 28 06:54:07 2025
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 28 Aug 2025 06:54:07 GMT
Subject: RFR: 7904068: Update to use JUnit 5.13
Message-ID: <rW-A023hErDB0_x0A0ypGd4cyq18884DicGUp4T4C9g=.91ef6037-3751-4d51-b0f0-740e1b0f59d4@github.com>

Please review this change updating to use JUnit 5.13.4

-------------

Commit messages:
 - Use correct order of arguments
 - Fix syntax
 - Use JUnit's `execute` command directly
 - Use correct SHA1 checksum
 - Update to use JUnit 5.13

Changes: https://git.openjdk.org/apidiff/pull/30/files
  Webrev: https://webrevs.openjdk.org/?repo=apidiff&pr=30&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7904068
  Stats: 5 lines in 2 files changed: 1 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/apidiff/pull/30.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/30/head:pull/30

PR: https://git.openjdk.org/apidiff/pull/30

From cstein at openjdk.org  Thu Aug 28 06:54:07 2025
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 28 Aug 2025 06:54:07 GMT
Subject: RFR: 7904068: Update to use JUnit 5.13
In-Reply-To: <rW-A023hErDB0_x0A0ypGd4cyq18884DicGUp4T4C9g=.91ef6037-3751-4d51-b0f0-740e1b0f59d4@github.com>
References: <rW-A023hErDB0_x0A0ypGd4cyq18884DicGUp4T4C9g=.91ef6037-3751-4d51-b0f0-740e1b0f59d4@github.com>
Message-ID: <dYb__ezLyWZTkbIIXEPofw7fjIzAF4esyAH38tTcZTQ=.e6de61fa-f315-4e28-bc9e-9dff32ce89a1@github.com>

On Wed, 27 Aug 2025 14:40:08 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating to use JUnit 5.13.4

> Want to see the build fail due to a checksum error.

So it did:


[build.sh][INFO] Downloading https://repo1.maven.org/maven2/org/junit/platform/junit-platform-console-standalone/1.13.4/junit-platform-console-standalone-1.13.4.jar to /home/runner/work/apidiff/apidiff/build/deps/junit/junit-platform-console-standalone-1.13.4.jar
Error: sh][ERROR] Checksum mismatch for /home/runner/work/apidiff/apidiff/build/deps/junit/junit-platform-console-standalone-1.13.4.jar:
Error: sh][ERROR] Expected: bb856bc86a6e6cd48080546afcaf7a210713ea21
Error: sh][ERROR] Actual  : 62734191af1bfc78ee17181ca38b94dbb5eb7737
Error: Process completed with exit code 1.

-------------

PR Comment: https://git.openjdk.org/apidiff/pull/30#issuecomment-3228553207

From cstein at openjdk.org  Thu Aug 28 06:59:34 2025
From: cstein at openjdk.org (Christian Stein)
Date: Thu, 28 Aug 2025 06:59:34 GMT
Subject: RFR: 7904068: Update to use JUnit 5.13 [v2]
In-Reply-To: <rW-A023hErDB0_x0A0ypGd4cyq18884DicGUp4T4C9g=.91ef6037-3751-4d51-b0f0-740e1b0f59d4@github.com>
References: <rW-A023hErDB0_x0A0ypGd4cyq18884DicGUp4T4C9g=.91ef6037-3751-4d51-b0f0-740e1b0f59d4@github.com>
Message-ID: <L73IzfcrMuZAaqIEpfZzwDFXx5neRspUT2c0WPysLTM=.b7124ae1-faba-490d-acfc-00efd050ec40@github.com>

> Please review this change updating to use JUnit 5.13.4

Christian Stein has updated the pull request incrementally with one additional commit since the last revision:

  Fail if JUnit could not find any test

-------------

Changes:
  - all: https://git.openjdk.org/apidiff/pull/30/files
  - new: https://git.openjdk.org/apidiff/pull/30/files/22325c08..7f22edd2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=apidiff&pr=30&range=01
 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=30&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/apidiff/pull/30.diff
  Fetch: git fetch https://git.openjdk.org/apidiff.git pull/30/head:pull/30

PR: https://git.openjdk.org/apidiff/pull/30

From iris at openjdk.org  Thu Aug 28 23:55:55 2025
From: iris at openjdk.org (Iris Clark)
Date: Thu, 28 Aug 2025 23:55:55 GMT
Subject: RFR: 7904068: Update to use JUnit 5.13 [v2]
In-Reply-To: <L73IzfcrMuZAaqIEpfZzwDFXx5neRspUT2c0WPysLTM=.b7124ae1-faba-490d-acfc-00efd050ec40@github.com>
References: <rW-A023hErDB0_x0A0ypGd4cyq18884DicGUp4T4C9g=.91ef6037-3751-4d51-b0f0-740e1b0f59d4@github.com>
 <L73IzfcrMuZAaqIEpfZzwDFXx5neRspUT2c0WPysLTM=.b7124ae1-faba-490d-acfc-00efd050ec40@github.com>
Message-ID: <uImyS4uNObiGzYc3QUELH2s_F7TQjHdw0NKXNwqvwXA=.3cdce383-443c-462c-b717-a4e25ff2b341@github.com>

On Thu, 28 Aug 2025 06:59:34 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Please review this change updating to use JUnit 5.13.4
>
> Christian Stein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fail if JUnit could not find any test

Thanks!

-------------

Marked as reviewed by iris (Reviewer).

PR Review: https://git.openjdk.org/apidiff/pull/30#pullrequestreview-3166933541

From cstein at openjdk.org  Fri Aug 29 05:19:56 2025
From: cstein at openjdk.org (Christian Stein)
Date: Fri, 29 Aug 2025 05:19:56 GMT
Subject: Integrated: 7904068: Update to use JUnit 5.13
In-Reply-To: <rW-A023hErDB0_x0A0ypGd4cyq18884DicGUp4T4C9g=.91ef6037-3751-4d51-b0f0-740e1b0f59d4@github.com>
References: <rW-A023hErDB0_x0A0ypGd4cyq18884DicGUp4T4C9g=.91ef6037-3751-4d51-b0f0-740e1b0f59d4@github.com>
Message-ID: <YOUowN4TBp38VACZIG6ws48Lj2R9Y3ranTzBvDFhn_M=.65fa8f33-e2fb-424c-b016-e1a8569c38b4@github.com>

On Wed, 27 Aug 2025 14:40:08 GMT, Christian Stein <cstein at openjdk.org> wrote:

> Please review this change updating to use JUnit 5.13.4

This pull request has now been integrated.

Changeset: 7b0a1eef
Author:    Christian Stein <cstein at openjdk.org>
URL:       https://git.openjdk.org/apidiff/commit/7b0a1eef3c91e0b6bf0c30794375392cf6899e25
Stats:     6 lines in 2 files changed: 2 ins; 0 del; 4 mod

7904068: Update to use JUnit 5.13

Reviewed-by: iris

-------------

PR: https://git.openjdk.org/apidiff/pull/30