From jlahoda at openjdk.org Wed Oct 1 09:05:48 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Wed, 1 Oct 2025 09:05:48 GMT Subject: RFR: 7904082: The UI for API Diff could be improved [v4] In-Reply-To: References: Message-ID: > This PR intends to improve the result of API diff in a few ways: > - in the list of updated elements, using green for elements that were added (instead of elements that are unchanged), and red for removed elements. At least in cases two variants of an API are compared. > - making added/removed elements more prominent by also coloring the signature lines > - hiding unchanged elements by default. > > An example diff that is produced before this patch: > https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/before/ > after this patch: > https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/after/ > > Please let me know what you think. I'll see if I can reasonably add some tests for this functionality. Jan Lahoda has updated the pull request incrementally with two additional commits since the last revision: - Adding a test. - Adding a command line option to unconditionally show unchanged elements. ------------- Changes: - all: https://git.openjdk.org/apidiff/pull/32/files - new: https://git.openjdk.org/apidiff/pull/32/files/6c795e1e..ffd79499 Webrevs: - full: https://webrevs.openjdk.org/?repo=apidiff&pr=32&range=03 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=32&range=02-03 Stats: 549 lines in 5 files changed: 543 ins; 5 del; 1 mod Patch: https://git.openjdk.org/apidiff/pull/32.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/32/head:pull/32 PR: https://git.openjdk.org/apidiff/pull/32 From jlahoda at openjdk.org Wed Oct 1 11:59:45 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Wed, 1 Oct 2025 11:59:45 GMT Subject: RFR: 7904082: The UI for API Diff could be improved [v5] In-Reply-To: References: Message-ID: > This PR intends to improve the result of API diff in a few ways: > - in the list of updated elements, using green for elements that were added (instead of elements that are unchanged), and red for removed elements. At least in cases two variants of an API are compared. > - making added/removed elements more prominent by also coloring the signature lines > - hiding unchanged elements by default. > > An example diff that is produced before this patch: > https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/before/ > after this patch: > https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/after/ > > Please let me know what you think. I'll see if I can reasonably add some tests for this functionality. Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: Removing trailing whitespace. ------------- Changes: - all: https://git.openjdk.org/apidiff/pull/32/files - new: https://git.openjdk.org/apidiff/pull/32/files/ffd79499..0b50d978 Webrevs: - full: https://webrevs.openjdk.org/?repo=apidiff&pr=32&range=04 - incr: https://webrevs.openjdk.org/?repo=apidiff&pr=32&range=03-04 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/apidiff/pull/32.diff Fetch: git fetch https://git.openjdk.org/apidiff.git pull/32/head:pull/32 PR: https://git.openjdk.org/apidiff/pull/32 From jlahoda at openjdk.org Wed Oct 1 12:04:35 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Wed, 1 Oct 2025 12:04:35 GMT Subject: RFR: 7904082: The UI for API Diff could be improved [v5] In-Reply-To: References: Message-ID: <4VvfmJ8uawJfvL1OtksyJQILqg2zIgxyUJfIr2xUR7Q=.d453efa7-9caf-47d2-8320-ab6857148d37@github.com> On Wed, 1 Oct 2025 11:59:45 GMT, Jan Lahoda wrote: >> This PR intends to improve the result of API diff in a few ways: >> - in the list of updated elements, using green for elements that were added (instead of elements that are unchanged), and red for removed elements. At least in cases two variants of an API are compared. >> - making added/removed elements more prominent by also coloring the signature lines >> - hiding unchanged elements by default. >> >> An example diff that is produced before this patch: >> https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/before/ >> after this patch: >> https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/after/ >> >> Please let me know what you think. I'll see if I can reasonably add some tests for this functionality. > > Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: > > Removing trailing whitespace. I've: - added a new command line option, `--show-unchanged` to unconditionally show unchanged elements - added a test attempt ------------- PR Comment: https://git.openjdk.org/apidiff/pull/32#issuecomment-3355991335 From cstein at openjdk.org Mon Oct 6 06:41:31 2025 From: cstein at openjdk.org (Christian Stein) Date: Mon, 6 Oct 2025 06:41:31 GMT Subject: RFR: 7904082: The UI for API Diff could be improved [v5] In-Reply-To: References: Message-ID: On Wed, 1 Oct 2025 11:59:45 GMT, Jan Lahoda wrote: >> This PR intends to improve the result of API diff in a few ways: >> - in the list of updated elements, using green for elements that were added (instead of elements that are unchanged), and red for removed elements. At least in cases two variants of an API are compared. >> - making added/removed elements more prominent by also coloring the signature lines >> - hiding unchanged elements by default. >> >> An example diff that is produced before this patch: >> https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/before/ >> after this patch: >> https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/after/ >> >> Please let me know what you think. I'll see if I can reasonably add some tests for this functionality. > > Jan Lahoda has updated the pull request incrementally with one additional commit since the last revision: > > Removing trailing whitespace. Marked as reviewed by cstein (Reviewer). ------------- PR Review: https://git.openjdk.org/apidiff/pull/32#pullrequestreview-3302992080 From jlahoda at openjdk.org Mon Oct 6 07:10:28 2025 From: jlahoda at openjdk.org (Jan Lahoda) Date: Mon, 6 Oct 2025 07:10:28 GMT Subject: Integrated: 7904082: The UI for API Diff could be improved In-Reply-To: References: Message-ID: On Mon, 22 Sep 2025 15:41:29 GMT, Jan Lahoda wrote: > This PR intends to improve the result of API diff in a few ways: > - in the list of updated elements, using green for elements that were added (instead of elements that are unchanged), and red for removed elements. At least in cases two variants of an API are compared. > - making added/removed elements more prominent by also coloring the signature lines > - hiding unchanged elements by default. > > An example diff that is produced before this patch: > https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/before/ > after this patch: > https://cr.openjdk.org/~jlahoda/CODETOOLS-7904082/after/ > > Please let me know what you think. I'll see if I can reasonably add some tests for this functionality. This pull request has now been integrated. Changeset: cb6c45e6 Author: Jan Lahoda URL: https://git.openjdk.org/apidiff/commit/cb6c45e6b6530808a787331935cf452440508b06 Stats: 801 lines in 9 files changed: 704 ins; 40 del; 57 mod 7904082: The UI for API Diff could be improved Reviewed-by: cstein ------------- PR: https://git.openjdk.org/apidiff/pull/32