From Brian.Kurotsuchi at Oracle.COM  Fri Jun 10 20:35:24 2016
From: Brian.Kurotsuchi at Oracle.COM (Brian Kurotsuchi)
Date: Fri, 10 Jun 2016 14:35:24 -0600
Subject: REVIEW REQUEST: asmtools.jar manifest changes
Message-ID: <bca7085b-6af0-57be-8ec3-66ec0687f16d@Oracle.COM>

Simple addition of version and other basic info.  Quick and dirty review 
for a simple change.

Side note - I noticed that the product doesn't build cleanly on JDK 8 
(similar to JT Harness) because of Javadoc lint checking - requires 
addition of -Xdoclint:none flag until we clean the sources (diff for 
that not included).

Brian


work at Banana~/asm/asmtools-os/build> hg diff build.xml
diff -r f201bb903e32 build/build.xml
--- a/build/build.xml    Wed Mar 02 14:00:55 2016 -0700
+++ b/build/build.xml    Fri Jun 10 14:31:28 2016 -0600
@@ -238,6 +238,10 @@
               basedir="${build.classes.dir}">
              <manifest>
                  <attribute name="Main-Class" 
value="org.openjdk.asmtools.Main"/>
+                <attribute name="Implementation-Title" 
value="${PRODUCT_NAME_LONG}"/>
+                <attribute name="Implementation-Version" 
value="${PRODUCT_VERSION}"/>
+                <attribute name="Build-Version" 
value="${PRODUCT_VERSION}"/>
+                <attribute name="Build-Number" 
value="${PRODUCT_BUILDNUMBER}"/>
              </manifest>
          </jar>
      </target>


*Results in:*
work at Bananaasm/asmtools-6.0-build/binaries/lib> cat META-INF/MANIFEST.MF
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.9.7
Created-By: 1.8.0_92-b14 (Oracle Corporation)
Main-Class: org.openjdk.asmtools.Main
Implementation-Title: Java Assembler Tools
Implementation-Version: 6.0
Build-Version: 6.0
Build-Number: b01

From kevin.looney at oracle.com  Fri Jun 10 21:03:25 2016
From: kevin.looney at oracle.com (Kevin Looney)
Date: Fri, 10 Jun 2016 14:03:25 -0700
Subject: REVIEW REQUEST: asmtools.jar manifest changes
In-Reply-To: <bca7085b-6af0-57be-8ec3-66ec0687f16d@Oracle.COM>
References: <bca7085b-6af0-57be-8ec3-66ec0687f16d@Oracle.COM>
Message-ID: <d4536d7e-4d16-ece9-d42d-f64ce8dcfca7@oracle.com>

Hi Brian,

The change looks good to me.  I approve.

Thanks,
Kevin

On 6/10/16 1:35 PM, Brian Kurotsuchi wrote:
> Simple addition of version and other basic info. Quick and dirty 
> review for a simple change.
>
> Side note - I noticed that the product doesn't build cleanly on JDK 8 
> (similar to JT Harness) because of Javadoc lint checking - requires 
> addition of -Xdoclint:none flag until we clean the sources (diff for 
> that not included).
>
> Brian
>
>
> work at Banana~/asm/asmtools-os/build> hg diff build.xml
> diff -r f201bb903e32 build/build.xml
> --- a/build/build.xml    Wed Mar 02 14:00:55 2016 -0700
> +++ b/build/build.xml    Fri Jun 10 14:31:28 2016 -0600
> @@ -238,6 +238,10 @@
>               basedir="${build.classes.dir}">
>              <manifest>
>                  <attribute name="Main-Class" 
> value="org.openjdk.asmtools.Main"/>
> +                <attribute name="Implementation-Title" 
> value="${PRODUCT_NAME_LONG}"/>
> +                <attribute name="Implementation-Version" 
> value="${PRODUCT_VERSION}"/>
> +                <attribute name="Build-Version" 
> value="${PRODUCT_VERSION}"/>
> +                <attribute name="Build-Number" 
> value="${PRODUCT_BUILDNUMBER}"/>
>              </manifest>
>          </jar>
>      </target>
>
>
> *Results in:*
> work at Bananaasm/asmtools-6.0-build/binaries/lib> cat META-INF/MANIFEST.MF
> Manifest-Version: 1.0
> Ant-Version: Apache Ant 1.9.7
> Created-By: 1.8.0_92-b14 (Oracle Corporation)
> Main-Class: org.openjdk.asmtools.Main
> Implementation-Title: Java Assembler Tools
> Implementation-Version: 6.0
> Build-Version: 6.0
> Build-Number: b01


-- 
kevin.looney at oracle.com


From brian.kurotsuchi at oracle.com  Wed Jun 15 17:52:34 2016
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Wed, 15 Jun 2016 17:52:34 +0000
Subject: hg: code-tools/asmtools: Add build/product attributes to jar manifest.
Message-ID: <201606151752.u5FHqYBO001532@aojmv0008.oracle.com>

Changeset: b884ce1fc0f8
Author:    bkurotsu
Date:      2016-06-15 11:52 -0600
URL:       http://hg.openjdk.java.net/code-tools/asmtools/rev/b884ce1fc0f8

Add build/product attributes to jar manifest.
Reviewed by: klooney

! build/build.xml


From Brian.Kurotsuchi at Oracle.COM  Wed Jun 15 17:54:08 2016
From: Brian.Kurotsuchi at Oracle.COM (Brian Kurotsuchi)
Date: Wed, 15 Jun 2016 11:54:08 -0600
Subject: [ASM Tools] For review: disable javadoc lint check
Message-ID: <15912224-d129-dacb-fb30-ef05baf7be03@Oracle.COM>

Another quick review.  Now that we upgraded to Java 8, the automatic 
lint checking is broken.  This disables it until we fix the sources.



work at Banana~/asm/asmtools-os/build> hg diff build.xml
diff --git a/build/build.xml b/build/build.xml
--- a/build/build.xml
+++ b/build/build.xml
@@ -296,7 +296,7 @@
              destdir="${build.javadoc.dir}"
              author="false"
              version="false"
-            additionalparam="-breakiterator"
+            additionalparam="-breakiterator -Xdoclint:none"
          >
              <classpath>
                  <path path="${javac.classpath}"/>


From kevin.looney at oracle.com  Wed Jun 15 18:21:53 2016
From: kevin.looney at oracle.com (Kevin Looney)
Date: Wed, 15 Jun 2016 11:21:53 -0700
Subject: [ASM Tools] For review: disable javadoc lint check
In-Reply-To: <15912224-d129-dacb-fb30-ef05baf7be03@Oracle.COM>
References: <15912224-d129-dacb-fb30-ef05baf7be03@Oracle.COM>
Message-ID: <1dfa0329-933e-6e63-86cf-c9f266b79bca@oracle.com>

Thanks Brian.   This looks fine.

Can you please file a bug against AsmTools to describe what needs to be 
changed in the source to make doclint happy?

Thanks,
Kevin

On 6/15/16 10:54 AM, Brian Kurotsuchi wrote:
> Another quick review.  Now that we upgraded to Java 8, the automatic 
> lint checking is broken.  This disables it until we fix the sources.
>
>
>
> work at Banana~/asm/asmtools-os/build> hg diff build.xml
> diff --git a/build/build.xml b/build/build.xml
> --- a/build/build.xml
> +++ b/build/build.xml
> @@ -296,7 +296,7 @@
>              destdir="${build.javadoc.dir}"
>              author="false"
>              version="false"
> -            additionalparam="-breakiterator"
> +            additionalparam="-breakiterator -Xdoclint:none"
>          >
>              <classpath>
>                  <path path="${javac.classpath}"/>
>


-- 
kevin.looney at oracle.com


From brian.kurotsuchi at oracle.com  Wed Jun 15 18:47:38 2016
From: brian.kurotsuchi at oracle.com (brian.kurotsuchi at oracle.com)
Date: Wed, 15 Jun 2016 18:47:38 +0000
Subject: hg: code-tools/asmtools: Disable javadoc lint until we fix the
	sources.
Message-ID: <201606151847.u5FIldcn023609@aojmv0008.oracle.com>

Changeset: 00021c8bcd23
Author:    bkurotsu
Date:      2016-06-15 12:47 -0600
URL:       http://hg.openjdk.java.net/code-tools/asmtools/rev/00021c8bcd23

Disable javadoc lint until we fix the sources.
See CODETOOLS-7901700
Reviewed by: klooney

! build/build.xml


From Brian.Kurotsuchi at Oracle.COM  Wed Jun 15 18:50:23 2016
From: Brian.Kurotsuchi at Oracle.COM (Brian Kurotsuchi)
Date: Wed, 15 Jun 2016 12:50:23 -0600
Subject: [ASM Tools] For review: disable javadoc lint check
In-Reply-To: <1dfa0329-933e-6e63-86cf-c9f266b79bca@oracle.com>
References: <15912224-d129-dacb-fb30-ef05baf7be03@Oracle.COM>
	<1dfa0329-933e-6e63-86cf-c9f266b79bca@oracle.com>
Message-ID: <65f1875b-2eae-dc07-325c-bfb4f28fe6b3@Oracle.COM>

Done.  Created CODETOOLS-7901700 
<https://bugs.openjdk.java.net/browse/CODETOOLS-7901700>

On 6/15/16 12:21 PM, Kevin Looney wrote:
> diff --git a/build/build.xml b/build/build.xml
> --- a/build/build.xml
> +++ b/build/build.xml
> @@ -296,7 +296,7 @@
>              destdir="${build.javadoc.dir}"
>              author="false"
>              version="false"
> -            additionalparam="-breakiterator"
> +            additionalparam="-breakiterator -Xdoclint:none"
>          >
>              <classpath>
>                  <path path="${javac.classpath}"/>