REVIEW REQUEST: asmtools.jar manifest changes
Brian Kurotsuchi
Brian.Kurotsuchi at Oracle.COM
Fri Jun 10 20:35:24 UTC 2016
Simple addition of version and other basic info. Quick and dirty review
for a simple change.
Side note - I noticed that the product doesn't build cleanly on JDK 8
(similar to JT Harness) because of Javadoc lint checking - requires
addition of -Xdoclint:none flag until we clean the sources (diff for
that not included).
Brian
work at Banana~/asm/asmtools-os/build> hg diff build.xml
diff -r f201bb903e32 build/build.xml
--- a/build/build.xml Wed Mar 02 14:00:55 2016 -0700
+++ b/build/build.xml Fri Jun 10 14:31:28 2016 -0600
@@ -238,6 +238,10 @@
basedir="${build.classes.dir}">
<manifest>
<attribute name="Main-Class"
value="org.openjdk.asmtools.Main"/>
+ <attribute name="Implementation-Title"
value="${PRODUCT_NAME_LONG}"/>
+ <attribute name="Implementation-Version"
value="${PRODUCT_VERSION}"/>
+ <attribute name="Build-Version"
value="${PRODUCT_VERSION}"/>
+ <attribute name="Build-Number"
value="${PRODUCT_BUILDNUMBER}"/>
</manifest>
</jar>
</target>
*Results in:*
work at Bananaasm/asmtools-6.0-build/binaries/lib> cat META-INF/MANIFEST.MF
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.9.7
Created-By: 1.8.0_92-b14 (Oracle Corporation)
Main-Class: org.openjdk.asmtools.Main
Implementation-Title: Java Assembler Tools
Implementation-Version: 6.0
Build-Version: 6.0
Build-Number: b01
More information about the asmtools-dev
mailing list