From lkuskov at openjdk.java.net Wed Jun 3 03:00:18 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 3 Jun 2020 03:00:18 GMT Subject: RFR: 7902686: Jasm incorrectly sets up the SourceFile attribute on Windows platform Message-ID: <5lIxWvQi9E9CfLz_t6QobTZDDXWorr_KApph2Km7b4M=.2b069720-414a-4345-b26d-19b93c9ad1fa@github.com> The simple fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902686 that uses the NIO2 API to calculate a file name for the SourceFile attribute. ------------- Commit messages: - 7902686: Jasm incorrectly sets up the SourceFile attribute on Windows platform - 7902681: Asmtools build fails if Default Java File Encoding is set to ASCII - Merge branch 'CODETOOLS-7902659' - Merge branch 'CODETOOLS-7902660' - 7902659: Correct unconditional call of System.exit in printVersion (Main.java) - 7902660: jdis includes unnecessary Field references in MethodHandle parameters while printing static params of a bsm and skips the method tag in ldc# instructions Changes: https://git.openjdk.java.net/asmtools/pull/5/files Webrev: https://webrevs.openjdk.java.net/asmtools/5/webrev.00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902686 Stats: 13 lines in 3 files changed: 5 ins; 2 del; 6 mod Patch: https://git.openjdk.java.net/asmtools/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/asmtools pull/5/head:pull/5 PR: https://git.openjdk.java.net/asmtools/pull/5 From lkuskov at openjdk.java.net Wed Jun 3 22:08:26 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 3 Jun 2020 22:08:26 GMT Subject: [Rev 01] RFR: 7902686: Jasm incorrectly sets up the SourceFile attribute on Windows platform In-Reply-To: <5lIxWvQi9E9CfLz_t6QobTZDDXWorr_KApph2Km7b4M=.2b069720-414a-4345-b26d-19b93c9ad1fa@github.com> References: <5lIxWvQi9E9CfLz_t6QobTZDDXWorr_KApph2Km7b4M=.2b069720-414a-4345-b26d-19b93c9ad1fa@github.com> Message-ID: > The simple fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902686 that > uses the NIO2 API to calculate a file name for the SourceFile attribute. Leonid Kuskov has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 7902686: Jasm incorrectly sets up the SourceFile attribute on Windows platform ------------- Changes: - all: https://git.openjdk.java.net/asmtools/pull/5/files - new: https://git.openjdk.java.net/asmtools/pull/5/files/4e58a743..6b13b4f8 Webrevs: - full: https://webrevs.openjdk.java.net/asmtools/5/webrev.01 - incr: https://webrevs.openjdk.java.net/asmtools/5/webrev.00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/asmtools/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/asmtools pull/5/head:pull/5 PR: https://git.openjdk.java.net/asmtools/pull/5 From lkuskov at openjdk.java.net Wed Jun 3 22:19:54 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Wed, 3 Jun 2020 22:19:54 GMT Subject: [Integrated] RFR: 7902686: Jasm incorrectly sets up the SourceFile attribute on Windows platform In-Reply-To: <5lIxWvQi9E9CfLz_t6QobTZDDXWorr_KApph2Km7b4M=.2b069720-414a-4345-b26d-19b93c9ad1fa@github.com> References: <5lIxWvQi9E9CfLz_t6QobTZDDXWorr_KApph2Km7b4M=.2b069720-414a-4345-b26d-19b93c9ad1fa@github.com> Message-ID: On Wed, 3 Jun 2020 02:53:46 GMT, Leonid Kuskov wrote: > The simple fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902686 that > uses the NIO2 API to calculate a file name for the SourceFile attribute. This pull request has now been integrated. Changeset: 656d1052 Author: Leonid Kuskov URL: https://git.openjdk.java.net/asmtools/commit/656d1052 Stats: 6 lines in 2 files changed: 2 ins; 1 del; 3 mod 7902686: Jasm incorrectly sets up the SourceFile attribute on Windows platform ------------- PR: https://git.openjdk.java.net/asmtools/pull/5 From lkuskov at openjdk.java.net Thu Jun 4 00:56:58 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Thu, 4 Jun 2020 00:56:58 GMT Subject: RFR: 7902688: Asmtools support for JEP 360: changing the name from SealedTypes to SealedClasses Message-ID: This is the trivial fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902688 All "PermittedSubtypes" names, identifiers and types have been changed to "PermittedSubclasses" ------------- Commit messages: - 7902688: Asmtools support for JEP 360: changing the name from SealedTypes to SealedClasses - 7902686: Jasm incorrectly sets up the SourceFile attribute on Windows platform - 7902681: Asmtools build fails if Default Java File Encoding is set to ASCII - Merge branch 'CODETOOLS-7902659' - Merge branch 'CODETOOLS-7902660' - 7902659: Correct unconditional call of System.exit in printVersion (Main.java) - 7902660: jdis includes unnecessary Field references in MethodHandle parameters while printing static params of a bsm and skips the method tag in ldc# instructions Changes: https://git.openjdk.java.net/asmtools/pull/6/files Webrev: https://webrevs.openjdk.java.net/asmtools/6/webrev.00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7902688 Stats: 236 lines in 16 files changed: 95 ins; 92 del; 49 mod Patch: https://git.openjdk.java.net/asmtools/pull/6.diff Fetch: git fetch https://git.openjdk.java.net/asmtools pull/6/head:pull/6 PR: https://git.openjdk.java.net/asmtools/pull/6 From lkuskov at openjdk.java.net Thu Jun 4 01:49:43 2020 From: lkuskov at openjdk.java.net (Leonid Kuskov) Date: Thu, 4 Jun 2020 01:49:43 GMT Subject: [Integrated] RFR: 7902688: Asmtools support for JEP 360: changing the name from SealedTypes to SealedClasses In-Reply-To: References: Message-ID: <2PKT_1D3fGUSZ0bVblzFR1ACbhhkqJk2cbTNtXGkQy0=.2d818ecc-a7d6-4a2d-b820-210784f0f493@github.com> On Thu, 4 Jun 2020 00:51:06 GMT, Leonid Kuskov wrote: > This is the trivial fix for https://bugs.openjdk.java.net/browse/CODETOOLS-7902688 > All "PermittedSubtypes" names, identifiers and types have been changed to "PermittedSubclasses" This pull request has now been integrated. Changeset: 176446ee Author: Leonid Kuskov URL: https://git.openjdk.java.net/asmtools/commit/176446ee Stats: 221 lines in 13 files changed: 90 ins; 90 del; 41 mod 7902688: Asmtools support for JEP 360: changing the name from SealedTypes to SealedClasses ------------- PR: https://git.openjdk.java.net/asmtools/pull/6