RFR: Created maven binding to make easy maven integration

Leonid Kuskov lkuskov at openjdk.java.net
Wed Jan 20 18:34:57 UTC 2021


On Fri, 15 Jan 2021 12:02:21 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> Simplest maven wrapper without any duplicated code (with hardcoded version) to allow simple asmtools usage via maven depndencies. The namespace (org.openjdk) is same as for JMH
>
> You can see, that jcheck failed with "Symbolic links are not allowed (file: maven/src/main/resources/org/openjdk/asmtools/util/productinfo.properties)". Where productinfo.properties is probably not important the test ishsowing just tip of the iceberg - the maven binding, relayes on symlinks.
> I'm aware it is then linux only, but that why I set "unsupported maven wrapper.." into description.
> If the symlinks are really no-go, then I would probably repalce the pom.xml by shell script, screting symlinks and pom on the fly. That can be later extended with batch file, which will copy the files instead of linking.
> Small advantage is, that in this case I can read the version from build/productinfo.properties
> What is your preference?

Since this project belongs to openjdk we have to follow its rules. Thus it would be good to resolve conflict in the proper way that is good for openjdk and you.  Actually, maven/src/.../util/productinfo.properties is just template that is added to a product image once it's written out. Please use  the resource build/productinfo.properties for maven purposes.

-------------

PR: https://git.openjdk.java.net/asmtools/pull/15


More information about the asmtools-dev mailing list