RFR: Created maven binding to make easy maven integration

[Leonid Kuskov]

On Sat, 16 Jan 2021 09:44:09 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> Since this project belongs to openjdk we have to follow its rules. Thus it would be good to resolve conflict in the proper way that is good for openjdk and you.  Actually, maven/src/.../util/productinfo.properties is just template that is added to a product image once it's written out. Please use  the resource build/productinfo.properties for maven purposes.
>
>> Since this project belongs to openjdk we have to follow its rules. Thus it would be good to resolve conflict in the proper way that is good for openjdk and you. Actually, maven/src/.../util/productinfo.properties is just template that is added to a product image once it's written out. Please use the resource build/productinfo.properties for maven purposes.
> 
> Oh. Good catch. For now I had switched the link to point to correct ProductInfo.java  from build directory.
> 
> As for the symlinks x wrapper, I do not have strong preference. I would like to add maven binding, as it will simplify integration in maven projects using jasm/jcoder as depndece really a lot, and I'm vearry happy that you are not aginst the idea.  I think the symlinks are a bit better as they are very direct. If the openjdk rules forbids them, or you are uneasy with them as a master of asmtools, then I will rework the symlinks+pom.xml to pom.xml.in and mvwarpper.sh.
> The mvn wrapper will be then responsible to set up symlinks (on posix machines) and generate pom.xml.  Final experience will be aprox same. Also the small advantage of including data from productinfo.properties to pom.xml would be there. I will be unable to provide windows wrapper, but from that point of view it is same as symlinks.
> 
> Of course if you have any other suggestion, I will be happy to follow.

> _I will rework the symlinks+pom.xml to pom.xml.in and mvwarpper.sh.
> The mvn wrapper will be then responsible to set up symlinks (on posix machines) and generate pom.xml. Final experience 
> will be aprox same. Also the small advantage of including data from productinfo.properties to pom.xml would be there._


Sounds good. Please integrate your changes I will be a sponsor for them

-------------

PR: https://git.openjdk.java.net/asmtools/pull/15