From jvanek at openjdk.java.net  Tue Jun  1 12:46:38 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 1 Jun 2021 12:46:38 GMT
Subject: RFR: Javadoc and sources
Message-ID: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>

To proceed with release to maven repositories, source and javadoc jars are mandatory. Thus adding the,

-------------

Commit messages:
 - Added generation of maven source jar
 - Added maven javadoc generation

Changes: https://git.openjdk.java.net/asmtools/pull/19/files
 Webrev: https://webrevs.openjdk.java.net/?repo=asmtools&pr=19&range=00
  Stats: 34 lines in 2 files changed: 33 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/asmtools/pull/19.diff
  Fetch: git fetch https://git.openjdk.java.net/asmtools pull/19/head:pull/19

PR: https://git.openjdk.java.net/asmtools/pull/19

From jvanek at openjdk.java.net  Tue Jun  1 13:27:50 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 1 Jun 2021 13:27:50 GMT
Subject: RFR: Javadoc and sources [v2]
In-Reply-To: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
References: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
Message-ID: <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>

> To proceed with release to maven repositories, source and javadoc jars are mandatory. Thus adding the,

Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:

  Aligning groupId and artifactId to be more like other openjdk projects

-------------

Changes:
  - all: https://git.openjdk.java.net/asmtools/pull/19/files
  - new: https://git.openjdk.java.net/asmtools/pull/19/files/616062c0..584b86bb

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=asmtools&pr=19&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=asmtools&pr=19&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.java.net/asmtools/pull/19.diff
  Fetch: git fetch https://git.openjdk.java.net/asmtools pull/19/head:pull/19

PR: https://git.openjdk.java.net/asmtools/pull/19

From jvanek at openjdk.java.net  Tue Jun  1 13:27:51 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 1 Jun 2021 13:27:51 GMT
Subject: RFR: Javadoc and sources
In-Reply-To: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
References: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
Message-ID: <hlTWtbB7eXO6XenwA2MFewoxKwi6GUj46tUYLyQFW9g=.9a11ba26-ca25-4da0-b54e-3ab2ed89c8a6@github.com>

On Tue, 1 Jun 2021 12:42:20 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> To proceed with release to maven repositories, source and javadoc jars are mandatory. Thus adding the,

I do not lihe last commit, but the new naming resulting to 

repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea.jar
repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea.pom
repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea-javadoc.jar
repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea-sources.jar

is more like the other members of eg: https://repo1.maven.org/maven2/org/openjdk/

-------------

PR: https://git.openjdk.java.net/asmtools/pull/19

From lkuskov at openjdk.java.net  Wed Jun  2 04:23:35 2021
From: lkuskov at openjdk.java.net (Leonid Kuskov)
Date: Wed, 2 Jun 2021 04:23:35 GMT
Subject: RFR: Javadoc and sources [v2]
In-Reply-To: <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>
References: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
 <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>
Message-ID: <N8Vk_RrNtkheYuuXrn5_iQFxAVRAozD06xXOhJi3Q90=.f62479b6-bbb2-44a2-8499-dbccdbafd577@github.com>

On Tue, 1 Jun 2021 13:27:50 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> To proceed with release to maven repositories, source and javadoc jars are mandatory. Thus adding the,
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Aligning groupId and artifactId to be more like other openjdk projects

Looks good. There is just one comment: do we need the suffix "core" for tagging asmtools jars. Actually asmtools doesn't have plugins, extra libraries or something else to emphasize meaning of core API.

-------------

PR: https://git.openjdk.java.net/asmtools/pull/19

From jvanek at openjdk.java.net  Wed Jun  2 06:58:37 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 2 Jun 2021 06:58:37 GMT
Subject: RFR: Javadoc and sources [v2]
In-Reply-To: <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>
References: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
 <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>
Message-ID: <cLN1VY6DC73xJ2TgkOBvqk1DMjjxBplficy5N86NI9k=.051517f9-4698-4191-a592-49d09c7020b6@github.com>

On Tue, 1 Jun 2021 13:27:50 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> To proceed with release to maven repositories, source and javadoc jars are mandatory. Thus adding the,
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Aligning groupId and artifactId to be more like other openjdk projects

Thank you very much for bringing it up, as - to be honest - I really do not have clear preference.  Afaik, the initial group of org.openjdk and artifact asmtools, was the most correct one. But as OpenJDK is huge, and consists not only from subprojects, but also from subbgroups org.openjdk.{jmh,nashorn,...,asmtools} gave somehow sense too. That lead to artifact of asmtools in group org.openjkd.asmtools - which is terrible.  Looking to the above m2 repo, then org.openjdk.project + project-something, where each, even singlelibray one (eg: https://repo1.maven.org/maven2/org/openjdk/nashorn/ ) have the core suffix.  Thus, the org.openjdk.asmtools with artifact asmtools-core, sounded most aligned and more extensible and more readable and more clear on first sight then just artifact of asmtools.

However, I will follow your knowledge. I agree with all three names:
 * org.openjkd+asmtools
 * org.openjkd.asmtools+asmtools
 * org.openjkd.asmtools+asmtools-core

But asmtools shouldl follow the schema of  other openjdk projects in maven repo.

-------------

PR: https://git.openjdk.java.net/asmtools/pull/19

From lkuskov at openjdk.java.net  Wed Jun  2 17:55:37 2021
From: lkuskov at openjdk.java.net (Leonid Kuskov)
Date: Wed, 2 Jun 2021 17:55:37 GMT
Subject: RFR: Javadoc and sources [v2]
In-Reply-To: <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>
References: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
 <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>
Message-ID: <d_ivR9No-7T9Glv93b4jyeZGwliSTqaN5VOlC25Ofvc=.81c9e92d-6e32-4861-9bf2-03ba72a2cbc2@github.com>

On Tue, 1 Jun 2021 13:27:50 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> To proceed with release to maven repositories, source and javadoc jars are mandatory. Thus adding the,
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Aligning groupId and artifactId to be more like other openjdk projects

Thank you for the explanation - sounds reasonable. Please integrate this variant: 
repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea.jar
repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea.pom
repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea-javadoc.jar
repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea-sources.jar

-------------

PR: https://git.openjdk.java.net/asmtools/pull/19

From jvanek at openjdk.java.net  Wed Jun  2 18:05:37 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 2 Jun 2021 18:05:37 GMT
Subject: RFR: Javadoc and sources [v2]
In-Reply-To: <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>
References: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
 <5_ODG3BAIq7d8bTKo40n9S5hwDH91u6gGIRtlWASKkE=.541485b0-cb17-480f-bfae-244cd56dfdc1@github.com>
Message-ID: <DBUBUMPIdwfzyNgx_-yCdZ84YtXU7B21XOtwrvQTu84=.a4c823f1-76a8-45e3-bde0-7e508906bf5b@github.com>

On Tue, 1 Jun 2021 13:27:50 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> To proceed with release to maven repositories, source and javadoc jars are mandatory. Thus adding the,
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Aligning groupId and artifactId to be more like other openjdk projects

Youp, that is current implementation. Will I integrate then?

[INFO] --- maven-install-plugin:2.4:install (default-install) @ asmtools-core ---
[INFO] Installing /home/jvanek/git/asmtools/maven/target/asmtools-core-7.0.b10-ea.jar to /home/jvanek/.m2/repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea.jar
[INFO] Installing /home/jvanek/git/asmtools/maven/pom.xml to /home/jvanek/.m2/repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea.pom
[INFO] Installing /home/jvanek/git/asmtools/maven/target/asmtools-core-7.0.b10-ea-javadoc.jar to /home/jvanek/.m2/repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea-javadoc.jar
[INFO] Installing /home/jvanek/git/asmtools/maven/target/asmtools-core-7.0.b10-ea-sources.jar to /home/jvanek/.m2/repository/org/openjdk/asmtools/asmtools-core/7.0.b10-ea/asmtools-core-7.0.b10-ea-sources.jar

-------------

PR: https://git.openjdk.java.net/asmtools/pull/19

From lkuskov at openjdk.java.net  Tue Jun  8 18:28:09 2021
From: lkuskov at openjdk.java.net (Leonid Kuskov)
Date: Tue, 8 Jun 2021 18:28:09 GMT
Subject: git: openjdk/asmtools: Javadoc and sources
Message-ID: <cb45cf01-902d-425a-acdd-cb1f7d4c4120@openjdk.org>

Changeset: 818d959f
Author:    Ji?? Van?k <jvanek at openjdk.org>
Committer: Leonid Kuskov <lkuskov at openjdk.org>
Date:      2021-06-08 18:27:47 +0000
URL:       https://git.openjdk.java.net/asmtools/commit/818d959f04c099149da5c30be2944d0bcb320dda

Javadoc and sources

! maven/pom.xml.in
! src/org/openjdk/asmtools/jasm/TypeAnnotationTypes.java


From jvanek at openjdk.java.net  Tue Jun  8 18:30:23 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 8 Jun 2021 18:30:23 GMT
Subject: Integrated: Javadoc and sources
In-Reply-To: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
References: <rNHlB8Gzc_vPuaCFWu5nlMqWsCQGVdv4p58me3jwIO0=.e380adc4-7622-4aa6-85e2-e4cc3ca440fb@github.com>
Message-ID: <KHIB94FgAgsCNoxyRpBYpJzHG3QSLr5s3tlfKWlzteU=.f5c9954a-50a6-4070-8536-fe6bf45fb77c@github.com>

On Tue, 1 Jun 2021 12:42:20 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> To proceed with release to maven repositories, source and javadoc jars are mandatory. Thus adding the,

This pull request has now been integrated.

Changeset: 818d959f
Author:    Ji?? Van?k <jvanek at openjdk.org>
Committer: Leonid Kuskov <lkuskov at openjdk.org>
URL:       https://git.openjdk.java.net/asmtools/commit/818d959f04c099149da5c30be2944d0bcb320dda
Stats:     36 lines in 2 files changed: 33 ins; 0 del; 3 mod

Javadoc and sources

-------------

PR: https://git.openjdk.java.net/asmtools/pull/19

From jvanek at openjdk.java.net  Wed Jun  9 12:08:28 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 9 Jun 2021 12:08:28 GMT
Subject: RFR: Added gpg plugin and steps for release
Message-ID: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>

Usually the maven release plugin or gpg release plugin are working with direct access to repo - push change of versions, tag, do release, and again bump versions for next development cycle. As for asmtools, the maven is just secondary, unsupported release medium so I had opted for upload of locally finished binaries. Thus the manual ```mvn clean verify gpg:sign install:install deploy:deploy -DaltDeploymentRepository=ossrh::default::https://oss.sonatype.org/service/local/staging/deploy/maven2/ ```  command in pom comment. 
This may not be best, but for now it is the only way I found to upload locally created binaries. But I must admit, I'm not 100% sure in maven reelase or gpg plugins. During the next releases, maybe I will find something better.

As the PR is now, the asmtools artifacts are uploaded in staging maven central: https://oss.sonatype.org/content/repositories/orgopenjdkasmtools-1002/org/openjdk/asmtools/asmtools-core/

I had tested it and it works as expected (https://github.com/pmikova/java-runtime-decompiler/commit/d8b5a03759b9e8dfe584b0052778ff590ba6e82b).

One offtopic question  - the {slash}integrate and/or {slash}sponsor is autoamtically squashing commits?

-------------

Commit messages:
 - Added missing sonatype informations
 - Added gpg plugin and steps for release

Changes: https://git.openjdk.java.net/asmtools/pull/20/files
 Webrev: https://webrevs.openjdk.java.net/?repo=asmtools&pr=20&range=00
  Stats: 76 lines in 1 file changed: 72 ins; 3 del; 1 mod
  Patch: https://git.openjdk.java.net/asmtools/pull/20.diff
  Fetch: git fetch https://git.openjdk.java.net/asmtools pull/20/head:pull/20

PR: https://git.openjdk.java.net/asmtools/pull/20

From jvanek at openjdk.java.net  Wed Jun  9 12:08:28 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 9 Jun 2021 12:08:28 GMT
Subject: RFR: Added gpg plugin and steps for release
In-Reply-To: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
References: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
Message-ID: <uBJehdnr-0RAS2jQ6adF6h-VFOBA4q0FOSQLIo_rp_g=.f0d7d088-37f7-40fe-b95f-c8e0b6e4258a@github.com>

On Wed, 9 Jun 2021 12:03:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> Usually the maven release plugin or gpg release plugin are working with direct access to repo - push change of versions, tag, do release, and again bump versions for next development cycle. As for asmtools, the maven is just secondary, unsupported release medium so I had opted for upload of locally finished binaries. Thus the manual ```mvn clean verify gpg:sign install:install deploy:deploy -DaltDeploymentRepository=ossrh::default::https://oss.sonatype.org/service/local/staging/deploy/maven2/ ```  command in pom comment. 
> This may not be best, but for now it is the only way I found to upload locally created binaries. But I must admit, I'm not 100% sure in maven reelase or gpg plugins. During the next releases, maybe I will find something better.
> 
> As the PR is now, the asmtools artifacts are uploaded in staging maven central: https://oss.sonatype.org/content/repositories/orgopenjdkasmtools-1002/org/openjdk/asmtools/asmtools-core/
> 
> I had tested it and it works as expected (https://github.com/pmikova/java-runtime-decompiler/commit/d8b5a03759b9e8dfe584b0052778ff590ba6e82b).
> 
> One offtopic question  - the {slash}integrate and/or {slash}sponsor is autoamtically squashing commits?

I will move from staging to maven central once this PR is merged.

-------------

PR: https://git.openjdk.java.net/asmtools/pull/20

From lkuskov at openjdk.java.net  Wed Jun  9 18:24:19 2021
From: lkuskov at openjdk.java.net (Leonid Kuskov)
Date: Wed, 9 Jun 2021 18:24:19 GMT
Subject: RFR: Added gpg plugin and steps for release
In-Reply-To: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
References: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
Message-ID: <hzOrHcRQ3qiTOGaHXfqX7R62AN5_xeucFO6A1W6bCPE=.1a3157fc-01b2-4ed2-a427-f14d9f95dc10@github.com>

On Wed, 9 Jun 2021 12:03:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> Usually the maven release plugin or gpg release plugin are working with direct access to repo - push change of versions, tag, do release, and again bump versions for next development cycle. As for asmtools, the maven is just secondary, unsupported release medium so I had opted for upload of locally finished binaries. Thus the manual ```mvn clean verify gpg:sign install:install deploy:deploy -DaltDeploymentRepository=ossrh::default::https://oss.sonatype.org/service/local/staging/deploy/maven2/ ```  command in pom comment. 
> This may not be best, but for now it is the only way I found to upload locally created binaries. But I must admit, I'm not 100% sure in maven reelase or gpg plugins. During the next releases, maybe I will find something better.
> 
> As the PR is now, the asmtools artifacts are uploaded in staging maven central: https://oss.sonatype.org/content/repositories/orgopenjdkasmtools-1002/org/openjdk/asmtools/asmtools-core/
> 
> I had tested it and it works as expected (https://github.com/pmikova/java-runtime-decompiler/commit/d8b5a03759b9e8dfe584b0052778ff590ba6e82b).
> 
> One offtopic question  - the {slash}integrate and/or {slash}sponsor is autoamtically squashing commits?

Looks good. I'll be a sponsor for your integration. The OpenJDK repos were initialized with options: 
Setting Options: Merge button ? Only allow squash merging
Settings General Merge Request: Squash commits when merging ? Encourage

-------------

PR: https://git.openjdk.java.net/asmtools/pull/20

From jvanek at openjdk.java.net  Thu Jun 10 16:13:18 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Thu, 10 Jun 2021 16:13:18 GMT
Subject: Integrated: Added gpg plugin and steps for release
In-Reply-To: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
References: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
Message-ID: <SnUj_dd4oSCU71q9lV9z0H5cd84l3XOQfx2fX9eqfHs=.5f825b0e-87fd-4745-8326-76f2c4cfb538@github.com>

On Wed, 9 Jun 2021 12:03:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> Usually the maven release plugin or gpg release plugin are working with direct access to repo - push change of versions, tag, do release, and again bump versions for next development cycle. As for asmtools, the maven is just secondary, unsupported release medium so I had opted for upload of locally finished binaries. Thus the manual ```mvn clean verify gpg:sign install:install deploy:deploy -DaltDeploymentRepository=ossrh::default::https://oss.sonatype.org/service/local/staging/deploy/maven2/ ```  command in pom comment. 
> This may not be best, but for now it is the only way I found to upload locally created binaries. But I must admit, I'm not 100% sure in maven reelase or gpg plugins. During the next releases, maybe I will find something better.
> 
> As the PR is now, the asmtools artifacts are uploaded in staging maven central: https://oss.sonatype.org/content/repositories/orgopenjdkasmtools-1002/org/openjdk/asmtools/asmtools-core/
> 
> I had tested it and it works as expected (https://github.com/pmikova/java-runtime-decompiler/commit/d8b5a03759b9e8dfe584b0052778ff590ba6e82b).
> 
> One offtopic question  - the {slash}integrate and/or {slash}sponsor is autoamtically squashing commits?

This pull request has now been integrated.

Changeset: f40a2c01
Author:    Ji?? Van?k <jvanek at openjdk.org>
Committer: Leonid Kuskov <lkuskov at openjdk.org>
URL:       https://git.openjdk.java.net/asmtools/commit/f40a2c014cfd32eb6cc1e1c6c4264a0411fe0415
Stats:     76 lines in 1 file changed: 72 ins; 3 del; 1 mod

Added gpg plugin and steps for release

-------------

PR: https://git.openjdk.java.net/asmtools/pull/20

From jvanek at openjdk.java.net  Fri Jun 11 09:09:56 2021
From: jvanek at openjdk.java.net (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 11 Jun 2021 09:09:56 GMT
Subject: RFR: Added gpg plugin and steps for release
In-Reply-To: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
References: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
Message-ID: <G5CE4hK5vWT-6SEkPS9Q02pGjihCddOHEQAK37BNorY=.6f979d08-ca77-43a4-9438-e661900a23ac@github.com>

On Wed, 9 Jun 2021 12:03:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> Usually the maven release plugin or gpg release plugin are working with direct access to repo - push change of versions, tag, do release, and again bump versions for next development cycle. As for asmtools, the maven is just secondary, unsupported release medium so I had opted for upload of locally finished binaries. Thus the manual ```mvn clean verify gpg:sign install:install deploy:deploy -DaltDeploymentRepository=ossrh::default::https://oss.sonatype.org/service/local/staging/deploy/maven2/ ```  command in pom comment. 
> This may not be best, but for now it is the only way I found to upload locally created binaries. But I must admit, I'm not 100% sure in maven reelase or gpg plugins. During the next releases, maybe I will find something better.
> 
> As the PR is now, the asmtools artifacts are uploaded in staging maven central: https://oss.sonatype.org/content/repositories/orgopenjdkasmtools-1002/org/openjdk/asmtools/asmtools-core/
> 
> I had tested it and it works as expected (https://github.com/pmikova/java-runtime-decompiler/commit/d8b5a03759b9e8dfe584b0052778ff590ba6e82b).
> 
> One offtopic question  - the {slash}integrate and/or {slash}sponsor is autoamtically squashing commits?

TY!

here we go:
https://repo1.maven.org/maven2/org/openjdk/asmtools/asmtools-core/
https://oss.sonatype.org/#nexus-search;quick~asmtools
To bubble to: https://mvnrepository.com/artifact/org.openjdk will take few hours, mayube days.  But the artifact is already usable. 

Thanx  for support!

-------------

PR: https://git.openjdk.java.net/asmtools/pull/20

From lkuskov at openjdk.java.net  Fri Jun 11 23:00:55 2021
From: lkuskov at openjdk.java.net (Leonid Kuskov)
Date: Fri, 11 Jun 2021 23:00:55 GMT
Subject: RFR: Added gpg plugin and steps for release
In-Reply-To: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
References: <ZnCOijqMMnk0iZOTK3ZUDL6RLNByNK_ksIUofskt5z0=.a6311579-dde2-4eec-badf-f5ec1265a428@github.com>
Message-ID: <qLWdm0k3tHeehOCKw5r5dgpF6ho6mHklTMb-AFr11qA=.d6b99f3e-0fcf-401a-867a-5c5151fdd7dd@github.com>

On Wed, 9 Jun 2021 12:03:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> Usually the maven release plugin or gpg release plugin are working with direct access to repo - push change of versions, tag, do release, and again bump versions for next development cycle. As for asmtools, the maven is just secondary, unsupported release medium so I had opted for upload of locally finished binaries. Thus the manual ```mvn clean verify gpg:sign install:install deploy:deploy -DaltDeploymentRepository=ossrh::default::https://oss.sonatype.org/service/local/staging/deploy/maven2/ ```  command in pom comment. 
> This may not be best, but for now it is the only way I found to upload locally created binaries. But I must admit, I'm not 100% sure in maven reelase or gpg plugins. During the next releases, maybe I will find something better.
> 
> As the PR is now, the asmtools artifacts are uploaded in staging maven central: https://oss.sonatype.org/content/repositories/orgopenjdkasmtools-1002/org/openjdk/asmtools/asmtools-core/
> 
> I had tested it and it works as expected (https://github.com/pmikova/java-runtime-decompiler/commit/d8b5a03759b9e8dfe584b0052778ff590ba6e82b).
> 
> One offtopic question  - the {slash}integrate and/or {slash}sponsor is autoamtically squashing commits?

Great news!
Thank you,
Leonid

From: judovana ***@***.***>
Reply-To: openjdk/asmtools ***@***.***>
Date: Friday, June 11, 2021 at 2:07 AM
To: openjdk/asmtools ***@***.***>
Cc: Leonid Kuskov ***@***.***>, Mention ***@***.***>
Subject: [External] : Re: [openjdk/asmtools] Added gpg plugin and steps for release (#20)


TY!

here we go:
https://repo1.maven.org/maven2/org/openjdk/asmtools/asmtools-core/<https://urldefense.com/v3/__https:/repo1.maven.org/maven2/org/openjdk/asmtools/asmtools-core/__;!!GqivPVa7Brio!LYIrV2RfIJd8gm2l0WRYsgpPO4lZ-3M_134ZF4K7Qt9MeM9i7NrnaAlaNpkFqIJLtcQ$>
https://oss.sonatype.org/#nexus-search;quick~asmtools<https://urldefense.com/v3/__https:/oss.sonatype.org/*nexus-search;quick*asmtools__;I34!!GqivPVa7Brio!LYIrV2RfIJd8gm2l0WRYsgpPO4lZ-3M_134ZF4K7Qt9MeM9i7NrnaAlaNpkFwaOH4HQ$>
To bubble to: https://mvnrepository.com/artifact/org.openjdk<https://urldefense.com/v3/__https:/mvnrepository.com/artifact/org.openjdk__;!!GqivPVa7Brio!LYIrV2RfIJd8gm2l0WRYsgpPO4lZ-3M_134ZF4K7Qt9MeM9i7NrnaAlaNpkFZqqHMR0$> will take few hours, mayube days. But the artifact is already usable.

Thanx for support!

?
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/openjdk/asmtools/pull/20*issuecomment-859409182__;Iw!!GqivPVa7Brio!LYIrV2RfIJd8gm2l0WRYsgpPO4lZ-3M_134ZF4K7Qt9MeM9i7NrnaAlaNpkFfMl-27M$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AB34ASBSGNVXOYBK4MVVZN3TSHG6JANCNFSM46L4WPBQ__;!!GqivPVa7Brio!LYIrV2RfIJd8gm2l0WRYsgpPO4lZ-3M_134ZF4K7Qt9MeM9i7NrnaAlaNpkFFHHggyo$>.

-------------

PR: https://git.openjdk.java.net/asmtools/pull/20