RFR: adding support for stdin [v4]

Jiří Vaněk jvanek at openjdk.org
Sun Aug 21 15:38:48 UTC 2022


On Sun, 21 Aug 2022 15:28:28 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> Now Added support for stdin in jdis. Before merging, I would like to add support to all four (not sure with jcdec) tools.
>> This PR serves for early feedback in approach. Hintsvery  welcomed. 
>> 
>> I personally miss stdin support in this toolchain. Also I think, that for any (test) wrapper, stdin will be much more comfortable then constantly create tmp files
>> 
>> As for the possibel future (test) wrapper, most likely custom stream implementation of ToolInput will arrive sooner or later.
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed jdis specific missleading provide method

I think the -g output can not be compiled yet again :(  The test which disassebbles and assembels and load whole freshly built asmtools (as  https://github.com/openjdk/asmtools/pull/27 ) with both -g and withotu is strictly encessary.
How much should I care about jcdec?

In similar way I woudl like to rework also stdout handling - to made asmtools reusabel in other projects, the strict depndece on files must be removed.

-------------

PR: https://git.openjdk.org/asmtools/pull/32


More information about the asmtools-dev mailing list