RFR: adding support for stdin [v11]
Leonid Kuskov
lkuskov at openjdk.org
Tue Aug 23 17:23:47 UTC 2022
On Tue, 23 Aug 2022 15:45:52 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> Now Added support for stdin in jdis. Before merging, I would like to add support to all four (not sure with jcdec) tools.
>> This PR serves for early feedback in approach. Hintsvery welcomed.
>>
>> I personally miss stdin support in this toolchain. Also I think, that for any (test) wrapper, stdin will be much more comfortable then constantly create tmp files
>>
>> As for the possibel future (test) wrapper, most likely custom stream implementation of ToolInput will arrive sooner or later.
>
> Jiří Vaněk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Added one more abstraction layer providing highly reusable byte[] based input
Yes, I agree the code in the jasm Parser isn't safe. Thank you for catching this. I've created the issue: https://bugs.openjdk.org/browse/CODETOOLS-7903259 If this stoped your works there is a short workaround rename g to g.jasm
-------------
PR: https://git.openjdk.org/asmtools/pull/32
More information about the asmtools-dev
mailing list