RFR: Revert 33 revert 32 stdin

Jiří Vaněk jvanek at openjdk.org
Wed Aug 24 08:18:35 UTC 2022


On Tue, 23 Aug 2022 22:38:29 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> After merging and testing I've found the following issue that I've missed before. 
> If I call jasm -version I will stuck with 
>>asm -version
>  Java Assembler Tools, version 8.0 ea 02 (August 23, 2022). 
> 
> I.e. there is no sign that the tool is waiting for stdin. 
> 
> From my point of view there is the good vim solution: 
> Usage: vim [arguments] [file ..]       edit specified file(s)
>               or: vim [arguments] -          read text from stdin

The -version should not be stuck under all cases. I see the error i my code. Will fix.
As for the "-" for std in, I do not have strong preference. I usually prefer  direct stdin unless said otherwise, but it have its issues.

Isn't worthy to touch the master, and remove the revert and revert of revert?

-------------

PR: https://git.openjdk.org/asmtools/pull/34


More information about the asmtools-dev mailing list