Withdrawn: Unstuck version

Leonid Kuskov lkuskov at openjdk.org
Wed Aug 31 17:45:27 UTC 2022


On Wed, 24 Aug 2022 10:39:27 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

> Hello! This pr is solving - and is not - the hanged waiting for stdin for no file argument.
> 1) it properly exits after version is printed, thus is unaffected by any file arguments (and streams) which may change alter
> 2) it changes the Stream (and extending) input implemetation to lazily drain the stream once needed, not durign construction. TBH, I'm not sure with this change, but I was generally very unhappy  by draining the stream in cosntructor at all. This alone, would not solve the -version problem, because the StreamInput is added always, and thus is always processed, thus stdin is read no meter if it is lazy or in constructor.
> 
> This intentionally do not add the empty "-" switch. That may come later as needed.
> 
> Hints welcomed!

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/asmtools/pull/36


More information about the asmtools-dev mailing list