From lkuskov at openjdk.org Tue Nov 1 23:25:40 2022
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 1 Nov 2022 23:25:40 GMT
Subject: RFR: 7902888: Excess entries in BootstrapMethods with the same bsm,
bsmKind, bsmArgs
Message-ID: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
This is the fix for a regression made during the fix of [CODETOOLS-7902888]( https://bugs.openjdk.org/browse/CODETOOLS-7902888)
Also added extra methods to Main classes to allow working with external tools.
-------------
Commit messages:
- 7902888: Excess entries in BootstrapMethods with the same bsm, bsmKind, bsmArgs
Changes: https://git.openjdk.org/asmtools/pull/47/files
Webrev: https://webrevs.openjdk.org/?repo=asmtools&pr=47&range=00
Issue: https://bugs.openjdk.org/browse/CODETOOLS-7902888
Stats: 282 lines in 11 files changed: 186 ins; 38 del; 58 mod
Patch: https://git.openjdk.org/asmtools/pull/47.diff
Fetch: git fetch https://git.openjdk.org/asmtools pull/47/head:pull/47
PR: https://git.openjdk.org/asmtools/pull/47
From jvanek at openjdk.org Fri Nov 4 07:40:41 2022
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 4 Nov 2022 07:40:41 GMT
Subject: RFR: 7902888: Excess entries in BootstrapMethods with the same
bsm, bsmKind, bsmArgs
In-Reply-To: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
References: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
Message-ID:
On Tue, 1 Nov 2022 23:21:15 GMT, Leonid Kuskov wrote:
> This is the fix for a regression made during the fix of [CODETOOLS-7902888]( https://bugs.openjdk.org/browse/CODETOOLS-7902888)
> Also added extra methods to Main classes to allow working with external tools.
src/org/openjdk/asmtools/jcoder/Main.java line 118:
> 116:
> 117: // Run jcoder compiler with args
> 118: public synchronized boolean compile(String... argv) {
I like the compile method with args idea! Why it was done sudenly synchrornized! Whole asmtools are not thread safe, aren't they?
-------------
PR: https://git.openjdk.org/asmtools/pull/47
From jvanek at openjdk.org Fri Nov 4 07:44:43 2022
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 4 Nov 2022 07:44:43 GMT
Subject: RFR: 7902888: Excess entries in BootstrapMethods with the same
bsm, bsmKind, bsmArgs
In-Reply-To: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
References: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
Message-ID:
On Tue, 1 Nov 2022 23:21:15 GMT, Leonid Kuskov wrote:
> This is the fix for a regression made during the fix of [CODETOOLS-7902888]( https://bugs.openjdk.org/browse/CODETOOLS-7902888)
> Also added extra methods to Main classes to allow working with external tools.
Thanx for adding the deprecated main methods. I should have realised the original stream consumers will exists widely.
-------------
PR: https://git.openjdk.org/asmtools/pull/47
From jvanek at openjdk.org Fri Nov 4 07:49:44 2022
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 4 Nov 2022 07:49:44 GMT
Subject: RFR: 7902888: Excess entries in BootstrapMethods with the same
bsm, bsmKind, bsmArgs
In-Reply-To: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
References: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
Message-ID:
On Tue, 1 Nov 2022 23:21:15 GMT, Leonid Kuskov wrote:
> This is the fix for a regression made during the fix of [CODETOOLS-7902888]( https://bugs.openjdk.org/browse/CODETOOLS-7902888)
> Also added extra methods to Main classes to allow working with external tools.
btw, a uinittest for this would be around?
Maybe just publish minimalistic file, and I can add a reproducers for you on your behalf?
A unittest should be hard-to-opt out.
I had checked the two files in the 7902888 bug, but am not sure what to assert.
-------------
PR: https://git.openjdk.org/asmtools/pull/47
From lkuskov at openjdk.org Fri Nov 4 18:46:19 2022
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 4 Nov 2022 18:46:19 GMT
Subject: Withdrawn: 7902888: Excess entries in BootstrapMethods with the same
bsm, bsmKind, bsmArgs
In-Reply-To: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
References: <1kvEboZsBWJeGfDv-Viodn4UOKe5mQlR7dV22V7X4xo=.531f054a-62bf-4506-8de2-a11518f24972@github.com>
Message-ID:
On Tue, 1 Nov 2022 23:21:15 GMT, Leonid Kuskov wrote:
> This is the fix for a regression made during the fix of [CODETOOLS-7902888]( https://bugs.openjdk.org/browse/CODETOOLS-7902888)
> Also added extra methods to Main classes to allow working with external tools.
This pull request has been closed without being integrated.
-------------
PR: https://git.openjdk.org/asmtools/pull/47
From jvanek at openjdk.org Tue Nov 8 12:08:11 2022
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 8 Nov 2022 12:08:11 GMT
Subject: RFR: Fixed issue when jasm produced only one file from source with
multiple ones
Message-ID:
Added tests for this issue
Added test veryfying that the jcoder is not affected
-------------
Commit messages:
- Fixed issue when jasm produced only one file from source with multiple ones
Changes: https://git.openjdk.org/asmtools/pull/49/files
Webrev: https://webrevs.openjdk.org/?repo=asmtools&pr=49&range=00
Stats: 1049 lines in 8 files changed: 1044 ins; 4 del; 1 mod
Patch: https://git.openjdk.org/asmtools/pull/49.diff
Fetch: git fetch https://git.openjdk.org/asmtools pull/49/head:pull/49
PR: https://git.openjdk.org/asmtools/pull/49
From lkuskov at openjdk.org Tue Nov 8 18:42:25 2022
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 8 Nov 2022 18:42:25 GMT
Subject: RFR: Fixed issue when jasm produced only one file from source with
multiple ones
In-Reply-To:
References:
Message-ID:
On Tue, 8 Nov 2022 12:02:04 GMT, Ji?? Van?k wrote:
> Added tests for this issue
> Added test veryfying that the jcoder is not affected
LGTM
-------------
PR: https://git.openjdk.org/asmtools/pull/49
From lkuskov at openjdk.org Tue Nov 8 18:42:26 2022
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 8 Nov 2022 18:42:26 GMT
Subject: Withdrawn: Fixed issue when jasm produced only one file from source
with multiple ones
In-Reply-To:
References:
Message-ID:
On Tue, 8 Nov 2022 12:02:04 GMT, Ji?? Van?k wrote:
> Added tests for this issue
> Added test veryfying that the jcoder is not affected
This pull request has been closed without being integrated.
-------------
PR: https://git.openjdk.org/asmtools/pull/49