RFR: WIP repalce stdout by configurable object [v4]
Jiří Vaněk
jvanek at openjdk.org
Mon Sep 19 09:02:08 UTC 2022
On Mon, 19 Sep 2022 08:56:27 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> See https://github.com/openjdk/asmtools/pull/38 for full story
>> The PR will be enhanced by handling of two streams in compiler logger. Then the stdout work can continue.
>
> Jiří Vaněk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Replaced dualstream logger by wrapper
>
> so it can be later made fully customisable
Hi Leonid!
Can you take an eye? My next steps will be to add switch to jcod/jasm so they will use the original dual stream logging or not. Then I will add the stdout capability to jasm/jcod and will turn the dual stream logger off by default.
Last step may be to remove the dual stream logging. And that is the question on you. If you wish to keep the dual stream logging for compilers as optional, then - by current impl, the nasty prints/printe methods will remain. If you will be rather happy to remove dual stream logging completely, then the nasty prints/printe wil lbe gone. Actually whole unhappy DualStreamLogger will be gone, which sounds tempting.
I'm in favour of dropping it and log to stderr only, but it may break older consummers... so Most likley lets keep it optional, and remove in some far future?
-------------
PR: https://git.openjdk.org/asmtools/pull/44
More information about the asmtools-dev
mailing list