RFR: repalce stdout by configurable object [v8]
Jiří Vaněk
jvanek at openjdk.org
Wed Sep 21 13:08:56 UTC 2022
On Wed, 21 Sep 2022 12:21:56 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:
>> See https://github.com/openjdk/asmtools/pull/38 for full story
>> The PR will be enhanced by handling of two streams in compiler logger. Then the stdout work can continue.
>
> Jiří Vaněk has updated the pull request incrementally with one additional commit since the last revision:
>
> Fixed typo which casued behavior regression
>
> found by unittests
Hello!
The main refactoring is now done. I went a bit differently then I originally stated, as it somehow flown out out of the box
* all 4 tools now prints to stdout by default
* all 4 tools now support -d <dir>
* the dual stream logger is still the default one
Is it ok for you to start playing with it?
if not, then I will most likely go with the commit, which will return jasm and jcoder back to origianl "-d like" behavior by default, and have stdout only as secondary option - Still I think the current state, all 4 stdouting and honoring -d is better
In all cases, there are at lease still two commits pending
- made dual stream logger on deman only (otherwise be on single stream stderr logger only)
- if the single stream logger goes really well, then drop the dualstream, as it is confusing
- if there was not those nasty printlns/printlne, I would vote for keeping the dual loger as optional extension, as the original logging have it sense. But it may rot on long term
- prepare string and streeam based stdotu/stderr and add more tests; that will most likely lead to small clean up
-------------
PR: https://git.openjdk.org/asmtools/pull/44
More information about the asmtools-dev
mailing list