RFR: Refactored new ToolInput/Outputs so they reside in own packages and not in original interfaces

Jonathan Gibbons jjg at openjdk.org
Tue Jan 3 17:20:06 UTC 2023


On Tue, 3 Jan 2023 15:47:00 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

>> This PR is refactoring the long interfaces with many inner classes to logical packages.
>
> As promised earlier. I'm still hesitating with the usage of uEscWriter in string based inputs/outputs. Maybe do you have jasm/jdis class reproducer of possible issues?

@judovana How much is it useful is refactor the code like this?   Some of the refactored classes are very small.  How much do the subtypes have subtype-specific API that needs to be directly and publicly available, compared to methods that just implement or override behavior declared in the super type.

Would it be better to just hide the subtypes where possible, and have static factory methods in the supertypes, possibly setting up the use of sealed classes and `permits` down the road?

-------------

PR: https://git.openjdk.org/asmtools/pull/53


More information about the asmtools-dev mailing list