RFR: Refactored new ToolInput/Outputs so they reside in own packages and not in original interfaces

Jonathan Gibbons jjg at openjdk.org
Fri Jan 6 02:10:08 UTC 2023


On Tue, 3 Jan 2023 15:46:53 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

> This PR is refactoring the long interfaces with many inner classes to logical packages.

src/org/openjdk/asmtools/common/outputs/DirOutput.java line 59:

> 57:         } else {
> 58:             environment.traceln("writing -d " + dir.getPath());
> 59:             if (!fileSeparator.equals("/")) {

Minor implementation detail: the implementation of `replace` is a no-op if the two arguments are single character strings and equal.  So, there is no need for the external guard in the `if` statement.

-------------

PR: https://git.openjdk.org/asmtools/pull/53


More information about the asmtools-dev mailing list