From jvanek at openjdk.org  Wed Nov 15 11:50:07 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 15 Nov 2023 11:50:07 GMT
Subject: RFR: WIP - made maven resource plugin expclicit
Message-ID: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>

That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .bin sufix for test classes. The testclasses probably may, and should be .class, Another solution is to use mrp 2.6 which do not suffer the symlinks issue

In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

-------------

Commit messages:
 - made maven resource plugin expclicit

Changes: https://git.openjdk.org/asmtools/pull/68/files
 Webrev: https://webrevs.openjdk.org/?repo=asmtools&pr=68&range=00
  Stats: 44 lines in 4 files changed: 41 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/asmtools/pull/68.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/68/head:pull/68

PR: https://git.openjdk.org/asmtools/pull/68

From jvanek at openjdk.org  Wed Nov 15 11:50:07 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Wed, 15 Nov 2023 11:50:07 GMT
Subject: RFR: WIP - made maven resource plugin expclicit
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <IjziaIxbGGwkP21P-6s0Rd7pYgIaQnNOZ6NvR2onQ2Q=.dbeea121-d530-4453-95bb-9f52efcc0ba5@github.com>

On Wed, 15 Nov 2023 11:42:14 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .bin sufix for test classes. The testclasses probably may, and should be .class, Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

Please, do not merge yet.
The PR exists onlyh to let you know tham I'm (although terribly rarely) on the issue with maven bindings and resources.


Currently I would like to discuss a direction of this PR:
  - to move to maven-resources-plugin 2.6 and then the issue will be indeed gone
  - to stay on 3.x with filtering, as shown in this PR

AFAICT, to stay on 3.x is the only viable solution for future. if we agree on that, we can merge, because at least there is explicit maven plugin version.


However the filtered resources did not had the expected results. I need to dive into it one more times

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1812386574

From lkuskov at openjdk.org  Thu Nov 16 01:54:58 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Thu, 16 Nov 2023 01:54:58 GMT
Subject: RFR: WIP - made maven resource plugin expclicit
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <jQSPpAac75ZdVIgp9e7jMxImRTS3MpVdwfhar1EBWOM=.b44305a7-b8f2-4b28-bcb5-4557c92925b9@github.com>

On Wed, 15 Nov 2023 11:42:14 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .bin sufix for test classes. The testclasses probably may, and should be .class, Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

The second direction seems more preferable. Since there is no rush, it makes sense to integrate a comprehensive fix for this Maven-Git issue. Thank you very much.

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1813637497

From jvanek at openjdk.org  Thu Nov 16 14:09:09 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Thu, 16 Nov 2023 14:09:09 GMT
Subject: RFR: WIP - made maven resource plugin expclicit
In-Reply-To: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
References: <7hoL79BPQJ1fwPskzfgudWbXwZvBYvioVKucLhq-zcc=.d57020dc-6428-4d80-8d72-93c5d19d2f17@github.com>
Message-ID: <OJogGOD_MEMeO7lGTmKxAyPPqw_MMMxTnixq47ExbDk=.bdcf8a00-9255-42be-ad5d-b78672194b1a@github.com>

On Wed, 15 Nov 2023 11:42:14 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .class sufix for test classes.  Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

ok. ty!

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1814500033

From lkuskov at openjdk.org  Fri Nov 17 00:16:07 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 17 Nov 2023 00:16:07 GMT
Subject: Integrated: 7903582: jdis incorrectly processes a class compiled with
 the --enable-preview option
Message-ID: <zHVreEt2cXL-GZrTDJg55hxkTELKUl0om-vtcoOEjwA=.7bbc9cd4-c9dc-4b6c-9cda-756f46ba7518@github.com>

This is the fix for [CODETOOLS-7903582](https://bugs.openjdk.org/browse/CODETOOLS-7903582)

-------------

Commit messages:
 - 7903582: dis incorrectly processes a class compiled with the --enable-preview option

Changes: https://git.openjdk.org/asmtools/pull/69/files
 Webrev: https://webrevs.openjdk.org/?repo=asmtools&pr=69&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903582
  Stats: 68 lines in 7 files changed: 27 ins; 3 del; 38 mod
  Patch: https://git.openjdk.org/asmtools/pull/69.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/69/head:pull/69

PR: https://git.openjdk.org/asmtools/pull/69

From lkuskov at openjdk.org  Fri Nov 17 00:16:07 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Fri, 17 Nov 2023 00:16:07 GMT
Subject: Integrated: 7903582: jdis incorrectly processes a class compiled with
 the --enable-preview option
In-Reply-To: <zHVreEt2cXL-GZrTDJg55hxkTELKUl0om-vtcoOEjwA=.7bbc9cd4-c9dc-4b6c-9cda-756f46ba7518@github.com>
References: <zHVreEt2cXL-GZrTDJg55hxkTELKUl0om-vtcoOEjwA=.7bbc9cd4-c9dc-4b6c-9cda-756f46ba7518@github.com>
Message-ID: <7fzDVGiv58tuDQATm6d9wwbELA3E-22U-1i2L6qDqO0=.c013ebcb-503c-45e6-acdf-b16e996fd7fc@github.com>

On Fri, 17 Nov 2023 00:04:18 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> This is the fix for [CODETOOLS-7903582](https://bugs.openjdk.org/browse/CODETOOLS-7903582)

This pull request has now been integrated.

Changeset: 25f829b0
Author:    Leonid Kuskov <lkuskov at openjdk.org>
URL:       https://git.openjdk.org/asmtools/commit/25f829b0b06099b7a9038f4ea82b9449067c788f
Stats:     68 lines in 7 files changed: 27 ins; 3 del; 38 mod

7903582: jdis incorrectly processes a class compiled with the --enable-preview option

-------------

PR: https://git.openjdk.org/asmtools/pull/69

From lkuskov at openjdk.org  Mon Nov 20 21:16:47 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Mon, 20 Nov 2023 21:16:47 GMT
Subject: RFR: 7903588: asmtool can't be build by JDK 20 and above
Message-ID: <WIISEykhXf0iS9UDyrmP3pAP6xMc61dg-6MA0O2SqZM=.b1df0f56-f518-45ae-ae35-8836ab7f8e67@github.com>

This is a fix for [CODETOOLS-7903588](https://bugs.openjdk.org/browse/CODETOOLS-7903588)

-------------

Commit messages:
 - 7903588: asmtool can't be build by JDK 20 and above

Changes: https://git.openjdk.org/asmtools/pull/70/files
 Webrev: https://webrevs.openjdk.org/?repo=asmtools&pr=70&range=00
  Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903588
  Stats: 5 lines in 2 files changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/asmtools/pull/70.diff
  Fetch: git fetch https://git.openjdk.org/asmtools.git pull/70/head:pull/70

PR: https://git.openjdk.org/asmtools/pull/70

From lkuskov at openjdk.org  Mon Nov 20 21:21:38 2023
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Mon, 20 Nov 2023 21:21:38 GMT
Subject: Integrated: 7903588: asmtool can't be build by JDK 20 and above
In-Reply-To: <WIISEykhXf0iS9UDyrmP3pAP6xMc61dg-6MA0O2SqZM=.b1df0f56-f518-45ae-ae35-8836ab7f8e67@github.com>
References: <WIISEykhXf0iS9UDyrmP3pAP6xMc61dg-6MA0O2SqZM=.b1df0f56-f518-45ae-ae35-8836ab7f8e67@github.com>
Message-ID: <IfM-qE5-hCUa0BhblWOLMlyFdoEJX6C-OYzTqqzZq4M=.6529b477-4f47-4edd-a060-67db8293bb14@github.com>

On Mon, 20 Nov 2023 21:10:29 GMT, Leonid Kuskov <lkuskov at openjdk.org> wrote:

> This is a fix for [CODETOOLS-7903588](https://bugs.openjdk.org/browse/CODETOOLS-7903588)

This pull request has now been integrated.

Changeset: 949fb1df
Author:    Leonid Kuskov <lkuskov at openjdk.org>
URL:       https://git.openjdk.org/asmtools/commit/949fb1dfcc54fd5bffbda012fe689ff059999c9f
Stats:     5 lines in 2 files changed: 3 ins; 0 del; 2 mod

7903588: asmtool can't be build by JDK 20 and above

-------------

PR: https://git.openjdk.org/asmtools/pull/70