RFR: WIP - made maven resource plugin expclicit

Jiří Vaněk jvanek at openjdk.org
Wed Nov 15 11:50:07 UTC 2023


On Wed, 15 Nov 2023 11:42:14 GMT, Jiří Vaněk <jvanek at openjdk.org> wrote:

> That is still sufferign the https://issues.apache.org/jira/browse/MRESOURCES-237 so the filtering was done. Fitlering is excluding proeprties (as they claim they are ascii) and is adding .bin sufix for test classes. The testclasses probably may, and should be .class, Another solution is to use mrp 2.6 which do not suffer the symlinks issue
> 
> In both cases, the tests still fail in maven runs, although rummor is, manually it passes (todo, verify)

Please, do not merge yet.
The PR exists onlyh to let you know tham I'm (although terribly rarely) on the issue with maven bindings and resources.


Currently I would like to discuss a direction of this PR:
  - to move to maven-resources-plugin 2.6 and then the issue will be indeed gone
  - to stay on 3.x with filtering, as shown in this PR

AFAICT, to stay on 3.x is the only viable solution for future. if we agree on that, we can merge, because at least there is explicit maven plugin version.


However the filtered resources did not had the expected results. I need to dive into it one more times

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/68#issuecomment-1812386574


More information about the asmtools-dev mailing list