From jvanek at openjdk.org  Fri Feb 16 13:21:04 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 16 Feb 2024 13:21:04 GMT
Subject: RFR: added jdk21 to test matrix
In-Reply-To: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
References: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
Message-ID: <yQvb0NwAvFSjvof3nuNDogZqG9IWfP8ha7Wr-RlTNqY=.7e029cfc-d5be-4b32-8598-dd0ed3becec2@github.com>

On Thu, 18 Jan 2024 11:27:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> This is adding jdk21 to jdk test matrix and removing at8 branch, which is no longer used
> I had not added at7 branch.
> ---------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> 
> ### Error
> &nbsp;?? The pull request body must not be empty.
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/asmtools.git pull/72/head:pull/72` \
> `$ git checkout pull/72`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/72` \
> `$ git pull https://git.openjdk.org/asmtools.git pull/72/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 72`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 72`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/asmtools/pull/72.diff">https://git.openjdk.org/asmtools/pull/72.diff</a>
> 
> </details>

@lkuskov afik this PR is ok. IDK why the GH do not run here. In my fork, it run correctly under  jdk21

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/72#issuecomment-1948373134

From lkuskov at openjdk.org  Tue Feb 20 01:15:03 2024
From: lkuskov at openjdk.org (Leonid Kuskov)
Date: Tue, 20 Feb 2024 01:15:03 GMT
Subject: RFR: added jdk21 to test matrix
In-Reply-To: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
References: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
Message-ID: <EFLnc6hDBbOawFQ7Ck-Pw0_N0z5LMDEwl5w7Y_s_Jk0=.143f1dd8-46bc-45a1-8630-624e06201d18@github.com>

On Thu, 18 Jan 2024 11:27:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> This is adding jdk21 to jdk test matrix and removing at8 branch, which is no longer used
> I had not added at7 branch.
> ---------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> 
> ### Error
> &nbsp;?? The pull request body must not be empty.
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/asmtools.git pull/72/head:pull/72` \
> `$ git checkout pull/72`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/72` \
> `$ git pull https://git.openjdk.org/asmtools.git pull/72/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 72`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 72`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/asmtools/pull/72.diff">https://git.openjdk.org/asmtools/pull/72.diff</a>
> 
> </details>

LGTM! Please integrate

-------------

PR Comment: https://git.openjdk.org/asmtools/pull/72#issuecomment-1953337464

From jvanek at openjdk.org  Tue Feb 20 18:48:07 2024
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Tue, 20 Feb 2024 18:48:07 GMT
Subject: Integrated: added jdk21 to test matrix
In-Reply-To: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
References: <7PG_dOzHezU1Ai4FJ6FRoi_CmzgeDStPYQ8SrbEixjA=.92f32e1c-ff0f-416b-93ab-15f9786fa004@github.com>
Message-ID: <QGUB8Be0gN6RDLvlEj8U4mCjWPK5eKGhQ_T8PQX9XaU=.7300fefc-2779-4c44-b239-73f6ba049c78@github.com>

On Thu, 18 Jan 2024 11:27:54 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> This is adding jdk21 to jdk test matrix and removing at8 branch, which is no longer used
> I had not added at7 branch.
> ---------
> ### Progress
> - [x] Change must not contain extraneous whitespace
> 
> ### Error
> &nbsp;?? The pull request body must not be empty.
> 
> ### Reviewing
> <details><summary>Using <code>git</code></summary>
> 
> Checkout this PR locally: \
> `$ git fetch https://git.openjdk.org/asmtools.git pull/72/head:pull/72` \
> `$ git checkout pull/72`
> 
> Update a local copy of the PR: \
> `$ git checkout pull/72` \
> `$ git pull https://git.openjdk.org/asmtools.git pull/72/head`
> 
> </details>
> <details><summary>Using Skara CLI tools</summary>
> 
> Checkout this PR locally: \
> `$ git pr checkout 72`
> 
> View PR using the GUI difftool: \
> `$ git pr show -t 72`
> 
> </details>
> <details><summary>Using diff file</summary>
> 
> Download this PR as a diff file: \
> <a href="https://git.openjdk.org/asmtools/pull/72.diff">https://git.openjdk.org/asmtools/pull/72.diff</a>
> 
> </details>

This pull request has now been integrated.

Changeset: 7ea57726
Author:    Ji?? Van?k <jvanek at openjdk.org>
Committer: Leonid Kuskov <lkuskov at openjdk.org>
URL:       https://git.openjdk.org/asmtools/commit/7ea57726a181b819c4b6331b19160c4fce238b11
Stats:     3 lines in 1 file changed: 0 ins; 0 del; 3 mod

added jdk21 to test matrix

-------------

PR: https://git.openjdk.org/asmtools/pull/72